[PATCH v6 0/2] net: tulip: add checks to avoid OOB access

2020-03-23 Thread P J P
From: Prasad J Pandit Hello, * This series adds checks to avoid potential OOB access and infinite loop issues while processing rx/tx data. * Tulip tx descriptors are capped at 128 to avoid infinite loop in tulip_xmit_list_update(), wrt Tulip kernel driver ->

[PATCH v6 1/2] net: tulip: check frame size and r/w data length

2020-03-23 Thread P J P
From: Prasad J Pandit Tulip network driver while copying tx/rx buffers does not check frame size against r/w data length. This may lead to OOB buffer access. Add check to avoid it. Limit iterations over descriptors to avoid potential infinite loop issue in tulip_xmit_list_update. Reported-by:

Re: [PATCH v4 2/2] tests/bios-tables-test: add smbios cpu speed test

2020-03-23 Thread Laszlo Ersek
On 03/19/20 14:30, Igor Mammedov wrote: > On Wed, 18 Mar 2020 14:48:20 +0800 > Heyi Guo wrote: > >> Add smbios type 4 CPU speed check for we added new options to set >> smbios type 4 "max speed" and "current speed". The default value >> should be 2000 when no option is specified, just as the old

Re: [PATCH 00/13] microvm: add acpi support

2020-03-23 Thread Igor Mammedov
On Mon, 23 Mar 2020 13:09:48 +0100 Gerd Hoffmann wrote: > On Mon, Mar 23, 2020 at 06:51:10AM -0400, Michael S. Tsirkin wrote: > > On Thu, Mar 19, 2020 at 09:01:04AM +0100, Gerd Hoffmann wrote: > > > I know that not supporting ACPI in microvm is intentional. If you still > > > don't want ACPI

Re: [PATCH 00/13] microvm: add acpi support

2020-03-23 Thread Gerd Hoffmann
On Mon, Mar 23, 2020 at 06:51:10AM -0400, Michael S. Tsirkin wrote: > On Thu, Mar 19, 2020 at 09:01:04AM +0100, Gerd Hoffmann wrote: > > I know that not supporting ACPI in microvm is intentional. If you still > > don't want ACPI this is perfectly fine, you can use the usual -no-acpi > > switch to

[PATCH] hmp/vnc: Fix info vnc list leak

2020-03-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" We're iterating the list, and then freeing the iteration pointer rather than the list head. Fixes: 0a9667ecdb6d ("hmp: Update info vnc") Reported-by: Coverity (CID 1421932) Signed-off-by: Dr. David Alan Gilbert --- monitor/hmp-cmds.c | 5 +++-- 1 file changed, 3

Re: [PATCH v8 3/4] qcow2: add zstd cluster compression

2020-03-23 Thread Vladimir Sementsov-Ogievskiy
23.03.2020 13:20, Denis Plotnikov wrote: On 23.03.2020 11:44, Vladimir Sementsov-Ogievskiy wrote: 21.03.2020 17:34, Denis Plotnikov wrote: zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in

Re: [PATCH v14 Kernel 2/7] vfio iommu: Remove atomicity of ref_count of pinned pages

2020-03-23 Thread Auger Eric
Hi Kirti, On 3/18/20 8:41 PM, Kirti Wankhede wrote: > vfio_pfn.ref_count is always updated by holding iommu->lock, using atomic > variable is overkill. > > Signed-off-by: Kirti Wankhede > Reviewed-by: Neo Jia > --- > drivers/vfio/vfio_iommu_type1.c | 9 + > 1 file changed, 5

Re: Coverity CID 1421984

2020-03-23 Thread Philippe Mathieu-Daudé
Cc'ing qemu-ppc since this is restricted to the aCube Sam460ex board. On 3/23/20 12:46 PM, Max Reitz wrote: Hi, I was triaging new Coverity block layer reports today, and one that seemed like a real bug was CID 1421984: It complains about a memleak in sii3112_pci_realize() in

[Bug 1867519] Re: qemu 4.2 segfaults on VF detach

2020-03-23 Thread Christian Ehrhardt 
** Merge proposal unlinked: https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/381033 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1867519 Title: qemu 4.2 segfaults on

Re: [PATCH-for-5.0 2/3] virtio: Document virtqueue_pop()

2020-03-23 Thread Marc-André Lureau
On Mon, Mar 23, 2020 at 12:30 PM Philippe Mathieu-Daudé wrote: > > Document that virtqueue_pop() returned memory must be released > with free(). > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau > --- > include/hw/virtio/virtio.h | 8 > 1 file changed, 8

Re: [PATCH-for-5.0 1/3] vhost-user-gpu: Release memory returned by vu_queue_pop() with free()

2020-03-23 Thread Marc-André Lureau
On Mon, Mar 23, 2020 at 12:29 PM Philippe Mathieu-Daudé wrote: > > vu_queue_pop() returns memory that must be freed with free(). > > Cc: qemu-sta...@nongnu.org > Reported-by: Coverity (CID 1421887 ALLOC_FREE_MISMATCH) > Suggested-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé

[Bug 1867519] Re: qemu 4.2 segfaults on VF detach

2020-03-23 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/381033 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1867519 Title: qemu 4.2 segfaults on VF

Re: [PULL v3 1/1] slirp: update submodule to v4.2.0+

2020-03-23 Thread Marc-André Lureau
Hi On Mon, Mar 23, 2020 at 12:40 PM Alex Bennée wrote: > > > Marc-André Lureau writes: > > > git shortlog > > 126c04acbabd7ad32c2b018fe10dfac2a3bc1210..55ab21c9a36852915b81f1b41ebaf3b6509dd8ba > > > > > build-sys: make libslirp-version.h depend on Makefile > > FWIW I ran into a build

Coverity CID 1421984

2020-03-23 Thread Max Reitz
Hi, I was triaging new Coverity block layer reports today, and one that seemed like a real bug was CID 1421984: It complains about a memleak in sii3112_pci_realize() in hw/ide/sii3112.c, specifically about @irq being leaked (it’s allocated by qemu_allocate_irqs(), but never put anywhere or

Re: [PATCH] linux-user, configure: improve syscall_nr.h dependencies checking

2020-03-23 Thread Philippe Mathieu-Daudé
On 3/23/20 12:41 PM, Laurent Vivier wrote: This is mostly a fix for in-tree build. It removes errors on .d directories: grep: ./.gitlab-ci.d: Is a directory grep: ./scripts/qemu-guest-agent/fsfreeze-hook.d: Is a directory and improves performance by only checking -linux-user

Re: [PATCH v14 Kernel 1/7] vfio: KABI for migration interface for device state

2020-03-23 Thread Auger Eric
Hi Kirti, On 3/18/20 8:41 PM, Kirti Wankhede wrote: > - Defined MIGRATION region type and sub-type. > > - Defined vfio_device_migration_info structure which will be placed at the > 0th offset of migration region to get/set VFIO device related > information. Defined members of structure and

[PATCH] linux-user, configure: improve syscall_nr.h dependencies checking

2020-03-23 Thread Laurent Vivier
This is mostly a fix for in-tree build. It removes errors on .d directories: grep: ./.gitlab-ci.d: Is a directory grep: ./scripts/qemu-guest-agent/fsfreeze-hook.d: Is a directory and improves performance by only checking -linux-user directories. Reported-by: BALATON Zoltan Tested-by:

Re: [PATCH] block: Avoid memleak on qcow2 image info failure

2020-03-23 Thread Andrey Shinkevich
From: Eric Blake Sent: Friday, March 20, 2020 9:36 PM To: qemu-devel@nongnu.org Cc: peter.mayd...@linaro.org ; Andrey Shinkevich ; Kevin Wolf ; Max Reitz ; open list:qcow2 Subject: [PATCH] block: Avoid memleak on qcow2 image info failure If we fail to get

Re: [PULL v3 1/1] slirp: update submodule to v4.2.0+

2020-03-23 Thread Alex Bennée
Marc-André Lureau writes: > git shortlog > 126c04acbabd7ad32c2b018fe10dfac2a3bc1210..55ab21c9a36852915b81f1b41ebaf3b6509dd8ba > > build-sys: make libslirp-version.h depend on Makefile FWIW I ran into a build error when I updated to the latest tree. It was failing while building

[PATCH v4 0/2] target/arm: kvm: Support for KVM DABT with no valid ISS

2020-03-23 Thread Beata Michalska
Some of the ARMv7 & ARMv8 load/store instructions might trigger a data abort exception with no valid ISS info to be decoded. The lack of decode info makes it at least tricky to emulate the instruction which is one of the (many) reasons why KVM will not even try to do so. So far, if a guest made

[PATCH v4 1/2] target/arm: kvm: Handle DABT with no valid ISS

2020-03-23 Thread Beata Michalska
On ARMv7 & ARMv8 some load/store instructions might trigger a data abort exception with no valid ISS info to be decoded. The lack of decode info makes it at least tricky to emulate those instruction which is one of the (many) reasons why KVM will not even try to do so. Add support for handling

[PATCH v4 2/2] target/arm: kvm: Handle potential issue with dabt injection

2020-03-23 Thread Beata Michalska
Injecting external data abort through KVM might trigger an issue on kernels that do not get updated to include the KVM fix. For those and aarch32 guests, the injected abort gets misconfigured to be an implementation defined exception. This leads to the guest repeatedly re-running the faulting

[PATCH-for-5.0 3/3] virtio-gpu: Release memory returned by virtqueue_pop() with free()

2020-03-23 Thread Philippe Mathieu-Daudé
As virtio_gpu_handle_ctrl() fills the cmdq calling virtqueue_pop(), we need to release it with free() in virtio_gpu_reset(). virtio_gpu_handle_ctrl() allocates memory calling virtqueue_pop(), release it in virtio_gpu_process_cmdq() with free(). virtio_gpu_process_cmdq() move commands from cmdq

[PATCH-for-5.0 1/3] vhost-user-gpu: Release memory returned by vu_queue_pop() with free()

2020-03-23 Thread Philippe Mathieu-Daudé
vu_queue_pop() returns memory that must be freed with free(). Cc: qemu-sta...@nongnu.org Reported-by: Coverity (CID 1421887 ALLOC_FREE_MISMATCH) Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- contrib/vhost-user-gpu/vhost-user-gpu.c | 4 ++--

[PATCH-for-5.0 2/3] virtio: Document virtqueue_pop()

2020-03-23 Thread Philippe Mathieu-Daudé
Document that virtqueue_pop() returned memory must be released with free(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/virtio/virtio.h | 8 1 file changed, 8 insertions(+) diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h index b69d517496..c6e3bfc500

[PATCH-for-5.0 0/3] virtio,vhost-gpu: Release memory returned by malloc() with free()

2020-03-23 Thread Philippe Mathieu-Daudé
Coverity reported a ALLOC_FREE_MISMATCH in vg_handle_cursor(), because the memory returned by vu_queue_pop() is allocated with malloc(). Fix it. Similar error occurs with virtio. Document and fix. Philippe Mathieu-Daudé (3): vhost-user-gpu: Release memory returned by vu_queue_pop() with free()

Re: [PATCH] qemu-ga: document vsock-listen in the man page

2020-03-23 Thread Stefano Garzarella
On Mon, Mar 23, 2020 at 11:04:08AM +, Stefan Hajnoczi wrote: > Although qemu-ga has supported vsock since 2016 it was not documented on > the man page. > > Also add the socket address representation to the qga --help output. > > Fixes: 586ef5dee77180fc32e33bc08051600030630239 >("qga:

Re: Qemu API documentation

2020-03-23 Thread Priyamvad Acharya
Thanks for the information. On Fri, 20 Mar 2020 at 16:47, Alex Bennée wrote: > > Priyamvad Acharya writes: > > > Thansk, I will check it out. > > > > To make my device I have used following link as reference > > > > >

Re: [PATCH] qemu-ga: document vsock-listen in the man page

2020-03-23 Thread Marc-André Lureau
Hi On Mon, Mar 23, 2020 at 12:04 PM Stefan Hajnoczi wrote: > > Although qemu-ga has supported vsock since 2016 it was not documented on > the man page. > > Also add the socket address representation to the qga --help output. > > Fixes: 586ef5dee77180fc32e33bc08051600030630239 >("qga: add

Re: [PATCH-for-5.0 1/2] hw/acpi/piix4: Add 'system-hotplug-support' property

2020-03-23 Thread Marcelo Tosatti
On Mon, Mar 23, 2020 at 09:05:06AM +0100, Paolo Bonzini wrote: > On 22/03/20 17:27, Philippe Mathieu-Daudé wrote: > >>> > >> That 'ugly' is typically used within QEMU to deal with such things > >> probably due to its low complexity. > > > > OK. Can you point me to the documentation for this

Re: [PATCH 0/6] dwc-hsotg (aka dwc2) USB host contoller emulation

2020-03-23 Thread Gerd Hoffmann
Hi, > 1) I have used printf-based debug statements while developing the >code, and have not implemented any tracing statements. I'm not >sure if that is considered acceptable for new code? Please use tracepoints. I'd suggest to use the "log" trace backend which comes very close to

Re: [PATCH-for-5.0] tools/virtiofsd/passthrough_ll: Fix double close()

2020-03-23 Thread Stefan Hajnoczi
On Sat, Mar 21, 2020 at 01:06:54PM +0100, Philippe Mathieu-Daudé wrote: > On success, the fdopendir() call closes fd. Later on the error > path we try to close an already-closed fd. This can lead to > use-after-free. Fix by only closing the fd if the fdopendir() > call failed. > > Cc:

Re: [PATCH] aio-posix: fix io_uring with external events

2020-03-23 Thread Stefan Hajnoczi
On Thu, Mar 19, 2020 at 04:35:59PM +, Stefan Hajnoczi wrote: > When external event sources are disabled fdmon-io_uring falls back to > fdmon-poll. The ->need_wait() callback needs to watch for this so it > can return true when external event sources are disabled. > > It is also necessary to

[PATCH] qemu-ga: document vsock-listen in the man page

2020-03-23 Thread Stefan Hajnoczi
Although qemu-ga has supported vsock since 2016 it was not documented on the man page. Also add the socket address representation to the qga --help output. Fixes: 586ef5dee77180fc32e33bc08051600030630239 ("qga: add vsock-listen method") Signed-off-by: Stefan Hajnoczi ---

Re: [Qemu-devel] [PULL 5/9] contrib: add vhost-user-gpu

2020-03-23 Thread Philippe Mathieu-Daudé
On 3/23/20 11:11 AM, Peter Maydell wrote: On Wed, 29 May 2019 at 05:42, Gerd Hoffmann wrote: From: Marc-André Lureau Add a vhost-user gpu backend, based on virtio-gpu/3d device. It is associated with a vhost-user-gpu device. Various TODO and nice to have items: - multi-head support - crash

Re: [PULL 11/26] vfio/spapr: Allow backing bigger guest IOMMU pages with smaller physical pages

2020-03-23 Thread Peter Maydell
On Tue, 21 Aug 2018 at 05:33, David Gibson wrote: > > From: Alexey Kardashevskiy > > At the moment the PPC64/pseries guest only supports 4K/64K/16M IOMMU > pages and POWER8 CPU supports the exact same set of page size so > so far things worked fine. > > However POWER9 supports different set of

Re: [PATCH 00/13] microvm: add acpi support

2020-03-23 Thread Michael S. Tsirkin
On Thu, Mar 19, 2020 at 09:01:04AM +0100, Gerd Hoffmann wrote: > I know that not supporting ACPI in microvm is intentional. If you still > don't want ACPI this is perfectly fine, you can use the usual -no-acpi > switch to toggle ACPI support. > > These are the advantages you are going to loose

[PATCH v4 1/3] Acceptance test: adds param 'address' in _get_free_port

2020-03-23 Thread Oksana Vohchana
In the migration test function _get_free_port works only for localhost, but in the case to use migration through an RDMA we need to get a free port on the configured network RDMA-interface. This patch is the start for another migration option Signed-off-by: Oksana Vohchana ---

[PATCH v4 3/3] Acceptance test: provides to use RDMA transport for migration test

2020-03-23 Thread Oksana Vohchana
Adds test for RDMA migration check Signed-off-by: Oksana Vohchana --- tests/acceptance/migration.py | 12 1 file changed, 12 insertions(+) diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py index 59144f18fd..c96da1dd4b 100644 ---

[PATCH v4 2/3] Acceptance test: provides new functions

2020-03-23 Thread Oksana Vohchana
Provides new functions related to the rdma migration test Adds functions to check if service RDMA is enabled and gets the ip address on the interface where it was configured Signed-off-by: Oksana Vohchana --- tests/acceptance/migration.py | 32 1 file changed,

[PATCH v4 0/3] Acceptance test: Extension of migration tests

2020-03-23 Thread Oksana Vohchana
This series adds a new migration test through RDMA. To correct uses of migration need to add a new function to work with RDMA service. And as a part of migration tests, the series makes small updates to EXEC migration and to _get_free_port function V2: - improves commit message in Acceptance

Re: [Qemu-devel] [PATCH v5 07/10] hw/rdma: Free all receive buffers when QP is destroyed

2020-03-23 Thread Peter Maydell
On Sun, 10 Mar 2019 at 09:25, Yuval Shaia wrote: > > When QP is destroyed the backend QP is destroyed as well. This ensures > we clean all received buffer we posted to it. > However, a contexts of these buffers are still remain in the device. > Fix it by maintaining a list of buffer's context and

Re: [PATCH v5 0/3] net: tulip: add checks to avoid OOB access

2020-03-23 Thread Jason Wang
On 2020/3/23 下午1:40, P J P wrote: +-- On Mon, 23 Mar 2020, P J P wrote --+ | +-- On Mon, 23 Mar 2020, Jason Wang wrote --+ | | hw/net/tulip.c:305:20: error: initialization of ‘_Bool (*)(NetClientState *)’ | | {aka ‘_Bool (*)(struct NetClientState *)’} from incompatible pointer type ‘int | |

Re: [PATCH 13/13] microvm/acpi: use GSI 16-23 for virtio

2020-03-23 Thread Gerd Hoffmann
On Fri, Mar 20, 2020 at 11:30:16AM -0400, Konrad Rzeszutek Wilk wrote: > On Thu, Mar 19, 2020 at 09:01:17AM +0100, Gerd Hoffmann wrote: > > With ACPI enabled and IO-APIC being properly declared in the ACPI tables > > we can use interrupt lines 16-23 for virtio and avoid shared interrupts. > > 7

Re: deprecation of in-tree builds

2020-03-23 Thread Daniel P . Berrangé
On Sun, Mar 22, 2020 at 08:14:24PM +, Peter Maydell wrote: > To be clear, I'm not saying we should pull the rug out > from anybody. I'm saying: > * we should clearly say what our plans are, with a >long warning if we can reasonably give longer warning > * if there's anything that we

Re: [PATCH v8 3/4] qcow2: add zstd cluster compression

2020-03-23 Thread Denis Plotnikov
On 23.03.2020 11:44, Vladimir Sementsov-Ogievskiy wrote: 21.03.2020 17:34, Denis Plotnikov wrote: zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment,

Re: [Qemu-devel] [PULL 5/9] contrib: add vhost-user-gpu

2020-03-23 Thread Peter Maydell
On Wed, 29 May 2019 at 05:42, Gerd Hoffmann wrote: > > From: Marc-André Lureau > > Add a vhost-user gpu backend, based on virtio-gpu/3d device. It is > associated with a vhost-user-gpu device. > > Various TODO and nice to have items: > - multi-head support > - crash & resume handling > -

Re: [PATCH-for-5.0 v2 2/4] tests/test-util-sockets: Skip test on non-x86 Travis containers

2020-03-23 Thread Philippe Mathieu-Daudé
On 3/23/20 10:48 AM, Daniel P. Berrangé wrote: On Fri, Mar 20, 2020 at 12:39:58PM +0100, Cornelia Huck wrote: On Wed, 18 Mar 2020 23:27:15 +0100 Philippe Mathieu-Daudé wrote: Similarly to commit 4f370b1098, test-util-sockets fails in restricted non-x86 Travis containers since they apparently

Re: [PATCH-for-5.0 v2 2/4] tests/docker: Install gcrypt devel package in Debian image

2020-03-23 Thread Philippe Mathieu-Daudé
On 3/22/20 1:01 PM, Philippe Mathieu-Daudé wrote: In commit 6f8bbb374be we enabled building with the gcrypt library on the the Debian 'x86 host', which was based on Debian Stretch. Later in commit 698a71edbed we upgraded the Debian base image to Buster. Aleksandar, is this updated description

Re: [PATCH-for-5.0 v2 0/4] tests/docker: Fixes for 5.0

2020-03-23 Thread Philippe Mathieu-Daudé
On 3/23/20 10:58 AM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: Easy fixes for our Docker images. Queued to testing/next, thanks. Thanks, but I think Aleksandar wanted to review patch 2/4 "tests/docker: Install gcrypt devel package in Debian image" and now I notice I forgot to

Re: [PATCH] .travis.yml: Add a KVM-only s390x job

2020-03-23 Thread Philippe Mathieu-Daudé
On 3/23/20 10:59 AM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: Add a job to build QEMU on s390x with TCG disabled, so this configuration won't bitrot over time. Queued to testing/next, thanks. Thanks! This only tests the build though - we don't exercise KVM doing this. Yes,

Re: [PATCH] .travis.yml: Add a KVM-only s390x job

2020-03-23 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Add a job to build QEMU on s390x with TCG disabled, so > this configuration won't bitrot over time. Queued to testing/next, thanks. This only tests the build though - we don't exercise KVM doing this. > > This job is quick, running check-unit: Ran for 5 min

Re: [PATCH v9 0/9] virtio-iommu: VFIO integration

2020-03-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200323084617.1782-1-bbhush...@marvell.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH-for-5.0 v2 0/4] tests/docker: Fixes for 5.0

2020-03-23 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Easy fixes for our Docker images. Queued to testing/next, thanks. > > Since v1: > - Reword gcrypt patch description (requested by Aleksandar) > > Philippe Mathieu-Daudé (4): > tests/docker: Keep package list sorted > tests/docker: Install gcrypt devel

Re: [PATCH v9 0/9] virtio-iommu: VFIO integration

2020-03-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200323084617.1782-1-bbhush...@marvell.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v9 0/9] virtio-iommu: VFIO integration Message-id: 20200323084617.1782-1-bbhush...@marvell.com

Re: discard and v2 qcow2 images

2020-03-23 Thread Daniel P . Berrangé
On Fri, Mar 20, 2020 at 02:35:44PM -0500, Eric Blake wrote: > On 3/20/20 1:58 PM, Alberto Garcia wrote: > > Hi, > > > > when full_discard is false in discard_in_l2_slice() then the selected > > cluster should be deallocated and it should read back as zeroes. This > > is done by clearing the

Re: [PATCH-for-5.0 v2 2/4] tests/test-util-sockets: Skip test on non-x86 Travis containers

2020-03-23 Thread Daniel P . Berrangé
On Fri, Mar 20, 2020 at 12:39:58PM +0100, Cornelia Huck wrote: > On Wed, 18 Mar 2020 23:27:15 +0100 > Philippe Mathieu-Daudé wrote: > > > Similarly to commit 4f370b1098, test-util-sockets fails in > > restricted non-x86 Travis containers since they apparently > > blacklisted some required system

Re: [PATCH v3 2/3] Acceptance test: provides new functions

2020-03-23 Thread Oksana Voshchana
Hi Willian I totally agree with your comments I'll move those functions outside the class Let me update and repost the patch Thanks On Fri, Mar 20, 2020 at 6:22 PM Willian Rampazzo wrote: > Hi Oksana, > > On Fri, Mar 20, 2020 at 12:15 PM Oksana Vohchana > wrote: > > > > Provides new functions

Re: [PATCH 0/3] target/arm: Coverity tweaks

2020-03-23 Thread Peter Maydell
On Fri, 20 Mar 2020 at 16:06, Richard Henderson wrote: > > Only the first of these appears to be a real bug. > The other two are adjustments to help satisfy Coverity. > > > r~ > > > Richard Henderson (3): > target/arm: Rearrange disabled check for watchpoints > target/arm: Assert immh != 0 in

Re: [PATCH RFC 2/2] qapi: Make section headings start a new doc comment block

2020-03-23 Thread Peter Maydell
On Fri, 20 Mar 2020 at 09:18, Markus Armbruster wrote: > > Our current QAPI doc-comment markup allows section headers (introduced > with a leading '=' or '==') anywhere in a free-form documentation > comment. This works for Texinfo because the generator simply prints a > Texinfo section command

Re: [PATCH] aspeed/smc: Fix DMA support for AST2600

2020-03-23 Thread Peter Maydell
On Fri, 20 Mar 2020 at 05:39, Cédric Le Goater wrote: > > Recent firmwares uses SPI DMA transfers in U-Boot to load the > different images (kernel, initrd, dtb) in the SoC DRAM. The AST2600 > FMC model is missing the masks to be applied on the DMA registers > which resulted in incorrect values.

Re: [PATCH] hw/arm/bcm283x: Correct the license text

2020-03-23 Thread Peter Maydell
On Thu, 12 Mar 2020 at 21:35, Philippe Mathieu-Daudé wrote: > > The license is the 'GNU General Public License v2.0 or later', > not 'and': > > This program is free software; you can redistribute it and/ori > modify it under the terms of the GNU General Public License as > published by the

Re: [PULL v3 0/1] Slirp patches

2020-03-23 Thread Peter Maydell
On Sun, 22 Mar 2020 at 17:16, Marc-André Lureau wrote: > > The following changes since commit f57587c7d47b35b2d9b31def3a74d81bdb5475d7: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-03-17' > into staging (2020-03-19 10:18:07 +) > > are available in the Git repository

[PATCH v9 8/9] virtio-iommu: Implement probe request

2020-03-23 Thread Bharat Bhushan
This patch implements the PROBE request. Currently supported page size mask per endpoint is returned. Also append a NONE property in the end. Signed-off-by: Bharat Bhushan Signed-off-by: Eric Auger --- include/standard-headers/linux/virtio_iommu.h | 6 + hw/virtio/virtio-iommu.c

[PATCH v9 9/9] virtio-iommu: add iommu notifier memory-region

2020-03-23 Thread Bharat Bhushan
Finally add notify_flag_changed() to for memory-region access flag iommu flag change notifier Finally add the memory notifier Signed-off-by: Bharat Bhushan --- hw/virtio/virtio-iommu.c | 22 ++ hw/virtio/trace-events | 2 ++ 2 files changed, 24 insertions(+) diff --git

[PATCH v9 6/9] virtio-iommu: Call iommu notifier for attach/detach

2020-03-23 Thread Bharat Bhushan
iommu-notifier are called when a device is attached or detached to as address-space. This is needed for VFIO. Signed-off-by: Bharat Bhushan --- hw/virtio/virtio-iommu.c | 49 1 file changed, 49 insertions(+) diff --git a/hw/virtio/virtio-iommu.c

[PATCH v9 7/9] virtio-iommu: add iommu replay

2020-03-23 Thread Bharat Bhushan
Default replay does not work with virtio-iommu, so this patch provide virtio-iommu replay functionality. Signed-off-by: Bharat Bhushan --- hw/virtio/virtio-iommu.c | 44 hw/virtio/trace-events | 1 + 2 files changed, 45 insertions(+) diff --git

[PATCH v9 4/9] virtio-iommu: set supported page size mask

2020-03-23 Thread Bharat Bhushan
Add optional interface to set page size mask. Currently this is set global configuration and not per endpoint. Signed-off-by: Bharat Bhushan --- include/hw/virtio/virtio-iommu.h | 1 + hw/virtio/virtio-iommu.c | 9 + 2 files changed, 10 insertions(+) diff --git

[PATCH v9 5/9] virtio-iommu: Add iommu notifier for map/unmap

2020-03-23 Thread Bharat Bhushan
This patch extends VIRTIO_IOMMU_T_MAP/UNMAP request to notify registered iommu-notifier. Which will call vfio notifier to map/unmap region in iommu. Signed-off-by: Bharat Bhushan Signed-off-by: Eric Auger --- include/hw/virtio/virtio-iommu.h | 2 + hw/virtio/virtio-iommu.c | 67

[PATCH v9 0/9] virtio-iommu: VFIO integration

2020-03-23 Thread Bharat Bhushan
This patch series integrates VFIO with virtio-iommu. This is only applicable for PCI pass-through with virtio-iommu. This series is available at: https://github.com/bharat-bhushan-devel/qemu.git virtio-iommu-vfio-integration-v8 This is tested with assigning more than one pci devices to Virtual

[PATCH v9 3/9] vfio: set iommu page size as per host supported page size

2020-03-23 Thread Bharat Bhushan
Set iommu supported page size mask same as host Linux supported page size mask. Signed-off-by: Bharat Bhushan --- hw/vfio/common.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index c586edf47a..6ea50d696f 100644 --- a/hw/vfio/common.c +++

[PATCH v9 2/9] memory: Add interface to set iommu page size mask

2020-03-23 Thread Bharat Bhushan
Allow to set page size mask to be supported by iommu. This is required to expose page size mask compatible with host with virtio-iommu. Signed-off-by: Bharat Bhushan --- include/exec/memory.h | 20 memory.c | 10 ++ 2 files changed, 30 insertions(+)

[PATCH v9 1/9] hw/vfio/common: Remove error print on mmio region translation by viommu

2020-03-23 Thread Bharat Bhushan
On ARM, the MSI doorbell is translated by the virtual IOMMU. As such address_space_translate() returns the MSI controller MMIO region and we get an "iommu map to non memory area" message. Let's remove this latter. Signed-off-by: Eric Auger Signed-off-by: Bharat Bhushan --- hw/vfio/common.c | 2

Re: [PATCH v8 3/4] qcow2: add zstd cluster compression

2020-03-23 Thread Vladimir Sementsov-Ogievskiy
21.03.2020 17:34, Denis Plotnikov wrote: zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment, is the only compression method available. The performance

Re: [PATCH v8 4/8] virtio-iommu: set supported page size mask

2020-03-23 Thread Bharat Bhushan
Hi Eric/Jean, On Wed, Mar 18, 2020 at 8:05 PM Bharat Bhushan wrote: > > Hi Eric, > > On Wed, Mar 18, 2020 at 4:58 PM Auger Eric wrote: > > > > Hi Bharat, > > > > On 3/18/20 11:11 AM, Bharat Bhushan wrote: > > > Add optional interface to set page size mask. > > > Currently this is set global

[Bug 1868527] [NEW] alignment may overlap the TLB flags

2020-03-23 Thread Hansni Bu
Public bug reported: Hi, In QEMU-4.2.0, or git-9b26a610936deaf436af9b7e39e4b7f0a35e4409, alignment may overlap the TLB flags. For example, the alignment: MO_ALIGN_32, MO_ALIGN_32 = 5 << MO_ASHIFT, and the TLB flag: TLB_DISCARD_WRITE #define TLB_DISCARD_WRITE (1 << (TARGET_PAGE_BITS_MIN -

[PATCH v12] s390x: protvirt: Support unpack facility

2020-03-23 Thread Janosch Frank
The unpack facility provides the means to setup a protected guest. A protected guest cannot be introspected by the hypervisor or any user/administrator of the machine it is running on. Protected guests are encrypted at rest and need a special boot mechanism via diag308 subcode 8 and 10. Code 8

Re: [PATCH v11 03/16] s390x: protvirt: Support unpack facility

2020-03-23 Thread Janosch Frank
On 3/23/20 8:37 AM, Christian Borntraeger wrote: > > > On 23.03.20 08:15, Christian Borntraeger wrote: >> [...] >> +int s390_ipl_prepare_pv_header(void) +{ +IplParameterBlock *ipib = s390_ipl_get_iplb_pv(); +IPLBlockPV *ipib_pv = >pv; +void *hdr =

Re: [PATCH] hax: Windows doesn't like posix device names

2020-03-23 Thread Paolo Bonzini
On 22/03/20 22:02, Volker Rümelin wrote: > Patch acb9f95a7c "i386: Fix GCC warning with snprintf when HAX > is enabled" replaced Windows device names with posix device > names. Revert this. > > Fixes: acb9f95a7c "i386: Fix GCC warning with snprintf when HAX is enabled" > > Signed-off-by: Volker

[question]vhost-user: atuo fix network link broken during migration

2020-03-23 Thread yangke (J)
We find an issue when host mce trigger openvswitch(dpdk) restart in source host during guest migration, VM is still link down in frontend after migration, it cause the network in VM never be up again. virtio_net_load_device: /* nc.link_down can't be migrated, so infer link_down according

Re: [PATCH v5 09/60] target/riscv: vector single-width integer add and subtract

2020-03-23 Thread LIU Zhiwei
On 2020/3/14 13:25, Richard Henderson wrote: On 3/12/20 7:58 AM, LIU Zhiwei wrote: +if (a->vm && s->vl_eq_vlmax) { \ +tcg_gen_gvec_##GVSUF(8 << s->sew, vreg_ofs(s, a->rd), \ +vreg_ofs(s, a->rs2), vreg_ofs(s, a->rs1), \

Re: [PATCH-for-5.0 1/2] hw/acpi/piix4: Add 'system-hotplug-support' property

2020-03-23 Thread Paolo Bonzini
On 22/03/20 17:27, Philippe Mathieu-Daudé wrote: >>> >> That 'ugly' is typically used within QEMU to deal with such things >> probably due to its low complexity. > > OK. Can you point me to the documentation for this feature? I can find > reference of GPE in the ICH9, but I can't find where this

Re: [PATCH v8 1/4] qcow2: introduce compression type feature

2020-03-23 Thread Vladimir Sementsov-Ogievskiy
21.03.2020 17:34, Denis Plotnikov wrote: The patch adds some preparation parts for incompatible compression type feature to qcow2 allowing the use different compression methods for image clusters (de)compressing. It is implied that the compression type is set on the image creation and can be

Re: [PATCH v11 03/16] s390x: protvirt: Support unpack facility

2020-03-23 Thread Christian Borntraeger
On 23.03.20 08:15, Christian Borntraeger wrote: > [...] > >>> +int s390_ipl_prepare_pv_header(void) >>> +{ >>> +IplParameterBlock *ipib = s390_ipl_get_iplb_pv(); >>> +IPLBlockPV *ipib_pv = >pv; >>> +void *hdr = g_malloc(ipib_pv->pv_header_len); >>> +int rc; >>> + >>> +

Re: [PATCH v11 03/16] s390x: protvirt: Support unpack facility

2020-03-23 Thread Christian Borntraeger
[...] >> +int s390_ipl_prepare_pv_header(void) >> +{ >> +IplParameterBlock *ipib = s390_ipl_get_iplb_pv(); >> +IPLBlockPV *ipib_pv = >pv; >> +void *hdr = g_malloc(ipib_pv->pv_header_len); >> +int rc; >> + >> +cpu_physical_memory_read(ipib_pv->pv_header_addr, hdr, >> +

Re: [PATCH v6 04/61] target/riscv: add vector configure instruction

2020-03-23 Thread LIU Zhiwei
On 2020/3/23 14:51, Kito Cheng wrote: Hi Zhiwei: vsetvl and vsetvli seems like missing ISA checking before translate, this cause those 2 instructions can be executed even RVV not enable. My testing env is qemu riscv64-linux-user mode. Hi Kito, I think you are right. Thanks for pointing

Re: [PATCH] block: Avoid memleak on qcow2 image info failure

2020-03-23 Thread Vladimir Sementsov-Ogievskiy
20.03.2020 21:36, Eric Blake wrote: If we fail to get bitmap info, we must not leak the encryption info. Fixes: b8968c875f403 Fixes: Coverity CID 1421894 Signed-off-by: Eric Blake --- block/qcow2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow2.c b/block/qcow2.c index

Re: [PATCH v6 04/61] target/riscv: add vector configure instruction

2020-03-23 Thread Kito Cheng
Hi Zhiwei: vsetvl and vsetvli seems like missing ISA checking before translate, this cause those 2 instructions can be executed even RVV not enable. My testing env is qemu riscv64-linux-user mode. > diff --git a/target/riscv/insn_trans/trans_rvv.inc.c > b/target/riscv/insn_trans/trans_rvv.inc.c

Re: [PATCH v5 0/3] net: tulip: add checks to avoid OOB access

2020-03-23 Thread Li Qiang
Jason Wang 于2020年3月23日周一 上午11:44写道: > > On 2020/3/20 上午1:40, P J P wrote: > > From: Prasad J Pandit > > > > Hello, > > > > * This series adds checks to avoid potential OOB access and infinite loop > >issues while processing rx/tx data. > > > > * Tulip tx descriptors are capped at 128 to

<    1   2   3