Re: [PATCH v12 2/3] qcow2: Allow writing compressed data of multiple clusters

2020-04-09 Thread Vladimir Sementsov-Ogievskiy
10.04.2020 3:12, Andrey Shinkevich wrote: We could assign indices to the clusters/chunks and improve the algorithm to write them down on the disk in the same order adjacently. If you find it feasible for QEMU, I'd like to create a task for doing that, shall I? Compressed cluster occupy

[PATCH] hax: Add hax max vcpu IOCTL and support 64 vcpu

2020-04-09 Thread WangBowen
This commit tried to obtain max vcpu of haxm driver by calling HAX_IOCTL_CAP_MAX_VCPU before creating the vm so that if using hax as the accelerator and the smp value is larger than the haxm driver supported max value, the program will terminate. Previously, it will create vm and vcpu one by one

[PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-09 Thread Alexander Duyck
From: Alexander Duyck We need to make certain to advertise support for page poison tracking if we want to actually get data on if the guest will be poisoning pages. So if free page hinting is active we should add page poisoning support and let the guest disable it if it isn't using it. Page

Re: [PATCH v1] nrf51: Fix last GPIO CNF address

2020-04-09 Thread Andrew Jeffery
On Tue, 7 Apr 2020, at 18:20, Peter Maydell wrote: > On Tue, 7 Apr 2020 at 09:45, Joel Stanley wrote: > > On Tue, 7 Apr 2020 at 08:41, Peter Maydell wrote: > > > Do you have a link to this patch, please? I had a quick search through > > > my mailing list articles but couldn't see anything

[PATCH v19 QEMU 0/4] virtio-balloon: add support for free page reporting

2020-04-09 Thread Alexander Duyck
This series provides an asynchronous means of reporting free guest pages to QEMU through virtio-balloon so that the memory associated with those pages can be dropped and reused by other processes and/or guests on the host. Using this it is possible to avoid unnecessary I/O to disk and greatly

[PATCH v19 QEMU 2/4] linux-headers: update to contain virito-balloon free page reporting

2020-04-09 Thread Alexander Duyck
From: Alexander Duyck Sync the latest upstream changes for free page reporting. To be replaced by a full linux header sync. Signed-off-by: Alexander Duyck --- include/standard-headers/linux/virtio_balloon.h |1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v19 QEMU 4/4] memory: Do not allow direct write access to rom_device regions

2020-04-09 Thread Alexander Duyck
From: Alexander Duyck According to the documentation in memory.h a ROM memory region will be backed by RAM for reads, but is supposed to go through a callback for writes. Currently we were not checking for the existence of the rom_device flag when determining if we could perform a direct write

[PATCH v19 QEMU 3/4] virtio-balloon: Provide an interface for free page reporting

2020-04-09 Thread Alexander Duyck
From: Alexander Duyck Add support for free page reporting. The idea is to function very similar to how the balloon works in that we basically end up madvising the page as not being used. However we don't really need to bother with any deflate type logic since the page will be faulted back into

Re: [PATCH v18 QEMU 3/3] virtio-balloon: Provide a interface for free page reporting

2020-04-09 Thread Alexander Duyck
On Thu, Apr 9, 2020 at 10:35 AM David Hildenbrand wrote: > On 09.04.20 19:34, Alexander Duyck wrote: > >>> hw/virtio/virtio-balloon.c | 48 > >>> +++- > >>> include/hw/virtio/virtio-balloon.h |2 +- > >>> 2 files changed, 47 insertions(+), 3

[Bug 1863441] Re: cmd_mode_sense always reports 0x70, no CDROM present

2020-04-09 Thread John Snow
Roger that, thanks! I don't think we're very careful about which version we try to emulate. In practice it's "Whatever seems to work across the largest swatch of guest operating systems simultaneously". If this comes up again, feel free to file against a specific guest OS that appears to be

Re: [PATCH] Fixed IPv6 payload lenght without jumbo option

2020-04-09 Thread Jason Wang
On 2020/4/9 下午9:35, Andrew Melnichenko wrote: > Do we support ipv6 segmentation then? No, but - if the backend supports big frames there is an issue that IPv6 plen doesn't have valid value. Actually, It's a good idea to add IPv6 fragmentation - I would do it later. Right, another

[PATCH v5 1/1] colo-compare: Fix memory leak in packet_enqueue()

2020-04-09 Thread Derek Su
The patch is to fix the "pkt" memory leak in packet_enqueue(). The allocated "pkt" needs to be freed if the colo compare primary or secondary queue is too big. Replace the error_report of full queue with a trace event. Signed-off-by: Derek Su --- net/colo-compare.c | 23 +++

[PATCH v5 0/1] COLO: handling of the full primary or secondary queue

2020-04-09 Thread Derek Su
The series is to handle the full primary or secondary queue in colo-compare. Fix the "pkt" memory leak in packet_enqueue(). Reproduce steps: 1. Setup PVM and SVM both with NIC e1000 by the steps descripted in the wiki qemu/COLO 2. Run "iperf3 -s" in PVM 3. Run "iperf3 -c -t 7200" in client

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-09 Thread Liu, Jingqi
On 4/10/2020 12:46 AM, Dan Williams wrote: On Thu, Apr 9, 2020 at 7:33 AM Liu, Jingqi wrote: On 4/8/2020 5:42 PM, Joao Martins wrote: On 4/8/20 3:25 AM, Liu, Jingqi wrote: On 4/8/2020 2:28 AM, Joao Martins wrote: On 4/7/20 5:55 PM, Dan Williams wrote: On Tue, Apr 7, 2020 at 4:01 AM Joao

Re: [RFC][PATCH v2 0/3] IVSHMEM version 2 device for QEMU

2020-04-09 Thread Liang Yan
On 4/9/20 10:11 AM, Jan Kiszka wrote: > On 09.04.20 15:52, Liang Yan wrote: >> >> >> On 1/7/20 9:36 AM, Jan Kiszka wrote: >>> Overdue update of the ivshmem 2.0 device model as presented at [1]. >>> >>> Changes in v2: >>>   - changed PCI device ID to Siemens-granted one, >>>     adjusted PCI

Re: [PATCH v12 2/3] qcow2: Allow writing compressed data of multiple clusters

2020-04-09 Thread Andrey Shinkevich
We could assign indices to the clusters/chunks and improve the algorithm to write them down on the disk in the same order adjacently. If you find it feasible for QEMU, I'd like to create a task for doing that, shall I? Andrey From: Vladimir Sementsov-Ogievskiy

Re: [Bug 1871842] [NEW] AMD CPUID leaf 0x8000'0008 reported number of cores inconsistent with ACPI.MADT

2020-04-09 Thread Babu Moger
Philipp, Can you please check if this patch works for you. diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 90ffc5f..e467fee 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -5831,10 +5831,17 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count, }

Re: [PATCH for 5.0-rc3 v1 00/11] more random fixes

2020-04-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200409211529.5269-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH for 5.0-rc3 v1 00/11] more random fixes Message-id:

[Bug 1871798] Re: Fails to start on Windows host without explicit --disable-pie

2020-04-09 Thread James Le Cuirot
Tested and working. Thank you! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1871798 Title: Fails to start on Windows host without explicit --disable-pie Status in QEMU: Incomplete Bug

Re: [PATCH v1 07/11] configure: disable PIE for Windows builds

2020-04-09 Thread Howard Spoelstra
On Thu, Apr 9, 2020 at 11:18 PM Alex Bennée wrote: > It seems on some compilers the test can pass but still give you > broken binaries. > > [AJB untested - please could windows users test] > > Fixes: d2cd29e30736 > Fixes: https://bugs.launchpad.net/qemu/+bug/1871798 > Cc: Bug 1871798

[PATCH v1 10/11] linux-user: fix /proc/self/stat handling

2020-04-09 Thread Alex Bennée
In the original bug report long files names in Guix caused /proc/self/stat be truncated without the trailing ") " as specified in proc manpage which says: (2) comm %s The filename of the executable, in parentheses. This is visible whether or not the executable is

[PATCH v1 06/11] configure: redirect sphinx-build check to config.log

2020-04-09 Thread Alex Bennée
Otherwise it's hard to debug whats going on. Signed-off-by: Alex Bennée --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 233c671aaa9..a207cce82bc 100755 --- a/configure +++ b/configure @@ -4936,7 +4936,7 @@ has_sphinx_build() { #

[PATCH v1 09/11] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

2020-04-09 Thread Alex Bennée
From: Peter Xu We should only pass in gdb_get_reg16() with the GByteArray* object itself, no need to shift. Without this patch, gdb remote attach will crash QEMU. Fixes: a010bdbe719 ("extend GByteArray to read register helpers") Signed-off-by: Peter Xu Reviewed-by: Philippe Mathieu-Daudé

[PATCH v1 03/11] accel/tcg: Relax va restrictions on 64-bit guests

2020-04-09 Thread Alex Bennée
From: Richard Henderson We cannot at present limit a 64-bit guest to a virtual address space smaller than the host. It will mostly work to ignore this limitation, except if the guest uses high bits of the address space for tags. But it will certainly work better, as presently we can wind up

[PATCH v1 07/11] configure: disable PIE for Windows builds

2020-04-09 Thread Alex Bennée
It seems on some compilers the test can pass but still give you broken binaries. [AJB untested - please could windows users test] Fixes: d2cd29e30736 Fixes: https://bugs.launchpad.net/qemu/+bug/1871798 Cc: Bug 1871798 <1871...@bugs.launchpad.net> Cc: James Le Cuirot Signed-off-by: Alex Bennée

[PATCH v1 02/11] exec/cpu-all: Use bool for have_guest_base

2020-04-09 Thread Alex Bennée
From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Alex Bennée --- include/exec/cpu-all.h | 2 +- bsd-user/main.c| 4 ++-- linux-user/main.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/exec/cpu-all.h

[PATCH v1 11/11] .travis.yml: Build OSX 10.14 with Xcode 10.0

2020-04-09 Thread Alex Bennée
From: Philippe Mathieu-Daudé Travis recently made a change which generates various warnings such [*]: CC utils.o In file included from cs.c:11: In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/stdio.h:64:

[PATCH v1 05/11] tests/docker: add docs FEATURE flag and use for test-misc

2020-04-09 Thread Alex Bennée
The test-misc docker test fails on a number of images which don't have the prerequisites to build the docs. Use the FEATURES flag so we can skip those tests. As the sphinx test fails to detect whatever feature we need to get hxtool to work we drop them from debian9 so the windows build doesn't

[PATCH for 5.0-rc3 v1 00/11] more random fixes

2020-04-09 Thread Alex Bennée
Hi, Here are some more random fixes for the tree. In no particular order we have: - A couple of bugs found in the gdbstub GByteArray conversion - A trivial fix to /proc/self/stat output - An attempt to fix broken PIE builds for Windows (please test!) - Some fixes to get "make

[PATCH v1 08/11] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray

2020-04-09 Thread Alex Bennée
From: Philippe Mathieu-Daudé Since a010bdbe719 the gdbstub API takes a GByteArray*. Unfortunately we forgot to update the gdb_get_reg*() calls. Do it now. Fixes: a010bdbe719 ("extend GByteArray to read register helpers") Reported-by: Peter Xu Signed-off-by: Philippe Mathieu-Daudé Reviewed-by:

[PATCH v1 04/11] linux-user/ppc: Fix padding in mcontext_t for ppc64

2020-04-09 Thread Alex Bennée
From: Richard Henderson The padding that was added in 95cda4c44ee was added to a union, and so it had no effect. This fixes misalignment errors detected by clang sanitizers for ppc64 and ppc64le. In addition, only ppc64 allocates space for VSX registers, so do not save them for ppc32. The

[PATCH v1 01/11] linux-user: completely re-write init_guest_space

2020-04-09 Thread Alex Bennée
First we ensure all guest space initialisation logic comes through probe_guest_base once we understand the nature of the binary we are loading. The convoluted init_guest_space routine is removed and replaced with a number of pgb_* helpers which are called depending on what requirements we have

Re: [PATCH-for-5.0] .travis.yml: Build OSX 10.14 with Xcode 10.0

2020-04-09 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Travis recently made a change which generates various warnings > such [*]: > > CC utils.o > In file included from cs.c:11: > In file included from > /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/stdio.h:64: > >

Re: [PATCH 2/2] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

2020-04-09 Thread Alex Bennée
Peter Xu writes: > We should only pass in gdb_get_reg16() with the GByteArray* object > itself, no need to shift. Without this patch, gdb remote attach will > crash QEMU. > > Cc: Alex Bennée > Cc: Philippe Mathieu-Daudé > Signed-off-by: Peter Xu Queued to for-5.0/more-random-fixes,

Re: [PATCH-for-5.0] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray

2020-04-09 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Since a010bdbe719 the gdbstub API takes a GByteArray*. > Unfortunately we forgot to update the gdb_get_reg*() > calls. Do it now. > Queued to for-5.0/more-random-fixes, thanks. > Fixes: a010bdbe719 ("extend GByteArray to read register helpers") >

[Bug 1821595] Re: Failed to emulate MMIO access with EmulatorReturnStatus: 2

2020-04-09 Thread Russell Morris
Sorry, not quite following your comment - but it's likely me :-(. I assume you mean QEMU - but build against what upstream library? I ask because for QEMU to build, only the three header files from Windows are copied over, and then it calls / uses the dll's (libraries) in Windows itself ...

RE: [RFC PATCH v2 20/67] Hexagon instruction utility functions

2020-04-09 Thread Taylor Simpson
> -Original Message- > From: bcain=codeaurora@mg.codeaurora.org > On Behalf Of Brian Cain > Sent: Thursday, April 9, 2020 1:53 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: riku.voi...@iki.fi; richard.hender...@linaro.org; laur...@vivier.eu; > phi...@redhat.com;

Re: hotplug issue of vhost-user-blk

2020-04-09 Thread Michael S. Tsirkin
On Wed, Apr 08, 2020 at 10:25:42AM +0800, Li Feng wrote: > Hi all, > > Hotplug of vhost-user-blk doesn't not work in qemu master branch and > all previous version. > > The action I insert a vhost-user-blk disk is: > (qemu) chardev-add socket,id=spdk_vhost_blk2,path=/vhost-blk.0,reconnect=1 >

[Bug 1821595] Re: Failed to emulate MMIO access with EmulatorReturnStatus: 2

2020-04-09 Thread Alex Bennée
I don't think QEMU can do anything to fix this - you need to build against a new library. ** Tags added: upstream-bug -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1821595 Title: Failed to

Re: linux-user: keep the name-ending parenthesis in /proc/self/stat

2020-04-09 Thread Alex Bennée
Brice Goglin writes: > Le 09/04/2020 à 17:27, Alex Bennée a écrit : >> Brice Goglin writes: >> >>> When the program name is very long, qemu-user may truncate it in >>> /proc/self/stat. However the truncation must keep the ending ") " >>> to conform to the proc manpage which says: >>> (2)

Re: [PATCH for-5.1 8/8] qemu-option: Move is_valid_option_list() to qemu-img.c and rewrite

2020-04-09 Thread Eric Blake
On 4/9/20 10:30 AM, Markus Armbruster wrote: is_valid_option_list()'s purpose is ensuring qemu-img.c's can safely join multiple parameter strings separated by ',' like this: g_strdup_printf("%s,%s", params1, params2); How it does that is anything but obvious. A close reading of the

[Bug 1871798] Re: Fails to start on Windows host without explicit --disable-pie

2020-04-09 Thread James Le Cuirot
I didn't know whether PIE is generally supported on Windows or not. It was possible that Gentoo is just inadvertently disabling support for it. It did stem from a bug report though and reading around, others elsewhere have reported that PIE on Windows doesn't work. -- You received this bug

Re: [PATCH 2/2] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

2020-04-09 Thread Philippe Mathieu-Daudé
On 4/9/20 8:01 PM, Peter Xu wrote: Hi, Phil, On Thu, Apr 09, 2020 at 07:21:04PM +0200, Philippe Mathieu-Daudé wrote: On 4/9/20 6:49 PM, Peter Xu wrote: We should only pass in gdb_get_reg16() with the GByteArray* object itself, no need to shift. Without this patch, gdb remote attach will

[PATCH for 5.0] qemu-iotests: allow qcow2 external discarded clusters to contain stale data

2020-04-09 Thread Paolo Bonzini
Test 244 checks the expected behavior of qcow2 external data files with respect to zero and discarded clusters. Filesystems however are free to ignore discard requests, and this seems to be the case for overlayfs. Relax the tests to skip checks on the external data file for discarded areas,

[PATCH-for-5.0] .travis.yml: Build OSX 10.14 with Xcode 10.0

2020-04-09 Thread Philippe Mathieu-Daudé
Travis recently made a change which generates various warnings such [*]: CC utils.o In file included from cs.c:11: In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/stdio.h:64:

Re: [PATCH v6 21/36] multi-process: PCI BAR read/write handling for proxy & remote endpoints

2020-04-09 Thread Dr. David Alan Gilbert
* elena.ufimts...@oracle.com (elena.ufimts...@oracle.com) wrote: > From: Jagannathan Raman > > Proxy device object implements handler for PCI BAR writes and reads. > The handler uses BAR_WRITE/BAR_READ message to communicate to the > remote process with the BAR address and value to be

Re: [PATCH v2 2/2] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

2020-04-09 Thread Peter Xu
On Thu, Apr 09, 2020 at 02:25:38PM -0400, Peter Xu wrote: > We should only pass in gdb_get_reg16() with the GByteArray* object > itself, no need to shift. Without this patch, gdb remote attach will > crash QEMU. > > Cc: Alex Bennée > Cc: Philippe Mathieu-Daudé > Fixes: b7b8756a9c

Re: [PATCH-for-5.0] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray

2020-04-09 Thread Peter Xu
On Thu, Apr 09, 2020 at 08:36:22PM +0200, Laurent Vivier wrote: > Le 09/04/2020 à 20:22, Peter Xu a écrit : > > On Thu, Apr 09, 2020 at 07:25:08PM +0200, Philippe Mathieu-Daudé wrote: > >> Since a010bdbe719 the gdbstub API takes a GByteArray*. > >> Unfortunately we forgot to update the

RE: [RFC PATCH v2 20/67] Hexagon instruction utility functions

2020-04-09 Thread Brian Cain
> -Original Message- > From: Qemu-devel bounces+bcain=codeaurora@nongnu.org> On Behalf Of Taylor Simpson > Sent: Friday, February 28, 2020 10:43 AM > To: qemu-devel@nongnu.org > Cc: riku.voi...@iki.fi; richard.hender...@linaro.org; laur...@vivier.eu; > Taylor Simpson ;

Re: [PATCH for-5.0? 0/9] block/io: safer inc/dec in_flight sections

2020-04-09 Thread Vladimir Sementsov-Ogievskiy
09.04.2020 20:00, Stefan Hajnoczi wrote: On Wed, Apr 08, 2020 at 12:30:42PM +0300, Vladimir Sementsov-Ogievskiy wrote: Hi all! This is inspired by Kevin's "block: Fix blk->in_flight during blk_wait_while_drained()" series. So, like it's now done for block-backends, let's expand

[Bug 1871798] Re: Fails to start on Windows host without explicit --disable-pie

2020-04-09 Thread James Le Cuirot
I'm using GCC 9.3.0 with mingw-w64 7.0.0, all built with Gentoo Linux's crossdev. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1871798 Title: Fails to start on Windows host without explicit

Re: [PATCH v4 03/30] qcow2: Add calculate_l2_meta()

2020-04-09 Thread Vladimir Sementsov-Ogievskiy
09.04.2020 18:12, Alberto Garcia wrote: On Thu 09 Apr 2020 10:30:13 AM CEST, Vladimir Sementsov-Ogievskiy wrote: +static void calculate_l2_meta(BlockDriverState *bs, + uint64_t host_cluster_offset, + uint64_t guest_offset, unsigned

[Bug 1821595] Re: Failed to emulate MMIO access with EmulatorReturnStatus: 2

2020-04-09 Thread Russell Morris
Folks seem to think this is the fix, https://stackoverflow.com/questions/55197032/android-emulator-whpx-failed-to-emulate-mmio-access-exit-code-3 But it's not working for me ... does it help you? Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Bug 1821595] Re: Failed to emulate MMIO access with EmulatorReturnStatus: 2

2020-04-09 Thread Russell Morris
And here, https://www.reddit.com/r/androiddev/comments/c7u6h2/android_virtual_device_on_ryzen/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1821595 Title: Failed to emulate MMIO access with

Re: [PATCH v12 2/3] qcow2: Allow writing compressed data of multiple clusters

2020-04-09 Thread Vladimir Sementsov-Ogievskiy
09.04.2020 19:50, Alberto Garcia wrote: On Mon 02 Dec 2019 01:15:05 PM CET, Andrey Shinkevich wrote: +static coroutine_fn int +qcow2_co_pwritev_compressed_part(BlockDriverState *bs, + uint64_t offset, uint64_t bytes, + QEMUIOVector

Re: [Bug 1871842] [NEW] AMD CPUID leaf 0x8000'0008 reported number of cores inconsistent with ACPI.MADT

2020-04-09 Thread Babu Moger
On 4/9/20 9:00 AM, Igor Mammedov wrote: > On Thu, 09 Apr 2020 12:58:11 - > Philipp Eppelt <1871...@bugs.launchpad.net> wrote: > >> Public bug reported: >> >> Setup: >> CPU: AMD EPYC-v2 or host's EPYC cpu >> Linux 64-bit fedora host; Kernel version 5.5.15-200.fc31 >> qemu version: self

Re: [PATCH-for-5.0] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray

2020-04-09 Thread Laurent Vivier
Le 09/04/2020 à 20:22, Peter Xu a écrit : > On Thu, Apr 09, 2020 at 07:25:08PM +0200, Philippe Mathieu-Daudé wrote: >> Since a010bdbe719 the gdbstub API takes a GByteArray*. >> Unfortunately we forgot to update the gdb_get_reg*() >> calls. Do it now. >> >> Fixes: a010bdbe719 ("extend GByteArray

Re: [PATCH-for-5.0] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray

2020-04-09 Thread Laurent Vivier
Le 09/04/2020 à 20:22, Peter Xu a écrit : > On Thu, Apr 09, 2020 at 07:25:08PM +0200, Philippe Mathieu-Daudé wrote: >> Since a010bdbe719 the gdbstub API takes a GByteArray*. >> Unfortunately we forgot to update the gdb_get_reg*() >> calls. Do it now. >> >> Fixes: a010bdbe719 ("extend GByteArray

[PATCH v2 1/2] gdbstub: Assert len read from each register

2020-04-09 Thread Peter Xu
This can expose the issue earlier on which register returned the wrong result. Signed-off-by: Peter Xu --- gdbstub.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 171e150950..69656e1052 100644 --- a/gdbstub.c +++ b/gdbstub.c @@

[PATCH v2 0/2] gdbstub: Unbreak i386 with gdb remote

2020-04-09 Thread Peter Xu
v2: - use "goto" in patch 1 [Phil] - pick some tags Thanks, Peter Xu (2): gdbstub: Assert len read from each register gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb gdbstub.c | 12 +--- target/i386/gdbstub.c | 2 +- 2 files changed, 10 insertions(+), 4

[PATCH v2 2/2] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

2020-04-09 Thread Peter Xu
We should only pass in gdb_get_reg16() with the GByteArray* object itself, no need to shift. Without this patch, gdb remote attach will crash QEMU. Cc: Alex Bennée Cc: Philippe Mathieu-Daudé Fixes: b7b8756a9c ("target/i386: use gdb_get_reg helpers", 2020-03-17) Reviewed-by: Philippe

Re: [PATCH-for-5.0] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray

2020-04-09 Thread Peter Xu
On Thu, Apr 09, 2020 at 07:25:08PM +0200, Philippe Mathieu-Daudé wrote: > Since a010bdbe719 the gdbstub API takes a GByteArray*. > Unfortunately we forgot to update the gdb_get_reg*() > calls. Do it now. > > Fixes: a010bdbe719 ("extend GByteArray to read register helpers") Should this be

Re: [PATCH for-5.1 7/8] qemu-img: Factor out accumulate_options() helper

2020-04-09 Thread Eric Blake
On 4/9/20 10:30 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- qemu-img.c | 59 +- 1 file changed, 23 insertions(+), 36 deletions(-) Nice. Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat,

Re: [PATCH for-5.1 6/8] test-qemu-opts: Simplify test_has_help_option() after bug fix

2020-04-09 Thread Eric Blake
On 4/9/20 10:30 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- tests/test-qemu-opts.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) Assuming that the interpretation of a,b,,help is intended to match the interpretation you chose in 5/8

Re: [PATCH 1/2] gdbstub: Assert len read from each register

2020-04-09 Thread Peter Xu
On Thu, Apr 09, 2020 at 07:51:49PM +0200, Philippe Mathieu-Daudé wrote: > On 4/9/20 6:49 PM, Peter Xu wrote: > > This can expose the issue earlier on which register returned the wrong > > result. > > > > Signed-off-by: Peter Xu > > --- > > gdbstub.c | 11 --- > > 1 file changed, 8

Re: [PATCH for-5.1 5/8] qemu-option: Fix has_help_option()'s sloppy parsing

2020-04-09 Thread Eric Blake
On 4/9/20 10:30 AM, Markus Armbruster wrote: has_help_option() uses its own parser. It's inconsistent with qemu_opts_parse(), as demonstrated by test-qemu-opts case /qemu-opts/has_help_option. Fix by reusing the common parser. Signed-off-by: Markus Armbruster --- tests/test-qemu-opts.c |

Re: [PATCH for-5.1 4/8] qemu-option: Avoid has_help_option() in qemu_opts_parse_noisily()

2020-04-09 Thread Eric Blake
On 4/9/20 10:30 AM, Markus Armbruster wrote: When opts_parse() sets @invalidp to true, qemu_opts_parse_noisily() uses has_help_option() to decide whether to print help. This parses the input string a second time, in a slightly different way. Easy to avoid: replace @invalidp by @help_wanted.

Re: [PATCH for-5.1 3/8] qemu-option: Fix sloppy recognition of "id=..." after ", , "

2020-04-09 Thread Eric Blake
On 4/9/20 10:30 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- tests/test-qemu-opts.c | 4 ++-- util/qemu-option.c | 27 +++ 2 files changed, 21 insertions(+), 10 deletions(-) diff --git a/tests/test-qemu-opts.c b/tests/test-qemu-opts.c index

Re: [PATCH-for-5.0] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray

2020-04-09 Thread Laurent Vivier
Le 09/04/2020 à 19:25, Philippe Mathieu-Daudé a écrit : > Since a010bdbe719 the gdbstub API takes a GByteArray*. > Unfortunately we forgot to update the gdb_get_reg*() > calls. Do it now. > > Fixes: a010bdbe719 ("extend GByteArray to read register helpers") > Reported-by: Peter Xu >

Re: [PATCH for-5.1 2/8] qemu-options: Factor out get_opt_name_value() helper

2020-04-09 Thread Eric Blake
On 4/9/20 10:30 AM, Markus Armbruster wrote: The next commits will put it to use. Signed-off-by: Markus Armbruster --- util/qemu-option.c | 102 + 1 file changed, 56 insertions(+), 46 deletions(-) +static const char *get_opt_name_value(const

Re: [PATCH 2/2] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

2020-04-09 Thread Peter Xu
Hi, Phil, On Thu, Apr 09, 2020 at 07:21:04PM +0200, Philippe Mathieu-Daudé wrote: > On 4/9/20 6:49 PM, Peter Xu wrote: > > We should only pass in gdb_get_reg16() with the GByteArray* object > > itself, no need to shift. Without this patch, gdb remote attach will > > crash QEMU. > > You are

[Bug 1821595] Re: Failed to emulate MMIO access with EmulatorReturnStatus: 2

2020-04-09 Thread Emin Ghuliev
I think WHPX can't some MMIO requests for EFI. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1821595 Title: Failed to emulate MMIO access with EmulatorReturnStatus: 2 Status in QEMU: New Bug

Re: [PATCH v6 16/36] multi-process: remote process initialization

2020-04-09 Thread Dr. David Alan Gilbert
* elena.ufimts...@oracle.com (elena.ufimts...@oracle.com) wrote: > From: Jagannathan Raman > > Adds the handler to process message from QEMU, > Initialize remote process main loop, handles SYNC_SYSMEM > message by updating its "system_memory" container using > shared file descriptors received

Re: [PATCH v6 12/36] multi-process: add functions to synchronize proxy and remote endpoints

2020-04-09 Thread Dr. David Alan Gilbert
* elena.ufimts...@oracle.com (elena.ufimts...@oracle.com) wrote: > From: Jagannathan Raman > > In some cases, for example MMIO read, QEMU has to wait for the remote to > complete a command before proceeding. An eventfd based mechanism is > added to synchronize QEMU & remote process. > >

Re: [PATCH RESEND 3/3] .travis.yml: Test building with Xcode 11.3

2020-04-09 Thread Daniel P . Berrangé
On Thu, Apr 09, 2020 at 07:44:46PM +0200, Philippe Mathieu-Daudé wrote: > On 2/25/20 1:29 PM, Alex Bennée wrote: > > > > Philippe Mathieu-Daudé writes: > > > > > We currently run a CI job on macOS Mojave with Xcode 10. > > > > > > QEMU policy is to support the two last major OS releases. > > >

Re: [PATCH 1/2] gdbstub: Assert len read from each register

2020-04-09 Thread Philippe Mathieu-Daudé
On 4/9/20 6:49 PM, Peter Xu wrote: This can expose the issue earlier on which register returned the wrong result. Signed-off-by: Peter Xu --- gdbstub.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 171e150950..f763545e81 100644

Re: [PATCH v6 06/36] monitor: destaticize HMP commands

2020-04-09 Thread Dr. David Alan Gilbert
* elena.ufimts...@oracle.com (elena.ufimts...@oracle.com) wrote: > From: Jagannathan Raman > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman Hmm OK, so Reviewed-by: Dr. David Alan Gilbert but it might be better where you can, to

[Bug 1821595] Re: Failed to emulate MMIO access with EmulatorReturnStatus: 2

2020-04-09 Thread Russell Morris
Hi, I tried backing up ... nothing but startup and UEFI (i.e. no OS, just get to the EFI Shell). Can't even get there ... does that make sense? Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH for-5.1 1/8] tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt()

2020-04-09 Thread Eric Blake
On 4/9/20 10:30 AM, Markus Armbruster wrote: The two turn out to be inconsistent for "a,b,,help". Test case marked /* BUG */. Signed-off-by: Markus Armbruster --- tests/test-qemu-opts.c | 38 ++ 1 file changed, 38 insertions(+) +static void

Re: [PATCH RESEND 0/3] travis-ci: Improve OSX coverage

2020-04-09 Thread Philippe Mathieu-Daudé
On 2/25/20 10:18 AM, Philippe Mathieu-Daudé wrote: On 2/18/20 3:20 PM, Philippe Mathieu-Daudé wrote: Add more packages on the Mojave OSX job (Xcode 10), and duplicate the job to build on Catalina (Xcode 11). ping? Ping for patches 1 + 2 (extend OSX coverage)? Each job takes ~34min:

Re: [PATCH RESEND 3/3] .travis.yml: Test building with Xcode 11.3

2020-04-09 Thread Philippe Mathieu-Daudé
On 2/25/20 1:29 PM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: We currently run a CI job on macOS Mojave with Xcode 10. QEMU policy is to support the two last major OS releases. Add a job building on macOS Catalina, which comes with Xcode 11. Split the target list in two, as we

[PULL for-5.0 3/3] async: use explicit memory barriers

2020-04-09 Thread Stefan Hajnoczi
From: Paolo Bonzini When using C11 atomics, non-seqcst reads and writes do not participate in the total order of seqcst operations. In util/async.c and util/aio-posix.c, in particular, the pattern that we use write ctx->notify_me write bh->scheduled read

Re: [PATCH for-5.1 0/8] qemu-option: Fix corner cases and clean up

2020-04-09 Thread Eric Blake
On 4/9/20 12:09 PM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200409153041.17576-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: === OUTPUT BEGIN === 1/8 Checking commit 2e003109273b

[PULL for-5.0 1/3] aio-posix: signal-proof fdmon-io_uring

2020-04-09 Thread Stefan Hajnoczi
The io_uring_enter(2) syscall returns with errno=EINTR when interrupted by a signal. Retry the syscall in this case. It's essential to do this in the io_uring_submit_and_wait() case. My interpretation of the Linux v5.5 io_uring_enter(2) code is that it shouldn't affect the io_uring_submit()

[PULL for-5.0 0/3] Block patches

2020-04-09 Thread Stefan Hajnoczi
The following changes since commit 8bac3ba57eecc466b7e73dabf7d19328a59f684e: Merge remote-tracking branch 'remotes/rth/tags/pull-rx-20200408' into staging (2020-04-09 13:23:30 +0100) are available in the Git repository at: https://github.com/stefanha/qemu.git tags/block-pull-request for

[PULL for-5.0 2/3] aio-wait: delegate polling of main AioContext if BQL not held

2020-04-09 Thread Stefan Hajnoczi
From: Paolo Bonzini Any thread that is not a iothread returns NULL for qemu_get_current_aio_context(). As a result, it would also return true for in_aio_context_home_thread(qemu_get_aio_context()), causing AIO_WAIT_WHILE to invoke aio_poll() directly. This is incorrect if the BQL is not held,

[Bug 1871250] Re: Failed to create HAX VM

2020-04-09 Thread Russell Morris
NP, will do. Thanks again for the help! ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1871250 Title: Failed to create HAX VM Status in

Re: [PATCH 2/2] target/arm: Fail on invalid size for VMUL (float)

2020-04-09 Thread Fredrik Strupe
On 08.04.2020 18:27, Peter Maydell wrote: > On Wed, 8 Apr 2020 at 16:29, Fredrik Strupe wrote: >> >> Bit 1 of VMUL (float)'s size field encodes the opcode and must be 0, >> with 1 making it undefined. Thus, make VMUL (float) instructions >> with size=0b10 or size=0b11 (size >= 2) undefined. >> >>

[Bug 1871798] Re: Fails to start on Windows host without explicit --disable-pie

2020-04-09 Thread Alex Bennée
What compiler and toolchain are you using? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1871798 Title: Fails to start on Windows host without

Re: [PATCH v18 QEMU 3/3] virtio-balloon: Provide a interface for free page reporting

2020-04-09 Thread David Hildenbrand
On 09.04.20 19:34, Alexander Duyck wrote: > On Thu, Apr 9, 2020 at 12:44 AM David Hildenbrand wrote: >> >> On 09.04.20 00:55, Alexander Duyck wrote: >>> From: Alexander Duyck >>> >>> Add support for what I am referring to as "free page reporting". >> >> "Add support for "free page reporting". >>

Re: [PATCH v18 QEMU 3/3] virtio-balloon: Provide a interface for free page reporting

2020-04-09 Thread Alexander Duyck
On Thu, Apr 9, 2020 at 12:44 AM David Hildenbrand wrote: > > On 09.04.20 00:55, Alexander Duyck wrote: > > From: Alexander Duyck > > > > Add support for what I am referring to as "free page reporting". > > "Add support for "free page reporting". > > > Basically the idea is to function very

[PATCH-for-5.0] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray

2020-04-09 Thread Philippe Mathieu-Daudé
Since a010bdbe719 the gdbstub API takes a GByteArray*. Unfortunately we forgot to update the gdb_get_reg*() calls. Do it now. Fixes: a010bdbe719 ("extend GByteArray to read register helpers") Reported-by: Peter Xu Signed-off-by: Philippe Mathieu-Daudé --- Based-on:

Re: [PATCH 2/2] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

2020-04-09 Thread Philippe Mathieu-Daudé
On 4/9/20 6:49 PM, Peter Xu wrote: We should only pass in gdb_get_reg16() with the GByteArray* object itself, no need to shift. Without this patch, gdb remote attach will crash QEMU. You are correct. Fixes: a010bdbe719 ("extend GByteArray to read register helpers") Reviewed-by: Philippe

Re: [PATCH for-5.1 0/8] qemu-option: Fix corner cases and clean up

2020-04-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200409153041.17576-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH for-5.1 0/8] qemu-option: Fix corner cases and clean up Message-id:

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-09 Thread Paolo Bonzini
On 09/04/20 18:46, Dan Williams wrote: > Alternatively maybe you can use libdaxctl that automatically handles > the ABI differences between compat-dax-class and dax-bus layouts? I > didn't recommend it before because I was not sure about qemu's policy > about taking on new library dependencies In

Re: [PATCH for-5.0? 0/9] block/io: safer inc/dec in_flight sections

2020-04-09 Thread Stefan Hajnoczi
On Wed, Apr 08, 2020 at 12:30:42PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > This is inspired by Kevin's > "block: Fix blk->in_flight during blk_wait_while_drained()" series. > > So, like it's now done for block-backends, let's expand > in_flight-protected sections for bdrv_

[PATCH 0/2] gdbstub: Unbreak i386 with gdb remote

2020-04-09 Thread Peter Xu
It's silently broken on master during an refactoring. Let's fix it. Please feel free to drop patch 1 if it's not rc material, but I guess we want patch 2... Thanks, Peter Xu (2): gdbstub: Assert len read from each register gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

Re: [PATCH v12 2/3] qcow2: Allow writing compressed data of multiple clusters

2020-04-09 Thread Alberto Garcia
On Mon 02 Dec 2019 01:15:05 PM CET, Andrey Shinkevich wrote: > +static coroutine_fn int > +qcow2_co_pwritev_compressed_part(BlockDriverState *bs, > + uint64_t offset, uint64_t bytes, > + QEMUIOVector *qiov, size_t qiov_offset) > +{ >

[PATCH 2/2] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

2020-04-09 Thread Peter Xu
We should only pass in gdb_get_reg16() with the GByteArray* object itself, no need to shift. Without this patch, gdb remote attach will crash QEMU. Cc: Alex Bennée Cc: Philippe Mathieu-Daudé Signed-off-by: Peter Xu --- target/i386/gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-09 Thread Dan Williams
On Thu, Apr 9, 2020 at 7:33 AM Liu, Jingqi wrote: > > On 4/8/2020 5:42 PM, Joao Martins wrote: > > On 4/8/20 3:25 AM, Liu, Jingqi wrote: > >> On 4/8/2020 2:28 AM, Joao Martins wrote: > >>> On 4/7/20 5:55 PM, Dan Williams wrote: > On Tue, Apr 7, 2020 at 4:01 AM Joao Martins > wrote: >

  1   2   >