Re: [PATCH 01/16] tcg: Add temp_readonly

2020-04-19 Thread Philippe Mathieu-Daudé
On 4/18/20 6:18 PM, Richard Henderson wrote: > In most, but not all, places that we check for TEMP_FIXED, > we are really testing that we do not modify the temporary. > > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > include/tcg/tcg.h | 5 + > tcg/tcg.c

Re: [PATCH v1 2/3] hw/arm: xlnx-zcu102: Move arm_boot_info into XlnxZCU102

2020-04-19 Thread Philippe Mathieu-Daudé
On 4/19/20 6:27 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Move arm_boot_info into XlnxZCU102. > > Signed-off-by: Edgar E. Iglesias > --- > hw/arm/xlnx-zcu102.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/hw/arm/xlnx-zcu102.c b/hw/arm/xl

Re: [PATCH v2 00/16] nvme: refactoring and cleanups

2020-04-19 Thread Klaus Birkelund Jensen
On Apr 15 15:01, Klaus Jensen wrote: > From: Klaus Jensen > > Changes since v1 > > * nvme: fix pci doorbell size calculation > - added some defines and a better comment (Philippe) > > * nvme: rename trace events to pci_nvme > - changed the prefix from nvme_dev to pci_nvme (P

Re: [PATCH 7/7] tcg: Add tcg_gen_gvec_dup_tl

2020-04-19 Thread LIU Zhiwei
On 2020/4/18 23:04, Richard Henderson wrote: For use when a target needs to pass a configure-specific target_ulong value to duplicate. Signed-off-by: Richard Henderson Reviewed-by: LIU Zhiwei Zhiwei --- include/tcg/tcg-op-gvec.h | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [PATCH 5/7] tcg: Use tcg_gen_gvec_dup_imm in logical simplifications

2020-04-19 Thread LIU Zhiwei
On 2020/4/18 23:04, Richard Henderson wrote: Replace the outgoing interface. Signed-off-by: Richard Henderson Reviewed-by: LIU Zhiwei Zhiwei --- tcg/tcg-op-gvec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tcg/tcg-op-gvec.c b/tcg/tcg-op-gvec.c index 59

Re: [PATCH 6/7] tcg: Remove tcg_gen_gvec_dup{8,16,32,64}i

2020-04-19 Thread LIU Zhiwei
On 2020/4/18 23:04, Richard Henderson wrote: These interfaces are now unused. Signed-off-by: Richard Henderson Reviewed-by: LIU Zhiwei Zhiwei --- include/tcg/tcg-op-gvec.h | 5 - tcg/tcg-op-gvec.c | 28 2 files changed, 33 deletions(-) diff

[PATCH v1 1/2] migration/xbzrle: replace transferred xbzrle bytes with encoded bytes

2020-04-19 Thread Wei Wang
Like compressed_size which indicates how many bytes are compressed, we need encoded_size to understand how many bytes are encoded with xbzrle during migration. Replace the old xbzrle_counter.bytes, instead of adding a new counter, because we don't find a usage of xbzrle_counter.bytes currently, wh

[PATCH v1 2/2] migration/xbzrle: add encoding rate

2020-04-19 Thread Wei Wang
Users may need to check the xbzrle encoding rate to know if the guest memory is xbzrle encoding-friendly, and dynamically turn off the encoding if the encoding rate is low. Signed-off-by: Yi Sun Signed-off-by: Wei Wang --- migration/migration.c | 1 + migration/ram.c | 31 +++

[PATCH v1 0/2] Migration xbzrle changes

2020-04-19 Thread Wei Wang
This patches change/add some xbzrle statistics to give users some useful feedbacks about the delta operations. Wei Wang (2): migration/xbzrle: replace transferred xbzrle bytes with encoded bytes migration/xbzrle: add encoding rate migration/migration.c | 3 ++- migration/ram.c | 49 ++

qemu-img from qemu-4.2.0 load the wrong nettle dependency

2020-04-19 Thread shiftag
Hi, I built qemu-4.2.0 from source in order to link it with my system libnettle library. Below some information : $ pkg-config --modversion nettle 3.5.1 $ find /usr -name 'libnettle*' -type f /usr/lib64/libnettle.so.7.0 When executing qemu-img, I have the following error : $ qemu-img qemu-img:

Re: [PATCH 3/7] target/ppc: Use tcg_gen_gvec_dup_imm

2020-04-19 Thread David Gibson
On Sat, Apr 18, 2020 at 08:04:07AM -0700, Richard Henderson wrote: > We can now unify the implementation of the 3 VSPLTI instructions. > > Signed-off-by: Richard Henderson Acked-by: David Gibson > --- > target/ppc/translate/vmx-impl.inc.c | 32 - > target/ppc/trans

Re: [PATCH] hax: Add hax max vcpu IOCTL and support 64 vcpu

2020-04-19 Thread Colin Xu
Looks good to me. Reviewed-by: Colin Xu -- Best Regards, Colin Xu On Fri, 10 Apr 2020, WangBowen wrote: This commit tried to obtain max vcpu of haxm driver by calling HAX_IOCTL_CAP_MAX_VCPU before creating the vm so that if using hax as the accelerator and the smp value is larger than the ha

Re: [PATCH] hax: Dynamic allocate vcpu state structure

2020-04-19 Thread Colin Xu
Looks good to me. Reviewed-by: Colin Xu -- Best Regards, Colin Xu On Mon, 6 Apr 2020, WangBowen wrote: Dynamic allocating vcpu state structure according to smp value to be more precise and safe. Previously it will alloccate array of fixed size HAX_MAX_VCPU. This is achieved by using g_new

Re: [PATCH 1/7] tcg: Add tcg_gen_gvec_dup_imm

2020-04-19 Thread LIU Zhiwei
On 2020/4/18 23:04, Richard Henderson wrote: Add a version of tcg_gen_dup_* that takes both immediate and a vector element size operand. This will replace the set of tcg_gen_gvec_dup{8,16,32,64}i functions that encode the element size within the function name. Signed-off-by: Richard Henderson

Re: [PATCH] op_helper: fix some compile warnings

2020-04-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200420054959.8082-1-pannengy...@huawei.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash e

Re: [PATCH 3/4] char-socket: avoid double call tcp_chr_free_connection

2020-04-19 Thread Li Feng
Hi Lureau, Thanks for your comment. I have spent some time to reproduce this crash, so that delay my reply, apologies. This is the description of this bug using gdb: 1. Set break points using gdb; b chardev/char-socket.c:410 if s->state == TCP_CHARDEV_STATE_DISCONNECTED b break vhost_user_write

[PATCH] op_helper: fix some compile warnings

2020-04-19 Thread Pan Nengyuan
We got the following compile-time warnings(gcc7.3): /mnt/sdb//qemu/target/rx/op_helper.c: In function ‘helper_scmpu’: /mnt/sdb/qemu/target/rx/op_helper.c:213:24: error: ‘tmp1’ may be used uninitialized in this function [-Werror=maybe-uninitialized] env->psw_c = (tmp0 >= tmp1);

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

2020-04-19 Thread Yan Zhao
On Fri, Apr 17, 2020 at 07:24:57PM +0800, Cornelia Huck wrote: > On Fri, 17 Apr 2020 05:52:02 -0400 > Yan Zhao wrote: > > > On Fri, Apr 17, 2020 at 04:44:50PM +0800, Cornelia Huck wrote: > > > On Mon, 13 Apr 2020 01:52:01 -0400 > > > Yan Zhao wrote: > > > > > > > This patchset introduces a mi

several patches around Linux userland emulator

2020-04-19 Thread Nikolay Igotti
Hi, Attached 3 relatively trivial patches helping with running userland Linux emulation. Best regards, Nikolay 0001-plugins-avoid-failing-plugin-when-CPU-is-inited-seve.patch Description: Binary data 0001-linux-user-fix-page-table-trashing-when-mmap-munmap-.patch Description: Binary

Re: [PATCH v3 01/19] target/arm: Rename KVM set_feature() as kvm_set_feature()

2020-04-19 Thread Peter Maydell
On Sun, 19 Apr 2020 at 17:31, Philippe Mathieu-Daudé wrote: > > On 3/17/20 10:09 AM, Philippe Mathieu-Daudé wrote: > > On 3/16/20 9:16 PM, Richard Henderson wrote: > >> On 3/16/20 9:06 AM, Philippe Mathieu-Daudé wrote: > >>> +++ b/target/arm/kvm32.c > >>> @@ -22,7 +22,7 @@ > >>> #include "intern

Re: [PATCH v1 6/6] target/microblaze: Add the pvr-user2 property

2020-04-19 Thread Luc Michel
On 4/17/20 9:10 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add the pvr-user2 property to control the user-defined > PVR1 User2 register. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Luc Michel > --- > target/microblaze/cpu.c | 2 ++ > target/microblaze/cpu.h | 1 + >

Re: [PATCH v1 5/6] target/microblaze: Add the pvr-user1 property

2020-04-19 Thread Luc Michel
On 4/17/20 9:10 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add the pvr-user1 property to control the user-defined > PVR0 User1 field. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Luc Michel > --- > target/microblaze/cpu.c | 4 +++- > target/microblaze/cpu.h | 1 + > 2

Re: [PATCH v1 4/6] target/microblaze: Add the unaligned-exceptions property

2020-04-19 Thread Luc Michel
On 4/17/20 9:10 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add the unaligned-exceptions property to control if the core > traps unaligned memory accesses. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Luc Michel > --- > target/microblaze/cpu.c | 4 > target/

Re: [PATCH v1 3/6] target/microblaze: Add the div-zero-exception property

2020-04-19 Thread Luc Michel
Hi Edgar, On 4/17/20 9:10 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add the div-zero-exception property to control if the core > traps divizions by zero. > > Signed-off-by: Edgar E. Iglesias > --- > target/microblaze/cpu.c | 2 ++ > target/microblaze/cpu.h | 1 +

Re: [PATCH v1 2/6] target/microblaze: Add the ill-opcode-exception property

2020-04-19 Thread Luc Michel
On 4/17/20 9:10 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add the ill-opcode-exception property to control if illegal > instructions will raise exceptions. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Luc Michel > --- > target/microblaze/cpu.c | 4 > targe

Re: [PATCH v1 1/6] target/microblaze: Add the opcode-0x0-illegal CPU property

2020-04-19 Thread Luc Michel
On 4/17/20 9:10 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add the opcode-0x0-illegal CPU property to control if the core > should trap opcode zero as illegal. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Luc Michel > --- > target/microblaze/cpu.c | 6 +- >

Re: [PATCH v1 1/1] hw/arm: versal: Setup the ADMA with 128bit bus-width

2020-04-19 Thread Luc Michel
On 4/17/20 5:38 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Setup the ADMA with 128bit bus-width. This matters when > FIXED BURST mode is used. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Luc Michel > --- > hw/arm/xlnx-versal.c | 2 ++ > 1 file changed, 2 insertions(+

Re: [PATCH RFC v5] target/arm: Implement SVE2 HISTCNT, HISTSEG

2020-04-19 Thread Richard Henderson
On 4/16/20 10:31 AM, Stephen Long wrote: > Signed-off-by: Stephen Long > --- > Made the fixes Richard noted. > > target/arm/helper-sve.h| 7 +++ > target/arm/sve.decode | 6 +++ > target/arm/sve_helper.c| 104 + > target/arm/translate-sve.c |

Re: [PATCH 0/4] target/arm: Implement last SVE2 narrowing section

2020-04-19 Thread Richard Henderson
On 4/17/20 9:22 AM, Stephen Long wrote: > Submitting patches for the section 'SVE2 integer add/subtract narrow > high part' for early review. > > Stephen Long (4): > target/arm: Implement SVE2 ADDHNB, ADDHNT > target/arm: Implement SVE2 RADDHNB, RADDHNT > target/arm: Implement SVE2 SUBHNB, S

Re: [PATCH v3 01/19] target/arm: Rename KVM set_feature() as kvm_set_feature()

2020-04-19 Thread Philippe Mathieu-Daudé
On 3/17/20 10:09 AM, Philippe Mathieu-Daudé wrote: On 3/16/20 9:16 PM, Richard Henderson wrote: On 3/16/20 9:06 AM, Philippe Mathieu-Daudé wrote: +++ b/target/arm/kvm32.c @@ -22,7 +22,7 @@   #include "internals.h"   #include "qemu/log.h" -static inline void set_feature(uint64_t *features, int f

[PATCH v1 2/3] hw/arm: xlnx-zcu102: Move arm_boot_info into XlnxZCU102

2020-04-19 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Move arm_boot_info into XlnxZCU102. Signed-off-by: Edgar E. Iglesias --- hw/arm/xlnx-zcu102.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/arm/xlnx-zcu102.c b/hw/arm/xlnx-zcu102.c index bd645ad818..4eb117c755 100644 --- a/hw/arm/xlnx

[PATCH v1 1/3] device_tree: Allow name wildcards in qemu_fdt_node_path()

2020-04-19 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Allow name wildcards in qemu_fdt_node_path(). This is useful to find all nodes with a given compatibility string. Signed-off-by: Edgar E. Iglesias --- device_tree.c| 2 +- include/sysemu/device_tree.h | 3 +++ 2 files changed, 4 insertions(+), 1 deleti

[PATCH v1 3/3] hw/arm: xlnx-zcu102: Disable unsupported FDT firmware nodes

2020-04-19 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Disable unsupported FDT firmware nodes if a user passes us a DTB with nodes enabled that the machine cannot support due to lack of EL3 or EL2 support. Signed-off-by: Edgar E. Iglesias --- hw/arm/xlnx-zcu102.c | 31 +++ 1 file changed, 31 in

[PATCH v1 0/3] hw/arm: xlnx-zcu102: Disable unsupported FDT firmware nodes

2020-04-19 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" When users try direct Linux runs on the ZynqMP models without enabling EL3 (and using appropriate FW) they run into trouble because the upstream kernel device-tree has EL3 based non-PSCI firmware nodes by default. PSCI firmware nodes work because we emulate the firmware

[PATCH v6 3/5] 9pfs: add new function v9fs_co_readdir_many()

2020-04-19 Thread Christian Schoenebeck
The newly added function v9fs_co_readdir_many() retrieves multiple directory entries with a single fs driver request. It is intended to replace uses of v9fs_co_readdir(), the latter only retrives a single directory entry per fs driver request instead. The reason for this planned replacement is tha

[PATCH v6 4/5] 9pfs: T_readdir latency optimization

2020-04-19 Thread Christian Schoenebeck
Make top half really top half and bottom half really bottom half: Each T_readdir request handling is hopping between threads (main I/O thread and background I/O driver threads) several times for every individual directory entry, which sums up to huge latencies for handling just a single T_readdir

[PATCH v6 0/5] 9pfs: readdir optimization

2020-04-19 Thread Christian Schoenebeck
As previously mentioned, I was investigating performance issues with 9pfs. Raw file read/write of 9pfs is actually quite good, provided that client picked a reasonable high msize (maximum message size). I would recommend to log a warning on 9p server side if a client attached with a small msize tha

[PATCH v6 5/5] 9pfs: clarify latency of v9fs_co_run_in_worker()

2020-04-19 Thread Christian Schoenebeck
As we just fixed a severe performance issue with Treaddir request handling, clarify this overall issue as a comment on v9fs_co_run_in_worker() with the intention to hopefully prevent such performance mistakes in future (and fixing other yet outstanding ones). Signed-off-by: Christian Schoenebeck

[PATCH v6 1/5] tests/virtio-9p: added split readdir tests

2020-04-19 Thread Christian Schoenebeck
The previous, already existing 'basic' readdir test simply used a 'count' parameter big enough to retrieve all directory entries with a single Treaddir request. In the 3 new 'split' readdir tests added by this patch, directory entries are retrieved, split over several Treaddir requests by picking

[PATCH v6 2/5] 9pfs: make v9fs_readdir_response_size() public

2020-04-19 Thread Christian Schoenebeck
Rename function v9fs_readdir_data_size() -> v9fs_readdir_response_size() and make it callable from other units. So far this function is only used by 9p.c, however subsequent patches require the function to be callable from another 9pfs unit. And as we're at it; also make it clear for what this func

Re: [PATCH v2 0/3] fetch the alignment of device dax

2020-04-19 Thread Liu, Jingqi
Ping for comments. Hi Paolo, Dan, Joao, Any comments for this series. Thanks, Jingqi On 4/15/2020 11:35 AM, Liu, Jingqi wrote: This series adds libdaxctl support and fetchs the alignment of device dax through libdaxctl [1] APIs. QEMU uses mmap(2) to maps vNVDIMM backends and aligns the mappin

[PATCH v2] chardev/char-socket: Properly make qio connections non blocking

2020-04-19 Thread Sai Pavan Boddu
In tcp_chr_sync_read function, there is a possibility of socket disconnection during blocking read, then tcp_chr_hup function would clean up the qio channel pointers(i.e ioc, sioc). Signed-off-by: Sai Pavan Boddu --- Changes for V2: Place the guard around 'qio_channel_set_blocking' call t

[QEMU][PATCH v2] chardev/char-socket: Properly make qio connections non blocking

2020-04-19 Thread Sai Pavan Boddu
In tcp_chr_sync_read function, there is a possibility of socket disconnection during read, then tcp_chr_hup function would clean up the qio channel pointers(i.e ioc, sioc). Signed-off-by: Sai Pavan Boddu --- Changes for V2: Simply guard the 'qio_channel_set_blocking' call to check connec

Re: [PATCH 13/15] KVM: MIPS: Add CONFIG6 and DIAG registers emulation

2020-04-19 Thread Huacai Chen
Hi, Jiaxun, Thank you for your suggestion, in this patch and the 8th patch I will use CONFIG_CPU_LOONGSON64. Huacai On Mon, Apr 13, 2020 at 7:19 PM Jiaxun Yang wrote: > > On Mon, 13 Apr 2020 15:30:22 +0800 > Huacai Chen wrote: > > > Loongson-3 has CONFIG6 and DIAG registers which need to be em

Re: [PATCH 0/15] KVM: MIPS: Add Loongson-3 support (Host Side)

2020-04-19 Thread Huacai Chen
Hi, all, On Tue, Apr 14, 2020 at 12:45 PM Jiaxun Yang wrote: > > On Tue, 14 Apr 2020 09:40:26 +0800 > maobibo wrote: > > > On 04/13/2020 04:18 PM, Jiaxun Yang wrote: > > > On Mon, 13 Apr 2020 15:30:09 +0800 > > > Huacai Chen wrote: > > > > > >> We are preparing to add KVM support for Loongson-3