Re: [PATCH v4 6/7] wire in the dwc-hsotg (dwc2) USB host controller emulation

On 4/28/20 4:22 AM, Paul Zimmerman wrote: > Wire the dwc-hsotg (dwc2) emulation into Qemu > > Signed-off-by: Paul Zimmerman > --- > hw/arm/bcm2835_peripherals.c | 21 - > include/hw/arm/bcm2835_peripherals.h | 3 ++- > 2 files changed, 22 insertions(+), 2 deletions(-

Re: [PATCH v4 4/7] dwc-hsotg (dwc2) USB host controller emulation

On 4/28/20 4:22 AM, Paul Zimmerman wrote: > Add the dwc-hsotg (dwc2) USB host controller emulation code. > Based on hw/usb/hcd-ehci.c and hw/usb/hcd-ohci.c. > > Note that to use this with the dwc-otg driver in the Raspbian > kernel, you must pass the option "dwc_otg.fiq_fsm_enable=0" on > the kern

Re: [PATCH v4 7/7] raspi2 acceptance test: add test for dwc-hsotg (dwc2) USB host

On 4/28/20 4:22 AM, Paul Zimmerman wrote: > Add a check for functional dwc-hsotg (dwc2) USB host emulation to > the Raspi 2 acceptance test > > Signed-off-by: Paul Zimmerman > --- > tests/acceptance/boot_linux_console.py | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff

Re: [PATCH v2 1/6] block/block-copy: rename in-flight requests to tasks

On 25.03.20 14:46, Vladimir Sementsov-Ogievskiy wrote: > We are going to use aio-task-pool API and extend in-flight request > structure to be a successor of AioTask, so rename things appropriately. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/block-copy.c | 99 ++

Re: [Bug 1874674] Re: [Feature request] acceptance test class to run user-mode binaries

On 4/24/20 9:14 PM, Richard Henderson wrote: > What user-mode testing do you think might be improved by using avocado? Test unmodified real-world binaries, know to work in the field. Test can be added by users without having to be a TCG developer, see https://www.mail-archive.com/qemu-devel@nongn

[PATCH 1/2] Fix undefined behaviour

Signed-off-by: Grzegorz Uriasz --- hw/xen/xen_pt_load_rom.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/xen/xen_pt_load_rom.c b/hw/xen/xen_pt_load_rom.c index a50a80837e..9f100dc159 100644 --- a/hw/xen/xen_pt_load_rom.c +++ b/hw/xen/xen_pt_load_rom.c @@ -38,

[PATCH 2/2] Improve legacy vbios handling

Signed-off-by: Grzegorz Uriasz --- hw/xen/xen_pt.c | 8 +-- hw/xen/xen_pt_graphics.c | 48 +--- hw/xen/xen_pt_load_rom.c | 2 +- 3 files changed, 52 insertions(+), 6 deletions(-) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index b91082cb8b..f

[PATCH 0/2] Fix QEMU crashes when passing IGD to a guest VM under XEN

Hi, This patch series is a small subset of a bigger patch set spanning few projects aiming to isolate the GPU in QUBES OS to a dedicated security domain. I'm doing this together with 3 colleagues as part of our Bachelors thesis. When passing an Intel Graphic Device to a HVM guest under XEN, Q

Re: [PATCH v2 2/6] block/block-copy: alloc task on each iteration

On 25.03.20 14:46, Vladimir Sementsov-Ogievskiy wrote: > We are going to use aio-task-pool API, so tasks will be handled in > parallel. We need therefore separate allocated task on each iteration. > Introduce this logic now. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/block-cop

Re: [PATCH v4 1/7] raspi: add BCM2835 SOC MPHI emulation

Hi Paul, On 4/28/20 4:22 AM, Paul Zimmerman wrote: > Add BCM2835 SOC MPHI (Message-based Parallel Host Interface) > emulation. It is very basic, only providing the FIQ interrupt > needed to allow the dwc-otg USB host controller driver in the > Raspbian kernel to function. > > Signed-off-by: Paul

Re: [PATCH v1 03/11] hw/arm: versal-virt: Fix typo xlnx-ve -> xlnx-versal

On 4/27/20 8:16 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Fix typo xlnx-ve -> xlnx-versal. > > Signed-off-by: Edgar E. Iglesias > --- > hw/arm/xlnx-versal-virt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx

Re: [PATCH v1 02/11] hw/arm: versal: Move misplaced comment

On 4/27/20 8:16 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Move misplaced comment. > > Signed-off-by: Edgar E. Iglesias > --- > hw/arm/xlnx-versal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c > index c

Re: [PATCH v1 07/11] hw/arm: versal: Embedd the APUs into the SoC type

On 4/27/20 8:16 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Embedd the APUs into the SoC type. > > Suggested-by: Peter Maydell > Signed-off-by: Edgar E. Iglesias > --- > hw/arm/xlnx-versal-virt.c| 4 ++-- > hw/arm/xlnx-versal.c | 19 +-- > include

Re: [PATCH v1 08/11] hw/arm: versal: Add support for SD

On 4/27/20 8:16 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add support for SD. > > Signed-off-by: Edgar E. Iglesias > --- > hw/arm/xlnx-versal.c | 31 +++ > include/hw/arm/xlnx-versal.h | 12 > 2 files changed, 43 insertions(+)

Re: [PATCH for-5.1 7/7] MAINTAINERS: Add myself as Loongson-3 maintainer

Hi Huacai, On 4/27/20 11:33 AM, Huacai Chen wrote: > Signed-off-by: Huacai Chen > Co-developed-by: Jiaxun Yang > --- > MAINTAINERS | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index aa9a057..efe840b 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS >

Re: [RFC patch v1 2/3] qemu-file: add buffered mode

On 27.04.2020 15:14, Dr. David Alan Gilbert wrote: * Denis Plotnikov (dplotni...@virtuozzo.com) wrote: The patch adds ability to qemu-file to write the data asynchronously to improve the performance on writing. Before, only synchronous writing was supported. Enabling of the asyncronous mode

Re: [PATCH v2] [Qemu-devel] target/i386: HAX: Enable ROM/ROM device memory region support

On 4/28/20 4:45 AM, Colin Xu wrote: Hi Paolo, Would you please queue this one? -- Best Regards, Colin Xu On Mon, 30 Mar 2020, Colin Xu wrote: Looks good to me. Reviewed-by: Colin Xu On 2020-03-30 11:25, hang.y...@linux.intel.com wrote: From: Hang Yuan Add ROM and ROM device memory regi

Re: [PATCH v1 04/11] hw/arm: versal: Embedd the UARTs into the SoC type

On 4/27/20 8:16 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Embedd the UARTs into the SoC type. > > Suggested-by: Peter Maydell > Signed-off-by: Edgar E. Iglesias > --- > hw/arm/xlnx-versal.c | 12 ++-- > include/hw/arm/xlnx-versal.h | 3 ++- > 2 files change

Re: [PATCH v1 09/11] hw/arm: versal: Add support for the RTC

On 4/27/20 8:16 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > hw/arm: versal: Add support for the RTC. > > Signed-off-by: Edgar E. Iglesias > --- > hw/arm/xlnx-versal.c | 21 + > include/hw/arm/xlnx-versal.h | 8 > 2 files changed, 29 insert

Re: [PATCH 3/3] virtio-net: remove VIRTIO_NET_HDR_F_RSC_INFO compat handling

On 2020/4/27 下午6:24, Cornelia Huck wrote: VIRTIO_NET_HDR_F_RSC_INFO is available in the headers now. Signed-off-by: Cornelia Huck --- hw/net/virtio-net.c | 8 1 file changed, 8 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index e85d902588b3..7449570c7123 10

Re: [PATCH v2 3/6] block/block-copy: add state pointer to BlockCopyTask

On 25.03.20 14:46, Vladimir Sementsov-Ogievskiy wrote: > We are going to use aio-task-pool API, so we'll need state pointer in > BlockCopyTask anyway. Add it now and use where possible. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/block-copy.c | 30 --

Re: [PATCH 3/3] virtio-net: remove VIRTIO_NET_HDR_F_RSC_INFO compat handling

On Tue, 28 Apr 2020 16:19:15 +0800 Jason Wang wrote: > On 2020/4/27 下午6:24, Cornelia Huck wrote: > > VIRTIO_NET_HDR_F_RSC_INFO is available in the headers now. > > > > Signed-off-by: Cornelia Huck > > --- > > hw/net/virtio-net.c | 8 > > 1 file changed, 8 deletions(-) > > > > diff --

Re: [PATCH for-5.1 7/7] MAINTAINERS: Add myself as Loongson-3 maintainer

Hi, Philippe, On Tue, Apr 28, 2020 at 2:18 PM Philippe Mathieu-Daudé wrote: > > Hi Huacai, > > On 4/27/20 11:33 AM, Huacai Chen wrote: > > Signed-off-by: Huacai Chen > > Co-developed-by: Jiaxun Yang > > --- > > MAINTAINERS | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/MA

Re: About hardfloat in ppc

罗勇刚(Yonggang Luo) writes: > I am confusing why only inexact are set then we can use hard-float. The inexact behaviour of the host hardware may be different from the guest architecture we are trying to emulate and the host hardware may not be configurable to emulate the guest mode. Have a lo

Re: [PATCH v1 06/11] hw/arm: versal: Embedd the ADMAs into the SoC type

On 4/27/20 8:16 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Embedd the ADMAs into the SoC type. > > Suggested-by: Peter Maydell > Signed-off-by: Edgar E. Iglesias > --- > hw/arm/xlnx-versal.c | 14 +++--- > include/hw/arm/xlnx-versal.h | 3 ++- > 2 files chan

Re: [PATCH] hax: Dynamic allocate vcpu state structure

On 4/28/20 4:47 AM, Colin Xu wrote: And this one. 3 patches for HAX. Thanks in advance. -- Best Regards, Colin Xu On Mon, 20 Apr 2020, Colin Xu wrote: Looks good to me. Reviewed-by: Colin Xu -- Best Regards, Colin Xu On Mon, 6 Apr 2020, WangBowen wrote: Dynamic allocating vcpu state s

Re: [PATCH] virtiofsd: Show submounts

On Mon, Apr 27, 2020 at 06:59:02PM +0100, Dr. David Alan Gilbert wrote: > * Max Reitz (mre...@redhat.com) wrote: > > Currently, setup_mounts() bind-mounts the shared directory without > > MS_REC. This makes all submounts disappear. > > > > Pass MS_REC so that the guest can see submounts again. >

Re: [PATCH for-5.1 4/7] target/mips: Add Loongson-3 CPU definition

Hi, Philippe, On Tue, Apr 28, 2020 at 2:34 PM Philippe Mathieu-Daudé wrote: > > Hi Huacai, > > On 4/27/20 11:33 AM, Huacai Chen wrote: > > Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and Loongson-3B > > R1/R2. Loongson-3A R4 is the newest and its ISA is almost the superset > > of all ot

Re: [PATCH v1 05/11] hw/arm: versal: Embedd the GEMs into the SoC type

On 4/27/20 8:16 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Embedd the GEMs into the SoC type. > > Suggested-by: Peter Maydell > Signed-off-by: Edgar E. Iglesias > --- > hw/arm/xlnx-versal.c | 15 --- > include/hw/arm/xlnx-versal.h | 3 ++- > 2 files chan

Re: [PATCH v20 3/4] qcow2: add zstd cluster compression

On 28.04.2020 09:16, Max Reitz wrote: On 27.04.20 21:26, Denis Plotnikov wrote: On 27.04.2020 15:35, Max Reitz wrote: On 21.04.20 10:11, Denis Plotnikov wrote: zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the

Re: [PATCH for-5.1 3/7] hw/mips: Add CPU IRQ3 delivery for KVM

Hi, Philippe, On Mon, Apr 27, 2020 at 5:57 PM Philippe Mathieu-Daudé wrote: > > On 4/27/20 11:33 AM, Huacai Chen wrote: > > Currently, KVM/MIPS only deliver I/O interrupt via IP2, this patch add > > IP2 delivery as well, because Loongson-3 based machine use both IRQ2 > > (CPU's IP2) and IRQ3 (CPU

Re: [PATCH v2 1/6] block/block-copy: rename in-flight requests to tasks

28.04.2020 10:30, Max Reitz wrote: On 25.03.20 14:46, Vladimir Sementsov-Ogievskiy wrote: We are going to use aio-task-pool API and extend in-flight request structure to be a successor of AioTask, so rename things appropriately. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/block-cop

RE: [PATCH 1/2] Fix undefined behaviour

> -Original Message- > From: Grzegorz Uriasz > Sent: 28 April 2020 07:29 > To: qemu-devel@nongnu.org > Cc: Grzegorz Uriasz ; marma...@invisiblethingslab.com; > ar...@puzio.waw.pl; > ja...@bartmin.ski; j.nowa...@student.uw.edu.pl; Stefano Stabellini > ; Anthony > Perard ; Paul Durrant ;

Re: [PATCH v2 5/6] block/block-copy: move block_copy_task_create down

28.04.2020 12:06, Max Reitz wrote: On 25.03.20 14:46, Vladimir Sementsov-Ogievskiy wrote: Simple movement without any change. It's needed for the following patch, as this function will need to use some staff which is currently *stuff below it. Wouldn’t it be simpler to just declare block_c

Re: [PATCH 3/3] virtio-net: remove VIRTIO_NET_HDR_F_RSC_INFO compat handling

On Tue, 28 Apr 2020 16:58:44 +0800 Jason Wang wrote: > On 2020/4/28 下午4:34, Cornelia Huck wrote: > > On Tue, 28 Apr 2020 16:19:15 +0800 > > Jason Wang wrote: > > > >> On 2020/4/27 下午6:24, Cornelia Huck wrote: > >>> VIRTIO_NET_HDR_F_RSC_INFO is available in the headers now. > >>> > >>> Signed

Re: [PATCH 1/2] Fix undefined behaviour

On Tue, 28 Apr 2020 at 08:50, Grzegorz Uriasz wrote: > > Signed-off-by: Grzegorz Uriasz > --- > hw/xen/xen_pt_load_rom.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) The subject doesn't match the patch contents and there is no long-form part of the commit message explaini

Re: [PATCH v2] char-socket: initialize reconnect timer only when the timer doesn't start

Sorry for sending the weird same mail out. Ignore the second one. Hi Lureau, I found another issue when running my new test: tests/test-char -p /char/socket/client/reconnect-error/unix The backtrace like this: #0 0x75ac3277 in raise () from /lib64/libc.so.6 #1 0x75ac4968 in abo

Re: [PATCH v2 5/6] block/block-copy: move block_copy_task_create down

On 25.03.20 14:46, Vladimir Sementsov-Ogievskiy wrote: > Simple movement without any change. It's needed for the following > patch, as this function will need to use some staff which is currently *stuff > below it. Wouldn’t it be simpler to just declare block_copy_task_entry()? Max > Signed-of

[PATCH v2] char-socket: initialize reconnect timer only when the timer doesn't start

When the disconnect event is triggered in the connecting stage, the tcp_chr_disconnect_locked may be called twice. The first call: #0 qemu_chr_socket_restart_timer (chr=0x5582ee90) at chardev/char-socket.c:120 #1 0x5558e38c in tcp_chr_disconnect_locked (chr=) at chardev/cha

Re: [PATCH 3/3] virtio-net: remove VIRTIO_NET_HDR_F_RSC_INFO compat handling

On 2020/4/28 下午4:34, Cornelia Huck wrote: On Tue, 28 Apr 2020 16:19:15 +0800 Jason Wang wrote: On 2020/4/27 下午6:24, Cornelia Huck wrote: VIRTIO_NET_HDR_F_RSC_INFO is available in the headers now. Signed-off-by: Cornelia Huck --- hw/net/virtio-net.c | 8 1 file changed, 8 del

Re: [PATCH v2 4/6] block/block-copy: move task size initial calculation to _task_create

28.04.2020 11:52, Max Reitz wrote: On 25.03.20 14:46, Vladimir Sementsov-Ogievskiy wrote: Comment "Called only on full-dirty region" without corresponding assertion is a very unsafe thing. Not sure whether it’s that unsafe for a static function with a single caller, but, well. Adding asserti

[PATCH v2] char-socket: initialize reconnect timer only when the timer doesn't start

When the disconnect event is triggered in the connecting stage, the tcp_chr_disconnect_locked may be called twice. The first call: #0 qemu_chr_socket_restart_timer (chr=0x5582ee90) at chardev/char-socket.c:120 #1 0x5558e38c in tcp_chr_disconnect_locked (chr=) at chardev/cha

Re: [PATCH v2 4/6] block/block-copy: move task size initial calculation to _task_create

On 25.03.20 14:46, Vladimir Sementsov-Ogievskiy wrote: > Comment "Called only on full-dirty region" without corresponding > assertion is a very unsafe thing. Not sure whether it’s that unsafe for a static function with a single caller, but, well. > Adding assertion means call > bdrv_dirty_bitmap_

backing chain & block status & filters

Hi! I wanted to resend my "[PATCH 0/4] fix & merge block_status_above and is_allocated_above", and returned to all the inconsistencies about block-status. I keep in mind Max's series about child-access functions, and Andrey's work about using COR filter in block-stream, which depends on Max's

Re: [PATCH] virtiofsd: Show submounts

* Max Reitz (mre...@redhat.com) wrote: > On 27.04.20 19:59, Dr. David Alan Gilbert wrote: > > * Max Reitz (mre...@redhat.com) wrote: > >> Currently, setup_mounts() bind-mounts the shared directory without > >> MS_REC. This makes all submounts disappear. > >> > >> Pass MS_REC so that the guest can

Re: [PATCH v2 6/6] block/block-copy: use aio-task-pool API

On 25.03.20 14:46, Vladimir Sementsov-Ogievskiy wrote: > Run block_copy iterations in parallel in aio tasks. > > Changes: > - BlockCopyTask becomes aio task structure. Add zeroes field to pass > it to block_copy_do_copy > - add call state - it's a state of one call of block_copy(), shared

Re: [PATCH v2 5/6] block/block-copy: move block_copy_task_create down

On 28.04.20 11:17, Vladimir Sementsov-Ogievskiy wrote: > 28.04.2020 12:06, Max Reitz wrote: >> On 25.03.20 14:46, Vladimir Sementsov-Ogievskiy wrote: >>> Simple movement without any change. It's needed for the following >>> patch, as this function will need to use some staff which is currently >> >

Re: [PATCH] virtiofsd: Show submounts

On 28.04.20 11:59, Dr. David Alan Gilbert wrote: > * Max Reitz (mre...@redhat.com) wrote: >> On 27.04.20 19:59, Dr. David Alan Gilbert wrote: >>> * Max Reitz (mre...@redhat.com) wrote: Currently, setup_mounts() bind-mounts the shared directory without MS_REC. This makes all submounts dis

Re: [PATCH v20 3/4] qcow2: add zstd cluster compression

On 28.04.20 09:23, Denis Plotnikov wrote: > > > On 28.04.2020 09:16, Max Reitz wrote: >> On 27.04.20 21:26, Denis Plotnikov wrote: >>> >>> On 27.04.2020 15:35, Max Reitz wrote: On 21.04.20 10:11, Denis Plotnikov wrote: > zstd significantly reduces cluster compression time. > It provi

Re: [PATCH] virtiofsd: Show submounts

* Max Reitz (mre...@redhat.com) wrote: > On 28.04.20 11:59, Dr. David Alan Gilbert wrote: > > * Max Reitz (mre...@redhat.com) wrote: > >> On 27.04.20 19:59, Dr. David Alan Gilbert wrote: > >>> * Max Reitz (mre...@redhat.com) wrote: > Currently, setup_mounts() bind-mounts the shared directory w

Re: [PATCH V2] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

+julie + laine Rebased patch to latest Qemu master. Only minimal changes. > On Apr 28, 2020, at 3:46 PM, Ani Sinha wrote: > > A new option "use_acpi_unplug" is introduced for PIIX which will > selectively only disable hot unplugging of both hot plugged and > cold plugged PCI devices on non-roo

[PATCH V2] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

A new option "use_acpi_unplug" is introduced for PIIX which will selectively only disable hot unplugging of both hot plugged and cold plugged PCI devices on non-root PCI buses. This will prevent hot unplugging of devices from Windows based guests from system tray but will not prevent devices from b

Re: [PATCH 1/2] tpm: tpm-tis-device: set PPI to false by default

On Mon, 27 Apr 2020 16:31:44 +0200 Eric Auger wrote: > The tpm-tis-device device does not support PPI. Let's > change the default value for the corresponding property > instead of tricking this latter in the mach-virt machine. > > Signed-off-by: Eric Auger > --- > hw/tpm/tpm_tis_sysbus.c | 2 +

Re: [PATCH 2/2] hw/arm/virt: Remove the compat forcing tpm-tis-device PPI to off

On Mon, 27 Apr 2020 16:31:45 +0200 Eric Auger wrote: > Now that the tpm-tis-device device PPI property is off by default, > we can remove the compat used for the same goal. > > Signed-off-by: Eric Auger > --- > hw/arm/virt.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/hw/arm/

Re: [PATCH 0/2] virt: Set tpm-tis-device ppi property to off by default

On Mon, 27 Apr 2020 16:31:43 +0200 Eric Auger wrote: > Instead of using a compat in the mach-virt machine to force > PPI off for all virt machines (PPI not supported by the > tpm-tis-device device), let's simply change the default value > in the sysbus device. > > Best Regards > > Eric > > Eri

Re: [PATCH 3/3] virtio-net: remove VIRTIO_NET_HDR_F_RSC_INFO compat handling

On Tue, Apr 28, 2020 at 12:18 PM Cornelia Huck wrote: > On Tue, 28 Apr 2020 16:58:44 +0800 > Jason Wang wrote: > > > On 2020/4/28 下午4:34, Cornelia Huck wrote: > > > On Tue, 28 Apr 2020 16:19:15 +0800 > > > Jason Wang wrote: > > > > > >> On 2020/4/27 下午6:24, Cornelia Huck wrote: > > >>> VIRTIO_N

Re: [PATCH 0/2] virt: Set tpm-tis-device ppi property to off by default

Hi Stefan, On 4/27/20 10:21 PM, Stefan Berger wrote: > On 4/27/20 10:31 AM, Eric Auger wrote: >> Instead of using a compat in the mach-virt machine to force >> PPI off for all virt machines (PPI not supported by the >> tpm-tis-device device), let's simply change the default value >> in the sysbus

Re: [PATCH v2] char-socket: initialize reconnect timer only when the timer doesn't start

Hi On Tue, Apr 28, 2020 at 10:59 AM Li Feng wrote: > > Sorry for sending the weird same mail out. > Ignore the second one. > > Hi Lureau, > > I found another issue when running my new test: tests/test-char -p > /char/socket/client/reconnect-error/unix > The backtrace like this: > #0 0x7

Re: backing chain & block status & filters

On 28.04.20 10:55, Vladimir Sementsov-Ogievskiy wrote: > Hi! > > I wanted to resend my "[PATCH 0/4] fix & merge block_status_above and > is_allocated_above", and returned to all the inconsistencies about > block-status. I keep in mind Max's series about child-access functions, > and Andrey's work

Re: backing chain & block status & filters

Am 28.04.2020 um 13:08 hat Max Reitz geschrieben: > On 28.04.20 10:55, Vladimir Sementsov-Ogievskiy wrote: > > Hi! > > > > I wanted to resend my "[PATCH 0/4] fix & merge block_status_above and > > is_allocated_above", and returned to all the inconsistencies about > > block-status. I keep in mind M

Re: [PATCH 0/3] headers update and virtio-net fixup

On Mon, 27 Apr 2020 12:24:12 +0200 Cornelia Huck wrote: > This updates the headers to Linux 5.7-rc3. Doing so exposes > a problem in virtio-net (the #define for compat covers too much), > fix it. > > Note 1: I'd like this to go through s390-next so that I can go > ahead with protected vi

Re: [PATCH 1/2] virtiofsd: only retain file system capabilities

* Stefan Hajnoczi (stefa...@redhat.com) wrote: > virtiofsd runs as root but only needs a subset of root's Linux > capabilities(7). As a file server its purpose is to create and access > files on behalf of a client. It needs to be able to access files with > arbitrary uid/gid owners. It also need

Re: [PATCH v20 4/4] iotests: 287: add qcow2 compression type test

On 27.04.2020 16:29, Max Reitz wrote: On 21.04.20 10:11, Denis Plotnikov wrote: The test checks fulfilling qcow2 requirements for the compression type feature and zstd compression type operability. Signed-off-by: Denis Plotnikov --- tests/qemu-iotests/287 | 146 +++

Re: [PATCH v10 00/14] iotests: use python logging

On 31.03.20 02:00, John Snow wrote: > This series uses python logging to enable output conditionally on > iotests.log(). We unify an initialization call (which also enables > debugging output for those tests with -d) and then make the switch > inside of iotests. > > It will help alleviate the need

Re: [RFC PATCH v1 20/26] kvm: vmi: intercept live migration

On Mon, 27 Apr 2020 20:08:55 +0100, "Dr. David Alan Gilbert" wrote: > * Adalbert Lazăr (ala...@bitdefender.com) wrote: > > From: Marian Rotariu > > > > It is possible that the introspection tool has made some changes inside > > the introspected VM which can make the guest crash if the introspec

Re: [PATCH v10 00/14] iotests: use python logging

Am 28.04.2020 um 13:46 hat Max Reitz geschrieben: > On 31.03.20 02:00, John Snow wrote: > > This series uses python logging to enable output conditionally on > > iotests.log(). We unify an initialization call (which also enables > > debugging output for those tests with -d) and then make the switch

Re: [RFC PATCH v1 20/26] kvm: vmi: intercept live migration

* Adalbert Lazăr (ala...@bitdefender.com) wrote: > On Mon, 27 Apr 2020 20:08:55 +0100, "Dr. David Alan Gilbert" > wrote: > > * Adalbert Lazăr (ala...@bitdefender.com) wrote: > > > From: Marian Rotariu > > > > > > It is possible that the introspection tool has made some changes inside > > > the

RE: [PATCH 1/2] Fix undefined behaviour

> -Original Message- > From: Artur Puzio > Sent: 28 April 2020 10:41 > To: p...@xen.org; 'Grzegorz Uriasz' ; > qemu-devel@nongnu.org > Cc: marma...@invisiblethingslab.com; ja...@bartmin.ski; > j.nowa...@student.uw.edu.pl; 'Stefano > Stabellini' ; 'Anthony Perard' > ; xen- > de...@lists.

RE: [PATCH 1/2] Fix undefined behaviour

> -Original Message- > From: Paul Durrant > Sent: 28 April 2020 13:33 > To: 'Artur Puzio' ; 'Grzegorz Uriasz' > ; qemu-devel@nongnu.org > Cc: marma...@invisiblethingslab.com; ja...@bartmin.ski; > j.nowa...@student.uw.edu.pl; 'Stefano > Stabellini' ; 'Anthony Perard' > ; xen- > de...@lis

Re: [PATCH v3 1/3] block: Add blk_new_with_bs() helper

On 4/28/20 1:34 AM, Max Reitz wrote: block_crypto_co_create_generic(BlockDriverState *bs,     PreallocMode prealloc,     Error **errp)   { -    int ret; +    int ret = -EPERM; I’m not sure I’m a fan of this, bec

Re: [PATCH v20 4/4] iotests: 287: add qcow2 compression type test

On 28.04.20 13:41, Denis Plotnikov wrote: > > > On 27.04.2020 16:29, Max Reitz wrote: >> On 21.04.20 10:11, Denis Plotnikov wrote: >>> The test checks fulfilling qcow2 requirements for the compression >>> type feature and zstd compression type operability. >>> >>> Signed-off-by: Denis Plotnikov

Re: [PATCH 3/3] virtio-net: remove VIRTIO_NET_HDR_F_RSC_INFO compat handling

On 2020/4/28 下午5:18, Cornelia Huck wrote: On Tue, 28 Apr 2020 16:58:44 +0800 Jason Wang wrote: On 2020/4/28 下午4:34, Cornelia Huck wrote: On Tue, 28 Apr 2020 16:19:15 +0800 Jason Wang wrote: On 2020/4/27 下午6:24, Cornelia Huck wrote: VIRTIO_NET_HDR_F_RSC_INFO is available in the headers

Re: [PATCH v3 0/3] qcow2: Allow resize of images with internal snapshots

On 24.04.20 21:09, Eric Blake wrote: > In v3: > - patch 1: fix error returns [patchew, Max], R-b dropped > - patch 2,3: unchanged, so add R-b > > Eric Blake (3): > block: Add blk_new_with_bs() helper > qcow2: Allow resize of images with internal snapshots > qcow2: Tweak comment about bitmaps

Re: [PATCH v20 4/4] iotests: 287: add qcow2 compression type test

On 4/28/20 7:55 AM, Max Reitz wrote: +# This tests qocw2-specific low-level functionality +_supported_fmt qcow2 +_supported_proto file +_supported_os Linux This test doesn’t work with compat=0.10 (because we can’t store a non-default compression type there) or data_file (because those don’t sup

Re: [PATCH 3/3] virtio-net: remove VIRTIO_NET_HDR_F_RSC_INFO compat handling

On 2020/4/28 下午6:55, Yuri Benditovich wrote: On Tue, Apr 28, 2020 at 12:18 PM Cornelia Huck > wrote: On Tue, 28 Apr 2020 16:58:44 +0800 Jason Wang mailto:jasow...@redhat.com>> wrote: > On 2020/4/28 下午4:34, Cornelia Huck wrote: > > On Tue, 28 Apr 202

Re: [PATCH 4/5] ramfb: add sanity checks to ramfb_create_display_surface

On 04/27/20 13:11, Gerd Hoffmann wrote: >>> -size = (hwaddr)linesize * height; >>> -data = cpu_physical_memory_map(addr, &size, false); >>> -if (size != (hwaddr)linesize * height) { >>> -cpu_physical_memory_unmap(data, size, 0, 0); >>> +mapsize = size = stride * (height - 1)

Re: [RFC PATCH v1 20/26] kvm: vmi: intercept live migration

On Tue, 28 Apr 2020 13:24:39 +0100, "Dr. David Alan Gilbert" wrote: > * Adalbert Lazăr (ala...@bitdefender.com) wrote: > > On Mon, 27 Apr 2020 20:08:55 +0100, "Dr. David Alan Gilbert" > > wrote: > > > * Adalbert Lazăr (ala...@bitdefender.com) wrote: > > > > From: Marian Rotariu > > > > > > >

Re: [PATCH v2 02/14] qcrypto/luks: implement encryption key management

On Sun, Mar 08, 2020 at 05:18:51PM +0200, Maxim Levitsky wrote: > Next few patches will expose that functionality > to the user. > > Signed-off-by: Maxim Levitsky > --- > crypto/block-luks.c | 398 +++- > qapi/crypto.json| 61 ++- > 2 files change

Re: [PATCH v1] target/m68k: fix gdb for m68xxx

Le 4/27/20 à 9:53 AM, Laurent Vivier a écrit : Le 20/04/2020 à 16:01, frederic.kon...@adacore.com a écrit : From: KONRAD Frederic Currently "cf-core.xml" is sent to GDB when using any m68k flavor. Thing is it uses the "org.gnu.gdb.coldfire.core" feature name and gdb 8.3 then expects a cold

[PATCH 4/4] block: Use blk_make_empty() after commits

bdrv_commit() already has a BlockBackend pointing to the BDS that we want to empty, it just has the wrong permissions. qemu-img commit has no BlockBackend pointing to the old backing file yet, but introducing one is simple. After this commit, bdrv_make_empty() is the only remaining caller of Bloc

[PATCH 2/4] block: Use bdrv_make_empty() where possible

Signed-off-by: Max Reitz --- block/replication.c | 6 ++ block/vvfat.c | 4 +--- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/block/replication.c b/block/replication.c index da013c2041..cc6a40d577 100644 --- a/block/replication.c +++ b/block/replication.c @@ -331,9 +33

[PATCH 1/4] block: Add bdrv_make_empty()

Right now, all users of bdrv_make_empty() call the BlockDriver method directly. That is not only bad style, it is also wrong, unless the caller has a BdrvChild with a WRITE permission. Introduce bdrv_make_empty() that verifies that it does. Signed-off-by: Max Reitz --- include/block/block.h |

[PATCH 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly

Branch: https://github.com/XanClic/qemu.git fix-bdrv_make_empty-v1 Branch: https://git.xanclic.moe/XanClic/qemu.git fix-bdrv_make_empty-v1 Hi, Right now, there is no centralized bdrv_make_empty() function. Not only is it bad style to call BlockDriver methods directly, it is also wrong, unless th

[PATCH 3/4] block: Add blk_make_empty()

Two callers of BlockDriver.bdrv_make_empty() remain that should not call this method directly. Both do not have access to a BdrvChild, but they can use a BlockBackend, so we add this function that lets them use it. Signed-off-by: Max Reitz --- include/sysemu/block-backend.h | 2 ++ block/block-

[PATCH v21 0/4] implement zstd cluster compression method

v21: 03: * remove the loop on compression [Max] * use designated initializers [Max] 04: * don't erase user's options [Max] * use _rm_test_img [Max] * add unsupported qcow2 options [Max] v20: 04: fix a number of flaws [Vladimir] * don't use $RAND_F

[PATCH v21 2/4] qcow2: rework the cluster compression routine

The patch enables processing the image compression type defined for the image and chooses an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Reviewed-by: Max Reitz --- block/qcow2-threa

[PATCH v21 4/4] iotests: 287: add qcow2 compression type test

The test checks fulfilling qcow2 requirements for the compression type feature and zstd compression type operability. Signed-off-by: Denis Plotnikov Reviewed-by: Vladimir Sementsov-Ogievskiy Tested-by: Vladimir Sementsov-Ogievskiy --- slirp | 2 +- tests/qemu-iotests/287

Re: [PATCH v20 4/4] iotests: 287: add qcow2 compression type test

On 28.04.2020 16:01, Eric Blake wrote: On 4/28/20 7:55 AM, Max Reitz wrote: +# This tests qocw2-specific low-level functionality +_supported_fmt qcow2 +_supported_proto file +_supported_os Linux This test doesn’t work with compat=0.10 (because we can’t store a non-default compression type t

[PATCH v21 3/4] qcow2: add zstd cluster compression

zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment, is the only compression method available. The performance test results: Test compresses and decompresse

[PATCH v21 1/4] qcow2: introduce compression type feature

The patch adds some preparation parts for incompatible compression type feature to qcow2 allowing the use different compression methods for image clusters (de)compressing. It is implied that the compression type is set on the image creation and can be changed only later by image conversion, thus c

Re: [PATCH 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly

Patchew URL: https://patchew.org/QEMU/20200428132629.796753-1-mre...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash expor

Re: [RFC PATCH v1 20/26] kvm: vmi: intercept live migration

* Adalbert Lazăr (ala...@bitdefender.com) wrote: > On Tue, 28 Apr 2020 13:24:39 +0100, "Dr. David Alan Gilbert" > wrote: > > * Adalbert Lazăr (ala...@bitdefender.com) wrote: > > > On Mon, 27 Apr 2020 20:08:55 +0100, "Dr. David Alan Gilbert" > > > wrote: > > > > * Adalbert Lazăr (ala...@bitdefen

Re: [PATCH 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly

Patchew URL: https://patchew.org/QEMU/20200428132629.796753-1-mre...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly

On 4/28/20 8:26 AM, Max Reitz wrote: Branch: https://github.com/XanClic/qemu.git fix-bdrv_make_empty-v1 Branch: https://git.xanclic.moe/XanClic/qemu.git fix-bdrv_make_empty-v1 Hi, Right now, there is no centralized bdrv_make_empty() function. Not only is it bad style to call BlockDriver method

Re: [PATCH 1/4] block: Add bdrv_make_empty()

Am 28.04.2020 um 15:53 hat Eric Blake geschrieben: > On 4/28/20 8:26 AM, Max Reitz wrote: > > Right now, all users of bdrv_make_empty() call the BlockDriver method > > directly. That is not only bad style, it is also wrong, unless the > > caller has a BdrvChild with a WRITE permission. > > > > In

Re: [PATCH 2/4] block: Use bdrv_make_empty() where possible

On 4/28/20 8:26 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- block/replication.c | 6 ++ block/vvfat.c | 4 +--- 2 files changed, 3 insertions(+), 7 deletions(-) Yes, definitely nicer :) May have some obvious fallout to add a 0 flag parameter, per my request on 1/4, but t

Re: [PATCH 1/4] block: Add bdrv_make_empty()

On 4/28/20 8:26 AM, Max Reitz wrote: Right now, all users of bdrv_make_empty() call the BlockDriver method directly. That is not only bad style, it is also wrong, unless the caller has a BdrvChild with a WRITE permission. Introduce bdrv_make_empty() that verifies that it does. Signed-off-by: M

Re: [PATCH 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly

Patchew URL: https://patchew.org/QEMU/20200428132629.796753-1-mre...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #

Re: [PATCH 1/4] block: Add bdrv_make_empty()

On 4/28/20 9:01 AM, Kevin Wolf wrote: Can we please fix this to take a flags parameter? I want to make it easier for callers to request BDRV_REQ_NO_FALLBACK for distinguishing between callers where the image must be made empty (read as all zeroes) regardless of time spent, vs. made empty quickl

Re: [PATCH 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly

On 4/28/20 8:49 AM, Eric Blake wrote: On 4/28/20 8:26 AM, Max Reitz wrote: Branch: https://github.com/XanClic/qemu.git fix-bdrv_make_empty-v1 Branch: https://git.xanclic.moe/XanClic/qemu.git fix-bdrv_make_empty-v1 Hi, Right now, there is no centralized bdrv_make_empty() function.  Not only is

  1   2   3   4   >