On 6/26/20 11:32 AM, Daniel P. Berrangé wrote:
> On Fri, Jun 26, 2020 at 11:01:58AM +0200, Janosch Frank wrote:
>> On 6/26/20 8:53 AM, David Hildenbrand wrote:
>>> Does this have any implications when probing with the 'none' machine?
>>
>> I'm not sure. In your case, I guess the cpu bi
On 6/26/20 7:49 AM, Markus Armbruster wrote:
> Philippe Mathieu-Daudé writes:
>
>> On 6/25/20 10:12 AM, Philippe Mathieu-Daudé wrote:
>>> On 6/25/20 8:37 AM, Markus Armbruster wrote:
Cédric Le Goater writes:
> On 6/22/20 10:31 AM, Philippe Mathieu-Daudé wrote:
>> On 6/22/20 8:2
On Fri, Jun 26, 2020 at 11:01:58AM +0200, Janosch Frank wrote:
> On 6/26/20 8:53 AM, David Hildenbrand wrote:
> > Does this have any implications when probing with the 'none' machine?
>
> I'm not sure. In your case, I guess the cpu bit would still show up
> as before, so it woul
The existing ADB state machine is designed to work with Linux which has a
different
interpretation of the state machine detailed in "Guide to the Macintosh Family
Hardware". In particular the current Linux implementation includes an extra
change
to IDLE state when switching the VIA between send a
On 6/26/20 11:20 AM, Thomas Huth wrote:
> On 26/06/2020 11.13, Philippe Mathieu-Daudé wrote:
>> On 6/26/20 9:37 AM, Aleksandar Markovic wrote:
>>> пет, 26. јун 2020. у 09:11 Aleksandar Markovic
>>> <1885...@bugs.launchpad.net> је написао/ла:
Public bug reported:
The code base is
Currently the logic is split between the mos6522 portB_write() callback and
the memory region used to capture the VIA1 MMIO accesses. Move everything
into the latter mos6522_q800_via1_write() function to keep all the logic in
one place to make it easier to follow.
Signed-off-by: Mark Cave-Ayland
This is to allow us to distinguish between ADB device events and ADB
bus events separately.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Finn Thain
Acked-by: Laurent Vivier
Message-Id: <20200623204936.24064-22-mark.cave-ayl...@ilande.co.uk>
---
hw/input/adb-k
Whilst autopoll is enabled it is necessary to prevent the ADB buffer contents
from being overwritten until the host has read back the response in its
entirety.
Add adb_autopoll_block() and adb_autopoll_unblock() functions in preparation
for ensuring that the ADB buffer contents are protected for e
Ensure that the PMU buffer is protected from autopoll requests overwriting
its contents whilst existing PMU requests are in progress.
Signed-off-by: Mark Cave-Ayland
Tested-by: Finn Thain
Acked-by: Laurent Vivier
Message-Id: <20200623204936.24064-18-mark.cave-ayl...@ilande.co.uk>
---
hw/misc/m
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Finn Thain
Acked-by: Laurent Vivier
Message-Id: <20200623204936.24064-23-mark.cave-ayl...@ilande.co.uk>
---
hw/input/adb.c| 21 -
hw/input/trace-events | 7 +++
2 files changed, 27 i
Currently adb_request() is called both for explicit ADB requests and internal
autopoll requests via adb_poll().
Move the current functionality into do_adb_request() to be used internally and
add a simple adb_request() wrapper for explicit requests.
Signed-off-by: Mark Cave-Ayland
Tested-by: Finn
Handle this at the ADB bus level so that individual implementations do not need
to handle this themselves.
Finally add an assert() into adb_request() to prevent developers from
accidentally
making an explicit ADB request without blocking autopoll.
Signed-off-by: Mark Cave-Ayland
Tested-by: Finn
Ensure that the CUDA buffer is protected from autopoll requests overwriting
its contents whilst existing CUDA requests are in progress.
Signed-off-by: Mark Cave-Ayland
Tested-by: Finn Thain
Acked-by: Laurent Vivier
Message-Id: <20200623204936.24064-17-mark.cave-ayl...@ilande.co.uk>
---
hw/misc
Rather than each ADB implementation requiring its own functions to manage
autopoll state, timers, and autopoll masks prepare to move this information
directly into ADBBusState.
Add external functions within adb.h to allow each ADB implementation to
manage the new autopoll variables.
Signed-off-by
Add a new pending variable to ADBBusState which is a bitmask indicating which
ADB devices have data to send. Update the bitmask every time that an ADB
request is executed.
Signed-off-by: Mark Cave-Ayland
Tested-by: Finn Thain
Acked-by: Laurent Vivier
Message-Id: <20200623204936.24064-13-mark.ca
Currently only 2 bits are defined: one to indicate if the request timed out (no
reply) and another to indicate whether the request was the result of an autopoll
operation.
Signed-off-by: Mark Cave-Ayland
Tested-by: Finn Thain
Acked-by: Laurent Vivier
Message-Id: <20200623204936.24064-14-mark.ca
Signed-off-by: Mark Cave-Ayland
Tested-by: Finn Thain
Acked-by: Laurent Vivier
Message-Id: <20200623204936.24064-11-mark.cave-ayl...@ilande.co.uk>
---
hw/misc/mac_via.c | 22 ++
include/hw/misc/mac_via.h | 1 -
2 files changed, 10 insertions(+), 13 deletions(-)
dif
This is required later to allow devices to assert a service request (SRQ)
signal to indicate that it has data to send, without having to consume it.
Signed-off-by: Mark Cave-Ayland
Tested-by: Finn Thain
Acked-by: Laurent Vivier
Message-Id: <20200623204936.24064-12-mark.cave-ayl...@ilande.co.uk>
Don't use a fixed value but instead use the default value from the ADB bus
state.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Finn Thain
Acked-by: Laurent Vivier
Message-Id: <20200623204936.24064-6-mark.cave-ayl...@ilande.co.uk>
---
hw/misc/macio/pmu.c | 4 +
This is in preparation for consolidating all of the ADB autopoll management
in one place.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Finn Thain
Acked-by: Laurent Vivier
Message-Id: <20200623204936.24064-4-mark.cave-ayl...@ilande.co.uk>
---
hw/misc/macio/cud
Signed-off-by: Mark Cave-Ayland
Tested-by: Finn Thain
Acked-by: Laurent Vivier
Message-Id: <20200623204936.24064-9-mark.cave-ayl...@ilande.co.uk>
---
hw/misc/macio/cuda.c | 56 +++-
include/hw/misc/macio/cuda.h | 4 ---
2 files changed, 23 insertions(+),
It seems that during the initial work to introduce the via-pmu ADB support a
duplicate autopoll mask variable was accidentally left in place.
Remove the duplicate autopoll_mask variable and switch everything over to
use adb_poll_mask instead.
Signed-off-by: Mark Cave-Ayland
Tested-by: Finn Thain
Signed-off-by: Mark Cave-Ayland
Tested-by: Finn Thain
Acked-by: Laurent Vivier
Message-Id: <20200623204936.24064-10-mark.cave-ayl...@ilande.co.uk>
---
hw/misc/macio/pmu.c | 39 ++---
include/hw/misc/macio/pmu.h | 3 ---
2 files changed, 15 insertions(+),
The following changes since commit 5acc270a355120ce967ca1f1eeca0abbdb9303c8:
Merge remote-tracking branch 'remotes/xtensa/tags/20200625-xtensa' into
staging (2020-06-25 21:20:45 +0100)
are available in the Git repository at:
git://github.com/mcayland/qemu.git tags/qemu-macppc-202
Signed-off-by: Mark Cave-Ayland
Tested-by: Finn Thain
Acked-by: Laurent Vivier
Message-Id: <20200623204936.24064-7-mark.cave-ayl...@ilande.co.uk>
---
hw/input/adb.c | 32
1 file changed, 32 insertions(+)
diff --git a/hw/input/adb.c b/hw/input/adb.c
index d85278
This will help ensure that style guidelines are being maintained during
subsequent changes.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Finn Thain
Acked-by: Laurent Vivier
Message-Id: <20200623204936.24064-2-mark.cave-ayl...@ilande.co.uk>
---
hw/input/adb.c
Commit 84051eb400 "adb: add property to disable direct reg 3 writes" introduced
a workaround for spurious writes to ADB register 3 when MacOS 9 enables
autopoll on the mouse device. Further analysis shows that the problem is that
only a partial request is sent, and since the len parameter is ignore
On 26/06/2020 11.13, Philippe Mathieu-Daudé wrote:
On 6/26/20 9:37 AM, Aleksandar Markovic wrote:
пет, 26. јун 2020. у 09:11 Aleksandar Markovic
<1885...@bugs.launchpad.net> је написао/ла:
Public bug reported:
The code base is on master, checked out on Thursday June25th 2020,
0250c595c9d. The
On 6/25/20 9:27 PM, no-re...@patchew.org wrote:
> Patchew URL:
> https://patchew.org/QEMU/20200625184838.28172-1-phi...@redhat.com/
>
>
>
> Hi,
>
> This series failed the docker-quick@centos7 build test. Please find the
> testing commands and
> their output below. If you have Docker installed
I suspect an extra uintptr_t cast will fix this:
p = (void *)(uintptr_t)(((uintptr_t)iter->map & TARGET_PAGE_MASK) |
off_in_page);
Which looks kind of ugly but then the code is taking a host void*
(iter->map), casting it to integer to do arithmetic on and then wanting
to get it back to a void* wh
On Thu, Jun 25, 2020 at 11:03:36PM +0100, Beata Michalska wrote:
> Injecting external data abort through KVM might trigger
> an issue on kernels that do not get updated to include the KVM fix.
> For those and aarch32 guests, the injected abort gets misconfigured
> to be an implementation defined ex
On 6/26/20 9:37 AM, Aleksandar Markovic wrote:
> пет, 26. јун 2020. у 09:11 Aleksandar Markovic
> <1885...@bugs.launchpad.net> је написао/ла:
>>
>> Public bug reported:
>>
>> The code base is on master, checked out on Thursday June25th 2020,
>> 0250c595c9d. The build procedure:
>>
>> $ mkdir build-
Hi Markus
On 6/26/20 10:53 AM, Markus Armbruster wrote:
> Auger Eric writes:
>
>> Hi Markus,
>> On 6/25/20 9:05 AM, Markus Armbruster wrote:
>>> Eric Auger writes:
>>>
This patch implements the PROBE request. At the moment,
only THE RESV_MEM property is handled. The first goal is
On 6/26/20 8:53 AM, David Hildenbrand wrote:
> Does this have any implications when probing with the 'none' machine?
I'm not sure. In your case, I guess the cpu bit would still show up
as before, so it would tell you base feature availability, but not
whether you can use th
On Thu, Jun 25, 2020 at 11:03:35PM +0100, Beata Michalska wrote:
> On ARMv7 & ARMv8 some load/store instructions might trigger a data abort
> exception with no valid ISS info to be decoded. The lack of decode info
> makes it at least tricky to emulate those instruction which is one of the
> (many)
Auger Eric writes:
> Hi Markus,
> On 6/25/20 9:05 AM, Markus Armbruster wrote:
>> Eric Auger writes:
>>
>>> This patch implements the PROBE request. At the moment,
>>> only THE RESV_MEM property is handled. The first goal is
>>> to report iommu wide reserved regions such as the MSI regions
>>>
On Thu, 25 Jun 2020 at 22:31, David CARLIER wrote:
>
> From 78706a28c6aa8b5e522b5781588b38961d79d6f6 Mon Sep 17 00:00:00 2001
> From: David Carlier
> Date: Thu, 25 Jun 2020 19:32:42 +
> Subject: [PATCH] build: haiku system build fix
>
> Most of missing features resides in the bsd library.
> A
On Fri, 26 Jun 2020 at 00:07, Keith Packard wrote:
>
> 'virtm' is a hardware target that is designed to be used for compiler
> and library testing on Cortex-M processors. It supports all cortex-m
> processors and includes sufficient memory to run even large test
> cases.
>
> Signed-off-by: Keith P
On Thu, 25 Jun 2020 at 09:11, Max Filippov wrote:
>
> Hi Peter,
>
> please pull the following batch of fixes for the target/xtensa.
>
> The following changes since commit 648db19685b7030aa558a4ddbd3a8e53d8c9a062:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2020-04-29'
> into
On 6/11/20 8:16 PM, Denis V. Lunev wrote:
> Nowaday SCSI drivers in guests are able to align UNMAP requests before
> sending to the device. Right now QEMU provides an ability to set
> this via "discard_granularity" property of the block device which could
> be used by management layer.
>
> Though,
On 6/25/20 2:58 PM, Thomas Huth wrote:
> On 24/06/2020 09.52, Janosch Frank wrote:
>> jump_to_IPL_code takes a 64 bit address, masks it with the short psw
>> address mask and later branches to it using a full 64 bit register.
>>
>> * As the masking is not necessary, let's remove it
>> * Without the
On 6/25/20 2:46 PM, Thomas Huth wrote:
> On 24/06/2020 09.52, Janosch Frank wrote:
>> The component entries written by zipl contain short PSWs, not
>> addresses. Let's mask them and only pass the address part to
>> jump_to_IPL_code(uint64_t address) because it expects an address as
>> visible by th
On Wed, Jun 24, 2020 at 09:47:59AM -0400, Michael S. Tsirkin wrote:
> On Wed, Jun 24, 2020 at 03:26:20PM +0200, Eric Auger wrote:
> > By default the virtio-iommu translates MSI transactions. This
> > behavior is inherited from ARM SMMU. However the virt machine
> > code knows where the MSI doorbell
On 26/06/2020 08:14, Laurent Vivier wrote:
> Le 23/06/2020 à 22:49, Mark Cave-Ayland a écrit :
>> This patchset is something I have been chipping away at for a while since
>> spending some time over the Christmas holidays trying to boot the MacOS
>> toolbox ROM on the new q800 machine.
>>
>> Initi
Hi Peter,
On 6/25/20 12:12 PM, Peter Maydell wrote:
> On Thu, 25 Jun 2020 at 08:06, Markus Armbruster wrote:
>> $ qemu-system-x86_64 -nodefaults -S -display none -device
>> virtio-iommu-pci,len-reserved-regions=1,reserved-regions[0]=0xfee0:0xfeef:99
>> qemu-system-x86_64: -device
Hi Peter,
On 6/25/20 12:01 PM, Peter Maydell wrote:
> On Wed, 24 Jun 2020 at 14:27, Eric Auger wrote:
>>
>> At the moment the virtio-iommu translates MSI transactions.
>> This behavior is inherited from ARM SMMU. The virt machine
>> code knows where the guest MSI doorbells are so we can easily
>>
Hi Markus,
On 6/25/20 9:05 AM, Markus Armbruster wrote:
> Eric Auger writes:
>
>> This patch implements the PROBE request. At the moment,
>> only THE RESV_MEM property is handled. The first goal is
>> to report iommu wide reserved regions such as the MSI regions
>> set by the machine code. On x86
Hi Peter,
On 6/25/20 12:08 PM, Peter Maydell wrote:
> Fix a typo in an error message in virtio_iommu_pci_realize():
> "Check you machine" should be "Check your machine".
>
> Reported-by: Markus Armbruster
> Signed-off-by: Peter Maydell
Reviewed-by: Eric Auger
Thanks
Eric
> ---
> hw/virtio/
пет, 26. јун 2020. у 09:11 Aleksandar Markovic
<1885...@bugs.launchpad.net> је написао/ла:
>
> Public bug reported:
>
> The code base is on master, checked out on Thursday June25th 2020,
> 0250c595c9d. The build procedure:
>
> $ mkdir build-gcc
> $ cd build-gcc
> $ ../configure
> $ make
>
> The bui
Let's auto-enable it also when maxmem is specified but no slots are
defined. This will result in us properly creating ACPI srat tables,
indicating the maximum possible PFN to the guest OS. Based on this, e.g.,
Linux will enable the swiotlb properly.
This avoids having to manually force the switolb
The content of unplugged memory is undefined and should not be migrated,
ever. Exclude all unplugged memory during precopy using the precopy notifier
infrastructure introduced for free page hinting in virtio-balloon.
Unplugged memory is marked as "not dirty", meaning it won't be
considered for mig
We want to make sure that certain properties don't change during
migration, especially to catch user errors in a nice way. Let's migrate
a temporary structure and validate that the properties didn't change.
Reviewed-by: Dr. David Alan Gilbert
Cc: "Michael S. Tsirkin"
Cc: "Dr. David Alan Gilbert"
Let's wire it up similar to virtio-pmem. Also disallow unplug, so it's
harder for users to shoot themselves into the foot.
Reviewed-by: Pankaj Gupta
Cc: "Michael S. Tsirkin"
Cc: Marcel Apfelbaum
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Eduardo Habkost
Cc: Eric Blake
Cc: Markus Armbruster
Let's add some trace events that might come in handy later.
Cc: "Michael S. Tsirkin"
Cc: "Dr. David Alan Gilbert"
Signed-off-by: David Hildenbrand
---
hw/virtio/trace-events | 10 ++
hw/virtio/virtio-mem.c | 10 +-
2 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/
Let's register the notifier and trigger the qapi event with the right
device id.
MEMORY_DEVICE_SIZE_CHANGE is similar to BALLOON_CHANGE, however on a
memory device level.
Don't unregister the notifier (we neither have finalize() nor unrealize()
for VirtIOPCIProxy, so it's not that simple to do it
Account the memory to the configured nid.
Reviewed-by: Pankaj Gupta
Cc: Eduardo Habkost
Cc: Marcel Apfelbaum
Cc: "Michael S. Tsirkin"
Signed-off-by: David Hildenbrand
---
hw/core/numa.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/hw/core/numa.c b/hw/core/numa.c
index 5f81900f88
Print the memory device info just like for other memory devices.
Reviewed-by: Dr. David Alan Gilbert
Cc: "Dr. David Alan Gilbert"
Cc: "Michael S. Tsirkin"
Signed-off-by: David Hildenbrand
---
monitor/hmp-cmds.c | 16
1 file changed, 16 insertions(+)
diff --git a/monitor/hmp-
RDMA will pin all guest memory (as documented in docs/rdma.txt). We want
to disable RAM block discards - however, to keep it simple use
ram_block_discard_is_required() instead of inhibiting.
Note: It is not sufficient to limit disabling to pin_all. Even when only
conditionally pinning 1 MB chunks,
We want to send qapi events in case the size of a virtio-mem device
changes. This allows upper layers to always know how much memory is
actually currently consumed via a virtio-mem device.
Unfortuantely, we have to report the id of our proxy device. Let's provide
an easy way for our proxy device t
Discarding RAM does not work as expected with protected VMs. Let's
switch to ram_block_discard_disable() for now, as we want to get rid
of qemu_balloon_inhibit(). Note that it will currently never fail, but
might fail in the future with new technologies (e.g., virtio-mem).
Acked-by: Cornelia Huck
Let's add a proxy for virtio-mem, make it a memory device, and
pass-through the properties.
Reviewed-by: Pankaj Gupta
Cc: "Michael S. Tsirkin"
Cc: Marcel Apfelbaum
Cc: "Dr. David Alan Gilbert"
Cc: Igor Mammedov
Signed-off-by: David Hildenbrand
---
hw/virtio/Makefile.objs| 1 +
hw/virt
Let's make sure patches/bug reports find the right person.
Reviewed-by: Dr. David Alan Gilbert
Cc: "Michael S. Tsirkin"
Cc: Peter Maydell
Cc: Markus Armbruster
Signed-off-by: David Hildenbrand
---
MAINTAINERS | 9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAIN
AMD SEV will pin all guest memory, mark discarding of RAM broken. At the
time this is called, we cannot have anyone active that relies on discards
to work properly - let's still implement error handling.
Reviewed-by: Dr. David Alan Gilbert
Cc: "Michael S. Tsirkin"
Cc: Paolo Bonzini
Cc: Richard
Discarding memory does not work as expected. At the time this is called,
we cannot have anyone active that relies on discards to work properly.
Reviewed-by: Dr. David Alan Gilbert
Cc: Paolo Bonzini
Signed-off-by: David Hildenbrand
---
accel/kvm/kvm-all.c | 4 ++--
1 file changed, 2 insertions(
The only remaining special case is postcopy. It cannot handle
concurrent discards yet, which would result in requesting already sent
pages from the source. Special-case it in virtio-balloon instead.
Introduce migration_in_incoming_postcopy(), to find out if incoming
postcopy is active.
Reviewed-b
This is the very basic/initial version of virtio-mem. An introduction to
virtio-mem can be found in the Linux kernel driver [1]. While it can be
used in the current state for hotplug of a smaller amount of memory, it
will heavily benefit from resizeable memory regions in the future.
Each virtio-me
COLO will copy all memory in a RAM block, disable discarding of RAM.
Reviewed-by: Dr. David Alan Gilbert
Tested-by: Lukas Straub
Cc: "Michael S. Tsirkin"
Cc: Hailiang Zhang
Cc: Juan Quintela
Cc: "Dr. David Alan Gilbert"
Signed-off-by: David Hildenbrand
---
include/migration/colo.h | 2 +-
VFIO is (except devices without a physical IOMMU or some mediated devices)
incompatible with discarding of RAM. The kernel will pin basically all VM
memory. Let's convert to ram_block_discard_disable(), which can now
fail, in contrast to qemu_balloon_inhibit().
Leave "x-balloon-allowed" named as i
We want to replace qemu_balloon_inhibit() by something more generic.
Especially, we want to make sure that technologies that really rely on
RAM block discards to work reliably to run mutual exclusive with
technologies that effectively break it.
E.g., vfio will usually pin all guest memory, turning
E.g., with "pc-q35-4.2", trying to coldplug a virtio-pmem-pci devices
results in
"virtio-pmem-pci not supported on this bus"
Reasons is, that the bus does not support hotplug and, therefore, does
not have a hotplug handler. Let's allow coldplugging virtio-pmem devices
on such buses. The hotplu
This is the very basic, initial version of virtio-mem. More info on
virtio-mem in general can be found in the Linux kernel driver v2 posting
[1] and in patch #10. The Linux driver is now upstream.
This series now contains a resend of [3]:
"[PATCH v1] pc: Support coldplugging of virtio-pmem-pci
Le 23/06/2020 à 22:49, Mark Cave-Ayland a écrit :
> This patchset is something I have been chipping away at for a while since
> spending some time over the Christmas holidays trying to boot the MacOS
> toolbox ROM on the new q800 machine.
>
> Initially I discovered that there were some problems wh
Public bug reported:
The code base is on master, checked out on Thursday June25th 2020,
0250c595c9d. The build procedure:
$ mkdir build-gcc
$ cd build-gcc
$ ../configure
$ make
The build error message is:
CC x86_64-softmmu/hw/hyperv/hyperv.o
CC x86_64-softmmu/hw/hyperv/hyperv_test
501 - 573 of 573 matches
Mail list logo