Re: [PATCH v7 09/21] multi-process: Initialize message handler in remote device

2020-06-30 Thread Stefan Hajnoczi
On Sat, Jun 27, 2020 at 10:09:31AM -0700, elena.ufimts...@oracle.com wrote: > diff --git a/hw/i386/remote-msg.c b/hw/i386/remote-msg.c > new file mode 100644 > index 00..58e24ab2ad > --- /dev/null > +++ b/hw/i386/remote-msg.c > @@ -0,0 +1,52 @@ > +#include "qemu/osdep.h" > +#include "qemu-c

Re: [PATCH v4 0/3] Avoid abort on QMP attempt to add an object with duplicate id

2020-06-30 Thread Auger Eric
Hi Paolo, On 6/29/20 5:30 PM, Paolo Bonzini wrote: > On 29/06/20 13:23, Eric Auger wrote: >> Attempting to add an object through QMP with an id that is >> already used leads to a qemu abort. This is a regression since >> d2623129a7de ("qom: Drop parameter @errp of object_property_add() >> & friend

Re: [PATCH v7 08/21] multi-process: Initialize communication channel at the remote end

2020-06-30 Thread Stefan Hajnoczi
On Sat, Jun 27, 2020 at 10:09:30AM -0700, elena.ufimts...@oracle.com wrote: > @@ -42,6 +43,20 @@ static void remote_machine_init(MachineState *machine) > qdev_realize(DEVICE(rem_host), sysbus_get_default(), &error_fatal); > } > > +static void remote_set_socket(Object *obj, const char *str,

Re: [PATCH v2 11/18] hw/block/nvme: Introduce max active and open zone limits

2020-06-30 Thread Klaus Jensen
On Jun 18 06:34, Dmitry Fomichev wrote: > Added two module properties, "max_active" and "max_open" to control > the maximum number of zones that can be active or open. Once these > variables are set to non-default values, the driver checks these > limits during I/O and returns Too Many Active or To

Re: [PATCH v2 12/18] hw/block/nvme: Simulate Zone Active excursions

2020-06-30 Thread Klaus Jensen
On Jun 18 06:34, Dmitry Fomichev wrote: > Added a Boolean flag to turn on simulation of Zone Active Excursions. > If the flag, "active_excursions", is set to true, the driver will try > to finish one of the currently open zone if max active zones limit is > going to get exceeded. > > Signed-off-by

Re: [PATCH 2/2] xen: cleanup unrealized flash devices

2020-06-30 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 6/30/20 5:44 PM, Paul Durrant wrote: >>> -Original Message- >>> From: Philippe Mathieu-Daudé >>> Sent: 30 June 2020 16:26 >>> To: Paul Durrant ; xen-de...@lists.xenproject.org; >>> qemu-devel@nongnu.org >>> Cc: Eduardo Habkost ; Michael S. Tsirkin >>

Re: [PATCH 2/2] xen: cleanup unrealized flash devices

2020-06-30 Thread Markus Armbruster
Anthony PERARD writes: > On Wed, Jun 24, 2020 at 01:18:41PM +0100, Paul Durrant wrote: >> From: Paul Durrant >> >> The generic pc_machine_initfn() calls pc_system_flash_create() which creates >> 'system.flash0' and 'system.flash1' devices. These devices are then realized >> by pc_system_flash_m

Re: [PATCH v2 1/2] net: tap: check if the file descriptor is valid before using it

2020-06-30 Thread Markus Armbruster
Laurent Vivier writes: > qemu_set_nonblock() checks that the file descriptor can be used and, if > not, crashes QEMU. An assert() is used for that. The use of assert() is > used to detect programming error and the coredump will allow to debug > the problem. > > But in the case of the tap device,

Re: [PATCH] pc: fix leak in pc_system_flash_cleanup_unused

2020-06-30 Thread Paolo Bonzini
On 01/07/20 03:58, Alexander Bulekov wrote: > fix a leak detected when building with --enable-sanitizers: > ./i386-softmmu/qemu-system-i386 > Upon exit: > ==13576==ERROR: LeakSanitizer: detected memory leaks > > Direct leak of 1216 byte(s) in 1 object(s) allocated from: > #0 0x7f9d2ed5c628 in

Re: [PATCH v2 00/12] vDPA support in qemu

2020-06-30 Thread Cindy Lu
Thanks Jason, I'm working in this, Will update a new version soon On Wed, Jul 1, 2020 at 1:29 PM Jason Wang wrote: > > > On 2020/7/1 上午2:06, no-re...@patchew.org wrote: > > Patchew URL: > > https://patchew.org/QEMU/20200630174937.25560-1-l...@redhat.com/ > > > > > > > > Hi, > > > > This series f

Re: [PATCH v2 00/12] vDPA support in qemu

2020-06-30 Thread Jason Wang
On 2020/7/1 上午2:06, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200630174937.25560-1-l...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably r

Re: [PATCH v2 11/12] vhost-vdpa: introduce vhost-vdpa backend

2020-06-30 Thread Jason Wang
On 2020/7/1 上午1:49, Cindy Lu wrote: Currently we have 2 types of vhost backends in QEMU: vhost kernel and vhost-user. The above patch provides a generic device for vDPA purpose, this vDPA device exposes to user space a non-vendor-specific configuration interface for setting up a vhost HW accele

[Bug 1885827] [NEW] building plugin failed on Windows with mingw

2020-06-30 Thread Xiaolei
Public bug reported: I want to build QEMU 4.2.0's plugin module on Windows 7/10 with Mingw, but the building process faild. The step I follow is listed below: 1. create "dsp_build" diretory under source file folder 2. change directory to dsp_build , and run ../configure --target-list=dsp-sof

[PATCH] pc: fix leak in pc_system_flash_cleanup_unused

2020-06-30 Thread Alexander Bulekov
fix a leak detected when building with --enable-sanitizers: ./i386-softmmu/qemu-system-i386 Upon exit: ==13576==ERROR: LeakSanitizer: detected memory leaks Direct leak of 1216 byte(s) in 1 object(s) allocated from: #0 0x7f9d2ed5c628 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5) #1 0x7

[Bug 1869006] Re: PCIe cards passthrough to TCG guest works on 2GB of guest memory but fails on 4GB (vfio_dma_map invalid arg)

2020-06-30 Thread Alex Williamson
You'd need to create a 160KB VM in order to stay below the required direct map memory regions imposed by the system firmware (e8000 - c). Non-upstream bypasses of those restrictions are clearly not supported. You can find more details regarding the RMRR restriction here: https://access.red

Re: [PATCH v3 0/5] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

2020-06-30 Thread Jiaxun Yang
在 2020/7/1 3:57, Philippe Mathieu-Daudé 写道: Hi, This series add a new 'malta-strict' machine, that aims to properly model the real hardware (which is not what the current 'malta' machine models). Just putting my random words here as things had became really tense.. My orginal proposal was

Re: [PATCH v3 7/9] tz-ppc: add dummy read/write methods

2020-06-30 Thread Li Qiang
P J P 于2020年6月30日周二 下午8:31写道: > > From: Prasad J Pandit > > Add tz-ppc-dummy mmio read/write methods to avoid assert failure > during initialisation. > > Signed-off-by: Prasad J Pandit Reviewed-by: Li Qiang > --- > hw/misc/tz-ppc.c | 14 ++ > 1 file changed, 14 insertions(+) > >

Re: [PATCH v3 0/5] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

2020-06-30 Thread BALATON Zoltan
On Tue, 30 Jun 2020, Aleksandar Markovic wrote: As, in a very clear way, evidenced from the previous versions of this series, this series real goal was not not to create some new "malta-strict" machine, but to prepare path to creation of some imagined "malta-unleashed" machine which will, to the

RE: [PATCH 00/10] hw/block/nvme: namespace types and zoned namespaces

2020-06-30 Thread Dmitry Fomichev
> -Original Message- > From: Klaus Jensen > Sent: Tuesday, June 30, 2020 4:30 PM > To: Niklas Cassel > Cc: qemu-bl...@nongnu.org; Klaus Jensen ; > qemu-devel@nongnu.org; Keith Busch ; Max Reitz > ; Kevin Wolf ; Javier Gonzalez > ; Maxim Levitsky ; > Philippe Mathieu-Daudé ; Dmitry Fomic

Re: [PATCH 14/17] hw/arm/spitz: Use LOG_GUEST_ERROR for bad guest register accesses

2020-06-30 Thread Alistair Francis
On Sun, Jun 28, 2020 at 7:33 AM Peter Maydell wrote: > > Instead of logging guest accesses to invalid register offsets in the > Spitz flash device with zaurus_printf() (which just prints to stderr), > use the usual qemu_log_mask(LOG_GUEST_ERROR,...). > > Signed-off-by: Peter Maydell Reviewed-by:

Re: [PATCH 15/17] hw/arm/pxa2xx_pic: Use LOG_GUEST_ERROR for bad guest register accesses

2020-06-30 Thread Alistair Francis
On Sun, Jun 28, 2020 at 7:29 AM Peter Maydell wrote: > > Instead of using printf() for logging guest accesses to invalid > register offsets in the pxa2xx PIC device, use the usual > qemu_log_mask(LOG_GUEST_ERROR,...). > > This was the only user of the REG_FMT macro in pxa.h, so we can > remove tha

Re: [PATCH 13/17] hw/gpio/zaurus.c: Use LOG_GUEST_ERROR for bad guest register accesses

2020-06-30 Thread Alistair Francis
On Sun, Jun 28, 2020 at 7:35 AM Peter Maydell wrote: > > Instead of logging guest accesses to invalid register offsets in this > device using zaurus_printf() (which just prints to stderr), use the > usual qemu_log_mask(LOG_GUEST_ERROR,...). > > Since this was the only use of the zaurus_printf() ma

Re: [PATCH 10/17] hw/misc/max111x: Use GPIO lines rather than max111x_set_input()

2020-06-30 Thread Alistair Francis
On Sun, Jun 28, 2020 at 7:28 AM Peter Maydell wrote: > > The max111x ADC device model allows other code to set the level on > the 8 ADC inputs using the max111x_set_input() function. Replace > this with generic qdev GPIO inputs, which also allow inputs to be set > to arbitrary values. > > Using G

Re: [PATCH v2 12/18] hw/block/nvme: Simulate Zone Active excursions

2020-06-30 Thread Alistair Francis
On Wed, Jun 17, 2020 at 2:52 PM Dmitry Fomichev wrote: > > Added a Boolean flag to turn on simulation of Zone Active Excursions. > If the flag, "active_excursions", is set to true, the driver will try > to finish one of the currently open zone if max active zones limit is > going to get exceeded.

Re: [PATCH v2 11/18] hw/block/nvme: Introduce max active and open zone limits

2020-06-30 Thread Alistair Francis
On Wed, Jun 17, 2020 at 3:07 PM Dmitry Fomichev wrote: > > Added two module properties, "max_active" and "max_open" to control > the maximum number of zones that can be active or open. Once these > variables are set to non-default values, the driver checks these > limits during I/O and returns Too

[Bug 1869006] Re: PCIe cards passthrough to TCG guest works on 2GB of guest memory but fails on 4GB (vfio_dma_map invalid arg)

2020-06-30 Thread costinel
except that in my case the vm does not boot at all no matter how less memory I allocate to it. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1869006 Title: PCIe cards passthrough to TCG guest works

[Bug 1869006] Re: PCIe cards passthrough to TCG guest works on 2GB of guest memory but fails on 4GB (vfio_dma_map invalid arg)

2020-06-30 Thread costinel
I am experiencing the same behaviour for x86_64 guest on x86_64 host to which I'm attempting to efi boot (not hotplug) with a pcie gpu passthrough This discussion (https://www.spinics.net/lists/iommu/msg40613.html) suggests a change in drivers/iommu/intel-iommu.c but it appears that in the kernel

Re: [PATCH v1 2/3] hw/riscv: Allow 64 bit access to SiFive CLINT

2020-06-30 Thread LIU Zhiwei
On 2020/7/1 4:12, Alistair Francis wrote: Commit 5d971f9e672507210e77d020d89e0e89165c8fc9 "memory: Revert "memory: accept mismatching sizes in memory_region_access_valid"" broke most RISC-V boards as they do 64 bit accesses to the CLINT and QEMU would trigger a fault. Fix this failure by allow

Re: [PATCH v1 3/3] target/riscv: Regen floating point rounding mode in dynamic mode

2020-06-30 Thread LIU Zhiwei
On 2020/7/1 5:51, Richard Henderson wrote: On 6/30/20 1:12 PM, Alistair Francis wrote: When a guest specificies the the rounding mode should be dynamic 0b111 then we want to re-caclulate the rounding mode on each instruction. The gen_helper_set_rounding_mode() function will correctly check th

Re: [PATCH v2 08/18] hw/block/nvme: Make Zoned NS Command Set definitions

2020-06-30 Thread Alistair Francis
On Wed, Jun 17, 2020 at 2:51 PM Dmitry Fomichev wrote: > > Define values and structures that are needed to support Zoned > Namespace Command Set (NVMe TP 4053) in PCI NVMe controller emulator. > > All new protocol definitions are located in include/block/nvme.h > and everything added that is speci

Re: [PATCH v3 0/5] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

2020-06-30 Thread Aleksandar Markovic
As, in a very clear way, evidenced from the previous versions of this series, this series real goal was not not to create some new "malta-strict" machine, but to prepare path to creation of some imagined "malta-unleashed" machine which will, to the contrary of proclaimed goal, create a machine that

Re: [PATCH v1 3/3] target/riscv: Regen floating point rounding mode in dynamic mode

2020-06-30 Thread Richard Henderson
On 6/30/20 1:12 PM, Alistair Francis wrote: > When a guest specificies the the rounding mode should be dynamic 0b111 > then we want to re-caclulate the rounding mode on each instruction. The > gen_helper_set_rounding_mode() function will correctly check the > rounding mode and handle a dynamic roun

Re: [PATCH v7 1/8] mac_oldworld: Allow loading binary ROM image

2020-06-30 Thread BALATON Zoltan
On Tue, 30 Jun 2020, Mark Cave-Ayland wrote: On 29/06/2020 19:55, BALATON Zoltan wrote: The beige G3 Power Macintosh has a 4MB firmware ROM. Fix the size of the rom region and fall back to loading a binary image with -bios if loading ELF image failed. This allows testing emulation with a ROM ima

Re: [PATCH v3 2/2] target/m68k: consolidate physical translation offset into get_physical_address()

2020-06-30 Thread Laurent Vivier
Le 30/06/2020 à 13:27, Mark Cave-Ayland a écrit : > Since all callers to get_physical_address() now apply the same page offset to > the translation result, move the logic into get_physical_address() itself to > avoid duplication. > > Suggested-by: Philippe Mathieu-Daudé > Signed-off-by: Mark Cave

[Bug 1885350] Re: RISCV dynamic rounding mode is not behaving correctly

2020-06-30 Thread Mina Magdy
Thank you Alistair Francis. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1885350 Title: RISCV dynamic rounding mode is not behaving correctly Status in QEMU: New Bug description: Hello, I

Re: [PATCH 08/17] ssi: Add ssi_realize_and_unref()

2020-06-30 Thread Alistair Francis
On Sun, Jun 28, 2020 at 7:27 AM Peter Maydell wrote: > > Add an ssi_realize_and_unref(), for the benefit of callers > who want to be able to create an SSI device, set QOM properties > on it, and then do the realize-and-unref afterwards. > > The API works on the same principle as the recently added

Re: [PATCH 07/17] hw/misc/max111x: Don't use vmstate_register()

2020-06-30 Thread Alistair Francis
On Sun, Jun 28, 2020 at 7:25 AM Peter Maydell wrote: > > The max111x is a proper qdev device; we can use dc->vmsd rather than > directly calling vmstate_register(). > > It's possible that this is a migration compat break, but the only > boards that use this device are the spitz-family ('akita', 'b

Re: [PATCH 06/17] hw/misc/max111x: provide QOM properties for setting initial values

2020-06-30 Thread Alistair Francis
On Sun, Jun 28, 2020 at 7:29 AM Peter Maydell wrote: > > Add some QOM properties to the max111x ADC device to allow the > initial values to be configured. Currently this is done by > board code calling max111x_set_input() after it creates the > device, which doesn't work on system reset. > > This

Re: [PATCH 05/17] hw/arm/spitz: Implement inbound GPIO lines for bit5 and power signals

2020-06-30 Thread Alistair Francis
On Sun, Jun 28, 2020 at 7:29 AM Peter Maydell wrote: > > Currently the Spitz board uses a nasty hack for the GPIO lines > that pass "bit5" and "power" information to the LCD controller: > the lcdtg realize function sets a global variable to point to > the instance it just realized, and then the fu

Re: [PATCH v4] sm501: Fix and optimize overlap check

2020-06-30 Thread Gerd Hoffmann
On Wed, Jun 24, 2020 at 06:42:18PM +0200, BALATON Zoltan wrote: > When doing reverse blit we need to check if source and dest overlap > but it is not trivial due to possible different base and pitch of > source and dest. Do rectangle overlap if base and pitch match, > otherwise just check if memory

[Bug 1885350] Re: RISCV dynamic rounding mode is not behaving correctly

2020-06-30 Thread Alistair Francis
This does look like incorrect behaviour. I have sent a patch to the mailing list. You can see the patch here: https://patchew.org/QEMU/cover.1593547870.git.alistair.fran...@wdc.com/ea4f280e6f77e734c8e555e3c98d10085ce9f5b6.1593547870.git.alistair.fran...@wdc.com/ -- You received this bug notificat

Re: [PATCH v7 0/8] Mac Old World ROM experiment

2020-06-30 Thread BALATON Zoltan
On Tue, 30 Jun 2020, Mark Cave-Ayland wrote: On 29/06/2020 19:55, BALATON Zoltan wrote: This is now a minimal set of patches needed to make it possible to experiment with a firmware ROM from real hardware. After finding out that the board firmware does not probe PCI devices but expects them at k

Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

2020-06-30 Thread Richard Henderson
On 6/30/20 10:28 AM, Aleksandar Markovic wrote: > уто, 30. јун 2020. у 19:16 Philippe Mathieu-Daudé је > написао/ла: >> >> On 6/30/20 6:55 PM, Aleksandar Markovic wrote: >>> уто, 30. јун 2020. у 18:46 Philippe Mathieu-Daudé је >>> написао/ла: On 6/30/20 5:38 PM, Aleksandar Markovic wrot

Re: [PATCH 00/10] hw/block/nvme: namespace types and zoned namespaces

2020-06-30 Thread Klaus Jensen
On Jun 30 08:42, Keith Busch wrote: > On Tue, Jun 30, 2020 at 04:09:46PM +0200, Philippe Mathieu-Daudé wrote: > > What I see doable for the following days is: > > - hw/block/nvme: Fix I/O BAR structure [3] > > - hw/block/nvme: handle transient dma errors > > - hw/block/nvme: bump to v1.3 > > > Th

Re: [PATCH 00/10] hw/block/nvme: namespace types and zoned namespaces

2020-06-30 Thread Klaus Jensen
On Jun 30 12:59, Niklas Cassel wrote: > On Tue, Jun 30, 2020 at 12:01:29PM +0200, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Hi all, > > Hello Klaus, > Hi Niklas, > > > > * the controller uses timers to autonomously finish zones (wrt. FRL) > > AFAICT, Dmitry's patches does this as

Re: [PATCH v2 06/18] hw/block/nvme: Define trace events related to NS Types

2020-06-30 Thread Alistair Francis
On Wed, Jun 17, 2020 at 2:46 PM Dmitry Fomichev wrote: > > A few trace events are defined that are relevant to implementing > Namespace Types (NVMe TP 4056). > > Signed-off-by: Dmitry Fomichev Reviewed-by: Alistair Francis Alistair > --- > hw/block/trace-events | 11 +++ > 1 file cha

[PATCH] tests/acceptance/machine_rx_gdbsim: Use stable URL for test_linux_sash

2020-06-30 Thread Philippe Mathieu-Daudé
Yoshinori said [*] URL references on OSDN were stable, but they appear not to be. Mirror the artifacts on GitHub to avoid failures while testing on CI. [*] https://www.mail-archive.com/qemu-devel@nongnu.org/msg686487.html Cc: Yoshinori Sato Reported-by: Alex Bennée Signed-off-by: Philippe Mathi

[PATCH v1 3/3] target/riscv: Regen floating point rounding mode in dynamic mode

2020-06-30 Thread Alistair Francis
When a guest specificies the the rounding mode should be dynamic 0b111 then we want to re-caclulate the rounding mode on each instruction. The gen_helper_set_rounding_mode() function will correctly check the rounding mode and handle a dynamic rounding, we just need to make sure it's always called i

[PATCH v1 0/3] A few RISC-V fixes

2020-06-30 Thread Alistair Francis
This series has a few fixes for RISC-V. Alistair Francis (3): hw/char: Convert the Ibex UART to use the qdev Clock model hw/riscv: Allow 64 bit access to SiFive CLINT target/riscv: Regen floating point rounding mode in dynamic mode include/hw/char/ibex_uart.h | 2 ++ hw/char/ibex_uart

[PATCH v1 2/3] hw/riscv: Allow 64 bit access to SiFive CLINT

2020-06-30 Thread Alistair Francis
Commit 5d971f9e672507210e77d020d89e0e89165c8fc9 "memory: Revert "memory: accept mismatching sizes in memory_region_access_valid"" broke most RISC-V boards as they do 64 bit accesses to the CLINT and QEMU would trigger a fault. Fix this failure by allowing 8 byte accesses. Signed-off-by: Alistair F

[PATCH v1 1/3] hw/char: Convert the Ibex UART to use the qdev Clock model

2020-06-30 Thread Alistair Francis
Conver the Ibex UART to use the recently added qdev-clock functions. Signed-off-by: Alistair Francis --- include/hw/char/ibex_uart.h | 2 ++ hw/char/ibex_uart.c | 19 ++- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/include/hw/char/ibex_uart.h b/include

Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

2020-06-30 Thread Thomas Huth
On 30/06/2020 17.38, Aleksandar Markovic wrote: уто, 30. јун 2020. у 16:52 Philippe Mathieu-Daudé је написао/ла: Hi, This series add a new 'malta-strict' machine, that aims to properly model the real hardware (which is not what the current 'malta' machine models). As a bonus for Debian build

Re: [PATCH v3 15/26] hw: Fix error API violation around object_property_set_link()

2020-06-30 Thread Mark Cave-Ayland
On 30/06/2020 10:03, Markus Armbruster wrote: > The Error ** argument must be NULL, &error_abort, &error_fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it no longer poi

[PATCH v3 5/5] hw/mips/malta: Verify malta-strict machine uses correct DIMM sizes

2020-06-30 Thread Philippe Mathieu-Daudé
The machine has 4 DIMM slots. Each DIMM must be a power of 2. Add a check the total RAM is a good combination of DIMMs. Example when asking a combination not power of 2: $ qemu-system-mips -M malta-strict -bios /dev/null -m 252 qemu-system-mips: RAM size must be the combination of 4 powers of

[PATCH v3 4/5] hw/mips/malta: Introduce the 'malta-strict' machine

2020-06-30 Thread Philippe Mathieu-Daudé
Introduce the 'malta-strict' machine, aiming to have the same limitations as real hardware. Start with 32 MB which is the default on the CoreLV, and allow up to 256 MB which is the maximum this card can accept. See datasheet 'MIPS Document Number: MD00051 Revision 01.07'. Example when asking a t

[PATCH v3 3/5] hw/mips/malta: Introduce MaltaMachineClass::max_ramsize

2020-06-30 Thread Philippe Mathieu-Daudé
The maximum RAM size is tied to the machine. First add the MaltaMachineClass, and add 'max_ramsize' to it. Set it to the current value of 2 GB, and adapt the code checking for the requested RAM is usable by the machine. Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/malta.c | 31 +

[PATCH v3 2/5] hw/mips/malta: Register the machine as a TypeInfo

2020-06-30 Thread Philippe Mathieu-Daudé
We want to add more machines. First convert from the old DEFINE_MACHINE() API to the more recent DEFINE_TYPES(TypeInfo[]) one. Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/malta.c | 32 1 file changed, 28 insertions(+), 4 deletions(-) diff --git a/hw/mips/m

[PATCH v3 1/5] hw/mips/malta: Trivial code movement

2020-06-30 Thread Philippe Mathieu-Daudé
Trivial code movement to make the next patch easier to review. Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/malta.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/mips/malta.c b/hw/mips/malta.c index d95926a89c..5b371c1e34 100644 --- a/hw/mips/malta.c

[PATCH v3 0/5] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

2020-06-30 Thread Philippe Mathieu-Daudé
Hi, This series add a new 'malta-strict' machine, that aims to properly model the real hardware (which is not what the current 'malta' machine models). Since v2: - Initialize missing malta_machine_types::class_size - Remove RFC patch that confuses Aleksandar - Added examples of 'malta-strict' use

Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

2020-06-30 Thread Philippe Mathieu-Daudé
On 6/30/20 7:28 PM, Aleksandar Markovic wrote: > уто, 30. јун 2020. у 19:16 Philippe Mathieu-Daudé је > написао/ла: >> >> On 6/30/20 6:55 PM, Aleksandar Markovic wrote: >>> уто, 30. јун 2020. у 18:46 Philippe Mathieu-Daudé је >>> написао/ла: On 6/30/20 5:38 PM, Aleksandar Markovic wrote

Re: [PATCH v7 0/8] Mac Old World ROM experiment

2020-06-30 Thread Mark Cave-Ayland
On 29/06/2020 19:55, BALATON Zoltan wrote: > This is now a minimal set of patches needed to make it possible to > experiment with a firmware ROM from real hardware. After finding out > that the board firmware does not probe PCI devices but expects them at > known fixed addresses we only need to ch

Re: [PATCH v7 5/8] mac_oldworld: Change PCI address of macio to match real hardware

2020-06-30 Thread Mark Cave-Ayland
On 29/06/2020 19:55, BALATON Zoltan wrote: > The board firmware expect these to be at fixed addresses and programs > them without probing, this patch puts the macio device at the expected > PCI address. > > Signed-off-by: BALATON Zoltan > --- > hw/ppc/mac_oldworld.c | 2 +- > 1 file changed, 1

[PATCH v2 07/12] block/nvme: Replace qemu_try_blockalign0 by qemu_try_blockalign/memset

2020-06-30 Thread Philippe Mathieu-Daudé
In the next commit we'll get rid of qemu_try_blockalign(). To ease review, first replace qemu_try_blockalign0() by explicit calls to qemu_try_blockalign() and memset(). Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 16 +--- 1 file changed, 9 i

[PATCH v2 11/12] block/nvme: Simplify nvme_create_queue_pair() arguments

2020-06-30 Thread Philippe Mathieu-Daudé
nvme_create_queue_pair() doesn't require BlockDriverState anymore. Replace it by BDRVNVMeState and AioContext to simplify. Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/block/

[PATCH v2 06/12] block/nvme: Use union of NvmeIdCtrl / NvmeIdNs structures

2020-06-30 Thread Philippe Mathieu-Daudé
We allocate an unique chunk of memory then use it for two different structures. By using an union, we make it clear the data is overlapping (and we can remove the casts). Suggested-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 31 +++ 1

[PATCH v2 12/12] block/nvme: Use per-queue AIO context

2020-06-30 Thread Philippe Mathieu-Daudé
To be able to use multiple queues on the same hardware, we need to have each queue able to receive IRQ notifications in the correct AIO context. The AIO context and the notification handler have to be proper to each queue, not to the block driver. Move aio_context and irq_notifier from BDRVNVMeStat

[PATCH v2 08/12] block/nvme: Replace qemu_try_blockalign(bs) by qemu_try_memalign(pg_sz)

2020-06-30 Thread Philippe Mathieu-Daudé
qemu_try_blockalign() is a generic API that call back to the block driver to return its page alignment. As we call from within the very same driver, we already know to page alignment stored in our state. Remove indirections and use the value from BDRVNVMeState. This change is required to later remo

[PATCH v2 05/12] block/nvme: Rename local variable

2020-06-30 Thread Philippe Mathieu-Daudé
We are going to modify the code in the next commit. Renaming the 'resp' variable to 'id' first makes the next commit easier to review. No logical changes. Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#2] Dissecting QEMU Into Three Main Parts

2020-06-30 Thread Ahmed Karaman
On Tue, Jun 30, 2020 at 2:46 PM Lukáš Doktor wrote: > > > However, we know that the results for hosts of different architectures > > will be different - we expect that. > > > > 32-bit Intel host will also most likely produce significantly > > different results than 64-bit Intel hosts. By the way,

[PATCH v2 09/12] block/nvme: Simplify nvme_init_queue() arguments

2020-06-30 Thread Philippe Mathieu-Daudé
nvme_init_queue() doesn't require BlockDriverState anymore. Replace it by BDRVNVMeState to simplify. Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/block/nvme.c b/block/nvme.c index 8

[PATCH v2 04/12] block/nvme: Define QUEUE_INDEX macros to ease code review

2020-06-30 Thread Philippe Mathieu-Daudé
Use definitions instead of '0' or '1' indexes. Also this will be useful when using multi-queues later. Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/bloc

[PATCH v2 10/12] block/nvme: Replace BDRV_POLL_WHILE by AIO_WAIT_WHILE

2020-06-30 Thread Philippe Mathieu-Daudé
BDRV_POLL_WHILE() is defined as: #define BDRV_POLL_WHILE(bs, cond) ({ \ BlockDriverState *bs_ = (bs); \ AIO_WAIT_WHILE(bdrv_get_aio_context(bs_), \ cond); }) As we will remove the BlockDriverState use in the next commit, start by using the e

Re: [PATCH v7 1/8] mac_oldworld: Allow loading binary ROM image

2020-06-30 Thread Mark Cave-Ayland
On 29/06/2020 19:55, BALATON Zoltan wrote: > The beige G3 Power Macintosh has a 4MB firmware ROM. Fix the size of > the rom region and fall back to loading a binary image with -bios if > loading ELF image failed. This allows testing emulation with a ROM > image from real hardware as well as using

[PATCH v2 03/12] block/nvme: Let nvme_create_queue_pair() fail gracefully

2020-06-30 Thread Philippe Mathieu-Daudé
As nvme_create_queue_pair() is allowed to fail, replace the alloc() calls by try_alloc() to avoid aborting QEMU. Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/block/nvme.c b/b

[PATCH v2 01/12] block/nvme: Replace magic value by SCALE_MS definition

2020-06-30 Thread Philippe Mathieu-Daudé
Use self-explicit SCALE_MS definition instead of magic value. Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/nvme.c b/block/nvme.c index 374e268915..2f5e3c2adf 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -715,7

[PATCH v2 00/12] block/nvme: Various cleanups required to use multiple queues

2020-06-30 Thread Philippe Mathieu-Daudé
Hi, This series is mostly code rearrangement (cleanups) to be able to split the hardware code from the block driver code, to be able to use multiple queues on the same hardware, or multiple block drivers on the same hardware. Missing review: 1, 2, 5, 6, 8, 12. Since v1: - rebased - use SCALE_MS

[PATCH v2 02/12] block/nvme: Avoid further processing if trace event not enabled

2020-06-30 Thread Philippe Mathieu-Daudé
Avoid further processing if TRACE_NVME_SUBMIT_COMMAND_RAW is not enabled. This is an untested intend of performance optimization. Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/nvme.c b/block/nvme.c index 2f5e3c2adf..8c30a5fee2

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#2] Dissecting QEMU Into Three Main Parts

2020-06-30 Thread Ahmed Karaman
On Tue, Jun 30, 2020 at 11:52 AM Aleksandar Markovic wrote: > > > As far as I know, this is how Ahmed test bed is setup: > > > > 1) Fresh installation on Ubuntu 18.04 on an Inter 64-bit host. > > 2) Install QEMU build prerequisite packages. > > 3) Install perf (this step is not necessary for Repor

Re: [PATCH v7 07/21] multi-process: add co-routines to communicate with remote

2020-06-30 Thread Stefan Hajnoczi
On Sat, Jun 27, 2020 at 10:09:29AM -0700, elena.ufimts...@oracle.com wrote: > From: Elena Ufimtseva > > process to avoid blocking the main loop during the message exchanges. > To be used by proxy device. The nested aio_poll() in this patch could be a problem. I've highlighted it here so that oth

RE: [PATCH v2 3/3] usb/hcd-xhci: Split pci wrapper for xhci base model

2020-06-30 Thread Sai Pavan Boddu
Hi Gred, > -Original Message- > From: Gerd Hoffmann > Sent: Tuesday, June 30, 2020 1:09 AM > To: Sai Pavan Boddu > Cc: Markus Armbruster ; Peter Maydell > ; Thomas Huth ; Eduardo > Habkost ; qemu-devel@nongnu.org; Alistair Francis > ; Paolo Bonzini ; Ying > Fang ; 'Marc-André Lureau' > ;

Re: [PATCH v2 00/12] vDPA support in qemu

2020-06-30 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200630174937.25560-1-l...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #! /

Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

2020-06-30 Thread Christian Schoenebeck
On Dienstag, 30. Juni 2020 18:39:57 CEST Greg Kurz wrote: > On Tue, 30 Jun 2020 17:16:40 +0200 > > Christian Schoenebeck wrote: > > On Montag, 29. Juni 2020 18:39:02 CEST Greg Kurz wrote: > > > On Wed, 03 Jun 2020 19:16:08 +0200 > > > > > > Christian Schoenebeck wrote: > > > > On Sonntag, 19. A

[PATCH v2 12/12] vhost-vdpa: introduce vhost-vdpa net client

2020-06-30 Thread Cindy Lu
This patch set introduces a new net client type: vhost-vdpa. vhost-vdpa net client will set up a vDPA device which is specified by a "vhostdev" parameter. Signed-off-by: Lingshan Zhu Signed-off-by: Tiwei Bie Signed-off-by: Cindy Lu --- include/net/vhost-vdpa.h | 22 net/Makefile.objs

[PATCH v2 11/12] vhost-vdpa: introduce vhost-vdpa backend

2020-06-30 Thread Cindy Lu
Currently we have 2 types of vhost backends in QEMU: vhost kernel and vhost-user. The above patch provides a generic device for vDPA purpose, this vDPA device exposes to user space a non-vendor-specific configuration interface for setting up a vhost HW accelerator, this patch set introduces a third

[PATCH v2 10/12] vhost: introduce new VhostOps vhost_get_device_id

2020-06-30 Thread Cindy Lu
This patch introduces new VhostOps vhost_get_device_id callback which can get the device id from backend Signed-off-by: Cindy Lu --- include/hw/virtio/vhost-backend.h | 4 1 file changed, 4 insertions(+) diff --git a/include/hw/virtio/vhost-backend.h b/include/hw/virtio/vhost-backend.h in

[PATCH v2 09/12] vhost: implement vhost_vq_get_addr method

2020-06-30 Thread Cindy Lu
use vhost_vq_get_addr callback to get the vq address from backend Signed-off-by: Cindy Lu --- hw/virtio/vhost.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 32809e54b5..1e083a8976 100644 --- a/hw/vir

[PATCH v2 07/12] vhost: implement vhost_dev_start method

2020-06-30 Thread Cindy Lu
use the vhost_dev_start callback to send the status to backend Signed-off-by: Cindy Lu --- hw/virtio/vhost.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 10304b583e..32809e54b5 100644 --- a/hw/virtio/vhost.c +++ b/hw/vi

[PATCH v2 05/12] vhost: check the existence of vhost_set_iotlb_callback

2020-06-30 Thread Cindy Lu
From: Jason Wang Add the check of vhost_set_iotlb_callback before calling Signed-off-by: Jason Wang Signed-off-by: Cindy Lu --- hw/virtio/vhost.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 5fd25fe520..10304b583e 100

[PATCH v2 08/12] vhost: introduce new VhostOps vhost_vq_get_addr

2020-06-30 Thread Cindy Lu
This patch introduces new VhostOps vhost_vq_get_addr_op callback to get the vring addr from the backend Signed-off-by: Cindy Lu --- include/hw/virtio/vhost-backend.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/hw/virtio/vhost-backend.h b/include/hw/virtio/vhost-backend.h i

[PATCH v2 06/12] vhost: introduce new VhostOps vhost_dev_start

2020-06-30 Thread Cindy Lu
This patch introduces new VhostOps vhost_dev_start callback which allows the vhost_net set the start/stop status to backend Signed-off-by: Cindy Lu --- include/hw/virtio/vhost-backend.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/hw/virtio/vhost-backend.h b/include/hw/virtio/v

[PATCH v2 03/12] virtio-bus: introduce queue_enabled method

2020-06-30 Thread Cindy Lu
From: Jason Wang This patch introduces queue_enabled() method which allows the transport to implement its own way to report whether or not a queue is enabled. Signed-off-by: Jason Wang Signed-off-by: Cindy Lu --- hw/virtio/virtio.c | 6 ++ include/hw/virtio/virtio-bus.h | 4 ++

[PATCH v2 04/12] virtio-pci: implement queue_enabled method

2020-06-30 Thread Cindy Lu
From: Jason Wang With version 1, we can detect whether a queue is enabled via queue_enabled. Signed-off-by: Jason Wang Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 7b

[PATCH v2 02/12] vhost_net: use the function qemu_get_peer

2020-06-30 Thread Cindy Lu
user the qemu_get_peer to replace the old process Signed-off-by: Cindy Lu Reviewed-by: Laurent Vivier --- hw/net/vhost_net.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c index 6b82803fa7..4096d64aaf 100644 --- a/hw

[PATCH v2 01/12] net: introduce qemu_get_peer

2020-06-30 Thread Cindy Lu
This is a small function that can get the peer from given NetClientState and queue_index Signed-off-by: Cindy Lu --- include/net/net.h | 1 + net/net.c | 7 +++ 2 files changed, 8 insertions(+) diff --git a/include/net/net.h b/include/net/net.h index 39085d9444..e7ef42d62b 100644 --

[PATCH v2 00/12] vDPA support in qemu

2020-06-30 Thread Cindy Lu
vDPA device is a device that uses a datapath which complies with the virtio specifications with vendor specific control path. vDPA devices can be both physically located on the hardware or emulated by software. This PATCH introduce the vDPA support in qemu TODO 1) vIOMMU support 2) live migration

Re: [PATCH v2 2/3] trace: Add support for recorder back-end

2020-06-30 Thread Dr. David Alan Gilbert
* Christophe de Dinechin (dinec...@redhat.com) wrote: > > On 2020-06-30 at 11:05 CEST, Dr. David Alan Gilbert wrote... > > * Christophe de Dinechin (dinec...@redhat.com) wrote: > >> The recorder library provides support for low-cost continuous > >> recording of events, which can then be replayed.

[Bug 1885350] Re: RISCV dynamic rounding mode is not behaving correctly

2020-06-30 Thread Alistair Francis
** Changed in: qemu Assignee: (unassigned) => Alistair Francis (alistair2323) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1885350 Title: RISCV dynamic rounding mode is not behaving correctly

Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

2020-06-30 Thread Aleksandar Markovic
уто, 30. јун 2020. у 19:16 Philippe Mathieu-Daudé је написао/ла: > > On 6/30/20 6:55 PM, Aleksandar Markovic wrote: > > уто, 30. јун 2020. у 18:46 Philippe Mathieu-Daudé је > > написао/ла: > >> > >> On 6/30/20 5:38 PM, Aleksandar Markovic wrote: > >>> уто, 30. јун 2020. у 16:52 Philippe Mathieu-D

Re: [PATCH 2/2] xen: cleanup unrealized flash devices

2020-06-30 Thread Philippe Mathieu-Daudé
On 6/30/20 5:44 PM, Paul Durrant wrote: >> -Original Message- >> From: Philippe Mathieu-Daudé >> Sent: 30 June 2020 16:26 >> To: Paul Durrant ; xen-de...@lists.xenproject.org; >> qemu-devel@nongnu.org >> Cc: Eduardo Habkost ; Michael S. Tsirkin >> ; Paul Durrant >> ; Jason Andryuk ; Paol

Re: [PATCH v2 1/2] target/mips: Remove identical if/else branches

2020-06-30 Thread Philippe Mathieu-Daudé
On 6/30/20 6:46 PM, Aleksandar Markovic wrote: > Remove the segment: > > if (other_tc == other->current_tc) { > tccause = other->CP0_Cause; > } else { > tccause = other->CP0_Cause; > } > > Original contributor can't remember what was his intention. > > Bug:

  1   2   3   4   5   >