Re: [PATCH] qemu-options.hx: Fix typo for netdev documentation

2020-07-26 Thread Li Qiang
Tianjia Zhang 于2020年7月27日周一 下午1:00写道: > > This patch fixes the netdev document description typo in qemu-option.hx. > > Signed-off-by: Tianjia Zhang Reviewed-by: Li Qiang > --- > qemu-options.hx | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-options.hx

Re: [PATCH] qemu-options.hx: Fix typo for netdev documentation

2020-07-26 Thread Thomas Huth
On 27/07/2020 06.59, Tianjia Zhang wrote: > This patch fixes the netdev document description typo in qemu-option.hx. > > Signed-off-by: Tianjia Zhang > --- > qemu-options.hx | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-26 Thread Thomas Huth
On 24/07/2020 18.49, Daniel P. Berrangé wrote: > On Fri, Jul 24, 2020 at 06:46:23PM +0200, Philippe Mathieu-Daudé wrote: >> On 7/24/20 4:46 PM, Daniel P. Berrangé wrote: >>> On Fri, Jul 24, 2020 at 04:32:19PM +0200, Thomas Huth wrote: Compiler warnings currently go unnoticed in our FreeBSD

[Bug 1889033] [NEW] qemu-img permission denied on vmdk creation on CIFS share

2020-07-26 Thread Hgkamath
Public bug reported: - on a CIFS mount qemu-img claims not to have permissions to write into a file. - VMDK sparse file creation succeeds - VMDK Flat file creation create the flat-file, but fails to write the description-file - VMDK flat file creation succeeds on native linux mount such as

[PATCH] qemu-options.hx: Fix typo for netdev documentation

2020-07-26 Thread Tianjia Zhang
This patch fixes the netdev document description typo in qemu-option.hx. Signed-off-by: Tianjia Zhang --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 708583b4ce..92556ed96d 100644 --- a/qemu-options.hx +++

Re: [PATCH] target/ppc: Fix SPE unavailable exception triggering

2020-07-26 Thread da...@gibson.dropbear.id.au
On Sun, Jul 26, 2020 at 04:59:16PM +, Matthieu Bucchianeri wrote: > Hello Balaton, > > Thank you for your thorough review! See my response below. > > > > static inline void gen_evmwsmiaa(DisasContext *ctx) { > > > -TCGv_i64 acc = tcg_temp_new_i64(); > > > -TCGv_i64 tmp =

[Bug 1888601] Re: QEMU v5.1.0-rc0/rc1 hang with nested virtualization

2020-07-26 Thread Jason Wang
Yon can get the calltrace by: 1) compile the qemu with --enable-debug 2) using gdb -p $pid_of_qemu when you see the hang 3) thread apply all bt Thanks -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[PATCH v2 1/2] linux-user: Fix 'mq_timedsend()' and 'mq_timedreceive()'

2020-07-26 Thread Filip Bozuta
Implementations of syscalls 'mq_timedsend()' and 'mq_timedreceive()' in 'syscall.c' use functions 'target_to_host_timespec()' and 'host_to_target_timespec()' to transfer the value of 'struct timespec' between target and host. However, the implementations don't check whether this conversion

[PATCH v2 2/2] linux-user: Add support for 'mq_timedsend_time64()' and 'mq_timedreceive_time64()'

2020-07-26 Thread Filip Bozuta
This patch implements functionality for following time64 syscalls: *mq_timedsend_time64() This is a year 2038 safe vairant of syscall: int mq_timedsend(mqd_t mqdes, const char *msg_ptr, size_t msg_len, unsigned int msg_prio, const struct

[PATCH v2 0/2] linux-user: Introducing functionality for two time64 syscalls

2020-07-26 Thread Filip Bozuta
This two patch series introduces functionality for two year 2038 safe syscalls. The first patch introduces a little correction for already implemented normal (32-bit) variants of implemented syscalls. The second patch introduces the implementation of the syscalls. Testing method: The

[Bug 1856335] Re: Cache Layout wrong on many Zen Arch CPUs

2020-07-26 Thread Sanjay Basu
h-sieger, I did some testing with geekbench 5: baseline multicore score = 12733 https://browser.geekbench.com/v5/cpu/3069626 score with option = 12775 https://browser.geekbench.com/v5/cpu/3069415 best score with your xml above = 16960 https://browser.geekbench.com/v5/cpu/3066003 I'm running

Re: [PATCH for 5.1] docs: fix trace docs build with sphinx 3.1.1

2020-07-26 Thread Andreas Schwab
On Jul 14 2020, Daniel P. Berrangé wrote: > In Fedora 33 rawhide, we now have sphinx 3.1.1, as opposed > to previous 2.2.2. This new version generates a warning on > the source: > > docs/qemu-option-trace.rst.inc:4:Malformed option description > '[enable=]PATTERN', should look like "opt", "-opt

[Bug 1880287] Re: gcc crashes in hppa emulation

2020-07-26 Thread Laurent Vivier
Fixed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=79826f99feb7 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1880287 Title: gcc crashes in hppa emulation Status in QEMU: Fix Committed

[Bug 1880287] Re: gcc crashes in hppa emulation

2020-07-26 Thread Richard Henderson
** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1880287 Title: gcc crashes in hppa emulation Status in QEMU: Fix Committed Bug

[Bug 1888165] Re: loopz/loopnz clearing previous instruction's modified flags on cx -> 0

2020-07-26 Thread Richard Henderson
** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888165 Title: loopz/loopnz clearing previous instruction's modified flags on cx -> 0

Re: [PULL 0/3] misc tcg-related patches

2020-07-26 Thread Peter Maydell
On Sat, 25 Jul 2020 at 17:05, Richard Henderson wrote: > > The following changes since commit 7adfbea8fd1efce36019a0c2f198ca73be9d3f18: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/x86-next-for-5.1-pull-request' into staging > (2020-07-24 10:52:20 +0100) > > are available in the

[Bug 1856335] Re: Cache Layout wrong on many Zen Arch CPUs

2020-07-26 Thread Heiko Sieger
@sanjaybmd I'm glad to read that it worked for you. In fact, since I posted the XML I didn't have the time to do benchmarking, now my motherboard is dead and I have to wait for repair/replacement. Do you have any data to quantify the performance gain? As to the number of cores, you will notice

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-26 Thread Christian Schoenebeck
On Sonntag, 26. Juli 2020 18:14:11 CEST Ed Maste wrote: > On Fri, 24 Jul 2020 at 10:32, Thomas Huth wrote: > > Compiler warnings currently go unnoticed in our FreeBSD and macOS builds, > > since -Werror is only enabled for Linux and MinGW builds by default. So > > let's enable them here now, too.

Re: [PATCH] target/ppc: Fix SPE unavailable exception triggering

2020-07-26 Thread Matthieu Bucchianeri
Hello Balaton, Thank you for your thorough review! See my response below. > > static inline void gen_evmwsmiaa(DisasContext *ctx) { > > -TCGv_i64 acc = tcg_temp_new_i64(); > > -TCGv_i64 tmp = tcg_temp_new_i64(); > > +TCGv_i64 acc; > > +TCGv_i64 tmp; > > + > > +if

Re: [PATCH 3/3] cirrus.yml: Update the macOS jobs to Catalina

2020-07-26 Thread Ed Maste
On Fri, 24 Jul 2020 at 10:32, Thomas Huth wrote: > > When looking at the CI jobs on cirrus-ci.com, it seems like the mojave-based > images have been decomissioned a while ago already, since apparently all our > jobs get automatically upgraded to catalina. So let's update our YML script >

Re: [PULL v1 0/3] Merge tpm 2020/07/24 v1

2020-07-26 Thread Peter Maydell
On Sat, 25 Jul 2020 at 01:22, Stefan Berger wrote: > > This series of patches corrects bad error reporting due to erroneous > or missing TPM related command line parameters. > > Regards, > Stefan > > The following changes since commit 7adfbea8fd1efce36019a0c2f198ca73be9d3f18: > > Merge

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-26 Thread Ed Maste
On Fri, 24 Jul 2020 at 10:32, Thomas Huth wrote: > > Compiler warnings currently go unnoticed in our FreeBSD and macOS builds, > since -Werror is only enabled for Linux and MinGW builds by default. So > let's enable them here now, too. Reviewed-by: Ed Maste for the FreeBSD change; I'm

[PATCH] slirp: update to latest stable-4.2 branch

2020-07-26 Thread Marc-André Lureau
Dr. David Alan Gilbert (1): ip_stripoptions use memmove Jindrich Novy (4): Fix possible infinite loops and use-after-free Use secure string copy to avoid overflow Be sure to initialize sockaddr structure Check lseek() for failure Marc-André Lureau (2): util:

[PATCH] target/i386: add -cpu,lbr=true support to enable guest LBR

2020-07-26 Thread Like Xu
The LBR feature would be enabled on the guest if: - the KVM is enabled and the PMU is enabled and, - the msr-based-feature IA32_PERF_CAPABILITIES is supporterd and, - the supported returned value for lbr_fmt from this msr is not zero. The LBR feature would be disabled on the guest if: - the

[PATCH] test-char: abort on serial test error

2020-07-26 Thread Marc-André Lureau
We are having issues debugging and bisecting this issue that happen mostly on patchew. Let's make it abort where it failed to gather some new informations. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Marc-André Lureau --- tests/test-char.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 1/2] block: nbd: Fix convert qcow2 compressed to nbd

2020-07-26 Thread Nir Soffer
When converting to qcow2 compressed format, the last step is a special zero length compressed write, ending in call to bdrv_co_truncate(). This call always fail for the nbd driver since it does not implement bdrv_co_truncate(). For block devices, which have the same limits, the call succeeds

[PATCH 2/2] qemu-iotests: Test convert to qcow2 compressed to NBD

2020-07-26 Thread Nir Soffer
Add test for "qemu-img convert -O qcow2 -c" to NBD target. The use case is writing compressed disk content to OVA archive. Signed-off-by: Nir Soffer --- tests/qemu-iotests/302 | 83 ++ tests/qemu-iotests/302.out | 27 +

[PATCH 0/2] Fix convert to qcow2 compressed to NBD

2020-07-26 Thread Nir Soffer
Fix qemu-img convert -O qcow2 -c to NBD URL and add missing test for this usage. This already works now, but unfortunately qemu-img fails when trying to truncate the target image to the same size at the end of the operation. Nir Soffer (2): block: nbd: Fix convert qcow2 compressed to nbd

[Bug 1856335] Re: Cache Layout wrong on many Zen Arch CPUs

2020-07-26 Thread Sanjay Basu
h-sieger, Your XML gave me very significant performance gains. Is there any way to do this with more than 24 assigned cores? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1856335 Title: Cache

Re: [PATCH] target/ppc: Fix SPE unavailable exception triggering

2020-07-26 Thread BALATON Zoltan
On Sat, 25 Jul 2020, Matthieu Bucchianeri wrote: When emulating certain floating point instructions or vector instructions on PowerPC machines, QEMU did not properly generate the SPE/Embedded Floating- Point Unavailable interrupt. See the buglink further below for references to the relevant NXP

Re: [PATCH v3 2/2] hw/pci-host: save/restore pci host config register for old ones

2020-07-26 Thread Michael S. Tsirkin
On Sat, Jul 25, 2020 at 08:54:37PM +0800, Hogan Wang wrote: > The i440fx and q35 machines integrate i440FX or MCH PCI device by default. > Refer to i440FX and ICH9-LPC spcifications, there are some reserved > configuration registers can used to save/restore PCIHostState.config_reg. > It's nasty

Re: [PATCH v3 1/2] hw/pci-host: save/restore pci host config register

2020-07-26 Thread Michael S. Tsirkin
On Sat, Jul 25, 2020 at 08:54:36PM +0800, Hogan Wang wrote: > The pci host config register is used to save PCI address for > read/write config data. If guest write a value to config register, > and then pause the vcpu to migrate, After the migration, the guest > continue to write pci config data,