Re: [PATCH v5 for-5.2] spapr: Use error_append_hint() in spapr_caps.c

2020-07-28 Thread David Gibson
On Tue, Jul 28, 2020 at 03:29:34PM +0200, Greg Kurz wrote: > We have a dedicated error API for hints. Use it instead of embedding > the hint in the error message, as recommanded in the "qapi/error.h" > header file. > > While here, have cap_fwnmi_apply(), which already uses > error_append_hint(), t

Re: [PATCH] hw: add compat machines for 5.2

2020-07-28 Thread Christian Borntraeger
On 28.07.20 11:46, Cornelia Huck wrote: > Add 5.2 machine types for arm/i440fx/q35/s390x/spapr. > > Signed-off-by: Cornelia Huck > --- > hw/arm/virt.c | 9 - > hw/core/machine.c | 3 +++ > hw/i386/pc.c | 3 +++ > hw/i386/pc_piix.c | 14 +

Re: [PATCH v11 09/11] qcow2_format.py: collect fields to dump in JSON format

2020-07-28 Thread Andrey Shinkevich
On 28.07.2020 14:09, Vladimir Sementsov-Ogievskiy wrote: 17.07.2020 11:14, Andrey Shinkevich wrote: As __dict__ is being extended with class members we do not want to print, add the to_dict() method to classes that returns a dictionary with desired fields and their values. Extend it in subclass

Re: [PULL for-5.1 3/3] tcg/cpu-exec: precise single-stepping after an interrupt

2020-07-28 Thread Pavel Dovgalyuk
On 17.07.2020 21:16, Richard Henderson wrote: When single-stepping with a debugger attached to QEMU, and when an interrupt is raised, the debugger misses the first instruction after the interrupt. Tested-by: Luc Michel Reviewed-by: Luc Michel Buglink: https://bugs.launchpad.net/qemu/+bug/75770

Re: [PATCH] hw: add compat machines for 5.2

2020-07-28 Thread David Gibson
On Tue, Jul 28, 2020 at 11:46:45AM +0200, Cornelia Huck wrote: > Add 5.2 machine types for arm/i440fx/q35/s390x/spapr. > > Signed-off-by: Cornelia Huck ppc parts Acked-by: David Gibson > --- > hw/arm/virt.c | 9 - > hw/core/machine.c | 3 +++ > hw/i386/pc.c

Re: [PATCH for-5.2] spapr: Avoid some integer conversions in spapr_phb_realize()

2020-07-28 Thread David Gibson
On Tue, Jul 28, 2020 at 11:14:13AM +0200, Greg Kurz wrote: > Without this patch, the irq number gets converted uselessly from int > to int32_t, back and forth. > > This doesn't fix an actual issue, it's just to make the code neater. > > Suggested-by: Markus Armbruster > Signed-off-by: Greg Kurz

Re: [PATCH] qcow2: cleanup created file when qcow2_co_create

2020-07-28 Thread Maxim Levitsky
On Thu, 2020-07-16 at 14:33 +0300, Maxim Levitsky wrote: > This is basically the same thing as commit > 'crypto.c: cleanup created file when block_crypto_co_create_opts_luks fails' > does but for qcow2 files to ensure that we don't leave qcow2 files > when creation fails. > > Signed-off-by: Maxim

Re: [PATCH v4 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u

2020-07-28 Thread Bin Meng
Hi Alistair, On Wed, Jul 29, 2020 at 1:05 PM Alistair Francis wrote: > > On Tue, Jul 28, 2020 at 9:51 PM Bin Meng wrote: > > > > Hi Alistair, > > > > On Wed, Jul 29, 2020 at 2:26 AM Alistair Francis > > wrote: > > > > > > On Tue, Jul 28, 2020 at 8:46 AM Bin Meng wrote: > > > > > > > > Hi Alis

Re: [PATCH 1/1] pci/pcie: refuse another hotplug/unplug event if attention button is pending

2020-07-28 Thread Maxim Levitsky
On Wed, 2020-07-22 at 19:19 +0300, Maxim Levitsky wrote: > On Wed, 2020-07-22 at 19:17 +0300, Maxim Levitsky wrote: > > Curently it is possible to hotplug a device and then immediatly > > hotunplug it before the OS notices, and that will result > > in missed unplug event since we can only send one

Re: [PATCH v4 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u

2020-07-28 Thread Alistair Francis
On Tue, Jul 28, 2020 at 9:51 PM Bin Meng wrote: > > Hi Alistair, > > On Wed, Jul 29, 2020 at 2:26 AM Alistair Francis wrote: > > > > On Tue, Jul 28, 2020 at 8:46 AM Bin Meng wrote: > > > > > > Hi Alistair, > > > > > > On Tue, Jul 28, 2020 at 11:39 PM Alistair Francis > > > wrote: > > > > > > >

Re: [PATCH v4 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u

2020-07-28 Thread Bin Meng
Hi Alistair, On Wed, Jul 29, 2020 at 2:26 AM Alistair Francis wrote: > > On Tue, Jul 28, 2020 at 8:46 AM Bin Meng wrote: > > > > Hi Alistair, > > > > On Tue, Jul 28, 2020 at 11:39 PM Alistair Francis > > wrote: > > > > > > On Wed, Jul 15, 2020 at 9:55 PM Bin Meng wrote: > > > > > > > > Hi Ali

[Bug 1872790] Re: empty qcow2

2020-07-28 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1872790 Title: empty qcow2

Adding VHOST_USER_PROTOCOL_F_CONFIG_MEM_SLOTS to 5.1 release notes

2020-07-28 Thread Raphael Norwitz
Hi mst, Looking at the current changelog https://wiki.qemu.org/ChangeLog/5.1#virtio, I don't see any mention of the VHOST_USER_PROTOCOL_F_CONFIG_MEM_SLOTS protocol feature. It is a user visible change so shouldn't we add a note? Thanks, Raphael

RE: qemu icount to run guest SMP code

2020-07-28 Thread Wu, Wentong
Thanks for the reply. > > We are trying to run guest SMP code with qemu icount mode, but based on my > > current understanding I don’t think we can do that, because with icount > > enabled, the multi cpus will be simulated in round-robin way(tcg kick vcpu > > timer, or current cpu exit in orde

[Bug 1856335] Re: Cache Layout wrong on many Zen Arch CPUs

2020-07-28 Thread Heiko Sieger
Sanjay, You can just increase the number of vcpus, such as: 64 then continue to define the vcpus: (6x enabled=yes, then 2x enabled=no.

Re: [PATCH v3 0/8] Generalize start-powered-off property from ARM

2020-07-28 Thread Thiago Jung Bauermann
Thiago Jung Bauermann writes: > The ARM code has a start-powered-off property in ARMCPU, which is a > subclass of CPUState. This property causes arm_cpu_reset() to set > CPUState::halted to 1, signalling that the CPU should start in a halted > state. Other architectures also have code which aim

Re: [RFC PATCH v3 8/8] target/s390x: Use start-powered-off CPUState property

2020-07-28 Thread Thiago Jung Bauermann
Hi, Cornelia Huck writes: > On Wed, 22 Jul 2020 23:56:57 -0300 > Thiago Jung Bauermann wrote: > >> Instead of setting CPUState::halted to 1 in s390_cpu_initfn(), use the >> start-powered-off property which makes cpu_common_reset() initialize it >> to 1 in common code. >> >> Note that this ch

Re: [PATCH v6 3/4] target/riscv: Fix the translation of physical address

2020-07-28 Thread Alistair Francis
On Tue, Jul 28, 2020 at 1:26 AM Zong Li wrote: > > The real physical address should add the 12 bits page offset. It also > causes the PMP wrong checking due to the minimum granularity of PMP is > 4 byte, but we always get the physical address which is 4KB alignment, > that means, we always use the

Re: [PATCH for-5.1? 0/3] Fix AIRCR.SYSRESETREQ for most M-profile boards

2020-07-28 Thread Alistair Francis
On Tue, Jul 28, 2020 at 3:38 AM Peter Maydell wrote: > > QEMU's NVIC device provides an outbound qemu_irq "SYSRESETREQ" which > it signals when the guest sets the SYSRESETREQ bit in the AIRCR > register. This matches the hardware design (where the CPU has a > signal of this name and it is up to t

[ANNOUNCE] QEMU 5.1.0-rc2 is now available

2020-07-28 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the third release candidate for the QEMU 5.1 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-5.1.0-rc2.tar.xz http://downl

Re: [PATCH for 5.1] docs: fix trace docs build with sphinx 3.1.1

2020-07-28 Thread John Snow
On 7/27/20 4:14 PM, Peter Maydell wrote: On Mon, 27 Jul 2020 at 20:52, John Snow wrote: ... Should we say goodbye to Sphinx 1.7.x, or is there a workaround that keeps support from 1.6.1 through to 3.1.1? I think we need to keep 1.7.x because it's the Sphinx shipped by some LTS distros we supp

Re: [PATCH v3 3/8] ppc/spapr: Use start-powered-off CPUState property

2020-07-28 Thread Thiago Jung Bauermann
Greg Kurz writes: > On Wed, 22 Jul 2020 23:56:52 -0300 > Thiago Jung Bauermann wrote: > >> PowerPC sPAPR CPUs start in the halted state, and spapr_reset_vcpu() >> attempts to implement this by setting CPUState::halted to 1. But that's too >> late for the case of hotplugged CPUs in a machine co

[PATCH] linux-user: Correctly start brk after executable

2020-07-28 Thread Timothy E Baldwin
info->brk was erroneously set to the end of highest addressed writable segment which could result it in overlapping the executable. As per load_elf_binary in fs/binfmt_elf.c in Linux, it should be set to end of highest addressed segment. Signed-off-by: Timothy E Baldwin --- linux-user/elfload.c

Re: [PATCH v3 1/8] target/arm: Move start-powered-off property to generic CPUState

2020-07-28 Thread Thiago Jung Bauermann
Greg Kurz writes: > On Thu, 23 Jul 2020 13:06:09 +1000 > David Gibson wrote: > >> On Wed, Jul 22, 2020 at 11:56:50PM -0300, Thiago Jung Bauermann wrote: >> > There are other platforms which also have CPUs that start powered off, so >> > generalize the start-powered-off property so that it can

Re: sysbus_create_simple Vs qdev_create

2020-07-28 Thread Eduardo Habkost
On Tue, Jul 28, 2020 at 07:38:27PM +0200, Paolo Bonzini wrote: > On 28/07/20 09:19, Markus Armbruster wrote: > >> the composition tree generally mirrors things that are born and die > >> at the same time, and creating children is generally reserved to the > >> object itself. > > > > Yes. Notable e

Re: [PATCH v2 3/3] virtiofsd: probe unshare(CLONE_FS) and print an error

2020-07-28 Thread Vivek Goyal
On Tue, Jul 28, 2020 at 03:12:54PM -0400, Daniel Walsh wrote: > On 7/28/20 09:12, Vivek Goyal wrote: > > On Tue, Jul 28, 2020 at 12:00:20PM +0200, Roman Mohr wrote: > >> On Tue, Jul 28, 2020 at 3:07 AM misono.tomoh...@fujitsu.com < > >> misono.tomoh...@fujitsu.com> wrote: > >> > Subject: [PATC

Re: [PATCH v2 3/3] virtiofsd: probe unshare(CLONE_FS) and print an error

2020-07-28 Thread Vivek Goyal
On Tue, Jul 28, 2020 at 04:52:33PM +0100, Daniel P. Berrangé wrote: > On Tue, Jul 28, 2020 at 09:12:50AM -0400, Vivek Goyal wrote: > > On Tue, Jul 28, 2020 at 12:00:20PM +0200, Roman Mohr wrote: > > > On Tue, Jul 28, 2020 at 3:07 AM misono.tomoh...@fujitsu.com < > > > misono.tomoh...@fujitsu.com>

Re: [PATCH v2 3/3] virtiofsd: probe unshare(CLONE_FS) and print an error

2020-07-28 Thread Daniel Walsh
On 7/28/20 11:32, Stefan Hajnoczi wrote: > On Tue, Jul 28, 2020 at 12:00:20PM +0200, Roman Mohr wrote: >> On Tue, Jul 28, 2020 at 3:07 AM misono.tomoh...@fujitsu.com < >> misono.tomoh...@fujitsu.com> wrote: >> Subject: [PATCH v2 3/3] virtiofsd: probe unshare(CLONE_FS) and print an >>> error >>

Re: [PATCH v2 3/3] virtiofsd: probe unshare(CLONE_FS) and print an error

2020-07-28 Thread Daniel Walsh
On 7/28/20 09:12, Vivek Goyal wrote: > On Tue, Jul 28, 2020 at 12:00:20PM +0200, Roman Mohr wrote: >> On Tue, Jul 28, 2020 at 3:07 AM misono.tomoh...@fujitsu.com < >> misono.tomoh...@fujitsu.com> wrote: >> Subject: [PATCH v2 3/3] virtiofsd: probe unshare(CLONE_FS) and print an >>> error A

[Bug 1889288] Re: aarch64 BICS instruciton doesn't set flags

2020-07-28 Thread Robert
Oh yes I see. Sorry for the false report. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1889288 Title: aarch64 BICS instruciton doesn't set flags Status in QEMU: Invalid Bug description: When

Re: [PULL 0/9] nbd patches for -rc2, 2020-07-28

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 16:06, Eric Blake wrote: > > The following changes since commit 1b242c3b1ec7c6011901b4f3b4b0876e31746afb: > > Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-20200727' > into staging (2020-07-28 13:46:31 +0100) > > are available in the Git repository at:

Re: [PULL 2/2] s390x/s390-virtio-ccw: fix loadparm property getter

2020-07-28 Thread Halil Pasic
On Tue, 28 Jul 2020 17:14:38 +0200 Cornelia Huck wrote: > On Tue, 28 Jul 2020 14:52:36 +0100 > Peter Maydell wrote: > > > On Mon, 27 Jul 2020 at 15:05, Cornelia Huck wrote: > > > > > > From: Halil Pasic > > > > > > The function machine_get_loadparm() is supposed to produce a C-string, > > > t

[Bug 1880424] Re: I/O write make imx_epit_reset() crash

2020-07-28 Thread Peter Maydell
Patch on list: https://patchew.org/QEMU/20200727154550.3409-1-peter.mayd...@linaro.org/ ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1880424 Ti

[PATCH] target/arm: Fix AddPAC error indication

2020-07-28 Thread Richard Henderson
The definition of top_bit used in this function is one higher than that used in the Arm ARM psuedo-code, which put the error indication at top_bit - 1 at the wrong place, which meant that it wasn't visible to Auth. Fixing the definition of top_bit requires more changes, because its most common use

Re: [PULL 0/2] Update slirp (+ debug test-serial)

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 15:31, Marc-André Lureau wrote: > > The following changes since commit 264991512193ee50e27d43e66f832d5041cf3b28: > > Merge remote-tracking branch 'remotes/ericb/tags/pull-bitmaps-2020-07-27' > into staging (2020-07-28 14:38:17 +0100) > > are available in the Git repositor

[PULL 4/4] hw/display/artist.c: fix out of bounds check

2020-07-28 Thread Helge Deller
From: Sven Schnelle Signed-off-by: Sven Schnelle Signed-off-by: Helge Deller --- hw/display/artist.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/hw/display/artist.c b/hw/display/artist.c index 6261bfe65b..46043ec895 100644 --- a/hw/display/artist.c +

[PULL 3/4] hw/hppa: Implement proper SeaBIOS version check

2020-07-28 Thread Helge Deller
It's important that the SeaBIOS hppa firmware is at least at a minimal level to ensure proper interaction between qemu and firmware. Implement a proper firmware version check by telling SeaBIOS via the fw_cfg interface which minimal SeaBIOS version is required by this running qemu instance. If the

[PULL 1/4] hw/hppa: Sync hppa_hardware.h file with SeaBIOS sources

2020-07-28 Thread Helge Deller
The hppa_hardware.h file is shared with SeaBIOS. Sync it. Signed-off-by: Helge Deller --- hw/hppa/hppa_hardware.h | 6 ++ hw/hppa/lasi.c | 2 -- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/hppa/hppa_hardware.h b/hw/hppa/hppa_hardware.h index 4a2fe2df60..cdb7fa6

[PULL 0/4] target-hppa fixes

2020-07-28 Thread Helge Deller
Please pull to fix those two bugs in target-hppa: * Fix the SeaBIOS-hppa firmware build with gcc-10 on Debian * Fix the following runtime warning with artist framebuffer: "write outside bounds: wants 1256x1023, max size 1280x1024" in addition the SeaBIOS-hppa firmware now includes a version ch

qemu repo lockdown message for a WHPX PR

2020-07-28 Thread Sunil Muthuswamy
Hey Paolo, Following your suggestion of creating PRs for WHPX changes, I tried creating a PR https://github.com/qemu/qemu/pull/95 But, I am getting repo-lockdown message. What do I need to do differently? Thanks, Sunil

Re: [PULL 0/7] target-arm queue

2020-07-28 Thread Peter Maydell
On Mon, 27 Jul 2020 at 16:19, Peter Maydell wrote: > > Just some bugfixes this time around. > > -- PMM > > The following changes since commit 4215d3413272ad6d1c6c9d0234450b602e46a74c: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.1-20200727' > into staging (2020-07-27 09:33:0

[PATCH for-5.2 5/6] pc-bios/s390-ccw: Scan through all boot devices if none has been specified

2020-07-28 Thread Thomas Huth
If no boot device has been specified (via "bootindex=..."), the s390-ccw bios scans through all devices to find a bootable device. But so far, it stops at the very first block device (including virtio-scsi controllers without attached devices) that it finds, no matter whether it is bootable or not.

[PATCH for-5.2 6/6] pc-bios/s390-ccw: Allow booting in case the first virtio-blk disk is bad

2020-07-28 Thread Thomas Huth
If you try to boot with two virtio-blk disks (without bootindex), and only the second one is bootable, the s390-ccw bios currently stops at the first disk and does not continue booting from the second one. This is annoying - and all other major QEMU firmwares succeed to boot from the second disk in

[PATCH for-5.2 1/6] pc-bios/s390-ccw/Makefile: Compile with -std=gnu99, -fwrapv and -fno-common

2020-07-28 Thread Thomas Huth
The main QEMU code is compiled with -std=gnu99, -fwrapv and -fno-common. We should use the same flags for the s390-ccw bios, too, to avoid that we get different behavior with different compiler versions that changed their default settings in the course of time (it happened at least with -std=... an

[PATCH for-5.2 4/6] pc-bios/s390-ccw: Do not bail out early if not finding a SCSI disk

2020-07-28 Thread Thomas Huth
In case the user did not specify a boot device, we want to continue looking for other devices if there are no valid SCSI disks on a virtio- scsi controller. As a first step, do not panic in this case and let the control flow carry the error to the upper functions instead. Signed-off-by: Thomas Hut

[PATCH for-5.2 3/6] pc-bios/s390-ccw: Move the inner logic of find_subch() to a separate function

2020-07-28 Thread Thomas Huth
Move the code to a separate function to be able to re-use it from a different spot later. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/main.c | 99 - 1 file changed, 57 insertions(+), 42 deletions(-) diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-

[PATCH for-5.2 0/6] Continue booting in case the first device is not bootable

2020-07-28 Thread Thomas Huth
If the user did not specify a "bootindex" property, the s390-ccw bios tries to find a bootable device on its own. Unfortunately, it alwasy stops at the very first device that it can find, no matter whether it's bootable or not. That causes some weird behavior, for example while qemu-system-s390x

[PATCH for-5.2 2/6] pc-bios/s390-ccw: Move ipl-related code from main() into a separate function

2020-07-28 Thread Thomas Huth
Let's move this part of the code into a separate function to be able to use it from multiple spots later. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/main.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/ma

Re: [PATCH v5 7/7] Makefile: Ship the generic platform bios ELF images for RISC-V

2020-07-28 Thread Alistair Francis
On Tue, Jul 28, 2020 at 8:52 AM Bin Meng wrote: > > Hi Alistair, > > On Tue, Jul 28, 2020 at 11:37 PM Alistair Francis > wrote: > > > > On Wed, Jul 15, 2020 at 11:01 PM Bin Meng wrote: > > > > > > From: Bin Meng > > > > > > At present only the generic platform fw_dynamic bios BIN images > > >

QEMU | Pipeline #171749063 has failed for master | 0a58e39f

2020-07-28 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 0a58e39f ( https://gitlab.com/qemu-project/qemu/-/commit/0a58e39fe90c50b313a5148c095f8dbb6111a6d6 ) Commit Message: Merge remote-tr

Re: [PATCH v4 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u

2020-07-28 Thread Alistair Francis
On Tue, Jul 28, 2020 at 8:46 AM Bin Meng wrote: > > Hi Alistair, > > On Tue, Jul 28, 2020 at 11:39 PM Alistair Francis > wrote: > > > > On Wed, Jul 15, 2020 at 9:55 PM Bin Meng wrote: > > > > > > Hi Alistair, > > > > > > On Mon, Jul 13, 2020 at 9:53 AM Bin Meng wrote: > > > > > > > > On Sun, J

[Bug 1889288] Re: aarch64 BICS instruciton doesn't set flags

2020-07-28 Thread Peter Maydell
The code is correct (though it is admittedly not entirely obvious at first glance). The switch statement at line 4753 is on "(opc | (invert << 2))" (where opc is a 2 bit field and invert a 1 bit field). Both ANDS and BICS have opc==3 and so will cause a call to gen_logic_CC(). The difference betwee

Re: [PULL 0/3] Block patches for 5.1.0-rc2?

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 14:48, Max Reitz wrote: > > Hi, > > Sorry for the very late pull request. The iotest issue only appeared > today, and the I/O path issue was only tracked down today. We need the > fixes for the latter in 5.1, so if they do not make it into rc2, we will > need them in rc3.

Re: sysbus_create_simple Vs qdev_create

2020-07-28 Thread Paolo Bonzini
On 28/07/20 09:19, Markus Armbruster wrote: >> the composition tree generally mirrors things that are born and die >> at the same time, and creating children is generally reserved to the >> object itself. > > Yes. Notable exceptions: containers /machine/peripheral, > /machine/peripheral-anon, /mac

[Bug 1888728] Re: Bare chroot in linux-user fails with pgb_reserved_va: Assertion `guest_base != 0' failed.

2020-07-28 Thread Laurent Vivier
Fixed here: https://github.com/qemu/qemu/commit/c9f8066697e0d3e77b97f6df423e9d6540b693be ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/

QEMU | Pipeline #171722122 has failed for master | a466dd08

2020-07-28 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: a466dd08 ( https://gitlab.com/qemu-project/qemu/-/commit/a466dd084f51cdc9da2e99361f674f98d7218559 ) Commit Message: Merge remote-tr

[Bug 1889288] [NEW] aarch64 BICS instruciton doesn't set flags

2020-07-28 Thread Robert
Public bug reported: When reading the source for translate-a64.c here: https://github.com/qemu/qemu/blob/a466dd084f51cdc9da2e99361f674f98d7218559/target/arm/translate-a64.c#L4783 I noticed that it does not appear to call gen_logic_CC for the BICS instruction so is not setting the flags as requir

Re: [PATCH 0/2] assertion failure in net_tx_pkt_add_raw_fragment() in hw/net/net_tx_pkt.c

2020-07-28 Thread Mauro Matteo Cascella
Thank you Alexander for testing the patch and providing the reproducer. I think you should be credited, along with Ziming, for independently reporting the same issue. On Mon, Jul 27, 2020 at 7:40 PM Alexander Bulekov wrote: > > I sent a reproducer for the to the list some time ago, but never crea

Re: [PULL 0/3] Linux user for 5.1 patches

2020-07-28 Thread Peter Maydell
--- > linux-user 20200728 > > Fix "pgb_reserved_va: Assertion `guest_base != 0' failed." error > Fix rt_sigtimedwait() errno > Fix getcwd() errno Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1 for any user-visible changes. -- PMM

Re: [PATCH v1 1/2] qemu-timer: gracefully handle the end of time

2020-07-28 Thread Paolo Bonzini
On 28/07/20 18:08, Alex Bennée wrote: > > Paolo Bonzini writes: > >> On 28/07/20 16:10, Alex Bennée wrote: >>> +/* >>> + * Check to see if we have run out of time. Most of our time >>> + * sources are nanoseconds since epoch (some time around the fall >>> + * of Babylon 5, the st

Re: [PATCH v2 2/2] scripts/performance: Add list_helpers.py script

2020-07-28 Thread Ahmed Karaman
On Tue, Jul 28, 2020 at 12:30 PM Aleksandar Markovic wrote: > > > > On Thursday, July 16, 2020, Ahmed Karaman > wrote: >> >> Python script that prints executed helpers of a QEMU invocation. >> > > Hi, Ahmed. > > You outlined the envisioned user workflow regarding this script in your > report. A

Re: [PATCH v2 0/2] QEMU Gating CI

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 17:34, Cleber Rosa wrote: > So, I think the reason for the skip (there's an open issue on GitLab > itself about not communicating to users the reason) is that GitLab > does a late evaluation of the job condition. For those jobs the > condition is: > >rules: >- if: '

qemu-img convert asserts while converting from vhdx to raw

2020-07-28 Thread Swapnil Ingle
Hey Guys, We are seeing following assert when trying to convert disk image from vhdx to raw. This issue is seen only for disk with 4k logical sector size. $ qemu-img convert -f vhdx -O raw 4KTest1.vhdx test.raw qemu-img: util/iov.c:388: qiov_slice: Assertion `offset + len <= qiov->size' failed.

QEMU | Pipeline #171708785 has failed for master | 1e0e0917

2020-07-28 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 1e0e0917 ( https://gitlab.com/qemu-project/qemu/-/commit/1e0e0917e5df765575a72afd35a7183e65f505ac ) Commit Message: Merge remote-tr

Re: [PATCH v2 0/2] QEMU Gating CI

2020-07-28 Thread Philippe Mathieu-Daudé
On 7/28/20 6:33 PM, Cleber Rosa wrote: > On Tue, Jul 28, 2020 at 05:08:50PM +0100, Peter Maydell wrote: >> On Tue, 28 Jul 2020 at 16:51, Cleber Rosa wrote: >>> ... OTOH I can't see anything on that web page that suggests that it's submitting jobs to the s390 or aarch64 boxes -- is it >>>

Re: [PATCH 2/7] build: fix device module builds

2020-07-28 Thread Philippe Mathieu-Daudé
On 7/23/20 7:46 PM, Christophe de Dinechin wrote: > From: Gerd Hoffmann > > See comment. Feels quite hackish. Better ideas anyone? I don't understand this patch, how is it related to the rest of your series? > > Signed-off-by: Gerd Hoffmann > Signed-off-by: Christophe de Dinechin > --- >

Re: [PATCH v2 3/4] iotests: Add more qemu_img helpers

2020-07-28 Thread Nir Soffer
On Tue, Jul 28, 2020 at 4:50 PM Vladimir Sementsov-Ogievskiy wrote: > > 28.07.2020 00:58, Nir Soffer wrote: > > Add 2 helpers for measuring and checking images: > > - qemu_img_measure() > > - qemu_img_check() > > > > Both use --output-json and parse the returned json to make easy to use > > in oth

Re: [PATCH v2 0/2] QEMU Gating CI

2020-07-28 Thread Cleber Rosa
On Tue, Jul 28, 2020 at 05:08:50PM +0100, Peter Maydell wrote: > On Tue, 28 Jul 2020 at 16:51, Cleber Rosa wrote: > > > > On Tue, Jul 28, 2020 at 03:48:38PM +0100, Peter Maydell wrote: > > > On Mon, 20 Jul 2020 at 18:22, Cleber Rosa wrote: > > > > Sure. It's important that PATCH 2/2 in this seri

Re: [PATCH 1/2] hw/net/net_tx_pkt: add function to check pkt->max_raw_frags

2020-07-28 Thread Mauro Matteo Cascella
On Tue, Jul 28, 2020 at 6:06 AM Jason Wang wrote: > > > On 2020/7/28 上午1:08, Mauro Matteo Cascella wrote: > > This patch introduces a new function in hw/net/net_tx_pkt.{c,h} to check the > > current data fragment against the maximum number of data fragments. > > > I wonder whether it's better to d

Re: [PATCH v2 0/2] QEMU Gating CI

2020-07-28 Thread Cleber Rosa
On Tue, Jul 28, 2020 at 05:15:17PM +0100, Daniel P. Berrangé wrote: > On Tue, Jul 28, 2020 at 12:13:06PM -0400, Cleber Rosa wrote: > > On Tue, Jul 28, 2020 at 03:51:34PM +0100, Daniel P. Berrangé wrote: > > > On Tue, Jul 28, 2020 at 03:48:38PM +0100, Peter Maydell wrote: > > > > On Mon, 20 Jul 2020

Re: [PATCH v1 2/2] target/arm: only set the nexttick timer if !ISTATUS

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 17:11, Alex Bennée wrote: > > > Peter Maydell writes: > > > On Tue, 28 Jul 2020 at 15:10, Alex Bennée wrote: > >> > >> Otherwise we have an unfortunate interaction with -count sleep=off > >> which means we fast forward time when we don't need to. The easiest > >> way to tr

Re: [PULL 0/3] Block patches for 5.1

2020-07-28 Thread Thomas Huth
On 28/07/2020 18.12, Peter Maydell wrote: > On Tue, 28 Jul 2020 at 11:19, Peter Maydell wrote: >> >> On Mon, 27 Jul 2020 at 15:38, Max Reitz wrote: >>> >>> Block patches for 5.1: >>> - Coverity fix >>> - iotests fix for rx and avr >

Re: [PULL 08/16] linux-user: don't use MAP_FIXED in pgd_find_hole_fallback

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 17:04, Alex Bennée wrote: > Peter Maydell writes: > > Hi; Coverity thinks this conditional expression is suspicious > > (CID 1431059): > > > >> if (mmap_start != MAP_FAILED) { > >> munmap((void *) align_start, guest_size); > >> -

Re: [PATCH v2 0/2] QEMU Gating CI

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jul 28, 2020 at 12:13:06PM -0400, Cleber Rosa wrote: > On Tue, Jul 28, 2020 at 03:51:34PM +0100, Daniel P. Berrangé wrote: > > On Tue, Jul 28, 2020 at 03:48:38PM +0100, Peter Maydell wrote: > > > On Mon, 20 Jul 2020 at 18:22, Cleber Rosa wrote: > > > > Sure. It's important that PATCH 2/2

Re: [PULL V2 0/3] Net patches

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 10:10, Jason Wang wrote: > > The following changes since commit 93ea484375ab473379dd9c836261ef484bd71ab1: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2020-07-27 21:00:01 +0100) > > are available in the git repository at: > > https://

Re: [PATCH v2 0/2] QEMU Gating CI

2020-07-28 Thread Cleber Rosa
On Tue, Jul 28, 2020 at 03:51:34PM +0100, Daniel P. Berrangé wrote: > On Tue, Jul 28, 2020 at 03:48:38PM +0100, Peter Maydell wrote: > > On Mon, 20 Jul 2020 at 18:22, Cleber Rosa wrote: > > > Sure. It's important that PATCH 2/2 in this series is included in a > > > branch that you need to push to

Re: [PULL 0/3] Block patches for 5.1

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 11:19, Peter Maydell wrote: > > On Mon, 27 Jul 2020 at 15:38, Max Reitz wrote: > > > > Block patches for 5.1: > > - Coverity fix > > - iotests fix for rx and avr > > - iotests fix for qcow2 -o compat=0.10 > >

Re: [PATCH v1 2/2] target/arm: only set the nexttick timer if !ISTATUS

2020-07-28 Thread Alex Bennée
Peter Maydell writes: > On Tue, 28 Jul 2020 at 15:10, Alex Bennée wrote: >> >> Otherwise we have an unfortunate interaction with -count sleep=off >> which means we fast forward time when we don't need to. The easiest >> way to trigger it was to attach to the gdbstub and place a break point >>

Re: [PATCH v7 01/47] block: Add child access functions

2020-07-28 Thread Christophe de Dinechin
On 2020-07-13 at 11:06 CEST, Vladimir Sementsov-Ogievskiy wrote... > 25.06.2020 18:21, Max Reitz wrote: >> There are BDS children that the general block layer code can access, >> namely bs->file and bs->backing. Since the introduction of filters and >> external data files, their meaning is not q

Re: [PATCH v2 0/2] QEMU Gating CI

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 16:51, Cleber Rosa wrote: > > On Tue, Jul 28, 2020 at 03:48:38PM +0100, Peter Maydell wrote: > > On Mon, 20 Jul 2020 at 18:22, Cleber Rosa wrote: > > > Sure. It's important that PATCH 2/2 in this series is included in a > > > branch that you need to push to the "staging" b

Re: [PATCH v1 1/2] qemu-timer: gracefully handle the end of time

2020-07-28 Thread Alex Bennée
Paolo Bonzini writes: > On 28/07/20 16:10, Alex Bennée wrote: >> +/* >> + * Check to see if we have run out of time. Most of our time >> + * sources are nanoseconds since epoch (some time around the fall >> + * of Babylon 5, the start of the Enterprises five year mission >> +

Re: [PATCH v2 2/4] iotests: Make qemu_nbd_popen() a contextmanager

2020-07-28 Thread Nir Soffer
On Tue, Jul 28, 2020 at 4:43 PM Vladimir Sementsov-Ogievskiy wrote: > > 28.07.2020 00:58, Nir Soffer wrote: > > Instead of duplicating the code to wait until the server is ready and > > remember to terminate the server and wait for it, make it possible to > > use like this: > > > > with qemu_

Re: [PULL 08/16] linux-user: don't use MAP_FIXED in pgd_find_hole_fallback

2020-07-28 Thread Alex Bennée
Peter Maydell writes: > On Mon, 27 Jul 2020 at 13:24, Alex Bennée wrote: >> >> Plain MAP_FIXED has the undesirable behaviour of splatting exiting >> maps so we don't actually achieve what we want when looking for gaps. >> We should be using MAP_FIXED_NOREPLACE. As this isn't always available >

Re: [PATCH v2 3/3] virtiofsd: probe unshare(CLONE_FS) and print an error

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jul 28, 2020 at 09:12:50AM -0400, Vivek Goyal wrote: > On Tue, Jul 28, 2020 at 12:00:20PM +0200, Roman Mohr wrote: > > On Tue, Jul 28, 2020 at 3:07 AM misono.tomoh...@fujitsu.com < > > misono.tomoh...@fujitsu.com> wrote: > > > > > > Subject: [PATCH v2 3/3] virtiofsd: probe unshare(CLONE_FS

QEMU | Pipeline #171670637 has failed for master | 26499151

2020-07-28 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 26499151 ( https://gitlab.com/qemu-project/qemu/-/commit/264991512193ee50e27d43e66f832d5041cf3b28 ) Commit Message: Merge remote-tr

Re: [PATCH v5 7/7] Makefile: Ship the generic platform bios ELF images for RISC-V

2020-07-28 Thread Bin Meng
Hi Alistair, On Tue, Jul 28, 2020 at 11:37 PM Alistair Francis wrote: > > On Wed, Jul 15, 2020 at 11:01 PM Bin Meng wrote: > > > > From: Bin Meng > > > > At present only the generic platform fw_dynamic bios BIN images > > are included in the 'make install' target for 'virt' and 'sifive_u' > > m

Re: [PATCH v2 0/2] QEMU Gating CI

2020-07-28 Thread Cleber Rosa
On Tue, Jul 28, 2020 at 03:48:38PM +0100, Peter Maydell wrote: > On Mon, 20 Jul 2020 at 18:22, Cleber Rosa wrote: > > Sure. It's important that PATCH 2/2 in this series is included in a > > branch that you need to push to the "staging" branch on the > > https://gitlab.com/qemu-project/qemu repo (

Re: [PATCH v4 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u

2020-07-28 Thread Bin Meng
Hi Alistair, On Tue, Jul 28, 2020 at 11:39 PM Alistair Francis wrote: > > On Wed, Jul 15, 2020 at 9:55 PM Bin Meng wrote: > > > > Hi Alistair, > > > > On Mon, Jul 13, 2020 at 9:53 AM Bin Meng wrote: > > > > > > On Sun, Jul 12, 2020 at 1:34 AM Alistair Francis > > > wrote: > > > > > > > > On T

Re: Missing qapi_free_Type in error case for qapi generated code?

2020-07-28 Thread Eric Blake
On 7/28/20 10:26 AM, Christophe de Dinechin wrote: The qapi generated code for qmp_marshal_query_spice seems to be missing a resource deallocation for "retval". For example, for SpiceInfo: retval = qmp_query_spice(&err); error_propagate(errp, err); if (err) { /* retval not free

Re: [PATCH v4 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u

2020-07-28 Thread Alistair Francis
On Wed, Jul 15, 2020 at 9:55 PM Bin Meng wrote: > > Hi Alistair, > > On Mon, Jul 13, 2020 at 9:53 AM Bin Meng wrote: > > > > On Sun, Jul 12, 2020 at 1:34 AM Alistair Francis > > wrote: > > > > > > On Thu, Jul 9, 2020 at 10:07 PM Bin Meng wrote: > > > > > > > > From: Bin Meng > > > > > > > > U

Re: [PATCH v5 7/7] Makefile: Ship the generic platform bios ELF images for RISC-V

2020-07-28 Thread Alistair Francis
On Wed, Jul 15, 2020 at 11:01 PM Bin Meng wrote: > > From: Bin Meng > > At present only the generic platform fw_dynamic bios BIN images > are included in the 'make install' target for 'virt' and 'sifive_u' > machines. This updates the install blob list to include ELF images > which are needed by

Re: [PULL 06/16] accel/tcg: better handle memory constrained systems

2020-07-28 Thread Christian Ehrhardt
On Mon, Jul 27, 2020 at 2:24 PM Alex Bennée wrote: > It turns out there are some 64 bit systems that have relatively low > amounts of physical memory available to them (typically CI system). > Even with swapping available a 1GB translation buffer that fills up > can put the machine under increase

Re: [PATCH] hw/riscv: sifive_u: Add a dummy L2 cache controller device

2020-07-28 Thread Alistair Francis
On Sun, Jul 19, 2020 at 11:50 PM Bin Meng wrote: > > From: Bin Meng > > It is enough to simply map the SiFive FU540 L2 cache controller > into the MMIO space using create_unimplemented_device(), with an > FDT fragment generated, to make the latest upstream U-Boot happy. > > Signed-off-by: Bin Men

Re: [PATCH v2 3/3] virtiofsd: probe unshare(CLONE_FS) and print an error

2020-07-28 Thread Stefan Hajnoczi
On Tue, Jul 28, 2020 at 12:00:20PM +0200, Roman Mohr wrote: > On Tue, Jul 28, 2020 at 3:07 AM misono.tomoh...@fujitsu.com < > misono.tomoh...@fujitsu.com> wrote: > > > > Subject: [PATCH v2 3/3] virtiofsd: probe unshare(CLONE_FS) and print an > > error > > > > > > An assertion failure is raised dur

Re: [PULL for-5.1 0/2] qemu-ga patch queue for hard-freeze

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 00:23, Michael Roth wrote: > > The following changes since commit 9303ecb658a0194560d1eecde165a1511223c2d8: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200727' into > staging (2020-07-27 17:25:06 +0100) > > are available in the Git repository at: > > g

Missing qapi_free_Type in error case for qapi generated code?

2020-07-28 Thread Christophe de Dinechin
The qapi generated code for qmp_marshal_query_spice seems to be missing a resource deallocation for "retval". For example, for SpiceInfo: #if defined(CONFIG_SPICE) void qmp_marshal_query_spice(QDict *args, QObject **ret, Error **errp) { Error *err = NULL; bool ok = false; Visitor *v;

Re: [Virtio-fs] virtio-fs performance

2020-07-28 Thread Vivek Goyal
On Tue, Jul 28, 2020 at 02:49:36PM +0100, Stefan Hajnoczi wrote: > > I'm trying and testing the virtio-fs feature in QEMU v5.0.0. > > My host and guest OS are both ubuntu 18.04 with kernel 5.4, and the > > underlying storage is one single SSD. > > > > The configuations are: > > (1) virtiofsd > > .

Re: [PATCH] osdep.h: Add doc comment for qemu_get_thread_id()

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 16:17, Eric Blake wrote: > > On 7/16/20 10:41 AM, Peter Maydell wrote: > > Add a documentation comment for qemu_get_thread_id(): since this > > is rather host-OS-specific it's useful if people writing the > > implementation and people thinking of using the function know > >

Re: [PULL 2/2] s390x/s390-virtio-ccw: fix loadparm property getter

2020-07-28 Thread Cornelia Huck
On Tue, 28 Jul 2020 14:52:36 +0100 Peter Maydell wrote: > On Mon, 27 Jul 2020 at 15:05, Cornelia Huck wrote: > > > > From: Halil Pasic > > > > The function machine_get_loadparm() is supposed to produce a C-string, > > that is a NUL-terminated one, but it does not. ElectricFence can detect > > t

[PATCH for-5.2 v4 11/11] hw/arm/smmuv3: Advertise SMMUv3.2 range invalidation

2020-07-28 Thread Eric Auger
Expose the RIL bit so that the guest driver uses range invalidation. Although RIL is a 3.2 features, We let the AIDR advertise SMMUv3.1 support as v3.x implementation is allowed to implement features from v3.(x+1). Signed-off-by: Eric Auger Reviewed-by: Peter Maydell --- v2 -> v3: - keep the A

  1   2   3   4   >