Re: [PATCH 2/2] libvhost-user: handle endianness as mandated by the spec

2020-08-01 Thread Michael S. Tsirkin
On Thu, Jul 30, 2020 at 04:07:31PM +0200, Marc Hartmayer wrote: > Since virtio existed even before it got standardized, the virtio > standard defines the following types of virtio devices: > > + legacy device (pre-virtio 1.0) > + non-legacy or VIRTIO 1.0 device > + transitional device (which ca

Re: [PATCH 0/2] Enable virtio-fs on s390x

2020-08-01 Thread Michael S. Tsirkin
On Thu, Jul 30, 2020 at 04:07:29PM +0200, Marc Hartmayer wrote: > This patch series is about enabling virtio-fs on s390x. For that we need > + some shim code (first patch), and we need > + libvhost-user to deal with virtio endiannes for non-legacy virtio >devices as mandated by the spec. > >

[Bug 1889943] Re: Improper TCP/IP packet splitting on e1000e/vmxnet3

2020-08-01 Thread Patrick Magauran
After stepping through the code, it has become clear that the e1000e/vmxnet3 emulated models do not implement TCP segmentation, however they still "advertise" it as a feature to the guest OS. Regarding my prior interpretation, the implementation is written to forward the entire packet to the host

[PATCH] configure: Require pixman for vhost-user-gpu.

2020-08-01 Thread Rafael Kitover
Use the test from Makefile to check if vhost-user-gpu is being built, and if so require pixman. Signed-off-by: Rafael Kitover --- configure | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/configure b/configure index 2acc4d1465..181b465861 100755

Re: [PATCH v2 0/4] target-hppa fixes

2020-08-01 Thread Michael Tokarev
01.08.2020 20:26, Helge Deller wrote: > Hi Michael, > > On 01.08.20 18:47, Michael Tokarev wrote: >> 01.08.2020 16:13, Helge Deller wrote: >>> A few late fixes for target-hppa: >>> >>> * Fix the SeaBIOS-hppa firmware build with gcc-10 on Debian >> >> It looks like you forgot the above change someh

Re: [PULL 0/9] decodetree: Add non-overlapping groups

2020-08-01 Thread Peter Maydell
On Tue, 9 Jun 2020 at 17:25, Richard Henderson wrote: > > Add non-overlapping groups > > > Richard Henderson (9): > decodetree: Tidy error_with_file > decod

Re: [PATCH v2 0/4] target-hppa fixes

2020-08-01 Thread Helge Deller
Hi Michael, On 01.08.20 18:47, Michael Tokarev wrote: > 01.08.2020 16:13, Helge Deller wrote: >> A few late fixes for target-hppa: >> >> * Fix the SeaBIOS-hppa firmware build with gcc-10 on Debian > > It looks like you forgot the above change somehow. Actually, no, I did not forgot this patch. It

[PATCH] seabios-hppa: add -fno-ipa-sra to the compiler flags

2020-08-01 Thread Michael Tokarev
Date: Wed, 22 Jul 2020 22:15:46 +0300 This allows seabios-hppa to build with gcc-10. Or else the compiler generates eg memset.isra.0 symbols instead of memset, and the final link step fails due to missing memset. Previous versions of gcc, for quite some time already, recognizes this option but it

Re: [PATCH v2 0/4] target-hppa fixes

2020-08-01 Thread Michael Tokarev
01.08.2020 16:13, Helge Deller wrote: > A few late fixes for target-hppa: > > * Fix the SeaBIOS-hppa firmware build with gcc-10 on Debian It looks like you forgot the above change somehow. And me too, I forgot to send you a proper [PATCH] for this. This is what I use in Debian: From: Michael T

[PATCH v2] hw/net/net_tx_pkt: fix assertion failure in net_tx_pkt_add_raw_fragment()

2020-08-01 Thread Mauro Matteo Cascella
An assertion failure issue was found in the code that processes network packets while adding data fragments into the packet context. It could be abused by a malicious guest to abort the QEMU process on the host. This patch replaces the affected assert() with a conditional statement, returning false

[PATCH v2 3/4] hw/hppa: Implement proper SeaBIOS version check

2020-08-01 Thread Helge Deller
It's important that the SeaBIOS hppa firmware is at least at a minimal level to ensure proper interaction between qemu and firmware. Implement a proper firmware version check by telling SeaBIOS via the fw_cfg interface which minimal SeaBIOS version is required by this running qemu instance. If the

[PATCH v2 0/4] target-hppa fixes

2020-08-01 Thread Helge Deller
A few late fixes for target-hppa: * Fix the SeaBIOS-hppa firmware build with gcc-10 on Debian * Fix the following runtime warning with artist framebuffer: "write outside bounds: wants 1256x1023, max size 1280x1024" in addition the SeaBIOS-hppa firmware now includes a version check to prevent s

[PATCH v2 1/4] hw/hppa: Sync hppa_hardware.h file with SeaBIOS sources

2020-08-01 Thread Helge Deller
The hppa_hardware.h file is shared with SeaBIOS. Sync it. Acked-by: Richard Henderson Signed-off-by: Helge Deller --- hw/hppa/hppa_hardware.h | 6 ++ hw/hppa/lasi.c | 2 -- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/hppa/hppa_hardware.h b/hw/hppa/hppa_hardwar

[PATCH v2 4/4] hw/display/artist.c: fix out of bounds check

2020-08-01 Thread Helge Deller
From: Sven Schnelle Signed-off-by: Sven Schnelle Signed-off-by: Helge Deller --- hw/display/artist.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/hw/display/artist.c b/hw/display/artist.c index 6261bfe65b..de56200dbf 100644 --- a/hw/display/art

Re: [PATCH 1/4] hw/hppa: Sync hppa_hardware.h file with SeaBIOS sources

2020-08-01 Thread Helge Deller
On 29.07.20 20:21, Philippe Mathieu-Daudé wrote: > On 7/27/20 11:46 PM, Helge Deller wrote: >> The hppa_hardware.h file is shared with SeaBIOS. Sync it. >> >> Signed-off-by: Helge Deller >> --- >> hw/hppa/hppa_hardware.h | 6 ++ >> hw/hppa/lasi.c | 2 -- >> 2 files changed, 6 inserti

Re: [PATCH 4/4] hw/display/artist.c: fix out of bounds check

2020-08-01 Thread Helge Deller
On 29.07.20 19:26, Richard Henderson wrote: > On 7/27/20 2:46 PM, Helge Deller wrote: >> -for (i = 0; i < pix_count; i++) { >> +for (i = 0; i < pix_count && offset + i < buf->size; i++) { >> artist_rop8(s, p + offset + pix_count - 1 - i, >> (dat

Re: [PATCH 3/3] hw/arm/virt: Implement kvm-steal-time

2020-08-01 Thread Andrew Jones
On Fri, Jul 31, 2020 at 03:54:07PM +0100, Peter Maydell wrote: > On Sat, 11 Jul 2020 at 11:10, Andrew Jones wrote: > > We add the kvm-steal-time CPU property and implement it for machvirt. > > A tiny bit of refactoring was also done to allow pmu and pvtime to > > use the same vcpu device helper fu