[Bug 1502613] Re: [Feature Request] Battery Status / Virtual Battery

2020-08-04 Thread Nahuel Pastorale
I just wanted to add that this would (probably) help solve the error 43 on mobile Nvidia GPU passthrough scenarios. While facing this myself I was able to get it working by simulating a battery and attaching it via an ACPI table. Your work is greatly appreciated Sergey. Thank you very much! --

Re: [PATCH 11/11] dockerfiles/debian-win64-cross: Download WHPX MinGW headers

2020-08-04 Thread Thomas Huth
On 04/08/2020 20.32, Stefan Weil wrote: > Am 04.08.20 um 19:00 schrieb Thomas Huth: > >> To compile-test the WHPX accelerator, we need to download these system >> headers first (they are unfortunately not part of any released and >> packaged MinGW toolchain yet). >> >> Idea taken from another patc

Re: [PATCH-for-5.0 1/2] hw/acpi/piix4: Add 'system-hotplug-support' property

2020-08-04 Thread Philippe Mathieu-Daudé
On 8/5/20 7:56 AM, Philippe Mathieu-Daudé wrote: > On 3/19/20 11:02 AM, Paolo Bonzini wrote: >> On 19/03/20 10:42, Philippe Mathieu-Daudé wrote: >>> On 3/19/20 10:36 AM, Paolo Bonzini wrote: On 18/03/20 23:15, Philippe Mathieu-Daudé wrote: > The I/O ranges registered by the piix4_acpi_syst

Re: [PATCH-for-5.0 1/2] hw/acpi/piix4: Add 'system-hotplug-support' property

2020-08-04 Thread Philippe Mathieu-Daudé
On 3/19/20 11:02 AM, Paolo Bonzini wrote: > On 19/03/20 10:42, Philippe Mathieu-Daudé wrote: >> On 3/19/20 10:36 AM, Paolo Bonzini wrote: >>> On 18/03/20 23:15, Philippe Mathieu-Daudé wrote: The I/O ranges registered by the piix4_acpi_system_hot_add_init() function are not documented in t

Re: [PATCH] docs: Update POWER9 XIVE support for nested guests

2020-08-04 Thread David Gibson
On Tue, Aug 04, 2020 at 03:16:39PM +0200, Cédric Le Goater wrote: > It is not yet supported. > > Signed-off-by: Cédric Le Goater Applied to ppc-for-5.2. > --- > docs/specs/ppc-spapr-xive.rst | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/docs/specs/ppc-spapr-xive.rst b/docs/spe

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-08-04 Thread Jason Wang
On 2020/8/5 上午4:30, Peter Xu wrote: On Mon, Aug 03, 2020 at 06:00:34PM +0200, Eugenio Pérez wrote: On Fri, 2020-07-03 at 15:24 +0800, Jason Wang wrote: On 2020/7/2 下午11:45, Peter Xu wrote: On Thu, Jul 02, 2020 at 11:01:54AM +0800, Jason Wang wrote: So I think we agree that a new notifier is

[Bug 1890290] Re: PowerPC L2(nested virt) kvm guest fails to boot with ic-mode=dual, kernel-irqchip=on - `KVM is too old to support ic-mode=dual, kernel-irqchip=on`

2020-08-04 Thread Satheesh Rajendran
this section of table in particular, https://www.qemu.org/docs/master/specs/ppc-spapr-xive.html#no-xive- support-in-kvm -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1890290 Title: PowerPC L2(neste

[Bug 1890290] Re: PowerPC L2(nested virt) kvm guest fails to boot with ic-mode=dual, kernel-irqchip=on - `KVM is too old to support ic-mode=dual, kernel-irqchip=on`

2020-08-04 Thread Satheesh Rajendran
As per this the table https://www.qemu.org/docs/master/specs/ppc-spapr- xive.html#kvm-negotiation reported qemu error msg "KVM is too old to support ic-mode=dual,kernel-irqchip=on" indicates the guest os is legacy, but that's not the case here, whereas kernel levels are near upstream which has s

Re: [PATCH v6 02/12] monitor: Use getter/setter functions for cur_mon

2020-08-04 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: > >> cur_mon really needs to be coroutine-local as soon as we move monitor >> command handlers to coroutines and let them yield. As a first step, just >> remove all direct accesses to cur_mon so that we can implement this in >> the getter function l

Re: [PATCH] trace/simple: Allow enabling simple traces from command line

2020-08-04 Thread Markus Armbruster
Josh DuBois writes: > On Aug 3, 2020, at 4:08 AM, Markus Armbruster wrote: >> >>> >>> - prior to db25d56c014aa1a96319c663e0a60346a223b31e, just like today, >>> QEMU built with simple tracing will always produce a trace- file, >>> regardless of whether the user asks for traces at runtime. >> >

[Bug 1890370] Re: Segfault in artist vram_bit_write

2020-08-04 Thread Alexander Bulekov
** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1890370 Title: Segfault in artist vram_bit_write Status in QEMU: Invalid Bug description: Hello

[Bug 1890312] Re: Segfault in artist_vram_read

2020-08-04 Thread Alexander Bulekov
There's one more slightly further in the same function - line 1231 https://github.com/hdeller/qemu- hppa/blob/1e5391948f977932d17526c491d262a3cd99a690/hw/display/artist.c#L1231 cat << EOF | ./hppa-softmmu/qemu-system-hppa -m 64 -display none \ -qtest stdio -accel qtest writeq 0xf8118005 0x1e7c50ff

Re: [PATCH v3 7/8] hw/display/artist: Refactor artist_rop8() to avoid buffer over-run

2020-08-04 Thread Alexander Bulekov
On 200804 1801, Alexander Bulekov wrote: > On 200804 2320, Helge Deller wrote: > > Hi Alexander, > > > > * Alexander Bulekov : > > > I applied this series and it fixes most of the problems I saw before. > > > I still see a few crashes - I made issues for them on launchpad: > > > https://bugs.launc

[Bug 1890370] [NEW] Segfault in artist vram_bit_write

2020-08-04 Thread Alexander Bulekov
Public bug reported: Hello, Reproducer: cat << EOF | ./hppa-softmmu/qemu-system-hppa -m 64 -display none \ -qtest stdio -accel qtest writeq 0xf810049f 0x writew 0xf8118001 0xff7c writew 0xf8118000 0x8300 writeq 0xf81005fb 0x5c18006400189e EOF SUMMARY: UndefinedBehaviorSanitizer:

Re: [PATCH 7/7] target/arm: Remove ARCH macro

2020-08-04 Thread Richard Henderson
On 8/3/20 4:18 AM, Peter Maydell wrote: > The ARCH() macro was used a lot in the legacy decoder, but > there are now just two uses of it left. Since a macro which > expands out to a goto is liable to be confusing when reading > code, replace the last two uses with a simple open-coded > qeuivalent.

Re: [PATCH 6/7] target/arm: Convert T32 coprocessor insns to decodetree

2020-08-04 Thread Richard Henderson
On 8/3/20 4:18 AM, Peter Maydell wrote: > Convert the T32 coprocessor instructions to decodetree. > As with the A32 conversion, this corrects an underdecoding > where we did not check that MRRC/MCRR [24:21] were 0b0010 > and so treated some kinds of LDC/STC and MRRC/MCRR rather > than UNDEFing them

Re: [PATCH 5/7] target/arm: Do M-profile NOCP checks early and via decodetree

2020-08-04 Thread Richard Henderson
On 8/3/20 4:18 AM, Peter Maydell wrote: > For M-profile CPUs, the architecture specifies that the NOCP > exception when a coprocessor is not present or disabled should cover > the entire wide range of coprocessor-space encodings, and should take > precedence over UNDEF exceptions. (This is the opp

Re: [PATCH 4/7] target/arm: Tidy up disas_arm_insn()

2020-08-04 Thread Richard Henderson
On 8/3/20 4:18 AM, Peter Maydell wrote: > The only thing left in the "legacy decoder" is the handling > of disas_xscale_insn(), and we can simplify the code. > > Signed-off-by: Peter Maydell > --- > target/arm/translate.c | 26 +- > 1 file changed, 9 insertions(+), 17 del

Re: [PATCH 3/7] target/arm: Convert A32 coprocessor insns to decodetree

2020-08-04 Thread Richard Henderson
On 8/3/20 4:18 AM, Peter Maydell wrote: > Convert the A32 coprocessor instructions to decodetree. > > Note that this corrects an underdecoding: for the 64-bit access case > (MRRC/MCRR) we did not check that bits [24:21] were 0b0010, so we > would incorrectly treat LDC/STC as MRRC/MCRR rather than

Re: [PULL 0/2] Net patches

2020-08-04 Thread Jason Wang
On 2020/8/4 下午6:53, Peter Maydell wrote: On Tue, 4 Aug 2020 at 07:41, Jason Wang wrote: The following changes since commit 5c1c3e4f02e458cf280c677c817ae4fd1ed9bf10: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200803' into staging (2020-08-03 20:34:26 +0100) ar

Re: [PATCH v6 4/4] target/riscv: Change the TLB page size depends on PMP entries.

2020-08-04 Thread Zong Li
On Tue, Jul 28, 2020 at 4:26 PM Zong Li wrote: > > The minimum granularity of PMP is 4 bytes, it is small than 4KB page > size, therefore, the pmp checking would be ignored if its range doesn't > start from the alignment of one page. This patch detects the pmp entries > and sets the small page siz

Re: [PATCH] qcow2: flush qcow2 l2 meta for new allocated clusters

2020-08-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200805023826.184-1-fangyi...@huawei.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. The full log is avail

Re: device compatibility interface for live migration with assigned devices

2020-08-04 Thread Jason Wang
On 2020/8/5 上午10:16, Yan Zhao wrote: On Wed, Aug 05, 2020 at 10:22:15AM +0800, Jason Wang wrote: On 2020/8/5 上午12:35, Cornelia Huck wrote: [sorry about not chiming in earlier] On Wed, 29 Jul 2020 16:05:03 +0800 Yan Zhao wrote: On Mon, Jul 27, 2020 at 04:23:21PM -0600, Alex Williamson wrot

[PATCH] qcow2: flush qcow2 l2 meta for new allocated clusters

2020-08-04 Thread Ying Fang
From: fangying When qemu or qemu-nbd process uses a qcow2 image and configured with 'cache = none', it will write to the qcow2 image with a cache to cache L2 tables, however the process will not use L2 tables without explicitly calling the flush command or closing the mirror flash into the disk.

Re: device compatibility interface for live migration with assigned devices

2020-08-04 Thread Yan Zhao
On Wed, Aug 05, 2020 at 10:22:15AM +0800, Jason Wang wrote: > > On 2020/8/5 上午12:35, Cornelia Huck wrote: > > [sorry about not chiming in earlier] > > > > On Wed, 29 Jul 2020 16:05:03 +0800 > > Yan Zhao wrote: > > > > > On Mon, Jul 27, 2020 at 04:23:21PM -0600, Alex Williamson wrote: > > (...)

Re: device compatibility interface for live migration with assigned devices

2020-08-04 Thread Jason Wang
On 2020/8/5 上午12:35, Cornelia Huck wrote: [sorry about not chiming in earlier] On Wed, 29 Jul 2020 16:05:03 +0800 Yan Zhao wrote: On Mon, Jul 27, 2020 at 04:23:21PM -0600, Alex Williamson wrote: (...) Based on the feedback we've received, the previously proposed interface is not viable.

Re: [Bug 1890360] [NEW] Assertion failure in address_space_unmap through virtio-blk

2020-08-04 Thread Alexander Bulekov
Hi Stefan, This looks an awful lot like the one you looked at here: https://www.mail-archive.com/qemu-devel@nongnu.org/msg705719.html though this one is for virtio-pci, while that one was for virtio-mmio: They are probably the same issue, but the original reproducer no longer causes an asserion fa

[Bug 1890360] [NEW] Assertion failure in address_space_unmap through virtio-blk

2020-08-04 Thread Alexander Bulekov
Public bug reported: Hello, Reproducer: cat << EOF | ./i386-softmmu/qemu-system-i386 \ -drive id=mydrive,file=null-co://,size=2M,format=raw,if=none \ -device virtio-blk,drive=mydrive \ -nodefaults -nographic -qtest stdio outl 0xcf8 0x80001010 outl 0xcfc 0xc001 outl 0xcf8 0x80001014 outl 0xcf8 0x80

Re: [PATCH v3 7/8] hw/display/artist: Refactor artist_rop8() to avoid buffer over-run

2020-08-04 Thread Alexander Bulekov
On 200804 2320, Helge Deller wrote: > Hi Alexander, > > * Alexander Bulekov : > > I applied this series and it fixes most of the problems I saw before. > > I still see a few crashes - I made issues for them on launchpad: > > https://bugs.launchpad.net/qemu/+bug/1890310 > > https://bugs.launchpad.n

[PATCH v8 0/4] Introduce Xilinx ZynqMP CAN controller

2020-08-04 Thread Vikram Garhwal
Changelog: v7 -> v8: Change CAN controller to keep one canbus per controller. Add canbus connections at machine level. Remove ctrl_idx from CAN controller. v6 -> v7: Remove '-m 4G' option from xlnx-can-test. This option causes the fail of docker-quick@centos7 build test. v5 -

Re: [PULL 0/3] virtio,acpi: bugfixes

2020-08-04 Thread Michael S. Tsirkin
On Tue, Aug 04, 2020 at 06:20:53PM +0100, Peter Maydell wrote: > On Tue, 4 Aug 2020 at 15:17, Michael S. Tsirkin wrote: > > > > The following changes since commit 5c1c3e4f02e458cf280c677c817ae4fd1ed9bf10: > > > > Merge remote-tracking branch > > 'remotes/pmaydell/tags/pull-target-arm-20200803'

Re: [PATCH v3 7/8] hw/display/artist: Refactor artist_rop8() to avoid buffer over-run

2020-08-04 Thread Helge Deller
Hi Alexander, * Alexander Bulekov : > I applied this series and it fixes most of the problems I saw before. > I still see a few crashes - I made issues for them on launchpad: > https://bugs.launchpad.net/qemu/+bug/1890310 > https://bugs.launchpad.net/qemu/+bug/1890311 > https://bugs.launchpad.net/

[PATCH v8 1/4] hw/net/can: Introduce Xilinx ZynqMP CAN controller

2020-08-04 Thread Vikram Garhwal
The Xilinx ZynqMP CAN controller is developed based on SocketCAN, QEMU CAN bus implementation. Bus connection and socketCAN connection for each CAN module can be set through command lines. Example for using single CAN: -object can-bus,id=canbus0 \ -machine xlnx-zcu102.canbus0=canbus0 \

[PATCH v8 4/4] MAINTAINERS: Add maintainer entry for Xilinx ZynqMP CAN controller

2020-08-04 Thread Vikram Garhwal
Reviewed-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias Signed-off-by: Vikram Garhwal --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0886eb3..14d9b73 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1536,6 +1536,14 @@ F: hw/net/o

[PATCH v8 3/4] tests/qtest: Introduce tests for Xilinx ZynqMP CAN controller

2020-08-04 Thread Vikram Garhwal
The QTests perform five tests on the Xilinx ZynqMP CAN controller: Tests the CAN controller in loopback, sleep and snoop mode. Tests filtering of incoming CAN messages. Signed-off-by: Vikram Garhwal --- tests/qtest/Makefile.include | 2 + tests/qtest/xlnx-can-test.c | 359

[PATCH v8 2/4] xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers

2020-08-04 Thread Vikram Garhwal
Connect CAN0 and CAN1 on the ZynqMP. Signed-off-by: Vikram Garhwal --- hw/arm/xlnx-zcu102.c | 20 hw/arm/xlnx-zynqmp.c | 34 ++ include/hw/arm/xlnx-zynqmp.h | 8 3 files changed, 62 insertions(+) diff --git a/hw/arm/

Re: [PATCH] target/arm: Fix Rt/Rt2 in ESR_ELx for copro traps from AArch32 to 64

2020-08-04 Thread Richard Henderson
On 8/3/20 9:54 AM, Peter Maydell wrote: > +case 14: > +switch (mode) { > +case ARM_CPU_MODE_USR: > +case ARM_CPU_MODE_SYS: > +return 14; > +case ARM_CPU_MODE_HYP: > +return 16; Hyp uses LR_usr... > +case ARM_CPU_MODE_IRQ: > +

Re: [PATCH 1/2] hw/core: Add bql_interrupt flag to CPUClass

2020-08-04 Thread Eduardo Habkost
On Sun, Aug 02, 2020 at 05:05:04PM +0100, Alex Bennée wrote: > > Eduardo Habkost writes: > > > On Fri, Jul 31, 2020 at 03:14:02PM -0400, Robert Foley wrote: > >> On Fri, 31 Jul 2020 at 13:44, Eduardo Habkost wrote: > >> > > > >> > > +static inline void cpu_class_disable_bql_interrupt(CPUClass

Re: [PULL 0/3] virtio,acpi: bugfixes

2020-08-04 Thread Michael S. Tsirkin
On Tue, Aug 04, 2020 at 10:17:01AM -0400, Michael S. Tsirkin wrote: > The following changes since commit 5c1c3e4f02e458cf280c677c817ae4fd1ed9bf10: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200803' into staging (2020-08-03 > 20:34:26 +0100) > > are available i

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-08-04 Thread Peter Xu
On Mon, Aug 03, 2020 at 06:00:34PM +0200, Eugenio Pérez wrote: > On Fri, 2020-07-03 at 15:24 +0800, Jason Wang wrote: > > On 2020/7/2 下午11:45, Peter Xu wrote: > > > On Thu, Jul 02, 2020 at 11:01:54AM +0800, Jason Wang wrote: > > > > So I think we agree that a new notifier is needed? > > > Good to m

[Bug 1890310] Re: Segfault in artist.c:block_move

2020-08-04 Thread Helge Deller
** Changed in: qemu Assignee: (unassigned) => Helge Deller (hdeller) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1890310 Title: Segfault in artist.c:block_move Status in QEMU: New Bug de

[Bug 1890312] Re: Segfault in artist_vram_read

2020-08-04 Thread Helge Deller
** Changed in: qemu Assignee: (unassigned) => Helge Deller (hdeller) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1890312 Title: Segfault in artist_vram_read Status in QEMU: New Bug descr

[Bug 1890311] Re: Segfault in cpu_physical_memory_set_dirty_range on hppa + artist

2020-08-04 Thread Helge Deller
** Changed in: qemu Assignee: (unassigned) => Helge Deller (hdeller) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1890311 Title: Segfault in cpu_physical_memory_set_dirty_range on hppa + arti

[PATCH v2 for-5.1?] target/arm: Fix Rt/Rt2 in ESR_ELx for copro traps from AArch32 to 64

2020-08-04 Thread Peter Maydell
When a coprocessor instruction in an AArch32 guest traps to AArch32 Hyp mode, the syndrome register (HSR) includes Rt and Rt2 fields which are simply copies of the Rt and Rt2 fields from the trapped instruction. However, if the instruction is trapped from AArch32 to an AArch64 higher exception le

[Bug 1718719] Re: qemu can't capture keys properly under wayland

2020-08-04 Thread Bug Watch Updater
** Changed in: xserver Status: Unknown => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1718719 Title: qemu can't capture keys properly under wayland Status in QEMU: New Status in XSe

[Bug 1879587] Re: Register number in ESR is incorrect for certain banked registers when switching from AA32 to AA64

2020-08-04 Thread Peter Maydell
Whoops, yes. I somehow misread that table (I think I failed to spot that there is no LR_hyp and it just shares r14 with usr/sys, so I did a cut-n-paste of the SP cases to LR, which isn't right). I think your adjustment to the patch is correct. I'll do a v2 patch for you to test, but it will just be

[Bug 1890333] [NEW] Assertion failure in address_space_stw_le_cached through virtio-* devices

2020-08-04 Thread Alexander Bulekov
Public bug reported: Hello, Reproducer: cat << EOF | ./i386-softmmu/qemu-system-i386 \ -drive id=mydrive,file=null-co://,size=2M,format=raw,if=none \ -device virtio-blk,drive=mydrive \ -nodefaults -qtest stdio -nographic outl 0xcf8 0x80001001 outl 0xcfc 0x6574c1ff outl 0xcf8 0x8000100e outl 0xcfc

[Bug 1879587] Re: Register number in ESR is incorrect for certain banked registers when switching from AA32 to AA64

2020-08-04 Thread Julien Freche
Unfortunately, I won't be able to send the code or binary for the hypervisor as of now (it will become available at some point in the future though). I've done a bit of debugging on the QEMU code and it seems like the approach you are taking works fine in general but the register mapping code doesn

Re: [PATCH-for-5.1] stubs: Fix notify-event stub linkage error on MinGW

2020-08-04 Thread Philippe Mathieu-Daudé
On 8/4/20 8:22 PM, Philippe Mathieu-Daudé wrote: > In commit e4d6d41ce2 we reduced the user-mode object list, > but forgot to also change the notify.o stub in the next commit > dc70f80fb2. This triggers a linker error while compiling the > tests under MinGW: > > LINKtests/test-timed-average.

Re: [PULL 0/2] target-arm queue

2020-08-04 Thread Peter Maydell
On Tue, 4 Aug 2020 at 17:08, Peter Maydell wrote: > > Couple of last-minute things for rc3... > > -- PMM > > The following changes since commit d15532d91be177e7528310e0110e39f915779a99: > > Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20200804'

Re: [PATCH 11/11] dockerfiles/debian-win64-cross: Download WHPX MinGW headers

2020-08-04 Thread Stefan Weil
Am 04.08.20 um 19:00 schrieb Thomas Huth: > To compile-test the WHPX accelerator, we need to download these system > headers first (they are unfortunately not part of any released and > packaged MinGW toolchain yet). > > Idea taken from another patch by Stefan Weil. > > Signed-off-by: Thomas Huth

Re: [PATCH-for-5.0 1/2] hw/acpi/piix4: Add 'system-hotplug-support' property

2020-08-04 Thread Philippe Mathieu-Daudé
On 8/3/20 7:33 PM, Marcelo Tosatti wrote: > On Mon, Aug 03, 2020 at 07:10:11PM +0200, Philippe Mathieu-Daudé wrote: >> Hi Igor, Paolo. >> >> On 3/23/20 12:04 PM, Marcelo Tosatti wrote: >>> On Mon, Mar 23, 2020 at 09:05:06AM +0100, Paolo Bonzini wrote: On 22/03/20 17:27, Philippe Mathieu-DaudÃ

Re: [PATCH 10/11] configure: Allow automatic WHPX detection

2020-08-04 Thread Stefan Weil
Am 04.08.20 um 19:00 schrieb Thomas Huth: > The whpx variable is currently initialized to "no" which causes the WHPX > check to skip the detection unless the user specified --enable-whpx. > Since the detection code should be able to figure it out correctly, let's > initialized the variable to "" o

Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

2020-08-04 Thread John Snow
On 8/4/20 4:03 AM, Markus Armbruster wrote: The pain of tweaking the parser is likely dwarved several times over by the pain of the flag day. You mention this often; I wonder if I misunderstand the critique, because the pain of a "flag day" for a new file format seems negligible to me. I do

[PATCH-for-5.1] stubs: Fix notify-event stub linkage error on MinGW

2020-08-04 Thread Philippe Mathieu-Daudé
In commit e4d6d41ce2 we reduced the user-mode object list, but forgot to also change the notify.o stub in the next commit dc70f80fb2. This triggers a linker error while compiling the tests under MinGW: LINKtests/test-timed-average.exe libqemuutil.a(main-loop.o): In function `qemu_notify_eve

Re: [PATCH 08/11] stubs/notify-event: Mark qemu_notify_event() stub as "weak"

2020-08-04 Thread Thomas Huth
On 04/08/2020 19.50, Richard Henderson wrote: > On 8/4/20 10:00 AM, Thomas Huth wrote: >> Otherwise there is a linker error with MinGW while compiling the tests: >> >> LINKtests/test-timed-average.exe >> libqemuutil.a(main-loop.o): In function `qemu_notify_event': >> /builds/huth/qemu/util/

Re: [PATCH V1 00/32] Live Update

2020-08-04 Thread Steven Sistare
Hi folks, any questions or comments on the vfio and pci changes in patch 30? Or on the means of preserving anonymous memory and re-exec'ing in patches 14 - 21? - Steve On 7/30/2020 11:14 AM, Steve Sistare wrote: > Improve and extend the qemu functions that save and restore VM state so a > gues

Re: qapi-schema esotera

2020-08-04 Thread John Snow
On 8/4/20 1:33 AM, Markus Armbruster wrote: > John Snow writes: > >> On 8/3/20 1:25 PM, Eric Blake wrote: >>> On 8/3/20 11:49 AM, John Snow wrote: UNION is split into two primary forms: 1. Simple (No discriminator nor base) 2. Flat (Discriminator and base) In expr.py

Re: [PATCH 11/11] dockerfiles/debian-win64-cross: Download WHPX MinGW headers

2020-08-04 Thread Philippe Mathieu-Daudé
On 8/4/20 7:00 PM, Thomas Huth wrote: > To compile-test the WHPX accelerator, we need to download these system > headers first (they are unfortunately not part of any released and > packaged MinGW toolchain yet). > > Idea taken from another patch by Stefan Weil. > > Signed-off-by: Thomas Huth >

Re: [RFC PATCH 8/8] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function

2020-08-04 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > From: Zheng Chuan > > Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be > called > by libvirt api. > > Signed-off-by: Zheng Chuan > Signed-off-by: YanYing Zhang > --- > migration/Makefile.objs | 1 + > migration/dirtyr

Re: [RFC PATCH 7/8] migration/dirtyrate: Implement calculate_dirtyrate() function

2020-08-04 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > From: Zheng Chuan > > Implement calculate_dirtyrate() function. > > Signed-off-by: Zheng Chuan > Signed-off-by: YanYing Zhang > --- > migration/dirtyrate.c | 53 > +-- > 1 file changed, 47 insertio

Re: [RFC PATCH 6/8] migration/dirtyrate: Implement get_sample_gap_period() and block_sample_gap_period()

2020-08-04 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > From: Zheng Chuan > > Implement get_sample_gap_period() and block_sample_gap_period() to > sleep specific time between sample actions. > > Signed-off-by: Zheng Chuan > Signed-off-by: YanYing Zhang > --- > migration/dirtyrate.c | 28 ++

Re: [PATCH 06/11] tests/Makefile: Add $(EXESUF) to fp-test target

2020-08-04 Thread Philippe Mathieu-Daudé
On 8/4/20 7:00 PM, Thomas Huth wrote: > In case we ever want to compile this for Windows, we need the $(EXESUF) > here. > > Signed-off-by: Thomas Huth > --- > tests/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.

Re: [PATCH 08/11] stubs/notify-event: Mark qemu_notify_event() stub as "weak"

2020-08-04 Thread Richard Henderson
On 8/4/20 10:00 AM, Thomas Huth wrote: > Otherwise there is a linker error with MinGW while compiling the tests: > > LINKtests/test-timed-average.exe > libqemuutil.a(main-loop.o): In function `qemu_notify_event': > /builds/huth/qemu/util/main-loop.c:139: multiple definition of > `qemu_no

Re: [PATCH 10/11] configure: Allow automatic WHPX detection

2020-08-04 Thread Philippe Mathieu-Daudé
On 8/4/20 7:00 PM, Thomas Huth wrote: > The whpx variable is currently initialized to "no" which causes the WHPX > check to skip the detection unless the user specified --enable-whpx. > Since the detection code should be able to figure it out correctly, let's > initialized the variable to "" on Min

Re: [PATCH 07/11] Get rid of the libqemustub.a remainders

2020-08-04 Thread Richard Henderson
On 8/4/20 10:00 AM, Thomas Huth wrote: > libqemustub.a has been removed in commit ebedb37c8d ("Makefile: Remove > libqemustub.a"). Some remainders have been missed. Remove them now. > > Signed-off-by: Thomas Huth > --- > Makefile| 2 +- > scripts/coverity-scan/run

Re: [PATCH 02/11] target/riscv/vector_helper: Fix build on 32-bit big endian targets

2020-08-04 Thread Philippe Mathieu-Daudé
On 8/4/20 7:00 PM, Thomas Huth wrote: > The code currently fails to compile on 32-bit big endian targets: s/target/host/ here and in subject? > > target/riscv/vector_helper.c: In function 'vext_clear': > target/riscv/vector_helper.c:154:16: error: cast to pointer from integer > of different s

Re: [PATCH 06/11] tests/Makefile: Add $(EXESUF) to fp-test target

2020-08-04 Thread Richard Henderson
On 8/4/20 10:00 AM, Thomas Huth wrote: > In case we ever want to compile this for Windows, we need the $(EXESUF) > here. > > Signed-off-by: Thomas Huth > --- > tests/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH] trace/simple: Allow enabling simple traces from command line

2020-08-04 Thread Josh DuBois
On Aug 3, 2020, at 4:08 AM, Markus Armbruster wrote: > >> >> - prior to db25d56c014aa1a96319c663e0a60346a223b31e, just like today, >> QEMU built with simple tracing will always produce a trace- file, >> regardless of whether the user asks for traces at runtime. > > When you send a patch with a

Re: [PATCH 02/11] target/riscv/vector_helper: Fix build on 32-bit big endian targets

2020-08-04 Thread Richard Henderson
On 8/4/20 10:00 AM, Thomas Huth wrote: > The code currently fails to compile on 32-bit big endian targets: > > target/riscv/vector_helper.c: In function 'vext_clear': > target/riscv/vector_helper.c:154:16: error: cast to pointer from integer > of different size [-Werror=int-to-pointer-cast] >

Re: [RFC PATCH 5/8] migration/dirtyrate: Compare hash results for recorded ramblock

2020-08-04 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > From: Zheng Chuan > > Compare hash results for recorded ramblock. > > Signed-off-by: Zheng Chuan > Signed-off-by: YanYing Zhang > --- > migration/dirtyrate.c | 77 > +++ > 1 file changed, 77 insert

Re: [PATCH] target/arm: Fix decode of {LD,ST}RA[AB] instructions

2020-08-04 Thread Peter Collingbourne
On Tue, Aug 4, 2020 at 8:41 AM Richard Henderson wrote: > > On 8/3/20 5:21 PM, Peter Collingbourne wrote: > > On Mon, Aug 3, 2020 at 3:27 PM Peter Collingbourne wrote: > >> > >> These instructions use zero as the discriminator, not SP. > > > > Oh, there is no such thing as STRAA/STRAB. I must hav

Re: [PULL 0/3] virtio,acpi: bugfixes

2020-08-04 Thread Peter Maydell
On Tue, 4 Aug 2020 at 15:17, Michael S. Tsirkin wrote: > > The following changes since commit 5c1c3e4f02e458cf280c677c817ae4fd1ed9bf10: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200803' into staging (2020-08-03 > 20:34:26 +0100) > > are available in the Git re

Re: [PATCH 00/11] Run cross-compilation build tests in the gitlab-CI

2020-08-04 Thread Thomas Huth
On 04/08/2020 19.00, Thomas Huth wrote: > Now that we can use all our QEMU build containers in the gitlab-CI, > we can also run the cross-compilation jobs there. Of course, some > problems have to be fixed first, since apparently nobody was running > "make check-build" for QEMU for 32-bit big endia

[PATCH 11/11] dockerfiles/debian-win64-cross: Download WHPX MinGW headers

2020-08-04 Thread Thomas Huth
To compile-test the WHPX accelerator, we need to download these system headers first (they are unfortunately not part of any released and packaged MinGW toolchain yet). Idea taken from another patch by Stefan Weil. Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/debian-win64-cross.docke

[PATCH 09/11] gitlab-ci: Add cross-compiling build tests

2020-08-04 Thread Thomas Huth
Now that we can use all our QEMU test containers in the gitlab-CI, we can easily add some jobs that test cross-compilation for various architectures. There is just only small ugliness: Since the shared runners on gitlab.com are single-threaded, we have to split each compilation job into two parts (

[PATCH 06/11] tests/Makefile: Add $(EXESUF) to fp-test target

2020-08-04 Thread Thomas Huth
In case we ever want to compile this for Windows, we need the $(EXESUF) here. Signed-off-by: Thomas Huth --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 2806e062d0..e2532e12e2 100644 --- a/tests/

[PATCH 10/11] configure: Allow automatic WHPX detection

2020-08-04 Thread Thomas Huth
The whpx variable is currently initialized to "no" which causes the WHPX check to skip the detection unless the user specified --enable-whpx. Since the detection code should be able to figure it out correctly, let's initialized the variable to "" on MinGW-builds for proper auto-detection instead.

[PATCH 05/11] tests/Makefile: Only build usable targets during 'make check-build'

2020-08-04 Thread Thomas Huth
If the softmmu targets are not enabled, "make check-build" fails to build the qtests (which could not be run anyway without softmmu binary). And the softfloat tests can not be compiled with MinGW yet (the macro LITTLEENDIAN is re-defined in one of the system headers there, so this needs some work f

[PATCH 07/11] Get rid of the libqemustub.a remainders

2020-08-04 Thread Thomas Huth
libqemustub.a has been removed in commit ebedb37c8d ("Makefile: Remove libqemustub.a"). Some remainders have been missed. Remove them now. Signed-off-by: Thomas Huth --- Makefile| 2 +- scripts/coverity-scan/run-coverity-scan | 3 --- tests/test-util-sockets.c

[PATCH 03/11] tests/Makefile: test-image-locking needs CONFIG_POSIX

2020-08-04 Thread Thomas Huth
test-image-locking.c uses the qemu_lock_fd_test() function which is only available on POSIX-like systems. Reviewed-by: John Snow Signed-off-by: Thomas Huth --- tests/Makefile.include | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/Makefile.include b/tests/Makefile.include index c7e4

[PATCH 08/11] stubs/notify-event: Mark qemu_notify_event() stub as "weak"

2020-08-04 Thread Thomas Huth
Otherwise there is a linker error with MinGW while compiling the tests: LINKtests/test-timed-average.exe libqemuutil.a(main-loop.o): In function `qemu_notify_event': /builds/huth/qemu/util/main-loop.c:139: multiple definition of `qemu_notify_event' tests/test-timed-average.o:/builds/hut

[PATCH 02/11] target/riscv/vector_helper: Fix build on 32-bit big endian targets

2020-08-04 Thread Thomas Huth
The code currently fails to compile on 32-bit big endian targets: target/riscv/vector_helper.c: In function 'vext_clear': target/riscv/vector_helper.c:154:16: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] memset((void *)((uintptr_t)tail & ~(7ULL)),

[PATCH 00/11] Run cross-compilation build tests in the gitlab-CI

2020-08-04 Thread Thomas Huth
Now that we can use all our QEMU build containers in the gitlab-CI, we can also run the cross-compilation jobs there. Of course, some problems have to be fixed first, since apparently nobody was running "make check-build" for QEMU for 32-bit big endian targets or MinGW recently... As a bonus, the

[PATCH 01/11] virtio-mem: Correct format specifier mismatch for RISC-V

2020-08-04 Thread Thomas Huth
From: Bruce Rogers This likely affects other, less popular host architectures as well. Less common host architectures under linux get QEMU_VMALLOC_ALIGN (from which VIRTIO_MEM_MIN_BLOCK_SIZE is derived) define to a variable of type uintptr, which isn't compatible with the format specifier used to

[PATCH 04/11] tests/Makefile: test-replication needs CONFIG_POSIX

2020-08-04 Thread Thomas Huth
test-replication uses sigaction() and friends which are only available on POSIX-like systems. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests/Makefile.include | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.

Re: [RFC PATCH 4/8] migration/dirtyrate: Record hash results for each ramblock

2020-08-04 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > From: Zheng Chuan > > Record hash results for each ramblock. Please be careful when talking about 'ramblock' since we already use that for a chunk of memory in QEMU. > Signed-off-by: Zheng Chuan > Signed-off-by: YanYing Zhang > --- > migration/d

Re: [PATCH 3/3] aio-posix: keep aio_notify_me disabled during polling

2020-08-04 Thread Paolo Bonzini
On 04/08/20 12:29, Stefan Hajnoczi wrote: > On Tue, Aug 04, 2020 at 06:28:04AM +0100, Stefan Hajnoczi wrote: >> @@ -597,15 +574,38 @@ bool aio_poll(AioContext *ctx, bool blocking) >> * system call---a single round of run_poll_handlers_once suffices. >> */ >> if (timeout || ctx->fdm

Re: [RFC PATCH 3/8] migration/dirtyrate: Add dirtyrate statistics series functions

2020-08-04 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > From: Zheng Chuan > > Add dirtyrate statistics to record/update dirtyrate info. > > Signed-off-by: Zheng Chuan > Signed-off-by: YanYing Zhang > --- > migration/dirtyrate.c | 47 ++- > migration/dirtyrat

Re: [PATCH v3 4/8] hw/display/artist.c: fix out of bounds check

2020-08-04 Thread Alexander Bulekov
Hi Helge, Sven, I think this patch introduces an issue: cat << EOF | ./hppa-softmmu/qemu-system-hppa -m 64 -display none \ -qtest stdio -accel qtest writeq 0xf810049f 0x7ed7087fff0d writew 0xf8118001 0x30fb writew 0xf8118000 0x5bfb writeq 0xf81005fb 0xd8d8d8d83d83d6 EOF AddressSanitizer:DEADL

Re: [PATCH v3 7/8] hw/display/artist: Refactor artist_rop8() to avoid buffer over-run

2020-08-04 Thread Alexander Bulekov
Hi Helge, I applied this series and it fixes most of the problems I saw before. I still see a few crashes - I made issues for them on launchpad: https://bugs.launchpad.net/qemu/+bug/1890310 https://bugs.launchpad.net/qemu/+bug/1890311 https://bugs.launchpad.net/qemu/+bug/1890312 Thanks! -Alex On

Re: device compatibility interface for live migration with assigned devices

2020-08-04 Thread Cornelia Huck
[sorry about not chiming in earlier] On Wed, 29 Jul 2020 16:05:03 +0800 Yan Zhao wrote: > On Mon, Jul 27, 2020 at 04:23:21PM -0600, Alex Williamson wrote: (...) > > Based on the feedback we've received, the previously proposed interface > > is not viable. I think there's agreement that the us

[Bug 1890312] [NEW] Segfault in artist_vram_read

2020-08-04 Thread Alexander Bulekov
Public bug reported: Hello, Reproducer: cat << EOF | ./hppa-softmmu/qemu-system-hppa -m 64 -display none \ -qtest stdio -accel qtest writew 0xf8118001 0x105a readq 0xf900f8ff EOF = ==20118==ERROR: AddressSanitizer: SEGV on unknown a

[Bug 1890311] [NEW] Segfault in cpu_physical_memory_set_dirty_range on hppa + artist

2020-08-04 Thread Alexander Bulekov
Public bug reported: Hello, Reproducer: cat << EOF | ./hppa-softmmu/qemu-system-hppa -m 64 -display none \ -qtest stdio -accel qtest writeq 0xf810049f 0x85 writew 0xf8118001 0x14 writeq 0xf81005fb 0x5c6418001832 EOF AddressSanitizer:DEADLYSIGNAL ==

[Bug 1890310] [NEW] Segfault in artist.c:block_move

2020-08-04 Thread Alexander Bulekov
Public bug reported: Hello, Reproducer: cat << EOF | ./hppa-softmmu/qemu-system-hppa -m 64 -display none \ -qtest stdio -accel qtest writeq 0xf8100802 0xff5c651b7c5c writeq 0xf8100afb 0x25e EOF AddressSanitizer:DEADLYSIGNAL

Re: [RFC PATCH 8/8] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function

2020-08-04 Thread Eric Blake
On 7/24/20 10:11 PM, Chuan Zheng wrote: From: Zheng Chuan Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be called by libvirt api. Signed-off-by: Zheng Chuan Signed-off-by: YanYing Zhang +## +{ 'command': 'get_dirty_rate', 'returns': 'int64' } diff --git a/qapi/

Re: [PATCH v2 4/4] gitlab-ci: Fix Avocado cache usage

2020-08-04 Thread Thomas Huth
On 04/08/2020 18.24, Alex Bennée wrote: > > Thomas Huth writes: > >> In commit 6957fd98dc ("gitlab: add avocado asset caching") we >> tried to save the Avocado cache (as in commit c1073e44b4 with >> Travis-CI) however it doesn't work as expected. For some reason >> Avocado uses /root/avocado_cac

Re: [RFC PATCH 8/8] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function

2020-08-04 Thread Eric Blake
On 7/24/20 10:11 PM, Chuan Zheng wrote: From: Zheng Chuan Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be called by libvirt api. Signed-off-by: Zheng Chuan Signed-off-by: YanYing Zhang --- +++ b/qapi/migration.json @@ -1621,3 +1621,27 @@ ## { 'event': 'UNP

Re: [RFC PATCH 2/8] migration/dirtyrate: Add block_dirty_info to store dirtypage info

2020-08-04 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > From: Zheng Chuan > > Add block_dirty_info to store dirtypage info for each ramblock > > Signed-off-by: Zheng Chuan > Signed-off-by: YanYing Zhang > --- > migration/dirtyrate.h | 13 + > 1 file changed, 13 insertions(+) > > diff --gi

Re: [PATCH v2 4/4] gitlab-ci: Fix Avocado cache usage

2020-08-04 Thread Alex Bennée
Thomas Huth writes: > In commit 6957fd98dc ("gitlab: add avocado asset caching") we > tried to save the Avocado cache (as in commit c1073e44b4 with > Travis-CI) however it doesn't work as expected. For some reason > Avocado uses /root/avocado_cache/ which we can not select later. > > Manually g

  1   2   3   >