Re: [PATCH 11/11] hw/display/vga:Remove redundant statement in vga_draw_graphic()

On Thu, Aug 13, 2020 at 03:37:12PM +0800, Chen Qun wrote: > Clang static code analyzer show warning: > hw/display/vga.c:1677:9: warning: Value stored to 'update' is never read > update = full_update; > ^~~~ > > Reported-by: Euler Robot > Signed-off-by: Chen Qun R

Re: [PATCH] hw: dev-wacom: Support wacom tablet emulation in linux qemu

Hi Gerd On Mon, Aug 17, 2020 at 8:47 AM Gerd Hoffmann wrote: > > On Wed, Aug 12, 2020 at 05:21:49PM +0200, Michael Trimarchi wrote: > > Linux need to fill up the hid descriptor in order to let > > the driver be emulated. This patch was tested on top of > > qemu 4.2.0 and recent linux kernel. > >

Re: [PATCH] hw: dev-wacom: Support wacom tablet emulation in linux qemu

On Wed, Aug 12, 2020 at 05:21:49PM +0200, Michael Trimarchi wrote: > Linux need to fill up the hid descriptor in order to let > the driver be emulated. This patch was tested on top of > qemu 4.2.0 and recent linux kernel. > > modprobe wacom.ko > evtest tool > > Signed-off-by: Michael Trimarchi >

Re: [PATCH v2 00/16] hw/block/nvme: dma handling and address mapping cleanup

On Jul 30 00:06, Klaus Jensen wrote: > From: Klaus Jensen > > This series consists of patches that refactors dma read/write and adds a > number of address mapping helper functions. > > v2: > * hw/block/nvme: add mapping helpers > - Add an assert in case of out of bounds array access. (Maxi

Re: device compatibility interface for live migration with assigned devices

On Thu, 13 Aug 2020 15:02:53 -0400 Eric Farman wrote: > On 8/13/20 11:33 AM, Cornelia Huck wrote: > > On Fri, 7 Aug 2020 13:59:42 +0200 > > Cornelia Huck wrote: > > > >> On Wed, 05 Aug 2020 12:35:01 +0100 > >> Sean Mooney wrote: > >> > >>> On Wed, 2020-08-05 at 12:53 +0200, Jiri Pirko wrot

Re: [PATCH v6 2/2] nvme: allow cmb and pmr to be enabled on same device

On Jul 30 00:50, Klaus Jensen wrote: > On Jul 29 15:01, Andrzej Jakowski wrote: > > So far it was not possible to have CMB and PMR emulated on the same > > device, because BAR2 was used exclusively either of PMR or CMB. This > > patch places CMB at BAR4 offset so it not conflicts with MSI-X vectors

Re: [PATCH v3 0/8] Generalize start-powered-off property from ARM

On Mon, Aug 17, 2020 at 07:24:43AM +0200, Philippe Mathieu-Daudé wrote: > On 8/17/20 6:47 AM, David Gibson wrote: > > On Wed, Jul 22, 2020 at 11:56:49PM -0300, Thiago Jung Bauermann wrote: > >> The ARM code has a start-powered-off property in ARMCPU, which is a > >> subclass of CPUState. This prope

Re: hw-display-qxl.so: undefined symbol: qemu_qxl_io_log_semaphore

Hi, > FWIW I'm still hitting issues with qemu-5.1.0 GA but maybe it's > unrelated to that specific fix. Issues reproduce on fedora 33+, not > fedora 32. > +Failed to open module: > /builddir/build/BUILD/qemu-5.1.0-rc3/build-dynamic/x86_64-softmmu/../hw-display-qxl.so: > undefined symbol: qemu_q

Re: [PATCH] memory: Initialize MemoryRegionOps for RAM memory regions

+Prasad On 8/16/20 8:26 PM, Philippe Mathieu-Daudé wrote: > There is an issue when using memory_region_dispatch_read() or > memory_region_dispatch_write() on RAM memory regions. > > RAM memory regions are initialized as: > > memory_region_init_ram() > -> memory_region_init_ram_nomigrate() >

Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks

On 8/17/20 7:02 AM, P J P wrote: > +-- On Sun, 16 Aug 2020, Philippe Mathieu-Daudé wrote --+ > | On 8/11/20 1:41 PM, P J P wrote: > | > From: Prasad J Pandit > | > * This series asserts that MemoryRegionOps objects define read/write > | > callback methods. Thus avoids potential NULL pointer dere

Re: [PATCH v3 0/8] Generalize start-powered-off property from ARM

On 8/17/20 6:47 AM, David Gibson wrote: > On Wed, Jul 22, 2020 at 11:56:49PM -0300, Thiago Jung Bauermann wrote: >> The ARM code has a start-powered-off property in ARMCPU, which is a >> subclass of CPUState. This property causes arm_cpu_reset() to set >> CPUState::halted to 1, signalling that the

Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks

+-- On Sun, 16 Aug 2020, Philippe Mathieu-Daudé wrote --+ | On 8/11/20 1:41 PM, P J P wrote: | > From: Prasad J Pandit | > * This series asserts that MemoryRegionOps objects define read/write | > callback methods. Thus avoids potential NULL pointer dereference. | > ex. -> https://git.qemu.org

Re: [PATCH v3 0/8] Generalize start-powered-off property from ARM

On Wed, Jul 22, 2020 at 11:56:49PM -0300, Thiago Jung Bauermann wrote: > The ARM code has a start-powered-off property in ARMCPU, which is a > subclass of CPUState. This property causes arm_cpu_reset() to set > CPUState::halted to 1, signalling that the CPU should start in a halted > state. Other a

[Bug 1880507] Re: VMM from Ubuntu 20.04 does not show the memory consumption

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1880507 Title: VMM from Ub

Re: [PATCH] ide:do nothing for identify cmd if no any device attached

Patchew URL: https://patchew.org/QEMU/20200817033803.14014-1-rockcui...@zhaoxin.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

[PATCH] ide:do nothing for identify cmd if no any device attached

This patch is for avoiding win7 IDE driver polling 0x1f7 when no any device attached. During Win7 VM boot procedure, if use virtio for disk and there is no any device be attached on hda & hdb, the win7 IDE driver would poll 0x1f7 for a while. This action may be stop windows LOGO atomic for a while

Re: [PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning

On Sun, Aug 16, 2020 at 11:26 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/16/20 5:57 PM, Rohit Shinde wrote: > > I misread the comment. The comment /* fallthrough */ was meant to stop > the > > compiler warning from occurring. I am trying to complete the bite sized > task >

[Bug 1891829] Re: High bit(s) sometimes set high on rcvd serial bytes when char size < 8 bits

** Summary changed: - High bits(s) sometimes set high on rcvd serial bytes when char size < 8 bits + High bit(s) sometimes set high on rcvd serial bytes when char size < 8 bits -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://

Re: [PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning

On 8/16/20 5:57 PM, Rohit Shinde wrote: > I misread the comment. The comment /* fallthrough */ was meant to stop the > compiler warning from occurring. I am trying to complete the bite sized task > mentioned here  under > "Compiler driven cleanups".

Re: [PATCH v3 00/10] *** A Method for evaluating dirty page rate ***

Patchew URL: https://patchew.org/QEMU/1597634433-18809-1-git-send-email-zhengch...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1597634433-18809-1-git-send-email-zhengch...@huawei.com Subject: [PATCH v3 0

[PATCH v3 10/10] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function

Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be called Signed-off-by: Chuan Zheng --- migration/dirtyrate.c | 56 +++ qapi/migration.json | 42 ++ 2 files changed, 98 insertions(+)

[PATCH v3 04/10] migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h

RAMBLOCK_FOREACH_MIGRATABLE is need in dirtyrate measure, move the existing definition up into migration/ram.h Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang --- migration/dirtyrate.c | 1 + migration/ram.c | 11 +-- migration/ram.h | 10 ++ 3 files change

[PATCH v3 05/10] migration/dirtyrate: Record hash results for each sampled page

Record hash results for each sampled page. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang --- migration/dirtyrate.c | 144 ++ migration/dirtyrate.h | 7 +++ 2 files changed, 151 insertions(+) diff --git a/migration/dirtyrate.c b/migra

[PATCH v3 06/10] migration/dirtyrate: Compare page hash results for recorded sampled page

Compare page hash results for recorded sampled page. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang --- migration/dirtyrate.c | 76 +++ 1 file changed, 76 insertions(+) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index 62

[PATCH v3 07/10] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE

In order to sample real RAM, skip ramblock with size below Signed-off-by: Chuan Zheng --- migration/dirtyrate.c | 24 migration/dirtyrate.h | 5 + 2 files changed, 29 insertions(+) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index 3ce25f5..6f30f67 10

[PATCH v3 02/10] migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info

Add RamlockDirtyInfo to store sampled page info of each ramblock. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang --- migration/dirtyrate.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/migration/dirtyrate.h b/migration/dirtyrate.h index 914c363..9650566 10064

[PATCH v3 01/10] migration/dirtyrate: Add get_dirtyrate_thread() function

Add get_dirtyrate_thread() functions Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang --- migration/Makefile.objs | 1 + migration/dirtyrate.c | 64 + migration/dirtyrate.h | 44 ++ 3 files changed, 109

[PATCH v3 08/10] migration/dirtyrate: Implement get_sample_page_period() and block_sample_page_period()

Implement get_sample_page_period() and set_sample_page_period() to sleep specific time between sample actions. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang --- migration/dirtyrate.c | 24 migration/dirtyrate.h | 2 ++ 2 files changed, 26 insertions(+) diff

[PATCH v3 00/10] *** A Method for evaluating dirty page rate ***

v2 -> v3: fix size_t compile warning fix codestyle checked by checkpatch.pl v1 -> v2: use g_rand_new() to generate rand_buf move RAMBLOCK_FOREACH_MIGRATABLE into migration/ram.h add skip_sample_ramblock to filter sampled ramblock fix multi-numa vm coredump when query dirtyr

[PATCH v3 09/10] migration/dirtyrate: Implement calculate_dirtyrate() function

Implement calculate_dirtyrate() function. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang --- migration/dirtyrate.c | 46 -- 1 file changed, 44 insertions(+), 2 deletions(-) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index 4b

[PATCH v3 03/10] migration/dirtyrate: Add dirtyrate statistics series functions

Add dirtyrate statistics to record/update dirtyrate info. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang --- migration/dirtyrate.c | 30 ++ migration/dirtyrate.h | 10 ++ 2 files changed, 40 insertions(+) diff --git a/migration/dirtyrate.c b/migrat

Re: device compatibility interface for live migration with assigned devices

On Fri, Aug 14, 2020 at 01:30:00PM +0100, Sean Mooney wrote: > On Fri, 2020-08-14 at 13:16 +0800, Yan Zhao wrote: > > On Thu, Aug 13, 2020 at 12:24:50PM +0800, Jason Wang wrote: > > > > > > On 2020/8/10 下午3:46, Yan Zhao wrote: > > > > > driver is it handled by? > > > > > > > > It looks that the d

[Bug 1891830] [NEW] msmouse serial mouse emulation broken? No id byte sent on reset

Public bug reported: I took a shot at getting Windows 1.01 working. It doesn't support a PS/2 mouse out-of-the-box but does support MS serial mice. It doesn't seem to detect qemu's emulated msmouse. When I run this command: > qemu-system-i386 -nodefaults -hda my_windows1_hd.qcow2 -vga std -ser

[Bug 1891829] Re: High bits(s) sometimes set high on rcvd serial bytes when char size < 8 bits

I will hopefully submit a patch for review soon. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1891829 Title: High bits(s) sometimes set high on rcvd serial bytes when char size < 8 bits Status

Re: [PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning

On Sun, Aug 16, 2020 at 6:52 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/16/20 9:55 AM, Rohit Shinde wrote: > > Hey Richard, > > > > 1. So I should fork off the master again? > > Yes. > > There need to be special circumstances for not posting a patch set > relative to > mas

[Bug 1891829] [NEW] High bits(s) sometimes set high on rcvd serial bytes when char size < 8 bits

Public bug reported: I *believe* (not confirmed) that the old standard PC serial ports, when configured with a character size of 7 bits or less, should set non-data bits to 0 when the CPU reads received chars from the read register. qemu doesn't do this. Windows 1.01 will not make use of a serial

Re: [PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning

On 8/16/20 9:55 AM, Rohit Shinde wrote: > Hey Richard, > > 1. So I should fork off the master again? Yes. There need to be special circumstances for not posting a patch set relative to master, and even then your cover letter would need to detail against what base the patch set applies. > 2. I

Re: [PATCH] fixed proc myself (linux user) for musl

>From 738f6ec4598b4618acd7ecbd11e5d250a82f28b7 Mon Sep 17 00:00:00 2001 From: Andrew Aladjev Date: Mon, 17 Aug 2020 01:20:03 +0300 Subject: [PATCH] fixed proc myself (linux user) for musl Signed-off-by: Andrew Aladjev --- linux-user/Makefile.objs | 5 +- linux-user/elfload.c | 7 ++-

Guest Physical addresses tracking in KVM mode

Hi, I want to ask if it is possible to monitor the Guest Physical addresses inside QEMU code while running with KVM mode. Appreciate your help Thanks Mahmoud

Re: [PATCH] fixed proc myself (linux user) for musl

Hi Andrew, Cc'ing the maintainer & Richard. ./scripts/get_maintainer.pl -f linux-user/main.c Laurent Vivier (maintainer:Linux user) On 8/16/20 9:58 PM, Андрей Аладьев wrote: > From: Andrew Aladjev > > Date: Sun, 16 Aug 2020 22:50:13 +0300 > Subject: [PATCH] fix

[PATCH] fixed proc myself (linux user) for musl

From: Andrew Aladjev Date: Sun, 16 Aug 2020 22:50:13 +0300 Subject: [PATCH] fixed proc myself (linux user) for musl Buglink: https://bugs.gentoo.org/587230 Signed-off-by: Andrew Aladjev --- linux-user/Makefile.objs | 5 +- linux-user/elfload.c | 7 ++- linux-user/exit.c | 7 ++-

[PATCH] memory: Initialize MemoryRegionOps for RAM memory regions

There is an issue when using memory_region_dispatch_read() or memory_region_dispatch_write() on RAM memory regions. RAM memory regions are initialized as: memory_region_init_ram() -> memory_region_init_ram_nomigrate() -> memory_region_init_ram_shared_nomigrate() -> memory_region_

[PATCH] trace/simple: Enable tracing on startup only if the user specifies a trace option

From: Josh DuBois Tracing can be enabled at the command line or via the monitor. Command-line trace options are recorded during trace_opt_parse(), but tracing is not enabled until the various front-ends later call trace_init_file(). If the user passes a trace option on the command-line, remember

[PATCH] memory: Directly dispatch alias accesses on origin memory region

There is an issue when accessing an alias memory region via the memory_region_dispatch_read() / memory_region_dispatch_write() calls: The memory_region_init_alias() flow is: memory_region_init_alias() -> memory_region_init() -> object_initialize(TYPE_MEMORY_REGION) -> memory_regi

Re: [PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning

Hey Richard, 1. So I should fork off the master again? I am a bit unclear on the workflow, since this is my first doing patches via format-patch and send-email so I am making mistakes. 2. I just checked and my version of the code doesn't contain that line, so I am unsure on how tha

Re: [PATCH 14/18] hw/net: cadence_gem: Add a new 'phy-addr' property

On 8/16/20 3:42 PM, Bin Meng wrote: > On Sun, Aug 16, 2020 at 8:08 PM Nathan Rossi wrote: >> >> On Sun, 16 Aug 2020 at 18:29, Bin Meng wrote: >>> >>> On Sat, Aug 15, 2020 at 5:06 PM Philippe Mathieu-Daudé >>> wrote: On 8/14/20 6:40 PM, Bin Meng wrote: > From: Bin Meng > >

Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks

On 8/11/20 1:41 PM, P J P wrote: > From: Prasad J Pandit > > Hello, > > * This series asserts that MemoryRegionOps objects define read/write > callback methods. Thus avoids potential NULL pointer dereference. > ex. -> > https://git.qemu.org/?p=qemu.git;a=commit;h=bb15013ef34617eb1344f527629

Re: [PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning

On 8/15/20 7:31 PM, Rohit Shinde wrote: > /* range has been completed, fall through in order to pop option */ > -__attribute__((fallthrough)); > +/* fallthrough */ (1) Any patch should not be relative to your own v3. (2) The previous line already contains the words "fall t

[PATCH v2] virtio-mem: detach the element from the virtqueue when error occurs

If error occurs while processing the virtio request we should call 'virtqueue_detach_element' to detach the element from the virtqueue before free the elem. Signed-off-by: Li Qiang --- Change since v1: Change the subject Avoid using the goto label hw/virtio/virtio-mem.c | 3 +++ 1 file changed,

Re: [PATCH 14/18] hw/net: cadence_gem: Add a new 'phy-addr' property

On Sun, Aug 16, 2020 at 8:08 PM Nathan Rossi wrote: > > On Sun, 16 Aug 2020 at 18:29, Bin Meng wrote: > > > > On Sat, Aug 15, 2020 at 5:06 PM Philippe Mathieu-Daudé > > wrote: > > > > > > On 8/14/20 6:40 PM, Bin Meng wrote: > > > > From: Bin Meng > > > > > > > > At present the PHY address of t

Re: [PATCH] spapr/xive: Allocate IPIs from the vCPU contexts

On 8/16/20 6:30 AM, David Gibson wrote: > On Fri, Aug 14, 2020 at 05:08:13PM +0200, Cédric Le Goater wrote: >> >> This works as expected with a 128 vCPUs guest with pinned vcpus. The >> first 64 IPIs are allocated on the first chip and the remaining 64 >> on the second chip. >> >> Still, this is mo

Re: [PATCH] hw: virtio-mem: detach the element fromt the virtqueue when error occurs

On 14.08.20 03:01, Li Qiang wrote: > David Hildenbrand 于2020年8月14日周五 上午1:15写道： >> >> On 13.08.20 18:46, Li Qiang wrote: >> >> For now we use "virtio-mem:" for the subject, without the "hw: "part. >> >>> If error occurs while processing the virtio request we should call >>> 'virtqueue_detach_elemen

Re: [PATCH 14/18] hw/net: cadence_gem: Add a new 'phy-addr' property

On Sun, 16 Aug 2020 at 18:29, Bin Meng wrote: > > On Sat, Aug 15, 2020 at 5:06 PM Philippe Mathieu-Daudé > wrote: > > > > On 8/14/20 6:40 PM, Bin Meng wrote: > > > From: Bin Meng > > > > > > At present the PHY address of the PHY connected to GEM is hard-coded > > > to either 23 (BOARD_PHY_ADDRE

[Bug 1890545] Re: (ARM64) qemu-x86_64+schroot(Debian bullseye) can't run chrome and can't load HTML

Could you try attached patch? ** Patch added: "add QEMU_IFLA_INFO_KIND nested type for sit" https://bugs.launchpad.net/qemu/+bug/1890545/+attachment/5401933/+files/0001-linux-user-add-QEMU_IFLA_INFO_KIND-nested-type-for-s.patch -- You received this bug notification because you are a member o

Re: [PATCH 14/18] hw/net: cadence_gem: Add a new 'phy-addr' property

On 8/16/20 10:29 AM, Bin Meng wrote: > On Sat, Aug 15, 2020 at 5:06 PM Philippe Mathieu-Daudé > wrote: >> >> On 8/14/20 6:40 PM, Bin Meng wrote: >>> From: Bin Meng >>> >>> At present the PHY address of the PHY connected to GEM is hard-coded >>> to either 23 (BOARD_PHY_ADDRESS) or 0. This might n

Re: [PATCH 13/18] hw/riscv: microchip_pfsoc: Connect a DMA controller

On 8/16/20 10:57 AM, Bin Meng wrote: > Hi Philippe, > > On Sat, Aug 15, 2020 at 5:00 PM Philippe Mathieu-Daudé > wrote: >> >> On 8/14/20 6:40 PM, Bin Meng wrote: >>> From: Bin Meng >>> >>> Connect a DMA controller to Microchip PolarFire SoC. Note interrupt >>> has not been connected due to miss

Re: [PATCH 09/18] hw/sd: sdhci: Make sdhci_poweron_reset() internal visible

On 8/16/20 10:50 AM, Bin Meng wrote: > Hi Philippe, > > On Sat, Aug 15, 2020 at 3:51 PM Philippe Mathieu-Daudé > wrote: >> >> On 8/14/20 6:40 PM, Bin Meng wrote: >>> From: Bin Meng >>> >>> sdhci_poweron_reset() might be needed for any SDHCI compatible >>> device that is built on top of the gene

[Bug 1891749] Re: CGA Mode 6 is only 100 pixels tall, when it's supposed to be 200

** Tags removed: linux-user -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1891749 Title: CGA Mode 6 is only 100 pixels tall, when it's supposed to be 200 Status in QEMU: New Bug description:

Re: [PATCH 13/18] hw/riscv: microchip_pfsoc: Connect a DMA controller

Hi Philippe, On Sat, Aug 15, 2020 at 5:00 PM Philippe Mathieu-Daudé wrote: > > On 8/14/20 6:40 PM, Bin Meng wrote: > > From: Bin Meng > > > > Connect a DMA controller to Microchip PolarFire SoC. Note interrupt > > has not been connected due to missing information in the manual how > > interrupts

Re: [PATCH 08/18] hw/sd: sd: Correctly set the high capacity bit

Hi Philippe, On Sat, Aug 15, 2020 at 4:38 PM Philippe Mathieu-Daudé wrote: > > On 8/14/20 6:40 PM, Bin Meng wrote: > > From: Bin Meng > > > > Per the SD spec, Standard Capacity SD Memory Card (SDSC) supports > > capacity up to and including 2 GiB. > > > > Fixes: 2d7adea4fe ("hw/sd: Support SDHC

Re: [PATCH 09/18] hw/sd: sdhci: Make sdhci_poweron_reset() internal visible

Hi Philippe, On Sat, Aug 15, 2020 at 3:51 PM Philippe Mathieu-Daudé wrote: > > On 8/14/20 6:40 PM, Bin Meng wrote: > > From: Bin Meng > > > > sdhci_poweron_reset() might be needed for any SDHCI compatible > > device that is built on top of the generic SDHCI device. > > NAck. Please use device_le

Re: [PATCH 3/3] virtio-crypto: don't modify elem->in/out_sg

Stefan Hajnoczi 于2020年8月12日周三 下午6:51写道： > A number of iov_discard_front/back() operations are made by > virtio-crypto. The elem->in/out_sg iovec arrays are modified by these > operations, resulting virtqueue_unmap_sg() calls on different addresses > than were originally mapped. > > This is proble

Re: [PATCH 14/18] hw/net: cadence_gem: Add a new 'phy-addr' property

On Sat, Aug 15, 2020 at 5:06 PM Philippe Mathieu-Daudé wrote: > > On 8/14/20 6:40 PM, Bin Meng wrote: > > From: Bin Meng > > > > At present the PHY address of the PHY connected to GEM is hard-coded > > to either 23 (BOARD_PHY_ADDRESS) or 0. This might not be the case for > > all boards. Add a new

Re: [PATCH 1/3] util/iov: add iov_discard_undo()

Stefan Hajnoczi 于2020年8月12日周三 下午6:52写道： > The iov_discard_front/back() operations are useful for parsing iovecs > but they modify the array elements. If the original array is needed > after parsing finishes there is currently no way to restore it. > > Although g_memdup() can be used before perfor