Re: [PATCH] util/vfio-helpers: Unify trace-events size format

2020-08-20 Thread Cornelia Huck
On Thu, 20 Aug 2020 19:10:06 +0200 Philippe Mathieu-Daudé wrote: > Some 'qemu_vfio_*' trace events sizes are displayed using > decimal notation, other using hexadecimal notation: > > qemu_vfio_ram_block_added s 0xf2448d90 host 0x5bc0 size > 0x400 > qemu_vfio_dma_map s 0x

Re: [PULL v7 000/151] Meson-based build system

2020-08-20 Thread Howard Spoelstra
On Wed, Aug 19, 2020 at 11:32 PM Paolo Bonzini wrote: > The following changes since commit > d0ed6a69d399ae193959225cdeaa9382746c91cc: > > Update version for v5.1.0 release (2020-08-11 17:07:03 +0100) > > are available in the Git repository at: > > https://gitlab.com/bonzini/qemu.git tags/for

Re: [PATCH v2] spapr/xive: Use the xics flag to check for XIVE-only IRQ backends

2020-08-20 Thread Cédric Le Goater
On 8/21/20 1:22 AM, David Gibson wrote: > On Thu, Aug 20, 2020 at 04:01:06PM +0200, Cédric Le Goater wrote: >> The sPAPR machine has four different IRQ backends, each implementing >> the XICS or XIVE interrupt mode or both in the case of the 'dual' >> backend. >> >> If a machine is started in P8 co

[PATCH] virtiofsd: add -o allow_directio|no_directio option

2020-08-20 Thread Jiachen Zhang
Due to the commit 65da4539803373ec4eec97ffc49ee90083e56efd, the O_DIRECT open flag of guest applications will be discarded by virtiofsd. While this behavior makes it consistent with the virtio-9p scheme when guest applications using direct I/O, we no longer have any chance to bypass the host page c

Re: [RFC PATCH v2 0/4] Use ACPI PCI hot-plug for q35

2020-08-20 Thread Michael S. Tsirkin
On Tue, Aug 18, 2020 at 11:52:23PM +0200, Julia Suvorova wrote: > PCIe native hot-plug has numerous problems with racing events and > unpredictable > guest behaviour (Windows). Switching to ACPI hot-plug for now. > > Tested on RHEL 8 and Windows 2019. > pxb-pcie is not yet supported. Julia, pls

Re: [ovirt-devel] Re: device compatibility interface for live migration with assigned devices

2020-08-20 Thread Jason Wang
On 2020/8/20 下午8:27, Cornelia Huck wrote: On Wed, 19 Aug 2020 17:28:38 +0800 Jason Wang wrote: On 2020/8/19 下午4:13, Yan Zhao wrote: On Wed, Aug 19, 2020 at 03:39:50PM +0800, Jason Wang wrote: On 2020/8/19 下午2:59, Yan Zhao wrote: On Wed, Aug 19, 2020 at 02:57:34PM +0800, Jason Wang wrote:

[Bug 1892441] Re: "No zIPL section in IPL2 record" error when emulating Debian 10.5.0 on s390x

2020-08-20 Thread Ahmed Karaman
** Description changed: Hi, - I want to emulate Debian 10.5.0 for the s390x architecture. + I want to emulate Debian 10.5.0 for the s390x architecture. The Debian image is downloaded from the following link: - https://cdimage.debian.org/debian-cd/current/s390x/iso-cd/debian-10.5.0-s390x-n

[Bug 1892441] [NEW] "No zIPL section in IPL2 record" error when emulating Debian 10.5.0 on s390x

2020-08-20 Thread Ahmed Karaman
Public bug reported: Hi, I want to emulate Debian 10.5.0 for the s390x architecture. The Debian image is downloaded from the following link: https://cdimage.debian.org/debian-cd/current/s390x/iso-cd/debian-10.5.0-s390x-netinst.iso Using the latest QEMU version 5.1.0, running the debian image

Re: Suspicious QOM types without instance/class size

2020-08-20 Thread David Gibson
On Thu, Aug 20, 2020 at 05:55:29PM -0400, Eduardo Habkost wrote: > While trying to convert TypeInfo declarations to the new > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases > where instance_size or class_size is not set, despite having type > checker macros that use a specific type

Re: [PATCH v2 0/4] spapr/xive: Allocate vCPU IPIs from the vCPU contexts

2020-08-20 Thread David Gibson
On Thu, Aug 20, 2020 at 03:45:43PM +0200, Cédric Le Goater wrote: > Hello, > > > When QEMU switches to the XIVE interrupt mode, it creates all the > guest interrupts at the level of the KVM device. These interrupts are > backed by real HW interrupts from the IPI interrupt pool of the XIVE > contr

Re: [PATCH] hw/arm/virt: Default to architecture appropriate CPU

2020-08-20 Thread Punit Agrawal
Hi Peter, Thanks for the quick feedback and the background. Peter Maydell writes: > On Thu, 20 Aug 2020 at 05:55, Punit Agrawal > wrote: >> >> The default_cpu_type for the Virt machine is set to "cortex-a15" for >> both the arm (qemu-system-arm) and aarch64 (qemu-system-aarch64) >> targets. >

Re: [PATCH v2 0/3] hw/sd: Add Cadence SDHCI emulation

2020-08-20 Thread Bin Meng
Hi Philippe, On Fri, Aug 21, 2020 at 2:04 AM Philippe Mathieu-Daudé wrote: > > Hi Sai Pavan, you said you were interested to test the first 2 > patches. FYI I plan to queue them and send the pull request tomorrow > or Saturday the latest. Have you got a chance to review the v2 of 3rd patch? "hw

Re: [PATCH v4 4/4] iotests: Test node/bitmap aliases during migration

2020-08-20 Thread Eric Blake
On 8/20/20 10:49 AM, Vladimir Sementsov-Ogievskiy wrote: # MYPYPATH=../../python/ mypy 300 300:154: error: Item "None" of "Optional[Match[Any]]" has no attribute "group" Found 1 error in 1 file (checked 1 source file) - the only complain. Suggest a fix: diff --git a/tests/qemu-iotests/300 b/t

Re: [PATCH v5 3/3] iotests: Test node/bitmap aliases during migration

2020-08-20 Thread Eric Blake
On 8/20/20 10:07 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/300 | 595 + tests/qemu-iotests/300.out | 5 + tests/qemu-iotests/group | 1 + 3 files changed, 601 insertions(+) create mode 100755 tests/qemu-iotests/300

Re: [PATCH v5 1/3] migration: Add block-bitmap-mapping parameter

2020-08-20 Thread Eric Blake
On 8/20/20 10:07 AM, Max Reitz wrote: This migration parameter allows mapping block node names and bitmap names to aliases for the purpose of block dirty bitmap migration. This way, management tools can use different node and bitmap names on the source and destination and pass the mapping of how

Re: [PATCH v2] spapr/xive: Use the xics flag to check for XIVE-only IRQ backends

2020-08-20 Thread David Gibson
On Thu, Aug 20, 2020 at 04:01:06PM +0200, Cédric Le Goater wrote: > The sPAPR machine has four different IRQ backends, each implementing > the XICS or XIVE interrupt mode or both in the case of the 'dual' > backend. > > If a machine is started in P8 compat mode, QEMU should necessarily > support t

Re: [PATCH 1/1] spapr_vscsi: do not allow device hotplug

2020-08-20 Thread David Gibson
On Thu, Aug 20, 2020 at 04:06:35PM -0300, Daniel Henrique Barboza wrote: > We do not implement hotplug in the vscsi bus, but we forgot to > tell qdev about it. The result is that users are able to hotplug > devices in the vscsi bus, the devices appear in qdev, but they > aren't usable by the guest

Re: [PATCH v2] ppc/pnv: Add a HIOMAP erase command

2020-08-20 Thread David Gibson
On Thu, Aug 20, 2020 at 06:46:38PM +0200, Cédric Le Goater wrote: > The OPAL test suite runs a read-erase-write test on the PNOR : > > https://github.com/open-power/op-test/blob/master/testcases/OpTestPNOR.py > > which revealed that the IPMI HIOMAP handlers didn't support > HIOMAP_C_ERASE. Impl

[PATCH v2 3/5] qemu-iotests: Support varargs syntax in FilePaths

2020-08-20 Thread Nir Soffer
Accept variable number of names instead of a sequence: with FilePaths("a", "b", "c") as (a, b, c): The disadvantage is that base_dir must be used as kwarg: with FilePaths("a", "b", base_dir=soc_dir) as (sock1, sock2): But this is more clear and calling optional argument as positional ar

[PATCH v2 2/5] qemu-iotests: Fix FilePaths docstring

2020-08-20 Thread Nir Soffer
When this class was extracted from FilePath, the docstring was not updated for generating multiple files, and the example usage was referencing unrelated file. Fixes: de263986b5dc Signed-off-by: Nir Soffer --- tests/qemu-iotests/iotests.py | 14 -- 1 file changed, 8 insertions(+), 6

[PATCH v2 0/5] iotest.FilePath fixes and cleanups

2020-08-20 Thread Nir Soffer
Fix some issues introduced when iotests.FilePaths was added and merge it back into FilePath keeping the option to create multiple file names. Changes since v1: - Remove unwanted submodule change [Eric] - Add Fixes: tag v1 was here: https://lists.nongnu.org/archive/html/qemu-block/2020-08/msg00773

[PATCH v2 4/5] qemu-iotests: Merge FilePaths and FilePath

2020-08-20 Thread Nir Soffer
FilePath creates now one temporary file: with FilePath("a") as a: Or more: with FilePath("a", "b", "c") as (a, b, c): This is also the behavior of the file_path() helper, used by some of the tests. Now we have only 2 helpers for creating temporary files instead of 3. Signed-off-by: Nir

[PATCH v2 1/5] qemu-iotests: Fix FilePaths cleanup

2020-08-20 Thread Nir Soffer
If os.remove() fails to remove one of the paths, for example if the file was removed by the test, the cleanup loop would exit silently, without removing the rest of the files. Fixes: de263986b5dc Signed-off-by: Nir Soffer --- tests/qemu-iotests/iotests.py | 8 1 file changed, 4 insertio

[PATCH v2 5/5] qemu-iotests: Simplify FilePath __init__

2020-08-20 Thread Nir Soffer
Use list comprehension instead of append loop. Signed-off-by: Nir Soffer --- tests/qemu-iotests/iotests.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 1b5cdd493e..7ebd0bcc92 100644 --- a/tests/qemu-i

Re: [PATCH 0/1] qcow2: Skip copy-on-write when allocating a zero cluster

2020-08-20 Thread Dave Chinner
On Thu, Aug 20, 2020 at 10:03:10PM +0200, Alberto Garcia wrote: > Cc: linux-xfs > > On Wed 19 Aug 2020 07:53:00 PM CEST, Brian Foster wrote: > > In any event, if you're seeing unclear or unexpected performance > > deltas between certain XFS configurations or other fs', I think the > > best thing t

Re: [PATCH] qemu-iotests: Fix FilePaths cleanup

2020-08-20 Thread Nir Soffer
On Fri, Aug 21, 2020 at 12:40 AM Nir Soffer wrote: > > On Fri, Aug 21, 2020 at 12:33 AM Eric Blake wrote: > > > > On 8/20/20 4:29 PM, Eric Blake wrote: > > > On 8/20/20 4:19 PM, Nir Soffer wrote: > > >> If os.remove() fails to remove one of the paths, for example if the file > > >> was removed by

Suspicious QOM types without instance/class size

2020-08-20 Thread Eduardo Habkost
While trying to convert TypeInfo declarations to the new OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases where instance_size or class_size is not set, despite having type checker macros that use a specific type. The ones with "WARNING" are abstract types (maybe not serious if subcl

Re: [PATCH] qemu-iotests: Fix FilePaths cleanup

2020-08-20 Thread Nir Soffer
On Fri, Aug 21, 2020 at 12:33 AM Eric Blake wrote: > > On 8/20/20 4:29 PM, Eric Blake wrote: > > On 8/20/20 4:19 PM, Nir Soffer wrote: > >> If os.remove() fails to remove one of the paths, for example if the file > >> was removed by the test, the cleanup loop would exit silently, without > >> remo

Re: [PATCH] qemu-iotests: Fix FilePaths cleanup

2020-08-20 Thread Eric Blake
On 8/20/20 4:29 PM, Eric Blake wrote: On 8/20/20 4:19 PM, Nir Soffer wrote: If os.remove() fails to remove one of the paths, for example if the file was removed by the test, the cleanup loop would exit silently, without removing the rest of the files. Signed-off-by: Nir Soffer ---   dtc   

[REPORT] Nightly Performance Tests - Thursday, August 20, 2020

2020-08-20 Thread Ahmed Karaman
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz Host Memory : 15.49 GB Start Time (UTC) : 2020-08-20 21:00:02 End Time (UTC) : 2020-08-20 21:32:14 Execution Time : 0:32:12.619200 Status : SUCCESS

Re: [PATCH] qemu-iotests: Fix FilePaths cleanup

2020-08-20 Thread Eric Blake
On 8/20/20 4:19 PM, Nir Soffer wrote: If os.remove() fails to remove one of the paths, for example if the file was removed by the test, the cleanup loop would exit silently, without removing the rest of the files. Signed-off-by: Nir Soffer --- dtc | 2 +- tests/qemu

Re: [PATCH] qemu-iotests: Fix FilePaths cleanup

2020-08-20 Thread Nir Soffer
On Fri, Aug 21, 2020 at 12:19 AM Nir Soffer wrote: > > If os.remove() fails to remove one of the paths, for example if the file > was removed by the test, the cleanup loop would exit silently, without > removing the rest of the files. > > Signed-off-by: Nir Soffer > --- > dtc

[PATCH] qemu-iotests: Fix FilePaths cleanup

2020-08-20 Thread Nir Soffer
If os.remove() fails to remove one of the paths, for example if the file was removed by the test, the cleanup loop would exit silently, without removing the rest of the files. Signed-off-by: Nir Soffer --- dtc | 2 +- tests/qemu-iotests/iotests.py | 8 2 files

Re: [PATCH v2] configure: add support for pseudo-"in source tree" builds

2020-08-20 Thread Eric Blake
On 8/20/20 12:31 PM, Daniel P. Berrangé wrote: Meson requires the build dir to be separate from the source tree. Many people are used to just running "./configure && make" though and the meson conversion breaks that. This introduces some backcompat support to make it appear as if an "in source t

Re: [PATCH v4 08/10] iotests.py: add verify_o_direct helper

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
21.08.2020 00:00, Nir Soffer wrote: On Thu, Aug 20, 2020 at 9:49 PM Vladimir Sementsov-Ogievskiy wrote: Add python notrun-helper similar to _check_o_direct for bash tests. To be used in the following commit. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi --- test

Re: [PATCH v4 08/10] iotests.py: add verify_o_direct helper

2020-08-20 Thread Nir Soffer
On Thu, Aug 20, 2020 at 9:49 PM Vladimir Sementsov-Ogievskiy wrote: > > Add python notrun-helper similar to _check_o_direct for bash tests. > To be used in the following commit. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Stefan Hajnoczi > --- > tests/qemu-iotests/iotests.py

Re: [PATCH v7 13/13] tests/acceptance: console boot tests for quanta-gsj

2020-08-20 Thread Havard Skinnemoen
On Thu, Aug 20, 2020 at 10:46 AM Philippe Mathieu-Daudé wrote: > > On 8/20/20 6:24 PM, Havard Skinnemoen wrote: > > On Wed, Aug 19, 2020 at 10:29 PM Philippe Mathieu-Daudé > > wrote: > >> > >> +Eric / Richard for compiler optimizations. > >> > >> On 8/20/20 3:53 AM, Havard Skinnemoen wrote: > >>

Trying to install win7 on qemu 5.1 with whpx failed, any suggestion?

2020-08-20 Thread Yonggang Luo
``` qemu-system-x86_64 -m 8192 ^ -machine type=q35,accel=whpx ^ -boot order=d ^ -vga std ^ -serial none ^ -parallel none ^ -netdev tap,id=mynet0,ifname=tap1,script=no,downscript=no ^ -device virtio-net-pci,netdev=mynet0,mac=52:55:00:d1:55:10 ^ -device intel-hda -device hda-duplex ^ -usb -device us

Re: [PATCH 0/1] qcow2: Skip copy-on-write when allocating a zero cluster

2020-08-20 Thread Alberto Garcia
Cc: linux-xfs On Wed 19 Aug 2020 07:53:00 PM CEST, Brian Foster wrote: > In any event, if you're seeing unclear or unexpected performance > deltas between certain XFS configurations or other fs', I think the > best thing to do is post a more complete description of the workload, > filesystem/stora

[PATCH v1 1/2] microblaze: petalogix-ml605: Add device-tree source

2020-08-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add a device-tree source for petalogix-ml605 and recompile the DTB. Signed-off-by: Edgar E. Iglesias --- pc-bios/petalogix-ml605.dtb | Bin 9982 -> 9882 bytes pc-bios/petalogix-ml605.dts | 350 2 files changed, 350 insertions(+) c

[PATCH v1 2/2] microblaze: petalogix-s3adsp1800: Add device-tree source

2020-08-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add a device-tree source for petalogix-s3adsp1800 and recompile the DTB. This also removes the unused mpmc node which causes compilation warnings. Signed-off-by: Edgar E. Iglesias --- pc-bios/petalogix-s3adsp1800.dtb | Bin 8259 -> 8161 bytes pc-bios/petalogix-s3adsp

[PATCH v1 0/2] pc-bios: petalogix: Re-generate DTB and add DTS files

2020-08-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This adds missing device-tree source files for the petalogix boards with recompiled DTBs. Cheers, Edgar Edgar E. Iglesias (2): microblaze: petalogix-ml605: Add device-tree source microblaze: petalogix-s3adsp1800: Add device-tree source pc-bios/petalogix-ml605.dtb

Re: [PATCH v4 00/10] preallocate filter

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
20.08.2020 22:16, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200820183950.13109-1-vsement...@virtuozzo.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can pro

Re: [PATCH v2] ppc/pnv: Add a HIOMAP erase command

2020-08-20 Thread Corey Minyard
On Thu, Aug 20, 2020 at 06:46:38PM +0200, Cédric Le Goater wrote: > The OPAL test suite runs a read-erase-write test on the PNOR : > > https://github.com/open-power/op-test/blob/master/testcases/OpTestPNOR.py > > which revealed that the IPMI HIOMAP handlers didn't support > HIOMAP_C_ERASE. Impl

Re: [PATCH v4 00/10] preallocate filter

2020-08-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200820183950.13109-1-vsement...@virtuozzo.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEG

Avocado's upcoming LTS release

2020-08-20 Thread Cleber Rosa
Hi QEMU community, I'd like to bring to your attention that the Avocado project has an upcoming 82.0 LTS release scheduled for Sept 7th[1]. We're writing to projects that use Avocado so that they can start testing with (what's going to be) the new release, and adapt their usage or influence the f

[PATCH 1/1] spapr_vscsi: do not allow device hotplug

2020-08-20 Thread Daniel Henrique Barboza
We do not implement hotplug in the vscsi bus, but we forgot to tell qdev about it. The result is that users are able to hotplug devices in the vscsi bus, the devices appear in qdev, but they aren't usable by the guest OS unless the user reboots it first. Setting qbus hotplug_handler to NULL will t

Re: [PATCH v2 44/58] qom: provide convenient macros for declaring and defining types

2020-08-20 Thread Eduardo Habkost
On Thu, Aug 20, 2020 at 06:57:33PM +0100, Daniel P. Berrangé wrote: > On Thu, Aug 20, 2020 at 01:45:06PM -0400, Eduardo Habkost wrote: > > (CCing Eric Blake, who reviewed the original patch. Sorry for > > not CCing you previously, Eric) > > > > On Wed, Aug 19, 2020 at 08:12:22PM -0400, Eduardo H

[PATCH v4 09/10] iotests.py: add filter_img_check

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
Add analog of bash _filter_qemu_img_check to python framework. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi --- tests/qemu-iotests/iotests.py | 4 1 file changed, 4 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 3

[PATCH v4 10/10] iotests: add 298 to test new preallocate filter driver

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi --- tests/qemu-iotests/298 | 50 ++ tests/qemu-iotests/298.out | 6 + tests/qemu-iotests/group | 1 + 3 files changed, 57 insertions(+) create mode 100644 tests/qemu-iotests/

[PATCH v4 08/10] iotests.py: add verify_o_direct helper

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
Add python notrun-helper similar to _check_o_direct for bash tests. To be used in the following commit. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi --- tests/qemu-iotests/iotests.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/qemu-iotests/iotests

[PATCH v4 07/10] block: introduce preallocate filter

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
It's intended to be inserted between format and protocol nodes to preallocate additional space (expanding protocol file) on writes crossing EOF. It improves performance for file-systems with slow allocation. Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/system/qemu-block-drivers.rst.inc |

[PATCH v4 06/10] block: introduce BDRV_REQ_NO_WAIT flag

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
Add flag to make serialising request no wait: if there are conflicting requests, just return error immediately. It's will be used in upcoming preallocate filter. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block.h | 9 - block/io.c| 11 ++- 2 files

Re: [PATCH v2 44/58] qom: provide convenient macros for declaring and defining types

2020-08-20 Thread Laurent Vivier
Le 20/08/2020 à 19:45, Eduardo Habkost a écrit : > (CCing Eric Blake, who reviewed the original patch. Sorry for > not CCing you previously, Eric) > > On Wed, Aug 19, 2020 at 08:12:22PM -0400, Eduardo Habkost wrote: > [...] >> +/** >> + * OBJECT_DECLARE_TYPE: >> + * @ModuleObjName: the object nam

[PATCH v4 02/10] block/io.c: drop assertion on double waiting for request serialisation

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
The comments states, that on misaligned request we should have already been waiting. But for bdrv_padding_rmw_read, we called bdrv_mark_request_serialising with align = request_alignment, and now we serialise with align = cluster_size. So we may have to wait again with larger alignment. Note, that

[PATCH v4 05/10] block: bdrv_mark_request_serialising: split non-waiting function

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
We'll need a separate function, which will only "mark" request serialising with specified align but not wait for conflicting requests. So, it will be like old bdrv_mark_request_serialising(), before merging bdrv_wait_serialising_requests_locked() into it. To reduce the possible mess, let's do the

[PATCH v4 01/10] block: simplify comment to BDRV_REQ_SERIALISING

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
1. BDRV_REQ_NO_SERIALISING doesn't exist already, don't mention it. 2. We are going to add one more user of BDRV_REQ_SERIALISING, so comment about backup becomes a bit confusing here. The use case in backup is documented in block/backup.c, so let's just drop duplication here. 3. The fact

[PATCH v4 03/10] block/io: split out bdrv_find_conflicting_request

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
To be reused in separate. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi --- block/io.c | 71 +++--- 1 file changed, 41 insertions(+), 30 deletions(-) diff --git a/block/io.c b/block/io.c index b18680a842..5b96715058 100

[PATCH v4 04/10] block/io: bdrv_wait_serialising_requests_locked: drop extra bs arg

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
bs is linked in req, so no needs to pass it separately. Most of tracked-requests API doesn't have bs argument. Actually, after this patch only tracked_request_begin has it, but it's for purpose. While being here, also add a comment about what "_locked" is. Signed-off-by: Vladimir Sementsov-Ogievs

[PATCH v4 00/10] preallocate filter

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is a filter, which does preallocation on write. In Virtuozzo we have to deal with some custom distributed storage solution, where allocation is relatively expensive operation. We have to workaround it in Qemu, so here is a new filter. v4: 01-04: add r-bs 05: add coroutine_fn tag 06:

Re: [PATCH] configure: add support for psuedo-"in source tree" builds

2020-08-20 Thread Paolo Bonzini
On 20/08/20 19:42, Eric Blake wrote: >> >> This goes on top of Paolo's most recent meson port v175 posting, >> or whatever number it is upto now :-) > > Nice comment for reviewers, but doesn't quite need to be preserved in git. I for one don't mind. :) Paolo

Re: [PATCH] configure: add support for psuedo-"in source tree" builds

2020-08-20 Thread Peter Maydell
On Thu, 20 Aug 2020 at 17:56, Daniel P. Berrangé wrote: > > Meson requires the build dir to be separate from the source tree. Many > people are used to just running "./configure && make" though and the > meson conversion breaks that. > > This introduces some backcompat support to make it appear as

Re: [PATCH v2 0/3] hw/sd: Add Cadence SDHCI emulation

2020-08-20 Thread Philippe Mathieu-Daudé
Hi Sai Pavan, you said you were interested to test the first 2 patches. FYI I plan to queue them and send the pull request tomorrow or Saturday the latest. On 8/17/20 12:03 PM, Bin Meng wrote: > This series is spun off from the following series as it is hw/sd > centric, so that it can be picked up

Re: [PATCH v3 10/10] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function

2020-08-20 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 8/16/20 10:20 PM, Chuan Zheng wrote: > > Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be > > called > > > > Signed-off-by: Chuan Zheng > > --- > > > +++ b/qapi/migration.json > > @@ -1621,3 +1621,45 @@ > > ## > > { 'ev

Re: [PATCH v3 09/10] migration/dirtyrate: Implement calculate_dirtyrate() function

2020-08-20 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > Implement calculate_dirtyrate() function. > > Signed-off-by: Chuan Zheng > Signed-off-by: YanYing Zhuang > --- > migration/dirtyrate.c | 46 -- > 1 file changed, 44 insertions(+), 2 deletions(-) > > diff

Re: [PATCH v2 44/58] qom: provide convenient macros for declaring and defining types

2020-08-20 Thread Daniel P . Berrangé
On Thu, Aug 20, 2020 at 01:45:06PM -0400, Eduardo Habkost wrote: > (CCing Eric Blake, who reviewed the original patch. Sorry for > not CCing you previously, Eric) > > On Wed, Aug 19, 2020 at 08:12:22PM -0400, Eduardo Habkost wrote: > [...] > > +/** > > + * OBJECT_DECLARE_TYPE: > > + * @ModuleObjN

Re: [PATCH v3 05/10] migration/dirtyrate: Record hash results for each sampled page

2020-08-20 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Aug 20, 2020 at 06:30:09PM +0100, Dr. David Alan Gilbert wrote: > > * Chuan Zheng (zhengch...@huawei.com) wrote: > > > Record hash results for each sampled page. > > > > > > Signed-off-by: Chuan Zheng > > > Signed-off-by: YanYing Zhuang

Re: [PATCH] configure: add support for psuedo-"in source tree" builds

2020-08-20 Thread Philippe Mathieu-Daudé
On 8/20/20 7:42 PM, Eric Blake wrote: > On 8/20/20 11:55 AM, Daniel P. Berrangé wrote: >> Meson requires the build dir to be separate from the source tree. Many >> people are used to just running "./configure && make" though and the >> meson conversion breaks that. >> >> This introduces some backco

Re: [PATCH v3 08/10] migration/dirtyrate: Implement get_sample_page_period() and block_sample_page_period()

2020-08-20 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > Implement get_sample_page_period() and set_sample_page_period() to > sleep specific time between sample actions. > > Signed-off-by: Chuan Zheng > Signed-off-by: YanYing Zhuang > --- > migration/dirtyrate.c | 24 > migration

Re: [PATCH v2] configure: add support for pseudo-"in source tree" builds

2020-08-20 Thread Eric Blake
On 8/20/20 12:31 PM, Daniel P. Berrangé wrote: Meson requires the build dir to be separate from the source tree. Many people are used to just running "./configure && make" though and the meson conversion breaks that. This introduces some backcompat support to make it appear as if an "in source t

Re: [PATCH v3 05/10] migration/dirtyrate: Record hash results for each sampled page

2020-08-20 Thread Daniel P . Berrangé
On Thu, Aug 20, 2020 at 06:30:09PM +0100, Dr. David Alan Gilbert wrote: > * Chuan Zheng (zhengch...@huawei.com) wrote: > > Record hash results for each sampled page. > > > > Signed-off-by: Chuan Zheng > > Signed-off-by: YanYing Zhuang > > --- > > migration/dirtyrate.c | 144 > > +++

Re: [PATCH v2] configure: add support for pseudo-"in source tree" builds

2020-08-20 Thread Philippe Mathieu-Daudé
On 8/20/20 7:31 PM, Daniel P. Berrangé wrote: > Meson requires the build dir to be separate from the source tree. Many > people are used to just running "./configure && make" though and the > meson conversion breaks that. > > This introduces some backcompat support to make it appear as if an > "in

Re: [PATCH v7 13/13] tests/acceptance: console boot tests for quanta-gsj

2020-08-20 Thread Philippe Mathieu-Daudé
On 8/20/20 6:24 PM, Havard Skinnemoen wrote: > On Wed, Aug 19, 2020 at 10:29 PM Philippe Mathieu-Daudé > wrote: >> >> +Eric / Richard for compiler optimizations. >> >> On 8/20/20 3:53 AM, Havard Skinnemoen wrote: >>> On Tue, Aug 11, 2020 at 8:26 PM Havard Skinnemoen >>> wrote: On Tue,

Re: [PATCH v2 44/58] qom: provide convenient macros for declaring and defining types

2020-08-20 Thread Eduardo Habkost
(CCing Eric Blake, who reviewed the original patch. Sorry for not CCing you previously, Eric) On Wed, Aug 19, 2020 at 08:12:22PM -0400, Eduardo Habkost wrote: [...] > +/** > + * OBJECT_DECLARE_TYPE: > + * @ModuleObjName: the object name with initial capitalization > + * @module_obj_name: the obje

Re: [PATCH] configure: add support for psuedo-"in source tree" builds

2020-08-20 Thread Eric Blake
On 8/20/20 11:55 AM, Daniel P. Berrangé wrote: Meson requires the build dir to be separate from the source tree. Many people are used to just running "./configure && make" though and the meson conversion breaks that. This introduces some backcompat support to make it appear as if an "in source t

Re: [PATCH v3 07/10] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE

2020-08-20 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > In order to sample real RAM, skip ramblock with size below > > Signed-off-by: Chuan Zheng OK, Reviewed-by: Dr. David Alan Gilbert > --- > migration/dirtyrate.c | 24 > migration/dirtyrate.h | 5 + > 2 files changed

Re: deprecation of in-tree builds

2020-08-20 Thread Paolo Bonzini
On 20/08/20 18:14, Kevin Wolf wrote: > I just don't understand why 99.9% of it were okay to do, but the final > bit that would make the switch a lot more seamless to people is asking > too much. You're familiar with the state after your patches, I'm not. I > assume you're also the one who sends the

[PATCH 1/2] linux user: fixed proc myself execfd behaviour, added tests for proc myself fd

2020-08-20 Thread Andrew Aladjev
Signed-off-by: Andrew Aladjev --- linux-user/elfload.c | 3 +- linux-user/main.c| 11 - linux-user/syscall.c | 7 ++- tests/tcg/multiarch/linux-test.c | 85 4 files changed, 101 insertions(+), 5 deletions(-) diff --gi

[PATCH 2/2] linux user: refactored is proc functions for syscalls

2020-08-20 Thread Andrew Aladjev
Signed-off-by: Andrew Aladjev --- linux-user/syscall.c | 81 ++-- 1 file changed, 56 insertions(+), 25 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 3d8c57522d..7b4d7cc197 100644 --- a/linux-user/syscall.c +++ b/linux-user/sys

Re: [PATCH v3 06/10] migration/dirtyrate: Compare page hash results for recorded sampled page

2020-08-20 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > Compare page hash results for recorded sampled page. > > Signed-off-by: Chuan Zheng > Signed-off-by: YanYing Zhuang > --- > migration/dirtyrate.c | 76 > +++ > 1 file changed, 76 insertions(+) > > d

[PATCH v2] configure: add support for pseudo-"in source tree" builds

2020-08-20 Thread Daniel P . Berrangé
Meson requires the build dir to be separate from the source tree. Many people are used to just running "./configure && make" though and the meson conversion breaks that. This introduces some backcompat support to make it appear as if an "in source tree" build is being done, but with the the result

Re: [PATCH v3 05/10] migration/dirtyrate: Record hash results for each sampled page

2020-08-20 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > Record hash results for each sampled page. > > Signed-off-by: Chuan Zheng > Signed-off-by: YanYing Zhuang > --- > migration/dirtyrate.c | 144 > ++ > migration/dirtyrate.h | 7 +++ > 2 files change

Re: [PATCH] configure: add support for psuedo-"in source tree" builds

2020-08-20 Thread Philippe Mathieu-Daudé
Typo "pseudo" in subject. On 8/20/20 6:55 PM, Daniel P. Berrangé wrote: > Meson requires the build dir to be separate from the source tree. Many > people are used to just running "./configure && make" though and the > meson conversion breaks that. > > This introduces some backcompat support to ma

Re: [PATCH v3 10/10] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function

2020-08-20 Thread Eric Blake
On 8/16/20 10:20 PM, Chuan Zheng wrote: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be called Signed-off-by: Chuan Zheng --- +++ b/qapi/migration.json @@ -1621,3 +1621,45 @@ ## { 'event': 'UNPLUG_PRIMARY', 'data': { 'device-id': 'str' } } + +## +# @Dirty

Re: [PATCH] configure: add support for psuedo-"in source tree" builds

2020-08-20 Thread Peter Maydell
On Thu, 20 Aug 2020 at 17:56, Daniel P. Berrangé wrote: > > Meson requires the build dir to be separate from the source tree. Many > people are used to just running "./configure && make" though and the > meson conversion breaks that. > > This introduces some backcompat support to make it appear as

Re: [PATCH] configure: add support for psuedo-"in source tree" builds

2020-08-20 Thread Daniel P . Berrangé
On Thu, Aug 20, 2020 at 06:10:34PM +0100, Peter Maydell wrote: > On Thu, 20 Aug 2020 at 17:56, Daniel P. Berrangé wrote: > > Meson requires the build dir to be separate from the source tree. Many > > people are used to just running "./configure && make" though and the > > meson conversion breaks t

Re: [PATCH v2] ppc/pnv: Add a HIOMAP erase command

2020-08-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200820164638.2515681-1-...@kaod.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/b

[PATCH] util/vfio-helpers: Unify trace-events size format

2020-08-20 Thread Philippe Mathieu-Daudé
Some 'qemu_vfio_*' trace events sizes are displayed using decimal notation, other using hexadecimal notation: qemu_vfio_ram_block_added s 0xf2448d90 host 0x5bc0 size 0x400 qemu_vfio_dma_map s 0xf2448d90 host 0x5bc0 size 67108864 temporary 0 iova (nil) qemu_vfio_f

Re: [PATCH] configure: add support for psuedo-"in source tree" builds

2020-08-20 Thread Peter Maydell
On Thu, 20 Aug 2020 at 17:56, Daniel P. Berrangé wrote: > Meson requires the build dir to be separate from the source tree. Many > people are used to just running "./configure && make" though and the > meson conversion breaks that. > > This introduces some backcompat support to make it appear as i

[PATCH v5 15/15] block/nvme: Use an array of EventNotifier

2020-08-20 Thread Philippe Mathieu-Daudé
In preparation of using multiple IRQ (thus multiple eventfds) make BDRVNVMeState::irq_notifier an array (for now of a single element, the admin queue notifier). Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 31 +-- 1 file chang

[PATCH v5 12/15] block/nvme: Replace BDRV_POLL_WHILE by AIO_WAIT_WHILE

2020-08-20 Thread Philippe Mathieu-Daudé
BDRV_POLL_WHILE() is defined as: #define BDRV_POLL_WHILE(bs, cond) ({ \ BlockDriverState *bs_ = (bs); \ AIO_WAIT_WHILE(bdrv_get_aio_context(bs_), \ cond); }) As we will remove the BlockDriverState use in the next commit, start by using the e

[PATCH v5 14/15] block/nvme: Extract nvme_poll_queue()

2020-08-20 Thread Philippe Mathieu-Daudé
As we want to do per-queue polling, extract the nvme_poll_queue() method which operates on a single queue. Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 44 +++- 1 file changed, 27 insertions(+), 17 deletions(-) di

[PATCH v5 13/15] block/nvme: Simplify nvme_create_queue_pair() arguments

2020-08-20 Thread Philippe Mathieu-Daudé
nvme_create_queue_pair() doesn't require BlockDriverState anymore. Replace it by BDRVNVMeState and AioContext to simplify. Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/block/

[PATCH v5 09/15] block/nvme: Replace qemu_try_blockalign0 by qemu_try_blockalign/memset

2020-08-20 Thread Philippe Mathieu-Daudé
In the next commit we'll get rid of qemu_try_blockalign(). To ease review, first replace qemu_try_blockalign0() by explicit calls to qemu_try_blockalign() and memset(). Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 16 +--- 1 file changed, 9 i

[PATCH v5 10/15] block/nvme: Replace qemu_try_blockalign(bs) by qemu_try_memalign(pg_sz)

2020-08-20 Thread Philippe Mathieu-Daudé
qemu_try_blockalign() is a generic API that call back to the block driver to return its page alignment. As we call from within the very same driver, we already know to page alignment stored in our state. Remove indirections and use the value from BDRVNVMeState. This change is required to later remo

[PATCH v5 11/15] block/nvme: Simplify nvme_init_queue() arguments

2020-08-20 Thread Philippe Mathieu-Daudé
nvme_init_queue() doesn't require BlockDriverState anymore. Replace it by BDRVNVMeState to simplify. Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/block/nvme.c b/block/nvme.c index f

[PATCH v5 07/15] block/nvme: Rename local variable

2020-08-20 Thread Philippe Mathieu-Daudé
We are going to modify the code in the next commit. Renaming the 'resp' variable to 'id' first makes the next commit easier to review. No logical changes. Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 19 +-- 1 file changed, 9 insertions(+

[PATCH v5 06/15] block/nvme: Use common error path in nvme_add_io_queue()

2020-08-20 Thread Philippe Mathieu-Daudé
Rearrange nvme_add_io_queue() by using a common error path. This will be proven useful in few commits where we add IRQ notification to the IO queues. Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-

[PATCH v5 08/15] block/nvme: Use union of NvmeIdCtrl / NvmeIdNs structures

2020-08-20 Thread Philippe Mathieu-Daudé
We allocate an unique chunk of memory then use it for two different structures. By using an union, we make it clear the data is overlapping (and we can remove the casts). Suggested-by: Stefan Hajnoczi Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 31

[PATCH v5 04/15] block/nvme: Define INDEX macros to ease code review

2020-08-20 Thread Philippe Mathieu-Daudé
Use definitions instead of '0' or '1' indexes. Also this will be useful when using multi-queues later. Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/bloc

  1   2   3   >