[PATCH] hw/hyperv: Fix 32-bit build error for vmbus.

2020-09-05 Thread Richard Henderson
../qemu/hw/hyperv/vmbus.c: In function ‘gpadl_iter_io’: ../qemu/hw/hyperv/vmbus.c:383:13: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] 383 | p = (void *)(((uintptr_t)iter->map & TARGET_PAGE_MASK) | off_in_page); | ^ cc1: all

Re: [PATCH 2/3] pci: Let pci_dma_read() propagate MemTxResult

2020-09-05 Thread Richard Henderson
On 9/4/20 9:26 AM, Philippe Mathieu-Daudé wrote: > pci_dma_rw() returns a MemTxResult type. > Do not discard it, return it to the caller. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/pci/pci.h | 16 ++-- > 1 file changed, 14 insertions(+), 2 deletions(-)

Re: [PATCH 3/3] pci: Let pci_dma_write() propagate MemTxResult

2020-09-05 Thread Richard Henderson
On 9/4/20 9:26 AM, Philippe Mathieu-Daudé wrote: > pci_dma_rw() returns a MemTxResult type. > Do not discard it, return it to the caller. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/pci/pci.h | 16 ++-- > 1 file changed, 14 insertions(+), 2 deletions(-)

Re: [PATCH 1/3] pci: Let pci_dma_rw() propagate MemTxResult

2020-09-05 Thread Richard Henderson
On 9/4/20 9:26 AM, Philippe Mathieu-Daudé wrote: > dma_memory_rw() returns a MemTxResult type. > Do not discard it, return it to the caller. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/pci/pci.h | 18 -- > 1 file changed, 16 insertions(+), 2 deletions(-)

Re: [PATCH 13/13] dma: Let dma_memory_map() take MemTxAttrs argument

2020-09-05 Thread Richard Henderson
On 9/4/20 8:44 AM, Philippe Mathieu-Daudé wrote: > Let devices specify transaction attributes when calling > dma_memory_map(). > > Patch created mechanically using spatch with this script: > > @@ > expression E1, E2, E3, E4; > @@ > - dma_memory_map(E1, E2, E3, E4) > +

Re: [PATCH 12/13] dma: Let dma_memory_read/write() take MemTxAttrs argument

2020-09-05 Thread Richard Henderson
On 9/4/20 8:44 AM, Philippe Mathieu-Daudé wrote: > Let devices specify transaction attributes when calling > dma_memory_read() or dma_memory_write(). > > Patch created mechanically using spatch with this script: > > @@ > expression E1, E2, E3, E4; > @@ > ( > - dma_memory_read(E1, E2,

Re: [PATCH 10/13] dma: Let dma_memory_rw_relaxed() take MemTxAttrs argument

2020-09-05 Thread Richard Henderson
On 9/4/20 8:44 AM, Philippe Mathieu-Daudé wrote: > We will add the MemTxAttrs argument to dma_memory_rw() in > the next commit. Since dma_memory_rw_relaxed() is only used > by dma_memory_rw(), modify it first in a separate commit to > keep the next commit easier to review. > > Signed-off-by:

Re: [PATCH 11/13] dma: Let dma_memory_rw() take MemTxAttrs argument

2020-09-05 Thread Richard Henderson
On 9/4/20 8:44 AM, Philippe Mathieu-Daudé wrote: > Let devices specify transaction attributes when calling > dma_memory_rw(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/pci/pci.h | 3 ++- > include/sysemu/dma.h | 11 ++- > dma-helpers.c| 3 ++- >

Re: [PATCH 09/13] dma: Let dma_memory_set() take MemTxAttrs argument

2020-09-05 Thread Richard Henderson
On 9/4/20 8:44 AM, Philippe Mathieu-Daudé wrote: > Let devices specify transaction attributes when calling > dma_memory_set(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/ppc/spapr_vio.h | 3 ++- > include/sysemu/dma.h | 3 ++- > dma-helpers.c | 5 ++--- >

Re: [PATCH 08/13] dma: Let dma_memory_valid() take MemTxAttrs argument

2020-09-05 Thread Richard Henderson
On 9/4/20 8:44 AM, Philippe Mathieu-Daudé wrote: > Let devices specify transaction attributes when calling > dma_memory_valid(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/ppc/spapr_vio.h | 2 +- > include/sysemu/dma.h | 4 ++-- > 2 files changed, 3 insertions(+), 3

Re: [PATCH 07/13] dma: Let dma_memory_write() propagate MemTxResult

2020-09-05 Thread Richard Henderson
On 9/4/20 8:44 AM, Philippe Mathieu-Daudé wrote: > dma_memory_rw_relaxed() returns a MemTxResult type. > Do not discard it, return it to the caller. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/dma.h | 22 ++ > 1 file changed, 18 insertions(+), 4

Re: [PATCH 06/13] dma: Let dma_memory_read() propagate MemTxResult

2020-09-05 Thread Richard Henderson
On 9/4/20 8:44 AM, Philippe Mathieu-Daudé wrote: > dma_memory_rw_relaxed() returns a MemTxResult type. > Do not discard it, return it to the caller. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/dma.h | 21 + > 1 file changed, 17 insertions(+), 4

Re: [PATCH 05/13] dma: Let dma_memory_rw() propagate MemTxResult

2020-09-05 Thread Richard Henderson
On 9/4/20 8:44 AM, Philippe Mathieu-Daudé wrote: > address_space_rw() returns a MemTxResult type. > Do not discard it, return it to the caller. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/dma.h | 30 ++ > 1 file changed, 22 insertions(+), 8

Re: [PATCH 04/13] dma: Let dma_memory_set() propagate MemTxResult

2020-09-05 Thread Richard Henderson
On 9/4/20 8:44 AM, Philippe Mathieu-Daudé wrote: > address_space_write() returns a MemTxResult type. > Do not discard it, return it to the caller. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/dma.h | 15 ++- > dma-helpers.c| 7 --- > 2 files changed,

Re: [PATCH 03/13] dma: Document address_space_map/address_space_unmap() prototypes

2020-09-05 Thread Richard Henderson
On 9/4/20 8:44 AM, Philippe Mathieu-Daudé wrote: > Add documentation based on address_space_map / address_space_unmap. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/dma.h | 30 +- > 1 file changed, 29 insertions(+), 1 deletion(-) Reviewed-by:

Re: [PATCH 02/13] docs/devel/loads-stores: Add regexp for DMA functions

2020-09-05 Thread Richard Henderson
On 9/4/20 8:44 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > docs/devel/loads-stores.rst | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH 01/13] pci: pass along the return value of dma_memory_rw

2020-09-05 Thread Richard Henderson
On 9/4/20 8:44 AM, Philippe Mathieu-Daudé wrote: > From: Klaus Jensen > > Some might actually care about the return value of dma_memory_rw. So > let us pass it along instead of ignoring it. > > There are no existing users of the return value, so this patch should be > safe. > > Signed-off-by:

Re: [PATCH] configure: Fixes ncursesw detection under msys2/mingw and enable curses

2020-09-05 Thread Richard Henderson
On 9/5/20 1:42 PM, Yonggang Luo wrote: > +nativecharset_to_ucs2 = iconv_open("UCS-2", g_get_codeset()); g_get_codeset(): "a newly allocated string containing the name of the character set. This string must be freed with g_free()." You need to plug the memory leak. It's probably worth fixing

Re: [PATCH] tests: Fixes building test-util-filemonitor.c on msys2/mingw

2020-09-05 Thread Richard Henderson
On 9/5/20 1:34 PM, Yonggang Luo wrote: > Fixes the following compiling error: > ../tests/test-util-filemonitor.c: In function 'test_file_monitor_events': > ../tests/test-util-filemonitor.c:620:17: error: too many arguments to > function 'mkdir' > 620 | if (mkdir(pathsrc, 0700) < 0)

Re: [RFC PATCH] docs/system/deprecated: mark ppc64abi32-linux-user for deprecation

2020-09-05 Thread Richard Henderson
On 9/4/20 10:21 AM, Peter Maydell wrote: > On Fri, 4 Sep 2020 at 17:52, Alex Bennée wrote: >> >> It's buggy and we are not sure anyone uses it. > >> +``ppc64abi32`` CPUs (since 5.2.0) >> +' >> + >> +The ``ppc64abi32`` architecture has a number of issues which

Re: [PATCH v3 00/16] hw/riscv: Add Microchip PolarFire SoC Icicle Kit board support

2020-09-05 Thread Leif Lindholm
On Tue, Sep 01, 2020 at 09:38:55 +0800, Bin Meng wrote: > From: Bin Meng > > This adds support for Microchip PolarFire SoC Icicle Kit board. > The Icicle Kit board integrates a PolarFire SoC, with one SiFive's > E51 plus four U54 cores and many on-chip peripherals and an FPGA. > > For more

[REPORT] Nightly Performance Tests - Saturday, September 5, 2020

2020-09-05 Thread Ahmed Karaman
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz Host Memory : 15.49 GB Start Time (UTC) : 2020-09-05 22:30:02 End Time (UTC) : 2020-09-05 23:02:41 Execution Time : 0:32:38.859046 Status : SUCCESS Note: Changes denoted by '-' are less than 0.01%.

Re: [PATCH 1/2] tests: Trying fixes test-replication.c on msys2/mingw.

2020-09-05 Thread Stefan Weil
Am 05.09.20 um 23:10 schrieb Yonggang Luo: > On Windows there is no path like /tmp/s_local_disk.XX > > Signed-off-by: Yonggang Luo > --- > tests/test-replication.c | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/tests/test-replication.c

Re: [PATCH v3 18/19] target/microblaze: Put MicroBlazeCPUConfig into DisasContext

2020-09-05 Thread Philippe Mathieu-Daudé
On 9/4/20 9:08 PM, Richard Henderson wrote: > The bulk of the translator should not have access to the > complete cpu state, to avoid the temptation to examine bits > that are in run time, but not translation time context. > > We do need access to the constant cpu configuration, and > that is

Re: [PATCH v3 16/19] target/microblaze: Move mmu parameters to MicroBlazeCPUConfig

2020-09-05 Thread Philippe Mathieu-Daudé
On 9/4/20 9:08 PM, Richard Henderson wrote: > The final 4 fields in MicroBlazeMMU are configuration constants. > Move them into MicroBlazeCPUConfig where they belong. > > Remove the leading "c_" from the member names, as that presumably > implied "config", and that should not be explicit in the

Re: [PATCH v3 14/19] target/microblaze: Move pvr regs to MicroBlazeCPUConfig

2020-09-05 Thread Philippe Mathieu-Daudé
On 9/4/20 9:08 PM, Richard Henderson wrote: > These values are constant, and are derived from the other > configuration knobs. Move them into MicroBlazeCPUConfig > to emphasize that they are not variable. > > Signed-off-by: Richard Henderson > --- > target/microblaze/cpu.h | 5 +-

Re: [PATCH v3 12/19] target/microblaze: Split out MicroBlazeCPUConfig

2020-09-05 Thread Philippe Mathieu-Daudé
On 9/4/20 9:08 PM, Richard Henderson wrote: > This struct was previously unnamed, and defined in MicroBlazeCPU. > Pull it out to its own typedef so that we can reuse it. > > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/microblaze/cpu.h | 55

Re: [PATCH v3 13/19] target/microblaze: Reorg MicroBlazeCPUConfig to minimize holes

2020-09-05 Thread Philippe Mathieu-Daudé
On 9/4/20 9:08 PM, Richard Henderson wrote: > Sort the elements by type and size, removing a number of holes > and reducing the size of the entire struct. > > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/microblaze/cpu.h | 15 ++- > 1 file

Re: [PATCH] tests: fixes test-vmstate.c compile error on msys2

2020-09-05 Thread Philippe Mathieu-Daudé
On 9/5/20 8:38 AM, Yonggang Luo wrote: > ../tests/test-vmstate.c: In function 'int_cmp': > ../tests/test-vmstate.c:884:5: error: unknown type name 'uint'; did you mean > 'uInt'? > 884 | uint ua = GPOINTER_TO_UINT(a); > | ^~~~ > | uInt > ../tests/test-vmstate.c:885:5:

[PATCH] hw/mips/malta: Fix FPGA I/O region size

2020-09-05 Thread Philippe Mathieu-Daudé
The FPGA present on the CoreCard has an I/O region 1MiB wide. Refs: - Atlas User’s Manual (Document Number: MD5) - Malta User’s Manual (Document Number: MD00048) Fixes: ea85df72b60 ("mips_malta: convert to memory API") Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/malta.c | 2 +- 1

[PATCH] meson: Fixes qapi tests.

2020-09-05 Thread Yonggang Luo
Use -b to ignore-space-change The error are: +@end table + +@end deftypefn + make: *** [Makefile.mtest:63: check-qapi-schema] Error 1 Signed-off-by: Yonggang Luo --- tests/qapi-schema/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qapi-schema/meson.build

[PATCH] hw/arm/aspeed: Map the UART5 device unconditionally

2020-09-05 Thread Philippe Mathieu-Daudé
The UART5 is present on the machine regardless there is a character device connected to it. Map it unconditionally. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/aspeed_ast2600.c | 8 +++- hw/arm/aspeed_soc.c | 8 +++- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git

[PATCH 2/2] block: get file-win32.c handle locking option consistence with file-posix.c

2020-09-05 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- block/file-win32.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/block/file-win32.c b/block/file-win32.c index ab69bd811a..14e5f5c3b5 100644 --- a/block/file-win32.c +++ b/block/file-win32.c @@ -299,6 +299,11 @@

[PATCH 1/2] tests: Trying fixes test-replication.c on msys2/mingw.

2020-09-05 Thread Yonggang Luo
On Windows there is no path like /tmp/s_local_disk.XX Signed-off-by: Yonggang Luo --- tests/test-replication.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/tests/test-replication.c b/tests/test-replication.c index 9ab3666a90..3cf544a133 100644 ---

[PATCH 0/2] Try fixes test-replication.c running on msys2/mingw

2020-09-05 Thread Yonggang Luo
Still failing 1..13 ok 1 /replication/primary/read ok 2 /replication/primary/write ok 3 /replication/primary/start ok 4 /replication/primary/stop ok 5 /replication/primary/do_checkpoint ok 6 /replication/primary/get_error_all ok 7 /replication/secondary/read ok 8 /replication/secondary/write

Re: [PATCH] linux-user: Protect btrfs ioctl target definitions

2020-09-05 Thread Laurent Vivier
Le 05/09/2020 à 18:38, Filip Bozuta a écrit : > Target definitions of btrfs ioctls in 'syscall_defs.h' use > the value BTRFS_IOCTL_MAGIC that is defined header 'btrfs.h'. > This header is not available in kernel versions before 3.9. > For that reason, these target ioctl definitions should be >

Re: [PATCH] linux-user: Protect btrfs ioctl target definitions

2020-09-05 Thread Laurent Vivier
Le 05/09/2020 à 18:38, Filip Bozuta a écrit : > Target definitions of btrfs ioctls in 'syscall_defs.h' use > the value BTRFS_IOCTL_MAGIC that is defined header 'btrfs.h'. > This header is not available in kernel versions before 3.9. > For that reason, these target ioctl definitions should be >

Re: [PATCH] linux-user: fix ppc/termbits.h

2020-09-05 Thread Laurent Vivier
Le 30/08/2020 à 20:16, Laurent Vivier a écrit : > On ppc, in termios, c_line is after c_cc, not before . > > Fixes: c218b4ede4f9 ("linux-user: Add missing termbits types and values > definitions") > Cc: filip.boz...@syrmia.com > Signed-off-by: Laurent Vivier > --- > linux-user/ppc/termbits.h |

Re: [PATCH] linux-user: Map signal numbers in fcntl

2020-09-05 Thread Laurent Vivier
Le 29/07/2020 à 22:06, Timothy Baldwin a écrit : > Map signal numbers in fcntl F_SETSIG and F_GETSIG. > > Signed-off-by: Timothy E Baldwin > --- >  linux-user/syscall.c | 10 -- >  1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/linux-user/syscall.c

Re: [PATCH] linux-user: Map signal numbers in fcntl

2020-09-05 Thread Laurent Vivier
Le 29/07/2020 à 22:06, Timothy Baldwin a écrit : > Map signal numbers in fcntl F_SETSIG and F_GETSIG. > > Signed-off-by: Timothy E Baldwin > --- >  linux-user/syscall.c | 10 -- >  1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/linux-user/syscall.c

[Bug 1894361] Re: linux-user: syscall.c lacks pselect6_time64

2020-09-05 Thread Laurent Vivier
Fix available in my branch: https://github.com/vivier/qemu/commits/linux-user-for-5.2 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1894361 Title: linux-user: syscall.c lacks pselect6_time64

Re: [PATCH] linux-user: Correctly start brk after executable

2020-09-05 Thread Laurent Vivier
Le 29/07/2020 à 00:46, Timothy E Baldwin a écrit : > info->brk was erroneously set to the end of highest addressed > writable segment which could result it in overlapping the executable. > > As per load_elf_binary in fs/binfmt_elf.c in Linux, it should be > set to end of highest addressed

[PATCH] configure: Fixes ncursesw detection under msys2/mingw and enable curses

2020-09-05 Thread Yonggang Luo
The mingw pkg-config are showing following absolute path and contains : as the separator, so we must handling : properly. -D_XOPEN_SOURCE=600 -D_POSIX_C_SOURCE=199506L -IC:/CI-Tools/msys64/mingw64/include/ncursesw:-I/usr/include/ncursesw: -DNCURSES_WIDECHAR -D_XOPEN_SOURCE=600

Re: [PATCH v2 1/2] linux-user: Add support for ppoll_time64() and pselect6_time64()

2020-09-05 Thread Laurent Vivier
Le 25/08/2020 à 17:23, Laurent Vivier a écrit : > Le 25/08/2020 à 09:17, Laurent Vivier a écrit : >> Le 25/08/2020 à 00:30, Filip Bozuta a écrit : >>> This patch introduces functionality for following time64 syscalls: >>> >>> *ppoll_time64 >>> >>> This is a year 2038 safe variant of: >>> >>>

[PATCH] tests: Fixes building test-util-filemonitor.c on msys2/mingw

2020-09-05 Thread Yonggang Luo
Fixes the following compiling error: ../tests/test-util-filemonitor.c: In function 'test_file_monitor_events': ../tests/test-util-filemonitor.c:620:17: error: too many arguments to function 'mkdir' 620 | if (mkdir(pathsrc, 0700) < 0) { | ^ In file included

[PATCH] linux-user: Protect btrfs ioctl target definitions

2020-09-05 Thread Filip Bozuta
Target definitions of btrfs ioctls in 'syscall_defs.h' use the value BTRFS_IOCTL_MAGIC that is defined header 'btrfs.h'. This header is not available in kernel versions before 3.9. For that reason, these target ioctl definitions should be enwrapped in an #ifdef directive to check whether the

Re: [PATCH] tests: fixes test-vmstate.c compile error on msys2

2020-09-05 Thread Thomas Huth
On 05/09/2020 18.16, 罗勇刚(Yonggang Luo) wrote: > > > On Sat, Sep 5, 2020 at 4:48 PM Thomas Huth > wrote: > > On 05/09/2020 08.38, Yonggang Luo wrote: > > ../tests/test-vmstate.c: In function 'int_cmp': > > ../tests/test-vmstate.c:884:5: error: unknown type

[Bug 1715203] Re: Maintain Haiku support

2020-09-05 Thread Thomas Huth
** Changed in: qemu Status: Incomplete => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1715203 Title: Maintain Haiku support Status in QEMU: Confirmed Bug description: It

Re: [PATCH] tests: fixes test-vmstate.c compile error on msys2

2020-09-05 Thread Yonggang Luo
On Sat, Sep 5, 2020 at 4:48 PM Thomas Huth wrote: > On 05/09/2020 08.38, Yonggang Luo wrote: > > ../tests/test-vmstate.c: In function 'int_cmp': > > ../tests/test-vmstate.c:884:5: error: unknown type name 'uint'; did you > mean 'uInt'? > > 884 | uint ua = GPOINTER_TO_UINT(a); > > |

QEMU | Pipeline #186145679 has failed for master | 8ca019b9

2020-09-05 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 8ca019b9 ( https://gitlab.com/qemu-project/qemu/-/commit/8ca019b9c9ff916414371dd13d265bbab308b14a ) Commit Message: Merge

[Bug 1715203] Re: Maintain Haiku support

2020-09-05 Thread kallisti5
and away we go.. ./haiku.x86_64 --image /tmp/haiku.img --build-qemu /home/kallisti5/Code/qemu Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc' Submodule 'slirp' (https://git.qemu.org/git/libslirp.git) registered for path 'slirp' Submodule 'meson'

[Bug 1715203] Re: Maintain Haiku support

2020-09-05 Thread kallisti5
$ ./haiku.x86_64 --verbose --image /tmp/haiku.img uname Haiku ./haiku.x86_64 --verbose --image /tmp/haiku.img "gcc -v" Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/boot/system/develop/tools/bin/../lib/gcc/x86_64-unknown-haiku/8.3.0/lto-wrapper Target: x86_64-unknown-haiku Configured

[Bug 1715203] Re: Maintain Haiku support

2020-09-05 Thread kallisti5
ok.. a Haiku vm for QEMU is WIP here: https://github.com/kallisti5/qemu/tree/haiku-test-vm ``` $ ./haiku.x86_64 --build-image --image /tmp/haiku.img ### Downloading disk image ... ### Preparing disk image ... ./box.img 100% repochecksum-1 [65 bytes] Validating checksum for Haiku...done. 100%

tests/test-char.exe are blocked by char_stdio_test_subprocess are blocked

2020-09-05 Thread Yonggang Luo
and the process won't finishe -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PULL 00/27] QOM boilerplate cleanup

2020-09-05 Thread Peter Maydell
On Thu, 3 Sep 2020 at 21:52, Eduardo Habkost wrote: > > The following changes since commit 67a7bfe560a1bba59efab085cb3430f45176d382: > > Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-09= > -03' into staging (2020-09-03 16:58:25 +0100) > > are available in the Git

Re: [PATCH v5 03/11] ci: fixes msys2 build by upgrading capstone to 4.0.2

2020-09-05 Thread Peter Maydell
On Sat, 5 Sep 2020 at 14:23, 罗勇刚(Yonggang Luo) wrote: > Who is responsible for capstone? Richard Henderson generally looks after it. (We don't have an entry for it in MAINTAINERS, which is an oversight.) -- PMM

Re: [PULL 0/8] QAPI patches patches for 2020-09-03

2020-09-05 Thread Peter Maydell
On Thu, 3 Sep 2020 at 09:23, Markus Armbruster wrote: > > The following changes since commit ed215cec0fcaeaece064b0fdf37fe3bceb06d76c: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2020-09-02 > 15:26:38 +0100) > > are available in the Git

Re: [PATCH v5 04/11] meson: upgrade meson for execute custom ninjatool under msys2 properly

2020-09-05 Thread Yonggang Luo
On Sat, Sep 5, 2020 at 9:44 PM Paolo Bonzini wrote: > On 05/09/20 08:23, Yonggang Luo wrote: > > The ninja options now have no need anymore. > > > > Signed-off-by: Yonggang Luo > > --- > > meson | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meson b/meson > >

Re: [PATCH v5 04/11] meson: upgrade meson for execute custom ninjatool under msys2 properly

2020-09-05 Thread Paolo Bonzini
On 05/09/20 08:23, Yonggang Luo wrote: > The ninja options now have no need anymore. > > Signed-off-by: Yonggang Luo > --- > meson | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson b/meson > index 68ed748f84..492afe50a4 16 > --- a/meson > +++ b/meson > @@ -1 +1

Re: [PATCH v5 03/11] ci: fixes msys2 build by upgrading capstone to 4.0.2

2020-09-05 Thread Yonggang Luo
On Sat, Sep 5, 2020 at 7:14 PM Mark Cave-Ayland < mark.cave-ayl...@ilande.co.uk> wrote: > On 05/09/2020 07:23, Yonggang Luo wrote: > > > Signed-off-by: Yonggang Luo > > --- > > capstone | 2 +- > > configure | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git

[Bug 1708442] Re: Crash(assert) during reading image from http url through qemu-nbd

2020-09-05 Thread Thomas Huth
Looking through old bug tickets... is this still an issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Bug 1708617] Re: qemu2.9 meet a question using reconnect about ovs+dpdk

2020-09-05 Thread Thomas Huth
ooking through old bug tickets... is this still an issue with the latest version of QEMU? Or could we close this ticket nowadays? And what is a "question ping between 2 vm error" ? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a

Re: [PATCH v1 0/3] unit tests for change 'do not add hotplug related amls for cold plugged bridges'

2020-09-05 Thread Ani Sinha
On Sat, Sep 5, 2020 at 4:05 PM Ani Sinha wrote: > > The following patchset adds the unit test for the change: > f80ba9e599 ("tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' > bridge flag") Apologies. This change is incorrect. It should be : e78c1c9a2e ("i440fx/acpi: do not add

[Bug 1715162] Re: qemu-user crashing when writing core dump

2020-09-05 Thread Thomas Huth
Looking through old bug tickets... is this still an issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Bug 1712818] Re: live migration with storage encounter assert(!(bs->open_flags & BDRV_O_INACTIVE)) crashes

2020-09-05 Thread Thomas Huth
Looking through old bug tickets... is this still an issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [RFC PATCH] travis.yml: Drop the default softmmu builds

2020-09-05 Thread Thomas Huth
On 05/08/2020 20.54, Thomas Huth wrote: > The total runtime of all Travis jobs is very long and we are testing > all softmmu targets in the gitlab-CI already - so we can speed up the > Travis testing a little bit by not testing the softmmu targets here > anymore. > > Signed-off-by: Thomas Huth >

Re: [PATCH 2/2] travis.yml: Drop the Python 3.5 and 3.6 builds

2020-09-05 Thread Thomas Huth
On 23/08/2020 08.54, Thomas Huth wrote: > On 05/08/2020 20.49, Thomas Huth wrote: >> Python 3.5 is already the default in Ubuntu Xenial (which we use for >> most jobs on Travis), and Python 3.6 is the default on Ubuntu Bionic >> (which we use for the s390x jobs on Travis for example already), so

[Bug 1715203] Re: Maintain Haiku support

2020-09-05 Thread kallisti5
Hi! Sorry, I forgot about this one. Haiku has a lot of options.. we can setup a vm image if needed to move this along. Haiku is graphical, but has ssh and all the standard tools. Vagrant also supports Haiku and provides some automation around it.

[PATCH] iotests: Skip test_stream_parallel in test 030 when doing "make check"

2020-09-05 Thread Thomas Huth
The test_stream_parallel test still occasionally fails in the CI. Thus let's disable it during "make check" for now so that it does not cause trouble during merge tests. We can enable it again once the problem has been resolved. Signed-off-by: Thomas Huth --- See e.g. these URLs for the

[Bug 1894071] Re: qemu-i386-static ioctl return -14 (Bad Address)

2020-09-05 Thread Thomas Huth
** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1894071 Title: qemu-i386-static ioctl return -14 (Bad Address) Status in QEMU: Invalid Bug

Re: [PATCH v5 03/11] ci: fixes msys2 build by upgrading capstone to 4.0.2

2020-09-05 Thread Mark Cave-Ayland
On 05/09/2020 07:23, Yonggang Luo wrote: > Signed-off-by: Yonggang Luo > --- > capstone | 2 +- > configure | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/capstone b/capstone > index 22ead3e0bf..1d23053284 16 > --- a/capstone > +++ b/capstone > @@ -1 +1 @@ >

[Bug 1894361] Re: linux-user: syscall.c lacks pselect6_time64

2020-09-05 Thread Laurent Vivier
pselect6_time64() has been implemented but it has not been merged because during the test I've seen it breaks ARM target. https://patchew.org/QEMU/20200824223050.92032-1-filip.boz...@syrmia.com/20200824223050.92032-2-filip.boz...@syrmia.com/ I try to fix that and merge that soon. -- You

[PATCH v1 2/3] tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag

2020-09-05 Thread Ani Sinha
This change adds a new unit test for the global flag 'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci bridges in i440fx. The flag can be used to turn off acpi based hotplug support for all the slots of the pci bus. Tested on the upstream qemu master branch on top of

[PATCH v1 1/3] tests/acpi: list added acpi table binary file for pci bridge hotplug test

2020-09-05 Thread Ani Sinha
The file 'tests/data/acpi/pc/DSDT.hpbridge' is a newly added acpi table file for testing the pci bridge option 'acpi-pci-hotplug-with-bridge-support' under i440fx. This change documents this fact. Signed-off-by: Ani Sinha --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + 1 file changed, 1

[PATCH v1 0/3] unit tests for change 'do not add hotplug related amls for cold plugged bridges'

2020-09-05 Thread Ani Sinha
The following patchset adds the unit test for the change: f80ba9e599 ("tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag") Please compare the diff of the DSDT table attached with the commit log with the following diff which was generated before appplying the above

[PATCH v1 3/3] tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug flag

2020-09-05 Thread Ani Sinha
This patch adds a binary blob corresponding to the DSDT acpi table. It is used to unit test the flag 'acpi-pci-hotplug-with-bridge-support' used with pci bridges. This change also clears the file tests/qtest/bios-tables-test-allowed-diff.h so that future changes which affect the table can be

[Bug 1715715] Re: [qemu-ppc] Segfault when booting from HD after MacOS9 install

2020-09-05 Thread Thomas Huth
Looking through old bug tickets ... can you still reproduce the segfault with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Bug 1717414] Re: Sending certain keysyms results in wrong symbol input

2020-09-05 Thread Thomas Huth
There have been quite a bunch of improvements in the keysyms handling during the past years ... can you still reproduce your issue with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu-

[Bug 1715573] Re: Android-x86_64 guest - "Could not disable RealTimeClock events (20160831/evxfevnt-267)"; UI sluggish, ACPI doesn't work with QEMU 2.10.0

2020-09-05 Thread Thomas Huth
** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1715573 Title: Android-x86_64 guest - "Could not disable RealTimeClock events

[Bug 1715203] Re: Maintain Haiku support

2020-09-05 Thread Thomas Huth
Is there any update on this? Could you provide a machine with ssh login to the QEMU project where QEMU could be built and tested on Haiku? Or can Haiku be installed automatically without graphical UI interactions? In that case, would it be feasible that you provide a VM setup for our tests/vm/

[Bug 1785203] Re: accel/tcg/translate-all.c:2511: page_check_range: Assertion `start < ((target_ulong)1 << L1_MAP_ADDR_SPACE_BITS)' failed.

2020-09-05 Thread Serge Belyshev
Fixed by 0acd4ab849827bbc20402e01c9da088207c0d236 ("linux-user: check valid address in access_ok()"), fix released in v5.0.0. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH v5 01/11] Revert "configure: add --ninja option"

2020-09-05 Thread Paolo Bonzini
Il sab 5 set 2020, 10:29 Thomas Huth ha scritto: > On 05/09/2020 08.23, Yonggang Luo wrote: > > This reverts commit 48328880fddf0145bdccc499160fb24dfabfbd41. > > > > Signed-off-by: Yonggang Luo > > --- > > configure | 16 +--- > > 1 file changed, 1 insertion(+), 15 deletions(-) > >

Re: [PATCH] tests: fixes test-vmstate.c compile error on msys2

2020-09-05 Thread Thomas Huth
On 05/09/2020 08.38, Yonggang Luo wrote: > ../tests/test-vmstate.c: In function 'int_cmp': > ../tests/test-vmstate.c:884:5: error: unknown type name 'uint'; did you mean > 'uInt'? > 884 | uint ua = GPOINTER_TO_UINT(a); > | ^~~~ > | uInt > ../tests/test-vmstate.c:885:5:

Re: [PATCH v5 01/11] Revert "configure: add --ninja option"

2020-09-05 Thread Mark Cave-Ayland
On 05/09/2020 09:29, Thomas Huth wrote: > On 05/09/2020 08.23, Yonggang Luo wrote: >> This reverts commit 48328880fddf0145bdccc499160fb24dfabfbd41. >> >> Signed-off-by: Yonggang Luo >> --- >> configure | 16 +--- >> 1 file changed, 1 insertion(+), 15 deletions(-) > > Please be a

Re: [PATCH v5 09/11] meson: Fixes qapi tests.

2020-09-05 Thread Thomas Huth
On 05/09/2020 08.23, Yonggang Luo wrote: > The error are: > +@end table > + > +@end deftypefn > + > make: *** [Makefile.mtest:63: check-qapi-schema] Error 1 > > Signed-off-by: Yonggang Luo > --- > tests/qapi-schema/meson.build | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff

Re: [PATCH v5 08/11] osdep: These function are only available on Non-Win32 system.

2020-09-05 Thread Thomas Huth
On 05/09/2020 08.23, Yonggang Luo wrote: > int qemu_lock_fd(int fd, int64_t start, int64_t len, bool exclusive); > int qemu_unlock_fd(int fd, int64_t start, int64_t len); > int qemu_lock_fd_test(int fd, int64_t start, int64_t len, bool exclusive); > bool qemu_has_ofd_lock(void); > >

Re: [PATCH v5 01/11] Revert "configure: add --ninja option"

2020-09-05 Thread Thomas Huth
On 05/09/2020 08.23, Yonggang Luo wrote: > This reverts commit 48328880fddf0145bdccc499160fb24dfabfbd41. > > Signed-off-by: Yonggang Luo > --- > configure | 16 +--- > 1 file changed, 1 insertion(+), 15 deletions(-) Please be a little bit more descriptive in the patch description:

Re: [RFC PATCH] docs/system/deprecated: mark ppc64abi32-linux-user for deprecation

2020-09-05 Thread David Gibson
On Fri, Sep 04, 2020 at 05:51:40PM +0100, Alex Bennée wrote: > It's buggy and we are not sure anyone uses it. > > Cc: David Gibson > Cc: Richard Henderson > Signed-off-by: Alex Bennée Acked-by: David Gibson > --- > docs/system/deprecated.rst | 9 + > 1 file changed, 9 insertions(+)

[Bug 1894361] [NEW] linux-user: syscall.c lacks pselect6_time64

2020-09-05 Thread Serge Belyshev
Public bug reported: in commit 50efc69586388a975c1ebd90cb8cc8e4a7328bc4 ("linux-user/riscv: Update the syscall_nr's to the 5.5 kernel") legacy pselect6 definition for riscv32 was removed in favour of pselect6_time64, but pselect6_time64 is not available in syscall.c, thus leaving riscv32 without

Re: [PATCH] stubs: Move qemu_timer_notify_cb() and remove qemu_notify_event() stub

2020-09-05 Thread Thomas Huth
On 05/09/2020 08.05, 罗勇刚(Yonggang Luo) wrote: > > > On Wed, Sep 2, 2020 at 6:33 PM Paolo Bonzini > wrote: > > On 02/09/20 12:24, Thomas Huth wrote: > > When cross-compiling with MinGW, there are sometimes some weird linker > > errors like: > > >

Re: [PATCH v2] tests: Trying fixes test-replication.c on msys2.

2020-09-05 Thread Thomas Huth
On 05/09/2020 05.11, 罗勇刚(Yonggang Luo) wrote: > > > On Fri, Sep 4, 2020 at 9:07 PM Thomas Huth > wrote: > > On 04/09/2020 00.06, Yonggang Luo wrote: > > Signed-off-by: Yonggang Luo > > > --- > > 

[PATCH] tests: fixes test-vmstate.c compile error on msys2

2020-09-05 Thread Yonggang Luo
../tests/test-vmstate.c: In function 'int_cmp': ../tests/test-vmstate.c:884:5: error: unknown type name 'uint'; did you mean 'uInt'? 884 | uint ua = GPOINTER_TO_UINT(a); | ^~~~ | uInt ../tests/test-vmstate.c:885:5: error: unknown type name 'uint'; did you mean 'uInt'?

[PATCH v5 09/11] meson: Fixes qapi tests.

2020-09-05 Thread Yonggang Luo
The error are: +@end table + +@end deftypefn + make: *** [Makefile.mtest:63: check-qapi-schema] Error 1 Signed-off-by: Yonggang Luo --- tests/qapi-schema/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qapi-schema/meson.build

[PATCH v5 07/11] block: get file-win32.c handle locking option consistence with file-posix.c

2020-09-05 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- block/file-win32.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/block/file-win32.c b/block/file-win32.c index ab69bd811a..14e5f5c3b5 100644 --- a/block/file-win32.c +++ b/block/file-win32.c @@ -299,6 +299,11 @@

[PATCH v5 11/11] ci: Enable Github actions.

2020-09-05 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- .github/workflows/main.yml| 31 +++ scripts/ci/windows/msys2-download.bat | 4 2 files changed, 35 insertions(+) create mode 100644 .github/workflows/main.yml create mode 100644 scripts/ci/windows/msys2-download.bat

[PATCH v5 10/11] docker: Add win32/msys2/mingw64 docker

2020-09-05 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- tests/docker/dockerfiles/msys2.docker | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 tests/docker/dockerfiles/msys2.docker diff --git a/tests/docker/dockerfiles/msys2.docker b/tests/docker/dockerfiles/msys2.docker new file mode 100644

[PATCH v5 05/11] ci: Enable msys2 ci in cirrus

2020-09-05 Thread Yonggang Luo
Install msys2 in a proper way refer to https://github.com/cirruslabs/cirrus-ci-docs/issues/699 The https://wiki.qemu.org/Hosts/W32#Native_builds_with_MSYS2 need to be updated. There is no need of --cross-prefix, open mingw64.exe instead of msys2.exe then we don't need the --cross-prefix, besides

[PATCH v5 08/11] osdep: These function are only available on Non-Win32 system.

2020-09-05 Thread Yonggang Luo
int qemu_lock_fd(int fd, int64_t start, int64_t len, bool exclusive); int qemu_unlock_fd(int fd, int64_t start, int64_t len); int qemu_lock_fd_test(int fd, int64_t start, int64_t len, bool exclusive); bool qemu_has_ofd_lock(void); Signed-off-by: Yonggang Luo --- include/qemu/osdep.h | 2 +- 1

[PATCH v5 02/11] block: Fixes nfs on msys2/mingw

2020-09-05 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- block/nfs.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index 61a249a9fc..34b2cd5708 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -24,7 +24,9 @@ #include "qemu/osdep.h" +#if

[PATCH v5 06/11] tests: Trying fixes test-replication.c on msys2.

2020-09-05 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- tests/test-replication.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/tests/test-replication.c b/tests/test-replication.c index 9ab3666a90..d0e06f8d77 100644 --- a/tests/test-replication.c +++ b/tests/test-replication.c @@

  1   2   >