Chuan Zheng 于2020年9月15日周二 上午10:34写道：
>
> add DirtyRateStatus to denote calculating status.
>
> Signed-off-by: Chuan Zheng
> Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Li Qiang
> ---
> migration/dirtyrate.c | 26 ++
> qapi/migration.json | 17 +
Chuan Zheng 于2020年9月15日周二 上午10:34写道：
>
> Add get_dirtyrate_thread() functions to setup query-dirtyrate
> framework.
>
> Signed-off-by: Chuan Zheng
> Signed-off-by: YanYing Zhuang
> Reviewed-by: Dr. David Alan Gilbert
> Reviewed-by: David Edmondson
Reviewed-by: Li Qiang
> ---
>
On Tue, Sep 15, 2020 at 10:27 PM Richard Henderson <
richard.hender...@linaro.org> wrote:
> On 9/14/20 11:27 PM, Paolo Bonzini wrote:
> > Looks good. Can you just add a "# Submodules" heading above the test?
> >
> > I would also like to remove the "yes" value (that is, the default fails
> if the
are available in the Git repository at:
>
> git://git.kraxel.org/qemu tags/vga-20200915-pull-request
>
> for you to fetch changes up to 7b0de5b7969e695d6235525654a8a28a0d82a0e0:
>
> virtio-gpu: build modular (2020-09-15 14:11:49 +0200)
>
> ---
Le 15/09/2020 à 15:43, Alex Bennée a écrit :
> On older kernels which don't implement MAP_FIXED_NOREPLACE the kernel
> may still fail to give us the address we asked for despite having
> already probed the map for a valid hole. Asserting isn't particularly
> useful to the user so let us move the
When acpi hotplug is turned off for both root pci bus as well as for pci
bridges, we should not generate the related amls for DSDT table or initialize
related hw ports or reserve hw resources. This change makes sure all those
operations are turned off in the case acpi pci hotplug is off globally.
When ACPI hotplug for the root bus is disabled, the bsel property for that
bus is not set. Please see the following commit:
3d7e78aaf ("Introduce a new flag for i440fx to disable PCI hotplug on the
root bus").
As a result, when acpi_pcihp_find_hotplug_bus() is called
with bsel set to 0, it
The file 'tests/data/acpi/pc/DSDT.hpbridge' is a newly added acpi table file for
testing the pci bridge option 'acpi-pci-hotplug-with-bridge-support' under
i440fx.
This change documents this fact.
Signed-off-by: Ani Sinha
---
tests/qtest/bios-tables-test-allowed-diff.h | 1 +
1 file changed, 1
This patch adds a binary blob corresponding to the DSDT acpi table. It is used
to unit test the flag 'acpi-pci-hotplug-with-bridge-support' used with pci
bridges.
This change also clears the file tests/qtest/bios-tables-test-allowed-diff.h
so that future changes which affect the table can be
A new binary ACPI table tests/data/acpi/pc/DSDT.roothp is added in order
to unit test hotplug on/off capability on the root pci bus for i440fx.
The diff between the table DSDT.bridge and DSDT.roothp is listed below:
@@ -1,30 +1,30 @@
/*
* Intel ACPI Component Architecture
* AML/ASL+
A new binary acpi table tests/data/acpi/pc/DSDT.roothp is added in order to
unit test
the feature flag that can disable/enable root pci bus hotplug on i440fx. This
feature was
added with the commit:
3d7e78aaf0 ("Introduce a new flag for i440fx to disable PCI hotplug on the
root bus")
This
Cold plugged bridges are not hot unpluggable, even when their hotplug
property (acpi-pci-hotplug-with-bridge-support) is turned off. Please see
the function acpi_pcihp_pc_no_hotplug() (thanks Julia). However, with
the current implementaton, windows would try to hot-unplug a pci bridge when
it's
This change adds a new unit test for the global flag
'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci
bridges in i440fx. The flag can be used to turn off acpi based hotplug support
for all pci bridges.
Signed-off-by: Ani Sinha
---
tests/qtest/bios-tables-test.c |
Ability to turn hotplug off on the pci root bus for i440fx was added in commit:
3d7e78aaf0 ("Introduce a new flag for i440fx to disable PCI hotplug on the
root bus")
This change adds a unit test in order to test this feature.
This change has been tested against upstream qemu master branch
In v3, I fixed another bug with patch #9. Now, with hotplug disabled on both
root bus and pci bridges, we get a clean DSDT table as can be seen here:
https://pastebin.ubuntu.com/p/JSZhfyBFD7/
The AML corresponding to the root bus is:
Scope (\_SB)
{
Scope (PCI0)
{
On 9/15/20 5:07 PM, Stefan Hajnoczi wrote:
> The sentence explaining the deprecation schedule is ambiguous. Make it
> clear that a feature deprecated in the Nth release is guaranteed to
> remain available in the N+1th release. Removal can occur in the N+2nd
> release or later.
>
> As an example
On Mon, Jun 15, 2020 at 02:39:02AM +0800, Coiby Xu wrote:
> v9
> - move logical block size check function to a utility function
> - fix issues regarding license, coding style, memory deallocation, etc.
Hi,
Any update on v10?
Please let me know if there's anything I can do to help.
Stefan
On Tue, Sep 15, 2020 at 04:07:34PM +0100, Stefan Hajnoczi wrote:
> The sentence explaining the deprecation schedule is ambiguous. Make it
> clear that a feature deprecated in the Nth release is guaranteed to
> remain available in the N+1th release. Removal can occur in the N+2nd
> release or
QEMU now hosts a mirror of meson.git. QEMU mirrors third-party code to
ensure that users can always build QEMU even if the dependency goes
offline and so QEMU meets its responsibilities to provide full source
code under software licenses.
Suggested-by: Peter Maydell
Cc: Marc-André Lureau
Cc:
On Wed, Sep 09, 2020 at 05:11:48PM +0200, Kevin Wolf wrote:
> Add a function to move the current coroutine to the AioContext of a
> given BlockDriverState.
>
> Signed-off-by: Kevin Wolf
> ---
> include/block/block.h | 6 ++
> block.c | 10 ++
> 2 files changed, 16
On Wed, Sep 09, 2020 at 05:11:47PM +0200, Kevin Wolf wrote:
> Add a function that can be used to move the currently running coroutine
> to a different AioContext (and therefore potentially a different
> thread).
>
> Signed-off-by: Kevin Wolf
> ---
> include/block/aio.h | 10 ++
>
On Mon, Sep 14, 2020 at 03:21:46PM +0100, Daniel P. Berrangé wrote:
> On Tue, Aug 11, 2020 at 11:47:36AM +0100, Stefan Hajnoczi wrote:
> > The sentence explaining the deprecation schedule is ambiguous. Make it
> > clear that a feature deprecated in the Nth release is guaranteed to
> > remain
The sentence explaining the deprecation schedule is ambiguous. Make it
clear that a feature deprecated in the Nth release is guaranteed to
remain available in the N+1th release. Removal can occur in the N+2nd
release or later.
As an example of this in action, see commit
On Mon, Sep 14, 2020 at 05:09:49PM +0200, Markus Armbruster wrote:
> Stefan Hajnoczi writes:
>
> > On Wed, Sep 09, 2020 at 05:11:36PM +0200, Kevin Wolf wrote:
> >> Some QMP command handlers can block the main loop for a relatively long
> >> time, for example because they perform some I/O. This
On Wed, Sep 09, 2020 at 05:11:49PM +0200, Kevin Wolf wrote:
> @@ -2456,8 +2456,7 @@ void qmp_block_resize(bool has_device, const char
> *device,
> return;
> }
>
> -aio_context = bdrv_get_aio_context(bs);
> -aio_context_acquire(aio_context);
> +old_ctx =
On 9/11/20 11:08 AM, Thomas Huth wrote:
> On 10/09/2020 11.36, Collin Walling wrote:
>> DIAGNOSE 0x318 (diag318) is an s390 instruction that allows the storage
>> of diagnostic information that is collected by the firmware in the case
>> of hardware/firmware service events.
>>
>> QEMU handles the
On Tue, 15 Sep 2020 10:16:23 -0400
Matthew Rosato wrote:
> On 9/15/20 7:28 AM, Cornelia Huck wrote:
> > On Mon, 14 Sep 2020 18:29:29 -0400
> > Matthew Rosato wrote:
> >
> >> When an s390 guest is using lazy unmapping, it can result in a very
> >> large number of oustanding DMA requests, far
On Tue, Sep 15, 2020 at 7:33 PM Ani Sinha wrote:
>
> On Tue, Sep 15, 2020 at 7:12 PM Igor Mammedov wrote:
> >
> > On Tue, 15 Sep 2020 18:25:55 +0530
> > Ani Sinha wrote:
> >
> > > On Tue, Sep 15, 2020 at 6:19 PM Igor Mammedov wrote:
> > > >
> > > > On Tue, 15 Sep 2020 17:40:25 +0530
> > > >
I don't understand the purpose of function 7 on these cards, the class
code indicates an Ethernet device, but without any BARs, I very much
doubt that the functions provide any useful service. Config space is
invalid for the function as QEMU identifies, the referenced BAR resource
for the MSI-X
When acpi hotplug is turned off for both root pci bus as well as for pci
bridges, we should not generate the related amls for DSDT table or initialize
related hw ports or reserve hw resources. This change makes sure all those
operations are turned off in the case acpi pci hotplug is off globally.
This patch adds a binary blob corresponding to the DSDT acpi table. It is used
to unit test the flag 'acpi-pci-hotplug-with-bridge-support' used with pci
bridges.
This change also clears the file tests/qtest/bios-tables-test-allowed-diff.h
so that future changes which affect the table can be
This change adds a new unit test for the global flag
'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci
bridges in i440fx. The flag can be used to turn off acpi based hotplug support
for all pci bridges.
Signed-off-by: Ani Sinha
---
tests/qtest/bios-tables-test.c |
When ACPI hotplug for the root bus is disabled, the bsel property for that
bus is not set. Please see the following commit:
3d7e78aaf ("Introduce a new flag for i440fx to disable PCI hotplug on the
root bus").
As a result, when acpi_pcihp_find_hotplug_bus() is called
with bsel set to 0, it
The file 'tests/data/acpi/pc/DSDT.hpbridge' is a newly added acpi table file for
testing the pci bridge option 'acpi-pci-hotplug-with-bridge-support' under
i440fx.
This change documents this fact.
Signed-off-by: Ani Sinha
---
tests/qtest/bios-tables-test-allowed-diff.h | 1 +
1 file changed, 1
Cold plugged bridges are not hot unpluggable, even when their hotplug
property (acpi-pci-hotplug-with-bridge-support) is turned off. Please see
the function acpi_pcihp_pc_no_hotplug() (thanks Julia). However, with
the current implementaton, windows would try to hot-unplug a pci bridge when
it's
Ability to turn hotplug off on the pci root bus for i440fx was added in commit:
3d7e78aaf0 ("Introduce a new flag for i440fx to disable PCI hotplug on the
root bus")
This change adds a unit test in order to test this feature.
This change has been tested against upstream qemu master branch
A new binary acpi table tests/data/acpi/pc/DSDT.roothp is added in order to
unit test
the feature flag that can disable/enable root pci bus hotplug on i440fx. This
feature was
added with the commit:
3d7e78aaf0 ("Introduce a new flag for i440fx to disable PCI hotplug on the
root bus")
This
A new binary ACPI table tests/data/acpi/pc/DSDT.roothp is added in order
to unit test hotplug on/off capability on the root pci bus for i440fx.
The diff between the table DSDT.bridge and DSDT.roothp is listed below:
@@ -1,30 +1,30 @@
/*
* Intel ACPI Component Architecture
* AML/ASL+
Updated patch #7 and patch #9.
Update to patch #7 is cosmetic, only commit message update.
Update to patch #9 fixes a bug and also updates the ACPI DSDT gold master
blobs for q35 so that unit tests pass.
Ani Sinha (9):
tests/acpi: document addition of table DSDT.roothp for unit testing
root
On Tue, 15 Sep 2020 09:57:03 -0400
Matthew Rosato wrote:
> On 9/15/20 6:33 AM, Cornelia Huck wrote:
> > On Mon, 14 Sep 2020 18:29:28 -0400
> > Matthew Rosato wrote:
> >
> >> The underlying host may be limiting the number of outstanding DMA
> >> requests for type 1 IOMMU. Add helper
This patch introduces the vfio-user protocol specification (formerly
known as VFIO-over-socket), which is designed to allow devices to be
emulated outside QEMU, in a separate process. vfio-user reuses the
existing VFIO defines, structs and concepts.
It has been earlier discussed as an RFC in:
On 9/14/20 11:27 PM, Paolo Bonzini wrote:
> Looks good. Can you just add a "# Submodules" heading above the test?
>
> I would also like to remove the "yes" value (that is, the default fails if the
> internal copy is not there) but it can be done later for all submodules.
Unless you simply plan
On 9/12/20 2:28 AM, Thomas Huth wrote:
> On 11/09/2020 20.16, Collin Walling wrote:
>> On 9/10/20 1:56 PM, Collin Walling wrote:
>>> On 9/10/20 1:50 PM, Thomas Huth wrote:
On 10/09/2020 11.36, Collin Walling wrote:
> The header contained within the SCCB passed to the SCLP service call
On 9/15/20 8:54 AM, Thomas Huth wrote:
On 15/09/2020 00.29, Matthew Rosato wrote:
When an s390 guest is using lazy unmapping, it can result in a very
large number of oustanding DMA requests, far beyond the default
limit configured for vfio. Let's track DMA usage similar to vfio
in the host,
On 9/15/20 7:28 AM, Cornelia Huck wrote:
On Mon, 14 Sep 2020 18:29:29 -0400
Matthew Rosato wrote:
When an s390 guest is using lazy unmapping, it can result in a very
large number of oustanding DMA requests, far beyond the default
limit configured for vfio. Let's track DMA usage similar to
On 9/15/20 6:33 AM, Cornelia Huck wrote:
On Mon, 14 Sep 2020 18:29:28 -0400
Matthew Rosato wrote:
The underlying host may be limiting the number of outstanding DMA
requests for type 1 IOMMU. Add helper functions to check for the
DMA available capability and retrieve the current number of DMA
On Tue, Sep 15, 2020 at 10:56:06AM +0800, Robert Hoo wrote:
> On Mon, 2020-09-14 at 13:38 +, Eduardo Habkost wrote:
> > On Mon, Sep 14, 2020 at 06:50:09PM +0800, Robert Hoo wrote:
[...]
> > > 2) Each x86 cpudef CPU model has 1 unversioned cpu_model_type then
> > > its
> > > versioned
Hi
On Tue, Sep 15, 2020 at 3:49 PM Thomas Huth wrote:
> When compiling QEMU with MSYS2 on Windows, there is currently the
> following error:
>
> ../qga/commands-win32.c:62:24: error: redundant redeclaration of
> 'CM_Get_DevNode_PropertyW' [-Werror=redundant-decls]
>62 | CMAPI CONFIGRET
On Tue, Sep 15, 2020 at 7:12 PM Igor Mammedov wrote:
>
> On Tue, 15 Sep 2020 18:25:55 +0530
> Ani Sinha wrote:
>
> > On Tue, Sep 15, 2020 at 6:19 PM Igor Mammedov wrote:
> > >
> > > On Tue, 15 Sep 2020 17:40:25 +0530
> > > Ani Sinha wrote:
> > >
> > > > On Tue, Sep 15, 2020 at 5:21 PM Igor
15.09.2020 16:43, Alex Bennée wrote:
> This is the common point at which we validate targets so it makes
> sense to add_to deprecated_features here. It will make future target
> deprecation easier as we only need to tweak one list.
>
> Signed-off-by: Alex Bennée
> ---
> configure | 14
Hi
On Tue, Sep 15, 2020 at 4:57 PM Philippe Mathieu-Daudé
wrote:
> Cc'ing Marc-André
>
> On 9/15/20 1:47 PM, Thomas Huth wrote:
> > When compiling QEMU with MSYS2 on Windows, there is currently the
> > following error:
> >
> > ../qga/commands-win32.c:62:24: error: redundant redeclaration of
> >
Hi Paolo,
I noticed that 'make check-qtest-aarch64' no longer runs the
arm-cpu-feature test. I simply did
diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index 874b5be62be2..db169a53b530 100644
--- a/tests/qtest/meson.build
+++ b/tests/qtest/meson.build
@@ -146,7 +146,8 @@
On Tue, 15 Sep 2020 15:08:05 +0200
Philippe Mathieu-Daudé wrote:
> On 9/14/20 2:35 PM, Greg Kurz wrote:
> > As recommended in "qapi/error.h", return true on success and false on
> > failure. This allows to reduce error propagation overhead in the callers.
> >
> > Signed-off-by: Greg Kurz
> >
On Tue, 15 Sep 2020 14:04:23 +0200
Greg Kurz wrote:
>
> I don't expect much people except David or maybe Markus to look
> at these patches actually. And anyway, it's up to David to merge
My bad, I didn't think about Philippe... :P
Thanks for the review, Philippe !
Cheers,
--
Greg
> them.
P J P 于2020年8月27日周四 下午7:52写道：
>
> From: Prasad J Pandit
>
> While mapping IRQ level in pci_change_irq_level() routine,
> it does not check if pci_get_bus() returned a valid pointer.
> It may lead to a NULL pointer dereference issue. Add check to
> avoid it.
>
> ->
From: Max Reitz
On macOS, (out of the box) readlink does not have -f. We do not really
need readlink here, though, it was just a replacement for realpath
(which is not available on our BSD test systems), which we needed to
make the $(dirname) into an absolute path.
Instead of using either,
While we are at it move the few places where they are into the
deprecation build bucket.
Signed-off-by: Alex Bennée
---
configure | 2 +-
.gitlab-ci.yml | 9 +
.shippable.yml | 2 +-
3 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/configure b/configure
index
On 9/15/20 2:16 AM, Philippe Mathieu-Daudé wrote:
On 9/15/20 12:29 AM, Matthew Rosato wrote:
Rather than duplicating the same loop in multiple locations,
create a static function to do the work.
Why not do that first in your series?
Fair question. I did originally do this collapsing
On older kernels which don't implement MAP_FIXED_NOREPLACE the kernel
may still fail to give us the address we asked for despite having
already probed the map for a valid hole. Asserting isn't particularly
useful to the user so let us move the check up and expand the
error_report a little to give
These targets might be deprecated but we should keep them building
before the final axe comes down. Lets keep them all in one place and
don't hold up the CI if they do fail. They are either poorly tested or
already flaky anyway.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Hi,
This series contains the previously posted linux-user fix for dealing
with weird mmap semantics as well as some tweaks to configure. Since
last version I've included Max's latest iotest update as well as
re-factored the configure logic. I've also added a patch for to
deprecate lm32 and
The target is already marked as deprecated in the documentation.
Signed-off-by: Alex Bennée
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 58be974065c8..dfd7f18dcb24 100755
--- a/configure
+++ b/configure
@@ -280,7 +280,7 @@
Rather than sed and loop just do a grep.
Signed-off-by: Alex Bennée
---
configure | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/configure b/configure
index f5fe48d6dd7b..58be974065c8 100755
--- a/configure
+++ b/configure
@@ -1739,17 +1739,9 @@ if test -z
This is the common point at which we validate targets so it makes
sense to add_to deprecated_features here. It will make future target
deprecation easier as we only need to tweak one list.
Signed-off-by: Alex Bennée
---
configure | 14 ++
1 file changed, 10 insertions(+), 4
On Tue, 15 Sep 2020 18:25:55 +0530
Ani Sinha wrote:
> On Tue, Sep 15, 2020 at 6:19 PM Igor Mammedov wrote:
> >
> > On Tue, 15 Sep 2020 17:40:25 +0530
> > Ani Sinha wrote:
> >
> > > On Tue, Sep 15, 2020 at 5:21 PM Igor Mammedov
> > > wrote:
> > > >
> > > > On Mon, 14 Sep 2020 20:20:21
Now the user has to make an even more deliberate decision to
enable a deprecated target rather than getting it as a side effect of
using --target-exclude-list.
Signed-off-by: Alex Bennée
---
configure | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/configure
ping!!
Li Qiang 于2020年9月7日周一 上午9:39写道：
>
> Ping!
>
> Li Qiang 于2020年9月1日周二 下午6:34写道：
> >
> > Ping.
> >
> > Li Qiang 于2020年8月15日周六 下午3:21写道：
> > >
> > > In 'map_page' we need to check the return value of
> > > 'dma_memory_map' to ensure the we actully maped something.
> > > Otherwise, we will
On 9/15/20 2:14 AM, Philippe Mathieu-Daudé wrote:
Hi Matthew,
On 9/15/20 12:29 AM, Matthew Rosato wrote:
The underlying host may be limiting the number of outstanding DMA
requests for type 1 IOMMU. Add helper functions to check for the
DMA available capability and retrieve the current number
On Tue, Sep 15, 2020 at 6:25 PM Ani Sinha wrote:
>
> On Tue, Sep 15, 2020 at 6:19 PM Igor Mammedov wrote:
> >
> > On Tue, 15 Sep 2020 17:40:25 +0530
> > Ani Sinha wrote:
> >
> > > On Tue, Sep 15, 2020 at 5:21 PM Igor Mammedov wrote:
> > > >
> > > > On Mon, 14 Sep 2020 20:20:21 +0530
> > > >
+-- On Tue, 11 Aug 2020, P J P wrote --+
| * This series asserts that MemoryRegionOps objects define read/write
| callback methods. Thus avoids potential NULL pointer dereference.
| ex. ->
https://git.qemu.org/?p=qemu.git;a=commit;h=bb15013ef34617eb1344f5276292cadd326c21b2
|
| * Also adds
On Tue, Sep 15, 2020 at 9:00 PM Daniel P. Berrangé
wrote:
>
> On Tue, Sep 15, 2020 at 08:12:56PM +0800, Yonggang Luo wrote:
> > First, this reduce the size of configure, configure are tending to
removal in future,
> > and this didn't introduce any new feature or remove any exist feature.
> >
From: Daniel P. Berrangé
Back in 2018 we introduced support for killing the whole QEMU process
instead of just one thread, when a seccomp rule is violated:
commit bda08a5764d470f101fa38635d30b41179a313e1
Author: Marc-André Lureau
Date: Wed Aug 22 19:02:48 2018 +0200
seccomp:
On 9/14/20 2:35 PM, Greg Kurz wrote:
> As recommended in "qapi/error.h", add a bool return value to
> spapr_realize_vcpu() and use it in spapr_cpu_core_realize()
> in order to get rid of the error propagation overhead.
>
> Signed-off-by: Greg Kurz
> ---
> hw/ppc/spapr_cpu_core.c | 16
On Thu, Sep 10, 2020 at 12:01:02PM +0530, Sai Pavan Boddu wrote:
> This patch series attempts to make 'hcd-xhci' an independent model so
> it can be used by both pci and system-bus interface.
Fails to apply again.
I guess this time the typedef / qom changes (I've just rebased my
microvm series
v2:
* Rebase now that vbootrom is in .gitmodules [Peter]
This patch series adds qemu.org mirrors for qboot, meson, and vbootrom.
vbootrom is not yet used by qemu.git/master so you may wish to hold off on
applying the final patch.
Stefan Hajnoczi (3):
gitmodules: switch to qemu.org qboot
-20200915
for you to fetch changes up to e474e3aacf4276eb0781d11c45e2fab996f9dc56:
seccomp: fix killing of whole process instead of thread (2020-09-15 12:56:26
+0200)
pull-seccomp-20200915
On 9/14/20 2:35 PM, Greg Kurz wrote:
> As recommended in "qapi/error.h", return true on success and false on
> failure. This allows to reduce error propagation overhead in the callers.
>
> Signed-off-by: Greg Kurz
> ---
> include/hw/ppc/spapr.h | 2 +-
> hw/ppc/spapr.c | 5 +++--
>
On Tue, Sep 15, 2020 at 03:00:00PM +0200, Stefano Garzarella wrote:
> Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally
> on") added a check that returns an error if legacy support is on, but the
> device is not legacy.
>
> Unfortunately some devices were wrongly declared
Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally
on") added a check that returns an error if legacy support is on, but the
device is not legacy.
Unfortunately some devices were wrongly declared legacy even if they
were not (e.g vhost-vsock).
To avoid migration issues,
Reference it via ops pointer instead, simliar to the vga one.
Removes hard symbol reference, needed to build virtio-gpu modular.
Signed-off-by: Gerd Hoffmann
Message-id: 20200914134224.29769-6-kra...@redhat.com
---
include/hw/virtio/virtio-gpu.h | 3 +--
hw/display/virtio-gpu-base.c | 3 ++-
On 9/14/20 2:34 PM, Greg Kurz wrote:
> Now that ppc_set_compat() indicates success/failure with a return
> value, use it and reduce error propagation overhead.
>
> Signed-off-by: Greg Kurz
> ---
> hw/ppc/spapr.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by:
Only build virtio-gpu-device modular (the code which actually depends on
the external virglrenderer library). virtio-gpu-pci and virtio-vga are
compiled into core qemu still.
Signed-off-by: Gerd Hoffmann
Message-id: 20200914134224.29769-7-kra...@redhat.com
---
util/module.c | 2 ++
The following changes since commit 2d2c73d0e3d504a61f868e46e6abd5643f38091b:
Merge remote-tracking branch
'remotes/pmaydell/tags/pull-target-arm-20200914-1' into staging (2020-09-14
16:03:08 +0100)
are available in the Git repository at:
git://git.kraxel.org/qemu tags/vga-20200915-pull
On Tue, Sep 15, 2020 at 08:13:11PM +0800, Yonggang Luo wrote:
> This is the error on msys2/mingw
> Running test test-io-channel-file
> **
> ERROR:../tests/test-io-channel-file.c:59:test_io_channel_file_helper:
> assertion failed (TEST_MASK & ~mask == st.st_mode & 0777): (384 == 438)
> ERROR
On 9/14/20 2:34 PM, Greg Kurz wrote:
> VMState handlers are supposed to return negative errno values on failure.
>
> Signed-off-by: Greg Kurz
> ---
> target/ppc/machine.c | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
On Tue, Sep 15, 2020 at 08:13:04PM +0800, Yonggang Luo wrote:
> Fixes following tests on msys2/mingw
> 'test-crypto-tlscredsx509'
> test-crypto-tlssession'
> 'test-io-channel-tls'
>
> These tests are failure with:
> ERROR test-crypto-tlscredsx509 - missing test plan
> ERROR test-crypto-tlssession
We should add sources to the softmmu_ss or module_ss but not both.
Signed-off-by: Gerd Hoffmann
Message-id: 20200914134224.29769-4-kra...@redhat.com
---
hw/display/meson.build | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/display/meson.build b/hw/display/meson.build
index
On 11/09/2020 - 15:18:32, Daniel P. Berrange wrote:
> Back in 2018 we introduced support for killing the whole QEMU process
> instead of just one thread, when a seccomp rule is violated:
>
> commit bda08a5764d470f101fa38635d30b41179a313e1
> Author: Marc-André Lureau
> Date: Wed Aug 22
On 9/14/20 2:35 PM, Greg Kurz wrote:
> As recommended in "qapi/error.h", return true on success and false on
> failure. This allows to reduce error propagation overhead in the callers.
>
> Signed-off-by: Greg Kurz
> ---
> include/hw/ppc/spapr_nvdimm.h | 2 +-
> hw/ppc/spapr.c|
QEMU now hosts a mirror of qboot.git. QEMU mirrors third-party code to
ensure that users can always build QEMU even if the dependency goes
offline and so QEMU meets its responsibilities to provide full source
code under software licenses.
Suggested-by: Peter Maydell
Cc: Paolo Bonzini
On Tue, Sep 15, 2020 at 08:12:56PM +0800, Yonggang Luo wrote:
> First, this reduce the size of configure, configure are tending to removal in
> future,
> and this didn't introduce any new feature or remove any exist feature.
> Second, the current localtime_r detection are conflict with ncursesw
On 9/14/20 2:35 PM, Greg Kurz wrote:
> As recommended in "qapi/error.h", return true on success and false on
> failure. This allows to reduce error propagation overhead in the callers.
>
> Signed-off-by: Greg Kurz
> ---
> include/hw/ppc/spapr.h | 2 +-
> hw/ppc/spapr.c | 4 +---
>
On 9/14/20 2:34 PM, Greg Kurz wrote:
> Use the return value of ppc_set_compat_all() to check failures,
> which is preferred over hijacking local_err.
>
> Signed-off-by: Greg Kurz
> ---
> hw/ppc/spapr_hcall.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Philippe
Use all config symbols not only the host ones.
Needed to make sure device configs like CONFIG_QXL
are used for modules too.
Suggested-by: Paolo Bonzini
Signed-off-by: Gerd Hoffmann
Message-id: 20200914134224.29769-3-kra...@redhat.com
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1
On 9/14/20 5:07 PM, Alex Bennée wrote:
> The target is already marked as deprecated in the documentation.
>
> Signed-off-by: Alex Bennée
> ---
> configure | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 50052378e417..d9987233 100755
Add pixman and spice deps to qxl module.
Signed-off-by: Gerd Hoffmann
Message-id: 20200914134224.29769-2-kra...@redhat.com
---
hw/display/meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/display/meson.build b/hw/display/meson.build
index
Needed to allow virtio-gpu-pci initialize the
virtio-gpu-device child device.
Signed-off-by: Gerd Hoffmann
Message-id: 20200914134224.29769-5-kra...@redhat.com
---
qom/object.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/qom/object.c b/qom/object.c
index b1822a2ef4be..387efb25ebe9
On 9/14/20 2:34 PM, Greg Kurz wrote:
> If spapr_irq_cpu_intc_create() fails, local_err isn't propagated and
> thus leaked.
>
> Fixes: 992861fb1e4c ("error: Eliminate error_propagate() manually")
> Cc: arm...@redhat.com
> Signed-off-by: Greg Kurz
> ---
> hw/ppc/spapr_cpu_core.c | 3 +--
> 1 file
On Tue, Sep 15, 2020 at 6:19 PM Igor Mammedov wrote:
>
> On Tue, 15 Sep 2020 17:40:25 +0530
> Ani Sinha wrote:
>
> > On Tue, Sep 15, 2020 at 5:21 PM Igor Mammedov wrote:
> > >
> > > On Mon, 14 Sep 2020 20:20:21 +0530
> > > Ani Sinha wrote:
> > >
> > > > On Mon, Sep 14, 2020 at 7:39 PM Igor
On 9/14/20 6:37 PM, Thomas Huth wrote:
> We simply want to ignore certain queries here, so let's rather
> use the term 'ignore' to express this intention.
>
> Signed-off-by: Thomas Huth
> ---
> v2: Changed naming according to suggestions
>
> tests/qtest/qmp-cmd-test.c | 10 +-
> 1
201 - 300 of 472 matches
Mail list logo
