On Thu, 2020-09-17 at 14:18 -0400, Eduardo Habkost wrote:
> I think the patch looks better now, thanks!
>
> Just a few minor questions and suggestions:
>
> On Wed, Sep 16, 2020 at 04:37:13PM +0800, Robert Hoo wrote:
> > Complement versioned CPU model framework with the ability of
> > marking
On Tue, Aug 18, 2020 at 04:19:58PM +0100, Stefan Hajnoczi wrote:
On Mon, Aug 17, 2020 at 2:13 PM Coiby Xu wrote:
I'm working on vhost-user block device backend [1]. When I tested my
patches on the latest version of QEMU (commit
d0ed6a69d399ae193959225cdeaa9382746c91cc) with --enable-sanitizer
On Thu, Sep 17, 2020 at 07:01:22PM +0200, Philippe Mathieu-Daudé wrote:
> On 9/17/20 6:53 PM, Thomas Huth wrote:
> > On 17/09/2020 18.39, Philippe Mathieu-Daudé wrote:
> >> Armbian servers are not very reliable and confused the GitLab CI
> >> users a few times this month (path updated, archives
P J P 于2020年9月4日周五 上午2:34写道：
>
> From: Prasad J Pandit
>
> When cancelling an i/o operation via ide_cancel_dma_sync(),
> a block pointer may be null. Add check to avoid null pointer
> dereference.
>
> -> https://ruhr-uni-bochum.sciebo.de/s/NNWP2GfwzYKeKwE?path=%2Fide_nullptr1
>
From: Erich McMillan
Signed-off-by: Erich McMillan
---
hw/i386/pc.c | 40
hw/i386/pc_sysfw.c | 13 ++---
include/hw/i386/pc.h | 22 --
3 files changed, 54 insertions(+), 21 deletions(-)
diff --git a/hw/i386/pc.c
On Fri, Sep 18, 2020 at 10:18:56AM +0800, Robert Hoo wrote:
> On Thu, 2020-09-17 at 14:01 -0400, Eduardo Habkost wrote:
> > On Wed, Sep 16, 2020 at 04:37:14PM +0800, Robert Hoo wrote:
> > > Going to obsolete Icelake-Client CPU models in the future.
> > >
> > > Signed-off-by: Robert Hoo
> > > ---
On Thu, Sep 17, 2020 at 01:56:21PM -0500, Tom Lendacky wrote:
> On 9/17/20 12:28 PM, Dr. David Alan Gilbert wrote:
> > * Tom Lendacky (thomas.lenda...@amd.com) wrote:
> > > From: Tom Lendacky
> > >
> > > This patch series provides support for launching an SEV-ES guest.
> > >
> > > Secure
On Thu, 2020-09-17 at 14:01 -0400, Eduardo Habkost wrote:
> On Wed, Sep 16, 2020 at 04:37:14PM +0800, Robert Hoo wrote:
> > Going to obsolete Icelake-Client CPU models in the future.
> >
> > Signed-off-by: Robert Hoo
> > ---
> > Change log
> > v3:
> > Obsolete in v5.2 --> v5.3.
> >
> >
Hello, I'm intersted in this bug fix and have some free time. maybe I
can do this bug-fix.
** Changed in: qemu
Status: New => In Progress
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1090604
https://bugs.launchpad.net/qemu/+bug/1894869
Here's the discussion with the upstream devs. The problem ended up being
on Chelsio's part as either the .7 funciton fo these cards should not
have even been exposed to the OS in the first place, or SR-IOV is
necessary to actually correct the
> From: Qemu-arm [mailto:qemu-arm-bounces+salil.mehta=huawei@nongnu.org]
> On Behalf Of Andrew Jones
> Sent: Thursday, September 17, 2020 9:13 AM
> To: fangying
> Cc: peter.mayd...@linaro.org; Zhanghailiang ;
> Alexander Graf ; qemu-devel@nongnu.org; Chenzhendong (alex)
> ;
Patchew URL:
https://patchew.org/QEMU/20200918000500.2690937-1-richard.hender...@linaro.org/
Hi,
This series failed build test on FreeBSD host. Please find the details below.
The full log is available at
While converting to gen_gvec_ool_zzzp, we lost passing
a->esz as the data argument to the function.
Fixes: 36cbb7a8e71
Cc: qemu-sta...@nongnu.org
Signed-off-by: Richard Henderson
---
target/arm/translate-sve.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
It is always possible to tell the length of an insn, even if the
actual insn is unknown. Skip the correct number of bytes, so that
we stay in sync with the instruction stream.
Acked-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
disas/capstone.c | 42
There is nothing target-specific about this code, so it
can be added to common_ss. This also requires that the
base capstone dependency be added to common_ss, so that
we get the correct include paths added to CFLAGS.
Signed-off-by: Richard Henderson
---
include/disas/dis-asm.h | 12 ++
Rename several functions, dropping "generic" and making "host"
vs "target" clearer. Make a bunch of functions static that are
not used outside this file. Replace INIT_DISASSEMBLE_INFO with
a trio of functions.
Acked-by: Thomas Huth
Signed-off-by: Richard Henderson
---
include/disas/dis-asm.h
The ifdef tangle failed to set cap_arch if libvixl itself
was not configured (e.g. due to lack of c++ compiler).
Reviewed-by: Thomas Huth
Signed-off-by: Richard Henderson
---
disas.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/disas.c b/disas.c
index
Do not retain a GString in thread-local storage. Allocate a
new one and free it on every invocation. Do not g_strdup the
result; return the buffer from the GString. Do not use
warn_report.
Using cs_disasm allocated memory via the parameter, but
that was never freed. Use cs_disasm_iter so
Enable s390x, aka SYSZ, in the git submodule build.
Set the capstone parameters for both s390x host and guest.
Acked-by: Thomas Huth
Signed-off-by: Richard Henderson
---
disas.c| 3 +++
target/s390x/cpu.c | 4
meson.build| 11 +++
3 files changed, 18
Use the routines we have already instead of open-coding.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
include/disas/dis-asm.h | 32
disas.c | 55 -
2 files changed, 27 insertions(+), 60
Instead of creating GStrings and passing them into log_disas,
just print the annotations directly in tb_gen_code.
Fix the annotations for the slow paths of the TB, after the
part implementing the final guest instruction.
Reviewed-by: Thomas Huth
Signed-off-by: Richard Henderson
---
The primary change here is the update for capstone to meson.
This bypasses capstone's build system entirely. There's more
commentary on that subject with the first patch.
Plus a collection of other fixes and cleanups in the area.
Patches still without review/ack:
This branch contains a number of improvements over master,
including making all of the disassembler data constant.
We are skipping past the 4.0 branchpoint, which changed
the location of the includes within the source directory.
Tested-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
There are better ways to do this, e.g. meson cmake subproject,
but that requires cmake 3.7 and some of our CI environments
only provide cmake 3.5.
Nor can we add a meson.build file to capstone/, because the git
submodule would then always report "untracked files". Fixing that
would require
Hi Graeme,
In the generated patch file ,there is subject description (as below)before the
"Signed-off-by: " line.Not sure why it doesn't show up in the mail.
Subject: [PATCH] hw/watchdog: Implement generic watchdog device model as per
ARM BSAv0.9 hw/arm/sbsa-ref : Include SBSA watchdog device in
Something still seems to have gone wrong with subject, and description
of patch is missing? Missed blank line between 1st line and description?
Do you have the link to updated ACPI tables for testing out of interest?
On Thu, Sep 17, 2020 at 02:12:45PM -0400, Shashi Mallela wrote:
>
On 9/17/20 9:31 AM, Philippe Mathieu-Daudé wrote:
> cpu_to_endian() and endian_to_cpu() can be extended to handle
> constant expressions. That way the programmer doesn't need to
> remember the const_X() API exists.
>
> Suggested-by: Stefan Hajnoczi
> Signed-off-by: Philippe Mathieu-Daudé
> ---
On Thu, Sep 17, 2020 at 1:41 PM Philippe Mathieu-Daudé
wrote:
>
> Armbian servers are not very reliable and confused the GitLab CI
> users a few times this month (path updated, archives moved, and
> now the SSL: CERTIFICATE_VERIFY_FAILED "certificate has expired"
> error). Time to disable these
On 9/17/20 9:31 AM, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé
>
> We already have the const_endian() macros for 16-bit and
> 32-bit values. Implement the 64-bit equivalent macros.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/qemu/bswap.h | 22
Patchew URL:
https://patchew.org/QEMU/20200917211321.1591257-1-kei...@keithp.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
N/A. Internal error while reading log file
The full log is available at
Adapt the arm semihosting support code for RISCV. This implementation
is based on the standard for RISC-V semihosting version 0.2 as
documented in
https://github.com/riscv/riscv-semihosting-spec/releases/tag/0.2
Signed-off-by: Keith Packard
---
v2:
Update PC after exception is
Patchew URL:
https://patchew.org/QEMU/20200917210200.158-1-kei...@keithp.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
N/A. Internal error while reading log file
The full log is available at
Patchew URL:
https://patchew.org/QEMU/20200917181245.132819-1-shashi.mall...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
N/A. Internal error while reading log file
The full log is available at
Adapt the arm semihosting support code for RISCV. This implementation
is based on the standard for RISC-V semihosting version 0.2 as
documented in
https://github.com/riscv/riscv-semihosting-spec/releases/tag/0.2
Signed-off-by: Keith Packard
---
v2:
Update PC after exception is
EDIT: Resending as reply-all
Hey Peter,
Appreciate the prompt response. Is there a particular reason why you were
proposing that the modification be made to the fsl-imx* files as opposed to the
"sabrelite.c" file? I was looking very briefly at the files you mentioned and I
believe the line
Signed-off-by: Shashi Mallela
---
hw/arm/Kconfig | 1 +
hw/arm/sbsa-ref.c | 23 ++
hw/watchdog/Kconfig | 4 +
hw/watchdog/meson.build | 1 +
hw/watchdog/wdt_sbsa_gwdt.c | 343
On 9/17/20 11:43 AM, Eduardo Habkost wrote:
> On Tue, Sep 15, 2020 at 05:46:33PM -0700, Richard Henderson wrote:
>> We do not need or want to be allocating page sized quanta.
>>
>> Signed-off-by: Richard Henderson
>
> Would it be safe to keep patches 2-6 applied in case this one
> gets dropped
On 9/15/20 6:39 PM, John Snow wrote:
Hi, this series starts adding static type hints to the QAPI module. As
you can see, the series started getting quite a bit long, so this is
only a partial conversion that focuses on a handful of the easier files.
The tougher files -- schema.py, expr.py,
On 9/17/20 10:06 AM, Alex Bennée wrote:
>> By the way, while you're at it, could you please also remove the form
>> feed character in this file here? ... that looks really confusing in my
>> e-mail client otherwise.
I guess, sure.
> I'm not entirely convinced that is from Richard. I've been
Patchew URL:
https://patchew.org/QEMU/20200917195519.19589-1-vsement...@virtuozzo.com/
Hi,
This series failed build test on FreeBSD host. Please find the details below.
The full log is available at
On 9/17/20 2:18 PM, John Snow wrote:
Your type hint adds a restriction that wasn't there before.
Is there a better way?
I've settled on using the `object` type for now, which is slightly more
restrictive than `Any`.
`Any` and `object` both allow any type of argument, but `Any`
effectively
Set errp always on failure. Generic bdrv_open_driver supports driver
functions which can return negative value and forget to set errp.
That's a strange thing.. Let's improve bdrv_qed_do_open to not behave
this way. This allows to simplify code in
bdrv_qed_co_invalidate_cache().
Signed-off-by:
qcow2_do_open correctly sets errp on each failure path. So, we can
simplify code in qcow2_co_invalidate_cache() and drop explicit error
propagation. We should use ERRP_GUARD() (accordingly to comment in
include/qapi/error.h) together with error_append() call which we add to
avoid problems with
It's recommended for bool functions with errp to return true on success
and false on failure. Non-standard interfaces don't help to understand
the code. The change is also needed to reduce error propagation.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2.h| 3 ++-
It's better to return status together with setting errp. It makes
possible to avoid error propagation.
While being here, put ERRP_GUARD() to fix error_prepend(errp, ...)
usage inside qcow2_store_persistent_dirty_bitmaps() (see the comment
above ERRP_GUARD() definition in include/qapi/error.h)
Don't use error propagation in qcow2_get_specific_info(). For this
refactor qcow2_get_bitmap_info_list, its current interface is rather
weird.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Greg Kurz
---
block/qcow2.h| 4 ++--
block/qcow2-bitmap.c | 27
We leak local_err and don't report failure to the caller. It's
definitely wrong, let's fix.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Greg Kurz
Reviewed-by: Alberto Garcia
---
blockdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/blockdev.c
bdrv_set_backing_hd now returns status, let's use it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Greg Kurz
Reviewed-by: Alberto Garcia
---
block.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/block.c b/block.c
index b4e36d6dd7..1cf825c349 100644
---
Let's check return value of mirror_start_job to check for failure
instead of local_err.
Rename ret to job, as ret is usually integer variable.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Greg Kurz
Reviewed-by: Alberto Garcia
---
block/mirror.c | 12 +---
1 file changed,
It's better to return status together with setting errp. It allows to
reduce error propagation.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Greg Kurz
Reviewed-by: Alberto Garcia
---
block/qcow2.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff
The recommended use of qemu error api assumes returning status together
with setting errp and avoid void functions with errp parameter. Let's
improve bdrv_append and some friends to reduce error-propagation
overhead in further patches.
Choose int return status, because bdrv_replace_node() has
This patch is generated by cocci script:
@@
symbol bdrv_open_child, errp, local_err;
expression file;
@@
file = bdrv_open_child(...,
-_err
+errp
);
- if (local_err)
+ if (!file)
{
...
- error_propagate(errp,
v2:
01-07: add Greg's and Alberto's r-bs
08: fix wording in commit message
add Greg's r-b
09: fix header_updated logic, add comment, drop unrelated style-change [Alberto]
10: - fix commit header
- add note about ERRP_GUARD in commit message
- add Greg's r-b
11: add Greg's and Alberto's
Better to return status together with setting errp. It allows to avoid
error propagation in the caller.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Greg Kurz
Reviewed-by: Alberto Garcia
---
include/block/blockjob.h | 2 +-
blockjob.c | 18 --
2
Now bdrv_append returns status and we can drop all the local_err things
around it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Greg Kurz
Reviewed-by: Alberto Garcia
---
block.c | 5 +
block/backup-top.c | 20
block/commit.c
On Thu, 17 Sep 2020 at 19:21, David Aghaian
wrote:
> Having a real difficult time determining whether or not I can use qemu (arm)
> with the Sabrelite machine type to be able to assign an sd-card to one of the
> 4 available sd-bus slots. Currently, no matter what combination of arguments
> I
On 9/17/20 10:42 AM, Markus Armbruster wrote:
Ugh.
Would moving it gen.py work?
Done.
On Wed, 16 Sep 2020 at 13:26, Alex Bennée wrote:
>
> The following changes since commit de39a045bd8d2b49e4f3d07976622c29d58e0bac:
>
> Merge remote-tracking branch
> 'remotes/kraxel/tags/vga-20200915-pull-request' into staging (2020-09-15
> 14:25:05 +0100)
>
> are available in the Git
On 9/17/20 3:14 PM, Eduardo Habkost wrote:
On Thu, Sep 17, 2020 at 02:44:53PM -0400, John Snow wrote:
[...]
Having said this, I have not found any tool to date that actually *checks*
these comments for consistency. The pycharm IDE interactively highlights
them when it senses that you have made
10.09.2020 19:10, Greg Kurz wrote:
On Wed, 9 Sep 2020 21:59:18 +0300
Vladimir Sementsov-Ogievskiy wrote:
Now bdrv_append returns status and we can drop all the local_err things
around it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
Reviewed-by: Greg Kurz
Just one suggestion for a
On Thu, Sep 17, 2020 at 02:44:53PM -0400, John Snow wrote:
[...]
> Having said this, I have not found any tool to date that actually *checks*
> these comments for consistency. The pycharm IDE interactively highlights
> them when it senses that you have made a mistake, but that cannot be worked
>
On 9/17/20 8:55 AM, Markus Armbruster wrote:
Daniel P. Berrangé writes:
On Wed, Sep 16, 2020 at 12:22:37PM -0400, John Snow wrote:
[...]
The real question I have is if anyone thinks it would be "rude" to separate
out any of the comment preambles (currently not visible at runtime or docs
in
Le 10/09/2020 à 09:01, Philippe Mathieu-Daudé a écrit :
> We don't have (yet?) inclusive terminology guidelines,
> but the PCI hole memory is not "black", the DMA sources
> don't stream to "slaves", and there isn't really a TSX
> "black" list, we only check for broken fields.
>
> As this terms
17.09.2020 19:35, Alberto Garcia wrote:
On Wed 09 Sep 2020 08:59:26 PM CEST, Vladimir Sementsov-Ogievskiy
wrote:
-/* qcow2_load_dirty_bitmaps()
- * Return value is a hint for caller: true means that the Qcow2 header was
- * updated. (false doesn't mean that the header should be updated by the
On 9/17/20 12:28 PM, Dr. David Alan Gilbert wrote:
* Tom Lendacky (thomas.lenda...@amd.com) wrote:
From: Tom Lendacky
This patch series provides support for launching an SEV-ES guest.
Secure Encrypted Virtualization - Encrypted State (SEV-ES) expands on the
SEV support to protect the guest
On 9/17/20 10:42 AM, Markus Armbruster wrote:
John Snow writes:
Including it in common.py creates a circular import dependency, because
schema relies on common.py. To type build_params properly, it needs to
be moved outside of the chain.
Signed-off-by: John Snow
---
17.09.2020 19:32, Alberto Garcia wrote:
On Wed 09 Sep 2020 08:59:25 PM CEST, Vladimir Sementsov-Ogievskiy
wrote:
+ * On success return true with bm_list set (probably to NULL, if no bitmaps),
" probably " ? :-)
I note this as "set to NULL" is not obvious thing (is it "unset" ? :).. And
Got it.
On Thu, 17 Sep 2020, 17:58 Paolo Bonzini, wrote:
>
>
> Il gio 17 set 2020, 18:53 Alex Bennée ha scritto:
>
>>
>> Philippe Mathieu-Daudé writes:
>>
>> > On 9/17/20 12:44 PM, Paolo Bonzini wrote:
>> >> Avoid that containers pile up.
>> >>
>> >> Signed-off-by: Paolo Bonzini
>> >> ---
>>
On 9/17/20 10:37 AM, Markus Armbruster wrote:
John Snow writes:
As docstrings, they'll show up in documentation and IDE help.
Signed-off-by: John Snow
---
scripts/qapi/common.py | 50 ++
1 file changed, 36 insertions(+), 14 deletions(-)
diff --git
On Tue, Sep 15, 2020 at 05:46:33PM -0700, Richard Henderson wrote:
> We do not need or want to be allocating page sized quanta.
>
> Signed-off-by: Richard Henderson
Would it be safe to keep patches 2-6 applied in case this one
gets dropped or reverted for any reason?
I consider patches 2-6 bug
Le 17/09/2020 à 09:50, zhaolichang a écrit :
> I found that there are many spelling errors in the comments of qemu,
> so I used the spellcheck tool to check the spelling errors
> and finally found some spelling errors in the qapi folder.
>
> Signed-off-by: zhaolichang
> Reviewed-by: Markus
Le 17/09/2020 à 10:44, Alex Bennée a écrit :
>
> zhaolichang writes:
>
>> I found that there are many spelling errors in the comments of qemu,
>> so I used the spellcheck tool to check the spelling errors
>> and finally found some spelling errors in the disas folder.
>>
>> Signed-off-by:
Le 17/09/2020 à 09:50, zhaolichang a écrit :
> I found that there are many spelling errors in the comments of qemu,
> so I used the spellcheck tool to check the spelling errors
> and finally found some spelling errors in the util folder.
>
> Signed-off-by: zhaolichang
> Reviewed-by: Alex Bennee
Le 17/09/2020 à 09:50, zhaolichang a écrit :
> I found that there are many spelling errors in the comments of qemu,
> so I used the spellcheck tool to check the spelling errors
> and finally found some spelling errors in the linux-user folder.
>
> Signed-off-by: zhaolichang
> Reviewed-by: Alex
Le 17/09/2020 à 09:50, zhaolichang a écrit :
> I found that there are many spelling errors in the comments of qemu,
> so I used the spellcheck tool to check the spelling errors
> and finally found some spelling errors in the scripts folder.
>
> Signed-off-by: zhaolichang
> Reviewed-by: Peter
Le 17/09/2020 à 09:50, zhaolichang a écrit :
> I found that there are many spelling errors in the comments of qemu,
> so I used the spellcheck tool to check the spelling errors
> and finally found some spelling errors in the migration folder.
>
> Signed-off-by: zhaolichang
> Reviewed-by: Peter
Le 17/09/2020 à 09:50, zhaolichang a écrit :
> I found that there are many spelling errors in the comments of qemu,
> so I used the spellcheck tool to check the spelling errors
> and finally found some spelling errors in the docs folder.
>
> Signed-off-by: zhaolichang
> Reviewed-by: Peter
Le 17/09/2020 à 09:50, zhaolichang a écrit :
> I found that there are many spelling errors in the comments of qemu,
> so I used the spellcheck tool to check the spelling errors
> and finally found some spelling errors in the folder.
>
> Signed-off-by: zhaolichang
> Reviewed-by: Alex Bennee
>
On 9/17/20 10:32 AM, Markus Armbruster wrote:
Question on the subject line: what makes a type hint notational?
My cover letter explains that every time I use this phrase, I mean to
state that "This patch adds exclusively type notations and makes no
functional changes to the runtime
I think the patch looks better now, thanks!
Just a few minor questions and suggestions:
On Wed, Sep 16, 2020 at 04:37:13PM +0800, Robert Hoo wrote:
> Complement versioned CPU model framework with the ability of marking some
> versions deprecated. When that CPU model is chosen, get some warning.
On 9/17/20 12:01 PM, Dr. David Alan Gilbert wrote:
* Tom Lendacky (thomas.lenda...@amd.com) wrote:
From: Tom Lendacky
An SEV-ES guest does not allow register state to be altered once it has
been measured. When a SEV-ES guest issues a reboot command, Qemu will
reset the vCPU state and resume
On 9/17/20 11:46 AM, Dr. David Alan Gilbert wrote:
* Tom Lendacky (thomas.lenda...@amd.com) wrote:
From: Tom Lendacky
When SEV-ES is enabled, it is not possible modify the guests register
state after it has been initially created, encrypted and measured.
Normally, an INIT-SIPI-SIPI request
** Attachment added: "matmult_double-m68k"
https://bugs.launchpad.net/qemu/+bug/1895703/+attachment/5411765/+files/matmult_double-m68k
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1895703
On Wed, Sep 16, 2020 at 04:37:14PM +0800, Robert Hoo wrote:
> Going to obsolete Icelake-Client CPU models in the future.
>
> Signed-off-by: Robert Hoo
> ---
> Change log
> v3:
> Obsolete in v5.2 --> v5.3.
>
> target/i386/cpu.c | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
Public bug reported:
Gcc version: 10.2.0
Glusterfs: 8.1
Libguestfs: 1.42
Configure options used:
configure \
--prefix=/usr \
--sysconfdir=/etc \
--localstatedir=/var \
--libexecdir=/usr/lib/qemu \
--extra-ldflags="$LDFLAGS" \
--smbd=/usr/bin/smbd \
--enable-modules \
On 9/17/20 10:17 AM, Markus Armbruster wrote:
John Snow writes:
Signed-off-by: John Snow
---
scripts/qapi/common.py | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py
index c665e67495..4c079755d3 100644
---
On Wed, Sep 16, 2020 at 04:11:31AM -0400, Paolo Bonzini wrote:
> Because the target/i386/hvf/meson.build rule culls hvf support
> on non-Darwin systems, a --enable-hvf build is succeeding.
> To fix this, just try the compilation test every time someone
> passes --enable-hvf.
>
> Reported-by:
On 9/17/20 10:15 AM, Markus Armbruster wrote:
John Snow writes:
Signed-off-by: John Snow
---
scripts/qapi/common.py | 16 +++-
scripts/qapi/schema.py | 14 +++---
2 files changed, 14 insertions(+), 16 deletions(-)
diff --git a/scripts/qapi/common.py
* Vitaly Kuznetsov (vkuzn...@redhat.com) wrote:
> "Dr. David Alan Gilbert" writes:
>
> > * Vitaly Kuznetsov (vkuzn...@redhat.com) wrote:
> >> Antoine Damhet writes:
> >>
> >> > On Thu, Sep 17, 2020 at 01:13:06PM +0200, Vitaly Kuznetsov wrote:
> >> >> QEMU's kvmclock device is only created when
On 9/17/20 7:02 PM, Stefano Garzarella wrote:
> Running checkpatch on a directory that contains a cover letter reports
> this error:
>
> Checking /tmp/tmpbnngauy3/-cover-letter.patch...
> ERROR: Does not appear to be a unified-diff format patch
>
> total: 1 errors, 0 warnings, 0
17.09.2020 19:23, Alberto Garcia wrote:
On Wed 09 Sep 2020 08:59:29 PM CEST, Vladimir Sementsov-Ogievskiy
wrote:
1. Drop extra error propagation
2. Set errp always on failure. Generic bdrv_open_driver supports driver
functions which can return negative value and forget to set errp.
That's a
On Thu, Sep 17, 2020 at 02:55:38PM +0200, Markus Armbruster wrote:
> Markus Armbruster (2):
> qom: Clean up object_property_get_enum()'s error value
> qom: Correct error values in two contracts
Queued, thanks!
--
Eduardo
* Tom Lendacky (thomas.lenda...@amd.com) wrote:
> From: Tom Lendacky
>
> This patch series provides support for launching an SEV-ES guest.
>
> Secure Encrypted Virtualization - Encrypted State (SEV-ES) expands on the
> SEV support to protect the guest register state from the hypervisor. See
>
On Wed, Sep 16, 2020 at 04:11:31AM -0400, Paolo Bonzini wrote:
> Because the target/i386/hvf/meson.build rule culls hvf support
> on non-Darwin systems, a --enable-hvf build is succeeding.
> To fix this, just try the compilation test every time someone
> passes --enable-hvf.
>
> Reported-by:
On Thu, Sep 17, 2020 at 09:38:02AM +0200, Cédric Le Goater wrote:
> On 9/17/20 4:49 AM, Eduardo Habkost wrote:
> > Mechanical search/replace to use the new
> > DECLARE_INTERFACE_CHECKER macro instead of manually defining
> > macros using INTERFACE_CHECK.
> >
> > Acked-by: David Gibson
> >
> Hello Qi,
>
> your patch breaks audio playback with the dsoundaudio backend.
>
> I suggest you make the following changes:
>
> - Test for size == 0 first and leave the loop in that case.
> - For buf == NULL drop size bytes. Don't leave the loop with break or return.
> - Verify all audio
On 9/17/20 4:07 AM, Markus Armbruster wrote:
John Snow writes:
On 9/16/20 11:13 AM, Markus Armbruster wrote:
John Snow writes:
Let's replace "the indent" by "the indentation" globally.
They're both cromulent as nouns and one is shorter.
I'll switch in good faith; do you prefer
Thomas Huth writes:
> On 15/09/2020 01.02, Richard Henderson wrote:
>> Rename several functions, dropping "generic" and making "host"
>> vs "target" clearer. Make a bunch of functions static that are
>> not used outside this file. Replace INIT_DISASSEMBLE_INFO with
>> a trio of functions.
>>
On 9/17/20 6:57 PM, Philippe Mathieu-Daudé wrote:
> On 9/16/20 7:51 AM, Cédric Le Goater wrote:
>> On 9/15/20 7:23 PM, Philippe Mathieu-Daudé wrote:
>>> ping?
>>
>> It's reviewed :
>>
>>
>> http://patchwork.ozlabs.org/project/qemu-devel/patch/20200905212415.760452-1-f4...@amsat.org/
>>
>
>
Patchew URL: https://patchew.org/QEMU/20200917163954.50514-1-phi...@redhat.com/
Hi,
This series failed build test on FreeBSD host. Please find the details below.
The full log is available at
http://patchew.org/logs/20200917163954.50514-1-phi...@redhat.com/testing.FreeBSD/?type=message.
1 - 100 of 471 matches
Mail list logo
