Re: [PATCH] hw/arm/virt: use pflash image real size when mapping

2020-09-21 Thread Laszlo Ersek
On 09/18/20 15:41, Philippe Mathieu-Daudé wrote: > Cc'ing firmware experts. > > On 9/18/20 2:26 PM, haibinzhang(寮犳捣鏂�) wrote: >> Default size of arm-virt pflash image is 64MB which >> will cost extra 128MB(64MBx2) memory per qemu process >> and 12.5GB for 100 qemu processes. Host memory is >> prec

Re: [PATCH 2/3] Reduce the time of checkpoint for COLO

2020-09-21 Thread Li Zhijian
On 9/19/20 11:10 AM, leirao wrote: we should set ram_bulk_stage to false after ram_state_init, otherwise the bitmap will be unused in migration_bitmap_find_dirty. all pages in ram cache will be flushed to the ram of secondary guest for each checkpoint. Signed-off-by: leirao --- migration/r

Re: [PATCH] qemu/atomic.h: prefix qemu_ to solve collisions

2020-09-21 Thread Paolo Bonzini
On 22/09/20 08:45, David Hildenbrand wrote: >> It's certainly a good idea but it's quite verbose. >> >> What about using atomic__* as the prefix? It is not very common in QEMU >> but there are some cases (and I cannot think of anything better). > > aqomic_*, lol :) Actually qatomic_ would be a go

Re: [PATCH 5/6] travis.yml: Update Travis to use Bionic and Focal instead of Xenial

2020-09-21 Thread Thomas Huth
On 22/09/2020 01.39, Cleber Rosa wrote: > On Fri, Sep 18, 2020 at 12:34:29PM +0200, Thomas Huth wrote: >> According to our support policy, we do not support Xenial anymore. >> Time to switch the bigger parts of the builds to Focal instead. >> Some few jobs have to be updated to Bionic instead, sinc

Re: [PATCH 22/24] i440fx: Register i440FX-pcihost properties as class properties

2020-09-21 Thread Igor Mammedov
On Mon, 21 Sep 2020 18:10:43 -0400 Eduardo Habkost wrote: > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Signed-off-by: Eduardo Habkost > --- > Cc: "Michael S. Tsirkin" > Cc: Marcel Apfelbaum > Cc: qemu-devel@nongnu.org

Re: [PATCH 3/6] migration: Silence compiler warning in global_state_store_running()

2020-09-21 Thread Thomas Huth
On 21/09/2020 22.39, Cleber Rosa wrote: > On Fri, Sep 18, 2020 at 12:34:27PM +0200, Thomas Huth wrote: >> GCC 9.3.0 on Ubuntu complains: >> >> In file included from /usr/include/string.h:495, >> from /home/travis/build/huth/qemu/include/qemu/osdep.h:87, >> from ../

Re: [PATCH 17/24] cpu/core: Register core-id and nr-threads as class properties

2020-09-21 Thread Igor Mammedov
On Mon, 21 Sep 2020 18:10:38 -0400 Eduardo Habkost wrote: > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > Cc: qemu-devel@nongnu.org > --- > hw/cpu/core.c

Re: [PATCH 1/3] Optimize seq_sorter function for colo-compare

2020-09-21 Thread Li Zhijian
On 9/19/20 11:10 AM, leirao wrote: The seq of tcp has been filled in fill_pkt_tcp_info, it can be used directly here. Signed-off-by: leirao Reviewed-by: Li Zhijian --- net/colo-compare.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/colo-compare.c b/net

Re: [PATCH 12/24] s390x: Register all CPU properties as class properties

2020-09-21 Thread David Hildenbrand
On 22.09.20 00:10, Eduardo Habkost wrote: > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Signed-off-by: Eduardo Habkost > --- > Cc: Cornelia Huck > Cc: Thomas Huth > Cc: Richard Henderson > Cc: David Hildenbrand > Cc: Ha

Re: [PATCH 14/24] i386: Register feature bit properties as class properties

2020-09-21 Thread Igor Mammedov
On Mon, 21 Sep 2020 18:10:35 -0400 Eduardo Habkost wrote: > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Signed-off-by: Eduardo Habkost > --- > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > Cc: qemu-

Re: [PATCH] qemu/atomic.h: prefix qemu_ to solve collisions

2020-09-21 Thread David Hildenbrand
On 22.09.20 08:27, Paolo Bonzini wrote: > On 21/09/20 18:23, Stefan Hajnoczi wrote: >> clang's C11 atomic_fetch_*() functions only take a C11 atomic type >> pointer argument. QEMU uses direct types (int, etc) and this causes a >> compiler error when a QEMU code calls these functions in a source fil

Re: [PATCH 3/4] net/colo-compare.c: Add secondary old packet detection

2020-09-21 Thread Li Zhijian
On 9/18/20 5:22 PM, Zhang Chen wrote: From: Zhang Chen Detect queued secondary packet to sync VM state in time. Signed-off-by: Zhang Chen --- net/colo-compare.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/net/colo-compare.c b/net/colo-c

Re: [PATCH 13/24] i386: Register most CPU properties as class properties

2020-09-21 Thread Igor Mammedov
On Mon, 21 Sep 2020 18:10:34 -0400 Eduardo Habkost wrote: > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Signed-off-by: Eduardo Habkost > --- > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > Cc: qemu-

Re: [PATCH 20/24] machine: Register "memory-backend" as class property

2020-09-21 Thread Igor Mammedov
On Mon, 21 Sep 2020 18:10:41 -0400 Eduardo Habkost wrote: > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Signed-off-by: Eduardo Habkost > --- > Cc: Eduardo Habkost > Cc: Marcel Apfelbaum > Cc: qemu-devel@nongnu.org Revi

Re: [PATCH] qemu/atomic.h: prefix qemu_ to solve collisions

2020-09-21 Thread Paolo Bonzini
On 21/09/20 18:23, Stefan Hajnoczi wrote: > clang's C11 atomic_fetch_*() functions only take a C11 atomic type > pointer argument. QEMU uses direct types (int, etc) and this causes a > compiler error when a QEMU code calls these functions in a source file > that also included via a system header f

Re: [PATCH 2/4] net/colo-compare.c: Change the timer clock type

2020-09-21 Thread Li Zhijian
On 9/18/20 5:22 PM, Zhang Chen wrote: From: Zhang Chen The virtual clock only runs during the emulation. It stops when the virtual machine is stopped. The host clock should be used for device models that emulate accurate real time sources. It will continue to run when the virtual machine is

Re: [PATCH 1/4] net/colo-compare.c: Fix compare_timeout format issue

2020-09-21 Thread Li Zhijian
On 9/18/20 5:22 PM, Zhang Chen wrote: From: Zhang Chen This parameter need compare with the return of qemu_clock_get_ms(), it is uinit64_t. So we need fix this issue here. Reported-by: Derek Su Signed-off-by: Zhang Chen Reviewed-by: Li Zhijian --- net/colo-compare.c | 12 ++-

Re: Regression with latest SeaBIOS booting multi-disk root LVs?

2020-09-21 Thread Gerd Hoffmann
On Mon, Sep 21, 2020 at 03:10:51PM +0200, Stefan Reiter wrote: > Hi list, > > since SeaBIOS 1.14.0 (QEMU 5.1) VMs with LVM root disks spanning more than > one PV fail to boot, if only the first is set as bootable. I believe this is > due to the changes in SeaBIOS only initializing drives marked as

Re: [PATCH v1 1/1] COLO: only flush dirty ram pages from colo cache

2020-09-21 Thread Derek Su
Hi, Chen and Lei Using Lei's patch is OK to me. Please help to add "Signed-off-by: Derek Su " for merging it. Thank you. :) Regards Derek Zhang, Chen 於 2020年9月22日 週二 下午1:37寫道: > So, Derek, you will send new version patch? > > > > Thanks > > Zhang Chen > > > > *From:* Derek Su > *Sent:* Tuesda

RE: [PATCH v1 1/1] COLO: only flush dirty ram pages from colo cache

2020-09-21 Thread Zhang, Chen
So, Derek, you will send new version patch? Thanks Zhang Chen From: Derek Su Sent: Tuesday, September 22, 2020 1:18 PM To: Rao, Lei Cc: Zhang, Chen ; qemu-devel ; zhang.zhanghaili...@huawei.com; quint...@redhat.com; dgilb...@redhat.com Subject: Re: [PATCH v1 1/1] COLO: only flush dirty ram pag

Re: [PATCH v1 1/1] COLO: only flush dirty ram pages from colo cache

2020-09-21 Thread Derek Su
Hi, Lei Got it. Thanks. Regards, Derek Rao, Lei 於 2020年9月22日 週二 下午1:04寫道: > Hi, Derek and Chen > > ram_bulk_stage is false by default before Hailiang's patch. > For COLO, it does not seem to be used, so I think there is no need to > reset it to true. > > Thanks, > Lei. > > From: Derek Su > Se

Re: [PATCH v3 1/2] Introduce (x86) CPU model deprecation API

2020-09-21 Thread Robert Hoo
On Mon, 2020-09-21 at 11:37 -0400, Eduardo Habkost wrote: > > ... > > Yes. Trying as less refactor as possible. I think my changes even > > cannot be called refactor at all. :) > > My idea is to make unversioned CPU model virtual. I did some patch, > > doable: > > 1) in x86_register_cpudef_types()

RE: [PATCH v1 1/1] COLO: only flush dirty ram pages from colo cache

2020-09-21 Thread Rao, Lei
Hi, Derek and Chen ram_bulk_stage is false by default before Hailiang's patch. For COLO, it does not seem to be used, so I think there is no need to reset it to true. Thanks, Lei. From: Derek Su Sent: Tuesday, September 22, 2020 11:48 AM To: Zhang, Chen Cc: qemu-devel ; Rao, Lei ; zhang.zha

Re: [PATCH 00/24] qom: Convert some properties to class properties

2020-09-21 Thread Eduardo Habkost
On Tue, Sep 22, 2020 at 09:47:57AM +0800, Li Qiang wrote: > Eduardo Habkost 于2020年9月22日周二 上午6:11写道: > > > > Class properties make QOM introspection simpler and easier, as it > > doesn't require an object to be instantiated. This series > > converts a few existing object_property_add*() calls to r

Re: [PATCH v1 1/1] COLO: only flush dirty ram pages from colo cache

2020-09-21 Thread Derek Su
Hi, Chen Sure. BTW, I just went through Lei's patch. ram_bulk_stage() might need to reset to true after stopping COLO service as my patch. How about your opinion? Thanks. Best regards, Derek Zhang, Chen 於 2020年9月22日 週二 上午11:41寫道: > Hi Derek and Lei, > > > > It looks same with Lei’ patch: >

RE: [PATCH v1 1/1] COLO: only flush dirty ram pages from colo cache

2020-09-21 Thread Zhang, Chen
Hi Derek and Lei, It looks same with Lei’ patch: [PATCH 2/3] Reduce the time of checkpoint for COLO Can you discuss to merge it into one patch? Thanks Zhang Chen From: Derek Su Sent: Tuesday, September 22, 2020 11:31 AM To: qemu-devel Cc: zhang.zhanghaili...@huawei.com; quint...@redhat.com; dg

Re: [PATCH v1 1/1] COLO: only flush dirty ram pages from colo cache

2020-09-21 Thread Derek Su
Hello, all Ping... Regards, Derek Su Derek Su 於 2020年9月10日 週四 下午6:47寫道: > In secondary side, the colo_flush_ram_cache() calls > migration_bitmap_find_dirty() to finding the dirty pages and > flush them to host. But ram_state's ram_bulk_stage flag is always > enabled in secondary side, it leads

[PATCH] vhost-user: save features of multiqueues if chardev is closed

2020-09-21 Thread 张海斌
Fore-commit(c6beefd674) only saves features of queue0, this makes wrong features of other queues in multiqueues situation. For examples: qemu-system-aarch64 ... \ -chardev socket,id=charnet0,path=/var/run/vhost_sock \ -netdev vhost-user,chardev=charnet0,queues=2,id=hostnet0 \ ... There are

Re: [PATCH 00/24] qom: Convert some properties to class properties

2020-09-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200921221045.699690-1-ehabk...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN =

Re: [PATCH 1/3] virtio-net: Set mac address to hardware if the peer is vdpa

2020-09-21 Thread Cindy Lu
On Tue, Sep 22, 2020 at 9:55 AM Jason Wang wrote: > > > On 2020/9/17 下午11:58, Cindy Lu wrote: > > If the peer's type is vdpa,set the mac address to NIC in > > virtio_net_device_realize, > > Also sometime vdpa get an all 0 macaddress from the hardware, this will > > cause the traffic down > > So

[Bug 1896561] [NEW] EFI GOP Mode 1366x768

2020-09-21 Thread Benjamin David Lunt
Public bug reported: When using the EFI firmware from https://www.kraxel.org/repos/jenkins/edk2/ (https://www.kraxel.org/repos/jenkins/edk2/edk2.git- ovmf-x64-0-20200919.1453.g7faece6985.noarch.rpm) (OVMF-pure-efi.fd and OVMF_VARS-pure-efi.fd) then using the GOP, setting the mode to 1366x768, QEMU

[PATCH V10 6/8] hw/mips: Implement fw_cfg_arch_key_name()

2020-09-21 Thread Huacai Chen
Implement fw_cfg_arch_key_name(), which returns the name of a mips-specific key. Signed-off-by: Huacai Chen Co-developed-by: Jiaxun Yang --- hw/mips/fw_cfg.c| 35 +++ hw/mips/fw_cfg.h| 19 +++ hw/mips/meson.build | 2 +- 3 files changed,

[PATCH V10 8/8] docs/system: Update MIPS machine documentation

2020-09-21 Thread Huacai Chen
Add Loongson-3A CPU models and Loongson-3 based machine description. Signed-off-by: Huacai Chen --- docs/system/cpu-models-mips.rst.inc | 10 -- docs/system/target-mips.rst | 10 ++ 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/docs/system/cpu-models-mip

[PATCH V10 5/8] target/mips: Add loongson-ext lsdc2 group of instructions

2020-09-21 Thread Huacai Chen
From: Jiaxun Yang LDC2/SDC2 opcodes have been rewritten as "load & store with offset" group of instructions by loongson-ext ASE. This patch add implementation of these instructions: gslbx: load 1 bytes to GPR gslhx: load 2 bytes to GPR gslwx: load 4 bytes to GPR gsldx: load 8 bytes to GPR gslwxc

[PATCH V10 3/8] target/mips: Add loongson-ext lswc2 group of instructions (Part 1)

2020-09-21 Thread Huacai Chen
From: Jiaxun Yang LWC2 & SWC2 have been rewritten by Loongson EXT vendor ASE as "load/store quad word" and "shifted load/store" groups of instructions. This patch add implementation of these instructions: gslq: load 16 bytes to GPR gssq: store 16 bytes from GPR gslqc1: load 16 bytes to FPR gssqc

[PATCH V10 2/8] target/mips: Fix PageMask with variable page size

2020-09-21 Thread Huacai Chen
From: Jiaxun Yang Our current code assumed the target page size is always 4k when handling PageMask and VPN2, however, variable page size was just added to mips target and that's nolonger true. Signed-off-by: Huacai Chen Signed-off-by: Jiaxun Yang --- target/mips/cp0_helper.c | 36 +++

[PATCH V10 7/8] hw/mips: Add Loongson-3 machine support

2020-09-21 Thread Huacai Chen
Add Loongson-3 based machine support, it use liointc as the interrupt controler and use GPEX as the pci controller. Currently it can work with both TCG and KVM. As the machine model is not based on any exiting physical hardware, the name of the machine is "loongson3-virt". It may be superseded in

[PATCH V10 1/8] linux-headers: Update MIPS KVM type defintition

2020-09-21 Thread Huacai Chen
Update MIPS KVM type defintition from Linux 5.9-rc6. Signed-off-by: Huacai Chen --- linux-headers/linux/kvm.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index a28c366737..36a480fd77 100644 --- a/linux-headers/lin

[PATCH V10 0/8] mips: Add Loongson-3 machine support

2020-09-21 Thread Huacai Chen
Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and Loongson-3B R1/R2. Loongson-3A R1 is the oldest and its ISA is the smallest, while Loongson-3A R4 is the newest and its ISA is almost the superset of all others. To reduce complexity, in QEMU we just define two CPU types: 1, "Loongson-3A100

[PATCH V10 4/8] target/mips: Add loongson-ext lswc2 group of instructions (Part 2)

2020-09-21 Thread Huacai Chen
From: Jiaxun Yang LWC2 & SWC2 have been rewritten by Loongson EXT vendor ASE as "load/store quad word" and "shifted load/store" groups of instructions. This patch add implementation of these instructions: gslwlc1: similar to lwl but RT is FPR instead of GPR gslwrc1: similar to lwr but RT is FPR

Re: [PATCH v2 2/2] vhost-vdpa: add trace-events

2020-09-21 Thread Jason Wang
On 2020/9/21 下午9:04, Laurent Vivier wrote: Add trace functionis in vhost-vdpa.c. All traces from this file can be enabled with '-trace vhost_vdpa*'. Acked-by: Stefan Hajnoczi Signed-off-by: Laurent Vivier --- hw/virtio/trace-events | 29 ++ hw/virtio/vhost-vdpa.c | 86 +++

Re: [PATCH 3/3] net: Add vhost-vdpa in show_netdevs()

2020-09-21 Thread Jason Wang
On 2020/9/17 下午11:58, Cindy Lu wrote: Fix the bug that while Check qemu supported netdev, there is no vhost-vdpa Signed-off-by: Cindy Lu Acked-by: Jason Wang --- net/net.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/net.c b/net/net.c index 7a2a0fb5ac..794c652282 10064

Re: [PATCH 2/3] vhost-vdpa: Add qemu_close in vhost_vdpa_cleanup

2020-09-21 Thread Jason Wang
On 2020/9/17 下午11:58, Cindy Lu wrote: fix the bug that fd will still open after the cleanup Signed-off-by: Cindy Lu Acked-by: Jason Wang --- net/vhost-vdpa.c | 4 1 file changed, 4 insertions(+) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index bc0e0d2d35..0480b92102 1006

Re: [PATCH 1/3] virtio-net: Set mac address to hardware if the peer is vdpa

2020-09-21 Thread Jason Wang
On 2020/9/17 下午11:58, Cindy Lu wrote: If the peer's type is vdpa,set the mac address to NIC in virtio_net_device_realize, Also sometime vdpa get an all 0 macaddress from the hardware, this will cause the traffic down So we add the check for this part. if we get an 0 mac address we will use th

Re: [PATCH 00/24] qom: Convert some properties to class properties

2020-09-21 Thread Li Qiang
Eduardo Habkost 于2020年9月22日周二 上午6:11写道: > > Class properties make QOM introspection simpler and easier, as it > doesn't require an object to be instantiated. This series > converts a few existing object_property_add*() calls to register > class properties instead. > Hello Eduardo, IIUC, most of

Re: [PATCH] hw: ide: check the pointer before do dma memory unmap

2020-09-21 Thread Alexander Bulekov
On 200815 0020, Li Qiang wrote: > In 'map_page' we need to check the return value of > 'dma_memory_map' to ensure the we actully maped something. > Otherwise, we will hit an assert in 'address_space_unmap'. > This is because we can't find the MR with the NULL buffer. > This is the LP#1884693: > >

RE: [PATCH 01/24] cryptodev-vhost-user: Register "chardev" as class property

2020-09-21 Thread Gonglei (Arei)
> -Original Message- > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Tuesday, September 22, 2020 6:10 AM > To: qemu-devel@nongnu.org > Cc: Paolo Bonzini ; Daniel P. Berrange > ; John Snow ; Gonglei (Arei) > > Subject: [PATCH 01/24] cryptodev-vhost-user: Register "chardev" a

RE: [PATCH 02/24] cryptodev-backend: Register "chardev" as class property

2020-09-21 Thread Gonglei (Arei)
> -Original Message- > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Tuesday, September 22, 2020 6:10 AM > To: qemu-devel@nongnu.org > Cc: Paolo Bonzini ; Daniel P. Berrange > ; John Snow ; Gonglei (Arei) > > Subject: [PATCH 02/24] cryptodev-backend: Register "chardev" as c

Re: [PATCH] migration: increase max-bandwidth to 128 MiB/s (1 Gib/s)

2020-09-21 Thread David Gibson
On Mon, Sep 21, 2020 at 04:49:57PM +0200, Laurent Vivier wrote: > max-bandwidth is set by default to 32 MiB/s (256 Mib/s) > since 2008 (5bb7910af031c). > > Most of the CPUs can dirty memory faster than that now, > and this is clearly a problem with POWER where the page > size is 64 kiB and not 4 K

Re: [PATCH] hw: ide: check the pointer before do dma memory unmap

2020-09-21 Thread Li Qiang
Ping!! Li Qiang 于2020年9月15日周二 下午9:38写道: > > ping!! > > Li Qiang 于2020年9月7日周一 上午9:39写道: > > > > Ping! > > > > Li Qiang 于2020年9月1日周二 下午6:34写道: > > > > > > Ping. > > > > > > Li Qiang 于2020年8月15日周六 下午3:21写道: > > > > > > > > In 'map_page' we need to check the return value of > > > > 'dma_memory_map

[PULL 0/1] bitmaps patches for 2020-09-21

2020-09-21 Thread Eric Blake
The following changes since commit 5df6c87e8080e0021e975c8387baa20cfe43c932: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' into staging (2020-09-21 17:41:32 +0100) are available in the Git repository at: https://repo.or.cz/qemu/ericb.git tags/pull-bitmaps-2020-0

[PULL 1/1] qemu-img: Support bitmap --merge into backing image

2020-09-21 Thread Eric Blake
If you have the chain 'base.qcow2 <- top.qcow2' and want to merge a bitmap from top into base, qemu-img was failing with: qemu-img: Could not open 'top.qcow2': Could not open backing file: Failed to get shared "write" lock Is another process using the image [base.qcow2]? The easiest fix is to no

Re: [PATCH v5 4/7] tests/qtest/libqos/virtio-blk: add support for vhost-user-blk

2020-09-21 Thread Dima Stepanov
On Mon, Sep 21, 2020 at 07:04:20PM -0400, Raphael Norwitz wrote: > MST already sent a PR with all the patches :) Thank you! ) > > On Wed, Sep 16, 2020 at 6:13 PM Dima Stepanov wrote: > > > > On Mon, Sep 14, 2020 at 09:23:42PM -0400, Raphael Norwitz wrote: > > > On Fri, Sep 11, 2020 at 4:43 AM D

Re: [PATCH v4 00/11] capstone + disassembler patches

2020-09-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200921174118.39352-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200921174118.39352-1-richard.hender...@linaro.org Subject: [PATCH v4 00/11] ca

Re: [PATCH] xen: xenguest is not used so is not needed

2020-09-21 Thread Stefano Stabellini
Adding Paul On Sat, 19 Sep 2020, Philippe Mathieu-Daudé wrote: > Cc'ing qemu-trivial@ > > On 7/27/20 5:09 PM, Anthony PERARD wrote: > > On Mon, Jul 27, 2020 at 05:00:48PM +0300, Michael Tokarev wrote: > >> There's no references in only file which includes xenguest.h > >> to any xen definitions.

Re: [PATCH v2] target/i386: Remove core_id assert check in CPUID 0x8000001E

2020-09-21 Thread Eduardo Habkost
On Mon, Sep 21, 2020 at 05:47:28PM -0500, Babu Moger wrote: > With x2apic enabled, configurations can have more that 255 cores. > Noticed the device add test is hitting an assert when during cpu > hotplug with core_id > 255. This is due to assert check in the > CPUID 0x801E. > > Remove the ass

Re: [RFC PATCH 3/6] hw/sd/sdcard: Do not use legal address '0' for INVALID_ADDRESS

2020-09-21 Thread Kevin O'Connor
On Mon, Sep 21, 2020 at 12:31:21PM +0200, Philippe Mathieu-Daudé wrote: > Back to the SDcard, it might be less critical, so a migration > breaking change might be acceptable. I'm only aware of Paolo > and Kevin using this device for testing. Not sure of its > importance in production. FWIW, I only

Re: [PATCH] migration: Truncate state file in xen-save-devices-state

2020-09-21 Thread Stefano Stabellini
Adding Paul On Mon, 21 Sep 2020, Dr. David Alan Gilbert wrote: > * Dov Murik (dovmu...@linux.vnet.ibm.com) wrote: > > > > > > On 21/09/2020 14:17, Dr. David Alan Gilbert wrote: > > > * Dov Murik (dovmu...@linux.vnet.ibm.com) wrote: > > > > When running the xen-save-devices-state QMP command, if

Re: [PATCH 6/6] travis.yml: Drop the superfluous Python 3.6 build

2020-09-21 Thread Cleber Rosa
On Fri, Sep 18, 2020 at 12:34:30PM +0200, Thomas Huth wrote: > Python 3.6 is already the default Python in the jobs that are based > on Ubuntu Bionic, so it does not make much sense to test this again > separately. > > Signed-off-by: Thomas Huth > --- > .travis.yml | 8 > 1 file changed

Re: [PATCH 5/6] travis.yml: Update Travis to use Bionic and Focal instead of Xenial

2020-09-21 Thread Cleber Rosa
On Fri, Sep 18, 2020 at 12:34:29PM +0200, Thomas Huth wrote: > According to our support policy, we do not support Xenial anymore. > Time to switch the bigger parts of the builds to Focal instead. > Some few jobs have to be updated to Bionic instead, since they are > currently still failing on Focal

Re: [PATCH v5 4/7] tests/qtest/libqos/virtio-blk: add support for vhost-user-blk

2020-09-21 Thread Raphael Norwitz
MST already sent a PR with all the patches :) On Wed, Sep 16, 2020 at 6:13 PM Dima Stepanov wrote: > > On Mon, Sep 14, 2020 at 09:23:42PM -0400, Raphael Norwitz wrote: > > On Fri, Sep 11, 2020 at 4:43 AM Dima Stepanov > > wrote: > > > > > > Add support for the vhost-user-blk-pci device. This no

Re: [PATCH] vhost-blk: set features before setting inflight feature

2020-09-21 Thread Raphael Norwitz
I see your point - all the open source backends I could find which support VHOST_USER_PROTOCOL_F_INFLIGHT_SHMFD rely on knowing the vq type to allocate the fd. That said, it looks like dpdk supports both VHOST_USER_PROTOCOL_F_INFLIGHT_SHMFD and packed vqs without needing such an API https://githu

[PATCH v2] target/i386: Remove core_id assert check in CPUID 0x8000001E

2020-09-21 Thread Babu Moger
With x2apic enabled, configurations can have more that 255 cores. Noticed the device add test is hitting an assert when during cpu hotplug with core_id > 255. This is due to assert check in the CPUID 0x801E. Remove the assert check and fix the problem. Fixes the bug: Link: https://bugzilla.re

[PATCH 22/24] i440fx: Register i440FX-pcihost properties as class properties

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Cc: qemu-devel@nongnu.org --- hw/pci-host/i440fx.c | 32 1 file chan

[PATCH 23/24] sifive_e: Register "revb" as class property

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Palmer Dabbelt Cc: Alistair Francis Cc: Sagar Karandikar Cc: Bastian Koppelmann Cc: qemu-ri...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/ri

[PATCH 19/24] xlnx-zcu102: Register properties as class properties

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Alistair Francis Cc: "Edgar E. Iglesias" Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/arm/xlnx-zcu102.c | 25 +++

Re: [PATCH 0/3] Hyper-V Dynamic Memory Protocol driver (hv-balloon)

2020-09-21 Thread Maciej S. Szmigiero
Hi David, Thank you for your comments. First, I want to underline that this driver targets Windows guests, where ability to modify and adapt the guest memory management code is extremely limited. While it does work with Linux guests, too, this is definitely not its native environment. It also h

[PATCH 21/24] vga-pci: Register "big-endian-framebuffer" as class property

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Gerd Hoffmann Cc: qemu-devel@nongnu.org --- hw/display/vga-pci.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git

[PATCH 14/24] i386: Register feature bit properties as class properties

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: qemu-devel@nongnu.org --- target/i386/cpu.c | 33 -

[PATCH 20/24] machine: Register "memory-backend" as class property

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: qemu-devel@nongnu.org --- hw/core/machine.c | 12 ++-- 1 file changed, 6 insertions(+), 6 dele

[PATCH 17/24] cpu/core: Register core-id and nr-threads as class properties

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: qemu-devel@nongnu.org --- hw/cpu/core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/cpu/core.c b/hw/cpu/core.c

[PATCH 12/24] s390x: Register all CPU properties as class properties

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Cornelia Huck Cc: Thomas Huth Cc: Richard Henderson Cc: David Hildenbrand Cc: Halil Pasic Cc: Christian Borntraeger Cc: qemu-s3...@nongnu.or

Re: [PATCH v3] SEV: QMP support for Inject-Launch-Secret

2020-09-21 Thread Tom Lendacky
On 9/21/20 3:33 PM, Tobin Feldman-Fitzthum wrote: > On 2020-09-21 15:16, Dr. David Alan Gilbert wrote: >> * Tobin Feldman-Fitzthum (to...@linux.vnet.ibm.com) wrote: >>> AMD SEV allows a guest owner to inject a secret blob >>> into the memory of a virtual machine. The secret is >>> encrypted with th

[PATCH 24/24] sifive_u: Register "start-in-flash" as class property

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Palmer Dabbelt Cc: Alistair Francis Cc: Sagar Karandikar Cc: Bastian Koppelmann Cc: qemu-ri...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/ri

[PATCH 08/24] vexpress-a15: Register "virtualization" as class property

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/arm/vexpress.c | 14 -- 1 file changed, 8 insertions(+), 6 de

[PATCH 04/24] rng-random: register "filename" as class property

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Laurent Vivier Cc: Amit Shah Cc: qemu-devel@nongnu.org --- backends/rng-random.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH 16/24] virt: Register "its" as class property

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Note: "its" is currently registered conditionally, but this makes the feature be registered unconditionally. The only side effect is that it will be now possible to set its=on on virt-2

[PATCH 11/24] tmp421: Register properties as class properties

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: qemu-devel@nongnu.org --- hw/misc/tmp421.c | 30 +- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/h

[PATCH 10/24] input-barrier: Register properties as class properties

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Gerd Hoffmann Cc: qemu-devel@nongnu.org --- ui/input-barrier.c | 44 ++-- 1 file changed, 22 insertions(

[PATCH 18/24] arm/cpu64: Register "aarch64" as class property

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- target/arm/cpu64.c | 16 ++-- 1 file changed, 6 insertions(+), 1

[PATCH 13/24] i386: Register most CPU properties as class properties

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: qemu-devel@nongnu.org --- target/i386/cpu.c | 66 -

[PATCH 03/24] rng-egd: Register "chardev" as class property

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Laurent Vivier Cc: Amit Shah Cc: qemu-devel@nongnu.org --- backends/rng-egd.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) d

[PATCH 07/24] rng: Register "opened" as class property

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Laurent Vivier Cc: Amit Shah Cc: qemu-devel@nongnu.org --- backends/rng.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff -

[PATCH 02/24] cryptodev-backend: Register "chardev" as class property

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: "Gonglei (Arei)" Cc: qemu-devel@nongnu.org --- backends/cryptodev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/

[PATCH 15/24] arm/virt: Register most properties as class properties

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/arm/virt.c | 76 +++ 1 fi

[PATCH 09/24] input-linux: Register properties as class properties

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Gerd Hoffmann Cc: qemu-devel@nongnu.org --- ui/input-linux.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-)

[PATCH 05/24] vhost-user: Register "chardev" as class property

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org --- backends/vhost-user.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 00/24] qom: Convert some properties to class properties

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as it doesn't require an object to be instantiated. This series converts a few existing object_property_add*() calls to register class properties instead. Eduardo Habkost (24): cryptodev-vhost-user: Register "chardev" as class property

[PATCH 06/24] vexpress: Register "secure" as class property

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/arm/vexpress.c | 11 ++- 1 file changed, 6 insertions(+), 5 delet

[PATCH 01/24] cryptodev-vhost-user: Register "chardev" as class property

2020-09-21 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: "Gonglei (Arei)" Cc: qemu-devel@nongnu.org --- backends/cryptodev-vhost-user.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(

Re: [PATCH v2] qemu-img: Support bitmap --merge into backing image

2020-09-21 Thread Eric Blake
On 9/17/20 5:19 AM, Max Reitz wrote: temporary over NBD, referring to a bitmap that lives only in Active is less effort than having to copy a bitmap into temporary [1].  So the testsuite additions in this patch check both where bitmaps get allocated (the qemu-img info output), and, when NOT usin

Re: [PATCH 0/6] block/nvme: Map doorbells pages write-only, remove magic from nvme_init

2020-09-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200921162949.553863-1-phi...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

RE: [PATCH v3 01/15] hw/block/nvme: Define 64 bit cqe.result

2020-09-21 Thread Dmitry Fomichev
> -Original Message- > From: Keith Busch > Sent: Friday, September 18, 2020 5:10 PM > To: Klaus Jensen > Cc: Dmitry Fomichev ; Fam Zheng > ; Kevin Wolf ; Damien Le Moal > ; qemu-bl...@nongnu.org; Niklas Cassel > ; Klaus Jensen ; qemu- > de...@nongnu.org; Alistair Francis ; Philippe > Math

Re: [PATCH 0/6] block/nvme: Map doorbells pages write-only, remove magic from nvme_init

2020-09-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200921162949.553863-1-phi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200921162949.553863-1-phi...@redhat.com Subject: [PATCH 0/6] block/nvme: Map doorbells pa

[PATCH] virtiofsd: Used glib "shared" thread pool

2020-09-21 Thread Vivek Goyal
glib offers thread pools and it seems to support "exclusive" and "shared" thread pools. https://developer.gnome.org/glib/stable/glib-Thread-Pools.html#g-thread-pool-new Currently we use "exlusive" thread pools but its performance seems to be poor. I tried using "shared" thread pools and performan

Re: [PATCH] qemu/atomic.h: prefix qemu_ to solve collisions

2020-09-21 Thread Eric Blake
On 9/21/20 11:23 AM, Stefan Hajnoczi wrote: clang's C11 atomic_fetch_*() functions only take a C11 atomic type pointer argument. QEMU uses direct types (int, etc) and this causes a compiler error when a QEMU code calls these functions in a source file that also included via a system header file:

Re: [PATCH] qemu/atomic.h: prefix qemu_ to solve collisions

2020-09-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200921162346.188997-1-stefa...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200921162346.188997-1-stefa...@redhat.com Subject: [PATCH] qemu/atomic.h: prefix qemu_

Re: [PATCH v3] SEV: QMP support for Inject-Launch-Secret

2020-09-21 Thread Tobin Feldman-Fitzthum
On 2020-09-21 15:16, Dr. David Alan Gilbert wrote: * Tobin Feldman-Fitzthum (to...@linux.vnet.ibm.com) wrote: AMD SEV allows a guest owner to inject a secret blob into the memory of a virtual machine. The secret is encrypted with the SEV Transport Encryption Key and integrity is guaranteed with

Re: [PATCH 4/6] travis.yml: Drop the default softmmu builds

2020-09-21 Thread Cleber Rosa
On Fri, Sep 18, 2020 at 12:34:28PM +0200, Thomas Huth wrote: > The total runtime of all Travis jobs is very long and we are testing > all softmmu targets in the gitlab-CI already - so we can speed up the > Travis testing a little bit by not testing the softmmu targets here > anymore. > > Reviewed-

Re: [PATCH 3/6] migration: Silence compiler warning in global_state_store_running()

2020-09-21 Thread Cleber Rosa
On Fri, Sep 18, 2020 at 12:34:27PM +0200, Thomas Huth wrote: > GCC 9.3.0 on Ubuntu complains: > > In file included from /usr/include/string.h:495, > from /home/travis/build/huth/qemu/include/qemu/osdep.h:87, > from ../migration/global_state.c:13: > In function ‘st

  1   2   3   4   >