Re: [PATCH v5 09/14] hw/block/nvme: Support Zoned Namespace Command Set

2020-09-27 Thread Klaus Jensen
On Sep 28 11:35, Dmitry Fomichev wrote: > The emulation code has been changed to advertise NVM Command Set when > "zoned" device property is not set (default) and Zoned Namespace > Command Set otherwise. > > Handlers for three new NVMe commands introduced in Zoned Namespace > Command Set specifica

Re: [PATCH v4 00/14] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-09-27 Thread Klaus Jensen
On Sep 28 02:33, Dmitry Fomichev wrote: > > -Original Message- > > From: Klaus Jensen > > > > If it really needs to be memory mapped, then I think a hostmem-based > > approach similar to what Andrzej did for PMR is needed (I think that > > will get rid of the CONFIG_POSIX ifdef at least, b

Re: [PATCH] vhost: Ignore vrings in dirty log when using a vIOMMU

2020-09-27 Thread David Gibson
On Fri, Sep 25, 2020 at 07:29:43PM +0200, Greg Kurz wrote: > When a vIOMMU is present, any address comming from the guest is an IO > virtual address, including those of the vrings. The backend's accesses > to the vrings happen through vIOMMU translation : the backend hence > only logs the final gue

Re: [PATCH v2 2/6] spapr_numa: forbid asymmetrical NUMA setups

2020-09-27 Thread David Gibson
On Sun, Sep 27, 2020 at 08:41:30AM -0300, Daniel Henrique Barboza wrote: > > > On 9/26/20 4:49 AM, David Gibson wrote: > > On Fri, Sep 25, 2020 at 09:41:02AM -0300, Daniel Henrique Barboza wrote: > > > > > > > > > On 9/25/20 12:48 AM, David Gibson wrote: > > > > On Thu, Sep 24, 2020 at 04:50:54

RE: [PATCH v1 1/3] i386: Remove the limitation of IP payloads for Intel PT

2020-09-27 Thread Kang, Luwei
> >> No, it's not possible. KVM doesn't have a say on what the processor > >> writes in the tracing packets. > > Can KVM refuse to enable packet generation if CSbase is not zero and > > CPUID.(EAX=14H,ECX=0)[bit 31] seen by guest is different from host? > > Yes, but the processor could change ope

[PATCH v5 13/14] hw/block/nvme: Use zone metadata file for persistence

2020-09-27 Thread Dmitry Fomichev
A ZNS drive that is emulated by this module is currently initialized with all zones Empty upon startup. However, actual ZNS SSDs save the state and condition of all zones in their internal NVRAM in the event of power loss. When such a drive is powered up again, it closes or finishes all zones that

[PATCH v5 12/14] hw/block/nvme: Add injection of Offline/Read-Only zones

2020-09-27 Thread Dmitry Fomichev
ZNS specification defines two zone conditions for the zones that no longer can function properly, possibly because of flash wear or other internal fault. It is useful to be able to "inject" a small number of such zones for testing purposes. This commit defines two optional device properties, "offl

[PATCH v5 14/14] hw/block/nvme: Document zoned parameters in usage text

2020-09-27 Thread Dmitry Fomichev
Added brief descriptions of the new device properties that are now available to users to configure features of Zoned Namespace Command Set in the emulator. This patch is for documentation only, no functionality change. Signed-off-by: Dmitry Fomichev --- hw/block/nvme.c | 44

[PATCH v5 08/14] hw/block/nvme: Define Zoned NS Command Set trace events

2020-09-27 Thread Dmitry Fomichev
The Zoned Namespace Command Set / Namespace Types implementation that is being introduced in this series adds a good number of trace events. Combine all tracepoint definitions into a separate patch to make reviewing more convenient. Signed-off-by: Dmitry Fomichev --- hw/block/trace-events | 26 +

[PATCH v5 10/14] hw/block/nvme: Introduce max active and open zone limits

2020-09-27 Thread Dmitry Fomichev
Added two module properties, "max_active" and "max_open" to control the maximum number of zones that can be active or open. Once these variables are set to non-default values, these limits are checked during I/O and Too Many Active or Too Many Open command status is returned if they are exceeded.

[PATCH v5 04/14] hw/block/nvme: Define trace events related to NS Types

2020-09-27 Thread Dmitry Fomichev
A few trace events are defined that are relevant to implementing Namespace Types (NVMe TP 4056). Signed-off-by: Dmitry Fomichev Reviewed-by: Klaus Jensen --- hw/block/trace-events | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/block/trace-events b/hw/block/trace-events index

[PATCH v5 09/14] hw/block/nvme: Support Zoned Namespace Command Set

2020-09-27 Thread Dmitry Fomichev
The emulation code has been changed to advertise NVM Command Set when "zoned" device property is not set (default) and Zoned Namespace Command Set otherwise. Handlers for three new NVMe commands introduced in Zoned Namespace Command Set specification are added, namely for Zone Management Receive,

[PATCH v5 11/14] hw/block/nvme: Support Zone Descriptor Extensions

2020-09-27 Thread Dmitry Fomichev
Zone Descriptor Extension is a label that can be assigned to a zone. It can be set to an Empty zone and it stays assigned until the zone is reset. This commit adds a new optional module property, "zone_descr_ext_size". Its value must be a multiple of 64 bytes. If this value is non-zero, it becomes

[PATCH v5 06/14] hw/block/nvme: Add support for active/inactive namespaces

2020-09-27 Thread Dmitry Fomichev
From: Niklas Cassel In NVMe, a namespace is active if it exists and is attached to the controller. CAP.CSS (together with the I/O Command Set data structure) defines what command sets are supported by the controller. CC.CSS (together with Set Profile) can be set to enable a subset of the availa

[PATCH v5 07/14] hw/block/nvme: Make Zoned NS Command Set definitions

2020-09-27 Thread Dmitry Fomichev
Define values and structures that are needed to support Zoned Namespace Command Set (NVMe TP 4053) in PCI NVMe controller emulator. All new protocol definitions are located in include/block/nvme.h and everything added that is specific to this implementation is kept in hw/block/nvme.h. In order to

[PATCH v5 03/14] hw/block/nvme: Introduce the Namespace Types definitions

2020-09-27 Thread Dmitry Fomichev
From: Niklas Cassel Define the structures and constants required to implement Namespace Types support. Signed-off-by: Niklas Cassel Signed-off-by: Dmitry Fomichev --- hw/block/nvme-ns.h | 2 ++ hw/block/nvme.c | 2 +- include/block/nvme.h | 74 +++-

[PATCH v5 05/14] hw/block/nvme: Add support for Namespace Types

2020-09-27 Thread Dmitry Fomichev
From: Niklas Cassel Namespace Types introduce a new command set, "I/O Command Sets", that allows the host to retrieve the command sets associated with a namespace. Introduce support for the command set and enable detection for the NVM Command Set. The new workflows for identify commands rely hea

[PATCH v5 02/14] hw/block/nvme: Add Commands Supported and Effects log

2020-09-27 Thread Dmitry Fomichev
This log page becomes necessary to implement to allow checking for Zone Append command support in Zoned Namespace Command Set. This commit adds the code to report this log page for NVM Command Set only. The parts that are specific to zoned operation will be added later in the series. Signed-off-b

[PATCH v5 00/14] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-09-27 Thread Dmitry Fomichev
v4 -> v5 - Rebase to the current qemu-nvme. - Use HostMemoryBackendFile as the backing storage for persistent zone metadata. - Fix the issue with filling the valid data in the next zone if RAZBi is enabled. v3 -> v4 - Fix bugs introduced in v2/v3 for QD > 1 operation. Now, all writes

[PATCH v5 01/14] hw/block/nvme: Report actual LBA data shift in LBAF

2020-09-27 Thread Dmitry Fomichev
Calculate the data shift value to report based on the set value of logical_block_size device property. In the process, use a local variable to calculate the LBA format index instead of the hardcoded value 0. This makes the code more readable and it will make it easier to add support for multiple L

RE: [PATCH v4 00/14] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-09-27 Thread Dmitry Fomichev
> -Original Message- > From: Klaus Jensen > Sent: Thursday, September 24, 2020 5:08 PM > To: Dmitry Fomichev > Cc: Keith Busch ; Klaus Jensen > ; Kevin Wolf ; Philippe > Mathieu-Daudé ; Maxim Levitsky > ; Fam Zheng ; Niklas Cassel > ; Damien Le Moal ; > qemu-bl...@nongnu.org; qemu-devel@n

[Bug 1897481] [NEW] qemu crashes with VGA pass-through, e-GPU, nvidia 1060

2020-09-27 Thread Sergiy K
Public bug reported: I try to pass-through nvidia 1060 6gb card, which is connected via ExpressCard (EXP-GDC converter). I can successfully run my virtual machine without pass-through, but when I try to add the devices, qemu crashes. The coredump contains: Stack trace of thread 3289311: #0 0x0

Re: [PATCH] linux-user: i386: Use trapnr which returns from cpu_exec() instead of exception_index

2020-09-27 Thread Richard Henderson
On 9/26/20 3:39 AM, cheng...@emindsoft.com.cn wrote: > +++ b/include/hw/core/cpu.h > @@ -458,6 +458,8 @@ struct CPUState { > > /* track IOMMUs whose translations we've cached in the TCG TLB */ > GArray *iommu_notifiers; > + > +int trapnr; Don't put this here. It belongs in CPUX86S

[Bug 1896317] Re: ioapic: UndefinedBehaviorSanitizer starting qemu-system-i386

2020-09-27 Thread Philippe Mathieu-Daudé
I am confused... I'm certain I was on a clean directory and commit 053a4177817, but now I can't reproduce that neither. Closing as Incomplete. ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribe

[PATCH 2/2] hw/mips: Simplify code using ROUND_UP(INITRD_PAGE_SIZE)

2020-09-27 Thread Philippe Mathieu-Daudé
Instead of using a INITRD_PAGE_MASK definition, use the simpler INITRD_PAGE_SIZE one which allows us to simplify the code by using directly the self-explicit ROUND_UP() macro. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/mips/mips.h | 4 +++- hw/mips/fuloong2e.c| 3 +-- hw/mips/malta

[PATCH 1/2] hw/mips: Simplify loading 64-bit ELF kernels

2020-09-27 Thread Philippe Mathieu-Daudé
Since 82790064116 ("Cast ELF datatypes properly to host 64bit types") we don't need to sign-extend the entry_point address. Remove this unnecessary code. Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/mipssim.c | 6 +- hw/mips/r4k.c | 6 +- 2 files changed, 2 insertions(+), 10 del

[PATCH 0/2] hw/mips: Code simplifications

2020-09-27 Thread Philippe Mathieu-Daudé
Doing housekeeping on old branches older than 1 year. Some patches are still valuable, so post them. These patches should not introduce logical change, they simply rewrite old style code using more recent API/macros. Philippe Mathieu-Daudé (2): hw/mips: Simplify loading 64-bit ELF kernels hw/

Re: [PATCH] hw/mips/malta: Fix FPGA I/O region size

2020-09-27 Thread Philippe Mathieu-Daudé
On 9/5/20 11:30 PM, Philippe Mathieu-Daudé wrote: > The FPGA present on the CoreCard has an I/O region 1MiB wide. > > Refs: > - Atlas User’s Manual (Document Number: MD5) > - Malta User’s Manual (Document Number: MD00048) > > Fixes: ea85df72b60 ("mips_malta: convert to memory API") > Signed-o

Re: [PATCH v1 1/1] riscv: Convert interrupt logs to use qemu_log_mask()

2020-09-27 Thread Philippe Mathieu-Daudé
On 9/27/20 3:47 PM, Alistair Francis wrote: > Currently we log interrupts and exceptions using the trace backed in s/backed/backend/ > riscv_cpu_do_interrupt(). We also log execptions using the interrupt log Typo "exceptions". > mask (-d int) in riscv_raise_exception(). > > This PR converts ri

[Bug 1502884] Re: Super important feature req: QEMU VNC server: Introduce a keyboard "norepeat" option!

2020-09-27 Thread Marcel Partap
... this doesn't seem to be a VNC-only issue.. I get quite the big of repeat/stuck key presses with the GTK frontend as well.. Also, lines like these frequently show up in the logs: > [15512.846716] psmouse serio1: VMMouse at isa0060/serio1/input0 lost sync at > byte 1 > [15513.031586] psmouse se

Re: [PATCH v3 0/6] Add physical display dimensions to spice/virtio-gpu

2020-09-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200927145751.365446-1-marcandre.lur...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [PATCH v2 2/4] plugin: Fixes compiling errors on msys2/mingw

2020-09-27 Thread Yonggang Luo
On Sun, Sep 27, 2020 at 4:45 PM Philippe Mathieu-Daudé wrote: > > On 9/27/20 10:18 AM, Yonggang Luo wrote: > > Signed-off-by: Yonggang Luo > > Reviewed-by: Philippe Mathieu-Daudé > > --- > > contrib/plugins/hotblocks.c | 2 +- > > tests/plugin/bb.c | 4 ++-- > > 2 files changed, 3 ins

[PATCH v3 6/6] virtio-gpu: set physical dimensions for EDID

2020-09-27 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- hw/display/virtio-gpu-base.c | 2 ++ hw/display/virtio-gpu.c| 2 ++ include/hw/virtio/virtio-gpu.h | 1 + 3 files changed, 5 insertions(+) diff --git a/hw/display/virtio-gpu-base.c b/hw/display/virtio-gpu-base.c index aeb87

[PATCH v3 2/6] edid: use physical dimensions if available

2020-09-27 Thread marcandre . lureau
From: Marc-André Lureau Replace dpi with width_mm/height_mm in qemu_edid_info. Use it when set (non-zero) to compute the DPI and generate the EDID. Signed-off-by: Marc-André Lureau --- hw/display/edid-generate.c | 36 +--- include/hw/display/edid.h | 5 -

[PATCH v3 4/6] spice: remove the single monitor config logic

2020-09-27 Thread marcandre . lureau
From: Marc-André Lureau Introduced in commit 9c956e646178fee8c14ce7dfae5a9d7cb901876c ("spice: prepare for upcoming spice-server change"), the new logic never materialized in the spice server source tree. Let's remove it for now, until it actually changes in Spice. Signed-off-by: Marc-André Lure

[PATCH v3 3/6] ui: add getter for UIInfo

2020-09-27 Thread marcandre . lureau
From: Marc-André Lureau The following patch is going to introduce extra fields / details to UIInfo. Add a getter and keep the current values, instead of memset(0) Signed-off-by: Marc-André Lureau --- include/ui/console.h | 1 + ui/console.c | 7 +++ ui/spice-display.c | 2 +- 3 f

[PATCH v3 5/6] spice: get monitors physical dimension

2020-09-27 Thread marcandre . lureau
From: Marc-André Lureau With upcoming Spice server version 0.14.4, the monitor configuration can contain additional fields for the monitor physical dimensions. Signed-off-by: Marc-André Lureau --- include/ui/console.h | 3 +++ ui/spice-display.c | 7 +++ 2 files changed, 10 insertions(+)

[PATCH v3 1/6] edid: fix physical display size computation

2020-09-27 Thread marcandre . lureau
From: Marc-André Lureau Divide the resolution by the DPI, and multiply to mm. Note the computation done for edid[21/22] is correct (in cm). Signed-off-by: Marc-André Lureau --- hw/display/edid-generate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/display/edid-g

[PATCH v3 0/6] Add physical display dimensions to spice/virtio-gpu

2020-09-27 Thread marcandre . lureau
From: Marc-André Lureau Hi, This series improves the support for HiDPI displays with Spice. The related spice series have already been merged. v3: - simplify the handling of Spice monitor configuration (Frediano) v2: - add a patch to "spice: remove the single monitor config logic" (Gerd) Mar

[PULL 2/2] core/register: Specify instance_size in the TypeInfo

2020-09-27 Thread Alistair Francis
Reported-by: Eduardo Habkost Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Message-Id: <4cf1beb7dafb9143c261d266557d3173bf160524.1598376594.git.alistair.fran...@wdc.com> --- hw/core/register.c | 31 +-- 1 file changed, 13 insertions(+), 18 dele

[PATCH v1 1/1] riscv: Convert interrupt logs to use qemu_log_mask()

2020-09-27 Thread Alistair Francis
Currently we log interrupts and exceptions using the trace backed in riscv_cpu_do_interrupt(). We also log execptions using the interrupt log mask (-d int) in riscv_raise_exception(). This PR converts riscv_cpu_do_interrupt() to log both interrupts and exceptions with the interrupt log mask, so th

[PULL 0/2] register queue

2020-09-27 Thread Alistair Francis
l-register-20200927 for you to fetch changes up to e8a612b7e3cdbdface1e34a27300ca2f8521dee0: core/register: Specify instance_size in the TypeInfo (2020-09-25 16:52:24 -0700) Two small patches. One with a fix for the re

[PULL 1/2] load_elf: Remove unused address variables from callers

2020-09-27 Thread Alistair Francis
From: BALATON Zoltan Several callers of load_elf() pass pointers for lowaddr and highaddr parameters which are then not used for anything. This may stem from a misunderstanding that load_elf need a value here but in fact it can take NULL to ignore these values. Remove such unused variables and pa

Re: [RFC PATCH 0/7] block-backend: Introduce I/O hang

2020-09-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200927130420.1095-1-fangyi...@huawei.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ==

Re: [RFC PATCH 0/7] block-backend: Introduce I/O hang

2020-09-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200927130420.1095-1-fangyi...@huawei.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[RFC PATCH 7/7] qapi: add I/O hang and I/O hang timeout qapi event

2020-09-27 Thread Ying Fang
Sometimes hypervisor management tools like libvirt may need to monitor I/O hang events. Let's report I/O hang and I/O hang timeout event via qapi. Signed-off-by: Jiahui Cen Signed-off-by: Ying Fang --- block/block-backend.c | 3 +++ qapi/block-core.json | 26 ++ 2 file

[RFC PATCH 2/7] block-backend: rehandle block aios when EIO

2020-09-27 Thread Ying Fang
When a backend device temporarily does not response, like a network disk down due to some network faults, any IO to the coresponding virtual block device in VM would return I/O error. If the hypervisor returns the error to VM, the filesystem on this block device may not work as usual. And in many s

[RFC PATCH 5/7] virtio-blk: disable I/O hang when resetting

2020-09-27 Thread Ying Fang
All AIOs including the hanging AIOs need to be drained when resetting virtio-blk. So it is necessary to disable I/O hang before resetting and enable I/O hang again after resetting if I/O hang is enabled. Signed-off-by: Ying Fang Signed-off-by: Jiahui Cen --- hw/block/virtio-blk.c | 8

[RFC PATCH 1/7] block-backend: introduce I/O rehandle info

2020-09-27 Thread Ying Fang
The I/O hang feature is realized based on a rehandle mechanism. Each block backend will have a list to store hanging block AIOs, and a timer to regularly resend these aios. In order to issue the AIOs again, each block AIOs also need to store its coroutine entry. Signed-off-by: Jiahui Cen Signed-o

[RFC PATCH 3/7] block-backend: add I/O hang timeout

2020-09-27 Thread Ying Fang
Not all errors would be fixed, so it is better to add a rehandle timeout for I/O hang. Signed-off-by: Jiahui Cen Signed-off-by: Ying Fang --- block/block-backend.c | 99 +- include/sysemu/block-backend.h | 2 + 2 files changed, 100 insertions(+), 1 dele

[RFC PATCH 6/7] qemu-option: add I/O hang timeout option

2020-09-27 Thread Ying Fang
I/O hang timeout should be different under different situations. So it is better to provide an option for user to determine I/O hang timeout for each block device. Signed-off-by: Jiahui Cen Signed-off-by: Ying Fang --- blockdev.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/

[RFC PATCH 0/7] block-backend: Introduce I/O hang

2020-09-27 Thread Ying Fang
A VM in the cloud environment may use a virutal disk as the backend storage, and there are usually filesystems on the virtual block device. When backend storage is temporarily down, any I/O issued to the virtual block device will cause an error. For example, an error occurred in ext4 filesystem wou

[RFC PATCH 4/7] block-backend: add I/O hang drain when disbale

2020-09-27 Thread Ying Fang
To disable I/O hang, all hanging AIOs need to be drained. A rehandle status field is introduced to notify rehandle mechanism not to rehandle failed AIOs when I/O hang is disabled. Signed-off-by: Ying Fang Signed-off-by: Jiahui Cen --- block/block-backend.c | 85

[PATCH 11/12] tests/9pfs: add virtio_9p_test_path()

2020-09-27 Thread Christian Schoenebeck
This new public function virtio_9p_test_path() allows 9pfs 'local' tests to translate a path from guest scope to host scope. For instance by passing an empty string it would return the root path on host of the exported 9pfs tree. Signed-off-by: Christian Schoenebeck --- tests/qtest/libqos/virtio

[PATCH 10/12] tests/9pfs: wipe local 9pfs test directory

2020-09-27 Thread Christian Schoenebeck
Before running the first 9pfs test case, make sure the test directory for running the 9pfs 'local' tests on is entirely empty. For that reason simply delete the test directory (if any) before (re)creating it on test suite startup. Signed-off-by: Christian Schoenebeck --- tests/qtest/libqos/virti

[PATCH 00/12] 9pfs: add tests using local fs driver

2020-09-27 Thread Christian Schoenebeck
The currently existing 9pfs test cases are all solely using the 9pfs 'synth' fileystem driver, which is a very simple and purely simulated (in RAM only) filesystem. There are issues though where the 'synth' fs driver is not sufficient. For example the following two bugs need test cases running the

[PATCH 08/12] tests/9pfs: refactor test names and test devices

2020-09-27 Thread Christian Schoenebeck
Rename all 9pfs tests and devices they create for running their tests from 'virtio*' -> 'virtio*-synth'. In order for the tests still to work after this renaming, use the newly added function qos_node_create_driver_named() instead of qos_node_create_driver(). That new function allows to assign a n

[PATCH 03/12] tests/qtest/qos: add qos_dump_graph()

2020-09-27 Thread Christian Schoenebeck
This new function is purely for debugging purposes. It prints the current qos graph to stdout and allows to identify problems in the created qos graph e.g. when writing new qos tests. Signed-off-by: Christian Schoenebeck --- tests/qtest/libqos/qgraph.c | 54 +

[PATCH 09/12] tests/9pfs: introduce local tests

2020-09-27 Thread Christian Schoenebeck
This patch introduces 9pfs test cases using the 9pfs 'local' filesystem driver which reads/writes/creates/deletes real files and directories. In this initial version, there are only 2 local tests which actually only check if the 9pfs 'local' device was created successfully. Before the 9pfs 'local

Re: [PATCH] virtio-gpu-3d: fix abnormal display after a warm reboot

2020-09-27 Thread Guoqing Zhang
hello Gerd and Michael Michael S. Tsirkin ping http://patchwork.ozlabs.org/project/qemu-devel/list/?series=202680 On Fri, Sep 18, 2020 at 7:16 PM Guoqing Zhang < zhangguoqing.ker...@bytedance.com> wrote: > When resetting virtio-gpu, virgl_renderer_reset() should be > called to ensure that the

[PATCH 01/12] tests/qtest/qgraph: add qemu_name to QOSGraphNode

2020-09-27 Thread Christian Schoenebeck
Add new member variable 'qemu_name' to struct QOSGraphNode. This new member may be optionally set in case a different name for the node (which must always be unique) vs. its actually associated QEMU (QMP) device name is required. Signed-off-by: Christian Schoenebeck --- tests/qtest/libqos/qgrap

Re: virtiofs vs 9p performance(Re: tools/virtiofs: Multi threading seems to hurt performance)

2020-09-27 Thread Christian Schoenebeck
On Freitag, 25. September 2020 20:51:47 CEST Dr. David Alan Gilbert wrote: > * Christian Schoenebeck (qemu_...@crudebyte.com) wrote: > > On Freitag, 25. September 2020 15:05:38 CEST Dr. David Alan Gilbert wrote: > > > > > 9p ( mount -t 9p -o trans=virtio kernel /mnt > > > > > -oversion=9p2000.L,cac

[PATCH 02/12] tests/qtest/qgraph: add qos_node_create_driver_named()

2020-09-27 Thread Christian Schoenebeck
So far the qos subsystem of the qtest framework had the limitation that only one instance of the same official QEMU (QMP) driver name could be created for qtests. That's because a) the created qos node names must always be unique, b) the node name must match the official QEMU driver name being inst

[PATCH 04/12] tests/qtest/qos-test: new QTEST_DUMP_GRAPH environment variable

2020-09-27 Thread Christian Schoenebeck
Setting this new QTEST_DUMP_GRAPH environment variable causes qos-test to dump the created qos graph (all nodes and edges, along with their current individual availability status) to stdout. See API doc comment on function qos_dump_graph() for details. Signed-off-by: Christian Schoenebeck --- t

[PATCH 07/12] test/9pfs: change export tag name to qtest-synth

2020-09-27 Thread Christian Schoenebeck
All existing 9pfs test cases are using the 'synth' fs driver so far, which means they are not accessing real files, but a purely simulated (in RAM only) file system. Let's start to make this clear with this and the following patch to pave the way for upcoming new tests going to use the 9pfs 'local

[PATCH 06/12] tests/qtest/qos-test: add environment variable QTEST_DEBUG

2020-09-27 Thread Christian Schoenebeck
For now this new environment variable QTEST_DEBUG will cause the assembled qemu command line to be printed before running each test. Signed-off-by: Christian Schoenebeck --- tests/qtest/qos-test.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qtest/qos-test.c b/tests/qtest/qos-tes

[PATCH 12/12] tests/9pfs: add local Tmkdir test

2020-09-27 Thread Christian Schoenebeck
This test case uses the 9pfs 'local' driver to create a directory and then checks if the expected directory was actually created on host side. Signed-off-by: Christian Schoenebeck --- tests/qtest/virtio-9p-test.c | 140 +++ 1 file changed, 140 insertions(+) diff

[PATCH 05/12] tests/qtest/qos-test: add QTEST_DUMP_ENV environment variable

2020-09-27 Thread Christian Schoenebeck
If this new QTEST_DUMP_ENV is set, it will cause all environment variables to be dumped to stdout. Signed-off-by: Christian Schoenebeck --- tests/qtest/qos-test.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/qtest/qos-test.c b/tests/qtest/qos-test.c index db6

Re: [PATCH v2 2/6] spapr_numa: forbid asymmetrical NUMA setups

2020-09-27 Thread Daniel Henrique Barboza
On 9/26/20 4:49 AM, David Gibson wrote: On Fri, Sep 25, 2020 at 09:41:02AM -0300, Daniel Henrique Barboza wrote: On 9/25/20 12:48 AM, David Gibson wrote: On Thu, Sep 24, 2020 at 04:50:54PM -0300, Daniel Henrique Barboza wrote: The pSeries machine does not support asymmetrical NUMA configu

Re: [PATCH v4 1/1] accel/tcg: Fix computing of is_write for MIPS

2020-09-27 Thread Kele Huang
Sorry about that, I only got maintainers by './scripts/get_maintainer.pl -f accel/tcg/user-exec.c' and missed your advice about maintainers. In another words, I thought I had Cc'ed the TCG MIPS maintainers. 😅 And sorry to maintainers. 😅 On Sun, 27 Sep 2020 at 16:41, Philippe Mathieu-Daudé wrote:

[PATCH] ssi: Display chip select polarity in monitor 'info qtree'

2020-09-27 Thread Philippe Mathieu-Daudé
It is sometime useful to verify a device chip select polarity on a SPI bus. Since we have this information available, display it in the 'info qtree' monitor output: $ qemu-system-arm -M lm3s6965evb -monitor stdio -S (qemu) info qtree [...] dev: pl022, id "" gpio-out "sysbus-irq" 1

[PATCH 3/3] hw/qdev-clock: Display error hint when clock is missing from device

2020-09-27 Thread Philippe Mathieu-Daudé
Instead of directly aborting, display a hint to help the developer figure out the problem (likely trying to connect a clock to a device pre-dating the Clock API, thus not expecting clocks). Signed-off-by: Philippe Mathieu-Daudé --- hw/core/qdev-clock.c | 11 +++ 1 file changed, 11 insert

[PATCH 0/3] qdev-clock: Minor improvements to the Clock API

2020-09-27 Thread Philippe Mathieu-Daudé
Handy patches while using the Clock API: - display frequency in SI scaled unit - display error hint when device lack clock support Philippe Mathieu-Daudé (3): util/cutils: Introduce freq_to_str() to display Hertz units qdev-monitor: Display frequencies scaled to SI unit hw/qdev-clock: Displa

[PATCH 1/3] util/cutils: Introduce freq_to_str() to display Hertz units

2020-09-27 Thread Philippe Mathieu-Daudé
Introduce freq_to_str() to convert frequency values in human friendly units using the SI units for Hertz. Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/cutils.h | 12 util/cutils.c | 10 ++ 2 files changed, 22 insertions(+) diff --git a/include/qemu/cutils.

[PATCH 2/3] qdev-monitor: Display frequencies scaled to SI unit

2020-09-27 Thread Philippe Mathieu-Daudé
Since commit 9f2ff99c7f2 ("qdev-monitor: print the device's clock with info qtree") we can display the clock frequencies in the monitor. Use the recently introduced freq_to_str() to display the frequencies using the closest SI unit (human friendlier). Before: (qemu) info qtree [...] dev: xi

Re: [PATCH v2 2/4] plugin: Fixes compiling errors on msys2/mingw

2020-09-27 Thread Philippe Mathieu-Daudé
On 9/27/20 10:18 AM, Yonggang Luo wrote: > Signed-off-by: Yonggang Luo > Reviewed-by: Philippe Mathieu-Daudé > --- > contrib/plugins/hotblocks.c | 2 +- > tests/plugin/bb.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/contrib/plugins/hotblocks.c b/cont

Re: [PATCH 2/4] plugin: Fixes compiling errors on msys2/mingw

2020-09-27 Thread Philippe Mathieu-Daudé
On 9/27/20 5:18 AM, Richard Henderson wrote: > On 9/26/20 7:04 AM, Yonggang Luo wrote: >> @@ -72,7 +72,7 @@ static void vcpu_tb_exec(unsigned int cpu_index, void >> *udata) >> CPUCount *count = max_cpus ? >> g_ptr_array_index(counts, cpu_index) : &inline_count; >> >> -unsigned

Re: [PATCH v4 1/1] accel/tcg: Fix computing of is_write for MIPS

2020-09-27 Thread Philippe Mathieu-Daudé
On 9/27/20 10:20 AM, Kele Huang wrote: > Detect all MIPS store instructions in cpu_signal_handler for all available > MIPS versions, and set is_write if encountering such store instructions. > > This fixed the error while dealing with self-modified code for MIPS. > > Reviewed-by: Richard Henderso

[PATCH v4 1/1] accel/tcg: Fix computing of is_write for MIPS

2020-09-27 Thread Kele Huang
Detect all MIPS store instructions in cpu_signal_handler for all available MIPS versions, and set is_write if encountering such store instructions. This fixed the error while dealing with self-modified code for MIPS. Reviewed-by: Richard Henderson Signed-off-by: Kele Huang Signed-off-by: Xu Zou

[PATCH v2 2/4] plugin: Fixes compiling errors on msys2/mingw

2020-09-27 Thread Yonggang Luo
Signed-off-by: Yonggang Luo Reviewed-by: Philippe Mathieu-Daudé --- contrib/plugins/hotblocks.c | 2 +- tests/plugin/bb.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c index 3942a2ca54..37435a3fc7 1006

Re: [PATCH v3 1/1] accel/tcg: Fix computing of is_write for MIPS

2020-09-27 Thread Kele Huang
Fixed! I have resent a v4 patch which contains SUXC1. Thank you! On Fri, 25 Sep 2020 at 22:58, Richard Henderson < richard.hender...@linaro.org> wrote: > On 9/25/20 1:33 AM, Kele Huang wrote: > > Detect all MIPS store instructions in cpu_signal_handler for all > available > > MIPS versions, and s

[PATCH v2 1/4] plugins: Fixes a issue when dlsym failed, the handle not closed

2020-09-27 Thread Yonggang Luo
Signed-off-by: Yonggang Luo Reviewed-by: Philippe Mathieu-Daudé --- plugins/loader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/loader.c b/plugins/loader.c index 685d334e1a..8ac5dbc20f 100644 --- a/plugins/loader.c +++ b/plugins/loader.c @@ -235,6 +235,7 @@ static int plugin_loa

[PATCH v2 4/4] Getting qemu-plugin works under win32.

2020-09-27 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- Makefile | 1 - configure| 71 - contrib/plugins/hotblocks.c | 1 + contrib/plugins/hotpages.c | 1 + contrib/plugins/howvec.c | 1 + contrib/plugins/lockstep.c | 1 + include/qemu/qemu-plugin.

[PATCH v2 3/4] cirrus: Enable plugin in cirrus for windows

2020-09-27 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- .cirrus.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index 86ea33926a..5363142373 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -104,7 +104,8 @@ windows_msys2_task: - C:\tools\msys64\usr\bin\bash.exe -lc "

[PATCH v2 0/4] Enable plugin support on msys2/mingw

2020-09-27 Thread Yonggang Luo
V1-V2 1. Fixes review comments 2. Increase QEMU_PLUGIN_VERSION to 1 for compat QEMU_PLUGIN_VERSION 0 3. Revise the loader to support for version 0 and 1 4. By export function qemu_plugin_initialize in plugin, and call it in loader= , so we have no need call it in every plugin. And also provide a

RE: [PATCH] target/riscv: raise exception to HS-mode at get_physical_address

2020-09-27 Thread Jiangyifei
> -Original Message- > From: Alistair Francis [mailto:alistai...@gmail.com] > Sent: Saturday, September 26, 2020 6:24 AM > To: Jiangyifei > Cc: qemu-devel@nongnu.org Developers ; open > list:RISC-V ; Zhanghailiang > ; Sagar Karandikar > ; Bastian Koppelmann > ; Zhangxiaofeng (F) > ; Alis