Re: [PATCH 4/5] ppc405_boards: use qdev properties instead of legacy m48t59_init() function

2020-10-17 Thread Artyom Tarasenko
On Fri, Oct 16, 2020 at 10:38 PM BALATON Zoltan wrote: > > On Fri, 16 Oct 2020, Mark Cave-Ayland wrote: > > Signed-off-by: Mark Cave-Ayland > > --- > > hw/ppc/ppc405_boards.c | 10 +- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/hw/ppc/ppc405_boards.c b/hw/ppc/pp

[PULL 08/22] add ninja to dockerfiles, CI configurations and test VMs

2020-10-17 Thread Paolo Bonzini
Reviewed-by: Daniel P. Berrangé Acked-by: Alex Bennée Signed-off-by: Paolo Bonzini --- .cirrus.yml| 6 +++--- .travis.yml| 13 + tests/docker/dockerfiles/centos7.docker| 1 + tests/docker/dockerfiles/centos8.docke

[PULL v3 00/22] Build system + misc changes for 2020-10-16

2020-10-17 Thread Paolo Bonzini
The following changes since commit 3e40748834923798aa57e3751db13a069e2c617b: Merge remote-tracking branch 'remotes/rth/tags/pull-mb-20201014' into staging (2020-10-15 20:30:24 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fe

[PULL 10/22] build: replace ninjatool with ninja

2020-10-17 Thread Paolo Bonzini
Now that the build is done entirely by Meson, there is no need to keep the Makefile conversion. Instead, we can ask Ninja about the targets it exposes and forward them. The main advantages are, from smallest to largest: - reducing the possible namespace pollution within the Makefile - removal o

Re: io_uring possibly the culprit for qemu hang (linux-5.4.y)

2020-10-17 Thread Jens Axboe
On 10/17/20 8:29 AM, Ju Hyung Park wrote: > Hi Jens. > > On Sat, Oct 17, 2020 at 3:07 AM Jens Axboe wrote: >> >> Would be great if you could try 5.4.71 and see if that helps for your >> issue. >> > > Oh wow, yeah it did fix the issue. > > I'm able to reliably turn off and start the VM multiple

Re: [PULL v2 00/22] Build system + misc changes for 2020-10-16

2020-10-17 Thread Paolo Bonzini
On 17/10/20 16:39, Peter Maydell wrote: > On Sat, 17 Oct 2020 at 14:38, Paolo Bonzini wrote: >> OpenBSD and NetBSD call the ninja package "ninja-build" unlike FreeBSD. >> I'm sure I had used the right name but well I didn't. I'll send a v3. > > OpenBSD built OK but meson produces this new warni

[PATCH v9] mac_oldworld: Allow loading binary ROM image

2020-10-17 Thread BALATON Zoltan via
The beige G3 Power Macintosh has a 4MB firmware ROM. Fix the size of the rom region and fall back to loading a binary image with -bios if loading ELF image failed. This allows testing emulation with a ROM image from real hardware as well as using an ELF OpenBIOS image. Signed-off-by: BALATON Zolta

Re: [PATCH v8 0/5] Mac Old World ROM experiment (ppc/mac_* clean ups and loading binary ROM)

2020-10-17 Thread BALATON Zoltan via
On Sat, 17 Oct 2020, Mark Cave-Ayland wrote: On 16/10/2020 13:19, BALATON Zoltan via wrote: On Fri, 16 Oct 2020, Mark Cave-Ayland wrote: On 16/10/2020 00:47, BALATON Zoltan via wrote: This is the cut down version of the earlier series omitting unfinished patches that I plan to rework later and

Re: [PATCH V14 7/8] hw/mips: Add Loongson-3 machine support

2020-10-17 Thread Philippe Mathieu-Daudé
On 10/16/20 8:51 AM, Huacai Chen wrote: Add Loongson-3 based machine support, it use liointc as the interrupt controler and use GPEX as the pci controller. Currently it can work with both TCG and KVM. As the machine model is not based on any exiting physical hardware, the name of the machine is

Re: [PATCH v9] mac_oldworld: Allow loading binary ROM image

2020-10-17 Thread Philippe Mathieu-Daudé
+Alistair for loader On 10/17/20 5:47 PM, BALATON Zoltan via wrote: The beige G3 Power Macintosh has a 4MB firmware ROM. Fix the size of the rom region and fall back to loading a binary image with -bios if loading ELF image failed. This allows testing emulation with a ROM image from real hardwar

Re: [PULL v2 00/22] Build system + misc changes for 2020-10-16

2020-10-17 Thread Yonggang Luo
On Sat, Oct 17, 2020 at 11:37 PM Paolo Bonzini wrote: > > On 17/10/20 16:39, Peter Maydell wrote: > > On Sat, 17 Oct 2020 at 14:38, Paolo Bonzini wrote: > >> OpenBSD and NetBSD call the ninja package "ninja-build" unlike FreeBSD. > >> I'm sure I had used the right name but well I didn't. I'll s

Re: [PATCH v9] mac_oldworld: Allow loading binary ROM image

2020-10-17 Thread BALATON Zoltan via
On Sat, 17 Oct 2020, Philippe Mathieu-Daudé wrote: +Alistair for loader On 10/17/20 5:47 PM, BALATON Zoltan via wrote: The beige G3 Power Macintosh has a 4MB firmware ROM. Fix the size of the rom region and fall back to loading a binary image with -bios if loading ELF image failed. This allows

Re: [PULL v2 00/22] Build system + misc changes for 2020-10-16

2020-10-17 Thread Paolo Bonzini
On 17/10/20 17:37, Paolo Bonzini wrote: > On 17/10/20 16:39, Peter Maydell wrote: >> Library iconv found: NO >> ../src/meson.build:531: WARNING: iconv required for curses UI but not >> available, disabling > > I'm not sure if that will remove the warning or not, but I'll check (and > if it does re

Re: [PATCH v8 0/5] Mac Old World ROM experiment (ppc/mac_* clean ups and loading binary ROM)

2020-10-17 Thread BALATON Zoltan via
On Fri, 16 Oct 2020, Philippe Mathieu-Daudé wrote: On 10/16/20 11:58 AM, Mark Cave-Ayland wrote: On 16/10/2020 00:47, BALATON Zoltan via wrote: This is the cut down version of the earlier series omitting unfinished patches that I plan to rework later and rebased to Mark's qemu-macppc branch. C

[PATCH v11] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-17 Thread Yonggang Luo
The sh script are harder to maintain for compatible different xsh environment so convert it to python script Also incorporate the fixes in https://patchew.org/QEMU/20200929143654.518157-1-marcandre.lur...@redhat.com/ According to https://github.com/msys2/MSYS2-packages/issues/2176 We need use CYGW

Re: [PATCH v11] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-17 Thread Yonggang Luo
On Sun, Oct 18, 2020 at 12:43 AM Yonggang Luo wrote: > > The sh script are harder to maintain for compatible different > xsh environment so convert it to python script > Also incorporate the fixes in > https://patchew.org/QEMU/20200929143654.518157-1-marcandre.lur...@redhat.com/ > > According to h

Re: [PATCH v11] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-17 Thread Paolo Bonzini
Il sab 17 ott 2020, 18:43 Yonggang Luo ha scritto: > The sh script are harder to maintain for compatible different > xsh environment so convert it to python script > Also incorporate the fixes in > > https://patchew.org/QEMU/20200929143654.518157-1-marcandre.lur...@redhat.com/ > > According to ht

Re: [PATCH v9] mac_oldworld: Allow loading binary ROM image

2020-10-17 Thread Philippe Mathieu-Daudé
On 10/17/20 6:31 PM, BALATON Zoltan via wrote: On Sat, 17 Oct 2020, Philippe Mathieu-Daudé wrote: +Alistair for loader On 10/17/20 5:47 PM, BALATON Zoltan via wrote: The beige G3 Power Macintosh has a 4MB firmware ROM. Fix the size of the rom region and fall back to loading a binary image with

Re: [PATCH v8 0/5] Mac Old World ROM experiment (ppc/mac_* clean ups and loading binary ROM)

2020-10-17 Thread Philippe Mathieu-Daudé
On 10/17/20 6:39 PM, BALATON Zoltan via wrote: On Fri, 16 Oct 2020, Philippe Mathieu-Daudé wrote: On 10/16/20 11:58 AM, Mark Cave-Ayland wrote: On 16/10/2020 00:47, BALATON Zoltan via wrote: This is the cut down version of the earlier series omitting unfinished patches that I plan to rewor

Re: [PULL 25/33] tests/acceptance: Add a test for the N800 and N810 arm machines

2020-10-17 Thread Philippe Mathieu-Daudé
Hi Peter, Igor, Thomas, On 2/28/20 5:38 PM, Peter Maydell wrote: From: Thomas Huth Old kernels from the Meego project can be used to check that Linux is at least starting on these machines. Signed-off-by: Thomas Huth Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Philippe Mathieu-Dau

[Bug 1874504] Re: VFIO passthrough spits out thousands of messages

2020-10-17 Thread Artyom Tarasenko
Is this a regression? Can you please bisect to the first commit where it happened? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1874504 Title: VFIO passthrough spits out thousands of messages Sta

[PATCH 1/2] hw/intc/bcm2835_ic: Trace GPU/CPU IRQ handlers

2020-10-17 Thread Philippe Mathieu-Daudé
Add trace events for GPU and CPU IRQs. Reviewed-by: Luc Michel Signed-off-by: Philippe Mathieu-Daudé --- hw/intc/bcm2835_ic.c | 4 +++- hw/intc/trace-events | 4 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/intc/bcm2835_ic.c b/hw/intc/bcm2835_ic.c index 53ab8f58810..900

[PATCH 0/2] hw/intc/bcm283x: Trivial tracing cleanup

2020-10-17 Thread Philippe Mathieu-Daudé
Add trace event for IRQ from CPU/GPU, use definitions for IRQ numbers. Philippe Mathieu-Daudé (2): hw/intc/bcm2835_ic: Trace GPU/CPU IRQ handlers hw/intc/bcm2836_control: Use IRQ definitions instead of magic numbers hw/intc/bcm2835_ic.c | 4 +++- hw/intc/bcm2836_control.c | 8

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-17 Thread Catangiu, Adrian Costin
After discussing this offline with Jann a bit, I have a few general comments on the design of this. First, the UUID communicated by the hypervisor should be consumed by the kernel -- added as another input to the rng -- and then userspace should be notified that it should resee

[PATCH 2/2] hw/intc/bcm2836_control: Use IRQ definitions instead of magic numbers

2020-10-17 Thread Philippe Mathieu-Daudé
The IRQ values are defined few lines earlier, use them instead of the magic numbers. Signed-off-by: Philippe Mathieu-Daudé --- hw/intc/bcm2836_control.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/intc/bcm2836_control.c b/hw/intc/bcm2836_control.c index 53dba00

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-17 Thread Andy Lutomirski
On Fri, Oct 16, 2020 at 6:40 PM Jann Horn wrote: > > [adding some more people who are interested in RNG stuff: Andy, Jason, > Theodore, Willy Tarreau, Eric Biggers. also linux-api@, because this > concerns some pretty fundamental API stuff related to RNG usage] > > On Fri, Oct 16, 2020 at 4:33 PM

Re: [PATCH v2 0/6] hw/sd/sdcard: Do not attempt to erase out of range addresses

2020-10-17 Thread Alexander Bulekov
On 201015 0838, Philippe Mathieu-Daudé wrote: > Yet another bug in the sdcard model found by libfuzzer: > https://bugs.launchpad.net/bugs/1895310 > > Since RFC: Settled migration issue > > Philippe Mathieu-Daudé (6): > hw/sd/sdcard: Add trace event for ERASE command (CMD38) > hw/sd/sdcard: In

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-17 Thread Alexander Graf
Hi Jason, On 17.10.20 15:24, Jason A. Donenfeld wrote: After discussing this offline with Jann a bit, I have a few general comments on the design of this. First, the UUID communicated by the hypervisor should be consumed by the kernel -- added as another input to the rng -- and then userspace

Re: [PULL v2 00/22] Build system + misc changes for 2020-10-16

2020-10-17 Thread Peter Maydell
On Sat, 17 Oct 2020 at 17:37, Paolo Bonzini wrote: > Ok, so the warning remains when everything is fixed, though the text is > slightly different (and better): > > Library iconv found: NO > Run-time dependency ncursesw found: NO (tried pkgconfig) > Library ncursesw found: YES > Library cur

Re: [PATCH v26 04/17] vfio: Add migration region initialization and finalize function

2020-10-17 Thread Kirti Wankhede
On 9/24/2020 7:38 PM, Cornelia Huck wrote: On Wed, 23 Sep 2020 04:54:06 +0530 Kirti Wankhede wrote: Whether the VFIO device supports migration or not is decided based of migration region query. If migration region query is successful and migration region initialization is successful then mi

Re: [PATCH v26 04/17] vfio: Add migration region initialization and finalize function

2020-10-17 Thread Kirti Wankhede
On 9/26/2020 1:50 AM, Alex Williamson wrote: On Wed, 23 Sep 2020 04:54:06 +0530 Kirti Wankhede wrote: Whether the VFIO device supports migration or not is decided based of migration region query. If migration region query is successful and migration region initialization is successful then

Re: [PATCH v26 05/17] vfio: Add VM state change handler to know state of VM

2020-10-17 Thread Kirti Wankhede
On 9/29/2020 4:33 PM, Dr. David Alan Gilbert wrote: * Cornelia Huck (coh...@redhat.com) wrote: On Wed, 23 Sep 2020 04:54:07 +0530 Kirti Wankhede wrote: VM state change handler gets called on change in VM's state. This is used to set VFIO device state to _RUNNING. Signed-off-by: Kirti Wank

Re: [PATCH v26 05/17] vfio: Add VM state change handler to know state of VM

2020-10-17 Thread Kirti Wankhede
On 9/26/2020 1:50 AM, Alex Williamson wrote: On Wed, 23 Sep 2020 04:54:07 +0530 Kirti Wankhede wrote: VM state change handler gets called on change in VM's state. This is used to set VFIO device state to _RUNNING. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia Reviewed-by: Dr. David

Re: [PATCH v26 06/17] vfio: Add migration state change notifier

2020-10-17 Thread Kirti Wankhede
On 9/26/2020 1:50 AM, Alex Williamson wrote: On Wed, 23 Sep 2020 04:54:08 +0530 Kirti Wankhede wrote: Added migration state change notifier to get notification on migration state change. These states are translated to VFIO device state and conveyed to vendor driver. Signed-off-by: Kirti Wa

[PATCH 5/6] ppc405_boards: use qdev instead of legacy m48t59_init() function

2020-10-17 Thread BALATON Zoltan via
Signed-off-by: BALATON Zoltan --- hw/ppc/ppc405_boards.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/ppc405_boards.c b/hw/ppc/ppc405_boards.c index 6198ec1035..7a11a38831 100644 --- a/hw/ppc/ppc405_boards.c +++ b/hw/ppc/ppc405_boards.c @@ -28,6 +28,7 @@ #include

[PATCH 2/6] mt48t59: Set default value of base-year property to 1968

2020-10-17 Thread BALATON Zoltan via
All instances set this value explicitely so make it the default to make it simpler to create instances without setting property. Signed-off-by: BALATON Zoltan --- hw/rtc/m48t59.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rtc/m48t59.c b/hw/rtc/m48t59.c index 652520697

[PATCH 4/6] sun4u: use qdev instead of legacy m48t59_init() function

2020-10-17 Thread BALATON Zoltan via
Signed-off-by: BALATON Zoltan --- hw/sparc64/sun4u.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index ad5ca2472a..a89ebed6f0 100644 --- a/hw/sparc64/sun4u.c +++ b/hw/sparc64/sun4u.c @@ -671,10 +671,12 @@ static void sun4uv_ini

Re: [PATCH v26 07/17] vfio: Register SaveVMHandlers for VFIO device

2020-10-17 Thread Kirti Wankhede
On 9/29/2020 3:49 PM, Dr. David Alan Gilbert wrote: * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: On 9/23/20 1:24 AM, Kirti Wankhede wrote: Define flags to be used as delimeter in migration file stream. Typo "delimiter". Added .save_setup and .save_cleanup functions. Mapped & unma

[PATCH 1/6] m48t59-isa: remove legacy m48t59_init_isa() function

2020-10-17 Thread BALATON Zoltan via
From: Mark Cave-Ayland This function is no longer used within the codebase. Signed-off-by: Mark Cave-Ayland Reviewed-by: Hervé Poussineau Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- hw/rtc/m48t59-isa.c | 25 - include/hw/rtc/m48t59.h

[PATCH 6/6] m48t59: remove legacy m48t59_init() function

2020-10-17 Thread BALATON Zoltan via
From: Mark Cave-Ayland Now that all of the callers of this function have been switched to use qdev properties, this legacy init function can now be removed. Signed-off-by: Mark Cave-Ayland Reviewed-by: Hervé Poussineau Reviewed-by: Philippe Mathieu-Daudé --- hw/rtc/m48t59.c | 35

[PATCH 0/6] m48t59: remove legacy init functions

2020-10-17 Thread BALATON Zoltan via
This is inspired by Mark's series: https://lists.nongnu.org/archive/html/qemu-ppc/2020-10/msg00251.html and implements what I've suggested in review of that series to simplify it and avoid code churn if implementing my suggestion later. Regards, BALATON Zoltan BALATON Zoltan (4): mt48t59: Set

[PATCH 3/6] sun4m: use qdev instead of legacy m48t59_init() function

2020-10-17 Thread BALATON Zoltan via
Also declare nvram variable with the correct type. Signed-off-by: BALATON Zoltan --- hw/sparc/sun4m.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c index 54a2b2f9ef..7f1a48440c 100644 --- a/hw/sparc/sun4m.c +++ b/hw/sparc/sun4m.c @@

[PATCH] accel/kvm: add PIO ioeventfds only in case kvm_eventfds_allowed is true

2020-10-17 Thread Elena Afanasova
Signed-off-by: Stefan Hajnoczi Signed-off-by: Elena Afanasova --- accel/kvm/kvm-all.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 9ef5daf4c5..baaa54249d 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -22

[PATCH] softmmu/memory: fix memory_region_ioeventfd_equal()

2020-10-17 Thread Elena Afanasova
Eventfd can be registered with a zero length when fast_mmio is true. Handle this case properly when dispatching through QEMU. Signed-off-by: Elena Afanasova --- softmmu/memory.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/softmmu/memory.c b/softmmu/memory

Re: [PATCH v9] mac_oldworld: Allow loading binary ROM image

2020-10-17 Thread BALATON Zoltan via
On Sat, 17 Oct 2020, Philippe Mathieu-Daudé wrote: On 10/17/20 6:31 PM, BALATON Zoltan via wrote: On Sat, 17 Oct 2020, Philippe Mathieu-Daudé wrote: +Alistair for loader On 10/17/20 5:47 PM, BALATON Zoltan via wrote: The beige G3 Power Macintosh has a 4MB firmware ROM. Fix the size of the rom

Re: [PATCH v26 05/17] vfio: Add VM state change handler to know state of VM

2020-10-17 Thread Alex Williamson
On Sun, 18 Oct 2020 02:00:44 +0530 Kirti Wankhede wrote: > On 9/26/2020 1:50 AM, Alex Williamson wrote: > > On Wed, 23 Sep 2020 04:54:07 +0530 > > Kirti Wankhede wrote: > > > >> VM state change handler gets called on change in VM's state. This is used > >> to set > >> VFIO device state to _R

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-17 Thread Jann Horn
On Sat, Oct 17, 2020 at 8:09 PM Alexander Graf wrote: > There are applications way beyond that though. What do you do with > applications that already consumed randomness? For example a cached pool > of SSL keys. Or a higher level language primitive that consumes > randomness and caches its seed s

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-17 Thread Colm MacCarthaigh
On 17 Oct 2020, at 6:24, Jason A. Donenfeld wrote: There are a few design goals of notifying userspace: it should be fast, because people who are using userspace RNGs are usually doing so in the first place to completely avoid syscall overhead for whatever high performance application they ha

[PATCH] qemu-img: add support for offline rate limit in qemu-img commit

2020-10-17 Thread Zhengui li
From: Zhengui Currently, there is no rate limit for qemu-img commit. This may cause the task of qemu-img commit to consume all the bandwidth of the storage. This will affect the IO performance of other processes and virtual machines under shared storage. So we add support for offline rate limit i

[PATCH] qemu-img: add support for rate limit in qemu-img convert

2020-10-17 Thread Zhengui li
From: Zhengui Currently, there is no rate limit for qemu-img convert. This may cause the task of qemu-img convert to consume all the bandwidth of the storage. This will affect the IO performance of other processes and virtual machines under shared storage. So we add support for offline rate limit

Re: [PATCH] qemu-img: add support for offline rate limit in qemu-img commit

2020-10-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1602999097-24744-1-git-send-email-lizhen...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1602999097-24744-1-git-send-email-lizhen...@huawei.com Subject: [PATCH] qemu-

Re: [PATCH] qemu-img: add support for rate limit in qemu-img convert

2020-10-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1602999390-21324-1-git-send-email-lizhen...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1602999390-21324-1-git-send-email-lizhen...@huawei.com Subject: [PATCH] qemu-

[PATCH] qemu-img: add support for rate limit in qemu-img commit

2020-10-17 Thread Zhengui li
From: Zhengui Currently, there is no rate limit for qemu-img commit. This may cause the task of qemu-img commit to consume all the bandwidth of the storage. This will affect the IO performance of other processes and virtual machines under shared storage. So we add support for offline rate limit i

[PATCH] qemu-img: add support for rate limit in qemu-img convert

2020-10-17 Thread Zhengui li
From: Zhengui Currently, there is no rate limit for qemu-img convert. This may cause the task of qemu-img convert to consume all the bandwidth of the storage. This will affect the IO performance of other processes and virtual machines under shared storage. So we add support for offline rate limit

<    1   2