On Mon, Oct 26, 2020 at 10:27:54AM -0600, Bruce Rogers wrote:
> On Mon, 2020-10-19 at 09:52 +0200, Gerd Hoffmann wrote:
> > - Add QemuSpiceOps, reorganize spice stubs.
> > - Add support for module dependencies.
> > - Build spice-core modular, and make the existing spice
> > modules (audio,
On 27/10/2020 06.05, Eric Blake wrote:
> Anywhere we create a list of just one item or by prepending items
> (typically because order doesn't matter), we can use the now-public
> macro. But places where we must keep the list in order by appending
> remain open-coded.
>
> Signed-off-by: Eric
On 26/10/2020 20.51, John Snow wrote:
> There's no reason to keep this here; the versions described are
> ancient. Everything here is still mirrored on
> https://wiki.qemu.org/ChangeLog/old if anyone is curious; otherwise, use
> the git history.
>
> Signed-off-by: John Snow
> ---
>
> V2: Add
tests/vm: update openbsd to release 6.8
A double dash at the end of a package name removes ambiguity
when the intent is to install a non-FLAVORed package.
Signed-off-by: Brad Smith
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daud??
diff --git
Anywhere we create a list of just one item or by prepending items
(typically because order doesn't matter), we can use the now-public
macro. But places where we must keep the list in order by appending
remain open-coded.
Signed-off-by: Eric Blake
---
docs/devel/writing-qmp-commands.txt | 13
'qemu-img map' provides a way to determine which extents of an image
come from the top layer vs. inherited from a backing chain. This is
useful information worth exposing over NBD. There is a proposal to
add a QMP command block-dirty-bitmap-populate which can create a dirty
bitmap that reflects
Allow the server to expose an additional metacontext to be requested
by savvy clients. qemu-nbd adds a new option -A to expose the
qemu:allocation-depth metacontext through NBD_CMD_BLOCK_STATUS; this
can also be set via QMP when using block-export-add.
qemu as client is hacked into viewing the
Each dirty bitmap already knows its name; by reducing the scope of the
places where we construct "qemu:dirty-bitmap:NAME" strings, tracking
the name is more localized, and there are fewer per-export fields to
worry about. This in turn will make it easier for an upcoming patch
to export more than
Since 'block-export-add' is new to 5.2, we can still tweak the
interface; there, allowing 'bitmaps':['str'] is nicer than
'bitmap':'str'. This wires up the qapi and qemu-nbd changes to permit
passing multiple bitmaps as distinct metadata contexts that the NBD
client may request, but the actual
When checking for allocation across a chain, it's already easy to
count the depth within the chain at which the allocation is found.
Instead of throwing that information away, return it to the caller.
Existing callers only cared about allocated/non-allocated, but having
a depth available will be
With this, 'qemu-nbd -B b0 -B b1 -f qcow2 img.qcow2' can let you sniff
out multiple bitmaps from one server. qemu-img as client can still
only read one bitmap per client connection, but other NBD clients
(hello libnbd) can now read multiple bitmaps in a single pass.
Signed-off-by: Eric Blake
Rather than open-coding the translation from the deprecated
NbdServerAddOptions type to the preferred BlockExportOptionsNbd, it's
better to utilize QAPI_CLONE_MEMBERS. This solves a couple of issues:
first, if we do any more refactoring of the base type (which an
upcoming patch plans to do), we
Rather than open-code the count of negotiated contexts at several
sites, embed it directly into the struct. This will make it easier
for upcoming commits to support even more simultaneous contexts.
Signed-off-by: Eric Blake
---
nbd/server.c | 26 +++---
1 file changed, 15
v5 was here:
https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg07124.html
Also available at:
https://repo.or.cz/qemu/ericb.git/shortlog/refs/tags/nbd-alloc-depth-v6
Since v5:
- rebase to master (mostly affects 8/11) [Vladimir]
- drop v5 1/12, and replace with new v6 1/11 [Markus]
-
We have a useful macro for inserting at the front of any
QAPI-generated list; move it from block.c to qapi/util.h so more
places can use it, including one earlier place in block.c.
There are many more places in the codebase that can benefit from using
the macro, but converting them will be left
There is no need to rely on the verbosity of the gcc/clang compiler
extension of g_new(typeof(X), 1) when we can instead use the standard
g_malloc(sizeof(X)). In general, we like g_new over g_malloc for
returning type X rather than void* to let the compiler catch more
potential typing mistakes,
hi paolo,
>So removing flatview_simplify() works because the higher area (0x1
>and above) remains the same. I guess the simplest thing to do is to
>apply flatview_simplify() only to I/O areas, though we can also consider
>removing it completely. I'm not sure in which case it would provide a
- Original Message -
> Hi jason
>
>
> On Mon, Oct 26, 2020 at 11:20 AM Jason Wang wrote:
>
> >
> > On 2020/10/26 上午10:43, Jason Wang wrote:
> > >
> > > On 2020/10/23 下午5:15, Cindy Lu wrote:
> > >> Sometime vdpa get an all 0 mac address from the hardware, this will
> > >> cause the
On Fri, Oct 09, 2020 at 02:44:37PM +0800, zhaolichang wrote:
> I found that there are many spelling errors in the comments of
> qemu/target/ppc.
> I used spellcheck to check the spelling errors and found some errors in the
> folder.
>
> Signed-off-by: zhaolichang
> Reviewed-by: David Edmondson
On Mon, Oct 26, 2020 at 01:40:54PM +0100, Greg Kurz wrote:
> spapr_reallocate_hpt() has three users, two of which pass _fatal
> and the third one, htab_load(), passes _err, uses it to detect
> failures and simply propagates -EINVAL up to vmstate_load(), which will
> cause QEMU to exit. It is thus
On Mon, Oct 26, 2020 at 10:30:23AM -0400, Paolo Bonzini wrote:
> Cc: David Gibson
> Signed-off-by: Paolo Bonzini
Acked-by: David Gibson
> ---
> hw/ppc/e500.c | 4 ++--
> hw/ppc/mac_newworld.c | 4 +---
> hw/ppc/mac_oldworld.c | 4 +---
> hw/ppc/pnv.c | 5 +
>
On Mon, Oct 26, 2020 at 10:14:00AM +0100, Thomas Huth wrote:
> On 09/10/2020 08.44, zhaolichang wrote:
> > I found that there are many spelling errors in the comments of
> > qemu/target/ppc.
> > I used spellcheck to check the spelling errors and found some errors in the
> > folder.
> >
> >
On Mon, Oct 26, 2020 at 01:40:47PM +0100, Greg Kurz wrote:
> If kvmppc_load_htab_chunk() fails, its return value is propagated up
> to vmstate_load(). It should thus be a negative errno, not -1 (which
> maps to EPERM and would lure the user into thinking that the problem
> is necessarily related
On Mon, Oct 26, 2020 at 03:46:47PM +0100, Greg Kurz wrote:
> On Mon, 26 Oct 2020 14:43:08 +0100
> Philippe Mathieu-Daudé wrote:
>
> > On 10/26/20 1:40 PM, Greg Kurz wrote:
> > > qemu_memalign() aborts if OOM. Drop some dead code.
> > >
> > > Signed-off-by: Greg Kurz
> > > ---
> > >
On Mon, Oct 26, 2020 at 01:40:40PM +0100, Greg Kurz wrote:
> Hints should be added with the dedicated error_append_hint() API
> because we don't want to print them when using QMP. This requires
> to insert ERRP_GUARD as explained in "qapi/error.h".
>
> Signed-off-by: Greg Kurz
Applied to
Included the newly implemented SBSA generic watchdog device model into
SBSA platform
Signed-off-by: Shashi Mallela
Reviewed-by: Peter Maydell
---
hw/arm/sbsa-ref.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
index
Generic watchdog device model implementation as per ARM SBSA v6.0
Signed-off-by: Shashi Mallela
---
hw/arm/Kconfig | 1 +
hw/watchdog/Kconfig | 3 +
hw/watchdog/meson.build | 1 +
hw/watchdog/sbsa_gwdt.c | 293
This patch series adds watchdog timer support for SbsaQemu platform.
The watchdog timer has been implemented first based on the generic
watchdog timer specifications from ARM SBSA v6.0 and then used
in the SbsaQemu reference platform
Changes in v8:
- cleared irq also along with ws0 clear on
Prior to 2a4b472c3c, sys/signal.h was only included on OpenBSD
(apart from two .c files). The POSIX standard location for this
header is just and in fact, OpenBSD's signal.h includes
sys/signal.h itself.
Unconditionally including on musl causes warnings
for just about every source file:
On Mon, Oct 26, 2020 at 11:43:36PM +0100, Philippe Mathieu-Daudé wrote:
> Cc'ing avocado-devel@
>
> On 10/26/20 11:35 PM, Peter Maydell wrote:
> > So, I somehow ended up with this process still running on my
> > local machine after a (probably failed) 'make check-acceptance':
> >
> > petmay01
From: Lichang Zhao
There are many spelling errors in the comments of target/sh4.
Use spellcheck to check the spelling errors, then fix them.
Signed-off-by: zhaolichang
Reviewed-by: David Edmondson
Reviewed-by: Philippe Mathieu-Daude
Message-Id: <20201009064449.2336-10-zhaolich...@huawei.com>
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Reviewed-by:
From: Thomas Huth
Replace TAB characters with spaces, put code after case-statement on
separate lines and add some curly braces in related lines to keep
checkpatch.pl happy.
Signed-off-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id:
Avoid checkpatch.pl warnings in the next commit.
Signed-off-by: Philippe Mathieu-Daudé
---
target/sh4/op_helper.c | 8 +---
target/sh4/translate.c | 8 +---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/target/sh4/op_helper.c b/target/sh4/op_helper.c
index
From: Lichang Zhao
There are many spelling errors in the comments of target/rx.
Use spellcheck to check the spelling errors, then fix them.
Signed-off-by: zhaolichang
Reviewed-by: David Edmondson
Reviewed-by: Philippe Mathieu-Daude
Message-Id: <20201009064449.2336-5-zhaolich...@huawei.com>
From: Thomas Huth
hw_error() is marked as QEMU_NORETURN, so the "break" statements
after this function are just dead code.
Signed-off-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20201020153935.54315-4-th...@redhat.com>
Signed-off-by:
The following changes since commit 1dc887329a10903940501b43e8c0cc67af7c06d5:
Merge remote-tracking branch 'remotes/philmd-gitlab/tags/sd-next-20201026' =
into staging (2020-10-26 17:19:26 +)
are available in the Git repository at:
https://gitlab.com/philmd/qemu.git tags/renesas-20201027
From: Yoshinori Sato
RX's ELF machine is not defined in "elf.h".
Added it.
Signed-off-by: Yoshinori Sato
Reviewed-by: Richard Henderson
Message-Id: <20200814131438.28406-1-ys...@users.sourceforge.jp>
Signed-off-by: Philippe Mathieu-Daudé
---
include/elf.h | 2 ++
1 file changed, 2
From: Thomas Huth
When compiling with -Werror=implicit-fallthrough, gcc complains about
missing fallthrough annotations in this file. Looking at the code,
the fallthrough is very likely intended here, so add some comments
to silence the compiler warnings.
Fixes: cd1a3f6840e ("Stand-alone TMU
Cc'ing avocado-devel@
On 10/26/20 11:35 PM, Peter Maydell wrote:
So, I somehow ended up with this process still running on my
local machine after a (probably failed) 'make check-acceptance':
petmay01 13710 99.7 3.7 2313448 1235780 pts/16 Sl 16:10 378:00
./qemu-system-aarch64 -display none
So, I somehow ended up with this process still running on my
local machine after a (probably failed) 'make check-acceptance':
petmay01 13710 99.7 3.7 2313448 1235780 pts/16 Sl 16:10 378:00
./qemu-system-aarch64 -display none -vga none -chardev
t;
> are available in the Git repository at:
>
> https://gitlab.com/philmd/qemu.git tags/sd-next-20201026
>
> for you to fetch changes up to 89c6700fe7eed9195f10055751edbc6d5e7ab940:
>
> hw/sd/sdcard: Zero out function selection fields before being p
On 10/23/20 2:38 PM, Chetan Pant wrote:
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by:
On 8/14/20 3:14 PM, Yoshinori Sato wrote:
RX's ELF machine not defined elf.h.
Added it.
Signed-off-by: Yoshinori Sato
---
include/elf.h | 2 ++
1 file changed, 2 insertions(+)
Thanks, applied to renesas-next.
On 10/9/20 8:44 AM, zhaolichang wrote:
I found that there are many spelling errors in the comments of qemu/target/rx.
I used spellcheck to check the spelling errors and found some errors in the
folder.
Signed-off-by: zhaolichang
Reviewed-by: David Edmondson
Reviewed-by: Philippe
Some devices expose GPIO lines.
Add a GPIO qdev input to our LED device, so we can
connect a GPIO output using qdev_connect_gpio_out().
When used with GPIOs, the intensity can only be either
minium or maximum. This depends of the polarity of the
GPIO (which can be inverted).
Declare the
On Mon, 26 Oct 2020 at 15:13, Paolo Bonzini wrote:
> This one seems okay because the union constrains the size to 4K. If
> "[0]" is enough to shut up the compiler, I'd say do that.
Do you mean converting a C flexible array member (declared as
"foo[]") into a gcc zero-length array (declared as
The recently added LED device reports LED status changes with
the 'led_set_intensity' trace event. It is less invasive than
the fprintf() calls. We need however to have a binary built
with tracing support.
Reviewed-by: Luc Michel
Reviewed-by: Richard Henderson
Signed-off-by: Philippe
Add a LED device which can be connected to a GPIO output.
They can also be dimmed with PWM devices. For now we do
not implement the dimmed mode, but in preparation of a
future implementation, we start using the LED intensity.
LEDs are limited to a fixed set of colors.
Reviewed-by: Luc Michel
Per the 'ARM MPS2 and MPS2+ FPGA Prototyping Boards Technical
Reference Manual' (100112_0200_07_en):
2.1 Overview of the MPS2 and MPS2+ hardware
The MPS2 and MPS2+ FPGA Prototyping Boards contain the
following components and interfaces:
* User switches and user LEDs:
Track the LED intensity, and emit a trace event when it changes.
Reviewed-by: Richard Henderson
Reviewed-by: Luc Michel
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20200912134041.946260-4-f4...@amsat.org>
---
hw/misc/led.c| 4
hw/misc/trace-events | 1 +
2 files changed, 5
The Witherspoon has 3 LEDs connected to a PCA9552. Add them.
The names and reset values are taken from:
https://github.com/open-power/witherspoon-xml/blob/master/witherspoon.xml
Example booting obmc-phosphor-image:
$ qemu-system-arm -M witherspoon-bmc -trace led_change_intensity
It has been removed from linux since
61a47c1ad3a4 ("sysctl: Remove the sysctl system call")
It's a good news because it was not really supported by qemu.
Signed-off-by: Laurent Vivier
Reviewed-by: Richard Henderson
Message-Id: <20200930003033.554124-5-laur...@vivier.eu>
Signed-off-by:
Per the 'ARM MPS2 and MPS2+ FPGA Prototyping Boards Technical
Reference Manual' (100112_0200_07_en):
2.1 Overview of the MPS2 and MPS2+ hardware
The MPS2 and MPS2+ FPGA Prototyping Boards contain the
following components and interfaces:
* User switches and user LEDs:
Updated running scripts/update-mips-syscall-args.sh
Signed-off-by: Laurent Vivier
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20200930003033.554124-3-laur...@vivier.eu>
Signed-off-by: Laurent Vivier
---
linux-user/mips/syscall-args-o32.c.inc | 4
1
Updated running scripts/update-syscalltbl.sh
Signed-off-by: Laurent Vivier
Reviewed-by: Richard Henderson
Message-Id: <20200930003033.554124-4-laur...@vivier.eu>
Signed-off-by: Laurent Vivier
---
linux-user/alpha/syscall.tbl | 4 +-
linux-user/arm/syscall.tbl| 4 +-
The following changes since commit 4c5b97bfd0dd54dc27717ae8d1cd10e14eef1430:
Merge remote-tracking branch 'remotes/kraxel/tags/modules-20201022-pull-req=
uest' into staging (2020-10-22 12:33:21 +0100)
are available in the Git repository at:
git://github.com/vivier/qemu.git
From: Max Filippov
Linux userspace always sees coprocessors as enabled. CPENABLE register
and coprocessor exceptions are used internally by the kernel to manage
lazy coprocessor context switch. None of it is needed for linux-user.
Always enable all coprocessors for user emulation.
-20201026
for you to fetch changes up to 06972067c48fc21a47445b5d706368f1129f216f:
hw/arm/tosa: Replace fprintf() calls by LED devices (2020-10-26 13:44:58 +0=
100)
API to model LED.
CI jobs results:
. https://cirrus-ci.com/build
From: Matus Kysel
accept4() returned wrong errno, that did not match current linux
Signed-off-by: Matus Kysel
Reviewed-by: Laurent Vivier
Message-Id: <20200930151616.3588165-1-mky...@tachyum.com>
Signed-off-by: Laurent Vivier
---
linux-user/syscall.c | 6 +++---
1 file changed, 3
On 10/16/20 5:29 PM, Philippe Mathieu-Daudé wrote:
On 9/19/20 2:30 PM, Philippe Mathieu-Daudé wrote:
On 9/12/20 3:40 PM, Philippe Mathieu-Daudé wrote:
Hello,
These patches are part of the GSoC unselected 'QEMU visualizer'
project.
This series introduce a LED device that can be easily
Update gensyscalls.sh not to generate an empty line at the end of the file
And then automatically update syscall_nr.h running scripts/gensyscalls.sh
Signed-off-by: Laurent Vivier
Reviewed-by: Alistair Francis
Reviewed-by: Richard Henderson
Message-Id:
From: Frajo
Same as d4247ec2d79ef2477cb886fa688706b068119736 but for statfs64
When running rpm within qemu-arm-dynamic this could cause rpm fail with
an error like
"installing package A needs B MB on the C filesystem" depending on what
is in memory in f_flags.
From: Stephen Long
The bug was triggered by the following code on aarch64-linux-user:
int main(void)
{
int PDeathSig = 0;
if (prctl(PR_GET_PDEATHSIG, ) == 0 && PDeathSig == SIGKILL)
prctl(PR_GET_PDEATHSIG, 0);
return (PDeathSig == SIGKILL);
}
Signed-off-by: Stephen Long
On 10/15/20 5:18 PM, Peter Maydell wrote:
In ptimer_reload(), we call the callback function provided by the
timer device that is using the ptimer. This callback might disable
the ptimer. The code mostly handles this correctly, except that
we'll still print the warning about "Timer with delta
On 10/15/20 5:31 PM, Peter Maydell wrote:
On Thu, 15 Oct 2020 at 16:18, Peter Maydell wrote:
The armv7m systick timer is a 24-bit decrementing, wrap-on-zero,
clear-on-write counter. Our current implementation has various
bugs and dubious workarounds in it (for instance see
Using an array of length 0 seems to be enough to avoid the warning
Will use that solution in v3.
Thanks,
Daniele
On 10/26/2020 11:12 AM, Paolo Bonzini wrote:
On 26/10/20 16:03, Daniele Buono wrote:
Hi Paolo,
I reorganized UASStatus to put uas_iu at the end and it works fine.
Unfortunately,
This enforces a type signature against all of the top-level expression
check routines without necessarily needing to create some
overcomplicated class hierarchy for them.
Signed-off-by: John Snow
Reviewed-by: Eduardo Habkost
Reviewed-by: Cleber Rosa
---
scripts/qapi/expr.py | 69
This is a very minor adjustment.
a + b is list-specific behavior, but we can accept a wider variety of
types in a more pythonic fashion if we avoid that behavior.
Typing it this way allows callers to use things like dict.keys() and
other iterables that are not their own discrete lists.
Signed-off-by: John Snow
Reviewed-by: Cleber Rosa
---
scripts/qapi/expr.py | 167 ++-
1 file changed, 164 insertions(+), 3 deletions(-)
diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py
index 99c5c2ff99b0..8ad82ca98864 100644
---
Signed-off-by: John Snow
Reviewed-by: Eduardo Habkost
Reviewed-by: Cleber Rosa
---
scripts/qapi/expr.py | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py
index 4d4ee3daa002..99c5c2ff99b0 100644
---
It is -- maybe -- possibly -- three nanoseconds faster.
Signed-off-by: John Snow
Reviewed-by: Eduardo Habkost
Reviewed-by: Cleber Rosa
---
scripts/qapi/expr.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py
index
There's not a big obvious difference between the types of checks that
happen in the main function versus the kind that happen in the
functions. Now they're in one place for each of the main types.
As part of the move, spell out the required and optional keywords so
they're obvious at a glance.
Patchew URL: https://patchew.org/QEMU/20201026212853.92880-1-kei...@keithp.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20201026212853.92880-1-kei...@keithp.com
Subject: [PATCH 0/4] riscv: Add semihosting
Iterating over the members of data isn't going to work if it's not some
form of dict anyway, but for type safety, formalize it.
Signed-off-by: John Snow
Reviewed-by: Eduardo Habkost
---
scripts/qapi/expr.py | 7 +++
1 file changed, 7 insertions(+)
diff --git a/scripts/qapi/expr.py
This is a only minor rewrite to address some minor style nits. Don't
compare against the empty list to check for the empty condition, and
move the normalization forward to unify the check on the now-normalized
structure.
Signed-off-by: John Snow
Reviewed-by: Eduardo Habkost
Reviewed-by: Cleber
Signed-off-by: John Snow
Tested-by: Eduardo Habkost
Reviewed-by: Eduardo Habkost
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
---
scripts/qapi/pylintrc | 1 -
1 file changed, 1 deletion(-)
diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc
index b9e077a1642d..fb0386d529ac 100644
Casts are instructions to the type checker only, they aren't "safe" and
should probably be avoided in general. In this case, when we perform
type checking on a nested structure, the type of each field does not
"stick".
We don't need to assert that something is a str if we've already checked
that
mypy does not know the types of values stored in Dicts that masquerade
as objects. Help the type checker out by constraining the type.
Signed-off-by: John Snow
Reviewed-by: Eduardo Habkost
Reviewed-by: Cleber Rosa
---
scripts/qapi/expr.py | 25 ++---
1 file changed, 22
Annotations do not change runtime behavior.
This commit *only* adds annotations.
Signed-off-by: John Snow
Reviewed-by: Eduardo Habkost
Reviewed-by: Cleber Rosa
---
scripts/qapi/expr.py | 71 ---
scripts/qapi/mypy.ini | 5 ---
2 files changed, 46
OrderedDict is a subtype of dict, so we can check for a more general form.
Signed-off-by: John Snow
Reviewed-by: Eduardo Habkost
Reviewed-by: Cleber Rosa
---
scripts/qapi/expr.py | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/scripts/qapi/expr.py
mypy isn't fond of allowing you to check for bool membership in a
collection of str elements. Guard this lookup for precisely when we were
given a name.
Signed-off-by: John Snow
Reviewed-by: Eduardo Habkost
Reviewed-by: Cleber Rosa
---
scripts/qapi/expr.py | 4 +++-
1 file changed, 3
based-on: <20201026194251.11075-1-js...@redhat.com>
[PATCH v2 00/11] qapi: static typing conversion, pt2
Hi, this series adds static type hints to the QAPI module.
This is part three, and it focuses on expr.py.
Part 3: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt3
The function can just use the argument from the scope above. Otherwise,
we get shadowed argument errors because the parameter name clashes with
the name of a variable already in-scope.
Signed-off-by: John Snow
Reviewed-by: Eduardo Habkost
Reviewed-by: Cleber Rosa
---
scripts/qapi/expr.py | 6
It's a simple case, shimmy the early return upwards.
Signed-off-by: John Snow
Reviewed-by: Eduardo Habkost
Reviewed-by: Cleber Rosa
---
scripts/qapi/expr.py | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py
index
This makes all of the internal interfaces architecture-independent and
renames the internal functions to use the 'common_semi' prefix instead
of 'arm' or 'arm_semi'.
To do this, some new architecture-specific internal helper functions
were created:
static inline target_ulong
This commit renames two files which provide ARM semihosting support so
that they can be shared by other architectures:
1. target/arm/arm-semi.c -> hw/semihosting/common-semi.c
2. linux-user/arm/semihost.c -> linux-user/semihost.c
The build system was modified to reflect this change, but
The public API is now defined in
hw/semihosting/common-semi.h. do_common_semihosting takes CPUState *
instead of CPUARMState *. All internal functions have been renamed
common_semi_ instead of arm_semi_ or arm_. Aside from the API change,
there are no functional changes in this patch.
This series first adapts the existing ARM semihosting code to be
architecture-neutral, then adds RISC-V semihosting support using that.
Patch 1/4 moves the ARM semihosting support code to common directories and
adapts the build system to match.
Patch 2/4 changes the public API to this code to
Adapt the arm semihosting support code for RISCV. This implementation
is based on the standard for RISC-V semihosting version 0.2 as
documented in
https://github.com/riscv/riscv-semihosting-spec/releases/tag/0.2
Signed-off-by: Keith Packard
---
v2:
Update PC after exception is
On Mon, 26 Oct 2020 13:48:37 +0100
Christian Schoenebeck wrote:
> On Montag, 26. Oktober 2020 11:33:42 CET Peter Maydell wrote:
> > On Fri, 23 Oct 2020 at 12:46, Christian Schoenebeck
> >
> > wrote:
> > > The following changes since commit
> > > 4c5b97bfd0dd54dc27717ae8d1cd10e14eef1430:
> > >
Richard Henderson writes:
> On 10/23/20 2:49 PM, Keith Packard via wrote:
>> static bool trans_ebreak(DisasContext *ctx, arg_ebreak *a)
>> {
>> -generate_exception(ctx, RISCV_EXCP_BREAKPOINT);
>> +uint32_t pre= opcode_at(>base, ctx->base.pc_next - 4);
>> +uint32_t ebreak =
Richard Henderson writes:
> This is no different to EXCP_DEBUG, really, which is also internal to qemu but
> user-visible in the same way. Just adjust the logging in
> riscv_cpu_do_interrupt.
I think that's already handled by the early return in
riscv_cpu_do_interrupt after handling the
On Tue, Oct 27, 2020 at 4:58 AM Paolo Bonzini wrote:
>
>
>
> Il lun 26 ott 2020, 19:59 罗勇刚(Yonggang Luo) ha
scritto:
>>
>> This pull request confused me, the windows msys2 build time slow down
from 40min to more than one hour.
>
>
> Probably just the cache being rebuilt. Cirrus CI times seem to
Il lun 26 ott 2020, 19:59 罗勇刚(Yonggang Luo) ha
scritto:
> This pull request confused me, the windows msys2 build time slow down from
> 40min to more than one hour.
>
Probably just the cache being rebuilt. Cirrus CI times seem to vary a lot
but 40min and 1h5min seem to be the common cases before
Patchew URL:
https://patchew.org/QEMU/1603743573-9870-1-git-send-email-eric.devol...@oracle.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1603743573-9870-1-git-send-email-eric.devol...@oracle.com
Subject: [PATCH
On Tue, Oct 27, 2020 at 4:44 AM Peter Maydell
wrote:
>
> Ping for review ?
>
Maybe nobody can review this, anyway, is that possible add a test case for
this?
I found https://github.com/oxidecomputer/qemu-systick-bug are simple enough.
> thanks
> -- PMM
>
> On Thu, 15 Oct 2020 at 16:18, Peter
This changeset introduces support for the ACPI Error Record
Serialization Table, ERST.
ERST is defined in [1], and the error records are defined
according to [2].
This changeset generates the ACPI ERST table, which OSPM
follows to program the associated ERST device. The ERST
device occupies 8KiB
This changeset introduces support for the ACPI Error Record
Serialization Table, ERST.
The change to hw/acpi/meson.build simply adds in the new .c file
for compilation.
The change to hw/i386/acpi-build.c calls out the building of the
ERST table (and also creates the associated device).
The new
Ping for review ?
thanks
-- PMM
On Thu, 15 Oct 2020 at 16:18, Peter Maydell wrote:
>
> This patch series rewrites our implementation of the armv7m systick
> timer to use ptimers.
>
> The armv7m systick timer is a 24-bit decrementing, wrap-on-zero,
> clear-on-write counter. Our current
1 - 100 of 664 matches
Mail list logo
