[PATCH v3 7/7] tests/acceptance: Add virtiofs_submounts.py

2020-11-02 Thread Max Reitz
This test invokes several shell scripts to create a random directory tree full of submounts, and then check in the VM whether every submount has its own ID and the structure looks as expected. (Note that the test scripts must be non-executable, so Avocado will not try to execute them as if they we

[PATCH v3 4/7] virtiofsd: Add mount ID to the lo_inode key

2020-11-02 Thread Max Reitz
Using st_dev is not sufficient to uniquely identify a mount: You can mount the same device twice, but those are still separate trees, and e.g. by mounting something else inside one of them, they may differ. Using statx(), we can get a mount ID that uniquely identifies a mount. If that is available

[PATCH v3 6/7] tests/acceptance/boot_linux: Accept SSH pubkey

2020-11-02 Thread Max Reitz
Let download_cloudinit() take an optional pubkey, which subclasses of BootLinux can pass through setUp(). Signed-off-by: Max Reitz Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Willian Rampazzo Reviewed-by: Stefan Hajnoczi --- tests/acceptance/boot_linux.py | 13 +++-- 1 file chang

[PATCH v3 3/7] meson.build: Check for statx()

2020-11-02 Thread Max Reitz
Check whether the glibc provides statx() and if so, define CONFIG_STATX. Signed-off-by: Max Reitz Reviewed-by: Stefan Hajnoczi --- meson.build | 16 1 file changed, 16 insertions(+) diff --git a/meson.build b/meson.build index 47e32e1fcb..39ac5cf6d8 100644 --- a/meson.build ++

[PATCH v3 2/7] virtiofsd: Add attr_flags to fuse_entry_param

2020-11-02 Thread Max Reitz
fuse_entry_param is converted to fuse_attr on the line (by fill_entry()), so it should have a member that mirrors fuse_attr.flags. fill_entry() should then copy this fuse_entry_param.attr_flags to fuse_attr.flags. Signed-off-by: Max Reitz Reviewed-by: Stefan Hajnoczi --- tools/virtiofsd/fuse_l

[PATCH v3 0/7] virtiofsd: Announce submounts to the guest

2020-11-02 Thread Max Reitz
RFC: https://www.redhat.com/archives/virtio-fs/2020-May/msg00024.html v1: https://lists.nongnu.org/archive/html/qemu-devel/2020-09/msg03598.html v2: https://lists.nongnu.org/archive/html/qemu-devel/2020-10/msg09117.html Branch: https://github.com/XanClic/qemu.git virtiofs-submounts-v4 Branch: http

[PATCH v3 5/7] virtiofsd: Announce sub-mount points

2020-11-02 Thread Max Reitz
Whenever we encounter a directory with an st_dev or mount ID that differs from that of its parent, we set the FUSE_ATTR_SUBMOUNT flag so the guest can create a submount for it. We only need to do so in lo_do_lookup(). The following functions return a fuse_attr object: - lo_create(), though fuse_r

[PATCH v3 1/7] virtiofsd: Check FUSE_SUBMOUNTS

2020-11-02 Thread Max Reitz
FUSE_SUBMOUNTS is a pure indicator by the kernel to signal that it supports submounts. It does not check its state in the init reply, so there is nothing for fuse_lowlevel.c to do but to check its existence and copy it into fuse_conn_info.capable. Signed-off-by: Max Reitz Reviewed-by: Stefan Haj

Re: [PULL 0/3] tcg patch queue

2020-11-02 Thread Richard Henderson
On 11/2/20 5:57 AM, Peter Maydell wrote: > On Tue, 27 Oct 2020 at 16:51, Richard Henderson > wrote: >> >> Optimize across branches. >> Add logging for cpu_io_recompile. > > Igor2 reported on IRC that this seems to cause a crash when

[PATCH V2] vl: pause option

2020-11-02 Thread Steve Sistare
Provide the -pause command-line parameter and the QEMU_PAUSE environment variable to pause QEMU during process startup using SIGSTOP and allow a developer to attach a debugger, or observe the process using tools such as strace. Useful when the QEMU has been launched with some other entity, such as

Re: [RFC PATCH-for-5.2? 4/5] tests/acceptance: Only run tests tagged 'gating-ci' on GitLab CI

2020-11-02 Thread Cleber Rosa
On Mon, Nov 02, 2020 at 03:59:12PM +0100, Philippe Mathieu-Daudé wrote: > On 11/2/20 3:42 PM, Philippe Mathieu-Daudé wrote: > > To avoid breaking our CI each time a test is added, switch from the > > "run all but disable some" to "only run the tagged tests on CI". > > This way we can add a test to

Re: [PULL v3 00/17] 9p queue (previous 2020-10-30)

2020-11-02 Thread Peter Maydell
00) > > are available in the Git repository at: > > https://github.com/cschoenebeck/qemu.git tags/pull-9p-20201102 > > for you to fetch changes up to 4d0746e2135f56c59c6e61ef42d700b7139065b4: > > tests/9pfs: add local

Re: target/mips: Deprecate nanoMIPS ISA?

2020-11-02 Thread Richard Henderson
On 11/2/20 2:00 AM, Philippe Mathieu-Daudé wrote: > The toolchain page mention LLVM but simply links http://llvm.org/ > where I couldn't find any reference on nanoMIPS. > > The only reference in the GCC mailing list, is the nanoMIPS > announcement: https://gcc.gnu.org/pipermail/gcc/2018-May.txt >

Re: [PATCH-for-5.2] hw/mips: Remove the 'r4k' machine

2020-11-02 Thread Richard Henderson
On 11/2/20 2:26 AM, Philippe Mathieu-Daudé wrote: > -mips ``r4k`` platform (since 5.0) > +mips ``r4k`` platform (removed in 5.2) > ' Header underline needs adjustment. Otherwise, Acked-by: Richard Henderson r~

Re: [RFC PATCH v2 00/37] cleanup qemu_init and make sense of command line processing

2020-11-02 Thread Igor Mammedov
On Tue, 27 Oct 2020 14:21:15 -0400 Paolo Bonzini wrote: > The main improvements with respect to v1 are: series no longer applies to master what commit if was based on? > > - further extraction of various phases of command line processing and VM > creation to separate function; > > - removin

Re: [PATCH 07/29] vl: extract qemu_init_subsystems

2020-11-02 Thread Igor Mammedov
On Tue, 27 Oct 2020 14:21:22 -0400 Paolo Bonzini wrote: > Group a bunch of subsystem initializations that can be done right > after command line parsing. Remove initializations that can be done > simply as global variable initializers. > > Signed-off-by: Paolo Bonzini Reviewed-by: Igor Mammed

Re: [PATCH v2] target/s390x: fix execution with icount

2020-11-02 Thread Richard Henderson
On 11/2/20 1:26 AM, Pavel Dovgalyuk wrote: > This patch adds some gen_io_start() calls to allow execution > of s390x targets in icount mode with -smp 1. > It enables deterministic timers and record/replay features. > > Signed-off-by: Pavel Dovgalyuk Reviewed-by: Richard Henderson r~

Re: [PULL 09/12] qga: add ssh-{add,remove}-authorized-keys

2020-11-02 Thread Markus Armbruster
Michael Roth writes: > From: Marc-André Lureau > > Add new commands to add and remove SSH public keys from > ~/.ssh/authorized_keys. > > I took a different approach for testing, including the unit tests right > with the code. I wanted to overwrite the function to get the user > details, I couldn

Re: [PATCH] tests/qtest/npcm7xx_rng-test: Disable randomness tests

2020-11-02 Thread Philippe Mathieu-Daudé
On 11/2/20 4:24 PM, Peter Maydell wrote: > The randomness tests in the NPCM7xx RNG test fail intermittently > but fairly frequently. On my machine running the test in a loop: > while QTEST_QEMU_BINARY=./qemu-system-aarch64 > ./tests/qtest/npcm7xx_rng-test; do true; done > > will fail in less tha

Re: [PULL] nvme emulation patches for 5.2

2020-11-02 Thread Philippe Mathieu-Daudé
f7c06d5: > > Merge remote-tracking branch 'remotes/philmd-gitlab/tags/sd-next-20201026' > into staging (2020-10-26 17:19:26 +) > > are available in the Git repository at: > > git://git.infradead.org/qemu-nvme.git tags/pull-nvme-20201102 > > for yo

Re: [PATCH 06/29] vl: move various initialization routines out of qemu_init

2020-11-02 Thread Igor Mammedov
On Tue, 27 Oct 2020 14:21:21 -0400 Paolo Bonzini wrote: > Some very simple initialization routines can be nested in existing > subsystem-level functions, do that to simplify qemu_init. > > Signed-off-by: Paolo Bonzini Reviewed-by: Igor Mammedov > --- > hw/core/machine.c | 3 +++ > incl

Re: [PATCH v2 00/11] qapi: static typing conversion, pt2

2020-11-02 Thread John Snow
On 10/26/20 3:42 PM, John Snow wrote: Hi, this series adds static type hints to the QAPI module. This is part two, and covers introspect.py. Part 2: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt2 Everything: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt6 - Requires P

Re: [PATCH 05/29] vl: split various early command line options to a separate function

2020-11-02 Thread Igor Mammedov
On Tue, 27 Oct 2020 14:21:20 -0400 Paolo Bonzini wrote: > Various options affect the global state of QEMU including the rest of > qemu_init, and they need to be called very early. Group them together > in a function that is called at the beginning. > > Signed-off-by: Paolo Bonzini > --- > sof

[PATCH 0/2] migration: Two extra fixes

2020-11-02 Thread Peter Xu
This should fix intermittent hang of migration-test due to the latest update to postcopy recovery. Thanks, Peter Xu (2): migration: Unify reset of last_rb on destination node when recover migration: Postpone the kick of the fault thread after recover migration/postcopy-ram.c | 2 -- migrat

[PATCH 1/2] migration: Unify reset of last_rb on destination node when recover

2020-11-02 Thread Peter Xu
When postcopy recover happens, we need to reset last_rb after each return of postcopy_pause_fault_thread() because that means we just got the postcopy migration continued. Unify this reset to the place right before we want to kick the fault thread again, when we get the command MIG_CMD_POSTCOPY_RE

[PATCH 2/2] migration: Postpone the kick of the fault thread after recover

2020-11-02 Thread Peter Xu
The new migrate_send_rp_req_pages_pending() call should greatly improve destination responsiveness because it will resync faulted address after postcopy recovery. However it is also the 1st place to initiate the page request from the main thread. One thing is overlooked on that migrate_send_rp_me

[PULL] nvme emulation patches for 5.2

2020-11-02 Thread Keith Busch
ab/tags/sd-next-20201026' into staging (2020-10-26 17:19:26 +) are available in the Git repository at: git://git.infradead.org/qemu-nvme.git tags/pull-nvme-20201102 for you to fetch changes up to 843c8f91a7ad63f8f3e4e564d3f41f3d030ab8a9: hw/block/nvme: fix queue identifer validation

[PATCH] tests/qtest/npcm7xx_rng-test: Disable randomness tests

2020-11-02 Thread Peter Maydell
The randomness tests in the NPCM7xx RNG test fail intermittently but fairly frequently. On my machine running the test in a loop: while QTEST_QEMU_BINARY=./qemu-system-aarch64 ./tests/qtest/npcm7xx_rng-test; do true; done will fail in less than a minute with an error like: ERROR:../../tests/qtes

Re: [PATCH-for-5.2] hw/smbios: Fix leaked fd in save_opt_one() error path

2020-11-02 Thread Laszlo Ersek
On 10/30/20 16:27, Philippe Mathieu-Daudé wrote: > Fix the following Coverity issue (RESOURCE_LEAK): > > CID 1432879: Resource leak > > Handle variable fd going out of scope leaks the handle. > > Replace a close() call by qemu_close() since the handle is > opened with qemu_open(). > > Fix

Re: [PATCH] virtiofsd: Seccomp: Add 'send' for syslog

2020-11-02 Thread Daniel P . Berrangé
On Mon, Nov 02, 2020 at 04:11:44PM +0100, Philippe Mathieu-Daudé wrote: > On 11/2/20 4:07 PM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > On ppc it looks like syslog ends up using 'send' rather than 'sendto'. > > > > Reference: https://github.com/kata-container

Re: [PATCH] virtiofsd: Seccomp: Add 'send' for syslog

2020-11-02 Thread Daniel P . Berrangé
On Mon, Nov 02, 2020 at 03:07:50PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > On ppc it looks like syslog ends up using 'send' rather than 'sendto'. > > Reference: https://github.com/kata-containers/kata-containers/issues/1050 > > Reported-by: amulm...@in.ib

Re: [PATCH] virtiofsd: Seccomp: Add 'send' for syslog

2020-11-02 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > On 11/2/20 4:07 PM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > On ppc it looks like syslog ends up using 'send' rather than 'sendto'. > > > > Reference: https://github.com/kata-containers/kata-containers/i

Re: recent flakiness (intermittent hangs) of migration-test

2020-11-02 Thread Peter Xu
On Mon, Nov 02, 2020 at 03:19:50PM +0100, Christian Schoenebeck wrote: > On Montag, 2. November 2020 14:55:04 CET Philippe Mathieu-Daudé wrote: > > On 10/30/20 2:53 PM, Peter Xu wrote: > > > On Fri, Oct 30, 2020 at 11:48:28AM +, Peter Maydell wrote: > > >>> Peter, is it possible that you enable

Re: [PATCH] virtiofsd: Seccomp: Add 'send' for syslog

2020-11-02 Thread Philippe Mathieu-Daudé
On 11/2/20 4:07 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > On ppc it looks like syslog ends up using 'send' rather than 'sendto'. > > Reference: https://github.com/kata-containers/kata-containers/issues/1050 > > Reported-by: amulm...@in.ibm.com > Signed-off-by:

[PATCH] virtiofsd: Seccomp: Add 'send' for syslog

2020-11-02 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" On ppc it looks like syslog ends up using 'send' rather than 'sendto'. Reference: https://github.com/kata-containers/kata-containers/issues/1050 Reported-by: amulm...@in.ibm.com Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_seccomp.c | 1

Re: Out-of-Process Device Emulation session at KVM Forum 2020

2020-11-02 Thread Stefan Hajnoczi
On Mon, Nov 02, 2020 at 05:34:50AM -0500, Michael S. Tsirkin wrote: > On Mon, Nov 02, 2020 at 10:27:54AM +, Stefan Hajnoczi wrote: > > On Mon, Nov 02, 2020 at 11:00:12AM +0800, Jason Wang wrote: > > > > > > On 2020/10/30 下午7:13, Stefan Hajnoczi wrote: > > > > > I still don't get why it must be

Re: [RFC PATCH-for-5.2? 4/5] tests/acceptance: Only run tests tagged 'gating-ci' on GitLab CI

2020-11-02 Thread Philippe Mathieu-Daudé
On 11/2/20 3:42 PM, Philippe Mathieu-Daudé wrote: > To avoid breaking our CI each time a test is added, switch from the > "run all but disable some" to "only run the tagged tests on CI". > This way we can add a test to the repository, and promote it to > 'gating-ci' once it is proven stable enough.

Re: VFIO Migration

2020-11-02 Thread Stefan Hajnoczi
On Mon, Nov 02, 2020 at 01:28:44PM +0100, Cornelia Huck wrote: > On Mon, 2 Nov 2020 11:11:53 + > Stefan Hajnoczi wrote: > > VFIO Migration > > == > > This document describes how to save and load VFIO device states. Saving a > > device state produces a snapshot of a VFIO device's st

[PULL 0/1] xen queue 2020-11-02

2020-11-02 Thread Anthony PERARD via
erard/qemu-dm.git tags/pull-xen-20201102 for you to fetch changes up to 045b1d4dbb44da67f1f86efa75b02843c0e951ef: xen: rework pci_piix3_xen_ide_unplug (2020-11-02 11:56:55 +) xen patch - Rework Xen disk unplug to work with new

Re: [PATCH 1/4] gitlab: publish the docs built during CI

2020-11-02 Thread Philippe Mathieu-Daudé
On 11/2/20 3:21 PM, Daniel P. Berrangé wrote: > On Mon, Nov 02, 2020 at 02:50:19PM +0100, Philippe Mathieu-Daudé wrote: >> On 11/2/20 2:09 PM, Daniel P. Berrangé wrote: >>> Most of the build jobs will create the sphinx documentation. If we >>> expose this as an artifact of a "pages" job in a "publi

Re: [PATCH 2/4] gitlab: force enable docs build in Fedora, Ubuntu, Debian

2020-11-02 Thread Philippe Mathieu-Daudé
On 11/2/20 2:09 PM, Daniel P. Berrangé wrote: > Meson runs a test to see if Sphinx works, and automatically disables it > on error. This can lead to the CI jobs skipping docs build without > maintainers noticing the problem. Use --enable-docs to force a fatal > error if Sphinx doesn't work on the j

[PULL 1/1] xen: rework pci_piix3_xen_ide_unplug

2020-11-02 Thread Anthony PERARD via
This is to allow IDE disks to be unplugged when adding to QEMU via: -drive file=/root/disk_file,if=none,id=ide-disk0,format=raw -device ide-hd,drive=ide-disk0,bus=ide.0,unit=0 as the current code only works for disk added with: -drive file=/root/disk_file,if=ide,index=0,media=disk,form

[PATCH-for-5.2? 5/5] tests/acceptance: Let stable tests use the 'gating-ci' tag

2020-11-02 Thread Philippe Mathieu-Daudé
Switch from "run all tests but disable some" to "only run the tests tagged as stable on CI". Declare our current set of tests as stable with the 'gating-ci' tag. Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/boot_linux.py | 10 -- tests/acceptance/boot_linux_consol

[PATCH-for-5.2? 2/5] tests/acceptance: Restore MIPS Malta multicore tests

2020-11-02 Thread Philippe Mathieu-Daudé
Since 42a052333a6 ("hw/misc/mips_cpc: Start vCPU when powered on") the multicore support of the MIPS Malta board has been fixed. This reverts commit 61bbce96fe4c8e3a2b7df5a67ba7dc6ba418e54b. Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/machine_mips_malta.py | 2 -- 1 file changed,

[PATCH-for-5.2? 3/5] tests/acceptance: Skip incomplete virtio_version tests using '@skip'

2020-11-02 Thread Philippe Mathieu-Daudé
Prefer skipping incomplete tests with the "@skip" keyword, rather than commenting the code. Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/virtio_version.py | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tests/acceptance/virtio_version.py b/tests/acc

[RFC PATCH-for-5.2? 4/5] tests/acceptance: Only run tests tagged 'gating-ci' on GitLab CI

2020-11-02 Thread Philippe Mathieu-Daudé
To avoid breaking our CI each time a test is added, switch from the "run all but disable some" to "only run the tagged tests on CI". This way we can add a test to the repository, and promote it to 'gating-ci' once it is proven stable enough. Signed-off-by: Philippe Mathieu-Daudé --- TODO: where

Re: Migrating to the gitlab issue tracker

2020-11-02 Thread Eric Blake
On 11/2/20 8:26 AM, Daniel P. Berrangé wrote: > On Mon, Nov 02, 2020 at 02:57:49PM +0100, Laszlo Ersek wrote: >> On 10/30/20 10:16, Stefan Hajnoczi wrote: >>> On Thu, Oct 29, 2020 at 12:01:27PM -0400, John Snow wrote: In experimenting with my mirror on gitlab though, I was unable to find a >>

[PATCH-for-5.2? 0/5] tests/acceptance: Only run tests tagged 'gating-ci' on GitLab CI

2020-11-02 Thread Philippe Mathieu-Daudé
This series try an idea from the CI BoF last week: - allow adding all test to mainstream repository - promote test to "gating" once it is proven stable - only run 'gating-ci' on GitLab CI Philippe Mathieu-Daudé (5): tests/acceptance: Restrict virtio_check_params tests to X86 target tests/accep

[PATCH-for-5.2? 1/5] tests/acceptance: Restrict virtio_check_params tests to X86 target

2020-11-02 Thread Philippe Mathieu-Daudé
We disabled the virtio_check_params tests in commit 2d6a6e238a2 ("tests/acceptance/virtio_check_params: Disable the test"), because these tests were making multiarch CI fail (virtio is multiarch). We took the big hammer, as we can restrict the tests to the X86 arch. Restore them on this single arc

Re: Migrating to the gitlab issue tracker

2020-11-02 Thread Daniel P . Berrangé
On Mon, Nov 02, 2020 at 02:57:49PM +0100, Laszlo Ersek wrote: > On 10/30/20 10:16, Stefan Hajnoczi wrote: > > On Thu, Oct 29, 2020 at 12:01:27PM -0400, John Snow wrote: > >> In experimenting with my mirror on gitlab though, I was unable to find a > >> way > >> to configure it to send issue tracker

Re: [PATCH 4/4] docs: add "page source" link to sphinx documentation

2020-11-02 Thread Daniel P . Berrangé
On Mon, Nov 02, 2020 at 01:52:04PM +, Peter Maydell wrote: > On Mon, 2 Nov 2020 at 13:09, Daniel P. Berrangé wrote: > > > > Add a link to the top of the sidebar in every docs page that takes the > > user back to the source code in gitlab. > > This doesn't exactly link back to the source code,

Re: [PATCH 1/4] gitlab: publish the docs built during CI

2020-11-02 Thread Daniel P . Berrangé
On Mon, Nov 02, 2020 at 02:50:19PM +0100, Philippe Mathieu-Daudé wrote: > On 11/2/20 2:09 PM, Daniel P. Berrangé wrote: > > Most of the build jobs will create the sphinx documentation. If we > > expose this as an artifact of a "pages" job in a "public" directory, it > > will get published using Git

Re: recent flakiness (intermittent hangs) of migration-test

2020-11-02 Thread Christian Schoenebeck
On Montag, 2. November 2020 14:55:04 CET Philippe Mathieu-Daudé wrote: > On 10/30/20 2:53 PM, Peter Xu wrote: > > On Fri, Oct 30, 2020 at 11:48:28AM +, Peter Maydell wrote: > >>> Peter, is it possible that you enable QTEST_LOG=1 in your future > >>> migration-test testcase and try to capture th

Re: [PATCH] hw/intc/arm_gicv3_cpuif: Make GIC maintenance interrupts work

2020-11-02 Thread Luc Michel
On 16:39 Fri 09 Oct , Peter Maydell wrote: > In gicv3_init_cpuif() we copy the ARMCPU gicv3_maintenance_interrupt > into the GICv3CPUState struct's maintenance_irq field. This will > only work if the board happens to have already wired up the CPU > maintenance IRQ before the GIC was realized.

Re: [PATCH v2 11/11] sockets: Make abstract UnixSocketAddress depend on CONFIG_LINUX

2020-11-02 Thread Eric Blake
On 11/2/20 3:44 AM, Markus Armbruster wrote: > The abstract socket namespace is a non-portable Linux extension. An > attempt to use it elsewhere should fail with ENOENT (the abstract > address looks like a "" pathname, which does not resolve). We report > this failure like > > Failed to conn

Re: [PATCH v2 01/11] test-util-sockets: Plug file descriptor leak

2020-11-02 Thread Philippe Mathieu-Daudé
On 11/2/20 10:44 AM, Markus Armbruster wrote: > Fixes: 4d3a329af59ef8acd076f99f05e82531d8129b34 > Reviewed-by: Paolo Bonzini > Reviewed-by: Eric Blake > Signed-off-by: Markus Armbruster > --- > tests/test-util-sockets.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daud

Re: [PATCH v2 09/11] char-socket: Fix qemu_chr_socket_address() for abstract sockets

2020-11-02 Thread Eric Blake
On 11/2/20 3:44 AM, Markus Armbruster wrote: > Commit 776b97d360 "qemu-sockets: add abstract UNIX domain socket > support" neglected to update qemu_chr_socket_address(). It shows > shows neither @abstract nor @tight. Fix that. > > Reviewed-by: Paolo Bonzini > Signed-off-by: Markus Armbruster >

Re: [PATCH v2 08/11] sockets: Fix socket_sockaddr_to_address_unix() for abstract sockets

2020-11-02 Thread Eric Blake
On 11/2/20 3:44 AM, Markus Armbruster wrote: > Commit 776b97d360 "qemu-sockets: add abstract UNIX domain socket > support" neglected to update socket_sockaddr_to_address_unix(). The > function returns a non-abstract socket address for abstract > sockets (wrong) with a null @path (also wrong; a non

Re: Migrating to the gitlab issue tracker

2020-11-02 Thread Laszlo Ersek
On 10/30/20 10:16, Stefan Hajnoczi wrote: > On Thu, Oct 29, 2020 at 12:01:27PM -0400, John Snow wrote: >> In experimenting with my mirror on gitlab though, I was unable to find a way >> to configure it to send issue tracker notifications to the email list. A >> move to gitlab would likely mean, the

Re: [PULL 0/3] tcg patch queue

2020-11-02 Thread Peter Maydell
On Tue, 27 Oct 2020 at 16:51, Richard Henderson wrote: > > Optimize across branches. > Add logging for cpu_io_recompile. Igor2 reported on IRC that this seems to cause a crash when using an hppa guest. This is apparently happening o

Re: recent flakiness (intermittent hangs) of migration-test

2020-11-02 Thread Philippe Mathieu-Daudé
On 10/30/20 2:53 PM, Peter Xu wrote: > On Fri, Oct 30, 2020 at 11:48:28AM +, Peter Maydell wrote: >>> Peter, is it possible that you enable QTEST_LOG=1 in your future >>> migration-test >>> testcase and try to capture the stderr? With the help of commit a47295014d >>> ("migration-test: Only h

Re: [RFC PATCH] hw/arm/virt: use sbsa-ec for reboot and poweroff in secure mode

2020-11-02 Thread Graeme Gregory
On Thu, Oct 29, 2020 at 11:19:39AM +, Leif Lindholm wrote: > Hi Peter, (+Ard) > > Graeme is on holiday this week, and I would like his input. > > On Wed, Oct 28, 2020 at 20:31:41 +, Peter Maydell wrote: > > On Wed, 28 Oct 2020 at 08:59, Maxim Uvarov wrote: > > > > > > If we're emulating

Re: [PATCH 4/4] docs: add "page source" link to sphinx documentation

2020-11-02 Thread Peter Maydell
On Mon, 2 Nov 2020 at 13:09, Daniel P. Berrangé wrote: > > Add a link to the top of the sidebar in every docs page that takes the > user back to the source code in gitlab. This doesn't exactly link back to the source code, which is a bit confusing I think. Eg the 'page source' link in https://ber

Re: [PATCH 1/4] gitlab: publish the docs built during CI

2020-11-02 Thread Philippe Mathieu-Daudé
On 11/2/20 2:09 PM, Daniel P. Berrangé wrote: > Most of the build jobs will create the sphinx documentation. If we > expose this as an artifact of a "pages" job in a "public" directory, it > will get published using GitLab Pages. This means a user can push a > branch with docs changes to GitLab and

Re: [PATCH-for-5.2 v3] util/cutils: Fix Coverity array overrun in freq_to_str()

2020-11-02 Thread Luc Michel
On 22:57 Sun 01 Nov , Philippe Mathieu-Daudé wrote: > Fix Coverity CID 1435957: Memory - illegal accesses (OVERRUN): > > >>> Overrunning array "suffixes" of 7 8-byte elements at element > index 7 (byte offset 63) using index "idx" (which evaluates to 7). > > Note, the biggest input value

Re: [PATCH 3/4] docs: show stdout/stderr when meson fails build test

2020-11-02 Thread Peter Maydell
On Mon, 2 Nov 2020 at 13:09, Daniel P. Berrangé wrote: > > It is hard to diagnose why Sphinx fails in a CI environment, as we > discard the stdout/err and just print a generic error message. > > Signed-off-by: Daniel P. Berrangé This kind of detailed-diagnostics should go into whatever meson's e

Re: [PATCH 0/4] Publish docs as GitLab Pages

2020-11-02 Thread Philippe Mathieu-Daudé
On 11/2/20 2:09 PM, Daniel P. Berrangé wrote: > This publishes the various docs as GitLab Pages, allowing users to > browse the docs generated in CI before sending patch series to the > mailing list. It also introduces a sidebar link to the original page > source to show readers what file to modify

Re: [PATCH-for-5.2 v3] util/cutils: Fix Coverity array overrun in freq_to_str()

2020-11-02 Thread Eduardo Habkost
On Sun, Nov 01, 2020 at 10:57:55PM +0100, Philippe Mathieu-Daudé wrote: > Fix Coverity CID 1435957: Memory - illegal accesses (OVERRUN): > > >>> Overrunning array "suffixes" of 7 8-byte elements at element > index 7 (byte offset 63) using index "idx" (which evaluates to 7). > > Note, the big

RE: [PATCH 01/14] target/arm: add arm_is_el2_enabled() helper

2020-11-02 Thread Remi Denis Courmont
Hi, > I replied to this before the cover letter explaining what the series > is doing arrived in my inbox, so the second part of my suggestion > would be a bit pointless. The first part (mentioning the name of > the pseudocode function) still seems worth doing. Yeah well, some spam filter seems t

Re: [PATCH] virtio: skip guest index check on device load

2020-11-02 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Tue, Oct 27, 2020 at 09:04:46AM -0400, Michael S. Tsirkin wrote: > > It's not a waste of time, it's just a lot of work > > within guests. > > Luckily it does no harm to set the NEEDS_RESET bit even if the guest > doesn't handle it. > > If the gu

RE: [PATCH] vhost: fix up trailing whitespace

2020-11-02 Thread Chenqun (kuhn)
> -Original Message- > From: Qemu-devel > [mailto:qemu-devel-bounces+kuhn.chenqun=huawei@nongnu.org] On > Behalf Of Michael S. Tsirkin > Sent: Monday, November 2, 2020 6:13 PM > To: qemu-devel@nongnu.org > Subject: [PATCH] vhost: fix up trailing whitespace > > Drop trailing whitespace

RE: Help on TCG asserts

2020-11-02 Thread Sai Pavan Boddu
Hi Richard, > -Original Message- > From: Richard Henderson > Sent: Wednesday, October 28, 2020 8:16 PM > To: Sai Pavan Boddu ; QEMU Developers de...@nongnu.org> > Cc: Peter Maydell ; Philippe Mathieu-Daudé > > Subject: Re: Help on TCG asserts > > On 10/27/20 9:15 PM, Sai Pavan Boddu wr

RE: [PATCH v2] pc: comment style fixup

2020-11-02 Thread Chenqun (kuhn)
> -Original Message- > From: Qemu-devel > [mailto:qemu-devel-bounces+kuhn.chenqun=huawei@nongnu.org] On > Behalf Of Michael S. Tsirkin > Sent: Monday, November 2, 2020 6:29 PM > To: qemu-devel@nongnu.org > Cc: Paolo Bonzini ; Eduardo Habkost > ; Richard Henderson > Subject: [PATCH v2]

Re: [PATCH v2 0/6] spapr/xive: Activate StoreEOI in P10 compat guests

2020-11-02 Thread Cédric Le Goater
Sorry for the late answer I was out for a couple of weeks. On 10/9/20 2:23 AM, David Gibson wrote: > On Mon, Oct 05, 2020 at 06:51:41PM +0200, Cédric Le Goater wrote: >> Hello, >> >> When an interrupt has been handled, the OS notifies the interrupt >> controller with an EOI sequence. On the XIVE i

[PATCH 3/4] docs: show stdout/stderr when meson fails build test

2020-11-02 Thread Daniel P . Berrangé
It is hard to diagnose why Sphinx fails in a CI environment, as we discard the stdout/err and just print a generic error message. Signed-off-by: Daniel P. Berrangé --- docs/meson.build | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/meson.build b/docs/meson.build

[PATCH 1/4] gitlab: publish the docs built during CI

2020-11-02 Thread Daniel P . Berrangé
Most of the build jobs will create the sphinx documentation. If we expose this as an artifact of a "pages" job in a "public" directory, it will get published using GitLab Pages. This means a user can push a branch with docs changes to GitLab and view the results at https://yourusername.gitlab.io

[PATCH 4/4] docs: add "page source" link to sphinx documentation

2020-11-02 Thread Daniel P . Berrangé
Add a link to the top of the sidebar in every docs page that takes the user back to the source code in gitlab. Signed-off-by: Daniel P. Berrangé --- docs/_templates/editpage.html | 5 + docs/conf.py | 1 + docs/devel/_templates/editpage.html | 5 + docs

[PATCH 2/4] gitlab: force enable docs build in Fedora, Ubuntu, Debian

2020-11-02 Thread Daniel P . Berrangé
Meson runs a test to see if Sphinx works, and automatically disables it on error. This can lead to the CI jobs skipping docs build without maintainers noticing the problem. Use --enable-docs to force a fatal error if Sphinx doesn't work on the jobs where we expect it to be OK. Signed-off-by: Danie

[PATCH 0/4] Publish docs as GitLab Pages

2020-11-02 Thread Daniel P . Berrangé
This publishes the various docs as GitLab Pages, allowing users to browse the docs generated in CI before sending patch series to the mailing list. It also introduces a sidebar link to the original page source to show readers what file to modify if they want to contribute to the docs. Daniel P. Be

Re: [PATCH v3 0/6] virtio-mem: block size and address-assignment optimizations

2020-11-02 Thread Michael S. Tsirkin
On Mon, Nov 02, 2020 at 01:20:11PM +0100, David Hildenbrand wrote: > On 22.10.20 10:10, David Hildenbrand wrote: > > On 08.10.20 10:30, David Hildenbrand wrote: > > > > > > > > > Let's try to detect the actual THP size and use it as default block size > > > (unless the page size of the backend in

Re: [PATCH] qmp: fix aio_poll() assertion failure on Windows

2020-11-02 Thread Mark Cave-Ayland
On 21/10/2020 07:40, Volker Rümelin wrote: Commit 9ce44e2ce2 "qmp: Move dispatcher to a coroutine" modified aio_poll() in util/aio-posix.c to avoid an assertion failure. This change is missing in util/aio-win32.c. Apply the changes to util/aio-posix.c to util/aio-win32.c too. This fixes an asse

Re: VFIO Migration

2020-11-02 Thread Cornelia Huck
On Mon, 2 Nov 2020 11:11:53 + Stefan Hajnoczi wrote: > There is discussion about VFIO migration in the "Re: Out-of-Process > Device Emulation session at KVM Forum 2020" thread. The current status > is that Kirti proposed a VFIO device region type for saving and loading > device state. There i

Re: [PATCH v3 0/6] virtio-mem: block size and address-assignment optimizations

2020-11-02 Thread David Hildenbrand
On 22.10.20 10:10, David Hildenbrand wrote: On 08.10.20 10:30, David Hildenbrand wrote: Let's try to detect the actual THP size and use it as default block size (unless the page size of the backend indicates that THP don't apply). Always allow to set a block size of 1 MiB, but warn if the conf

Re: [PATCH V3] hw/display/exynos4210_fimd: Fix potential NULL pointer dereference

2020-11-02 Thread Peter Maydell
On Mon, 2 Nov 2020 at 10:13, AlexChen wrote: > > In exynos4210_fimd_update(), the pointer 's' is dereferenced before > checking it is valid, which may lead to NULL pointer dereference. > So move the assignment to global_width after checking 's' is valid. > > Reported-by: Euler Robot > Signed-off-

Re: [PATCH V2] hw/display/omap_lcdc: Fix potential NULL pointer dereference

2020-11-02 Thread Peter Maydell
On Sat, 31 Oct 2020 at 03:35, AlexChen wrote: > > In omap_lcd_interrupts(), the pointer omap_lcd is dereferinced before > being check if it is valid, which may lead to NULL pointer dereference. > So move the assignment to surface after checking that the omap_lcd is valid > and move surface_bits_pe

Re: [PATCH] pc: comment stule fixup

2020-11-02 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > Fix up checkpatch comment style warnings. > > Signed-off-by: Michael S. Tsirkin > --- > hw/i386/pc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 416fb0e0f6..5872ae6095 100644 > --- a/hw/i386/pc

Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp

2020-11-02 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Nov 02, 2020 at 10:59:43AM +0100, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Mon, Nov 02, 2020 at 09:44:49AM +0100, Markus Armbruster wrote: >> >> Daniel P. Berrangé writes: >> >> >> >> > On Fri, Oct 30, 2020 at 11:11:19AM +0100, Mar

[PATCH v2] trace: remove argument from trace_init_file

2020-11-02 Thread Paolo Bonzini
It is not needed, all the callers are just saving what was retrieved from -trace and trace_init_file can retrieve it on its own. Signed-off-by: Paolo Bonzini --- bsd-user/main.c | 6 ++ linux-user/main.c| 6 ++ qemu-img.c

[PATCH] block/vvfat: Fix bad printf format specifiers

2020-11-02 Thread AlexChen
We should use printf format specifier "%u" instead of "%d" for argument of type "unsigned int". In addition, fix two error format problems found by checkpatch.pl: ERROR: space required after that ',' (ctx:VxV) +fprintf(stderr,"%s attributes=0x%02x begin=%u size=%d\n",

RE: [PATCH v5] introduce vfio-user protocol specification

2020-11-02 Thread Thanos Makatos
> -Original Message- > From: Qemu-devel bounces+thanos.makatos=nutanix@nongnu.org> On Behalf Of John > Levon > Sent: 02 November 2020 11:41 > To: Thanos Makatos > Cc: benjamin.wal...@intel.com; Elena Ufimtseva > ; jag.ra...@oracle.com; > james.r.har...@intel.com; Swapnil Ingle ; >

Re: [PATCH] hw/arm/boot: fix SVE for EL3 direct kernel boot

2020-11-02 Thread Peter Maydell
On Fri, 30 Oct 2020 at 18:56, Richard Henderson wrote: > > On 10/30/20 8:15 AM, r...@remlab.net wrote: > > From: Rémi Denis-Courmont > > > > When booting a CPU with EL3 using the -kernel flag, set up CPTR_EL3 so > > that SVE will not trap to EL3. > > > > Signed-off-by: Rémi Denis-Courmont > > --

Re: [PATCH-for-5.2] hw/arm/smmuv3: Fix potential integer overflow (CID 1432363)

2020-11-02 Thread Peter Maydell
On Fri, 30 Oct 2020 at 14:46, Philippe Mathieu-Daudé wrote: > > Use the BIT_ULL() macro to ensure we use 64-bit arithmetic. > This fixes the following Coverity issue (OVERFLOW_BEFORE_WIDEN): > > CID 1432363 (#1 of 1): Unintentional integer overflow: > > overflow_before_widen: > Potentially

Re: [PATCH] hw/input/ps2.c: Remove remnants of printf debug

2020-11-02 Thread Stefano Garzarella
On Sun, Nov 01, 2020 at 01:32:58PM +, Peter Maydell wrote: In commit 5edab03d4040 we added tracepoints to the ps2 keyboard and mouse emulation. However we didn't remove all the debug-by-printf support. In fact there is only one printf() remaining, and it is redundant with the trace_ps2_write_

Re: [PATCH v5] introduce vfio-user protocol specification

2020-11-02 Thread John Levon
On Mon, Nov 02, 2020 at 11:29:23AM +, Thanos Makatos wrote: > > +==++= > > ==+ > > > | version | object | ``{"major": , "minor": }`` > > > | > > > | ||

Re: [PATCH v3 4/6] hw/misc: Add npcm7xx random number generator

2020-11-02 Thread Peter Maydell
On Fri, 23 Oct 2020 at 22:06, Havard Skinnemoen wrote: > > The RNG module returns a byte of randomness when the Data Valid bit is > set. > > This implementation ignores the prescaler setting, and loads a new value > into RNGD every time RNGCS is read while the RNG is enabled and random > data is a

RE: [PATCH v5] introduce vfio-user protocol specification

2020-11-02 Thread Thanos Makatos
> -Original Message- > From: John Levon > Sent: 30 October 2020 17:03 > To: Thanos Makatos > Cc: qemu-devel@nongnu.org; benjamin.wal...@intel.com; Elena Ufimtseva > ; tomassetti.and...@gmail.com; > john.g.john...@oracle.com; jag.ra...@oracle.com; Swapnil Ingle > ; james.r.har...@intel.com

Re: [PATCH 01/14] target/arm: add arm_is_el2_enabled() helper

2020-11-02 Thread Peter Maydell
On Mon, 2 Nov 2020 at 11:06, Peter Maydell wrote: > > On Mon, 2 Nov 2020 at 10:58, wrote: > > > > From: Rémi Denis-Courmont > > > > This checks if EL2 is enabled (meaning EL2 registers take effects) in > > the current security context. > > > > Signed-off-by: Rémi Denis-Courmont > > --- > > tar

Re: target/mips: Deprecate nanoMIPS ISA?

2020-11-02 Thread Philippe Mathieu-Daudé
On 11/2/20 11:00 AM, Philippe Mathieu-Daudé wrote: > Hi Richard, > > Cc'ing developers who introduced nanoMIPS. Who are now unreachable, as I got: Your message to stefan.marko...@mips.com couldn't be delivered. Your message to smarko...@wavecomp.com couldn't be delivered. Couldn't deliver the

Re: [PATCH 1/2] scripts/kerneldoc: For Sphinx 3 use c:macro for macros with arguments

2020-11-02 Thread Stefan Hajnoczi
On Fri, Oct 30, 2020 at 5:47 PM Peter Maydell wrote: > > The kerneldoc script currently emits Sphinx markup for a macro with > arguments that uses the c:function directive. This is correct for > Sphinx versions earlier than Sphinx 3, where c:macro doesn't allow > documentation of macros with argum

Re: [PATCH 2/2] qemu-option-trace.rst.inc: Don't use option:: markup

2020-11-02 Thread Stefan Hajnoczi
On Fri, Oct 30, 2020 at 5:48 PM Peter Maydell wrote: > > Sphinx 3.2 is pickier than earlier versions about the option:: markup, > and complains about our usage in qemu-option-trace.rst: > > ../../docs/qemu-option-trace.rst.inc:4:Malformed option description > '[enable=]PATTERN', should look like

<    1   2   3   4   >