Re: Proposal for a regular upstream performance testing

Dne 30. 11. 20 v 14:23 Stefan Hajnoczi napsal(a): On Thu, Nov 26, 2020 at 09:43:38AM +, Daniel P. Berrangé wrote: On Thu, Nov 26, 2020 at 09:10:14AM +0100, Lukáš Doktor wrote: Ideally the community should have a way to also issue their custom builds in order to verify their patches so they

Re: [RFC PATCH v2 4/5] virtio-net: Added eBPF RSS to virtio-net.

On Tue, Nov 24, 2020 at 10:49 AM Jason Wang wrote: > > On 2020/11/19 下午7:13, Andrew Melnychenko wrote: > > From: Andrew > > > > When RSS is enabled the device tries to load the eBPF program > > to select RX virtqueue in the TUN. If eBPF can be loaded > > the RSS will function also with vhost (wo

Re: [PATCH] python 3.5 compatibility

Hi On Mon, Nov 30, 2020 at 10:29 PM Enrico Weigelt, metux IT consult < l...@metux.net> wrote: > On 27.11.20 20:15, Peter Maydell wrote: > > Hi, > > > Could you say which "stable distros" you have in mind, and whether > > they are covered by our "supported build platforms" policy > > https://www.q

Re: [PATCH v4 0/6] UFFD write-tracking migration/snapshots

On Thu, Nov 26, 2020 at 18:17:28 +0300, Andrey Gruzdev via wrote: > This patch series is a kind of 'rethinking' of Denis Plotnikov's ideas he's > implemented in his series '[PATCH v0 0/4] migration: add background snapshot'. Hi, I gave this a try when attempting to implement the libvirt code for

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

On 2020/12/1 1:03, Alex Williamson wrote: > On Thu, 26 Nov 2020 14:56:17 +0800 > Shenming Lu wrote: > >> Hi, >> >> After reading everyone's opinions, we have a rough idea for this issue. >> >> One key point is whether it is necessary to setup the config space before >> the device can accept furth

Re: [PATCH v4] qga: Correct loop count in qmp_guest_get_vcpus()

Hi On Tue, Dec 1, 2020 at 10:14 AM Lin Ma wrote: > The guest-get-vcpus returns incorrect vcpu info in case we hotunplug > vcpus(not > the last one). > e.g.: > A VM has 4 VCPUs: cpu0 + 3 hotunpluggable online vcpus(cpu1, cpu2 and > cpu3). > Hotunplug cpu2, Now only cpu0, cpu1 and cpu3 are presen

Re: [PATCH] python 3.5 compatibility

"Enrico Weigelt, metux IT consult" writes: > On 27.11.20 20:15, Peter Maydell wrote: > > Hi, > >> Could you say which "stable distros" you have in mind, and whether >> they are covered by our "supported build platforms" policy >> https://www.qemu.org/docs/master/system/build-platforms.html ? > >

[PATCH] qemu-nbd: Fix a memleak in nbd_client_thread()

When the qio_channel_socket_connect_sync() fails we should goto 'out_socket' label to free the 'sioc' instead of goto 'out' label. In addition, now the 'out' label is useless, delete it. Reported-by: Euler Robot Signed-off-by: Alex Chen --- qemu-nbd.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH v4] qga: Correct loop count in qmp_guest_get_vcpus()

The guest-get-vcpus returns incorrect vcpu info in case we hotunplug vcpus(not the last one). e.g.: A VM has 4 VCPUs: cpu0 + 3 hotunpluggable online vcpus(cpu1, cpu2 and cpu3). Hotunplug cpu2, Now only cpu0, cpu1 and cpu3 are present & online. ./qmp-shell /tmp/qmp-monitor.sock (QEMU) query-hotplu

Re: [PATCH 1/6] migration: Add multi-thread compress method

On 2020/11/30 16:35, Markus Armbruster wrote: > Zeyu Jin writes: > >> On 2020/11/27 17:48, Markus Armbruster wrote: >>> Kevin, Max, suggest to skip right to Qcow2CompressionType. >>> >>> Zeyu Jin writes: >>> A multi-thread compress method parameter is added to hold the method we are go

Re: [PATCH v2 4/6] migration: Add zstd support in multi-thread compression

On 2020/12/1 0:43, Eric Blake wrote: > On 11/27/20 3:32 AM, Zeyu Jin wrote: >> This patch enables zstd option in multi-thread compression. >> >> Signed-off-by: Zeyu Jin >> Signed-off-by: Ying Fang >> --- > >> +++ b/qapi/migration.json >> @@ -536,7 +536,7 @@ >> # >> ## >> { 'enum': 'CompressMe

Re: [PATCH v2 0/6] migration: Multi-thread compression method support

On 2020/12/1 0:42, Eric Blake wrote: > On 11/27/20 3:36 AM, Zeyu Jin wrote: > > Meta-comment: you appear to be having problems threading your series; > I've now seen three separate cover letters (RFC v1, v2 with no subject, > v2 with subject) and two series where each patch was a separate thread.

Re: [PATCH] hw/net/dp8393x: fix integer underflow in dp8393x_do_transmit_packets()

On 2020/11/30 下午8:11, Mauro Matteo Cascella wrote: On Mon, Nov 30, 2020 at 11:44 AM Philippe Mathieu-Daudé wrote: +Laurent/Finn On 11/24/20 10:24 AM, Mauro Matteo Cascella wrote: An integer underflow could occur during packet transmission due to 'tx_len' not being updated if SONIC_TFC regis

Re: [PATCH v2] net/e1000e_core: adjust count if RDH exceeds RDT in e1000e_ring_advance()

On 2020/11/30 下午10:12, Mauro Matteo Cascella wrote: On Mon, Nov 30, 2020 at 3:58 AM Jason Wang wrote: On 2020/11/27 下午10:49, Mauro Matteo Cascella wrote: On Fri, Nov 27, 2020 at 6:21 AM Jason Wang wrote: On 2020/11/24 上午5:30, Mauro Matteo Cascella wrote: On Thu, Nov 19, 2020 at 6:57 AM J

RE: [EXTERNAL] Re: [PATCH] WHPX: support for the kernel-irqchip on/off

> It's close enough to the release that you can resend (or if no rebasing > is needed, just tell me). > > Paolo Thank you. No rebasing needed; the same patch applies on the current master.

Re: [RFC PATCH-for-5.2] gitlab-ci: Do not automatically run Avocado integration tests anymore

On Fri, Nov 27, 2020 at 06:41:10PM +0100, Philippe Mathieu-Daudé wrote: > We lately realized that the Avocado framework was not designed > to be regularly run on CI environments. Therefore, as of 5.2 Hi Phil, First of all, let me say that I understand your overall goal, and although I don't agree

[PATCH 1/1] target-riscv: support QMP dump-guest-memory

Add the support needed for creating prstatus elf notes. Now elf notes only contains user_regs. This allows us to use QMP dump-guest-memory. Signed-off-by: Yifei Jiang Signed-off-by: Mingwang Li --- target/riscv/arch_dump.c | 189 +++ target/riscv/cpu.c

[PATCH 0/1] target-riscv: support QMP dump-guest-memory

Hi, This patch supports QMP dump-guest-memory in RISC-V. We tested this feature by using following command: dump-guest-memory guest.memory. Then we used the gdb tool to debug guest.memory: gdb vmlinux guest.memory. The test result is as follow: 1. info registers ra 0xffe0008cb83c

Re: [PATCH 2/8] hvf: Move common code out

On Mon, Nov 30, 2020 at 2:10 PM Peter Maydell wrote: > On Mon, 30 Nov 2020 at 20:56, Frank Yang wrote: > > We'd actually like to contribute upstream too :) We do want to maintain > > our own downstream though; Android Emulator codebase needs to work > > solidly on macos and windows which has mad

Re: [PATCH] target/riscv: Fix definition of MSTATUS_TW and MSTATUS_TSR

On Mon, Nov 30, 2020 at 9:07 AM Alex Richardson wrote: > > The TW and TSR fields should be bits 21 and 22 and not 30/29. > This was found while comparing QEMU behaviour against the sail formal > model (https://github.com/rems-project/sail-riscv/). > > Signed-off-by: Alex Richardson Reviewed-by:

Re: [PATCH] target/riscv: Fix the bug of HLVX/HLV/HSV

On Sun, Nov 29, 2020 at 5:37 PM Yifei Jiang wrote: > > We found that the hypervisor virtual-machine load and store instructions, > included HLVX/HLV/HSV, couldn't access guest userspace memory. > > In the riscv-privileged spec, HLVX/HLV/HSV is defined as follow: > "As usual when V=1, two-stage add

Re: [PATCH-for-5.2? 1/4] hw/arm/fsl-imx: Add SD bus QOM alias on the SoC

On Tue, Nov 24, 2020 at 1:54 AM Philippe Mathieu-Daudé wrote: > > To be able to select a particular SD bus from the command > line, add a QOM alias on the SoC (using an unique name). > > Buglink: https://bugs.launchpad.net/qemu/+bug/1895895 > Reported-by: David Aghaian > Suggested-by: Peter Mayde

Re: [PATCH-for-5.2? 4/4] hw/arm/xilinx_zynq: Add SD bus QOM alias on the machine

On Tue, Nov 24, 2020 at 1:50 AM Philippe Mathieu-Daudé wrote: > > To be able to select a particular SD bus from the command > line, add a QOM alias on the machine (using an unique name). > > Suggested-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alis

Re: [PATCH-for-5.2? 3/4] hw/arm/xlnx-versal: Add SD bus QOM alias on the SoC

On Tue, Nov 24, 2020 at 1:51 AM Philippe Mathieu-Daudé wrote: > > To be able to select a particular SD bus from the command > line, add a QOM alias on the SoC (using an unique name). > > Suggested-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair

Re: [PATCH 2/2] hw/ssi: imx_spi: Disable chip selects in imx_spi_reset()

On Sun, Nov 29, 2020 at 8:05 PM Bin Meng wrote: > > From: Xuzhou Cheng > > When a write to ECSPI_CONREG register to disable the SPI controller, > imx_spi_reset() is called to reset the controller, during which CS > lines should have been disabled, otherwise the state machine of any > devices (e.g

Re: [PATCH 1/2] hw/ssi: imx_spi: Use a macro for number of chip selects supported

On Sun, Nov 29, 2020 at 8:06 PM Bin Meng wrote: > > From: Bin Meng > > Avoid using a magic number (4) everywhere for the number of chip > selects supported. > > Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Alistair > --- > > hw/ssi/imx_spi.c | 4 ++-- > include/hw/ssi/imx_s

Re: [PATCH-for-5.2? 2/4] hw/arm/exynos4210: Add SD bus QOM alias on the SoC

On Tue, Nov 24, 2020 at 1:55 AM Philippe Mathieu-Daudé wrote: > > To be able to select a particular SD bus from the command > line, add a QOM alias on the SoC (using an unique name). > > Suggested-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair

[Bug 1906156] Re: Host OS Reboot Required, for Guest kext to Load (Fully)

Sure, will do (upstream version). Is there a preferred way to do it? Meaning ... build locally, or install from some repository? Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1906156 Title:

Re: [PATCH 2/8] hvf: Move common code out

On Mon, Nov 30, 2020 at 10:40:49PM +0100, Alexander Graf wrote: > Hi Peter, > > On 30.11.20 22:08, Peter Collingbourne wrote: > > On Mon, Nov 30, 2020 at 12:56 PM Frank Yang wrote: > > > > > > > > > On Mon, Nov 30, 2020 at 12:34 PM Alexander Graf wrote: > > > > Hi Frank, > > > > > > > > Thank

Re: [PATCH 2/8] hvf: Move common code out

On 01.12.20 01:00, Peter Collingbourne wrote: On Mon, Nov 30, 2020 at 3:18 PM Alexander Graf wrote: On 01.12.20 00:01, Peter Collingbourne wrote: On Mon, Nov 30, 2020 at 1:40 PM Alexander Graf wrote: Hi Peter, On 30.11.20 22:08, Peter Collingbourne wrote: On Mon, Nov 30, 2020 at 12:56 P

Re: [PATCH 2/8] hvf: Move common code out

On Mon, Nov 30, 2020 at 3:18 PM Alexander Graf wrote: > > > On 01.12.20 00:01, Peter Collingbourne wrote: > > On Mon, Nov 30, 2020 at 1:40 PM Alexander Graf wrote: > >> Hi Peter, > >> > >> On 30.11.20 22:08, Peter Collingbourne wrote: > >>> On Mon, Nov 30, 2020 at 12:56 PM Frank Yang wrote: > >>

Re: [PATCH 2/8] hvf: Move common code out

On 01.12.20 00:01, Peter Collingbourne wrote: On Mon, Nov 30, 2020 at 1:40 PM Alexander Graf wrote: Hi Peter, On 30.11.20 22:08, Peter Collingbourne wrote: On Mon, Nov 30, 2020 at 12:56 PM Frank Yang wrote: On Mon, Nov 30, 2020 at 12:34 PM Alexander Graf wrote: Hi Frank, Thanks for th

Re: [PATCH 2/8] hvf: Move common code out

On Mon, Nov 30, 2020 at 1:40 PM Alexander Graf wrote: > > Hi Peter, > > On 30.11.20 22:08, Peter Collingbourne wrote: > > On Mon, Nov 30, 2020 at 12:56 PM Frank Yang wrote: > >> > >> > >> On Mon, Nov 30, 2020 at 12:34 PM Alexander Graf wrote: > >>> Hi Frank, > >>> > >>> Thanks for the update :).

Re: [PATCH 2/8] hvf: Move common code out

On Mon, Nov 30, 2020 at 12:56 PM Frank Yang wrote: > > > > On Mon, Nov 30, 2020 at 12:34 PM Alexander Graf wrote: >> >> Hi Frank, >> >> Thanks for the update :). Your previous email nudged me into the right >> direction. I previously had implemented WFI through the internal timer >> framework w

Re: [PATCH 2/8] hvf: Move common code out

On Mon, 30 Nov 2020 at 20:56, Frank Yang wrote: > We'd actually like to contribute upstream too :) We do want to maintain > our own downstream though; Android Emulator codebase needs to work > solidly on macos and windows which has made keeping up with upstream difficult One of the main reasons w

Re: [PATCH] qmp-shell: Sort by key when pretty-printing

On Monday, 2020-11-30 at 15:56:51 -05, John Snow wrote: > On 10/13/20 10:14 AM, David Edmondson wrote: >> If the user selects pretty-printing (-p) the contents of any >> dictionaries in the output are sorted by key. >> >> Signed-off-by: David Edmondson >> --- >> scripts/qmp/qmp-shell | 2 +- >>

Re: [RFC PATCH-for-5.2] gitlab-ci: Do not automatically run Avocado integration tests anymore

On Fri, Nov 27, 2020 at 2:41 PM Philippe Mathieu-Daudé wrote: > > We lately realized that the Avocado framework was not designed > to be regularly run on CI environments. Therefore, as of 5.2 > we deprecate the gitlab-ci jobs using Avocado. To not disrupt > current users, it is possible to keep th

Re: [PATCH 2/8] hvf: Move common code out

Hi Peter, On 30.11.20 22:08, Peter Collingbourne wrote: On Mon, Nov 30, 2020 at 12:56 PM Frank Yang wrote: On Mon, Nov 30, 2020 at 12:34 PM Alexander Graf wrote: Hi Frank, Thanks for the update :). Your previous email nudged me into the right direction. I previously had implemented WFI t

Re: [PATCH-for-6.0 v4 15/17] gitlab-ci: Add test for Xen (on CentOS 7)

On Fri, 27 Nov 2020, Anthony PERARD wrote: > On Thu, Nov 26, 2020 at 12:45:59PM -0500, Eduardo Habkost wrote: > > On Thu, Nov 26, 2020 at 05:38:24PM +, Anthony PERARD wrote: > > > Is `make check` going to do something useful with the Xen support? Or is > > > it going to need more work in order

Re: [PATCH 2/8] hvf: Move common code out

On Mon, Nov 30, 2020 at 12:56 PM Frank Yang wrote: > > > > On Mon, Nov 30, 2020 at 12:34 PM Alexander Graf wrote: >> >> Hi Frank, >> >> Thanks for the update :). Your previous email nudged me into the right >> direction. I previously had implemented WFI through the internal timer >> framework w

Re: [PATCH v2 07/12] tpm: put some tpm devices into the correct category

On 11/30/20 3:36 AM, Gan Qixin wrote: Some tpm devices have no category, put them into the correct category. Signed-off-by: Gan Qixin --- Cc: Stefan Berger --- hw/tpm/tpm_tis_isa.c| 1 + hw/tpm/tpm_tis_sysbus.c | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/tpm/tpm_tis_isa.c

Re: [PATCH] qmp-shell: Sort by key when pretty-printing

On 10/13/20 10:14 AM, David Edmondson wrote: If the user selects pretty-printing (-p) the contents of any dictionaries in the output are sorted by key. Signed-off-by: David Edmondson --- scripts/qmp/qmp-shell | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qmp/qmp

Re: [PATCH v2] hw/nvme: Move NVMe emulation out of hw/block/ directory

On Nov 30 15:52, Philippe Mathieu-Daudé wrote: > As IDE used to be, NVMe emulation is becoming an active > subsystem. Move it into its own namespace. > > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: Rebased after nvme-ns got merged in commit 8680d6e3646 > --- > meson.build

Re: [PATCH 2/8] hvf: Move common code out

Update: We're not quite sure how to compare the CNTV_CVAL and CNTVCT. But the high CPU usage seems to be mitigated by having a poll interval (like KVM does) in handling WFI: https://android-review.googlesource.com/c/platform/external/qemu/+/1512501 This is loosely inspired by https://elixir.bootl

[Bug 1906295] Re: Implementation of exclusive monitor in ARM

QEMU's load/store exclusive implementation is known to not be architecturally compliant. Most notably, it works on virtual addresses and the architecture specifies that exclusives are supposed to work on physical addresses. We provide a "good enough for what real code (not weird test cases) needs"

Re: [RFC] ich9:cpuhp: add support for cpu hot-unplug with SMI broadcast enabled

On 2020-11-30 8:58 a.m., Laszlo Ersek wrote: On 11/28/20 00:48, Ankur Arora wrote: It is possible that there are CPUs with bits for both is_inserting and is_removing. In that case QemuCpuhpCollectApicIds() would put them in the PluggedApicIds array and the unplug eventually happens in the next

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

On 30/11/20 19:10, Kevin Wolf wrote: Am 30.11.2020 um 17:57 hat Paolo Bonzini geschrieben: The main problem is that it wouldn't extend well, if at all, to machines and devices. So those would still not be integrated into the QAPI schema. What do you think is the biggest difference there? Don'

Re: [PATCH v4 6/6] introduce simple linear scan rate limiting mechanism

On 30.11.2020 19:40, Peter Xu wrote: On Mon, Nov 30, 2020 at 11:11:00AM +0300, Andrey Gruzdev wrote: On 28.11.2020 01:28, Peter Xu wrote: On Thu, Nov 26, 2020 at 06:17:34PM +0300, Andrey Gruzdev wrote: Since reading UFFD events and saving paged data are performed from the same thread, write fa

Re: [PATCH v4 3/6] support UFFD write fault processing in ram_save_iterate()

On 30.11.2020 19:32, Peter Xu wrote: On Mon, Nov 30, 2020 at 12:14:03AM +0300, Andrey Gruzdev wrote: +#ifdef CONFIG_LINUX +/** + * ram_find_block_by_host_address: find RAM block containing host page + * + * Returns pointer to RAMBlock if found, NULL otherwise + * + * @rs: current RAM state + * @

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

On Mon, Nov 30, 2020 at 13:25:20 +0100, Kevin Wolf wrote: > This series adds a QAPI type for the properties of all user creatable > QOM types and finally makes QMP object-add use the new ObjectOptions > union so that QAPI introspection can be used for user creatable objects. FYI, here's a libvirt

Re: [PATCH] qemu-nbd: Fix a memleak in qemu_nbd_client_list()

On 11/30/20 6:36 AM, Alex Chen wrote: > When the qio_channel_socket_connect_sync() fails > we should goto 'out' label to free the 'sioc' instead of return. > > Reported-by: Euler Robot > Signed-off-by: Alex Chen > --- > qemu-nbd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) A local

[Bug 1906295] [NEW] Implementation of exclusive monitor in ARM

Public bug reported: Hi I refer to the implementation of exclusive monitor in ARM32. For instruction like STREX Rx,Ry,[Rz], we need to check whether the address [Rz] is in exclusive state. If not, we set the value Rx as 1 without doing the store operation. However, I noticed that QEMU will not ch

Re: [PATCH v4 2/6] introduce UFFD-WP low-level interface helpers

On 30.11.2020 18:34, Peter Xu wrote: On Sun, Nov 29, 2020 at 11:12:10PM +0300, Andrey Gruzdev wrote: +void ram_write_tracking_stop(void) +{ +#ifdef CONFIG_LINUX +RAMState *rs = ram_state; +RAMBlock *bs; +assert(rs->uffdio_fd >= 0); Maybe too harsh - we can return if it's invalid.

Re: QMP and the 'id' parameter

On 11/23/20 1:57 AM, Markus Armbruster wrote: (Was it not possible to have the client send an ACK response that doesn't indicate success, but just signals receipt? Semantically, it would be the difference between do-x and start-x as a command.) Feels quite possible to me. If I read git-log corr

Re: [PATCH for-6.0 v2 1/3] spapr: Improve naming of some vCPU id related items

On Mon, 30 Nov 2020 18:32:27 +0100 Cédric Le Goater wrote: > On 11/30/20 5:52 PM, Greg Kurz wrote: > > The machine tells the IC backend the number of vCPU ids it will be > > exposed to, in order to: > > - fill the "ibm,interrupt-server-ranges" property in the DT (XICS) > > - size the VP block use

Re: [PATCH 4/4] elf_ops.h: Be more verbose with ROM blob names

On 11/29/20 2:39 PM, Peter Maydell wrote: > Instead of making the ROM blob name something like: > phdr #0: /home/petmay01/linaro/qemu-misc-tests/ldmia-fault.axf > make it a little more self-explanatory for people who don't know > ELF format details: > /home/petmay01/linaro/qemu-misc-tests/ldmia

Re: [PATCH] python 3.5 compatibility

On 30.11.20 10:44, Kevin Wolf wrote: Hi, > While type hints are valuable documentation, they are more than just > that. They help to find and prevent avoidable bugs in the code. We are > actively in the process of adding them to everything in the QAPI > generator to improve maintainability rather

Re: [PATCH] python 3.5 compatibility

On 27.11.20 20:15, Peter Maydell wrote: Hi, > Could you say which "stable distros" you have in mind, and whether > they are covered by our "supported build platforms" policy > https://www.qemu.org/docs/master/system/build-platforms.html ? I'm running on Devuan Ascii. And packaging python-3.6 j

Re: [PATCH 3/4] elf_ops.h: Don't truncate name of the ROM blobs we create

On 11/29/20 2:39 PM, Peter Maydell wrote: > Currently the load_elf code assembles the ROM blob name into a > local 128 byte fixed-size array. Use g_strdup_printf() instead so > that we don't truncate the pathname if it happens to be long. > (This matters mostly for monitor 'info roms' output and fo

Re: [PATCH 2/4] hw/core/loader.c: Improve reporting of ROM overlap errors

On 11/29/20 2:39 PM, Peter Maydell wrote: > In rom_check_and_register_reset() we report to the user if there is > a "ROM region overlap". This has a couple of problems: > * the reported information is not very easy to intepret > * the function just prints the overlap to stderr (and relies on >

Re: [PATCH 1/4] hw/core/loader.c: Track last-seen ROM in rom_check_and_register_reset()

On 11/29/20 2:39 PM, Peter Maydell wrote: > In rom_check_and_register_reset() we detect overlaps by looking at > whether the ROM blob we're currently examining is in the same address > space and starts before the previous ROM blob ends. (This works > because the ROM list is kept sorted in order by

Re: [PATCH] target/mips: Allow executing MSA instructions on Loongson-3A4000

On 11/30/20 4:22 AM, Philippe Mathieu-Daudé wrote: > The Loongson-3A4000 is a GS464V-based processor with MIPS MSA ASE: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg763059.html > > Commit af868995e1b correctly set the 'MSA present' bit of Config3 > register, but forgot to allow the MSA

Re: [PATCH] decodetree: Allow use of hex/bin format for argument field values

On 11/30/20 6:26 AM, Philippe Mathieu-Daudé wrote: > # 'Foo=number' sets an argument field to a constant value > -if re.fullmatch(re_C_ident + '=[+-]?[0-9]+', t): > +if re.fullmatch(re_C_ident + '=[+-]?(0[bx])?[0-9]+', t): > (fname, value) = t.split('=') > -

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

Am 30.11.2020 um 17:57 hat Paolo Bonzini geschrieben: > On 30/11/20 16:46, Kevin Wolf wrote: > > Am 30.11.2020 um 15:58 hat Paolo Bonzini geschrieben: > > > With this series it's basically pointless to have QOM properties at > > > all. > > > > Not entirely, because there are still some writable pr

Re: [PATCH for-6.0 v2 1/3] spapr: Improve naming of some vCPU id related items

On 11/30/20 6:32 PM, Cédric Le Goater wrote: > On 11/30/20 5:52 PM, Greg Kurz wrote: >> The machine tells the IC backend the number of vCPU ids it will be >> exposed to, in order to: >> - fill the "ibm,interrupt-server-ranges" property in the DT (XICS) >> - size the VP block used by the in-kernel c

Re: [PATCH for-6.0 v2 2/3] spapr/xive: Fix size of END table and number of claimed IPIs

On 11/30/20 5:52 PM, Greg Kurz wrote: > The sPAPR XIVE device has an internal ENDT table the size of > which is configurable by the machine. This table is supposed > to contain END structures for all possible vCPUs that may > enter the guest. The machine must also claim IPIs for all > possible vCPU

[PATCH 2/3] tests/acceptance: verify s390x device detection

The kernel/initrd combination does not provide the virtio-net driver; therefore, simply check whether the presented device type is indeed virtio-net for the two virtio-net-{ccw,pci} devices. Signed-off-by: Cornelia Huck --- tests/acceptance/machine_s390_ccw_virtio.py | 11 +++ 1 file cha

[PATCH 1/3] tests/acceptance: test virtio-ccw revision handling

The max_revision prop of virtio-ccw devices can be used to force an older revision for compatibility handling. The easiest way to check this is to force a device to revision 0, which turns off virtio-1. Signed-off-by: Cornelia Huck --- tests/acceptance/machine_s390_ccw_virtio.py | 18 +++

[PATCH 3/3] tests/acceptance: test s390x zpci fid propagation

Verify that a fid specified on the command line shows up correctly as the function_id in the guest. Signed-off-by: Cornelia Huck --- tests/acceptance/machine_s390_ccw_virtio.py | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/tests/acceptance/machine_s390_ccw_virt

[PATCH 0/3] tests/acceptance: enhance s390x devices test

This series builds upon the new s390x acceptance test currently queued on my s390-next branch. Sadly, the kernel/initrd I'm using does not have the virtio-net driver, so I cannot test things like mac address specification etc. Instead, I added some quick checks regarding legacy virtio and propagat

Re: ImageInfo oddities regarding compression

On Fri, Nov 27, 2020 at 05:52:09PM +0100, Markus Armbruster wrote: > Kevin Wolf writes: > > > Am 27.11.2020 um 13:21 hat Markus Armbruster geschrieben: > >> >> I fell down this (thankfully shallow) rabbit hole because we also have > >> >> > >> >> { 'enum': 'MultiFDCompression', > >> >>

Re: [PATCH for-6.0 v2 1/3] spapr: Improve naming of some vCPU id related items

On 11/30/20 5:52 PM, Greg Kurz wrote: > The machine tells the IC backend the number of vCPU ids it will be > exposed to, in order to: > - fill the "ibm,interrupt-server-ranges" property in the DT (XICS) > - size the VP block used by the in-kernel chip (XICS-on-XIVE, XIVE) > > The current "nr_serve

Re: [PATCH for-6.0 v2 0/3] spapr: Address the confusion between IPI numbers and vCPU ids

On 11/30/20 5:52 PM, Greg Kurz wrote: > A regression was recently fixed in the sPAPR XIVE code for QEMU 5.2 > RC3 [1]. It boiled down to a confusion between IPI numbers and vCPU > ids, which happen to be numerically equal in general, but are really > different entities that can diverge in some setu

Re: ImageInfo oddities regarding compression

On 11/27/20 4:32 AM, Kevin Wolf wrote: >>>## >>># @Qcow2CompressionType: >>># >>># Compression type used in qcow2 image file >>># >>># @zlib: zlib compression, see >>># @zstd: zstd compression, see >>># >>># S

[Bug 498523] Re: Add on-line write compression support to qcow2

The compression filter can be used e.g. with -drive driver=compress,file.driver=qcow2,file.file.filename=foo.qcow2. However, it shouldn’t be used lightly, as it will only do the right thing in very specific circumstances, namely every cluster that’s written to must not be allocated already. So wri

Re: [PATCH v1 8/9] virtio-mem: Require only coordinated discards

* David Hildenbrand (da...@redhat.com) wrote: > We implement the RamDiscardMgr interface and only require coordinated > discarding of RAM to work. > > Cc: Paolo Bonzini > Cc: "Michael S. Tsirkin" > Cc: Alex Williamson > Cc: Dr. David Alan Gilbert > Cc: Igor Mammedov > Cc: Pankaj Gupta > Cc:

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

On 11/16/20 2:10 PM, Roman Bolshakov wrote: > There's a problem for management applications to determine if certain > accelerators available. Generic QMP command should help with that. > > Signed-off-by: Roman Bolshakov > --- > monitor/qmp-cmds.c | 15 +++ > qapi/machine.json | 19 +

[PATCH] target/riscv: Fix definition of MSTATUS_TW and MSTATUS_TSR

The TW and TSR fields should be bits 21 and 22 and not 30/29. This was found while comparing QEMU behaviour against the sail formal model (https://github.com/rems-project/sail-riscv/). Signed-off-by: Alex Richardson --- target/riscv/cpu_bits.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

Re: [RFC PATCH 18/25] hw/cxl/device: Add a memory device (8.2.8.5)

On 20-11-26 07:36:23, Markus Armbruster wrote: > Ben Widawsky writes: > > > On 20-11-13 08:47:59, Markus Armbruster wrote: > >> Eric Blake writes: > >> > >> > On 11/10/20 11:47 PM, Ben Widawsky wrote: > >> >> A CXL memory device (AKA Type 3) is a CXL component that contains some > >> >> combina

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

On Thu, 26 Nov 2020 14:56:17 +0800 Shenming Lu wrote: > Hi, > > After reading everyone's opinions, we have a rough idea for this issue. > > One key point is whether it is necessary to setup the config space before > the device can accept further migration data. I think it is decided by > the ve

Re: [RFC] ich9:cpuhp: add support for cpu hot-unplug with SMI broadcast enabled

On 11/28/20 01:43, Ankur Arora wrote: > On 2020-11-27 7:19 a.m., Laszlo Ersek wrote: >> On 11/27/20 05:10, Ankur Arora wrote: >> >>> Yeah I was wondering what would happen for simultaneous hot add and >>> remove. >>> I guess we would always do remove first and then the add, unless we hit >>> the br

Re: [RFC] ich9:cpuhp: add support for cpu hot-unplug with SMI broadcast enabled

On 11/28/20 00:48, Ankur Arora wrote: > It is possible that there are CPUs with bits for both is_inserting and > is_removing. In that case QemuCpuhpCollectApicIds() would put them in the > PluggedApicIds array and the unplug eventually happens in the next > firmware invocation. > > If a CPU has b

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

On 30/11/20 16:46, Kevin Wolf wrote: Am 30.11.2020 um 15:58 hat Paolo Bonzini geschrieben: With this series it's basically pointless to have QOM properties at all. Not entirely, because there are still some writable properties that can be changed later on. Are there really any (that are not

Re: [PATCH v2 0/4] [RfC] fix tracing for modules

On Tue, Nov 24, 2020 at 05:02:51PM +0100, Gerd Hoffmann wrote: > First version that actually works. Only qxl covered for this RfC, other > modules will follow once the basics are hashed out. > > More context: > https://bugzilla.redhat.com/show_bug.cgi?id=1898700 > https://bugzilla.redhat.com/

[PATCH for-6.0 v2 1/3] spapr: Improve naming of some vCPU id related items

The machine tells the IC backend the number of vCPU ids it will be exposed to, in order to: - fill the "ibm,interrupt-server-ranges" property in the DT (XICS) - size the VP block used by the in-kernel chip (XICS-on-XIVE, XIVE) The current "nr_servers" and "spapr_max_server_number" naming can misle

[PATCH for-6.0 v2 2/3] spapr/xive: Fix size of END table and number of claimed IPIs

The sPAPR XIVE device has an internal ENDT table the size of which is configurable by the machine. This table is supposed to contain END structures for all possible vCPUs that may enter the guest. The machine must also claim IPIs for all possible vCPUs since this is expected by the guest. spapr_ir

[PATCH for-6.0 v2 0/3] spapr: Address the confusion between IPI numbers and vCPU ids

A regression was recently fixed in the sPAPR XIVE code for QEMU 5.2 RC3 [1]. It boiled down to a confusion between IPI numbers and vCPU ids, which happen to be numerically equal in general, but are really different entities that can diverge in some setups. This was causing QEMU to misconfigure XIVE

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

On Mon, Nov 30, 2020 at 05:13:57PM +0100, Kevin Wolf wrote: > Am 30.11.2020 um 16:30 hat Daniel P. Berrangé geschrieben: > > On Mon, Nov 30, 2020 at 03:58:23PM +0100, Paolo Bonzini wrote: > > > On 30/11/20 13:25, Kevin Wolf wrote: > > > > This series adds a QAPI type for the properties of all us

[PATCH for-6.0 v2 3/3] spapr/xive: Fix the "ibm, xive-lisn-ranges" property

The dt() callback of the sPAPR IC class has a "nr_servers" argument which is used by both XIVE and XICS to setup the "interrupt-controller" node in the DT. The machine currently passes spapr_max_server_number() to spapr_irq_dt(). This is perfectly fine to populate the range of vCPU ids in the "ibm

Re: [RFC PATCH-for-5.2] gitlab-ci: Do not automatically run Avocado integration tests anymore

On Mon, Nov 30, 2020 at 10:31:09AM +, Daniel P. Berrangé wrote: > On Fri, Nov 27, 2020 at 07:29:31PM +0100, Thomas Huth wrote: > > On 27/11/2020 18.57, Philippe Mathieu-Daudé wrote: > > > On 11/27/20 6:47 PM, Thomas Huth wrote: > > >> On 27/11/2020 18.41, Philippe Mathieu-Daudé wrote: > > >>

Re: [PATCH v2 4/6] migration: Add zstd support in multi-thread compression

On 11/27/20 3:32 AM, Zeyu Jin wrote: > This patch enables zstd option in multi-thread compression. > > Signed-off-by: Zeyu Jin > Signed-off-by: Ying Fang > --- > +++ b/qapi/migration.json > @@ -536,7 +536,7 @@ > # > ## > { 'enum': 'CompressMethod', > - 'data': [ 'zlib' ] } > + 'data': [ 'z

Re: [PATCH v2 0/6] migration: Multi-thread compression method support

On 11/27/20 3:36 AM, Zeyu Jin wrote: Meta-comment: you appear to be having problems threading your series; I've now seen three separate cover letters (RFC v1, v2 with no subject, v2 with subject) and two series where each patch was a separate thread. It is difficult to follow which messages are re

Re: [PATCH v4 6/6] introduce simple linear scan rate limiting mechanism

On Mon, Nov 30, 2020 at 11:11:00AM +0300, Andrey Gruzdev wrote: > On 28.11.2020 01:28, Peter Xu wrote: > > On Thu, Nov 26, 2020 at 06:17:34PM +0300, Andrey Gruzdev wrote: > > > Since reading UFFD events and saving paged data are performed > > > from the same thread, write fault latencies are sensit

Re: [PATCH v4 3/6] support UFFD write fault processing in ram_save_iterate()

On Mon, Nov 30, 2020 at 12:14:03AM +0300, Andrey Gruzdev wrote: > > > +#ifdef CONFIG_LINUX > > > +/** > > > + * ram_find_block_by_host_address: find RAM block containing host page > > > + * > > > + * Returns pointer to RAMBlock if found, NULL otherwise > > > + * > > > + * @rs: current RAM state > >

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

On 30/11/20 16:30, Daniel P. Berrangé wrote: { 'struct': 'QCryptoSecretCommon', 'base': 'Object', 'state': { 'rawdata': '*uint8_t', 'rawlen': 'size_t' }, 'data': { '*format': 'QCryptoSecretFormat', '*keyid': 'str', '*iv': 'str' } } { 'struct': 'QC

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

Am 30.11.2020 um 16:30 hat Daniel P. Berrangé geschrieben: > On Mon, Nov 30, 2020 at 03:58:23PM +0100, Paolo Bonzini wrote: > > On 30/11/20 13:25, Kevin Wolf wrote: > > > This series adds a QAPI type for the properties of all user creatable > > > QOM types and finally makes QMP object-add use the

[PATCH v7] introduce vfio-user protocol specification

This patch introduces the vfio-user protocol specification (formerly known as VFIO-over-socket), which is designed to allow devices to be emulated outside QEMU, in a separate process. vfio-user reuses the existing VFIO defines, structs and concepts. It has been earlier discussed as an RFC in: "RFC

Re: [PATCH for-6.0 6/6] qapi: Deprecate 'query-kvm'

Peter Krempa writes: > On Mon, Nov 30, 2020 at 10:21:08 +0100, Markus Armbruster wrote: >> Peter Krempa writes: >> >> > On Fri, Nov 27, 2020 at 16:44:05 +0100, Markus Armbruster wrote: >> >> Peter Krempa writes: > > [...] > >> > I know it's hard to enforce, but probably the cheapest in terms o

Re: [PATCH 01/18] qapi/qom: Add ObjectOptions for iothread

Am 30.11.2020 um 16:00 hat Paolo Bonzini geschrieben: > On 30/11/20 13:25, Kevin Wolf wrote: > > +## > > +# @IothreadProperties: > > +# > > +# Properties for iothread objects. > > +# > > +# @poll-max-ns: the maximum number of nanoseconds to busy wait for events. > > +# 0 means polling

Re: [PATCH] virtio: reset device on bad guest index in virtio_load()

No, but how about sending the patch to me and the mailing list? I didn't get it through either channel. On Mon, Nov 30, 2020 at 03:51:13PM +, John Levon wrote: > On Fri, Nov 20, 2020 at 06:51:07PM +, John Levon wrote: > > > If we find a queue with an inconsistent guest index value, expl

  1   2   3   >