[PATCH v3] docs: Build and install all the docs in a single manual

2021-01-15 Thread Peter Maydell
When we first converted our documentation to Sphinx, we split it into multiple manuals (system, interop, tools, etc), which are all built separately. The primary driver for this was wanting to be able to avoid shipping the 'devel' manual to end-users. However, this is working against the grain

Realize methods realizing "sideways" in the composition tree

2021-01-15 Thread Markus Armbruster
Perhaps I'm slow on the uptake today... We have typedef struct XHCIPciState { /*< private >*/ PCIDevice parent_obj; /*< public >*/ (1) XHCIState xhci; OnOffAuto msi; OnOffAuto msix; } XHCIPciState; This is a PCI device that contains a

Re: Windows installer builds apparently broken since October?

2021-01-15 Thread Stefan Weil
Am 15.01.21 um 15:01 schrieb Peter Maydell: I was just trying to see what updates the qemu.nsi file needed for the merge-all-the-manuals-into-one-place change, and I discovered that it's been broken since October when we removed the Changelog file: File: "/tmp/qemu-test/src\Changelog" -> no

Re: [PATCH v7 10/13] spapr: Add PEF based confidential guest support

2021-01-15 Thread Cornelia Huck
On Thu, 14 Jan 2021 10:58:08 +1100 David Gibson wrote: > Some upcoming POWER machines have a system called PEF (Protected > Execution Facility) which uses a small ultravisor to allow guests to > run in a way that they can't be eavesdropped by the hypervisor. The > effect is roughly similar to

Re: [PATCH] fuzz: Add virtio-9p configurations for fuzzing

2021-01-15 Thread Alexander Bulekov
On 210115 1323, Greg Kurz wrote: > On Thu, 14 Jan 2021 17:17:48 -0500 > Alexander Bulekov wrote: > > > Signed-off-by: Alexander Bulekov > > --- > > No changelog at all ? > > > tests/qtest/fuzz/generic_fuzz_configs.h | 12 > > 1 file changed, 12 insertions(+) > > > > diff --git

Re: [PULL 00/30] testing, gdbstub and semihosting

2021-01-15 Thread Peter Maydell
On Fri, 15 Jan 2021 at 13:08, Alex Bennée wrote: > > The following changes since commit 7c79721606be11b5bc556449e5bcbc331ef6867d: > > Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210113' > into staging (2021-01-14 09:54:29 +) > > are available in the Git repository at:

[PATCH v7 9/9] hw/ssi: imx_spi: Correct tx and rx fifo endianness

2021-01-15 Thread Philippe Mathieu-Daudé
From: Bin Meng The endianness of data exchange between tx and rx fifo is incorrect. Earlier bytes are supposed to show up on MSB and later bytes on LSB, ie: in big endian. The manual does not explicitly say this, but the U-Boot and Linux driver codes have a swap on the data transferred to tx

[PATCH v7 7/9] hw/ssi: imx_spi: Round up the burst length to be multiple of 8

2021-01-15 Thread Philippe Mathieu-Daudé
From: Bin Meng Current implementation of the imx spi controller expects the burst length to be multiple of 8, which is the most common use case. In case the burst length is not what we expect, log it to give user a chance to notice it, and round it up to be multiple of 8. Signed-off-by: Bin

Re: [PATCH v7 09/13] confidential guest support: Update documentation

2021-01-15 Thread Cornelia Huck
On Thu, 14 Jan 2021 10:58:07 +1100 David Gibson wrote: > Now that we've implemented a generic machine option for configuring various > confidential guest support mechanisms: > 1. Update docs/amd-memory-encryption.txt to reference this rather than > the earlier SEV specific option > 2.

[PATCH v7 8/9] hw/ssi: imx_spi: Correct the burst length > 32 bit transfer logic

2021-01-15 Thread Philippe Mathieu-Daudé
From: Bin Meng For the ECSPIx_CONREG register BURST_LENGTH field, the manual says: 0x020 A SPI burst contains the 1 LSB in first word and all 32 bits in second word. 0x021 A SPI burst contains the 2 LSB in first word and all 32 bits in second word. Current logic uses either s->burst_length

[PATCH v7 4/9] hw/ssi: imx_spi: Rework imx_spi_read() to handle block disabled

2021-01-15 Thread Philippe Mathieu-Daudé
When the block is disabled, it stay it is 'internal reset logic' (internal clocks are gated off). Reading any register returns its reset value. Only update this value if the device is enabled. Ref: i.MX 6DQ Applications Processor Reference Manual (IMX6DQRM), chapter 21.7.3: Control Register

[PATCH v7 5/9] hw/ssi: imx_spi: Rework imx_spi_write() to handle block disabled

2021-01-15 Thread Philippe Mathieu-Daudé
When the block is disabled, only the ECSPI_CONREG register can be modified. Setting the EN bit enabled the device, clearing it "disables the block and resets the internal logic with the exception of the ECSPI_CONREG" register. Move the imx_spi_is_enabled() check earlier. Ref: i.MX 6DQ

[PATCH v7 3/9] hw/ssi: imx_spi: Rework imx_spi_reset() to keep CONREG register value

2021-01-15 Thread Philippe Mathieu-Daudé
When the block is disabled, all registers are reset with the exception of the ECSPI_CONREG. It is initialized to zero when the instance is created. Ref: i.MX 6DQ Applications Processor Reference Manual (IMX6DQRM), chapter 21.7.3: Control Register (ECSPIx_CONREG) Reviewed-by: Juan Quintela

[PATCH v7 1/9] hw/ssi: imx_spi: Use a macro for number of chip selects supported

2021-01-15 Thread Philippe Mathieu-Daudé
From: Bin Meng Avoid using a magic number (4) everywhere for the number of chip selects supported. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210112145526.31095-2-bmeng...@gmail.com> Reviewed-by: Juan Quintela Signed-off-by:

[PATCH v7 6/9] hw/ssi: imx_spi: Disable chip selects when controller is disabled

2021-01-15 Thread Philippe Mathieu-Daudé
From: Xuzhou Cheng When a write to ECSPI_CONREG register to disable the SPI controller, imx_spi_reset() is called to reset the controller, but chip select lines should have been disabled, otherwise the state machine of any devices (e.g.: SPI flashes) connected to the SPI master is stuck to its

[RFC PATCH v7 3/3] KVM: arm64: ioctl to fetch/store tags in a guest

2021-01-15 Thread Steven Price
The VMM may not wish to have it's own mapping of guest memory mapped with PROT_MTE because this causes problems if the VMM has tag checking enabled (the guest controls the tags in physical RAM and it's unlikely the tags are correct for the VMM). Instead add a new ioctl which allows the VMM to

[PATCH v7 2/9] hw/ssi: imx_spi: Remove pointless variable initialization

2021-01-15 Thread Philippe Mathieu-Daudé
'burst_length' is cleared in imx_spi_reset(), which is called after imx_spi_realize(). Remove the initialization to simplify. Reviewed-by: Juan Quintela Signed-off-by: Philippe Mathieu-Daudé --- hw/ssi/imx_spi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/ssi/imx_spi.c

[PATCH v7 0/9] hw/ssi: imx_spi: Fix various bugs in the imx_spi model

2021-01-15 Thread Philippe Mathieu-Daudé
Hi, This is how I understand the ecSPI reset works, after looking at the IMX6DQRM.pdf datasheet. This is a respin of Ben's v5 series [*]. Since v6: - Dropped "Reduce 'change_mask' variable scope" patch - Fixed inverted reset logic - Added Juan R-b tags - Removed 'RFC' tag as tests pass

[PATCH v7 1/3] arm64: kvm: Save/restore MTE registers

2021-01-15 Thread Steven Price
Define the new system registers that MTE introduces and context switch them. The MTE feature is still hidden from the ID register as it isn't supported in a VM yet. Signed-off-by: Steven Price --- arch/arm64/include/asm/kvm_host.h | 4 ++ arch/arm64/include/asm/kvm_mte.h |

Re: [PATCH 7/7] block/rbd: change request alignment to 1 byte

2021-01-15 Thread Jason Dillaman
On Thu, Jan 14, 2021 at 2:59 PM Peter Lieven wrote: > > Am 14.01.21 um 20:19 schrieb Jason Dillaman: > > On Sun, Dec 27, 2020 at 11:42 AM Peter Lieven wrote: > >> since we implement byte interfaces and librbd supports aio on byte > >> granularity we can lift > >> the 512 byte alignment. > >> >

[PATCH v7 2/3] arm64: kvm: Introduce MTE VCPU feature

2021-01-15 Thread Steven Price
Add a new VM feature 'KVM_ARM_CAP_MTE' which enables memory tagging for a VM. This exposes the feature to the guest and automatically tags memory pages touched by the VM as PG_mte_tagged (and clears the tags storage) to ensure that the guest cannot see stale tags, and so that the tags are

[PATCH v7 0/3] MTE support for KVM guest

2021-01-15 Thread Steven Price
After chasing down a bug[1] with MTE assisted KASAN and KVM, I've now been able to rebase on v5.11-rc1 and test the combination of KVM-with-MTE and KASAN. For anyone new to this series, or simply pretending 2020 didn't happen, this series adds support for Arm's Memory Tagging Extension (MTE) to

Re: [PULL v2 00/69] MIPS patches for 2021-01-14

2021-01-15 Thread Peter Maydell
On Thu, 14 Jan 2021 at 16:56, Philippe Mathieu-Daudé wrote: > > Resending the MIPS pull request from MIPS patches from last week > (2021-01-07) now than the "decodetree: Open files with encoding='utf-8'" > patch got merged (commit 4cacecaaa2b). > >

Re: [RFC PATCH v6 04/11] hw/ssi: imx_spi: Reduce 'change_mask' variable scope

2021-01-15 Thread Philippe Mathieu-Daudé
On 1/13/21 2:47 PM, Juan Quintela wrote: > Juan Quintela wrote: >> Philippe Mathieu-Daudé wrote: >>> Signed-off-by: Philippe Mathieu-Daudé >> >> I think this one is wrong. > > Wrong is a strong word. I mean that it changes behaviour and the commit > message don't talk about changing

Re: [PATCH] fuzz: Add virtio-9p configurations for fuzzing

2021-01-15 Thread Alexander Bulekov
On 210115 1033, Darren Kenny wrote: > Hi Alex, > > On Thursday, 2021-01-14 at 17:17:48 -05, Alexander Bulekov wrote: > > Signed-off-by: Alexander Bulekov > > In general this look good, so: > > Reviewed-by: Darren Kenny > > but I do have a question below... > > > --- > >

Re: Windows installer builds apparently broken since October?

2021-01-15 Thread Peter Maydell
On Fri, 15 Jan 2021 at 14:01, Peter Maydell wrote: > > I was just trying to see what updates the qemu.nsi file needed for > the merge-all-the-manuals-into-one-place change, and I discovered > that it's been broken since October when we removed the Changelog file: > > File:

[PATCH v2 0/2] net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr()

2021-01-15 Thread Philippe Mathieu-Daudé
I had a look at the patch from Miroslav trying to silence a compiler warning which in fact is a nasty bug. Here is a fix. https://www.mail-archive.com/qemu-devel@nongnu.org/msg772735.html v2: Restrict tests so they don't fail when device aren't available Based-on:

[PATCH v2 2/2] net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr()

2021-01-15 Thread Philippe Mathieu-Daudé
QEMU fuzzer reported a buffer overflow in _eth_get_rss_ex_dst_addr() reproducible as: $ cat << EOF | ./qemu-system-i386 -M pc-q35-5.0 \ -accel qtest -monitor none \ -serial none -nographic -qtest stdio outl 0xcf8 0x80001010 outl 0xcfc 0xe102 outl 0xcf8 0x80001004 outw 0xcfc

[PATCH v2 1/2] net/eth: Simplify _eth_get_rss_ex_dst_addr()

2021-01-15 Thread Philippe Mathieu-Daudé
The length field is already contained in the ip6_ext_hdr structure. Check it direcly in eth_parse_ipv6_hdr() before calling _eth_get_rss_ex_dst_addr(), which gets a bit simplified. Reviewed-by: Miroslav Rezanina Signed-off-by: Philippe Mathieu-Daudé --- net/eth.c | 14 +++--- 1 file

[PATCH 3/4] tests/qtest: Only run fuzz-megasas-test if megasas device is available

2021-01-15 Thread Philippe Mathieu-Daudé
This test fails when QEMU is built without the megasas device, restrict it to its availability. Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/fuzz-megasas-test.c | 49 + tests/qtest/fuzz-test.c | 25 - MAINTAINERS

[PATCH 1/4] tests/qtest: Remove TPM tests

2021-01-15 Thread Philippe Mathieu-Daudé
The TPM tests are failing, and no further tests are run, making the rest of the testsuite pointless: $ make check-qtest = ==3330026==ERROR: LeakSanitizer: detected memory leaks Indirect leak of 444960 byte(s) in 108

[PATCH 4/4] tests/qtest: Only run fuzz-virtio-scsi when virtio-scsi is available

2021-01-15 Thread Philippe Mathieu-Daudé
This test fails when QEMU is built without the virtio-scsi device, restrict it to its availability. Signed-off-by: Philippe Mathieu-Daudé --- Cc: "Michael S. Tsirkin" Note when running check-qtest-i386 I still get this failure: qemu-system-i386: Cannot map used it comes from

[PATCH 2/4] tests/qtest: Make fuzz-test generic to all targets

2021-01-15 Thread Philippe Mathieu-Daudé
Tests in fuzz-test's main() already check for the supported architecture before adding tests, therefore this test is not specific to the X86 target. Move it to the generic set. Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH 0/4] tests/qtest: Fixes fuzz-tests

2021-01-15 Thread Philippe Mathieu-Daudé
tests/qtest/fuzz-test seems to have bitrotten. Fix it to make it useful. Philippe Mathieu-Daudé (4): tests/qtest: Remove TPM tests tests/qtest: Make fuzz-test generic to all targets tests/qtest: Only run fuzz-megasas-test if megasas device is available tests/qtest: Only run

Re: [PATCH 6/7] block/rbd: add write zeroes support

2021-01-15 Thread Jason Dillaman
On Thu, Jan 14, 2021 at 2:41 PM Peter Lieven wrote: > > Am 14.01.21 um 20:19 schrieb Jason Dillaman: > > On Sun, Dec 27, 2020 at 11:42 AM Peter Lieven wrote: > >> Signed-off-by: Peter Lieven > >> --- > >> block/rbd.c | 31 ++- > >> 1 file changed, 30 insertions(+),

Re: [PATCH v11 0/5] UFFD write-tracking migration/snapshots

2021-01-15 Thread Peter Xu
On Fri, Jan 15, 2021 at 02:34:40PM +0300, Andrey Gruzdev wrote: > Ping Dave, Juan, I really think this series needs some attention... It'll be a great if QEMU can start to take live snapshot at least to me. Andrey (and also Denis with the older versions) did a great job working on it and moving

Re: [PATCH v2 05/25] tests/docker: remove travis container

2021-01-15 Thread Wainer dos Santos Moschetta
On 1/14/21 10:02 AM, Daniel P. Berrangé wrote: The travis container that we have no longer matches what travis currently uses. As all x86 jobs are being moved to GitLab CI too, there is no compelling reason to update the travis container. It is simpler to just remove it. Signed-off-by: Daniel

Re: [PATCH v3 08/10] iotests/129: Limit mirror job's buffer size

2021-01-15 Thread Willian Rampazzo
On Thu, Jan 14, 2021 at 2:37 PM Max Reitz wrote: > > Issuing 'stop' on the VM drains all nodes. If the mirror job has many > large requests in flight, this may lead to significant I/O that looks a > bit like 'stop' would make the job try to complete (which is what 129 > should verify not to

Re: [PATCH v3 04/10] iotests/129: Remove test images in tearDown()

2021-01-15 Thread Willian Rampazzo
On Thu, Jan 14, 2021 at 2:29 PM Max Reitz wrote: > > Signed-off-by: Max Reitz > Reviewed-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/129 | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Willian Rampazzo

Re: [PATCH v3 1/1] target-riscv: support QMP dump-guest-memory

2021-01-15 Thread Andrew Jones
On Fri, Jan 15, 2021 at 09:28:19AM +0800, Yifei Jiang wrote: > Add the support needed for creating prstatus elf notes. Now elf notes > only contains user_regs. This allows us to use QMP dump-guest-memory. > > Signed-off-by: Yifei Jiang > Signed-off-by: Mingwang Li > --- >

Re: [PATCH v3 09/10] iotests/129: Clean up pylint and mypy complaints

2021-01-15 Thread Willian Rampazzo
On Fri, Jan 15, 2021 at 6:30 AM Max Reitz wrote: > > On 14.01.21 21:02, Willian Rampazzo wrote: > > On Thu, Jan 14, 2021 at 2:41 PM Max Reitz wrote: > >> > >> Signed-off-by: Max Reitz > >> --- > >> tests/qemu-iotests/129 | 4 ++-- > >> tests/qemu-iotests/297 | 2 +- > >> 2 files changed, 3

Windows installer builds apparently broken since October?

2021-01-15 Thread Peter Maydell
I was just trying to see what updates the qemu.nsi file needed for the merge-all-the-manuals-into-one-place change, and I discovered that it's been broken since October when we removed the Changelog file: File: "/tmp/qemu-test/src\Changelog" -> no files found. Usage: File [/nonfatal] [/a] ([/r]

Re: [PATCH v2 02/25] tests/docker: don't use BUILDKIT in GitLab either

2021-01-15 Thread Daniel P . Berrangé
On Fri, Jan 15, 2021 at 10:53:34AM -0300, Wainer dos Santos Moschetta wrote: > Hi, > > On 1/14/21 10:02 AM, Daniel P. Berrangé wrote: > > Using BUILDKIT breaks with certain container registries such as CentOS, > > with docker build reporting an error such as > > > >failed to solve with

Re: [PATCH 0/9] hw/block: m25p80: Fix the mess of dummy bytes needed for fast read commands

2021-01-15 Thread Bin Meng
Hi Francisco, On Fri, Jan 15, 2021 at 8:26 PM Francisco Iglesias wrote: > > Hi Bin, > > On [2021 Jan 15] Fri 10:07:52, Bin Meng wrote: > > Hi Francisco, > > > > On Fri, Jan 15, 2021 at 2:13 AM Francisco Iglesias > > wrote: > > > > > > Hi Bin, > > > > > > On [2021 Jan 14] Thu 23:08:53, Bin Meng

Re: [PATCH 0/9] hw/block: m25p80: Fix the mess of dummy bytes needed for fast read commands

2021-01-15 Thread Bin Meng
Hi Havard, On Fri, Jan 15, 2021 at 11:29 AM Havard Skinnemoen wrote: > > Hi Bin, > > On Thu, Jan 14, 2021 at 6:08 PM Bin Meng wrote: > > > > Hi Francisco, > > > > On Fri, Jan 15, 2021 at 2:13 AM Francisco Iglesias > > wrote: > > > > > > Hi Bin, > > > > > > On [2021 Jan 14] Thu 23:08:53, Bin

Re: [PATCH 2/4] target/riscv: Add CSR name in the CSR function table

2021-01-15 Thread Bin Meng
Hi Alex, On Fri, Jan 15, 2021 at 9:14 PM Alexander Richardson wrote: > > On Tue, 12 Jan 2021 at 05:02, Bin Meng wrote: > > > > From: Bin Meng > > > > In preparation to generate the CSR register list for GDB stub > > dynamically, let's add the CSR name in the CSR function table. > > > >

Re: [RFC PATCH 0/5] hw/block/nvme: support multi-path for ctrl/ns

2021-01-15 Thread Klaus Jensen
On Jan 15 21:05, Minwoo Im wrote: > Hello, > > This series added support for multi-path I/O with multi-controllers and > namespace sharing. By supporting these features, we can test Linux > kernel mpath(multi-path) code with this NVMe device. > > Patches from the first to third added

[PULL 24/30] semihosting: Change internal common-semi interfaces to use CPUState *

2021-01-15 Thread Alex Bennée
From: Keith Packard This makes all of the internal interfaces architecture-independent and renames the internal functions to use the 'common_semi' prefix instead of 'arm' or 'arm_semi'. To do this, some new architecture-specific internal helper functions were created: static inline

Re: [PULL 00/30] Audio 20210115 patches

2021-01-15 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210115132146.1443592-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210115132146.1443592-1-kra...@redhat.com Subject: [PULL 00/30] Audio 20210115 patches

Re: [PATCH 0/1] net: Fix handling of id in netdev_add and netdev_del

2021-01-15 Thread Markus Armbruster
Jason Wang writes: > On 2020/11/25 下午6:02, Markus Armbruster wrote: >> This is a regression fix, but the regression is already in 5.0. I >> think it's too late for 5.2. If I'm right, then the issue should be >> documented in the release notes (I can do that). > > > Please do that and I've

Re: [PATCH] hw/block/nvme: add zoned I/O commands to nvme_io_opc_str()

2021-01-15 Thread Minwoo Im
Oh, I think I missed that one :-). Thanks!

[PULL 12/30] scripts/checkpatch.pl: fix git-show invocation to include diffstat

2021-01-15 Thread Alex Bennée
Without this checkpatch keeps complaining about new/changed files even when MAINTAINERS has been updated. Normal invocations of checkpatch on patch files rather than commit IDs are unaffected. Signed-off-by: Alex Bennée Tested-by: Philippe Mathieu-Daudé Reviewed-by: Willian Rampazzo

Re: [PATCH] hw/misc/sifive_u_otp: handling the fails of blk_pread and blk_pwrite

2021-01-15 Thread Peter Maydell
On Fri, 15 Jan 2021 at 13:33, Bin Meng wrote: > > On Fri, Jan 15, 2021 at 7:50 PM Peter Maydell > wrote: > > > > Ping! This patch was trying to fix a Coverity issue (CID 1435959, > > 1435960, 1435961) -- is anybody planning to review it? > > > > (I'm not entirely sure 'guest error' is the right

[PULL 23/30] semihosting: Change common-semi API to be architecture-independent

2021-01-15 Thread Alex Bennée
From: Keith Packard The public API is now defined in hw/semihosting/common-semi.h. do_common_semihosting takes CPUState * instead of CPUARMState *. All internal functions have been renamed common_semi_ instead of arm_semi_ or arm_. Aside from the API change, there are no functional changes in

Re: [PATCH] MAINTAINERS: Update 9pfs tree URL

2021-01-15 Thread Christian Schoenebeck
On Freitag, 15. Januar 2021 14:42:24 CET Greg Kurz wrote: > I've already moved my repositories to gitlab for extra CI coverage, > and I won't use the ones at github anymore. > > Signed-off-by: Greg Kurz Reviewed-by: Christian Schoenebeck > --- > MAINTAINERS |2 +- > 1 file changed, 1

Re: QEMU 6.0 release schedule proposal

2021-01-15 Thread Bin Meng
On Fri, Jan 15, 2021 at 9:52 PM Peter Maydell wrote: > > Hi; I've filled in some proposed dates for the 6.0 release cycle > on the wiki page: > https://wiki.qemu.org/Planning/6.0#Release_Schedule > > Summary: > * softfreeze: Tues 16 Mar > * Hardfreeze/rc0: 23 Mar > * rc1/2/3: 30 Mar/4 Apr/13

Re: [PATCH] hw/misc/sifive_u_otp: handling the fails of blk_pread and blk_pwrite

2021-01-15 Thread Bin Meng
On Fri, Jan 15, 2021 at 9:55 PM Peter Maydell wrote: > > On Fri, 15 Jan 2021 at 13:33, Bin Meng wrote: > > > > On Fri, Jan 15, 2021 at 7:50 PM Peter Maydell > > wrote: > > > > > > Ping! This patch was trying to fix a Coverity issue (CID 1435959, > > > 1435960, 1435961) -- is anybody planning

[PATCH] hw/block/nvme: add zoned I/O commands to nvme_io_opc_str()

2021-01-15 Thread Minwoo Im
Currently, Zoned I/O commands are parsed as unknown: pci_nvme_io_cmd cid 768 nsid 1 sqid 4 opc 0x79 opname 'NVME_NVM_CMD_UNKNOWN' Parse zoned I/O commands along with other I/O commands to print. Signed-off-by: Minwoo Im --- hw/block/nvme.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH] monitor/qmp-cmds.c: Don't include ui/vnc.h

2021-01-15 Thread Markus Armbruster
Peter Maydell writes: > The qmp-cmds.c file currently includes ui/vnc.h, which (being located > in the ui/ directory rather than include) is really supposed to be > for use only by the ui subsystem. In fact the function prototypes we > need (vnc_display_password(), etc) are all declared in >

[PULL 09/30] gitlab: move docs and tools build across from Travis

2021-01-15 Thread Alex Bennée
While we are at it we might as well check the tag generation. For bonus points we run GNU globals htags into the public pages directory for publishing with the auto generated pages. Signed-off-by: Alex Bennée Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Willian Rampazzo Acked-by:

Re: [PATCH v2 02/25] tests/docker: don't use BUILDKIT in GitLab either

2021-01-15 Thread Wainer dos Santos Moschetta
Hi, On 1/14/21 10:02 AM, Daniel P. Berrangé wrote: Using BUILDKIT breaks with certain container registries such as CentOS, with docker build reporting an error such as failed to solve with frontend dockerfile.v0: failed to build LLB: failed to load cache key: unexpected status code

Re: [PATCH v2 2/2] vnc: add qmp to support reload vnc tls certificates

2021-01-15 Thread Daniel P . Berrangé
On Fri, Jan 15, 2021 at 02:37:33PM +0100, Markus Armbruster wrote: > Zihao Chang writes: > > > QEMU loads vnc tls certificates only when vm is started. This patch > > provides a new qmp to reload vnc tls certificates without restart > > vnc-server/VM. > > {"execute": "reload-vnc-cert"} > > > >

[PULL 19/30] paaudio: send recorded data in smaller chunks

2021-01-15 Thread Gerd Hoffmann
From: Volker Rümelin Tell PulseAudio to send recorded audio data in smaller chunks than timer_period, so there's a good chance that qemu can read recorded audio data every time it looks for new data. PulseAudio tries to send buffer updates at a fragsize / 2 rate. With fragsize = timer_period /

[PULL 15/30] Revert "tests/tcg/multiarch/Makefile.target: Disable run-gdbstub-sha1 test"

2021-01-15 Thread Alex Bennée
We won't attempt to run the test now it's gated on a newer version of gdb. This reverts commit a930cadd83b4681a98ce72abf530a791ee2e42a6. Signed-off-by: Alex Bennée Message-Id: <20210108224256.2321-5-alex.ben...@linaro.org> diff --git a/tests/tcg/multiarch/Makefile.target

Re: [PATCH] hw/block/nvme: add zoned I/O commands to nvme_io_opc_str()

2021-01-15 Thread Klaus Jensen
On Jan 15 22:48, Minwoo Im wrote: > Currently, Zoned I/O commands are parsed as unknown: > pci_nvme_io_cmd cid 768 nsid 1 sqid 4 opc 0x79 opname 'NVME_NVM_CMD_UNKNOWN' > > Parse zoned I/O commands along with other I/O commands to print. > > Signed-off-by: Minwoo Im > --- > hw/block/nvme.h |

Re: [PATCH v19 08/20] io: add qio_channel_readv_full_all_eof & qio_channel_readv_full_all helpers

2021-01-15 Thread Jag Raman
> On Jan 15, 2021, at 4:20 AM, Stefan Hajnoczi wrote: > > On Thu, Jan 14, 2021 at 01:24:37PM -0500, Jag Raman wrote: >> >> >>> On Jan 14, 2021, at 1:00 PM, Daniel P. Berrangé wrote: >>> >>> On Thu, Jan 14, 2021 at 12:55:58PM -0500, Jag Raman wrote: > On Jan 14, 2021, at

[PULL 29/30] audio: Suspect code indent for conditional statements

2021-01-15 Thread Gerd Hoffmann
From: Zhang Han Fix code indent. Signed-off-by: Zhang Han Message-id: 20210115012431.79533-1-zhangha...@huawei.com Message-Id: <20210115012431.79533-7-zhangha...@huawei.com> Signed-off-by: Gerd Hoffmann --- audio/paaudio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PULL 20/30] gdbstub: ensure we clean-up when terminated

2021-01-15 Thread Alex Bennée
If you kill the inferior from GDB we end up leaving our socket lying around. Fix this by calling gdb_exit() first. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210108224256.2321-10-alex.ben...@linaro.org> diff --git a/gdbstub.c

[PATCH] MAINTAINERS: Update 9pfs tree URL

2021-01-15 Thread Greg Kurz
I've already moved my repositories to gitlab for extra CI coverage, and I won't use the ones at github anymore. Signed-off-by: Greg Kurz --- MAINTAINERS |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index cb0656aec3d4..21038d3fdfce 100644 ---

[PULL 27/30] riscv: Add semihosting support for user mode

2021-01-15 Thread Alex Bennée
From: Kito Cheng This could made testing more easier and ARM/AArch64 has supported on their linux user mode too, so I think it should be reasonable. Verified GCC testsuite with newlib/semihosting. Signed-off-by: Kito Cheng Signed-off-by: Alex Bennée Reviewed-by: Keith Packard Reviewed-by:

[PULL 25/30] audio: Add spaces around operator/delete redundant spaces

2021-01-15 Thread Gerd Hoffmann
From: Zhang Han Fix problems about spaces: -operator needs spaces around it, add them. -somespaces are redundant, remove them. Signed-off-by: Zhang Han Reviewed-by: Philippe Mathieu-Daudé Message-id: 20210115012431.79533-1-zhangha...@huawei.com Message-Id:

Re: [PATCH v2 01/25] hw/usb/ccid: remove references to NSS

2021-01-15 Thread Wainer dos Santos Moschetta
On 1/14/21 10:02 AM, Daniel P. Berrangé wrote: The NSS package was previously pre-requisite for building CCID related features, however, this became obsolete when the libcacard library was spun off to a separate project: commit 7b02f5447c64d1854468f758398c9f6fe9e5721f Author:

[PULL 26/30] riscv: Add semihosting support

2021-01-15 Thread Alex Bennée
From: Keith Packard Adapt the arm semihosting support code for RISCV. This implementation is based on the standard for RISC-V semihosting version 0.2 as documented in https://github.com/riscv/riscv-semihosting-spec/releases/tag/0.2 Signed-off-by: Keith Packard Signed-off-by: Alex Bennée

[PULL 24/30] audio: Add braces for statements/fix braces' position

2021-01-15 Thread Gerd Hoffmann
From: Zhang Han Fix problems about braces: -braces are necessary for all arms of if/for/while statements -else should follow close brace '}' Signed-off-by: Zhang Han Message-id: 20210115012431.79533-1-zhangha...@huawei.com Message-Id: <20210115012431.79533-2-zhangha...@huawei.com>

Re: [PATCH v6 08/11] iotests: add testenv.py

2021-01-15 Thread Vladimir Sementsov-Ogievskiy
15.01.2021 16:20, Kevin Wolf wrote: Am 15.01.2021 um 14:10 hat Vladimir Sementsov-Ogievskiy geschrieben: 15.01.2021 15:45, Kevin Wolf wrote: Am 15.01.2021 um 13:19 hat Vladimir Sementsov-Ogievskiy geschrieben: 15.01.2021 14:18, Kevin Wolf wrote: Am 09.01.2021 um 13:26 hat Vladimir

[PULL 10/30] Fix build with new yank feature by adding stubs

2021-01-15 Thread Alex Bennée
From: Lukas Straub Fixes: 50186051f42 ("Introduce yank feature") Signed-off-by: Lukas Straub [AJB: tweak MAINTAINERS] Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210114141918.5201c...@gecko.fritz.box> Message-Id:

[PULL 14/30] paaudio: wait for PA_STREAM_READY in qpa_write()

2021-01-15 Thread Gerd Hoffmann
From: Volker Rümelin Don't call pa_stream_writable_size() in qpa_write() before the playback stream is ready. This prevents a lot of the following pulseaudio error messages. pulseaudio: pa_stream_writable_size failed pulseaudio: Reason: Bad state To reproduce start qemu with -parallel none

Re: [PATCH v2 2/2] vnc: add qmp to support reload vnc tls certificates

2021-01-15 Thread Markus Armbruster
Zihao Chang writes: > QEMU loads vnc tls certificates only when vm is started. This patch > provides a new qmp to reload vnc tls certificates without restart > vnc-server/VM. > {"execute": "reload-vnc-cert"} > > Signed-off-by: Zihao Chang > --- > include/ui/console.h | 1 + >

[PULL 22/30] semihosting: Move ARM semihosting code to shared directories

2021-01-15 Thread Alex Bennée
From: Keith Packard This commit renames two files which provide ARM semihosting support so that they can be shared by other architectures: 1. target/arm/arm-semi.c -> hw/semihosting/common-semi.c 2. linux-user/arm/semihost.c -> linux-user/semihost.c The build system was modified use a

Re: [PATCH] vnc: add qmp to support reload vnc tls certificates

2021-01-15 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Jan 04, 2021 at 03:11:28PM +0800, Zihao Chang wrote: >> QEMU loads vnc tls certificates only when vm is started. This patch >> provides a new qmp command to reload vnc tls certificates without >> restart vnc-server/VM. >> >> Signed-off-by: Zihao Chang [...]

[PULL 08/30] docker: expand debian-amd64 image to include tag tools

2021-01-15 Thread Alex Bennée
This is going to be helpful when we want to both test the tool integration and in the case of global generate a xref doc build. Signed-off-by: Alex Bennée Reviewed-by: Willian Rampazzo Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210114165730.31607-9-alex.ben...@linaro.org> diff --git

[PULL 06/30] sdlaudio: fill remaining sample buffer with silence

2021-01-15 Thread Gerd Hoffmann
From: Volker Rümelin Fill the remaining sample buffer with silence. To fill it with zeroes is wrong for unsigned samples because this is silence with a DC bias. Signed-off-by: Volker Rümelin Reviewed-by: Thomas Huth Message-id: 9315afe5-5958-c0b4-ea1e-14769511a...@t-online.de Message-Id:

[PULL 27/30] audio: Fix lines over 90 characters

2021-01-15 Thread Gerd Hoffmann
From: Zhang Han Fix the line width of code. Signed-off-by: Zhang Han Message-id: 20210115012431.79533-1-zhangha...@huawei.com Message-Id: <20210115012431.79533-5-zhangha...@huawei.com> Signed-off-by: Gerd Hoffmann --- audio/dsoundaudio.c | 37 +++-- 1 file

[PULL 13/30] paaudio: avoid to clip samples multiple times

2021-01-15 Thread Gerd Hoffmann
From: Volker Rümelin The pulseaudio backend currently converts, clips and copies audio playback samples in the mixing-engine sample buffer multiple times. In qpa_get_buffer_out() the function pa_stream_begin_write() returns a rather large buffer and this allows audio_pcm_hw_run_out() in

[PULL 11/30] gitlab: migrate the minimal tools and unit tests from Travis

2021-01-15 Thread Alex Bennée
These tests are good at shaking out missing stubs which otherwise work if we have built targets. Rather than create a new job just add the checks to the existing tools-and-docs build. Signed-off-by: Alex Bennée Reviewed-by: Willian Rampazzo Reviewed-by: Thomas Huth Reviewed-by: Philippe

[PULL 11/30] sdlaudio: enable (in|out).mixing-engine=off

2021-01-15 Thread Gerd Hoffmann
From: Volker Rümelin Enable the SDL2 backend options -audiodev sdl,out.mixing- engine=off,in.mixing-engine=off. Signed-off-by: Volker Rümelin Message-id: 9315afe5-5958-c0b4-ea1e-14769511a...@t-online.de Message-Id: <20210110100239.27588-11-vr_q...@t-online.de> Signed-off-by: Gerd Hoffmann ---

[PULL 19/30] gdbstub: drop gdbserver_cleanup in favour of gdb_exit

2021-01-15 Thread Alex Bennée
Despite it's name it didn't actually clean-up so let us document gdb_exit() better and use that. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210108224256.2321-9-alex.ben...@linaro.org> diff --git a/include/exec/gdbstub.h

[PULL 17/30] paaudio: comment bugs in functions qpa_init_*

2021-01-15 Thread Gerd Hoffmann
From: Volker Rümelin The audio buffer size in audio/paaudio.c is typically larger than expected. Just comment the bugs in qpa_init_in() and qpa_init_out() for now. Fixing these bugs may break glitch free audio playback with fine tuned user audio settings. Signed-off-by: Volker Rümelin

Re: [RFC PATCH 0/2] Allow changing bs->file on reopen

2021-01-15 Thread Kashyap Chamarthy
On Fri, Jan 15, 2021 at 02:02:36PM +0100, Alberto Garcia wrote: > Hi, Hi, > during the past months we talked about making x-blockdev-reopen stable > API, and one of the missing things was having support for changing > bs->file. See here for the discusssion (I can't find the message from >

[PULL 12/30] audio: remove remaining unused plive code

2021-01-15 Thread Gerd Hoffmann
From: Volker Rümelin Commit 73ad33ef7b "audio: remove plive" forgot to remove this code. Signed-off-by: Volker Rümelin Message-id: 9315afe5-5958-c0b4-ea1e-14769511a...@t-online.de Message-Id: <20210110100239.27588-12-vr_q...@t-online.de> Signed-off-by: Gerd Hoffmann --- audio/audio.c | 17

Re: [PATCH] hw/misc/sifive_u_otp: handling the fails of blk_pread and blk_pwrite

2021-01-15 Thread Bin Meng
On Fri, Jan 15, 2021 at 7:50 PM Peter Maydell wrote: > > Ping! This patch was trying to fix a Coverity issue (CID 1435959, > 1435960, 1435961) -- is anybody planning to review it? > > (I'm not entirely sure 'guest error' is the right warning category, > but I don't know the specifics of this

[PULL 20/30] dsoundaudio: replace GetForegroundWindow()

2021-01-15 Thread Gerd Hoffmann
From: Volker Rümelin GetForegroundWindow() doesn't necessarily return the own window handle. It just returns a handle to the currently active window and can even return NULL. At the time dsound_open() gets called the active window is most likely the shell window and not the QEMU window. Replace

QEMU 6.0 release schedule proposal

2021-01-15 Thread Peter Maydell
Hi; I've filled in some proposed dates for the 6.0 release cycle on the wiki page: https://wiki.qemu.org/Planning/6.0#Release_Schedule Summary: * softfreeze: Tues 16 Mar * Hardfreeze/rc0: 23 Mar * rc1/2/3: 30 Mar/4 Apr/13 Apr * release: Tues 20 Apr, or 27th if we needed an rc4 (Easter

Re: [PATCH v3 11/10] iotests: add flake8 linter

2021-01-15 Thread Vladimir Sementsov-Ogievskiy
15.01.2021 15:03, Max Reitz wrote: On 15.01.21 12:53, Vladimir Sementsov-Ogievskiy wrote: pylint is good, but doesn't cover the PEP8. Let's add flake8, to be sure that our code sutisfy PEP8. Add new linter and fix some code style in checked files. Signed-off-by: Vladimir Sementsov-Ogievskiy

[PULL 08/30] audio: split pcm_ops function get_buffer_in

2021-01-15 Thread Gerd Hoffmann
From: Volker Rümelin Split off pcm_ops function run_buffer_in from get_buffer_in and call run_buffer_in before get_buffer_in. The next patch only needs the generic buffer management part from audio_generic_get_buffer_in(). Signed-off-by: Volker Rümelin Message-id:

[PULL 04/30] sdlaudio: don't start playback in init routine

2021-01-15 Thread Gerd Hoffmann
From: Volker Rümelin Every emulated audio device has a way to enable audio playback. Don't start playback until the guest enables the audio device. This patch keeps the SDL2 device pause state in sync with hw->enabled. Signed-off-by: Volker Rümelin Reviewed-by: Thomas Huth Tested-by: Thomas

Re: [PATCH v7 08/13] confidential guest support: Move SEV initialization into arch specific code

2021-01-15 Thread Cornelia Huck
On Thu, 14 Jan 2021 10:58:06 +1100 David Gibson wrote: > While we've abstracted some (potential) differences between mechanisms for > securing guest memory, the initialization is still specific to SEV. Given > that, move it into x86's kvm_arch_init() code, rather than the generic > kvm_init()

[PULL 30/30] audio: space prohibited between function name and parenthesis'('

2021-01-15 Thread Gerd Hoffmann
From: Zhang Han Delete spaces between function name and open parenthesis'(' Signed-off-by: Zhang Han Message-id: 20210115012431.79533-1-zhangha...@huawei.com Message-Id: <20210115012431.79533-8-zhangha...@huawei.com> Signed-off-by: Gerd Hoffmann --- audio/audio_template.h | 12 ++--

[PULL 05/30] sdlaudio: always clear the sample buffer

2021-01-15 Thread Gerd Hoffmann
From: Volker Rümelin Always fill the remaining audio callback buffer with silence. SDL 2.0 doesn't initialize the audio callback buffer. This was an incompatible change compared to SDL 1.2. For reference read the SDL 1.2 to 2.0 migration guide. Signed-off-by: Volker Rümelin Reviewed-by: Thomas

[PULL 00/30] Audio 20210115 patches

2021-01-15 Thread Gerd Hoffmann
The following changes since commit 45240eed4f064576d589ea60ebadf3c11d7ab891: Merge remote-tracking branch 'remotes/armbru/tags/pull-yank-2021-01-13' int= o staging (2021-01-13 14:19:24 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/audio-20210115-pull-request

<    1   2   3   4   5   >