Re: [PATCH v2 2/7] audio: Add spaces around operator/delete redundant spaces

2021-01-15 Thread Philippe Mathieu-Daudé
On 1/15/21 2:24 AM, Zhang Han wrote: > Fix problems about spaces: > -operator needs spaces around it, add them. > -somespaces are redundant, remove them. > > Signed-off-by: Zhang Han > --- > audio/audio_template.h | 2 +- > audio/coreaudio.c | 2 +- > audio/dsoundaudio.c| 2 +- >

Re: [PATCH v19 08/20] io: add qio_channel_readv_full_all_eof & qio_channel_readv_full_all helpers

2021-01-15 Thread Stefan Hajnoczi
On Thu, Jan 14, 2021 at 01:24:37PM -0500, Jag Raman wrote: > > > > On Jan 14, 2021, at 1:00 PM, Daniel P. Berrangé wrote: > > > > On Thu, Jan 14, 2021 at 12:55:58PM -0500, Jag Raman wrote: > >> > >> > >>> On Jan 14, 2021, at 11:27 AM, Stefan Hajnoczi wrote: > >>> > >>> On Thu, Jan 14, 2021

Re: [PATCH v3 18/19] i386: provide simple 'hv-default=on' option

2021-01-15 Thread Vitaly Kuznetsov
Igor Mammedov writes: > On Thu, 7 Jan 2021 16:14:49 +0100 > Vitaly Kuznetsov wrote: > >> Enabling Hyper-V emulation for a Windows VM is a tiring experience as it >> requires listing all currently supported enlightenments ("hv-*" CPU >> features) explicitly. We do have 'hv-passthrough' mode

Re: [PATCH v3 01/10] iotests.py: Assume a couple of variables as given

2021-01-15 Thread Vladimir Sementsov-Ogievskiy
14.01.2021 20:02, Max Reitz wrote: There are a couple of environment variables that we fetch with os.environ.get() without supplying a default. Clearly they are required and expected to be set by the ./check script (as evidenced by execute_setup_common(), which checks for test_dir and

Re: [PATCH v4 1/3] block/nvme: introduce bit 5 for critical warning

2021-01-15 Thread Philippe Mathieu-Daudé
On 1/15/21 4:27 AM, zhenwei pi wrote: > According to NVMe spec 1.4 section "According to NVMe spec 1.4 section 5.14.1.2" > , introduce bit 5 > for "Persistent Memory Region has become read-only or unreliable". > > Signed-off-by: zhenwei pi > --- > include/block/nvme.h | 1 + > 1 file changed,

Re: [PATCH v4 3/3] hw/blocl/nvme: trigger async event during injecting smart warning

2021-01-15 Thread Philippe Mathieu-Daudé
On 1/15/21 4:27 AM, zhenwei pi wrote: > During smart critical warning injection by setting property from QMP > command, also try to trigger asynchronous event. > > Suggested by Keith, if a event has already been raised, there is no > need to enqueue the duplicate event any more. > >

Re: [PATCH] qtest/npcm7xx_pwm-test: Fix memleak in pwm_qom_get

2021-01-15 Thread Philippe Mathieu-Daudé
On 1/15/21 8:56 AM, Gan Qixin wrote: > The pwm_qom_get function didn't free "response", which caused an indirect > memory leak. So use qobject_unref() to fix it. > > ASAN shows memory leak stack: > > Indirect leak of 7416 byte(s) in 18000 object(s) allocated from: > #0 0x7f96e2f79d4e in

RE: [PATCH 3/3] net/colo-compare: Add handler for passthrough connection

2021-01-15 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Thursday, January 14, 2021 9:51 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Eric Blake ; Dr. David Alan > Gilbert ; Markus Armbruster ; > Zhang Chen > Subject: Re: [PATCH 3/3] net/colo-compare: Add handler for

[PULL 1/1] 9pfs: Fully restart unreclaim loop (CVE-2021-20181)

2021-01-15 Thread Greg Kurz
Depending on the client activity, the server can be asked to open a huge number of file descriptors and eventually hit RLIMIT_NOFILE. This is currently mitigated using a reclaim logic : the server closes the file descriptors of idle fids, based on the assumption that it will be able to re-open

RE: [PATCH 3/3] net/colo-compare: Add handler for passthrough connection

2021-01-15 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Thursday, January 14, 2021 9:45 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Eric Blake ; Dr. David Alan > Gilbert ; Markus Armbruster ; > Zhang Chen > Subject: Re: [PATCH 3/3] net/colo-compare: Add handler for

[PULL 0/1] 9p security fix 2021-01-15

2021-01-15 Thread Greg Kurz
The following changes since commit 7c79721606be11b5bc556449e5bcbc331ef6867d: Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210113' into staging (2021-01-14 09:54:29 +) are available in the Git repository at: https://gitlab.com/gkurz/qemu.git tags/9p-next-2021-01-15

Re: [PATCH 0/2] ui/gtk: Update refresh rate on EGL as well

2021-01-15 Thread Gerd Hoffmann
Hi, > These patches were made in response to Volkers patches which dealt with > cleaning up my previous code: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg766686.html > and thus are meant to be merged after Volker's patches. > > Hopefully, this commit message isn't too daunting

Re: [PATCH 03/23] sdlaudio: add -audiodev sdl, out.buffer-count option

2021-01-15 Thread Markus Armbruster
Volker Rümelin writes: > Currently there is a crackling noise with SDL2 audio playback. > Commit bcf19777df: "audio/sdlaudio: Allow audio playback with > SDL2" already mentioned the crackling noise. > > Add an out.buffer-count option to give users a chance to select > sane settings for glitch

Re: [RFC PATCH v0 1/1] target/ppc: Support for H_RPT_INVALIDATE hcall

2021-01-15 Thread Bharata B Rao
On Wed, Jan 13, 2021 at 05:22:56PM +0100, Greg Kurz wrote: > Hi Bharata, > > On Wed, 6 Jan 2021 14:29:10 +0530 > Bharata B Rao wrote: > > > If KVM_CAP_RPT_INVALIDATE KVM capability is enabled, then > > > > - indicate the availability of H_RPT_INVALIDATE hcall to the guest via > >

Re: Fwd: VirtioSound device emulation implementation

2021-01-15 Thread Shreyansh Chouhan
On Thu, 14 Jan 2021 at 23:17, Alex Bennée wrote: > > Shreyansh Chouhan writes: > > > Just an update: > > > > I've studied the virtio specification along with the source code and I > now > > understand what the device implementation is > > going to look like. Also I understand the source code a

<    1   2   3   4   5