Re: [PATCH v3 5/5] vhost-vdpa: add callback function for configure interrupt

2021-01-26 Thread Cindy Lu
On Wed, Jan 27, 2021 at 1:47 PM Jason Wang wrote: > > > On 2021/1/26 下午3:42, Cindy Lu wrote: > > Add call back function for configure interrupt. > > Set the notifier's fd to the kernel driver when vdpa start. > > also set -1 while vdpa stop. then the kernel will release > > the related resource >

[PULL v1 3/3] target/microblaze: Add security attributes on memory transactions

2021-01-26 Thread Edgar E. Iglesias
From: Joe Komlodi Using the cfg.use_non_secure bitfield and the MMU access type, we can determine if the access should be secure or not. Signed-off-by: Joe Komlodi Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias Message-Id: <1611274735-303873-4-git-send-email-koml...@xilinx.com>

[PULL v1 2/3] target/microblaze: use MMUAccessType instead of int in mmu_translate

2021-01-26 Thread Edgar E. Iglesias
From: Joe Komlodi Using MMUAccessType makes it more clear what the variable's use is. No functional change. Signed-off-by: Joe Komlodi Reviewed-by: Richard Henderson Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias Message-Id:

[PULL v1 0/3] Xilinx queue

2021-01-26 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" The following changes since commit 9cd69f1a270235b652766f00b94114f48a2d603f: Merge remote-tracking branch 'remotes/stefanberger/tags/pull-tpm-2021-01-25-1' into staging (2021-01-26 09:51:02 +) are available in the Git repository at:

[PULL v1 1/3] target/microblaze: Add use-non-secure property

2021-01-26 Thread Edgar E. Iglesias
From: Joe Komlodi This property is used to control the security of the following interfaces on MicroBlaze: M_AXI_DP - data interface M_AXI_IP - instruction interface M_AXI_DC - dcache interface M_AXI_IC - icache interface It works by enabling or disabling the use of the non_secure[3:0] signals.

Re: [PATCH v3 3/5] virtio-pci: add support for configure interrupt

2021-01-26 Thread Cindy Lu
On Wed, Jan 27, 2021 at 1:44 PM Jason Wang wrote: > > > On 2021/1/26 下午3:42, Cindy Lu wrote: > > Add support for configure interrupt, use kvm_irqfd_assign and set the > > gsi to kernel. When the configure notifier was eventfd_signal by host > > kernel, this will finally inject an msix interrupt

Re: [PATCH v3 2/5] vhost_net: enable configure interrupt when vhost_net start

2021-01-26 Thread Cindy Lu
On Wed, Jan 27, 2021 at 1:38 PM Jason Wang wrote: > > > On 2021/1/26 下午3:42, Cindy Lu wrote: > > While peer is vhost vdpa, setup the configure interrupt function > > vhost_net_start and release the resource when vhost_net_stop > > > > Signed-off-by: Cindy Lu > > --- > > hw/net/vhost_net.c | 19

Re: [PATCH 3/7] ppc/pnv: Use skiboot addresses to load kernel and ramfs

2021-01-26 Thread Cédric Le Goater
On 1/27/21 2:27 AM, Murilo Opsfelder Araújo wrote: > Bonjour, Cédric. > > On Tuesday, January 26, 2021 2:10:55 PM -03 Cédric Le Goater wrote: >> The current settings are useful to load large kernels (with debug) but >> it moves the initrd image in a memory region not protected by >> skiboot. If

Re: [PATCH] tests/acceptance: Increase the timeout in the replay tests

2021-01-26 Thread Pavel Dovgalyuk
On 27.01.2021 09:52, Thomas Huth wrote: Our gitlab-CI just showed a failed test_ppc_mac99 since it was apparently killed some few seconds before the test finished. Allow it some more time to complete. Signed-off-by: Thomas Huth Acked-by: Pavel Dovgalyuk --- Seen in this test log:

[PATCH v3 4/4] hw/mips/boston: Use bootloader helper to set GCRs

2021-01-26 Thread Jiaxun Yang
Translate embedded assembly into IO writes which is more readable. Also hardcode cm_base at boot time instead of reading from CP0. Signed-off-by: Jiaxun Yang Reviewed-by: Philippe Mathieu-Daudé -- v3: Use bl_gen_write_ulong. --- hw/mips/boston.c | 47

[PATCH v3 3/4] hw/mips/malta: Use bootloader helper to set BAR resgiters

2021-01-26 Thread Jiaxun Yang
Translate embedded assembly into IO writes which is more readable. Signed-off-by: Jiaxun Yang --- hw/mips/malta.c | 68 - 1 file changed, 22 insertions(+), 46 deletions(-) diff --git a/hw/mips/malta.c b/hw/mips/malta.c index

[PATCH v3 1/4] hw/mips: Add a bootloader helper

2021-01-26 Thread Jiaxun Yang
Add a bootloader helper to generate simple bootloaders for kernel. It can help us reduce inline hex hack and also keep MIPS release 6 compatibility easier. Signed-off-by: Jiaxun Yang --- include/hw/mips/bootloader.h | 49 +++ hw/mips/bootloader.c | 164

[PATCH v3 2/4] hw/mips: Use bl_gen_kernel_jump to generate bootloaders

2021-01-26 Thread Jiaxun Yang
Replace embedded binary with generated code. Signed-off-by: Jiaxun Yang --- hw/mips/boston.c| 17 ++--- hw/mips/fuloong2e.c | 28 hw/mips/malta.c | 41 ++--- 3 files changed, 16 insertions(+), 70 deletions(-)

[PATCH v3 0/4] MIPS Bootloader helper

2021-01-26 Thread Jiaxun Yang
v2: A big reconstruction. rewrite helpers with CPU feature and sepreate changesets. v3: respin Jiaxun Yang (4): hw/mips: Add a bootloader helper hw/mips: Use bl_gen_kernel_jump to generate bootloaders hw/mips/malta: Use bootloader helper to set BAR resgiters hw/mips/boston: Use bootloader

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-26 Thread Stefan Weil
Am 26.01.21 um 23:39 schrieb Richard Henderson: On 1/26/21 9:44 AM, Stefan Weil wrote: I was not talking about the TODO assertions. When I wrote TCI, I only enabled and included code which was triggered by my testing - that's why I said the productive code lines have 100 % test coverage. TODO

[PATCH] tests/acceptance: Increase the timeout in the replay tests

2021-01-26 Thread Thomas Huth
Our gitlab-CI just showed a failed test_ppc_mac99 since it was apparently killed some few seconds before the test finished. Allow it some more time to complete. Signed-off-by: Thomas Huth --- Seen in this test log:

Re: [PATCH] libqtest: Rework qtest_rsp()

2021-01-26 Thread Thomas Huth
On 26/01/2021 16.16, Markus Armbruster wrote: qtest_rsp() is used in two different ways: (1) return some arguments to caller, which the caller must free, and (2) return no arguments to caller. Passing non-zero @expected_args gets you (1), and passing zero gets you (2). Having "the return value

[PATCH] gitlab-ci.yml: Run check-tcg with TCI

2021-01-26 Thread Thomas Huth
It's now possible to also run the non-x86 TCG tests with TCI. Signed-off-by: Thomas Huth --- Based-on: 20210126192518.2019885-1...@weilnetz.de CI-run: https://gitlab.com/huth/qemu/-/jobs/988742434#L5200 .gitlab-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v3 9/9] docs/system: riscv: Add documentation for sifive_u machine

2021-01-26 Thread Palmer Dabbelt
On Mon, 25 Jan 2021 22:00:07 PST (-0800), bmeng...@gmail.com wrote: From: Bin Meng This adds detailed documentation for RISC-V `sifive_u` machine, including the following information: - Supported devices - Hardware configuration information - Boot options - Machine-specific options - Running

Re: [PATCH v3 5/5] vhost-vdpa: add callback function for configure interrupt

2021-01-26 Thread Jason Wang
On 2021/1/26 下午3:42, Cindy Lu wrote: Add call back function for configure interrupt. Set the notifier's fd to the kernel driver when vdpa start. also set -1 while vdpa stop. then the kernel will release the related resource Signed-off-by: Cindy Lu --- hw/virtio/trace-events| 2

Re: [PATCH v3 3/5] virtio-pci: add support for configure interrupt

2021-01-26 Thread Jason Wang
On 2021/1/26 下午3:42, Cindy Lu wrote: Add support for configure interrupt, use kvm_irqfd_assign and set the gsi to kernel. When the configure notifier was eventfd_signal by host kernel, this will finally inject an msix interrupt to guest Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c |

Re: [PATCH v3 2/5] vhost_net: enable configure interrupt when vhost_net start

2021-01-26 Thread Jason Wang
On 2021/1/26 下午3:42, Cindy Lu wrote: While peer is vhost vdpa, setup the configure interrupt function vhost_net_start and release the resource when vhost_net_stop Signed-off-by: Cindy Lu --- hw/net/vhost_net.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff

Re: [PATCH v3 1/5] virtio: add support for configure interrupt

2021-01-26 Thread Jason Wang
On 2021/1/26 下午3:42, Cindy Lu wrote: Add configure notifier and virtio_set_config_notifier_fd_handler in virtio The title and commit log is kind of misleading. I think we should use "virtio: add guest notifier for config interrupt" Signed-off-by: Cindy Lu --- hw/virtio/virtio.c

[Bug 1912777] Re: KVM_EXIT_MMIO has increased in Qemu4.0.0 when compared to Qemu 2.11.0

2021-01-26 Thread ANIMESH KUMAR SINHA
The testcase is a rather a very basic one. Doing a mmap on a pcie device and triggering a read and write operation on the Virtual Address, which would in-turn trigger transaction requests on the host device. I understand that Qemu v4.0 may be and old one, but the issue is that test case

Re: [PATCH v2] virtio: Add corresponding memory_listener_unregister to unrealize

2021-01-26 Thread Jason Wang
On 2021/1/26 下午11:40, Peter Xu wrote: On Mon, Jan 25, 2021 at 08:25:05PM +0100, Eugenio Pérez wrote: Address space is destroyed without proper removal of its listeners with current code. They are expected to be removed in virtio_device_instance_finalize [1], but qemu calls it through

Re: [PATCH v3 0/6] Enable plugin support on msys2/mingw

2021-01-26 Thread Yonggang Luo
Hi alex, when does plugins/next getting PR On Tue, Oct 6, 2020 at 7:35 PM Alex Bennée wrote: > > Yonggang Luo writes: > > > V2-V3 > > Split following patches out > > > > V1-V2 > > 1. Fixes review comments > > 2. Increase QEMU_PLUGIN_VERSION to 1 for compat QEMU_PLUGIN_VERSION 0 > > 3. Revise

Re: [PATCH v2 5/8] hw/mips: Use bl_gen_kernel_jump to generate bootloaders

2021-01-26 Thread Jiaxun Yang
在 2021/1/7 上午1:48, Philippe Mathieu-Daudé 写道: +Alex On 12/15/20 7:45 AM, Jiaxun Yang wrote: Replace embedded binary with generated code. Signed-off-by: Jiaxun Yang --- hw/mips/boston.c| 17 ++--- hw/mips/fuloong2e.c | 28 hw/mips/malta.c |

Re: [PATCH v3 5/5] vhost-vdpa: add callback function for configure interrupt

2021-01-26 Thread Cindy Lu
On Tue, Jan 26, 2021 at 10:53 PM Stefano Garzarella wrote: > > On Tue, Jan 26, 2021 at 03:42:54PM +0800, Cindy Lu wrote: > >Add call back function for configure interrupt. > >Set the notifier's fd to the kernel driver when vdpa start. > >also set -1 while vdpa stop. then the kernel will release >

Re: [PATCH] spapr: Adjust firmware path of PCI devices

2021-01-26 Thread Alexey Kardashevskiy
On 25/01/2021 21:23, Greg Kurz wrote: On Sat, 23 Jan 2021 13:36:34 +1100 Alexey Kardashevskiy wrote: On 23/01/2021 04:01, Greg Kurz wrote: It is currently not possible to perform a strict boot from USB storage: $ qemu-system-ppc64 -accel kvm -nodefaults -nographic -serial stdio \

Re: [PATCH 3/7] ppc/pnv: Use skiboot addresses to load kernel and ramfs

2021-01-26 Thread Murilo Opsfelder Araújo
Bonjour, Cédric. On Tuesday, January 26, 2021 2:10:55 PM -03 Cédric Le Goater wrote: > The current settings are useful to load large kernels (with debug) but > it moves the initrd image in a memory region not protected by > skiboot. If skiboot is compiled with DEBUG=1, memory poisoning will >

[PATCH v2] hw/misc: Fix arith overflow in NPCM7XX PWM module

2021-01-26 Thread wuhaotsh--- via
Fix potential overflow problem when calculating pwm_duty. 1. Ensure p->cmr and p->cnr to be from [0,65535], according to the hardware specification. 2. Changed duty to uint32_t. However, since MAX_DUTY * (p->cmr+1) can excceed UINT32_MAX, we convert them to uint64_t in computation and

[PATCH 0/1] tests/acceptance/boot_linux: Switch to Fedora 32

2021-01-26 Thread Daniele Buono
Local acceptance tests run with "make check-acceptance" are now showing some cases canceled like the following: (01/39) tests/acceptance/boot_linux.py:BootLinuxX8664.test_pc_i440fx_tcg: CANCEL: Failed to download/prepare boot image (0.25 s) Turns out, every full-vm test in boot_linux.py is

[PATCH 1/1] tests/acceptance/boot_linux: Switch to Fedora 32

2021-01-26 Thread Daniele Buono
Some acceptance test require a full VM image. The tests were using Fedora 31, which is now EOL. Probably as a consequence, the Avocado framework is not able to download such images anymore. Switch to Fedora 32, which is still supported. Signed-off-by: Daniele Buono ---

[PATCH 5/5] tests/qtest/qos-test: dump QEMU command if verbose

2021-01-26 Thread qemu_oss--- via
If qtests are run in verbose mode (i.e. if --verbose CL argument was provided) then print the assembled qemu command line for each test. Use qos_printf() instead of g_test_message() to avoid the latter cluttering the output. Signed-off-by: Christian Schoenebeck --- tests/qtest/qos-test.c | 3

[PATCH 0/5] enhance debugging with qtest framework

2021-01-26 Thread qemu_oss--- via
This series is a follow-up of the following previous series: https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg02251.html The 9p patches of the previous series have already been merged. This series consists of 2 parts: 1. libqos patch 1 removes a limitation of the qtest/libqos subsystem:

[PATCH 4/5] tests/qtest/qos-test: dump environment variables if verbose

2021-01-26 Thread qemu_oss--- via
If qtests are run in verbose mode (i.e. if --verbose CL argument was provided) then print all environment variables to stdout before running the individual tests. It is common nowadays, at least being able to output all config vectors in a build chain, especially if it is required to investigate

[PATCH 2/5] libqos/qgraph_internal: add qos_printf() and qos_printf_literal()

2021-01-26 Thread qemu_oss--- via
These two are macros wrapping regular printf() call. They are intended to be used instead of calling printf() directly in order to avoid breaking TAP output format. TAP output format is enabled by using --tap command line argument. Starting with glib 2.62 it is enabled by default. Unfortunately

[PATCH 1/5] libqos/qgraph: add qos_node_create_driver_named()

2021-01-26 Thread qemu_oss--- via
So far the qos subsystem of the qtest framework had the limitation that only one instance of the same official QEMU (QMP) driver name could be created for qtests. That's because a) the created qos node names must always be unique, b) the node name must match the official QEMU driver name being

[PATCH 3/5] tests/qtest/qos-test: dump qos graph if verbose

2021-01-26 Thread qemu_oss--- via
If qtests were run in verbose mode (i.e. if --verbose CL argument was provided) then dump the generated qos graph (all nodes and edges, along with their current individual availability status) to stdout, which allows to identify problems in the created qos graph e.g. when writing new qos tests.

Re: [PATCH] docs/system: Deprecate `-cpu ...,+feature,-feature` syntax

2021-01-26 Thread John Snow
On 1/21/21 4:39 AM, Daniel P. Berrangé wrote: On Wed, Jan 20, 2021 at 03:12:41PM -0500, Eduardo Habkost wrote: The ordering semantics of +feature/-feature is tricky and not obvious, and it requires a custom option parser. Deprecate that syntax so we can eventually remove the custom -cpu option

Re: [PATCH 6/6] hw/i2c: Implement NPCM7XX SMBus Module FIFO Mode

2021-01-26 Thread Corey Minyard
On Tue, Jan 26, 2021 at 11:32:37AM -0800, wuhaotsh--- via wrote: > + > +static void npcm7xx_smbus_read_byte_fifo(NPCM7xxSMBusState *s) > +{ > +uint8_t received_bytes = NPCM7XX_SMBRXF_STS_RX_BYTES(s->rxf_sts); > + > +if (received_bytes == 0) { > +npcm7xx_smbus_recv_fifo(s); > +

Re: [PATCH] IOMMU and ATS not supported by vhost-user filesystem.

2021-01-26 Thread Leonardo Augusto Guimarães Garcia
On 1/26/21 4:45 PM, Dr. David Alan Gilbert wrote: * lagar...@linux.ibm.com (lagar...@linux.ibm.com) wrote: From: Leonardo Garcia Currently, as IOMMU and ATS are not supported, if a user mistakenly set any of them and tries to mount the vhost-user filesystem inside the guest, whenever the user

Re: [PATCH 4/6] hw/arm: Add I2C device tree for Quanta GSJ

2021-01-26 Thread Corey Minyard
On Tue, Jan 26, 2021 at 11:32:35AM -0800, wuhaotsh--- via wrote: > Add an I2C device tree for Quanta GSJ. We only included devices with > existing QEMU implementation, including AT24 EEPROM and temperature > sensors. > > Reviewed-by: Doug Evans > Reviewed-by: Tyrong Ting > Signed-off-by: Hao Wu

Re: [PATCH 2/6] hw/i2c: Implement NPCM7XX SMBus Module Single Mode

2021-01-26 Thread Corey Minyard
On Tue, Jan 26, 2021 at 11:32:33AM -0800, wuhaotsh--- via wrote: > This commit implements the single-byte mode of the SMBus. > > Each Nuvoton SoC has 16 System Management Bus (SMBus). These buses > compliant with SMBus and I2C protocol. > > This patch implements the single-byte mode of the

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-26 Thread Richard Henderson
On 1/26/21 9:44 AM, Stefan Weil wrote: > I was not talking about the TODO assertions. When I wrote TCI, I only enabled > and included code which was triggered by my testing - that's why I said the > productive code lines have 100 % test coverage. TODO assertions are not > productive code, but

Re: [PATCH] vfio/migrate: Move switch of dirty tracking into vfio_memory_listener

2021-01-26 Thread Alex Williamson
Kirti? Migration experts? Thanks, Alex On Mon, 11 Jan 2021 15:34:39 +0800 Keqian Zhu wrote: > For now the switch of vfio dirty page tracking is integrated into > the vfio_save_handler, it causes some problems [1]. > > The object of dirty tracking is guest memory, but the object of > the

Re: [PATCH V6 0/6] hw/block/nvme: support multi-path for ctrl/ns

2021-01-26 Thread Minwoo Im
On 21-01-27 05:39:29, Keith Busch wrote: > This came out looking cleaner than I had initially expected. Thanks for > seeing this feature through! > > Reviewed-by: Keith Busch Thanks Keith for the review!

Re: [PATCH v2 8/9] tests/docker: Add dockerfile for Alpine Linux

2021-01-26 Thread John Snow
On 1/19/21 8:41 AM, Thomas Huth wrote: On 18/01/2021 11.33, Daniel P. Berrangé wrote: On Mon, Jan 18, 2021 at 02:38:07PM +0800, Jiaxun Yang wrote: Alpine Linux[1] is a security-oriented, lightweight Linux distribution based on musl libc and busybox. It it popular among Docker guests and

Re: [RFC PATCH v2 2/3] vfio: Set the priority of the VFIO VM state change handler explicitly

2021-01-26 Thread Alex Williamson
On Wed, 9 Dec 2020 16:09:18 +0800 Shenming Lu wrote: > In the VFIO VM state change handler, VFIO devices are transitioned > in the _SAVING state, which should keep them from sending interrupts. Is this comment accurate? It's my expectation that _SAVING has no bearing on a device generating

Re: [RFC PATCH v2 3/3] vfio: Avoid disabling and enabling vectors repeatedly in VFIO migration

2021-01-26 Thread Alex Williamson
On Wed, 9 Dec 2020 16:09:19 +0800 Shenming Lu wrote: > Different from the normal situation when the guest starts, we can > know the max unmasked vetctor (at the beginning) after msix_load() > in VFIO migration. So in order to avoid ineffectively disabling and s/ineffectively/inefficiently/?

Re: [RFC PATCH v2 1/3] vfio: Move the saving of the config space to the right place in VFIO migration

2021-01-26 Thread Alex Williamson
On Thu, 10 Dec 2020 10:21:21 +0800 Shenming Lu wrote: > On 2020/12/10 2:34, Alex Williamson wrote: > > On Wed, 9 Dec 2020 13:29:47 +0100 > > Cornelia Huck wrote: > > > >> On Wed, 9 Dec 2020 16:09:17 +0800 > >> Shenming Lu wrote: > >> > >>> On ARM64 the VFIO SET_IRQS ioctl is dependent on

Handling multiple inheritance [for CXL]

2021-01-26 Thread Ben Widawsky
I'm working on CXL 2.0 type 3 memory devices [1]. In short, these are PCIe devices that have persistent memory on them. As such, it would be nice to inherit from both a PCI_DEVICE class as well as an NVDIMM device class. Truth be told, using TYPE_MEMORY_DEVICE as the interface does provide most

Re: [PATCH v5 03/10] iotests: Move try_remove to iotests.py

2021-01-26 Thread John Snow
On 1/18/21 5:57 AM, Max Reitz wrote: Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Willian Rampazzo --- tests/qemu-iotests/124| 8 +--- tests/qemu-iotests/iotests.py | 11 +++ 2 files changed, 8 insertions(+),

Re: [PATCH v5 02/10] iotests/297: Rewrite in Python and extend reach

2021-01-26 Thread John Snow
On 1/18/21 5:57 AM, Max Reitz wrote: Instead of checking iotests.py only, check all Python files in the qemu-iotests/ directory. Of course, most of them do not pass, so there is an extensive skip list for now. (The only files that do pass are 209, 254, 283, and iotests.py.) Chiming in to

Re: [PATCH v5 01/10] iotests.py: Assume a couple of variables as given

2021-01-26 Thread John Snow
On 1/18/21 5:57 AM, Max Reitz wrote: There are a couple of environment variables that we fetch with os.environ.get() without supplying a default. Clearly they are required and expected to be set by the ./check script (as evidenced by execute_setup_common(), which checks for test_dir and

Re: [PATCH 1/1] x86/cpu: Populate SVM CPUID feature bits

2021-01-26 Thread Paolo Bonzini
On 26/01/21 21:24, Wei Huang wrote: Newer AMD CPUs will add CPUID_0x800A_EDX[28] bit, which indicates that SVM instructions (VMRUN/VMSAVE/VMLOAD) will trigger #VMEXIT before CPU checking their EAX against reserved memory regions. This change will allow the hypervisor to avoid intercepting

Re: [PATCH V6 4/6] hw/block/nvme: support for multi-controller in subsystem

2021-01-26 Thread Minwoo Im
On 21-01-26 09:57:23, Keith Busch wrote: > On Tue, Jan 26, 2021 at 09:52:48AM +0900, Minwoo Im wrote: > > On 21-01-25 10:11:43, Keith Busch wrote: > > > On Mon, Jan 25, 2021 at 07:03:32PM +0100, Klaus Jensen wrote: > > > > On Jan 24 11:54, Minwoo Im wrote: > > > > > We have nvme-subsys and nvme

[PATCH 1/1] x86/cpu: Populate SVM CPUID feature bits

2021-01-26 Thread Wei Huang
Newer AMD CPUs will add CPUID_0x800A_EDX[28] bit, which indicates that SVM instructions (VMRUN/VMSAVE/VMLOAD) will trigger #VMEXIT before CPU checking their EAX against reserved memory regions. This change will allow the hypervisor to avoid intercepting #GP and emulating SVM instructions. KVM

Re: [PATCH V6 0/6] hw/block/nvme: support multi-path for ctrl/ns

2021-01-26 Thread Keith Busch
This came out looking cleaner than I had initially expected. Thanks for seeing this feature through! Reviewed-by: Keith Busch

[Bug 1913344] [NEW] Exynos4210 UART peripheral data loss

2021-01-26 Thread Iris Johnson
Public bug reported: Currently the Exynos4210 UART (hw/char/exynos4210_uart.c) incorrectly reports however many empty bytes are available in the FIFO when queried for receive capacity. However this peripheral supports a polled mode where only a single byte can be submitted at a time and the FIFO

[Bug 1913341] [NEW] Chardev behavior breaks polling based devices

2021-01-26 Thread Iris Johnson
Public bug reported: Currently in latest QEMU (9cd69f1a270235b652766f00b94114f48a2d603f at this time) the behavior of chardev sources is that when processed (before IO polling occurs), the chardev source will check the amount of space for reading. If it reports more than 0 bytes available to

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-26 Thread Stefan Weil
Am 26.01.21 um 21:07 schrieb Paolo Bonzini: On 26/01/21 20:44, Stefan Weil wrote: Yes, I tested with latest git master and did not notice that --enable-tcg-interpreter was broken. Paolo's patch fixed that.I could reproduce the fatal assertions which were all caused by the same missing TCG

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-26 Thread Paolo Bonzini
On 26/01/21 20:44, Stefan Weil wrote: Yes, I tested with latest git master and did not notice that --enable-tcg-interpreter was broken. Paolo's patch fixed that.I could reproduce the fatal assertions which were all caused by the same missing TCG opcode implementation. My patch _broke_

Re: [PATCH] coroutine-sigaltstack: Add SIGUSR2 mutex

2021-01-26 Thread Laszlo Ersek
On 01/26/21 14:16, Max Reitz wrote: > On 26.01.21 13:44, Vladimir Sementsov-Ogievskiy wrote: >> 25.01.2021 15:03, Max Reitz wrote: >>> Disposition (action) for any given signal is global for the process. >>> When two threads run coroutine-sigaltstack's qemu_coroutine_new() >>> concurrently, they

Re: [PATCH v4 1/4] configure: Fix --enable-tcg-interpreter

2021-01-26 Thread Stefan Weil
Am 25.01.21 um 15:45 schrieb Philippe Mathieu-Daudé: From: Richard Henderson The configure option was backward, and we failed to pass the value on to meson. Fixes: 23a77b2d18b ("build-system: clean up TCG/TCI configury") Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] IOMMU and ATS not supported by vhost-user filesystem.

2021-01-26 Thread Dr. David Alan Gilbert
* lagar...@linux.ibm.com (lagar...@linux.ibm.com) wrote: > From: Leonardo Garcia > > Currently, as IOMMU and ATS are not supported, if a user mistakenly set > any of them and tries to mount the vhost-user filesystem inside the > guest, whenever the user tries to access the mount point, the

Re: [PATCH] gitlab-ci.yml: Exclude some redundant targets in build-without-default-features

2021-01-26 Thread Wainer dos Santos Moschetta
On 1/26/21 2:23 PM, Thomas Huth wrote: The build-without-default-features job is running quite long and sometimes already hits the 1h time limit. Exclude some targets which do not provide additional test coverage here (since we e.g. also already test other targets of the same type, just with

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-26 Thread Stefan Weil
Am 26.01.21 um 18:24 schrieb Alex Bennée: I'm going to go out on a limb and guess you have commit: 23a77b2d18 (build-system: clean up TCG/TCI configury) which temporarily has the effect of disabling TCI. See Subject: Re: [PATCH v4 1/4] configure: Fix --enable-tcg-interpreter From:

Re: [PATCH v2 00/12] buildsys: Do not build various objects if not necessary

2021-01-26 Thread Philippe Mathieu-Daudé
On 1/26/21 5:09 PM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> On 1/26/21 3:57 PM, Alex Bennée wrote: >>> >>> Philippe Mathieu-Daudé writes: >>> In this series we deselect a bunch of features when they not required, so less objects are built. While this

[PATCH 4/6] hw/arm: Add I2C device tree for Quanta GSJ

2021-01-26 Thread wuhaotsh--- via
Add an I2C device tree for Quanta GSJ. We only included devices with existing QEMU implementation, including AT24 EEPROM and temperature sensors. Reviewed-by: Doug Evans Reviewed-by: Tyrong Ting Signed-off-by: Hao Wu --- hw/arm/npcm7xx_boards.c | 17 + 1 file changed, 17

[PATCH 1/6] hw/arm: Remove GPIO from unimplemented NPCM7XX

2021-01-26 Thread wuhaotsh--- via
NPCM7XX GPIO devices have been implemented in hw/gpio/npcm7xx-gpio.c. So we removed them from the unimplemented devices list. Reviewed-by: Doug Evans Reviewed-by: Tyrong Ting Signed-off-by: Hao Wu --- hw/arm/npcm7xx.c | 8 1 file changed, 8 deletions(-) diff --git a/hw/arm/npcm7xx.c

[PATCH 5/6] hw/i2c: Add a QTest for NPCM7XX SMBus Device

2021-01-26 Thread wuhaotsh--- via
This patch adds a QTest for NPCM7XX SMBus's single byte mode. It sends a byte to a device in the evaluation board, and verify the retrieved value is equivalent to the sent value. Reviewed-by: Doug Evans Reviewed-by: Tyrong Ting Signed-off-by: Hao Wu --- tests/qtest/meson.build | 1 +

[PATCH 6/6] hw/i2c: Implement NPCM7XX SMBus Module FIFO Mode

2021-01-26 Thread wuhaotsh--- via
This patch implements the FIFO mode of the SMBus module. In FIFO, the user transmits or receives at most 16 bytes at a time. The FIFO mode allows the module to transmit large amount of data faster than single byte mode. Reviewed-by: Doug Evans Reviewed-by: Tyrong Ting Signed-off-by: Hao Wu ---

[PATCH 3/6] hw/arm: Add I2C device tree for NPCM750 eval board

2021-01-26 Thread wuhaotsh--- via
Add an I2C device tree for NPCM750 evaluation board. Reviewed-by: Doug Evans Reviewed-by: Tyrong Ting Signed-off-by: Hao Wu --- hw/arm/npcm7xx_boards.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c index

[PATCH 0/6] hw/i2c: Add NPCM7XX SMBus Device

2021-01-26 Thread wuhaotsh--- via
This patch set implements the System manager bus (SMBus) module in NPCM7XX SoC. Basically, it emulates the data transactions of the module, not the SDA/SCL levels. We have also added a QTest which contains read and write operations for both single-byte and FIFO mode, and added basic I2C device

[PATCH 2/6] hw/i2c: Implement NPCM7XX SMBus Module Single Mode

2021-01-26 Thread wuhaotsh--- via
This commit implements the single-byte mode of the SMBus. Each Nuvoton SoC has 16 System Management Bus (SMBus). These buses compliant with SMBus and I2C protocol. This patch implements the single-byte mode of the SMBus. In this mode, the user sends or receives a byte each time. The SMBus device

[PATCH] tcg/tci: Implement INDEX_op_ld16u_i32

2021-01-26 Thread Stefan Weil
This fixes `make check-tcg`. Signed-off-by: Stefan Weil --- tcg/tci.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tcg/tci.c b/tcg/tci.c index 2311aa7d3a..42354d8ebb 100644 --- a/tcg/tci.c +++ b/tcg/tci.c @@ -611,7 +611,10 @@ uintptr_t QEMU_DISABLE_CFI

Re: [PATCH] gitlab-ci.yml: Exclude some redundant targets in build-without-default-features

2021-01-26 Thread Philippe Mathieu-Daudé
On 1/26/21 6:23 PM, Thomas Huth wrote: > The build-without-default-features job is running quite long and sometimes > already hits the 1h time limit. Exclude some targets which do not provide > additional test coverage here (since we e.g. also already test other targets > of the same type, just

[Bug 1907042] Re: assert issue locates in hw/usb/core.c:727: usb_ep_get: Assertion `pid == USB_TOKEN_IN || pid == USB_TOKEN_OUT' failed

2021-01-26 Thread Alexander Bulekov
This looks like a dupe of https://bugs.launchpad.net/qemu/+bug/1525123/ , though through OHCI rather than XHCI -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1907042 Title: assert issue locates in

[PATCH] IOMMU and ATS not supported by vhost-user filesystem.

2021-01-26 Thread lagarcia
From: Leonardo Garcia Currently, as IOMMU and ATS are not supported, if a user mistakenly set any of them and tries to mount the vhost-user filesystem inside the guest, whenever the user tries to access the mount point, the system will hang forever. Signed-off-by: Leonardo Garcia ---

Re: [PATCH 1/6] virtiofsd: Drop ->vu_dispatch_rwlock while waiting for thread to exit

2021-01-26 Thread Vivek Goyal
On Tue, Jan 26, 2021 at 04:56:00PM +0100, Greg Kurz wrote: > On Mon, 25 Jan 2021 13:01:10 -0500 > Vivek Goyal wrote: > > > When we are shutting down virtqueues, virtio_loop() receives a message > > VHOST_USER_GET_VRING_BASE from master. We acquire ->vu_dispatch_rwlock > > and get into the

Re: [PATCH v3] configure: Only build s390-ccw BIOS when system emulation is built

2021-01-26 Thread Thomas Huth
On 25/01/2021 17.58, Philippe Mathieu-Daudé wrote: It is pointless to build the s390-ccw BIOS when only user-mode emulation is built. Only build it when s390 system mode emulation is selected. Signed-off-by: Philippe Mathieu-Daudé --- v3: Restrict to s390x host (thuth) v2: Restrict to

Re: [PATCH v2 1/2] tests/qtest: Only run fuzz-megasas-test if megasas device is available

2021-01-26 Thread Thomas Huth
On 26/01/2021 19.01, Alexander Bulekov wrote: On 210126 1851, Thomas Huth wrote: On 26/01/2021 12.16, Philippe Mathieu-Daudé wrote: This test fails when QEMU is built without the megasas device, restrict it to its availability. Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH v2 1/2] tests/qtest: Only run fuzz-megasas-test if megasas device is available

2021-01-26 Thread Alexander Bulekov
On 210126 1851, Thomas Huth wrote: > On 26/01/2021 12.16, Philippe Mathieu-Daudé wrote: > > This test fails when QEMU is built without the megasas device, > > restrict it to its availability. > > > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > tests/qtest/fuzz-megasas-test.c | 49

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-26 Thread Alex Bennée
Stefan Weil writes: > Am 25.01.21 um 23:35 schrieb Richard Henderson: >> On 1/25/21 11:02 AM, Stefan Weil wrote: >>> Am 25.01.21 um 20:02 schrieb Richard Henderson: On 1/25/21 8:58 AM, Stefan Weil wrote: > I have no evidence that TCI is less reliable than TCG, so I would not >

Re: [PATCH V6 4/6] hw/block/nvme: support for multi-controller in subsystem

2021-01-26 Thread Keith Busch
On Tue, Jan 26, 2021 at 09:52:48AM +0900, Minwoo Im wrote: > On 21-01-25 10:11:43, Keith Busch wrote: > > On Mon, Jan 25, 2021 at 07:03:32PM +0100, Klaus Jensen wrote: > > > On Jan 24 11:54, Minwoo Im wrote: > > > > We have nvme-subsys and nvme devices mapped together. To support > > > >

Re: [PATCH v2 3/2] MAINTAINERS: Cover fuzzer reproducer tests within 'Device Fuzzing'

2021-01-26 Thread Thomas Huth
On 26/01/2021 12.28, Philippe Mathieu-Daudé wrote: When we started to commit the fuzzer QTest reproducers to fuzz-test.c in commit d8dd1095019 ("qtest: add fuzz test case"), we forgot to add the corresponding MAINTAINERS entry. Do it now. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS

Re: [PATCH v2 2/2] tests/qtest: Only run fuzz-virtio-scsi when virtio-scsi is available

2021-01-26 Thread Thomas Huth
On 26/01/2021 12.16, Philippe Mathieu-Daudé wrote: This test fails when QEMU is built without the virtio-scsi device, restrict it to its availability. Reviewed-by: Michael S. Tsirkin Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/fuzz-test.c | 51

Re: [PATCH v2 1/2] tests/qtest: Only run fuzz-megasas-test if megasas device is available

2021-01-26 Thread Thomas Huth
On 26/01/2021 12.16, Philippe Mathieu-Daudé wrote: This test fails when QEMU is built without the megasas device, restrict it to its availability. Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/fuzz-megasas-test.c | 49 + tests/qtest/fuzz-test.c

Re: [PATCH v2] docs/devel: Explain how acceptance tests can be skipped

2021-01-26 Thread Thomas Huth
On 15/01/2021 22.00, Wainer dos Santos Moschetta wrote: Documented under the "Acceptance tests using the Avocado Framework" section in testing.rst how environment variables are used to skip tests. Signed-off-by: Wainer dos Santos Moschetta --- v2: - Made the changes Thomas pointed out.

[PATCH v6 6/6] sev/i386: Enable an SEV-ES guest based on SEV policy

2021-01-26 Thread Tom Lendacky
From: Tom Lendacky Update the sev_es_enabled() function return value to be based on the SEV policy that has been specified. SEV-ES is enabled if SEV is enabled and the SEV-ES policy bit is set in the policy object. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Reviewed-by: Dr.

[PATCH v6 5/6] kvm/i386: Use a per-VM check for SMM capability

2021-01-26 Thread Tom Lendacky
From: Tom Lendacky SMM is not currently supported for an SEV-ES guest by KVM. Change the SMM capability check from a KVM-wide check to a per-VM check in order to have a finer-grained SMM capability check. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Suggested-by: Sean

[PATCH v6 4/6] sev/i386: Don't allow a system reset under an SEV-ES guest

2021-01-26 Thread Tom Lendacky
From: Tom Lendacky An SEV-ES guest does not allow register state to be altered once it has been measured. When an SEV-ES guest issues a reboot command, Qemu will reset the vCPU state and resume the guest. This will cause failures under SEV-ES. Prevent that from occuring by introducing an

[PATCH v6 3/6] sev/i386: Allow AP booting under SEV-ES

2021-01-26 Thread Tom Lendacky
From: Tom Lendacky When SEV-ES is enabled, it is not possible modify the guests register state after it has been initially created, encrypted and measured. Normally, an INIT-SIPI-SIPI request is used to boot the AP. However, the hypervisor cannot emulate this because it cannot update the AP

[PATCH v6 2/6] sev/i386: Require in-kernel irqchip support for SEV-ES guests

2021-01-26 Thread Tom Lendacky
From: Tom Lendacky In prep for AP booting, require the use of in-kernel irqchip support. This lessens the Qemu support burden required to boot APs. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Tom Lendacky ---

[PATCH v6 1/6] sev/i386: Add initial support for SEV-ES

2021-01-26 Thread Tom Lendacky
From: Tom Lendacky Provide initial support for SEV-ES. This includes creating a function to indicate the guest is an SEV-ES guest (which will return false until all support is in place), performing the proper SEV initialization and ensuring that the guest CPU state is measured as part of the

[PATCH v6 0/6] Qemu SEV-ES guest support

2021-01-26 Thread Tom Lendacky
From: Tom Lendacky This patch series provides support for launching an SEV-ES guest. Secure Encrypted Virtualization - Encrypted State (SEV-ES) expands on the SEV support to protect the guest register state from the hypervisor. See "AMD64 Architecture Programmer's Manual Volume 2: System

[PATCH] gitlab-ci.yml: Exclude some redundant targets in build-without-default-features

2021-01-26 Thread Thomas Huth
The build-without-default-features job is running quite long and sometimes already hits the 1h time limit. Exclude some targets which do not provide additional test coverage here (since we e.g. also already test other targets of the same type, just with different endianess, or a 64-bit superset)

Re: [Virtio-fs] [PATCH v2] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-26 Thread Greg Kurz
On Tue, 26 Jan 2021 10:35:02 + Stefan Hajnoczi wrote: > A well-behaved FUSE client does not attempt to open special files with > FUSE_OPEN because they are handled on the client side (e.g. device nodes > are handled by client-side device drivers). > > The check to prevent virtiofsd from

Re: [PATCH v4 0/6] Qemu SEV-ES guest support

2021-01-26 Thread Paolo Bonzini
On 26/01/21 18:13, Tom Lendacky wrote: Also, the new version will have a prereq against another patch series that has not been accepted yet: [PATCH v2 0/2] sev: enable secret injection to a self described area in OVMF

  1   2   3   4   >