[Bug 1916112] Re: Illegal instruction crash of QEMU on Jetson Nano

2021-02-19 Thread Ravishankar
Disassembly: [ OK ] Mounted RPC Pipe File System. [ 75.916706] systemd[1]: Started Create list of required static device nodes for the current kernel. [ OK ] Started Create list of req… nodes for the current kernel. Thread 7 "qemu-system-aar" received signal SIGILL, Illegal instruction.

Re: [PATCH v2 5/6] hw/sd: sdhci: Limit block size only when SDHC_BLKSIZE register is writable

2021-02-19 Thread Bin Meng
Hi Philippe, On Fri, Feb 19, 2021 at 2:03 AM Philippe Mathieu-Daudé wrote: > > On 2/18/21 6:09 PM, Philippe Mathieu-Daudé wrote: > > On 2/16/21 4:46 AM, Bin Meng wrote: > >> The codes to limit the maximum block size is only necessary when > >> SDHC_BLKSIZE register is writable. > > Per "SD

Re: [PATCH v4] net/macos: implement vmnet-based netdev

2021-02-19 Thread Howard Spoelstra
On Thu, Feb 18, 2021 at 2:49 PM wrote: > > From: Phillip Tennen > > This patch implements a new netdev device, reachable via -netdev > vmnet-macos, that’s backed by macOS’s vmnet framework. > > The vmnet framework provides native bridging support, and its usage in > this patch is intended as a

Re: [PATCH v2 05/11] hw/mips: Restrict KVM to the malta & virt machines

2021-02-19 Thread Huacai Chen
Reviewed-by: Huacai Chen On Sat, Feb 20, 2021 at 12:56 PM Jiaxun Yang wrote: > > 在 2021/2/20 上午1:38, Philippe Mathieu-Daudé 写道: > > Restrit KVM to the following MIPS machines: > > - malta > > - loongson3-virt > > > > Signed-off-by: Philippe Mathieu-Daudé > > Reviewed-by: Jiaxun Yang > > > ---

Re: [PATCH] opengl: Do not convert format with glTexImage2D on OpenGL ES

2021-02-19 Thread Akihiko Odaki
2021年2月19日(金) 23:14 Gerd Hoffmann : > > On Fri, Feb 19, 2021 at 06:48:03PM +0900, Akihiko Odaki wrote: > > OpenGL ES does not support conversion from the given data format > > to the internal format with glTexImage2D. > > > > Use the given data format as the internal format, and ignore > > the

Re: [PATCH] target/riscv: fix TB_FLAGS bits overlapping bug for rvv/rvh

2021-02-19 Thread Frank Chang
On Sat, Feb 20, 2021 at 12:12 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 2/19/21 1:59 AM, frank.ch...@sifive.com wrote: > > +/* Skip mem_idx bits */ > > +FIELD(TB_FLAGS, VL_EQ_VLMAX, 3, 1) > > Why not just add the mem_idx field to the list? > > The separation between the

Re: [PATCH v2 05/11] hw/mips: Restrict KVM to the malta & virt machines

2021-02-19 Thread Jiaxun Yang
在 2021/2/20 上午1:38, Philippe Mathieu-Daudé 写道: Restrit KVM to the following MIPS machines: - malta - loongson3-virt Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Jiaxun Yang --- hw/mips/loongson3_virt.c | 5 + hw/mips/malta.c | 5 + 2 files changed, 10

[PATCH v3] ui/cocoa: Use kCGColorSpaceSRGB

2021-02-19 Thread Akihiko Odaki
kCGColorSpaceGenericRGB | Apple Developer Documentation https://developer.apple.com/documentation/coregraphics/kcgcolorspacegenericrgb > Deprecated > Use kCGColorSpaceSRGB instead. This change also removes the legacy color space specification for PowerPC. Signed-off-by: Akihiko Odaki ---

[Bug 1906180] Re: Keyboard keys get stuck

2021-02-19 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1906180 Title: Keyboard

Re: [PATCH v2 6/6] hw/sd: sdhci: Reset the data pointer of s->fifo_buffer[] when a different block size is programmed

2021-02-19 Thread Bin Meng
Hi Philippe, On Fri, Feb 19, 2021 at 2:06 AM Philippe Mathieu-Daudé wrote: > > Hi Bin, > > On 2/16/21 4:46 AM, Bin Meng wrote: > > If the block size is programmed to a different value from the > > previous one, reset the data pointer of s->fifo_buffer[] so that > > s->fifo_buffer[] can be filled

Re: [PATCH] net: eepro100: validate various address values

2021-02-19 Thread Alexander Bulekov
On 210219 1243, Li Qiang wrote: > Alexander Bulekov 于2021年2月19日周五 上午10:15写道: > > > > On 210219 1006, Li Qiang wrote: > > > Alexander Bulekov 于2021年2月19日周五 上午9:56写道: > > > > > > > > On 210218 1441, Peter Maydell wrote: > > > > > On Thu, 18 Feb 2021 at 14:13, P J P wrote: > > > > > > > > > > > >

Re: [RFC PATCH 3/5] tests: add a sdhci reproducer

2021-02-19 Thread Alexander Bulekov
On 210219 2306, Philippe Mathieu-Daudé wrote: > On 2/18/21 10:12 PM, Alexander Bulekov wrote: > > This patch serves as an example of a file generated with the > > ./scripts/oss-fuzz/output_reproducer.py script: > > The source file in this patch was generated like this: > > > > $ wget

Re: [PATCH v2 6/8] hw/sd: sd: Actually perform the erase operation

2021-02-19 Thread Bin Meng
On Sat, Feb 20, 2021 at 6:28 AM Philippe Mathieu-Daudé wrote: > > On 2/16/21 4:02 PM, Bin Meng wrote: > > From: Bin Meng > > > > At present the sd_erase() does not erase the requested range of card > > data to 0xFFs. Let's make the erase operation actually happen. > > > > Signed-off-by: Bin Meng

Re: [PATCH v2 3/4] hw/riscv: virt: Limit RAM size in a 32-bit system

2021-02-19 Thread Bin Meng
Hi Alistair, On Fri, Feb 19, 2021 at 11:39 PM Bin Meng wrote: > > From: Bin Meng > > RV32 supports 34-bit physical address hence the maximum RAM size > should be limitted. Limit the RAM size to 10 GiB, which leaves > some room for PCIe high mmio space. > > For 32-bit host, this is not needed as

[PATCH v2] ui/cocoa: Remove the uses of full screen APIs

2021-02-19 Thread Akihiko Odaki
The detections of [NSView -enterFullScreen:] and [NSView -exitFullScreen:] were wrong. A detection is coded as: [NSView respondsToSelector:@selector(exitFullScreenModeWithOptions:)] but it should be: [NSView instancesRespondToSelector:@selector(exitFullScreenModeWithOptions:)] Because of those

Re: [PATCH v5 0/5] Add support for ipv6 host forwarding

2021-02-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210220001322.1311139-1-...@google.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210220001322.1311139-1-...@google.com Subject: [PATCH v5 0/5] Add support for ipv6 host

[Bug 1910586] Re: SD card size constraint conceptually wrong

2021-02-19 Thread Philippe Mathieu-Daudé
** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1910586 Title: SD card size constraint conceptually wrong Status in QEMU: Confirmed Bug

Re: [PATCH v5 1/5] slirp: Advance libslirp submodule to add ipv6 host-forward support

2021-02-19 Thread Philippe Mathieu-Daudé
Hi Doug, On 2/20/21 1:13 AM, Doug Evans via wrote: When updating submodules, the commit description is a good good place to include the output of: $ git shortlog 8f43a99..26ae658 See for example QEMU commit f350d78f102 ("Update SLOF"). Anyhow up to the maintainer merging your patch. >

[PULL 14/18] hw/sd: sd: Skip write protect groups check in sd_erase() for high capacity cards

2021-02-19 Thread Philippe Mathieu-Daudé
From: Bin Meng High capacity cards don't support write protection hence we should not perform the write protect groups check in sd_erase() for them. Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210216150225.27996-6-bmeng...@gmail.com> Signed-off-by: Philippe

[PULL 18/18] MAINTAINERS: Add Bin Meng as co-maintainer for SD/MMC cards

2021-02-19 Thread Philippe Mathieu-Daudé
There is new interest in the SD/MMC device emulation, so it would be good to have more than only one maintainer / reviewer for it. Bin Meng proved by his contributions a deep understanding of the SD cards internals, so let's add him to the corresponding section in the MAINTAINERS file.

[PULL 12/18] hw/sd: sd: Fix CMD30 response type

2021-02-19 Thread Philippe Mathieu-Daudé
From: Bin Meng Per the "Physical Layer Specification Version 8.00", table 4-26 (SD mode) and table 7-3 (SPI mode) command descriptions, CMD30 response type is R1, not R1b. Fixes: a1bb27b1e98a ("SD card emulation initial implementation") Signed-off-by: Bin Meng Reviewed-by: Philippe

[PULL 17/18] hw/sd: sdhci: Simplify updating s->prnsts in sdhci_sdma_transfer_multi_blocks()

2021-02-19 Thread Philippe Mathieu-Daudé
From: Bin Meng s->prnsts is updated in both branches of the if () else () statement. Move the common bits outside so that it is cleaner. Signed-off-by: Bin Meng Tested-by: Alexander Bulekov Reviewed-by: Alexander Bulekov Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PULL 11/18] hw/sd: sd: Only SDSC cards support CMD28/29/30

2021-02-19 Thread Philippe Mathieu-Daudé
From: Bin Meng Per the "Physical Layer Specification Version 8.00", table 4-26 (SD mode) and table 7-3 (SPI mode) command descriptions, the following commands: - CMD28 (SET_WRITE_PROT) - CMD29 (CLR_WRITE_PROT) - CMD30 (SEND_WRITE_PROT) are only supported by SDSC cards. Signed-off-by: Bin Meng

[PULL 13/18] hw/sd: sd: Move the sd_block_{read, write} and macros ahead

2021-02-19 Thread Philippe Mathieu-Daudé
From: Bin Meng These APIs and macros may be referenced by functions that are currently before them. Move them ahead a little bit. Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210216150225.27996-5-bmeng...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé ---

[PULL 10/18] hw/sd: sd: Fix address check in sd_erase()

2021-02-19 Thread Philippe Mathieu-Daudé
From: Bin Meng For high capacity memory cards, the erase start address and end address are multiplied by 512, but the address check is still based on the original block number in sd->erase_{start, end}. Fixes: 1bd6fd8ed593 ("hw/sd/sdcard: Do not attempt to erase out of range addresses")

[PULL 16/18] hw/sd: sd: Bypass the RCA check for CMD13 in SPI mode

2021-02-19 Thread Philippe Mathieu-Daudé
From: Bin Meng Unlike SD mode, when SD card is working in SPI mode, the argument of CMD13 is stuff bits. Hence we should bypass the RCA check. See "Physical Layer Specification Version 8.00", chapter 7.3.1.3 Detailed Command Description (SPI mode): "The card shall ignore stuff bits and

[PULL 08/18] hw/sd: ssi-sd: Fix STOP_TRANSMISSION (CMD12) response

2021-02-19 Thread Philippe Mathieu-Daudé
From: Bin Meng CMD12's response type is R1b, which is basically a R1 plus optional addition of the busy signal token that can be any number of bytes. A zero value indicates card is busy and a non-zero value indicates the card is ready for the next command. Current implementation sends the busy

[PULL 09/18] hw/sd: ssi-sd: Handle the rest commands with R1b response type

2021-02-19 Thread Philippe Mathieu-Daudé
From: Bin Meng Besides CMD12, the following command's reponse type is R1b: - SET_WRITE_PROT (CMD28) - CLR_WRITE_PROT (CMD29) - ERASE (CMD38) Reuse the same s->stopping to indicate a R1b reponse is needed. Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PATCH v5 2/5] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-02-19 Thread Doug Evans via
The parsing is moved into new function inet_parse_host_and_port. This is done in preparation for using the function in net/slirp.c. Signed-off-by: Doug Evans --- Changes from v4: - move recognition of "[]:port" to separate patch - allow passing NULL for ip_v6 - fix some formatting issues

[PULL 15/18] hw/sd: sd: Skip write protect groups check in CMD24/25 for high capacity cards

2021-02-19 Thread Philippe Mathieu-Daudé
From: Bin Meng High capacity cards don't support write protection hence we should not perform the write protect groups check in CMD24/25 for them. Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210216150225.27996-8-bmeng...@gmail.com> Signed-off-by: Philippe

[PULL 07/18] hw/sd: ssi-sd: Fix SEND_IF_COND (CMD8) response

2021-02-19 Thread Philippe Mathieu-Daudé
From: Bin Meng The SEND_IF_COND command (CMD8) response is of format R7, but current code returns R1 for CMD8. Fix it. Fixes: 775616c3ae8c ("Partial SD card SPI mode support") Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210128063035.15674-8-bmeng...@gmail.com>

[PULL 06/18] hw/sd: ssi-sd: Support multiple block write

2021-02-19 Thread Philippe Mathieu-Daudé
From: Bin Meng For a multiple block write operation, each block begins with a multi write start token. Unlike the SD mode that the multiple block write ends when receiving a STOP_TRAN command (CMD12), a special stop tran token is used to signal the card. Emulating this by manually sending a

[PATCH v5 4/5] net/slirp.c: Refactor address parsing

2021-02-19 Thread Doug Evans via
... in preparation for adding ipv6 host forwarding support. New test: avocado run tests/acceptance/hostfwd.py Signed-off-by: Doug Evans --- Changes from v4: - was 3/4 in v4 - fix some formatting issues Changes from v3: - this patch renamed from 2/3 to 3/4 - call inet_parse_host_and_port from

[PATCH v5 0/5] Add support for ipv6 host forwarding

2021-02-19 Thread Doug Evans via
This patchset takes the original patch from Maxim, https://www.mail-archive.com/qemu-devel@nongnu.org/msg569573.html and updates it. Option hostfwd is extended to support ipv6 addresses. Commands hostfwd_add, hostfwd_remove are extended as well. The libslirp part of the patch has been committed

[PATCH v5 3/5] inet_parse_host_and_addr: Recognize []:port (empty ipv6 address)

2021-02-19 Thread Doug Evans via
Some callers need to distinguish empty ipv4 addresses from ipv6. Signed-off-by: Doug Evans --- Changes from v4: - new in this patchset revision util/qemu-sockets.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index

[PATCH v5 5/5] net: Extend host forwarding to support IPv6

2021-02-19 Thread Doug Evans via
Net option "-hostfwd" now supports IPv6 addresses. Commands hostfwd_add, hostfwd_remove now support IPv6 addresses. Signed-off-by: Doug Evans --- Changes from v4: - was 4/4 in v4 - fix some formatting issues Differences from v3: - this patch renamed from 3/3 to 4/4 - ipv6 support added to

[PULL 03/18] hw/sd: sd: Allow single/multiple block write for SPI mode

2021-02-19 Thread Philippe Mathieu-Daudé
From: Bin Meng At present the single/multiple block write in SPI mode is blocked by sd_normal_command(). Remove the limitation. Signed-off-by: Bin Meng Tested-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PULL 04/18] hw/sd: Introduce receive_ready() callback

2021-02-19 Thread Philippe Mathieu-Daudé
From: Bin Meng At present there is a data_ready() callback for the SD data read path. Let's add a receive_ready() for the SD data write path. Signed-off-by: Bin Meng Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis Message-Id:

[PULL 01/18] hw/sd: ssi-sd: Support multiple block read

2021-02-19 Thread Philippe Mathieu-Daudé
From: Bin Meng In the case of a multiple block read operation every transferred block has its suffix of CRC16. Update the state machine logic to handle multiple block read. Signed-off-by: Bin Meng [PMD: Change VMState version id 5 -> 6] Signed-off-by: Philippe Mathieu-Daudé Tested-by:

[PULL 05/18] hw/sd: ssi-sd: Support single block write

2021-02-19 Thread Philippe Mathieu-Daudé
From: Bin Meng Add 2 more states for the block write operation. The SPI host needs to send a data start token to start the transfer, and the data block written to the card will be acknowledged by a data response token. Signed-off-by: Bin Meng [PMD: Change VMState version id 6 -> 7]

[PATCH v5 1/5] slirp: Advance libslirp submodule to add ipv6 host-forward support

2021-02-19 Thread Doug Evans via
Signed-off-by: Doug Evans --- Changes from v4: NOTE TO REVIEWERS: I need some hand-holding to know what The Right way to submit this particular patch is. - no change Changes from v3: - pick up latest libslirp patch to reject ipv6 addr-any for guest address - libslirp currently only provides

[PULL 02/18] hw/sd: sd: Remove duplicated codes in single/multiple block read/write

2021-02-19 Thread Philippe Mathieu-Daudé
From: Bin Meng The single block read (CMD17) codes are the same as the multiple block read (CMD18). Merge them into one. The same applies to single block write (CMD24) and multiple block write (CMD25). Signed-off-by: Bin Meng Tested-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis

[PULL 00/18] SD/MMC patches for 2021-02-20

2021-02-19 Thread Philippe Mathieu-Daudé
The following changes since commit e90ef02389dc8b57eaea22b290244609d720a8bf: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2021-02-18' into staging (2021-02-19 17:22:42 +) are available in the Git repository at: https://gitlab.com/philmd/qemu.git tags/sdmmc-20210220 for

Re: [PATCH] MAINTAINERS: Add Bin Meng as co-maintainer for SD/MMC cards

2021-02-19 Thread Philippe Mathieu-Daudé
On 2/16/21 2:28 PM, Philippe Mathieu-Daudé wrote: > There is new interest in the SD/MMC device emulation, so it > would be good to have more than only one maintainer / reviewer > for it. > > Bin Meng proved by his contributions a deep understanding of the > SD cards internals, so let's add him to

Re: [PATCH v2 4/6] hw/sd: sdhci: Simplify updating s->prnsts in sdhci_sdma_transfer_multi_blocks()

2021-02-19 Thread Philippe Mathieu-Daudé
On 2/16/21 4:46 AM, Bin Meng wrote: > s->prnsts is updated in both branches of the if () else () statement. > Move the common bits outside so that it is cleaner. > > Signed-off-by: Bin Meng > --- > > (no changes since v1) > > hw/sd/sdhci.c | 7 +++ > 1 file changed, 3 insertions(+), 4

Re: [PATCH 2/2] hw/timer/renesas_tmr: Fix use of uninitialized data in read_tcnt()

2021-02-19 Thread Philippe Mathieu-Daudé
On 2/19/21 11:32 PM, Peter Maydell wrote: > The read_tcnt() function calculates the TCNT register values for the > two channels of the timer module; it sets these up in the local > tcnt[] array, and eventually returns either one or both of them, > depending on whether the access is 8 or 16 bits.

Re: [PATCH 1/2] hw/timer/renesas_tmr: Prefix constants for CSS values with CSS_

2021-02-19 Thread Philippe Mathieu-Daudé
On 2/19/21 11:32 PM, Peter Maydell wrote: > The #defines INTERNAL and CASCADING represent different possible > values for the TCCR.CSS register field; prefix them with CSS_ to make > this more obvious, before we add more defines to represent the > other possible values of the field in the next

Re: [PATCH] hw/intc/loongson_liointc: Fix per core ISR handling

2021-02-19 Thread Philippe Mathieu-Daudé
On 2/19/21 11:35 PM, Peter Maydell wrote: > This patch has been reviewed and fixes a Coverity issue; > Philippe, are you planning to take it through your MIPS tree? Sorry felt through the crack, now applied to mips-next (I'll send a pull request next week). Thanks! > > -- PMM > > On Tue, 12

Re: problema compilation

2021-02-19 Thread Philippe Mathieu-Daudé
Cc'ing Stefan / Yonggang / Paolo. On 2/20/21 12:03 AM, Peter Maydell wrote: > On Fri, 19 Feb 2021 at 22:54, nerus wrote: >> >> Good evening, I turn to you because I have a problem that does not appear in >> the official documentation, nor in the different blogs or irc channels. >> >> I need to

Re: [PATCH v13 0/5] UFFD write-tracking migration/snapshots

2021-02-19 Thread Peter Xu
On Fri, Feb 19, 2021 at 10:20:42PM +0100, David Hildenbrand wrote: > > A shiver just went down my spine. Please don‘t just for the sake of > > creating a snapshot. > > > > (Just imagine you don‘t have a shared zeropage...) > > ... and I just remembered we read all memory either way. Gah. > > I

Re: [PATCH v2 00/12] block/export: vhost-user-blk server tests and input validation

2021-02-19 Thread Peter Maydell
On Mon, 15 Feb 2021 at 10:41, Kevin Wolf wrote: > > Am 07.12.2020 um 18:20 hat Stefan Hajnoczi geschrieben: > > v2: > > * Add abrt handler that terminates qemu-storage-daemon to > >vhost-user-blk-test. No more orphaned processes on test failure. [Peter] > > * Fix sector number calculation

Re: [PATCH v2 0/8] hw/sd: sd: Erase operation and other fixes

2021-02-19 Thread Philippe Mathieu-Daudé
On 2/16/21 4:02 PM, Bin Meng wrote: > From: Bin Meng > > This includes several fixes related to erase operation of a SD card. > Bin Meng (8): > hw/sd: sd: Fix address check in sd_erase() > hw/sd: sd: Only SDSC cards support CMD28/29/30 > hw/sd: sd: Fix CMD30 response type > hw/sd: sd:

Re: [PATCH] hw/intc/loongson_liointc: Fix per core ISR handling

2021-02-19 Thread Peter Maydell
This patch has been reviewed and fixes a Coverity issue; Philippe, are you planning to take it through your MIPS tree? -- PMM On Tue, 12 Jan 2021 at 01:28, Jiaxun Yang wrote: > > Per core ISR is a set of 32-bit registers spaced by 8 bytes. > This patch fixed calculation of it's size and also

[PATCH 2/2] hw/timer/renesas_tmr: Fix use of uninitialized data in read_tcnt()

2021-02-19 Thread Peter Maydell
The read_tcnt() function calculates the TCNT register values for the two channels of the timer module; it sets these up in the local tcnt[] array, and eventually returns either one or both of them, depending on whether the access is 8 or 16 bits. However, not all of the code paths through this

[PATCH 0/2] hw/timer/renesas_tmr: Fix use of uninitialized data

2021-02-19 Thread Peter Maydell
This patchseries fixes a use-of-uninitialized-data spotted by Coverity (CID 1429976). Patch 1 just tweaks some constant names for values of the TCCR.CSS register field, since patch 2 needs to add some more defines for the other possible values of the field. Patch 2 is the bugfix proper; the

[PATCH 1/2] hw/timer/renesas_tmr: Prefix constants for CSS values with CSS_

2021-02-19 Thread Peter Maydell
The #defines INTERNAL and CASCADING represent different possible values for the TCCR.CSS register field; prefix them with CSS_ to make this more obvious, before we add more defines to represent the other possible values of the field in the next commit. Signed-off-by: Peter Maydell ---

Re: [PATCH v2 5/8] hw/sd: sd: Skip write protect groups check in sd_erase() for high capacity cards

2021-02-19 Thread Philippe Mathieu-Daudé
On 2/16/21 4:02 PM, Bin Meng wrote: > From: Bin Meng > > High capacity cards don't support write protection hence we should > not preform the write protect groups check in sd_erase() for them. > > Signed-off-by: Bin Meng > > --- > > Changes in v2: > - new patch: sd: Skip write protect groups

Re: [PATCH v2 6/8] hw/sd: sd: Actually perform the erase operation

2021-02-19 Thread Philippe Mathieu-Daudé
On 2/16/21 4:02 PM, Bin Meng wrote: > From: Bin Meng > > At present the sd_erase() does not erase the requested range of card > data to 0xFFs. Let's make the erase operation actually happen. > > Signed-off-by: Bin Meng > > --- > > Changes in v2: > - honor the write protection bits for SDSC

Re: [PATCH v2 7/8] hw/sd: sd: Skip write protect groups check in CMD24/25 for high capacity cards

2021-02-19 Thread Philippe Mathieu-Daudé
On 2/16/21 4:02 PM, Bin Meng wrote: > From: Bin Meng > > High capacity cards don't support write protection hence we should > not preform the write protect groups check in CMD24/25 for them. > > Signed-off-by: Bin Meng > > --- > > Changes in v2: > - new patch: sd: Skip write protect groups

Re: [PULL 00/18] QAPI patches patches for 2021-02-18

2021-02-19 Thread Peter Maydell
On Fri, 19 Feb 2021 at 14:49, Markus Armbruster wrote: > > The following changes since commit 91416a4254015e1e3f602f2b241b9ddb7879c10b: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-plugin-updates-180221-1' into staging (2021-02-18 > 13:27:03 +) > > are available in the

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-02-19 Thread Doug Evans
On Fri, Feb 19, 2021 at 2:00 AM Daniel P. Berrangé wrote: > On Thu, Feb 18, 2021 at 12:15:36PM -0800, Doug Evans wrote: > > The parsing is moved into new function inet_parse_host_and_port. > > This is done in preparation for using the function in net/slirp.c. > > > > Signed-off-by: Doug Evans >

Re: [PATCH v2 3/8] hw/sd: sd: Fix CMD30 response type

2021-02-19 Thread Philippe Mathieu-Daudé
On 2/16/21 4:02 PM, Bin Meng wrote: > From: Bin Meng > > Per the "Physical Layer Specification Version 8.00", table 4-26 > (SD mode) and table 7-3 (SPI mode) command descriptions, CMD30 > response type is R1, not R1b. > > Fixes: a1bb27b1e98a ("SD card emulation initial implementation") >

Re: [RFC PATCH 3/5] tests: add a sdhci reproducer

2021-02-19 Thread Philippe Mathieu-Daudé
On 2/18/21 10:12 PM, Alexander Bulekov wrote: > This patch serves as an example of a file generated with the > ./scripts/oss-fuzz/output_reproducer.py script: > The source file in this patch was generated like this: > > $ wget https://paste.debian.net/plain/118513 -O /tmp/trace > $ export

[PULL 5/8] spice-app: avoid crash when core spice module doesn't loaded

2021-02-19 Thread Gerd Hoffmann
From: Bruce Rogers When qemu is built with modules, but a given module doesn't load qemu should handle that gracefully. When ui-spice-core.so isn't able to be loaded and qemu is invoked with -display spice-app or -spice, qemu will dereference a null pointer. With this change we check the pointer

[PULL 3/8] ui/cocoa: Support unique keys of JIS keyboards

2021-02-19 Thread Gerd Hoffmann
From: Akihiko Odaki Signed-off-by: Akihiko Odaki Message-Id: <20210212000404.28413-1-akihiko.od...@gmail.com> Signed-off-by: Gerd Hoffmann --- ui/cocoa.m | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ui/cocoa.m b/ui/cocoa.m index 13fba8103e1a..78fcfeaf04b7 100644 --- a/ui/cocoa.m

[PULL 8/8] ui/console: Remove dpy_gl_ctx_get_current

2021-02-19 Thread Gerd Hoffmann
From: Akihiko Odaki It is not used, and it is unlikely that a new use case will emerge anytime soon because the scope of OpenGL contexts are limited due to the nature of the frontend, VirGL, processing simple commands from the guest. Remove the function and ease implementing a new OpenGL

[PULL 6/8] ui/cocoa: Interpret left button down as is when command is pressed

2021-02-19 Thread Gerd Hoffmann
From: Akihiko Odaki Old Macs were not equipped with mice with an ability to perform "right clicks" and ui/cocoa interpreted left button down with left command key pressed as right button down as a workaround. The workaround has an obvious downside: you cannot tell the guest that the left button

[PULL 7/8] ui/cocoa: Statically allocate dcl

2021-02-19 Thread Gerd Hoffmann
From: Akihiko Odaki There is no need of dynamic allocation as dcl is a small singleton. Static allocation reduces code size and makes hacking with ui/cocoa a bit easier. Signed-off-by: Akihiko Odaki Message-Id: <20210219084419.90181-1-akihiko.od...@gmail.com> Signed-off-by: Gerd Hoffmann ---

[PATCH v5 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2021-02-19 Thread Cleber Rosa
To have the jobs dispatched to custom runners, gitlab-runner must be installed, active as a service and properly configured. The variables file and playbook introduced here should help with those steps. The playbook introduced here covers a number of different Linux distributions and FreeBSD,

[PULL 2/8] spice: flush drawing before notifying client

2021-02-19 Thread Gerd Hoffmann
From: Marc-André Lureau This solves the client having slow/outdated VGA/2D console. It's a regression introduced when the code was switched to render it via opengl in commit 4423184376d ("spice/gl: render DisplaySurface via opengl") Signed-off-by: Marc-André Lureau Message-Id:

[PULL 4/8] ui/cocoa: Do not copy members of pixman image

2021-02-19 Thread Gerd Hoffmann
From: Akihiko Odaki The old CocoaView had an idea of synchronizing the host window configuration and the guest screen configuration. Here, the guest screen actually means pixman image given ui/cocoa display implementation. However, [CocoaView -drawRect:] directly interacts with the pixman image

[PULL 1/8] spice: flush on GL update before notifying client

2021-02-19 Thread Gerd Hoffmann
From: Marc-André Lureau Since the introduction of spice/virgl support in commit 474114b7 ("spice: add opengl/virgl/dmabuf support"), the drawing isn't being flushed before notifying the client. This results in outdated/sluggish drawing on client side, in particular when using the Linux console.

[PATCH v5 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

2021-02-19 Thread Cleber Rosa
The QEMU project has two machines (aarch64 and s390x) that can be used for jobs that do build and run tests. This introduces those jobs, which are a mapping of custom scripts used for the same purpose. Signed-off-by: Cleber Rosa Reviewed-by: Daniel P. Berrangé ---

[PULL 0/8] Ui 20210219 patches

2021-02-19 Thread Gerd Hoffmann
The following changes since commit c79f01c9450bcf90c08a77f13fbf67bdba59a316: Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-hex-20210218' in= to staging (2021-02-18 16:33:36 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/ui-20210219-pull-request

[PATCH v5 0/4] GitLab Custom Runners and Jobs (was: QEMU Gating CI)

2021-02-19 Thread Cleber Rosa
TL;DR: this should allow the QEMU maintainer to push to the staging branch, and have custom jobs running on the project's aarch64 and s390x machines. Jobs in this version are allowed to fail, to allow for the inclusion of the novel machines/jobs without CI disruption. Simple usage looks like:

[PATCH v5 2/4] Jobs based on custom runners: build environment docs and playbook

2021-02-19 Thread Cleber Rosa
To run basic jobs on custom runners, the environment needs to be properly set up. The most common requirement is having the right packages installed. The playbook introduced here covers the QEMU's project s390x and aarch64 machines. At the time this is being proposed, those machines have

[PATCH v5 1/4] Jobs based on custom runners: documentation and configuration placeholder

2021-02-19 Thread Cleber Rosa
As described in the included documentation, the "custom runner" jobs extend the GitLab CI jobs already in place. One of their primary goals of catching and preventing regressions on a wider number of host systems than the ones provided by GitLab's shared runners. This sets the stage in which

Re: [PATCH v4 1/4] slirp: Advance libslirp submodule to add ipv6 host-forward support

2021-02-19 Thread Doug Evans
On Fri, Feb 19, 2021 at 1:38 AM Daniel P. Berrangé wrote: > On Thu, Feb 18, 2021 at 12:15:35PM -0800, Doug Evans wrote: > > FWIW, normally when QEMU updates libslirp, the commit message is > set to contain the "git shortlog old..new" output > Ah. In this case I'm not sure what to do as QEMU

[PATCH v2] bsd-user: Add new maintainers

2021-02-19 Thread Warner Losh
From: Warner Losh The FreeBSD project has a number of enhancements to bsd-user. Add myself as maintainer and Kyle Evans as a reviewer. Also add our github repo. Signed-off-by: Warner Losh Reviewed-by: Thomas Huth --- MAINTAINERS | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-)

[PATCH] FreeBSD: Upgrade to 12.2 release

2021-02-19 Thread Warner Losh
From: Warner Losh FreeBSD 12.1 has reached end of life. Use 12.2 instead so that FreeBSD's project's packages will work. Signed-off-by: Warner Losh --- tests/vm/freebsd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/vm/freebsd b/tests/vm/freebsd index

Re: [PATCH v3 7/7] spapr_drc.c: use DRC reconfiguration to cleanup DIMM unplug state

2021-02-19 Thread Daniel Henrique Barboza
On 2/16/21 11:31 PM, David Gibson wrote: On Thu, Feb 11, 2021 at 07:52:46PM -0300, Daniel Henrique Barboza wrote: Handling errors in memory hotunplug in the pSeries machine is more complex than any other device type, because there are all the complications that other devices has, and more.

Re: [PATCH v13 0/5] UFFD write-tracking migration/snapshots

2021-02-19 Thread David Hildenbrand
> Am 19.02.2021 um 22:14 schrieb David Hildenbrand : > >  >>> Am 19.02.2021 um 22:10 schrieb Peter Xu : >>> >>> On Fri, Feb 19, 2021 at 03:50:52PM -0500, Peter Xu wrote: >>> Andrey, >>> On Fri, Feb 19, 2021 at 09:57:37AM +0300, Andrey Gruzdev wrote: For the discards that happen

Re: [PATCH v13 0/5] UFFD write-tracking migration/snapshots

2021-02-19 Thread David Hildenbrand
> Am 19.02.2021 um 22:10 schrieb Peter Xu : > > On Fri, Feb 19, 2021 at 03:50:52PM -0500, Peter Xu wrote: >> Andrey, >> >>> On Fri, Feb 19, 2021 at 09:57:37AM +0300, Andrey Gruzdev wrote: >>> For the discards that happen before snapshot is started, I need to dig into >>> Linux and QEMU

Re: [PATCH v13 0/5] UFFD write-tracking migration/snapshots

2021-02-19 Thread Peter Xu
On Fri, Feb 19, 2021 at 03:50:52PM -0500, Peter Xu wrote: > Andrey, > > On Fri, Feb 19, 2021 at 09:57:37AM +0300, Andrey Gruzdev wrote: > > For the discards that happen before snapshot is started, I need to dig into > > Linux and QEMU virtio-baloon > > code more to get clear with it. > > Yes

Re: [PATCH v13 0/5] UFFD write-tracking migration/snapshots

2021-02-19 Thread Peter Xu
Andrey, On Fri, Feb 19, 2021 at 09:57:37AM +0300, Andrey Gruzdev wrote: > For the discards that happen before snapshot is started, I need to dig into > Linux and QEMU virtio-baloon > code more to get clear with it. Yes it's very tricky on how the error could trigger. Let's think of below

Re: [PATCH] target/arm: Use TCF0 and TFSRE0 for unprivileged tag checks

2021-02-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210219201820.2672077-1-...@google.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210219201820.2672077-1-...@google.com Subject: [PATCH] target/arm: Use TCF0 and TFSRE0 for

Re: [PATCH] target/i386/sev: Ensure sev_fw_errlist is sync with update-linux-headers

2021-02-19 Thread Connor Kuehl
On 2/19/21 12:01 PM, Philippe Mathieu-Daudé wrote: Ensure sev_fw_errlist[] is updated after running the update-linux-headers.sh script. Signed-off-by: Philippe Mathieu-Daudé --- Based-on: <20210218151633.215374-1-cku...@redhat.com> --- target/i386/sev.c | 5 - 1 file changed, 4

[PATCH] target/arm: Use TCF0 and TFSRE0 for unprivileged tag checks

2021-02-19 Thread Peter Collingbourne via
Section D6.7 of the ARM ARM states: For the purpose of determining Tag Check Fault handling, unprivileged load and store instructions are treated as if executed at EL0 when executed at either: - EL1, when the Effective value of PSTATE.UAO is 0. - EL2, when both the Effective value of

Re: [PATCH v3 7/7] spapr_drc.c: use DRC reconfiguration to cleanup DIMM unplug state

2021-02-19 Thread Daniel Henrique Barboza
On 2/16/21 11:31 PM, David Gibson wrote: On Thu, Feb 11, 2021 at 07:52:46PM -0300, Daniel Henrique Barboza wrote: Handling errors in memory hotunplug in the pSeries machine is more complex than any other device type, because there are all the complications that other devices has, and more.

Re: Can not set high msize with virtio-9p (Was: Re: virtiofs vs 9p performance)

2021-02-19 Thread Vivek Goyal
On Fri, Feb 19, 2021 at 06:33:46PM +0100, Christian Schoenebeck wrote: > On Freitag, 19. Februar 2021 17:08:48 CET Vivek Goyal wrote: > > On Fri, Sep 25, 2020 at 10:06:41AM +0200, Christian Schoenebeck wrote: > > > On Freitag, 25. September 2020 00:10:23 CEST Vivek Goyal wrote: > > > > In my

Re: [PATCH 0/2] Allwinner H3 fixes for EMAC and acceptance tests

2021-02-19 Thread Cleber Rosa
On Fri, Feb 19, 2021 at 07:24:01PM +0100, Philippe Mathieu-Daudé wrote: > > I hope you understand the concern I have is not with you in particular, > and I used your case to start a discussion with the QEMU community. > > FWIW I missed the URL change because I still have the image cached in >

Re: [PATCH v2 1/1] css: SCHIB measurement block origin must be aligned

2021-02-19 Thread Pierre Morel
On 2/19/21 2:41 PM, Thomas Huth wrote: On 19/02/2021 14.39, Pierre Morel wrote: The Measurement Block Origin inside the SCHIB is used when Measurement Block format 1 is in used and must be aligned on 64 bytes otherwise an operand exception is recognized when issuing the Modify Sub CHannel

[PATCH 2/4] ui: introduce "password-secret" option for SPICE server

2021-02-19 Thread Daniel P . Berrangé
Currently when using SPICE the "password" option provides the password in plain text on the command line. This is insecure as it is visible to all processes on the host. As an alternative, the password can be provided separately via the monitor. This introduces a "password-secret" option which

[PATCH 4/4] ui, monitor: remove deprecated VNC ACL option and HMP commands

2021-02-19 Thread Daniel P . Berrangé
The VNC ACL concept has been replaced by the pluggable "authz" framework which does not use monitor commands. Signed-off-by: Daniel P. Berrangé --- docs/system/deprecated.rst | 16 --- docs/system/removed-features.rst | 13 +++ hmp-commands.hx | 76 -

[PATCH 1/4] ui: introduce "password-secret" option for VNC servers

2021-02-19 Thread Daniel P . Berrangé
Currently when using VNC the "password" flag turns on password based authentication. The actual password has to be provided separately via the monitor. This introduces a "password-secret" option which lets the password be provided up front. $QEMU --object secret,id=vncsec0,file=passwd.txt \

[PATCH 3/4] ui: deprecate "password" option for SPICE server

2021-02-19 Thread Daniel P . Berrangé
With the new "password-secret" option, there is no reason to use the old inecure "password" option with -spice, so it can be deprecated. Signed-off-by: Daniel P. Berrangé --- docs/system/deprecated.rst | 8 qemu-options.hx| 4 ui/spice-core.c| 4 3

[PATCH 0/4] ui: add support for 'secret' object to provide VNC/SPICE passwords

2021-02-19 Thread Daniel P . Berrangé
This fixes a long standing limitation of the VNC/SPICE code which was unable to securely accept passswords on the CLI, instead requiring use of separate monitor commands after startup. This takes the opportunity to also remove previously deprecated ACL functionality from VNC. Daniel P. Berrangé

link to User documentation of https://wiki.qemu.org/Features/Tracing is broken currently

2021-02-19 Thread Claudio Fontana
Hi all, the link to User documentation of https://wiki.qemu.org/Features/Tracing is broken currently: it points to: http://git.qemu-project.org/?p=qemu.git;a=blob_plain;f=docs/devel/tracing.txt;hb=HEAD and that to me gives a 404 - Cannot find file. Ciao, Claudio -- Claudio Fontana

Re: FreeBSD build regressions

2021-02-19 Thread Warner Losh
On Fri, Feb 19, 2021 at 9:14 AM Peter Maydell wrote: > On Fri, 19 Feb 2021 at 16:08, Warner Losh wrote: > > FreeBSD builds packages on the oldest supported version in the stable > branch. Due to forward compatibility, that means all supported versions of > FreeBSD 12.x will work. Recently,

Re: who's using the ozlabs patchwork install for QEMU patches ?

2021-02-19 Thread Philippe Mathieu-Daudé
On 2/19/21 7:07 PM, BALATON Zoltan wrote: > On Fri, 19 Feb 2021, Peter Maydell wrote: >> Does anybody use the ozlabs patchwork install for QEMU patches, >> either occasionally or on a regular basis ? >> http://patchwork.ozlabs.org/project/qemu-devel/list/ >> The admins for that system are trying

  1   2   3   4   >