Le 12/03/2021 à 07:45, John Snow a écrit :
On 1/8/21 6:01 PM, Alexander Bulekov wrote:
fdctrl_format_sector was added in
baca51faff ("updated floppy driver: formatting code, disk geometry auto detect
(Jocelyn Mayer)")
The single callsite is guarded by a check:
fdctrl->data_state &
ui/cocoa used to raise all keys before it resigns active to prevent a
stuck key problem caused by key up events it does not see while it is
inactive. The problem is solved by checking -[NSEvent modifierFlags] in
commit 6d73bb643aa725348aabe6a885ac5fb0b7f70252, which is better
because it handles
Signed-off-by: Alexander Bulekov
---
Fuzzing this device might lead to better coverage over the general scsi
code.
tests/qtest/fuzz/generic_fuzz_configs.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h
QEMU ppce500 machine can dynamically instantiate an eTSEC device
if "-device eTSEC" is given to QEMU.
This series updates the fixed-link ethernet PHY driver as well as
the Freescale eTSEC driver to support the QEMU ppce500 board.
3 patches related to fixed phy in v1 are dropped in v2 as the
Here are examples of code generated by the script:
https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg06027.html
https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg06028.html
https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg06029.html
On 210313 2323, Alexander Bulekov wrote:
>
We have several scripts that help build reproducers, but no
documentation for how they should be used. Add some documentation
Signed-off-by: Alexander Bulekov
---
docs/devel/fuzzing.rst | 45 ++
1 file changed, 45 insertions(+)
diff --git
Currently, bash and C crash reproducers are be built manually. This is a
problem, as we want to integrate reproducers into the tree, for
regression testing. This patch adds a script that converts a sequence of
QTest commands into a pasteable Bash reproducer, or a libqtest-based C
program. This
Hello,
This series adds a script that can be handy for reporting fuzzer bugs
and creating regression-tests, based on crash reproducers.
Patch 1 adds a script that can help create bash and C reproducers for
crashes.
Patch 2 documents the process of building reproducers.
Alexander Bulekov (2):
Changed calls to malloc(), calloc(), and realloc() with their
equivalent allocation functions in GLib, and replaced their
respective free() calls with g_free().
Allocation and deallocation of fuse_req structs, fuse_pollhandle
structs, fuse_session structs and many local variables are now
Replaced a call to calloc() and its respective free() call
with GLib's g_try_new0() and g_free() calls.
Signed-off-by: Mahmoud Mandour
---
tools/virtiofsd/buffer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/virtiofsd/buffer.c b/tools/virtiofsd/buffer.c
index
Replaced a malloc() call and its respective free() with
GLib's g_try_malloc() and g_free() calls.
Signed-off-by: Mahmoud Mandour
---
tools/virtiofsd/fuse_opt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/virtiofsd/fuse_opt.c b/tools/virtiofsd/fuse_opt.c
index
Replaced the calls to malloc() and their respective calls to
free() with GLib's allocation and deallocation functions.
Removed null checking before calling g_free() because it's
not necessary and generates style errors.
Signed-off-by: Mahmoud Mandour
---
target/xtensa/xtensa-isa.c | 53
Replaced a malloc() call and its respective free() call with
GLib's g_try_malloc() and g_free().
Also, did slight styling changes that were producing
style errors when using the checkpatch.pl script against
the file.
Signed-off-by: Mahmoud Mandour
---
util/compatfd.c | 10 +-
1 file
Fixed style errors on the relevant lines in which
I will introduce changes.
Signed-off-by: Mahmoud Mandour
---
hw/audio/fmopl.c | 58 ++--
1 file changed, 32 insertions(+), 26 deletions(-)
diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c
index
Replaced calls to malloc(), and free() to their equivalent
allocation functions from GLib.
Also added checking for null after ENV_CURVE allocation
following the same pattern of checking on preceeding
table allocations.
Signed-off-by: Mahmoud Mandour
---
hw/audio/fmopl.c | 42
Replaced the calls to malloc(), realloc(), and free() to their
equivalents in GLib's allocation functions in various places.
Signed-off-by: Mahmoud Mandour
---
bsd-user/elfload.c | 74 +++---
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git
Inspired by the task in the Bite-sized tasks page, I've tried to change
some of the occurrences of malloc(), calloc(), and realloc() calls and
their respective free() calls. I also included some minor style
improvements that caused errors and warnings when supplied to the
checkpatch.pl script.
>
> Nack.
>
> This is BIOS code and it does not have glib.
>
Thank you so much for the helping notice. This did not cause
build problems nor was mentioned in the bite-sized tasks
page as a place to not change. In any case, there are some
more problems with this series so I was going to resend it
On 3/13/21 6:40 PM, Taylor Simpson wrote:
-Original Message-
From: Richard Henderson
Sent: Sunday, February 14, 2021 7:04 PM
To: Taylor Simpson ; qemu-devel@nongnu.org
Cc: phi...@redhat.com; alex.ben...@linaro.org; laur...@vivier.eu;
a...@rev.ng; Brian Cain
Subject: Re: [PATCH v8
On 3/13/21 6:39 PM, Taylor Simpson wrote:
BTW, how can I generate an assert via TCG?
You can't, as such. You can call a helper function, which can do whatever.
Except for HEX_DEBUG, why would we not know whether or not a predicate
has been
written twice? It seems like we shouldn't need
> -Original Message-
> From: Richard Henderson
> Sent: Sunday, February 14, 2021 6:34 PM
> To: Taylor Simpson ; qemu-devel@nongnu.org
> Cc: phi...@redhat.com; alex.ben...@linaro.org; laur...@vivier.eu;
> a...@rev.ng; Brian Cain
> Subject: Re: [PATCH v8 27/35] Hexagon (target/hexagon)
> -Original Message-
> From: Richard Henderson
> Sent: Sunday, February 14, 2021 7:04 PM
> To: Taylor Simpson ; qemu-devel@nongnu.org
> Cc: phi...@redhat.com; alex.ben...@linaro.org; laur...@vivier.eu;
> a...@rev.ng; Brian Cain
> Subject: Re: [PATCH v8 29/35] Hexagon (target/hexagon)
> -Original Message-
> From: Richard Henderson
> Sent: Sunday, February 14, 2021 6:07 PM
> To: Taylor Simpson ; qemu-devel@nongnu.org
> Cc: phi...@redhat.com; alex.ben...@linaro.org; laur...@vivier.eu;
> a...@rev.ng; Brian Cain
> Subject: Re: [PATCH v8 26/35] Hexagon (target/hexagon)
> -Original Message-
> From: Richard Henderson
> Sent: Sunday, February 14, 2021 5:41 PM
> To: Taylor Simpson ; qemu-devel@nongnu.org
> Cc: phi...@redhat.com; alex.ben...@linaro.org; laur...@vivier.eu;
> a...@rev.ng; Brian Cain
> Subject: Re: [PATCH v8 25/35] Hexagon (target/hexagon)
Hi Claudio,
On 2/4/21 5:39 PM, Claudio Fontana wrote:
> v15 -> v16:
>
> * cpu: Move synchronize_from_tb() to tcg_ops:
> - adjusted comments (Alex)
>
> * cpu: tcg_ops: move to tcg-cpu-ops.h, keep a pointer in CPUClass:
> - remove forward decl. of AccelCPUClass, should be in a later patch.
Hi Richard,
On 3/4/21 11:23 PM, Philippe Mathieu-Daudé wrote:
> Hi,
>
> cpu_has_work() isn't used out of TCG, so restrict it to it.
> RFC because maybe it could?
>
> Since v1:
> - finished PPC
> - check cc->tcg_ops->has_work non-null (thuth)
>
> Based-on:
On 2/26/21 10:30 AM, Philippe Mathieu-Daudé wrote:
> Series fully reviewed.
> Philippe Mathieu-Daud=C3=A9 (13):
> target/mips/meson: Introduce mips_tcg source set
> target/mips/meson: Restrict mips-semi.c to TCG
> target/mips: Rewrite complex ifdef'ry
> target/mips: Remove XBurst Media
v2:
- Make the device a TYPE_SYS_BUS_DEVICE device
- Remove the qtest (the device cannot be enabled for testing outside
of the fuzzing code).
- Since this will only be used for short-lived fuzzing processes, do
not keep track of empty regions.
- Move some DMA callbacks
On 3/11/2021 1:39 PM, Daniel P. Berrangé wrote:
On Thu, Mar 11, 2021 at 06:28:57PM +, Dr. David Alan Gilbert wrote:
* Laurent Vivier (laur...@vivier.eu) wrote:
Le 08/03/2021 à 12:46, Thomas Huth a écrit :
On 22/02/2021 08.28, Brad Smith wrote:
OpenBSD has supported 64-bit time_t across
For the sparse-mem device, we want the fuzzer to populate entire DMA
reads from sparse-mem, rather than hooking into the individual MMIO
memory_region_dispatch_read operations. Otherwise, the fuzzer will treat
each sequential read separately (and populate it with a separate
pattern). Work around
The generic-fuzzer often provides randomized DMA addresses to
virtual-devices. For a 64-bit address-space, the chance of these
randomized addresses coinciding with RAM regions, is fairly small. Even
though the fuzzer's instrumentation eventually finds valid addresses,
this can take some-time, and
For testing, it can be useful to simulate an enormous amount of memory
(e.g. 2^64 RAM). This adds an MMIO device that acts as sparse memory.
When something writes a nonzero value to a sparse-mem address, we
allocate a block of memory. This block is kept around, until all of the
bytes within the
On 3/13/21 9:02 PM, Richard Henderson wrote:
> On 3/13/21 10:54 AM, Philippe Mathieu-Daudé wrote:
>> +static unsigned gpio_port_index(char c)
>> +{
>> + assert(c >= 'A' && c < 'A' + GPIO_MAX);
>> + return c - 'A';
>> +}
>
> If you're not going to use this for anything else, isn't
>
>
Reviewed-by: Michael Rolnik
On Sat, Mar 13, 2021 at 6:54 PM Philippe Mathieu-Daudé
wrote:
> Hi,
>
> This series contains all the AVR patches I could find on the list.
>
> Niteesh, I fixed minor issues. Do you mind reviewing on top?
>
> Pull request planned for Monday if no problem arises.
>
>
On 3/11/21 2:07 PM, Eric Blake wrote:
+/*
+ * Add in a fudge-factor (2^53 when double is IEEE format) for
+ * all scales less than P (2^50), so that things like
+ * 12.345M with unit 1000 produce 12345000 instead of
+ * 12344999.
+ */
+if
On 3/13/21 10:54 AM, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
hw/gpio/avr_gpio.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
Reviewed-by: Richard Henderson
r~
On 3/13/21 10:54 AM, Philippe Mathieu-Daudé wrote:
+if (s->id == UINT8_MAX) {
+error_setg(errp, "property 'id' not set");
+return;
+}
This error message would be a tad confusing if one set the id to 255. What's
the point?
r~
On 3/13/21 10:54 AM, Philippe Mathieu-Daudé wrote:
Add the yellow "lime" LED.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/misc/led.h | 1 +
hw/misc/led.c | 1 +
2 files changed, 2 insertions(+)
Reviewed-by: Richard Henderson
r~
We have almost 400 lines of code full of /* TODO */ comments
which end calling gen_reserved_instruction().
As we are not going to implement them, and all the caller's
switch() default cases already call gen_reserved_instruction(),
we can remove this altogether.
Signed-off-by: Philippe
This comment describing the tx79 opcodes is helpful. As we
will implement these instructions in tx79_translate.c, move
the comment there.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20210214175912.732946-15-f4...@amsat.org>
Signed-off-by: Philippe
Move PCPYLD (Parallel Copy Lower Doubleword) and PCPYUD
(Parallel Copy Upper Doubleword) to decodetree. Remove
unnecessary code / comments.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20210214175912.732946-13-f4...@amsat.org>
Signed-off-by: Philippe
Move the existing PCPYH opcode (Parallel Copy Halfword) to decodetree.
Remove unnecessary code / comments.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20210214175912.732946-12-f4...@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé
---
Introduce decodetree structure to decode the tx79 opcodes.
Start it by moving the existing MFHI1 and MFLO1 opcodes.
Remove unnecessary comments.
As the TX79 share opcodes with the TX19/TX39/TX49 CPUs,
we introduce the decode_ext_txx9() dispatcher where we
will add the other decoders later.
Simplify the PCPYH (Parallel Copy Halfword) instruction by using
multiple calls to deposit_i64() which can be optimized by some
TCG backends.
Suggested-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id:
On 3/13/21 10:54 AM, Philippe Mathieu-Daudé wrote:
+static unsigned gpio_port_index(char c)
+{
+assert(c >= 'A' && c < 'A' + GPIO_MAX);
+return c - 'A';
+}
If you're not going to use this for anything else, isn't
#define PORT_B 1
enough?
r~
We already have a macro and definition to extract / check
the Special2 MUL opcode. Use it instead of the unnecessary
OPC__MXU_MUL macro.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/translate.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
On 3/13/21 10:54 AM, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
hw/gpio/avr_gpio.c | 14 ++
1 file changed, 14 insertions(+)
Reviewed-by: Richard Henderson
r~
We will use gen_rdhwr() outside of translate.c, make it public.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20210214175912.732946-28-f4...@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/translate.h | 2 ++
target/mips/translate.c | 2 +-
None of these MXU functions use their CPUMIPSState* env argument,
remove it.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/translate.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/target/mips/translate.c
On 3/13/21 10:54 AM, Philippe Mathieu-Daudé wrote:
+#define AVR_GPIO_COUNT 8
+
+struct AVRGPIOState {
+/*< private >*/
+SysBusDevice parent_obj;
+
+/*< public >*/
+MemoryRegion mmio;
+
+struct {
+uint8_t pin;
+uint8_t ddr;
+uint8_t port;
+} reg;
+
By making the prototype public and checking
'TARGET_LONG_BITS == 32' we let the compiler
elide the decode_opc_mxu() call.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/translate.h | 3 +++
target/mips/translate.c | 6 ++
2 files changed, 5
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20210214175912.732946-10-f4...@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/tx79.decode | 3 +++
target/mips/translate.c | 25 -
target/mips/tx79_translate.c
No need for this obfuscated ifdef'ry, KISS.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/translate.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/target/mips/translate.c b/target/mips/translate.c
index
Move the check for MUL opcode from decode_opc_mxu() callee
to decode_opc_legacy() caller, so we can simplify the ifdef'ry
and elide the call in few commits.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/translate.c | 19 +--
1 file
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/mips/meson.build b/target/mips/meson.build
index 75c16524606..53580633ce0 100644
--- a/target/mips/meson.build
+++
On 3/13/21 10:54 AM, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
hw/avr/arduino.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson
r~
Extract the MXU register initialization code from mips_tcg_init()
as a new mxu_translate_init() helper. Make it public and replace
!TARGET_MIPS64 ifdef'ry by the 'TARGET_LONG_BITS == 32' check to
elide this code at preprocessing time.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe
In the next commit we'll make decode_opc_mxu() match decodetree
prototype by returning a boolean. First pass ctx->opcode as an
argument.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/translate.c | 14 +++---
1 file changed, 7 insertions(+), 7
Introduce the 'mips_tcg' source set to collect TCG specific files.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/meson.build | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/target/mips/meson.build b/target/mips/meson.build
index
To easily convert MXU code to decodetree, making it return a boolean.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/translate.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/target/mips/translate.c b/target/mips/translate.c
Extract 1600+ lines from the big translate.c into a new file.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/mxu_translate.c | 1609 +++
target/mips/translate.c | 1605 --
All these unimplemented MXU opcodes end up calling
gen_reserved_instruction() which is the default switch
case in decode_opc_mxu().
The translate.c file is already big enough and hard to maintain,
remove 1300 lines of unnecessary code and /* TODO */ comments.
Reviewed-by: Richard Henderson
Use "decode_{isa,ase,ext}_$name()" function name pattern for
public decodetree entrypoints.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/translate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/mips/translate.c
Use gen_load_gpr[_hi]() instead of open coding it.
Patch generated using the following spatch script:
@gen_load_gpr@
identifier reg_idx;
expression tcg_reg;
@@
-if (reg_idx == 0) {
-tcg_gen_movi_tl(tcg_reg, 0);
-} else {
-tcg_gen_mov_tl(tcg_reg, cpu_gpr[reg_idx]);
-}
We want to trace all register accesses. First rename the current
gt64120_read / gt64120_write events with '_intreg' suffix, as they
are restricted to interrupt registers.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: BALATON Zoltan
Message-Id: <20210309142630.728014-5-f4...@amsat.org>
---
Trace all accesses to Internal Space Decode (ISD) registers.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: BALATON Zoltan
Message-Id: <20210309142630.728014-6-f4...@amsat.org>
---
hw/mips/gt64xxx_pci.c | 2 ++
hw/mips/trace-events | 2 ++
2 files changed, 4 insertions(+)
diff --git
The ISD MemoryRegion is implemented for 32-bit accesses.
Simplify it by setting the MemoryRegionOps::impl min/max
access size fields.
Since the region is registered with a size of 0x1000 bytes,
we can remove the hwaddr mask.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: BALATON Zoltan
The ISD I/O region belongs to the TYPE_GT64120_PCI_HOST_BRIDGE,
so initialize it before it is realized, not after.
Rename the region as 'gt64120-isd' so it is clearer to realize
it belongs to the GT64120 in the memory tree view.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: BALATON Zoltan
The following changes since commit 3f8d1885e48e4d72eab0688f604de62e0aea7a38:
Merge remote-tracking branch 'remotes/kraxel/tags/ui-20210311-pull-request'
into staging (2021-03-12 13:53:44 +)
are available in the Git repository at:
https://github.com/philmd/qemu.git tags/mips-20210313
Fix the following typos:
- GT_PCI1_CFGDATA is not a timer register but a PCI one,
- zero-padding flag is out of the format
Fixes: 641ca2bfcd5 ("hw/mips/gt64xxx_pci: Use qemu_log_mask() instead of debug
printf()")
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: BALATON Zoltan
Message-Id:
On 3/13/21 11:01 AM, Philippe Mathieu-Daudé wrote:
When QDev objects have their DeviceReset handler set, they
shouldn't worry about calling it at realization stage (it
is handled by hw/core/qdev.c::device_set_realized).
Remove the pointless/confusing bcm2835_fb_reset() call.
Signed-off-by:
On 3/13/21 1:27 PM, Philippe Mathieu-Daudé wrote:
On 3/11/21 1:21 AM, Richard Henderson wrote:
Perform both tcg_context_init and tcg_region_init.
Do not leave this split to the caller.
Signed-off-by: Richard Henderson
---
include/tcg/tcg.h | 3 +--
tcg/internal.h| 1 +
On Sat, 13 Mar 2021 at 19:05, Richard Henderson
wrote:
>
> On 3/12/21 12:59 PM, Peter Maydell wrote:
> > On Fri, 12 Mar 2021 at 17:29, Peter Maydell
> > wrote:
> >> This series handles the possibility of aliasing by iterating through
> >> the whole FlatView of the CPU's address space checking
On 3/11/21 1:21 AM, Richard Henderson wrote:
> Perform both tcg_context_init and tcg_region_init.
> Do not leave this split to the caller.
>
> Signed-off-by: Richard Henderson
> ---
> include/tcg/tcg.h | 3 +--
> tcg/internal.h| 1 +
> accel/tcg/translate-all.c | 3 +--
>
On 3/12/21 12:59 PM, Peter Maydell wrote:
On Fri, 12 Mar 2021 at 17:29, Peter Maydell wrote:
This series handles the possibility of aliasing by iterating through
the whole FlatView of the CPU's address space checking for other
mappings of the MemoryRegion corresponding to the location of the
On 3/12/21 2:17 PM, Philippe Mathieu-Daudé wrote:
+static int find_rom_cb(Int128 start, Int128 len, const MemoryRegion *mr,
+ hwaddr offset_in_region, void *opaque)
Return bool maybe?
Yes, it might be worth changing with the first patch, while we're changing all
(one)
On 13.03.21 17:36, Mahmoud Mandour wrote:
Changed a call to malloc() and its respective calls free() with
GLib's allocation and deallocation functions.
Signed-off-by: Mahmoud Mandour
Nack.
This is BIOS code and it does not have glib.
---
pc-bios/s390-ccw/netmain.c | 6 +++---
1 file
On 3/10/21 6:21 PM, Richard Henderson wrote:
Buffer management is integral to tcg. Do not leave the allocation
to code outside of tcg/. This is code movement, with further
cleanups to follow.
Signed-off-by: Richard Henderson
---
include/tcg/tcg.h | 2 +-
accel/tcg/translate-all.c
On 3/10/21 6:21 PM, Richard Henderson wrote:
There's no reason to do this in the main meson.build.
Signed-off-by: Richard Henderson
---
meson.build | 1 -
disas/meson.build | 2 ++
2 files changed, 2 insertions(+), 1 deletion(-)
I'm going to drop this one because it conflicts with
I saw comments about support for virtio devices on AIX 7.2, was it not
available on AIX 7.1?
With AIX 7.1 also, I am getting similar issue as faced by other users with AIX
6.1.
qemu-system-ppc64 -cpu POWER8 -machine pseries -m 2048 -d unimp -serial stdio
-drive
Hi all,
I'm a student and I'm new to QEMU and virtualization.
I would like to locate the Interrupt Descriptor Table of the guest from the
host and so I want to obtain a host virtual address pointing to it.
I don't know if I've found the right way to do that, but till now I'm doing
like this from
Public bug reported:
Hello,
Using hypervisor fuzzer, hyfuzz, I found an assertion failure through
am53c974 emulator.
A malicious guest user/process could use this flaw to abort the QEMU
process on the host, resulting in a denial of service.
This was found in version 5.2.0 (master, 3f8d1885e4)
On 3/11/21 1:21 AM, Richard Henderson wrote:
> For --enable-tcg-interpreter on Windows, we will need this.
>
> Signed-off-by: Richard Henderson
> ---
> include/qemu/osdep.h | 1 +
> util/osdep.c | 9 +
> 2 files changed, 10 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé
On 3/11/21 1:21 AM, Richard Henderson wrote:
> Finish the divorce of tcg/ from hw/, and do not take
> the max cpu value from MachineState; just rememver what
Typo "remember"
> we were passed in tcg_init.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/internal.h | 3 ++-
> tcg/region.c |
On 3/11/21 1:21 AM, Richard Henderson wrote:
> Start removing the include of hw/boards.h from tcg/.
> Pass down the max_cpus value from tcg_init_machine,
> where we have the MachineState already.
>
> Signed-off-by: Richard Henderson
> ---
> include/tcg/tcg.h | 2 +-
> tcg/internal.h |
On 3/11/21 1:21 AM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> meson.build | 4 +---
> fpu/meson.build | 1 +
> 2 files changed, 2 insertions(+), 3 deletions(-)
> create mode 100644 fpu/meson.build
Reviewed-by: Philippe Mathieu-Daudé
On 3/11/21 1:21 AM, Richard Henderson wrote:
> We shortly want to use tcg_init for something else.
> Since the hook is called init_machine, match that.
>
> Signed-off-by: Richard Henderson
> ---
> accel/tcg/tcg-all.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by:
On 3/11/21 1:21 AM, Richard Henderson wrote:
> It consists of one function call and has only one caller.
>
> Signed-off-by: Richard Henderson
> ---
> accel/tcg/translate-all.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
On 3/11/21 1:21 AM, Richard Henderson wrote:
> All callers immediately assert on error, so move the assert
> into the function itself.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/tcg.c | 19 ++-
> 1 file changed, 6 insertions(+), 13 deletions(-)
Reviewed-by: Philippe
On 3/11/21 1:21 AM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> meson.build | 9 ++---
> tcg/meson.build | 13 +
> 2 files changed, 15 insertions(+), 7 deletions(-)
> create mode 100644 tcg/meson.build
Reviewed-by: Philippe Mathieu-Daudé
On 3/11/21 1:21 AM, Richard Henderson wrote:
> There's no reason to do this in the main meson.build.
>
> Signed-off-by: Richard Henderson
> ---
> meson.build | 1 -
> disas/meson.build | 2 ++
> 2 files changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé
Public bug reported:
Hello,
Using hypervisor fuzzer, hyfuzz, I found an assertion failure through
am53c974 emulator.
A malicious guest user/process could use this flaw to abort the QEMU
process on the host, resulting in a denial of service.
This was found in version 5.2.0 (master, 3f8d1885e4)
Reviewed-by: Niteesh G S
On Sat, Mar 13, 2021 at 10:32 PM Niteesh G. S. wrote:
> Hii Phil,
>
> Just a few mins earlier than me :)
>
> Thanks,
> Niteesh
>
> On Sat, Mar 13, 2021 at 10:25 PM Philippe Mathieu-Daudé
> wrote:
>
>> From: G S Niteesh Babu
>>
>> Signed-off-by: G S Niteesh Babu
>>
On 3/13/21 11:11 AM, Philippe Mathieu-Daudé wrote:
Philippe Mathieu-Daudé (3):
hw/arm: Constify VMStateDescription
hw/display/qxl: Constify VMStateDescription
hw/usb: Constify VMStateDescription
Reviewed-by: Richard Henderson
r~
When QDev objects have their DeviceReset handler set, they
shouldn't worry about calling it at realization stage (it
is handled by hw/core/qdev.c::device_set_realized).
Remove the pointless/confusing bcm2835_fb_reset() call.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/display/bcm2835_fb.c | 2
Reviewed-by: Niteesh G S
On Sat, Mar 13, 2021 at 10:25 PM Philippe Mathieu-Daudé
wrote:
> From: G S Niteesh Babu
>
> Added tracing for gpio read, write, and update output irq.
>
> 1) trace_avr_gpio_update_ouput_irq
> 2) trace_avr_gpio_read
> 3) trace_avr_gpio_write
>
> Signed-off-by: G S
On 3/12/21 9:55 AM, Philippe Mathieu-Daudé wrote:
Philippe Mathieu-Daudé (2):
MAINTAINERS: Mark RX hardware emulation orphan
MAINTAINERS: Mark SH-4 hardware emulation orphan
Acked-by: Richard Henderson
r~
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/ccid-card-passthru.c | 2 +-
hw/usb/dev-smartcard-reader.c | 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/usb/ccid-card-passthru.c b/hw/usb/ccid-card-passthru.c
index c1a90fcc7a5..7212d0d7fb5 100644
---
From: G S Niteesh Babu
Signed-off-by: G S Niteesh Babu
Reviewed-by: Michael Rolnik
Message-Id: <20210311135539.10206-4-niteesh...@gmail.com>
[PMD: Added ArduinoMachineClass::d13_led_portb_bit]
Signed-off-by: Philippe Mathieu-Daudé
---
hw/avr/arduino.c | 18 ++
hw/avr/Kconfig
Signed-off-by: Philippe Mathieu-Daudé
---
hw/display/qxl.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index 93907e82a33..2ba75637ec3 100644
--- a/hw/display/qxl.c
+++ b/hw/display/qxl.c
@@ -2384,7 +2384,7 @@ static bool
1 - 100 of 169 matches
Mail list logo
