[PATCH] linux-user: allow NULL msg in recvfrom

2021-03-25 Thread Zach Reizner
The kernel allows a NULL msg in recvfrom so that he size of the next message may be queried before allocating a correctly sized buffer. This change allows the syscall translator to pass along the NULL msg pointer instead of returning early with EFAULT. Signed-off-by: Zach Reizner ---

[PATCH 1/6] qdev: introduce qapi/hmp command for kick/call event

2021-03-25 Thread Dongli Zhang
The virtio device/driver (e.g., vhost-scsi or vhost-net) may hang due to the loss of doorbell kick, e.g., https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg01711.html ... or due to the loss of IRQ, e.g., as fixed by linux kernel commit fe200ae48ef5 ("genirq: Mark polled irqs and defer the

[PATCH 5/6] vhost-scsi-pci: implement device event interface for kick/call

2021-03-25 Thread Dongli Zhang
This is to implement the device event interface for vhost-scsi-pci. Signed-off-by: Dongli Zhang --- hw/scsi/vhost-scsi.c | 6 ++ hw/virtio/vhost-scsi-pci.c | 10 ++ include/hw/virtio/vhost-scsi.h | 3 +++ 3 files changed, 19 insertions(+) diff --git

[PATCH 3/6] virtio-blk-pci: implement device event interface for kick/call

2021-03-25 Thread Dongli Zhang
This is to implement the device event interface for virtio-blk-pci. Signed-off-by: Dongli Zhang --- hw/block/virtio-blk.c | 9 + hw/virtio/virtio-blk-pci.c | 10 ++ include/hw/virtio/virtio-blk.h | 2 ++ 3 files changed, 21 insertions(+) diff --git

[PATCH 4/6] virtio-scsi-pci: implement device event interface for kick/call

2021-03-25 Thread Dongli Zhang
This is to implement the device event interface for virtio-scsi-pci. Signed-off-by: Dongli Zhang --- hw/scsi/virtio-scsi.c | 9 + hw/virtio/virtio-scsi-pci.c | 10 ++ include/hw/virtio/virtio-scsi.h | 3 +++ 3 files changed, 22 insertions(+) diff --git

[PATCH 6/6] virtio-net-pci: implement device event interface for kick/call

2021-03-25 Thread Dongli Zhang
This is to implement the device event interface for virtio-net-pci. Signed-off-by: Dongli Zhang --- hw/net/virtio-net.c| 9 + hw/virtio/virtio-net-pci.c | 10 ++ include/hw/virtio/virtio-net.h | 3 +++ 3 files changed, 22 insertions(+) diff --git

[PATCH 2/6] virtio: introduce helper function for kick/call device event

2021-03-25 Thread Dongli Zhang
This is to introduce the helper function for virtio device to kick or call. Signed-off-by: Dongli Zhang --- hw/virtio/virtio.c | 64 ++ include/hw/virtio/virtio.h | 3 ++ 2 files changed, 67 insertions(+) diff --git a/hw/virtio/virtio.c

[PATCH 0/6] Add debug interface to kick/call on purpose

2021-03-25 Thread Dongli Zhang
The virtio device/driver (e.g., vhost-scsi or vhost-net) may hang due to the loss of doorbell kick, e.g., https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg01711.html ... or due to the loss of IRQ, e.g., as fixed by linux kernel commit fe200ae48ef5 ("genirq: Mark polled irqs and defer the

Re: [PATCH v4 05/19] qapi/expr.py: constrain incoming expression types

2021-03-25 Thread Markus Armbruster
John Snow writes: > On 3/25/21 10:04 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> mypy does not know the types of values stored in Dicts that masquerade >>> as objects. Help the type checker out by constraining the type. >>> >>> Signed-off-by: John Snow >>> --- >>>

Re: [PATCH 10/28] qapi: Rework name checking in preparation of stricter checking

2021-03-25 Thread Markus Armbruster
John Snow writes: > On 3/25/21 2:18 AM, Markus Armbruster wrote: [...] >> Apropos qapi-gen testing scripts. I have scripts to show me how the >> generated code changes along the way in a branch. They evolved over a >> long time, and try to cope with changes in the tree that are hardly >>

[Bug 1921444] Re: Q35 doesn't support to hot add the 2nd PCIe device to KVM guest

2021-03-25 Thread xudong
Alex, thanks for you response. I tried to create guest with multiple root ports, but qemu report error: # qemu-system-x86_64 --accel kvm -m 4096 -smp 4 -drive file=/home/hao/rhel8.2.qcow2,if=none,id=virtio-disk0 -device virtio-blk-pci,drive=virtio-disk0 -device

[Bug 1921444] Re: Q35 doesn't support to hot add the 2nd PCIe device to KVM guest

2021-03-25 Thread Alex Williamson
You need a root port per device you want to hotplug, you cannot independently hotplug multiple devices to a PCIe link. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1921444 Title: Q35 doesn't

RE: [PATCH V4 2/7] qapi/net.json: Add L4_Connection definition

2021-03-25 Thread Zhang, Chen
> -Original Message- > From: Markus Armbruster > Sent: Wednesday, March 24, 2021 2:47 PM > To: Dr. David Alan Gilbert > Cc: Lukas Straub ; Li Zhijian > ; Jason Wang ; qemu- > dev ; Zhang, Chen ; > Zhang Chen > Subject: Re: [PATCH V4 2/7] qapi/net.json: Add L4_Connection definition >

[Bug 1921444] Re: Q35 doesn't support to hot add the 2nd PCIe device to KVM guest

2021-03-25 Thread xudong
** Attachment added: "guest_dmesg.log" https://bugs.launchpad.net/qemu/+bug/1921444/+attachment/5481022/+files/guest_dmesg.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1921444 Title: Q35

[Bug 1921444] [NEW] Q35 doesn't support to hot add the 2nd PCIe device to KVM guest

2021-03-25 Thread xudong
Public bug reported: KVM: https://git.kernel.org/pub/scm/virt/kvm/kvm.git branch: next, commit: 4a98623d Qemu: https://git.qemu.org/git/qemu.git branch: master, commit: 9e2e9fe3 Created a KVM guest with Q35 chipset, and try to hot add 2 PCIe device to guest with qemu internal command

Re: [PATCH v3 6/7] hw/arm/smmuv3: Fix SMMU_CMD_CFGI_STE_RANGE handling

2021-03-25 Thread Zenghui Yu
On 2021/3/25 23:09, Auger Eric wrote: Hi Zenghui, On 3/25/21 3:18 PM, Zenghui Yu wrote: which seems to be some bits that we had never taken into account. And what I'm saying is roughly something like below (compile tested), any thoughts? [...] Thanks for spotting this discrepancy with the

Re: Bug with Windows tap network when running qemu-system-ppc with Mac OS 9 guest

2021-03-25 Thread Bin Meng
Hi Howard, On Fri, Mar 26, 2021 at 1:35 AM Peter Maydell wrote: > > (adding the relevant people to the cc list) > > On Thu, 25 Mar 2021 at 17:26, Howard Spoelstra wrote: > > > > Hi, > > > > When running qemu-system-ppc with Mac OS guest, the guest crashes when > > using a tap network

Re: [PATCH v3] i386/cpu_dump: support AVX512 ZMM regs dump

2021-03-25 Thread Robert Hoo
On Thu, 2021-03-25 at 06:39 -0600, Richard Henderson wrote: > On 3/24/21 9:15 PM, Robert Hoo wrote: > > > > +} else if (env->xcr0 & XFEATURE_AVX) { > > > > > > This is normally a 2-bit test. > > > > I beg your pardon. What 2 bits? > > I forget the names, but isn't the usual test xcr0 &

RE: [PATCH v4 09/10] Add the function of colo_bitmap_clear_diry.

2021-03-25 Thread Rao, Lei
-Original Message- From: Dr. David Alan Gilbert Sent: Friday, March 26, 2021 2:08 AM To: Rao, Lei Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com; jasow...@redhat.com; quint...@redhat.com; pbonz...@redhat.com; lukasstra...@web.de; qemu-devel@nongnu.org Subject: Re: [PATCH v4 09/10] Add

Re: Ways to deal with broken machine types

2021-03-25 Thread Igor Mammedov
On Tue, 23 Mar 2021 17:40:36 + Daniel P. Berrangé wrote: > On Tue, Mar 23, 2021 at 05:54:47PM +0100, Igor Mammedov wrote: > > Let me hijack this thread for beyond this case scope. > > > > I agree that for this particular bug we've done all we could, but > > there is broader issue to discuss

Re: [PATCH v4 00/19] qapi: static typing conversion, pt3

2021-03-25 Thread John Snow
On 3/25/21 2:03 AM, John Snow wrote: Hi, this series adds static types to the QAPI module. This is part three, and it focuses on expr.py. Environment: - Python >= 3.6, <= 3.8 * - mypy >= 0.770 - pylint >= 2.6.0 - flake8 - isort Every commit should pass with (from ./scripts/): - flake8 qapi/

[PATCH-for-6.1 06/10] hw/block/pflash_cfi02: Remove pflash_setup_mappings()

2021-03-25 Thread Philippe Mathieu-Daudé
All boards calling pflash_cfi02_register() use nb_mappings=1, which does not do any mapping: $ git grep -wl pflash_cfi02_register hw/ hw/arm/xilinx_zynq.c hw/block/pflash_cfi02.c hw/lm32/lm32_boards.c hw/ppc/ppc405_boards.c hw/sh4/r2d.c We can remove this now unneeded code.

[RFC PATCH-for-6.1 10/10] hw/m68k/q800: Map MacIO using memory_region_add_subregion_aliased()

2021-03-25 Thread Philippe Mathieu-Daudé
Currently the memory and flatview tree is huge, not very practical: $ (echo info mtree -f;echo q) \ | qemu-system-m68k -M q800 -S -monitor stdio \ | wc -l 2073 Use the memory_region_add_subregion_aliased() helper to manage the MacIO aliases under the hood. - before: (qemu) info

[RFC PATCH-for-6.1 05/10] hw/arm/digic: Map flash using memory_region_add_subregion_aliased()

2021-03-25 Thread Philippe Mathieu-Daudé
Instead of using a device specific feature for mapping the flash memory multiple times over a wider region, use the generic memory_region_add_subregion_aliased() helper. There is no change in the memory layout. * before: $ qemu-system-arm -M canon-a1100 -S -monitor stdio QEMU 5.2.90 monitor

[RFC PATCH-for-6.1 08/10] hw/misc/aliased_region: Simplify aliased I/O regions

2021-03-25 Thread Philippe Mathieu-Daudé
Currently a small I/O region aliased on a wide container creates many aliases. For example, a 8 bytes regions in a 4KiB container creates 512 aliases! As I/O goes via the slow path, we can optimize by using an I/O region which dispatch via an address space view of the aliased region.

[PATCH-for-6.1 04/10] hw/arm/digic: Open-code pflash_cfi02_register() call

2021-03-25 Thread Philippe Mathieu-Daudé
To be able to manually map the flash region on the main memory (in the next commit), first expand the pflash_cfi02_register in place. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/digic_boards.c | 27 +-- 1 file changed, 21 insertions(+), 6 deletions(-) diff --git

[PATCH-for-6.1 09/10] hw/m68k/q800: Add MacIO container

2021-03-25 Thread Philippe Mathieu-Daudé
Instead of having devices mapped onto some main memory range, then having many aliases pointing to this memory range, add a container, map the devices onto it, and map aliases of the container onto the main memory. We gain a better visibility of the devices on the mac-io bus. - before: (qemu)

[PATCH-for-6.1 07/10] hw/block/pflash_cfi02: Simplify pflash_cfi02_register() prototype

2021-03-25 Thread Philippe Mathieu-Daudé
The previous commit removed the mapping code from TYPE_PFLASH_CFI02. pflash_cfi02_register() doesn't use the 'nb_mappings' argument anymore. Simply remove it to simplify. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/block/flash.h | 1 - hw/arm/digic_boards.c| 1 - hw/arm/musicpal.c

[PATCH-for-6.1 02/10] hw/arm/musicpal: Open-code pflash_cfi02_register() call

2021-03-25 Thread Philippe Mathieu-Daudé
To be able to manually map the flash region on the main memory (in the next commit), first expand the pflash_cfi02_register in place. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/musicpal.c | 27 +-- 1 file changed, 21 insertions(+), 6 deletions(-) diff --git

[RFC PATCH-for-6.1 01/10] hw/misc: Add device to help managing aliased memory regions

2021-03-25 Thread Philippe Mathieu-Daudé
// TODO explain here how buses work? when some address lines are // not bound we get memory aliasing, high addresses are masked. // etc... Add a helper to manage this use case easily. For example a having @span_size = @region_size / 4 we get such mapping: ^---^ |

[RFC PATCH-for-6.1 03/10] hw/arm/musicpal: Map flash using memory_region_add_subregion_aliased()

2021-03-25 Thread Philippe Mathieu-Daudé
Instead of using a device specific feature for mapping the flash memory multiple times over a wider region, use the generic memory_region_add_subregion_aliased() helper. There is no change in the memory layout. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/musicpal.c | 11 +++

[RFC PATCH-for-6.1 00/10] hw/misc: Add memory_region_add_subregion_aliased() helper

2021-03-25 Thread Philippe Mathieu-Daudé
Hi, This series introduce the memory_region_add_subregion_aliased() helper which basically create a device which maps a subregion multiple times. Examples are easier, so having a subregion aliased every @span_size then mapped onto a container at an offset, you get something like:

Re: [PATCH V4] file-posix: allow -EBUSY error during ioctl(fd, BLKZEROOUT, range) on block

2021-03-25 Thread ChangLimin
>On Thu, Mar 25, 2021 at 8:07 AM ChangLimin wrote: >>On Wed, Mar 24, 2021 at 4:52 PM Max Reitz wrote: >>On 22.03.21 10:25, ChangLimin wrote: >>> For Linux 5.10/5.11, qemu write zeros to a multipath device using >>> ioctl(fd, BLKZEROOUT, range) with cache none or directsync return -EBUSY >>>

Re: [PATCH] i386/acpi: restore device paths for pre-5.1 vms

2021-03-25 Thread Igor Mammedov
On Tue, 23 Mar 2021 15:32:23 -0400 "Michael S. Tsirkin" wrote: > On Tue, Mar 23, 2021 at 04:04:11PM +0100, Thomas Lamprecht wrote: > > On 23.03.21 15:55, Vitaly Cheptsov wrote: > > >> 23 марта 2021 г., в 17:48, Michael S. Tsirkin > > >> написал(а): > > >> > > >> The issue is with people who

Re: [PATCH v4 13/19] qapi/expr.py: Consolidate check_if_str calls in check_if

2021-03-25 Thread John Snow
On 3/25/21 11:15 AM, Markus Armbruster wrote: John Snow writes: This is a small rewrite to address some minor style nits. Don't compare against the empty list to check for the empty condition, and move the normalization forward to unify the check on the now-normalized structure. With the

Re: [PATCH v4 11/19] qapi/expr.py: Modify check_keys to accept any Collection

2021-03-25 Thread John Snow
On 3/25/21 10:45 AM, Markus Armbruster wrote: John Snow writes: This is a minor adjustment that allows the 'required' and 'optional' keys fields to take a default value of an empty, immutable sequence (the empty tuple). This reveals a quirk of this function, which is that "a + b" is

Re: [PATCH v4 10/19] qapi/expr.py: Add casts in a few select cases

2021-03-25 Thread John Snow
On 3/25/21 10:33 AM, Markus Armbruster wrote: John Snow writes: Casts are instructions to the type checker only, they aren't "safe" and should probably be avoided in general. In this case, when we perform type checking on a nested structure, the type of each field does not "stick". (See PEP

Re: [PATCH v3 1/4] tests: Add tests for yank with the chardev-change case

2021-03-25 Thread Lukas Straub
On Fri, 26 Mar 2021 00:36:45 +0400 Marc-André Lureau wrote: > Hi > > On Tue, Mar 23, 2021 at 9:57 PM Lukas Straub wrote: > > > Add tests for yank with the chardev-change case. > > > > Signed-off-by: Lukas Straub > > --- > > MAINTAINERS| 1 + > > tests/unit/meson.build | 3 +-

Re: [Qemu-devel] [PULL v5 39/43] hw/hppa: Implement DINO system board

2021-03-25 Thread Philippe Mathieu-Daudé
Hi Helge, Richard, On Tue, Jan 30, 2018 at 5:48 AM Richard Henderson wrote: > > From: Helge Deller > > Now that we have the prerequisites in target/hppa/, > implement the hardware for a PA7100LC. > > This also enables build for hppa-softmmu. > > Signed-off-by: Helge Deller > [rth: Since it is

Re: [PATCH for-6.0 4/4] hw/ppc/e500plat: Only try to add valid dynamic sysbus devices to platform bus

2021-03-25 Thread David Gibson
On Thu, Mar 25, 2021 at 03:33:10PM +, Peter Maydell wrote: > The e500plat machine device plug callback currently calls > platform_bus_link_device() for any sysbus device. This is overly > broad, because platform_bus_link_device() will unconditionally grab > the IRQs and MMIOs of the device it

Re: [PATCH v5 10/10] target/ppc: Validate hflags with CONFIG_DEBUG_TCG

2021-03-25 Thread David Gibson
On Wed, Mar 24, 2021 at 11:12:20AM +1100, David Gibson wrote: > On Tue, Mar 23, 2021 at 12:43:40PM -0600, Richard Henderson wrote: > > Verify that hflags was updated correctly whenever we change > > cpu state that is used by hflags. > > > > Signed-off-by: Richard Henderson > > Applied to

Re: [RFC v11 47/55] target/arm: make is_aa64 and arm_el_is_aa64 a macro for !TARGET_AARCH64

2021-03-25 Thread Claudio Fontana
On 3/25/21 8:03 PM, Richard Henderson wrote: > On 3/23/21 9:46 AM, Claudio Fontana wrote: >> +#define is_a64(env) (false) > ... >> +#define arm_el_is_aa64(env, el) (false) > > Why a define and not have the ifdef inside the static inline? > > This define is causing you to make other random

Re: [RFC v11 22/55] target/arm: move sve_zcr_len_for_el to common_cpu

2021-03-25 Thread Claudio Fontana
On 3/24/21 11:03 PM, Richard Henderson wrote: > On 3/23/21 9:46 AM, Claudio Fontana wrote: >> it is required by arch-dump.c and cpu.c, so apparently >> we need this for KVM too >> >> Signed-off-by: Claudio Fontana > > > Reviewed-by: Richard Henderson > > >> +/* >> + * these are AARCH64-only,

Re: [PATCH v4 09/19] qapi/expr.py: Check type of 'data' member

2021-03-25 Thread John Snow
On 3/25/21 10:26 AM, Markus Armbruster wrote: Suggest qapi/expr.py: Check type of union and alternate 'data' member John Snow writes: We don't actually check, so the user can get some unpleasant stacktraces. Let's point to the new tests here. Well, it'll get merged with the last

Re: [RFC 0/8] virtio: Improve boot time of virtio-scsi-pci and virtio-blk-pci

2021-03-25 Thread Greg Kurz
On Thu, 25 Mar 2021 17:43:10 + Stefan Hajnoczi wrote: > On Thu, Mar 25, 2021 at 01:05:16PM -0400, Michael S. Tsirkin wrote: > > On Thu, Mar 25, 2021 at 04:07:27PM +0100, Greg Kurz wrote: > > > Now that virtio-scsi-pci and virtio-blk-pci map 1 virtqueue per vCPU, > > > a serious slow down may

Re: [PATCH for-6.0 0/4] Don't treat all sysbus devices as hotpluggable

2021-03-25 Thread Mark Cave-Ayland
On 25/03/2021 15:33, Peter Maydell wrote: On the two machines which have the "platform bus" (ppc e500 and arm virt) we currently treat all TYPE_SYS_BUS_DEVICE devices as being hotpluggable in the device callbacks, and try to plug those devices into the platform bus. This is far too broad,

Re: [PATCH v4 05/19] qapi/expr.py: constrain incoming expression types

2021-03-25 Thread John Snow
On 3/25/21 10:04 AM, Markus Armbruster wrote: John Snow writes: mypy does not know the types of values stored in Dicts that masquerade as objects. Help the type checker out by constraining the type. Signed-off-by: John Snow --- scripts/qapi/expr.py | 26 +++--- 1 file

Re: Fail to create sev-guest object on 6.0.0-rc0

2021-03-25 Thread Tom Lendacky
On 3/25/21 1:51 PM, Brijesh Singh wrote: > Hi All, > > It seems creating the sev-guest object is broken rc0 tag. The following > command is no longer able to create the sev-guest object > > $QEMU \ > >  -machine ...,confidential-guest-support=sev0 \ > >  -object sev-guest,id=sev0,policy=0x1 \

Re: [PATCH v3 1/4] tests: Add tests for yank with the chardev-change case

2021-03-25 Thread Marc-André Lureau
Hi On Tue, Mar 23, 2021 at 9:57 PM Lukas Straub wrote: > Add tests for yank with the chardev-change case. > > Signed-off-by: Lukas Straub > --- > MAINTAINERS| 1 + > tests/unit/meson.build | 3 +- > tests/unit/test-yank.c | 201 + > 3

Re: [PATCH 2/2] yank: Always link full yank code

2021-03-25 Thread Marc-André Lureau
On Tue, Mar 23, 2021 at 9:57 PM Lukas Straub wrote: > Yank now only depends on util and can be always linked in. Also remove > the stubs as they are not needed anymore. > > Signed-off-by: Lukas Straub > Reviewed-by: Marc-André Lureau --- > MAINTAINERS | 1 - > stubs/meson.build | 1

Re: [PATCH 1/2] yank: Remove dependency on qiochannel

2021-03-25 Thread Marc-André Lureau
On Tue, Mar 23, 2021 at 9:54 PM Lukas Straub wrote: > Remove dependency on qiochannel by removing yank_generic_iochannel and > letting migration and chardev use their own yank function for > iochannel. > > Signed-off-by: Lukas Straub > Reviewed-by: Marc-André Lureau --- > MAINTAINERS

Re: [PATCH V3] target/riscv: Align the data type of reset vector address

2021-03-25 Thread Alistair Francis
On Thu, Mar 25, 2021 at 5:43 AM Dylan Jhong wrote: > > Signed-off-by: Dylan Jhong > Signed-off-by: Ruinland ChuanTzu Tsai > --- > target/riscv/cpu.c | 6 +- > target/riscv/cpu.h | 2 +- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/target/riscv/cpu.c

Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings

2021-03-25 Thread John Snow
On 3/25/21 11:21 AM, Markus Armbruster wrote: John Snow writes: PEP8's BDFL writes: "For flowing long blocks of text with fewer structural restrictions (docstrings or comments), the line length should be limited to 72 characters." I do not like this patch. I have included it explicitly to

Re: [PATCH v5] sphinx: adopt kernel readthedoc theme

2021-03-25 Thread Marc-André Lureau
On Tue, Mar 23, 2021 at 3:54 PM wrote: > From: Marc-André Lureau > > The default "alabaster" sphinx theme has a couple shortcomings: > - the navbar moves along the page > - the search bar is not always at the same place > - it lacks some contrast and colours > > The "rtd" theme from

Re: [PATCH v4 01/19] qapi/expr: Comment cleanup

2021-03-25 Thread John Snow
On 3/25/21 11:41 AM, Markus Armbruster wrote: John Snow writes: Fixes: 0825f62c842 For a slightly peculiar value of "fixes" ;) Less of this, please.

Re: [PATCH v5] sphinx: adopt kernel readthedoc theme

2021-03-25 Thread Marc-André Lureau
Hi Thomas On Tue, Mar 23, 2021 at 4:34 PM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi > > On Tue, Mar 23, 2021 at 4:27 PM Thomas Lamprecht > wrote: > >> On 23.03.21 12:53, marcandre.lur...@redhat.com wrote: >> > From: Marc-André Lureau >> > >> >> Just saw this patch by accident

Re: [PATCH v3] linux-user/s390x: Use the guest pointer for the sigreturn stub

2021-03-25 Thread Laurent Vivier
Le 24/03/2021 à 19:51, Andreas Krebbel a écrit : > When setting up the pointer for the sigreturn stub in the return > address register (r14) we currently use the host frame address instead > of the guest frame address. > > Note: This only caused problems if Qemu has been built with >

Re: [PATCH v1 0/8] GICv3 LPI and ITS feature implementation

2021-03-25 Thread Alex Bennée
Shashi Mallela writes: > This patchset implements qemu device model for enabling physical > LPI support and ITS functionality in GIC as per GICv3 specification. > Both flat table and 2 level tables are implemented.The ITS commands > for adding/deleting ITS table entries,trigerring LPI

Re: [PATCH v2 00/10] Acceptance Test: introduce base class for Linux based tests

2021-03-25 Thread Wainer dos Santos Moschetta
Hi, On 3/23/21 7:15 PM, Cleber Rosa wrote: This introduces a base class for tests that need to interact with a Linux guest. It generalizes the "boot_linux.py" code, already been used by the "virtiofs_submounts.py" and also SSH related code being used by that and "linux_ssh_mips_malta.py". I

Re: [PATCH v3 04/16] qapi/expr.py: Add assertion for union type 'check_dict'

2021-03-25 Thread John Snow
On 3/25/21 1:46 AM, Markus Armbruster wrote: John Snow writes: On 2/24/21 5:35 AM, Markus Armbruster wrote: John Snow writes: mypy isn't fond of allowing you to check for bool membership in a collection of str elements. Guard this lookup for precisely when we were given a name.

Re: [PATCH v1 2/8] hw/intc: GICv3 ITS register definitions added

2021-03-25 Thread Alex Bennée
Shashi Mallela writes: > Defined descriptors for ITS device table,collection table and ITS > command queue entities.Implemented register read/write functions, > extract ITS table parameters and command queue parameters,extended > gicv3 common to capture qemu address space(which host the ITS

Re: [RFC PATCH v2 4/5] Add migration support for KVM guest with MTE

2021-03-25 Thread Dr. David Alan Gilbert
* Haibo Xu (haibo...@linaro.org) wrote: > On Thu, 18 Mar 2021 at 04:11, Dr. David Alan Gilbert > wrote: > > > > * Haibo Xu (haibo...@linaro.org) wrote: > > > To make it easier to keep the page tags sync with > > > the page data, tags for one page are appended to > > > the data during ram save

Re: [PATCH v4 for-6.0? 0/3] qcow2: fix parallel rewrite and discard (rw-lock)

2021-03-25 Thread Vladimir Sementsov-Ogievskiy
ping. Do we want it for 6.0? 19.03.2021 13:08, Vladimir Sementsov-Ogievskiy wrote: Look at 03 for the problem and fix. 01 is preparation and 02 is the test. Actually previous version of this thing is [PATCH v2(RFC) 0/3] qcow2: fix parallel rewrite and discard Still [PATCH v3 0/6]

Fail to create sev-guest object on 6.0.0-rc0

2021-03-25 Thread Brijesh Singh
Hi All, It seems creating the sev-guest object is broken rc0 tag. The following command is no longer able to create the sev-guest object $QEMU \  -machine ...,confidential-guest-support=sev0 \  -object sev-guest,id=sev0,policy=0x1 \ It fails with "-object sev-guest,id=sev0: Invalid parameter

Re: [RFC v11 48/55] target/arm: arch_dump: restrict ELFCLASS64 to AArch64

2021-03-25 Thread Richard Henderson
On 3/23/21 9:46 AM, Claudio Fontana wrote: this will allow us to restrict more code to TARGET_AARCH64 Signed-off-by: Claudio Fontana --- target/arm/helper-a64.h | 2 ++ target/arm/helper.h | 1 - target/arm/arch_dump.c | 12 +++- target/arm/cpu.c| 1 -

Re: [RFC v11 47/55] target/arm: make is_aa64 and arm_el_is_aa64 a macro for !TARGET_AARCH64

2021-03-25 Thread Richard Henderson
On 3/23/21 9:46 AM, Claudio Fontana wrote: +#define is_a64(env) (false) ... +#define arm_el_is_aa64(env, el) (false) Why a define and not have the ifdef inside the static inline? This define is causing you to make other random changes to avoid unused variables, and I'm not keen. If

Re: [PATCH v4 14/14] hmp: Print "reserve" property of memory backends with "info memdev"

2021-03-25 Thread Dr. David Alan Gilbert
* David Hildenbrand (da...@redhat.com) wrote: > Let's print the new property. > > Cc: Markus Armbruster > Cc: Eric Blake > Signed-off-by: David Hildenbrand Reviewed-by: Dr. David Alan Gilbert > --- > hw/core/machine-hmp-cmds.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [PATCH] MAINTAINERS: add/replace backups for some s390 areas

2021-03-25 Thread Jason J. Herne
On 3/25/21 9:55 AM, Matthew Rosato wrote: S390 PCI currently has no backup, add one. Add an additional backup for vfio-ccw and refresh the backup for vfio-ap. Signed-off-by: Matthew Rosato --- MAINTAINERS | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS

Re: [RFC v11 28/55] target/arm: refactor exception and cpu code

2021-03-25 Thread Claudio Fontana
On 3/25/21 7:43 PM, Richard Henderson wrote: > On 3/25/21 5:59 AM, Claudio Fontana wrote: >>> Isn't tcg/tcg-* redundant? >> >> I considered that, and at some point I had "cpu.c" for x86 too. After >> working on it for a while, I noticed how >> it got really confusing in practice to have files

Re: [RFC v11 45/55] target/arm: cpu-sve: new module

2021-03-25 Thread Claudio Fontana
On 3/25/21 7:40 PM, Richard Henderson wrote: > On 3/23/21 9:46 AM, Claudio Fontana wrote: >> extract the SVE-related cpu object properties and functions, >> and move them to a separate module. >> >> Disentangle SVE from pauth that is a separate, TCG-only feature. >> >> Signed-off-by: Claudio

Re: [RFC v11 46/55] target/arm: cpu-sve: split TCG and KVM functionality

2021-03-25 Thread Richard Henderson
On 3/23/21 9:46 AM, Claudio Fontana wrote: /* called by arm_cpu_finalize_features in realizefn */ -void cpu_sve_finalize_features(ARMCPU *cpu, Error **errp); +bool cpu_sve_finalize_features(ARMCPU *cpu, Error **errp); No interface changes simultaneous with code movement. r~

Re: [RFC v11 28/55] target/arm: refactor exception and cpu code

2021-03-25 Thread Richard Henderson
On 3/25/21 5:59 AM, Claudio Fontana wrote: Isn't tcg/tcg-* redundant? I considered that, and at some point I had "cpu.c" for x86 too. After working on it for a while, I noticed how it got really confusing in practice to have files called just "cpu.c" when working on them, just too many files

Re: [PATCH v3] hw/isa/piix4: Migrate Reset Control Register

2021-03-25 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (f4...@amsat.org) wrote: > When adding the Reset register in commit 5790b757cfb we > forgot to migrate it. > > While it is possible a VM using the PIIX4 is migrated just > after requesting a system shutdown, it is very unlikely. > However when restoring a migrated VM, we

Re: [RFC v11 45/55] target/arm: cpu-sve: new module

2021-03-25 Thread Richard Henderson
On 3/23/21 9:46 AM, Claudio Fontana wrote: extract the SVE-related cpu object properties and functions, and move them to a separate module. Disentangle SVE from pauth that is a separate, TCG-only feature. Signed-off-by: Claudio Fontana --- target/arm/cpu-sve.h | 40 +

Re: [PATCH for-6.0 0/2] document gdbstub debugging of multicore machines

2021-03-25 Thread Philippe Mathieu-Daudé
On 3/25/21 6:50 PM, Peter Maydell wrote: > Peter Maydell (2): > docs/system/gdb.rst: Add some more heading structure > docs/system/gdb.rst: Document how to debug multicore machines > > docs/system/gdb.rst | 63 - > 1 file changed, 62

Re: [PATCH v2 09/10] Acceptance Tests: add basic documentation on LinuxTest base class

2021-03-25 Thread Wainer dos Santos Moschetta
Hi, On 3/23/21 7:15 PM, Cleber Rosa wrote: Signed-off-by: Cleber Rosa Reviewed-by: Marc-André Lureau Reviewed-by: Willian Rampazzo --- docs/devel/testing.rst | 25 + 1 file changed, 25 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst

Re: [PATCH v2 0/5] qemu-iotests: quality of life improvements

2021-03-25 Thread Max Reitz
On 23.03.21 19:19, Paolo Bonzini wrote: This series adds a few usability improvements to qemu-iotests, in particular: - arguments can be passed to Python unittests scripts, for example to run only a subset of the test cases (patches 1-2) - it is possible to do "./check --

Re: [PATCH v2 for-6.0?] hw/pci-host/gpex: Don't fault for unmapped parts of MMIO and PIO windows

2021-03-25 Thread Philippe Mathieu-Daudé
Hi Peter, On 3/25/21 5:33 PM, Peter Maydell wrote: > Currently the gpex PCI controller implements no special behaviour for > guest accesses to areas of the PIO and MMIO where it has not mapped > any PCI devices, which means that for Arm you end up with a CPU > exception due to a data abort. > >

Re: [PATCH v4 09/10] Add the function of colo_bitmap_clear_diry.

2021-03-25 Thread Dr. David Alan Gilbert
* leirao (lei@intel.com) wrote: > From: "Rao, Lei" > > When we use continuous dirty memory copy for flushing ram cache on > secondary VM, we can also clean up the bitmap of contiguous dirty > page memory. This also can reduce the VM stop time during checkpoint. > > Signed-off-by: Lei Rao >

Re: [PATCH v2 03/10] Python: add utility function for retrieving port redirection

2021-03-25 Thread John Snow
On 3/23/21 6:15 PM, Cleber Rosa wrote: Slightly different versions for the same utility code are currently present on different locations. This unifies them all, giving preference to the version from virtiofs_submounts.py, because of the last tweaks added to it. While at it, this adds a

[Bug 1921092] Re: gdbstub debug of multi-cluster machines is undocumented and confusing

2021-03-25 Thread Martin Schönstedt
qemu-system-arm -cpu cortex-m33 -machine mps2-an521 -nographic -m 16 -vga none -net none -chardev stdio,id=con,mux=on -serial chardev:con -mon chardev=con,mode=readline -icount shift=7,align=off,sleep=off -rtc clock=vm -device loader,file=/zephyr.elf -s -S -kernel /zephyr.elf i've included both

Re: [RFC 0/8] virtio: Improve boot time of virtio-scsi-pci and virtio-blk-pci

2021-03-25 Thread Greg Kurz
On Thu, 25 Mar 2021 13:05:16 -0400 "Michael S. Tsirkin" wrote: > On Thu, Mar 25, 2021 at 04:07:27PM +0100, Greg Kurz wrote: > > Now that virtio-scsi-pci and virtio-blk-pci map 1 virtqueue per vCPU, > > a serious slow down may be observed on setups with a big enough number > > of vCPUs. > > > >

Re: [PATCH v1 0/8] GICv3 LPI and ITS feature implementation

2021-03-25 Thread Alex Bennée
Shashi Mallela writes: > This patchset implements qemu device model for enabling physical > LPI support and ITS functionality in GIC as per GICv3 specification. > Both flat table and 2 level tables are implemented.The ITS commands > for adding/deleting ITS table entries,trigerring LPI

Re: [PATCH v2 05/10] Acceptance Tests: add port redirection for ssh by default

2021-03-25 Thread Wainer dos Santos Moschetta
Hi, On 3/24/21 6:10 AM, Auger Eric wrote: Hi Cleber, On 3/23/21 11:15 PM, Cleber Rosa wrote: For users of the LinuxTest class, let's set up the VM with the port redirection for SSH, instead of requiring each test to set the same also sets the network device to virtio-net. This may be worth

[PATCH for-6.0 0/2] document gdbstub debugging of multicore machines

2021-03-25 Thread Peter Maydell
The way gdb and our gdbstub handle multicore and multicluster machines is not very obvious. This patchset adds some documentation of how to do it. In particular it gives the necessary runes for how to get gdb to work with machines which have multiple clusters of heterogenous CPUs (that's the

[PATCH for-6.0 2/2] docs/system/gdb.rst: Document how to debug multicore machines

2021-03-25 Thread Peter Maydell
Document how multicore machines appear to GDB when debugged via the debug stub. This is particularly non-intuitive for the "multiple heterogenous clusters" case, but unfortunately as far as I know there is no way with the remote protocol for the stub to tell gdb "I have 2 inferiors, please connect

[PATCH for-6.0 1/2] docs/system/gdb.rst: Add some more heading structure

2021-03-25 Thread Peter Maydell
We're about to add a new section to gdb.rst. In preparation, add some more headings so it isn't just one huge run-on section. Signed-off-by: Peter Maydell --- docs/system/gdb.rst | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/docs/system/gdb.rst b/docs/system/gdb.rst

Re: [PATCH 13/28] qapi: Enforce event naming rules

2021-03-25 Thread John Snow
On 3/25/21 2:22 AM, Markus Armbruster wrote: John Snow writes: On 3/24/21 2:22 AM, Markus Armbruster wrote: John Snow writes: On 3/23/21 5:40 AM, Markus Armbruster wrote: Event names should be ALL_CAPS with words separated by underscore. Enforce this. The only offenders are in tests/.

Re: [PATCH 10/28] qapi: Rework name checking in preparation of stricter checking

2021-03-25 Thread John Snow
On 3/25/21 2:18 AM, Markus Armbruster wrote: John Snow writes: On 3/24/21 1:57 AM, Markus Armbruster wrote: John Snow writes: On 3/23/21 5:40 AM, Markus Armbruster wrote: Naming rules differ for the various kinds of names. To prepare enforcing them, define functions to check them:

Re: [PATCH v2 04/10] Acceptance Tests: move useful ssh methods to base class

2021-03-25 Thread Wainer dos Santos Moschetta
Hi, On 3/25/21 9:50 AM, Auger Eric wrote: Hi Cleber, On 3/24/21 11:23 PM, Cleber Rosa wrote: On Wed, Mar 24, 2021 at 10:07:31AM +0100, Auger Eric wrote: Hi Cleber, On 3/23/21 11:15 PM, Cleber Rosa wrote: Both the virtiofs submounts and the linux ssh mips malta tests contains useful methods

Re: [RFC 0/8] virtio: Improve boot time of virtio-scsi-pci and virtio-blk-pci

2021-03-25 Thread Stefan Hajnoczi
On Thu, Mar 25, 2021 at 01:05:16PM -0400, Michael S. Tsirkin wrote: > On Thu, Mar 25, 2021 at 04:07:27PM +0100, Greg Kurz wrote: > > Now that virtio-scsi-pci and virtio-blk-pci map 1 virtqueue per vCPU, > > a serious slow down may be observed on setups with a big enough number > > of vCPUs. > > >

Re: [PULL 0/2] Block patches

2021-03-25 Thread Stefan Hajnoczi
On Thu, Mar 25, 2021 at 04:36:43PM +, Peter Maydell wrote: > On Thu, 25 Mar 2021 at 16:28, Stefan Hajnoczi wrote: > > > > On Thu, Mar 25, 2021 at 01:17:50PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > Thanks! My path modifies migration/block-dirty-bitmap.c. qsd-jobs runs > > >

RE: [PATCH 11/15] Hexagon (target/hexagon) circular addressing

2021-03-25 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Thursday, March 25, 2021 11:34 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; a...@rev.ng; Brian Cain > Subject: Re: [PATCH 11/15] Hexagon (target/hexagon) circular addressing > > On 3/24/21 8:50 PM,

Re: Bug with Windows tap network when running qemu-system-ppc with Mac OS 9 guest

2021-03-25 Thread Peter Maydell
(adding the relevant people to the cc list) On Thu, 25 Mar 2021 at 17:26, Howard Spoelstra wrote: > > Hi, > > When running qemu-system-ppc with Mac OS guest, the guest crashes when > using a tap network connection. Openvpn 2.4.9-I601-win10 is installed > with TAP-Windows 9.24.2. A tap connection

Re: [PATCH for-6.0 0/4] Don't treat all sysbus devices as hotpluggable

2021-03-25 Thread Richard Henderson
On 3/25/21 9:33 AM, Peter Maydell wrote: On the two machines which have the "platform bus" (ppc e500 and arm virt) we currently treat all TYPE_SYS_BUS_DEVICE devices as being hotpluggable in the device callbacks, and try to plug those devices into the platform bus. This is far too broad,

Bug with Windows tap network when running qemu-system-ppc with Mac OS 9 guest

2021-03-25 Thread Howard Spoelstra
Hi, When running qemu-system-ppc with Mac OS guest, the guest crashes when using a tap network connection. Openvpn 2.4.9-I601-win10 is installed with TAP-Windows 9.24.2. A tap connection called TapQemu is bridged with the default ethernet connection. It gets activated when I start qemu. To

Re: [PATCH v1 1/8] hw/intc: GICv3 ITS initial framework

2021-03-25 Thread Alex Bennée
Shashi Mallela writes: > Added register definitions relevant to ITS,implemented overall > ITS device framework with stubs for ITS control and translater > regions read/write,extended ITS common to handle mmio init between > existing kvm device and newer qemu device. > > Signed-off-by: Shashi

Re: [PATCH v1 1/8] hw/intc: GICv3 ITS initial framework

2021-03-25 Thread Alex Bennée
Shashi Mallela writes: > Added register definitions relevant to ITS,implemented overall > ITS device framework with stubs for ITS control and translater > regions read/write,extended ITS common to handle mmio init between > existing kvm device and newer qemu device. > > Signed-off-by: Shashi

[PATCH v2] qapi: introduce 'query-cpu-model-cpuid' action

2021-03-25 Thread Valeriy Vdovin
Introducing new qapi method 'query-cpu-model-cpuid'. This method can be used to get virtualized cpu model info generated by QEMU during VM initialization in the form of cpuid representation. Diving into more details about virtual cpu generation: QEMU first parses '-cpu' command line option. From

Re: qemu-system-aarch64 crashes with device ich9-usb-ehci1

2021-03-25 Thread Richard Henderson
On 3/25/21 10:58 AM, Thomas Huth wrote: In case anybody is interested, ich9-usb-ehci1 can be used to crash QEMU: $ ./qemu-system-aarch64 -M virt -device ich9-usb-ehci1,help qemu-system-aarch64: ../../devel/qemu/softmmu/physmem.c:1154: phys_section_add: Assertion `map->sections_nb <

  1   2   3   4   >