socket.c added support for unix domain socket datagram transport

2021-04-22 Thread Ralph Schmieder
Hey... new to this list. I was looking for a way to use Unix domain sockets as a network transport between local VMs. I'm part of a team where we run dozens if not hundreds of VMs on a single compute instance which are highly interconnected. In the current implementation, I use UDP sockets (e

Re: s390-ccw: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]

2021-04-22 Thread Christian Borntraeger
On 23.04.21 08:40, Stefano Garzarella wrote: On Thu, Apr 22, 2021 at 06:54:21PM +0200, Philippe Mathieu-Daudé wrote: On 4/22/21 6:07 PM, Thomas Huth wrote: On 22/04/2021 17.52, Stefano Garzarella wrote: On Thu, Apr 22, 2021 at 05:38:26PM +0200, Thomas Huth wrote: On 22/04/2021 16.31, Phili

Re: [PATCH 0/9] hw/block: m25p80: Fix the mess of dummy bytes needed for fast read commands

2021-04-22 Thread Bin Meng
On Mon, Feb 8, 2021 at 10:41 PM Bin Meng wrote: > > On Thu, Jan 21, 2021 at 10:18 PM Francisco Iglesias > wrote: > > > > Hi Bin, > > > > On [2021 Jan 21] Thu 16:59:51, Bin Meng wrote: > > > Hi Francisco, > > > > > > On Thu, Jan 21, 2021 at 4:50 PM Francisco Iglesias > > > wrote: > > > > > > > >

Re: s390-ccw: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]

2021-04-22 Thread Stefano Garzarella
On Thu, Apr 22, 2021 at 06:54:21PM +0200, Philippe Mathieu-Daudé wrote: On 4/22/21 6:07 PM, Thomas Huth wrote: On 22/04/2021 17.52, Stefano Garzarella wrote: On Thu, Apr 22, 2021 at 05:38:26PM +0200, Thomas Huth wrote: On 22/04/2021 16.31, Philippe Mathieu-Daudé wrote: On 4/22/21 2:41 PM, Chr

Re: [PATCH for 6.0] net: check the existence of peer before trying to pad

2021-04-22 Thread Jason Wang
在 2021/4/23 下午1:42, Stefan Weil 写道: Am 23.04.21 um 05:18 schrieb Jason Wang: There could be case that peer is NULL. This can happen when during network device hot-add where net device needs to be added first. So the patch check the existence of peer before trying to do the pad. Fixes: 969e50

Re: [PATCH RFC 0/1] To add HMP interface to dump PCI MSI-X table/PBA

2021-04-22 Thread Jason Wang
在 2021/4/23 下午12:47, Dongli Zhang 写道: This is inspired by the discussion with Jason on below patchset. https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg09020.html The new HMP command is introduced to dump the MSI-X table and PBA. Initially, I was going to add new option to "info pci"

constant_tsc support for SVM guest

2021-04-22 Thread Wei Huang
There was a customer request for const_tsc support on AMD guests. Right now this feature is turned off by default for QEMU x86 CPU types (in CPUID_Fn8007_EDX[8]). However we are seeing a discrepancy in guest VM behavior between Intel and AMD. In Linux kernel, Intel x86 code enables X86_FEA

Re: [PATCH for 6.0] net: check the existence of peer before trying to pad

2021-04-22 Thread Stefan Weil
Am 23.04.21 um 05:18 schrieb Jason Wang: There could be case that peer is NULL. This can happen when during network device hot-add where net device needs to be added first. So the patch check the existence of peer before trying to do the pad. Fixes: 969e50b61a285 ("net: Pad short frames to mini

[PATCH for-6.0 v2 1/2] hw/block/nvme: fix invalid msix exclusive uninit

2021-04-22 Thread Klaus Jensen
From: Klaus Jensen Commit 1901b4967c3f changed the nvme device from using a bar exclusive for MSI-x to sharing it on bar0. Unfortunately, the msix_uninit_exclusive_bar() call remains in nvme_exit() which causes havoc when the device is removed with, say, device_del. Fix this. Additionally, a su

[PATCH for-6.0 v2 2/2] hw/block/nvme: disable hotplugging for subsystem-linked controllers

2021-04-22 Thread Klaus Jensen
From: Klaus Jensen If a controller is linked to a subsystem, do not allow it to be hotplugged since this will mess up the (possibly shared) namespaces. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/block/nvme.c b/hw/block/nvme.c inde

[PATCH for-6.0 v2 0/2] hw/block/nvme: fix msix uninit

2021-04-22 Thread Klaus Jensen
From: Klaus Jensen First patch fixes a regression where msix is not correctly uninit'ed when an nvme device is hotplugged with device_del. When viewed in conjunction with the commit that introduced the bug (commit 1901b4967c3f), I think the fix looks relatively obvious. Second patch disables hot

[PATCH RFC 1/1] msix: add hmp interface to dump MSI-X info

2021-04-22 Thread Dongli Zhang
This patch is to add the HMP interface to dump MSI-X table and PBA, in order to help diagnose the loss of IRQ issue in VM (e.g., if an MSI-X vector is erroneously masked permanently). Here is the example with vhost-scsi: (qemu) info msix /machine/peripheral/vscsi0 MSI-X Table 0xfee01004 0x

[PATCH RFC 0/1] To add HMP interface to dump PCI MSI-X table/PBA

2021-04-22 Thread Dongli Zhang
This is inspired by the discussion with Jason on below patchset. https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg09020.html The new HMP command is introduced to dump the MSI-X table and PBA. Initially, I was going to add new option to "info pci". However, as the number of entries is not

[Bug 1580459] Re: Windows (10?) guest freezes entire host on shutdown if using PCI passthrough

2021-04-22 Thread Thomas Huth
Ok, thanks for answering! So I'm closing this issue now. In case anybody still has similar issues, please open a new bug ticket instead. ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscr

[Bug 1395217] Re: Networking in qemu 2.0.0 and beyond is not compatible with Open Solaris (Illumos) 5.11

2021-04-22 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1395217 Title: Networking

[Bug 1778966] Re: Windows 1803 and later crashes on KVM

2021-04-22 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1778966 Title: Windows 180

[Bug 1615212] Re: SDL UI switching to monitor half-broken and scrolling broken

2021-04-22 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1615212 Title: SDL UI swit

[Bug 1725707] Re: QEMU sends excess VNC data to websockify even when network is poor

2021-04-22 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1725707 Title: QEMU sends

[Bug 1820247] Re: QEMU random crash caused by libspice-server

2021-04-22 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1820247 Title: QEMU random

[Bug 1879425] Re: The thread of "CPU 0 /KVM" keeping 99.9%CPU

2021-04-22 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1879425 Title: The thread

[Bug 1642421] Re: qemu-system-x86_64: ipv6 and dns is broken with netdev user

2021-04-22 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1642421 Title: qemu-system

Re: [PATCH 1/4] target/ppc: Code motion required to build disabling tcg

2021-04-22 Thread David Gibson
On Thu, Apr 22, 2021 at 04:35:34PM -0300, Fabiano Rosas wrote: > Bruno Piazera Larsen writes: > > >> > You are correct! I've just tweaked the code that defines spr_register and > >> > it should be working now. I'm still working in splitting the SPR > >> > functions > >> > from translate_init, si

Re: [PATCH for 6.0] net: check the existence of peer before trying to pad

2021-04-22 Thread Bin Meng
On Fri, Apr 23, 2021 at 11:18 AM Jason Wang wrote: > > There could be case that peer is NULL. This can happen when during > network device hot-add where net device needs to be added first. So > the patch check the existence of peer before trying to do the pad. > > Fixes: 969e50b61a285 ("net: Pad s

[PATCH for 6.0] net: check the existence of peer before trying to pad

2021-04-22 Thread Jason Wang
There could be case that peer is NULL. This can happen when during network device hot-add where net device needs to be added first. So the patch check the existence of peer before trying to do the pad. Fixes: 969e50b61a285 ("net: Pad short frames to minimum size before sending from SLiRP/TAP") Si

[PATCH RESEND 1/2] target/i386: add "-cpu, lbr-fmt=*" support to enable guest LBR

2021-04-22 Thread Like Xu
The last branch recording (LBR) is a performance monitor unit (PMU) feature on Intel processors that records a running trace of the most recent branches taken by the processor in the LBR stack. The QEMU could configure whether it's enabled or not for each guest via CLI. The LBR feature would be en

[PATCH RESEND 2/2] target/i386: add kvm_exact_match_flags to FeatureWordInfo

2021-04-22 Thread Like Xu
Instead of hardcoding the PERF_CAPABILITIES rules in this loop, this could become a FeatureWordInfo field. It would be very useful for other features like intel-pt, where we need some bits to match the host bits too. Suggested-by: Eduardo Habkost Signed-off-by: Like Xu --- target/i386/cpu.c | 2

Re: [PATCH v2] i386: Add ratelimit for bus locks acquired in guest

2021-04-22 Thread Chenyi Qiang
On 4/21/2021 11:18 PM, Eduardo Habkost wrote: On Wed, Apr 21, 2021 at 10:50:10PM +0800, Xiaoyao Li wrote: On 4/21/2021 10:12 PM, Eduardo Habkost wrote: On Wed, Apr 21, 2021 at 02:26:42PM +0800, Chenyi Qiang wrote: Hi, Eduardo, thanks for your comments! On 4/21/2021 12:34 AM, Eduardo Habko

Re: [PATCH-for-6.0] net: tap: fix crash on hotplug

2021-04-22 Thread Jason Wang
在 2021/4/23 上午5:34, Cole Robinson 写道: On 4/22/21 5:42 AM, Bin Meng wrote: On Thu, Apr 22, 2021 at 5:36 PM Peter Maydell wrote: On Thu, 22 Apr 2021 at 05:29, Bin Meng wrote: On Thu, Apr 22, 2021 at 12:36 AM Philippe Mathieu-Daudé wrote: Cc'ing Bin. On 4/21/21 5:22 PM, Cole Robinson wrote

Re: [PATCH v6 10/18] cpu: Move CPUClass::vmsd to SysemuCPUOps

2021-04-22 Thread Richard Henderson
On 4/22/21 12:38 PM, Philippe Mathieu-Daudé wrote: Migration is specific to system emulation. - Move the CPUClass::vmsd field to SysemuCPUOps, - restrict VMSTATE_CPU() macro to sysemu, - vmstate_dummy is now unused, remove it. Signed-off-by: Philippe Mathieu-Daudé --- Reviewed-by: Richard He

Re: [PATCH v6 08/18] cpu/{avr, lm32, moxie}: Set DeviceClass vmsd field (not CPUClass one)

2021-04-22 Thread Richard Henderson
On 4/22/21 12:38 PM, Philippe Mathieu-Daudé wrote: See rationale in previous commit. Targets should use the vmsd field of DeviceClass, not CPUClass. As migration is not important on the avr/lm32/moxie targets, break the migration compatibility and set the DeviceClass vmsd field. Signed-off-by: P

Re: [PATCH v6 07/18] cpu: Rename CPUClass vmsd -> legacy_vmsd

2021-04-22 Thread Richard Henderson
On 4/22/21 12:38 PM, Philippe Mathieu-Daudé wrote: Quoting Peter Maydell [*]: There are two ways to handle migration for a CPU object: (1) like any other device, so it has a dc->vmsd that covers migration for the whole object. As usual for objects that are a subclass of a parent

Re: [PATCH v6 06/18] cpu: Assert DeviceClass::vmsd is NULL on user emulation

2021-04-22 Thread Richard Henderson
On 4/22/21 12:38 PM, Philippe Mathieu-Daudé wrote: Migration is specific to system emulation. Restrict current DeviceClass::vmsd to sysemu using #ifdef'ry, and assert in cpu_exec_realizefn() that dc->vmsd not set under user emulation. Signed-off-by: Philippe Mathieu-Daudé --- cpu.c

Re: [PATCH v2 0/7] linux-user: sigaction fixes/cleanups

2021-04-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210422230227.314751-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210422230227.314751-1-richard.hender...@linaro.org Subject: [PATCH v2 0/7] li

[PATCH v2 7/7] linux-user: Tidy TARGET_NR_rt_sigaction

2021-04-22 Thread Richard Henderson
Initialize variables instead of elses. Use an else instead of a goto. Add braces. Signed-off-by: Richard Henderson --- linux-user/syscall.c | 32 +--- 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 9bc

[PATCH v2 4/7] linux-user: Honor TARGET_ARCH_HAS_SA_RESTORER in do_syscall

2021-04-22 Thread Richard Henderson
Do not access a field that may not be present. This will become an issue when sharing more code in the next patch. Signed-off-by: Richard Henderson --- linux-user/syscall.c | 4 1 file changed, 4 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 36169a0ded..89d6

[PATCH v2 3/7] linux-user: Pass ka_restorer to do_sigaction

2021-04-22 Thread Richard Henderson
The value of ka_restorer needs to be saved in sigact_table. At the moment, the attempt to save it in do_syscall is improperly clobbering user memory. Signed-off-by: Richard Henderson --- linux-user/syscall_defs.h | 2 +- linux-user/signal.c | 5 - linux-user/syscall.c | 19 +

[PATCH v2 2/7] linux-user/alpha: Rename the sigaction restorer field

2021-04-22 Thread Richard Henderson
Use ka_restorer, in line with TARGET_ARCH_HAS_KA_RESTORER vs TARGET_ARCH_HAS_SA_RESTORER, since Alpha passes this field as a syscall argument. Signed-off-by: Richard Henderson --- linux-user/syscall_defs.h | 2 +- linux-user/alpha/signal.c | 8 linux-user/syscall.c | 4 ++-- 3 file

[PATCH v2 6/7] linux-user/alpha: Share code for TARGET_NR_sigaction

2021-04-22 Thread Richard Henderson
There's no longer a difference between the alpha code and the generic code. There is a type difference in target_old_sigaction.sa_flags, which can be resolved with a very much smaller ifdef, which allows us to finish sharing the target_sigaction definition. Signed-off-by: Richard Henderson ---

[PATCH v2 5/7] linux-user/alpha: Define TARGET_ARCH_HAS_KA_RESTORER

2021-04-22 Thread Richard Henderson
This means that we can share the TARGET_NR_rt_sigaction code, and the target_rt_sigaction structure is unused. Untangling the ifdefs so that target_sigaction can be shared will wait until the next patch. Signed-off-by: Richard Henderson --- linux-user/alpha/target_signal.h | 1 + linux-user/sy

[PATCH v2 0/7] linux-user: sigaction fixes/cleanups

2021-04-22 Thread Richard Henderson
Alpha had two bugs, one with the non-ka_restorer fallback using the wrong offset, and the other with the ka_restorer value getting lost in do_sigaction. Sparc had another bug, where the ka_restorer field was written to user memory. Version 2 splits patch 2 into 6. r~ Richard Henderson (7):

[PATCH v2 1/7] linux-user/alpha: Fix rt sigframe return

2021-04-22 Thread Richard Henderson
We incorrectly used the offset of the non-rt sigframe. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/alpha/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/alpha/signal.c b/linux-user/alpha

Re: [Bug 1743191] Re: Interacting with NetBSD serial console boot blocks no longer works

2021-04-22 Thread Ottavio Caruso
On Thu, 22 Apr 2021 at 18:23, Andreas Gustafsson <1743...@bugs.launchpad.net> wrote: > > Ottavio Caruso wrote: > > I am currently using: > > > > $ qemu-system-x86_64 --version > > QEMU emulator version 5.2.0 > > > > And I have no problem selecting from menu in serial console, so I > > assume this i

[PULL 2/2] x86: acpi: use offset instead of pointer when using build_header()

2021-04-22 Thread Michael S. Tsirkin
From: Igor Mammedov Do the same as in commit (4d027afeb3a97 Virt: ACPI: fix qemu assert due to re-assigned table data address) for remaining tables that happen to use saved at the beginning pointer to build header to avoid assert when table_data is relocated due to implicit re-size. In this ca

[PULL 0/2] pc: last minute bugfixes

2021-04-22 Thread Michael S. Tsirkin
The following changes since commit d83f46d189a26fa32434139954d264326f199a45: virtio-pci: compat page aligned ATS (2021-04-06 07:11:36 -0400) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to 9106db1038

[PULL 1/2] amd_iommu: Fix pte_override_page_mask()

2021-04-22 Thread Michael S. Tsirkin
From: Jean-Philippe Brucker AMD IOMMU PTEs have a special mode allowing to specify an arbitrary page size. Quoting the AMD IOMMU specification: "When the Next Level bits [of a pte] are 7h, the size of the page is determined by the first zero bit in the page address, starting from bit 12." So if

[Bug 1925512] Re: UNDEFINED case for instruction BLX

2021-04-22 Thread Richard Henderson
The complete imm32 is computed by %imm24 26:s1 13:1 11:1 16:10 0:11 !function=t32_branch24 so that H appears at bit 1 in a->imm in trans_BLX_i. Returning false from any trans_* function means that the trans function did not match. In some cases, this means that the next possible match

Re: [PATCH-for-6.0] net: tap: fix crash on hotplug

2021-04-22 Thread Cole Robinson
On 4/22/21 5:42 AM, Bin Meng wrote: > On Thu, Apr 22, 2021 at 5:36 PM Peter Maydell > wrote: >> >> On Thu, 22 Apr 2021 at 05:29, Bin Meng wrote: >>> >>> On Thu, Apr 22, 2021 at 12:36 AM Philippe Mathieu-Daudé >>> wrote: Cc'ing Bin. On 4/21/21 5:22 PM, Cole Robinson wrote: >>

qemu/kvm tianocore restart stuck

2021-04-22 Thread VoidCC
Hello, I'm hitting a hard wall with qemu and efi. I'm running multiple windows server 2019 vms which usually reboot on updates. The issue is, efi breaks on reboot. It randomly(race condition?, does not occur consistently) ends up in a blackscreen: no bootloader, no efi screen and the only way to

Re: [PATCH 2/2] linux-user: Clean up sigaction ka_restorer

2021-04-22 Thread Richard Henderson
On 4/22/21 11:08 AM, Richard Henderson wrote: Pass the ka_restorer value as an argument to do_sigaction, and put it into the sigaction table. Drop the separate TARGET_ALPHA struct target_rt_sigaction and define TARGET_ARCH_HAS_KA_RESTORER. Tidy up TARGET_NR_rt_sigaction, merging TARGET_ALPHA, a

Re: [RFC PATCH 0/4] hw/ppc: remove call to tcg-only function

2021-04-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210422193131.22560-1-lucas.ara...@eldorado.org.br/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210422193131.22560-1-lucas.ara...@eldorado.org.br Subject: [RFC PATCH 0/4] hw/

[RFC PATCH 0/4] hw/ppc: remove call to tcg-only function

2021-04-22 Thread Lucas Mateus Castro (alqotel)
Hi, I'm working with Bruno Larsen (billionai) to enable the disable-tcg option for PowerPC, right now I'm aiming at removing call to tcg-only functions from hw/ppc, there is still some work to be done in target/ppc. This patch creates a spapr_hcall_tcg_stub.c file that has the same hcalls as spap

[RFC PATCH 3/4] hw/ppc: updated build rules to use new file

2021-04-22 Thread Lucas Mateus Castro (alqotel)
Updated meson.build to compile spapr_hcall_tcg_stub.c instead of spapr_hcall.c when disable-tcg option is used Signed-off-by: Lucas Mateus Castro (alqotel) --- hw/ppc/meson.build | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/ppc/meson.build b/hw/ppc/meson.build

[RFC PATCH 2/4] hw/ppc: Add kvm-only file spapr_hcall_tcg_stub.c

2021-04-22 Thread Lucas Mateus Castro (alqotel)
This file should be used instead of spapr_hcall.c when compiling without tcg (--disable-tcg) as it does not call tcg-only functions and trips fatal error when invalid functions are called As of right now some functions are repeated here and in spapr_hcall.c, as they are static, is some other metho

[PATCH v6 18/18] cpu: Restrict "hw/core/sysemu-cpu-ops.h" to target/cpu.c

2021-04-22 Thread Philippe Mathieu-Daudé
Somehow similar to commit 78271684719 ("cpu: tcg_ops: move to tcg-cpu-ops.h, keep a pointer in CPUClass"): We cannot in principle make the SysEmu Operations field definitions conditional on CONFIG_SOFTMMU in code that is included by both common_ss and specific_ss modules. Therefore, what we can d

[PATCH v6 15/18] cpu: Move CPUClass::get_phys_page_debug to SysemuCPUOps

2021-04-22 Thread Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h| 8 include/hw/core/sysemu-cpu-ops.h | 13 + hw/core/cpu.c| 6 +++--- target/alpha/cpu.c | 2 +- target/arm/cpu.c |

[RFC PATCH 1/4] target/ppc: updated build options

2021-04-22 Thread Lucas Mateus Castro (alqotel)
updated meson.build to not compile tcg-only files Signed-off-by: Lucas Mateus Castro (alqotel) --- target/ppc/meson.build | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/target/ppc/meson.build b/target/ppc/meson.build index bbfef90e08..b369a6bcd0 100644

[PATCH v6 13/18] cpu: Move CPUClass::write_elf* to SysemuCPUOps

2021-04-22 Thread Philippe Mathieu-Daudé
The write_elf*() handlers are used to dump vmcore images. This feature is only meaningful for system emulation. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h| 17 - include/hw/core/sysemu-cpu-ops.h | 24 +++

[PATCH v6 17/18] cpu: Move CPUClass::get_paging_enabled to SysemuCPUOps

2021-04-22 Thread Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h| 2 -- include/hw/core/sysemu-cpu-ops.h | 4 hw/core/cpu.c| 4 ++-- target/i386/cpu.c| 4 +++- 4 files changed, 9 insertions(+), 5 deletions(-) dif

[RFC PATCH 4/4] target/ppc: transfered functions to non-tcg-only files

2021-04-22 Thread Lucas Mateus Castro (alqotel)
moved the functions ppc_store_lpcr and ppc_hash64_filter_pagesizes to common-misc.c so they can be used in a disable-tcg build and added the necessary includes to files that call them. Created ppc_(store|load)_vscr to be used by both tcg and kvm. Signed-off-by: Lucas Mateus Castro (alqotel) ---

[PATCH v6 09/18] cpu: Introduce SysemuCPUOps structure

2021-04-22 Thread Philippe Mathieu-Daudé
Introduce a structure to hold handler specific to sysemu. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h| 5 + include/hw/core/sysemu-cpu-ops.h | 21 + target/alpha/cpu.c | 6 ++ target/arm/c

[PATCH v6 12/18] cpu: Move CPUClass::get_crash_info to SysemuCPUOps

2021-04-22 Thread Philippe Mathieu-Daudé
cpu_get_crash_info() is called on GUEST_PANICKED events, which only occur in system emulation. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h| 1 - include/hw/core/sysemu-cpu-ops.h | 5 + hw/core/cpu.c| 4 ++--

[PATCH v6 08/18] cpu/{avr, lm32, moxie}: Set DeviceClass vmsd field (not CPUClass one)

2021-04-22 Thread Philippe Mathieu-Daudé
See rationale in previous commit. Targets should use the vmsd field of DeviceClass, not CPUClass. As migration is not important on the avr/lm32/moxie targets, break the migration compatibility and set the DeviceClass vmsd field. Signed-off-by: Philippe Mathieu-Daudé --- target/avr/cpu.c | 2 +-

[PATCH v6 14/18] cpu: Move CPUClass::asidx_from_attrs to SysemuCPUOps

2021-04-22 Thread Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h| 3 --- include/hw/core/sysemu-cpu-ops.h | 5 + hw/core/cpu.c| 4 ++-- target/arm/cpu.c | 2 +- target/i386/cpu.c| 2 +- 5 files chan

[PATCH v6 16/18] cpu: Move CPUClass::get_memory_mapping to SysemuCPUOps

2021-04-22 Thread Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h| 3 --- include/hw/core/sysemu-cpu-ops.h | 5 + hw/core/cpu.c| 4 ++-- target/i386/cpu.c| 2 +- 4 files changed, 8 insertions(+), 6 deletions(-) dif

[PATCH v6 06/18] cpu: Assert DeviceClass::vmsd is NULL on user emulation

2021-04-22 Thread Philippe Mathieu-Daudé
Migration is specific to system emulation. Restrict current DeviceClass::vmsd to sysemu using #ifdef'ry, and assert in cpu_exec_realizefn() that dc->vmsd not set under user emulation. Signed-off-by: Philippe Mathieu-Daudé --- cpu.c | 1 + target/sh4/cpu.c | 5 +++-- targe

[PATCH v6 07/18] cpu: Rename CPUClass vmsd -> legacy_vmsd

2021-04-22 Thread Philippe Mathieu-Daudé
Quoting Peter Maydell [*]: There are two ways to handle migration for a CPU object: (1) like any other device, so it has a dc->vmsd that covers migration for the whole object. As usual for objects that are a subclass of a parent that has state, the first entry in the VMStateDescriptio

[PATCH v6 10/18] cpu: Move CPUClass::vmsd to SysemuCPUOps

2021-04-22 Thread Philippe Mathieu-Daudé
Migration is specific to system emulation. - Move the CPUClass::vmsd field to SysemuCPUOps, - restrict VMSTATE_CPU() macro to sysemu, - vmstate_dummy is now unused, remove it. Signed-off-by: Philippe Mathieu-Daudé --- Since v3: Merged in patch 1 (Eduardo) therefore removed Richard R-b. 'vmsd' i

[PATCH v6 11/18] cpu: Move CPUClass::virtio_is_big_endian to SysemuCPUOps

2021-04-22 Thread Philippe Mathieu-Daudé
VirtIO devices are only meaningful with system emulation. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h| 5 - include/hw/core/sysemu-cpu-ops.h | 8 hw/core/cpu.c| 4 ++-- target/arm/cpu.c

[PATCH v6 04/18] cpu: Directly use get_paging_enabled() fallback handlers in place

2021-04-22 Thread Philippe Mathieu-Daudé
No code uses CPUClass::get_paging_enabled() outside of hw/core/cpu.c: $ git grep -F -- '->get_paging_enabled' hw/core/cpu.c:74:return cc->get_paging_enabled(cpu); hw/core/cpu.c:438:k->get_paging_enabled = cpu_common_get_paging_enabled; target/i386/cpu.c:7418:cc->get_paging_enab

[PATCH v6 03/18] cpu: Directly use cpu_write_elf*() fallback handlers in place

2021-04-22 Thread Philippe Mathieu-Daudé
No code directly accesses CPUClass::write_elf*() handlers out of hw/core/cpu.c (the rest are assignation in target/ code): $ git grep -F -- '->write_elf' hw/core/cpu.c:157:return (*cc->write_elf32_qemunote)(f, cpu, opaque); hw/core/cpu.c:171:return (*cc->write_elf32_note)(f, cpu, cpu

[PATCH v6 05/18] cpu: Directly use get_memory_mapping() fallback handlers in place

2021-04-22 Thread Philippe Mathieu-Daudé
No code uses CPUClass::get_memory_mapping() outside of hw/core/cpu.c: $ git grep -F -- '->get_memory_mapping' hw/core/cpu.c:87:cc->get_memory_mapping(cpu, list, errp); hw/core/cpu.c:439:k->get_memory_mapping = cpu_common_get_memory_mapping; target/i386/cpu.c:7422:cc->get_memory

[PATCH v6 01/18] cpu: Un-inline cpu_get_phys_page_debug and cpu_asidx_from_attrs

2021-04-22 Thread Philippe Mathieu-Daudé
To be able to later extract the cpu_get_phys_page_debug() and cpu_asidx_from_attrs() handlers from CPUClass, un-inline them from "hw/core/cpu.h". Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 33 - hw/core/cpu.c

[PATCH v6 02/18] cpu: Introduce cpu_virtio_is_big_endian()

2021-04-22 Thread Philippe Mathieu-Daudé
Introduce the cpu_virtio_is_big_endian() generic helper to avoid calling CPUClass internal virtio_is_big_endian() one. Similarly to commit bf7663c4bd8 ("cpu: introduce CPUClass::virtio_is_big_endian()"), we keep 'virtio' in the method name to hint this handler shouldn't be called anywhere but from

[PATCH v6 00/18] cpu: Introduce SysemuCPUOps structure

2021-04-22 Thread Philippe Mathieu-Daudé
Missing review: patch 6, 7, 8, 10 Hi, This series is inspired on Claudio TCG work. Instead of separate TCG from other accelerators, here we separate sysemu operations (system VS user). Patches 1-5 are generic cleanups. Patches 6-14 move from CPUClass to SysemuCPUOps Patch 15 restricts SysemuC

RE: [PATCH 1/4] target/ppc: Code motion required to build disabling tcg

2021-04-22 Thread Fabiano Rosas
Bruno Piazera Larsen writes: >> > You are correct! I've just tweaked the code that defines spr_register and >> > it should be working now. I'm still working in splitting the SPR functions >> > from translate_init, since I think it would make it easier to prepare the >> > !TCG case and for adding

[Bug 1925512] Re: UNDEFINED case for instruction BLX

2021-04-22 Thread JIANG Muhui
Hi I still feel QEMU's implementation is not right. Could you please check it again. According to https://developer.arm.com/documentation/ddi0406/c /Application-Level-Architecture/Instruction-Details/Alphabetical-list- of-instructions/BL--BLX--immediate-?lang=en The encoding T2 for BLX is below:

Re: [PATCH 1/2] linux-user/alpha: Fix rt sigframe return

2021-04-22 Thread Philippe Mathieu-Daudé
On 4/22/21 8:08 PM, Richard Henderson wrote: > We incorrectly used the offset of the non-rt sigframe. > > Signed-off-by: Richard Henderson > --- > linux-user/alpha/signal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH for-6.0? 0/1] hw/block/nvme: fix msix uninit

2021-04-22 Thread Klaus Jensen
On Apr 22 19:58, Peter Maydell wrote: On Thu, 22 Apr 2021 at 15:07, Klaus Jensen wrote: On Apr 22 15:58, Klaus Jensen wrote: >From: Klaus Jensen > >Hi Peter, > >The commit message on the patch describes the issue. This is a QEMU >crashing bug in -rc4 that I introduced early in the cycle and n

Re: [Bug 1743191] Re: Interacting with NetBSD serial console boot blocks no longer works

2021-04-22 Thread Andreas Gustafsson
Ottavio Caruso wrote: > I am currently using: > > $ qemu-system-x86_64 --version > QEMU emulator version 5.2.0 > > And I have no problem selecting from menu in serial console, so I > assume this is fixed for me. This is my command line: > > $ cat opt/bin/boot-netbsd-virtio > #!/bin/sh > qemu-sys

[Bug 1725707] Re: QEMU sends excess VNC data to websockify even when network is poor

2021-04-22 Thread Thomas Huth
** Bug watch removed: github.com/novnc/noVNC/issues #431 https://github.com/novnc/noVNC/issues/431 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1725707 Title: QEMU sends excess VNC data to webs

[Bug 1615212] Re: SDL UI switching to monitor half-broken and scrolling broken

2021-04-22 Thread Thomas Huth
** Bug watch removed: bugzilla.libsdl.org/ #3287 http://bugzilla.libsdl.org/show_bug.cgi?id=3287 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1615212 Title: SDL UI switching to monitor half-bro

[Bug 1395217] Re: Networking in qemu 2.0.0 and beyond is not compatible with Open Solaris (Illumos) 5.11

2021-04-22 Thread Thomas Huth
** Bug watch removed: Red Hat Bugzilla #1040500 https://bugzilla.redhat.com/show_bug.cgi?id=1040500 ** Bug watch removed: Red Hat Bugzilla #1262093 https://bugzilla.redhat.com/show_bug.cgi?id=1262093 -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Bug 1642421] Re: qemu-system-x86_64: ipv6 and dns is broken with netdev user

2021-04-22 Thread Thomas Huth
** Bug watch removed: Sourceware.org Bugzilla #5475 https://sourceware.org/bugzilla/show_bug.cgi?id=5475 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1642421 Title: qemu-system-x86_64: ipv6 and

[Bug 1703506] Re: SMT not supported by QEMU on AMD Ryzen CPU

2021-04-22 Thread Thomas Huth
** Bug watch removed: Red Hat Bugzilla #1135772 https://bugzilla.redhat.com/show_bug.cgi?id=1135772 ** Bug watch removed: Red Hat Bugzilla #1592276 https://bugzilla.redhat.com/show_bug.cgi?id=1592276 ** Changed in: qemu Assignee: Eduardo Habkost (ehabkost) => (unassigned) -- You rece

[Bug 1766841] Re: QEMU 2.12 Running Problem in Windows 7 Installation

2021-04-22 Thread Thomas Huth
** Changed in: qemu Assignee: Stefan Weil (ubuntu-weilnetz) => (unassigned) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1766841 Title: QEMU 2.12 Running Problem in Windows 7 Installation St

[Bug 1778966] Re: Windows 1803 and later crashes on KVM

2021-04-22 Thread Thomas Huth
** Bug watch removed: Red Hat Bugzilla #1592276 https://bugzilla.redhat.com/show_bug.cgi?id=1592276 ** Bug watch removed: Red Hat Bugzilla #1593190 https://bugzilla.redhat.com/show_bug.cgi?id=1593190 -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Bug 1820247] Re: QEMU random crash caused by libspice-server

2021-04-22 Thread Thomas Huth
** Bug watch removed: Red Hat Bugzilla #980714 https://bugzilla.redhat.com/show_bug.cgi?id=980714 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1820247 Title: QEMU random crash caused by libspic

[Bug 1879425] Re: The thread of "CPU 0 /KVM" keeping 99.9%CPU

2021-04-22 Thread Thomas Huth
** Bug watch removed: bugs.centos.org/ #17385 https://bugs.centos.org/view.php?id=17385 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1879425 Title: The thread of "CPU 0 /KVM" keeping 99.9%CPU

[Bug 1925512] Re: UNDEFINED case for instruction BLX

2021-04-22 Thread Richard Henderson
It's right there in trans_BLX_i: if (s->thumb && (a->imm & 2)) { return false; } ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1925

[Bug 1925417] Re: Cannot boot from EFI image on aarch64

2021-04-22 Thread Ravishankar
When i try to do it manually using the instructions provided here: https://mricher.fr/post/boot-from-an-efi-shell/ I see that Mapping table FS0: Alias(s):HD0m:;BLK4: VenHw(837DCA9E-E874-4D82-B29A-23FE0E23D1E2,003E000A)/HD(12,GPT,49037CF8-B2EF-5B4B-8CCE-EF5803A9E8B3,0x3D0

Re: [PATCH for-6.0? 0/1] hw/block/nvme: fix msix uninit

2021-04-22 Thread Peter Maydell
On Thu, 22 Apr 2021 at 15:07, Klaus Jensen wrote: > > On Apr 22 15:58, Klaus Jensen wrote: > >From: Klaus Jensen > > > >Hi Peter, > > > >The commit message on the patch describes the issue. This is a QEMU > >crashing bug in -rc4 that I introduced early in the cycle and never > >found in time. Lac

Re: [PATCH v2 1/2] block: Add BDRV_O_NO_SHARE for blk_new_open()

2021-04-22 Thread Eric Blake
On 4/22/21 11:43 AM, Kevin Wolf wrote: > Normally, blk_new_open() just shares all permissions. This was fine > originally when permissions only protected against uses in the same > process because no other part of the code would actually get to access > the block nodes opened with blk_new_open(). H

Re: [PATCH 1/2] linux-user/alpha: Fix rt sigframe return

2021-04-22 Thread Laurent Vivier
Le 22/04/2021 à 20:08, Richard Henderson a écrit : > We incorrectly used the offset of the non-rt sigframe. > > Signed-off-by: Richard Henderson > --- > linux-user/alpha/signal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/linux-user/alpha/signal.c b/linux-user/alph

Re: [PATCH 0/2] linux-user: sigaction fixes/cleanups

2021-04-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210422180819.252121-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210422180819.252121-1-richard.hender...@linaro.org Subject: [PATCH 0/2] linux

[PATCH 1/2] linux-user/alpha: Fix rt sigframe return

2021-04-22 Thread Richard Henderson
We incorrectly used the offset of the non-rt sigframe. Signed-off-by: Richard Henderson --- linux-user/alpha/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/alpha/signal.c b/linux-user/alpha/signal.c index c5c27ce084..86f5d2276d 100644 --- a/linux-user/alp

[PATCH 2/2] linux-user: Clean up sigaction ka_restorer

2021-04-22 Thread Richard Henderson
Pass the ka_restorer value as an argument to do_sigaction, and put it into the sigaction table. Drop the separate TARGET_ALPHA struct target_rt_sigaction and define TARGET_ARCH_HAS_KA_RESTORER. Tidy up TARGET_NR_rt_sigaction, merging TARGET_ALPHA, and TARGET_SPARC into common code. Signed-off-by

[PATCH 0/2] linux-user: sigaction fixes/cleanups

2021-04-22 Thread Richard Henderson
Alpha had two bugs, one with the non-ka_restorer fallback using the wrong offset, and the other with the ka_restorer value getting lost in do_sigaction. Because do_sigaction didn't see TARGET_ARCH_HAS_SA_RESTORER (which is correct for alpha, as the field isn't present in the structure), we didn't

[RFC] tcg plugin: Additional plugin interface

2021-04-22 Thread Min-Yih Hsu
Hi Alex and QEMU developers, Recently I was working with the TCG plugin. I found that `qemu_plugin_cb_flags` seems to reserve the functionality to read / write CPU register state, I'm wondering if you can share some roadmap or thoughts on this feature? Personally I see reading the CPU register st

[PATCH 5/5] vhost-user-blk: Check that num-queues is supported by backend

2021-04-22 Thread Kevin Wolf
Creating a device with a number of queues that isn't supported by the backend is pointless, the device won't work properly and the error messages are rather confusing. Just fail to create the device if num-queues is higher than what the backend supports. Since the relationship between num-queues

[PATCH 3/5] vhost-user-blk: Get more feature flags from vhost device

2021-04-22 Thread Kevin Wolf
VIRTIO_F_RING_PACKED and VIRTIO_F_IOMMU_PLATFORM need to be supported by the vhost device, otherwise advertising it to the guest doesn't result in a working configuration. They are currently not supported by the vhost-user-blk export in QEMU. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1935

  1   2   3   4   >