[PATCH v3 07/22] tests/docker: fix mistakes in centos package lists

2021-05-13 Thread Daniel P . Berrangé
mesa-libEGL-devel is not used in QEMU at all, but mesa-libgbm-devel is. spice-glib-devel is not use in QEMU at all, but spice-protocol is. We also need the -devel package for spice-server, not the runtime. There is no need to specifically refer to python36, we can just use python3 as in other dis

[PATCH v3 15/22] tests/docker: expand opensuse-leap package list

2021-05-13 Thread Daniel P . Berrangé
This is the fully expanded list of build pre-requisites QEMU can conceivably use in any scenario. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/opensuse-leap.docker | 57 ++- 1 file changed, 56 insertions(+), 1 deletion(-) di

[PATCH v3 20/22] tests/docker: auto-generate ubuntu2004 with lcitool

2021-05-13 Thread Daniel P . Berrangé
This commit is best examined using the "-b" option to diff. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles-refresh.py| 6 + tests/docker/dockerfiles/ubuntu2004.docker | 249 - 2 files changed, 144 insertions(+), 1

[PATCH v3 13/22] tests/docker: expand ubuntu1804 package list

2021-05-13 Thread Daniel P . Berrangé
This is the fully expanded list of build pre-requisites QEMU can conceivably use in any scenario. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/ubuntu1804.docker | 61 +- 1 file changed, 60 insertions(+), 1 deletion(-) di

[PATCH v3 12/22] tests/docker: expand fedora package list

2021-05-13 Thread Daniel P . Berrangé
This is the fully expanded list of build pre-requisites QEMU can conceivably use in any scenario. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/fedora.docker | 28 +- 1 file changed, 27 insertions(+), 1 deletion(-) di

[PATCH v3 19/22] tests/docker: auto-generate ubuntu1804 with lcitool

2021-05-13 Thread Daniel P . Berrangé
This commit is best examined using the "-b" option to diff. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles-refresh.py| 6 + tests/docker/dockerfiles/ubuntu1804.docker | 247 - 2 files changed, 143 insertions(+), 1

[PATCH v3 02/22] tests/docker: don't use BUILDKIT in GitLab either

2021-05-13 Thread Daniel P . Berrangé
Using BUILDKIT breaks with certain container registries such as CentOS, with docker build reporting an error such as failed to solve with frontend dockerfile.v0: failed to build LLB: failed to load cache key: unexpected status code https://registry.centos.org/v2/centos/manifests/7: 403 F

[PATCH v3 09/22] tests/docker: fix mistakes in ubuntu package lists

2021-05-13 Thread Daniel P . Berrangé
librados-dev is not required by QEMU directly, only librbd-dev. glusterfs-common is not directly needed by QEMU. QEMU uses ncursesw only on non-Windows hosts. The clang package is clang 10. flex and bison are not required by QEMU. Standardize on nmap ncat implementation to match Fedora/CentOS.

[PATCH v3 05/22] tests/docker: remove FEATURES env var from templates

2021-05-13 Thread Daniel P . Berrangé
In preparation for switching to auto-generated dockerfiles, remove the FEATURES env variable. The equivalent functionality can be achieved in most cases by just looking for existance of a binary. The cases which don't correspond to binaries are simply dropped because configure/meson will probe for

[PATCH v3 08/22] tests/docker: fix mistakes in fedora package list

2021-05-13 Thread Daniel P . Berrangé
libblockdev-mpath-devel is not used by QEMU, rather it wants device-mapper-multipath-devel. Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/fedora.docker | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v3 11/22] tests/docker: expand centos8 package list

2021-05-13 Thread Daniel P . Berrangé
This is the fully expanded list of build pre-requisites QEMU can conceivably use in any scenario. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/centos8.docker | 66 + 1 file changed, 66 insertions(+) diff --git a/test

[PATCH v3 00/22] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles

2021-05-13 Thread Daniel P . Berrangé
Currently the tests/docker/dockerfiles/*Dockerfile recipes are all hand written by contributors. There is a common design pattern, but the set of packages listed for installation leaves alot to be desired - There is no consistency at all across distros - Many potential build deps are not listed

[PATCH v3 06/22] tests/docker: fix sorting in package lists

2021-05-13 Thread Daniel P . Berrangé
This will make diffs in later patches clearer. Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/centos8.docker | 2 +- tests/docker/dockerfiles/fedora.docker| 4 ++-- tests/docker/dockerf

[PATCH v3 04/22] tests/docker: use explicit docker.io registry

2021-05-13 Thread Daniel P . Berrangé
It is good practice to use an explicit registry for referencing the base image. This is because some distros will inject their own registries into the search path. For example registry.fedoraproject.org comes ahead of docker.io. Using an explicit registry avoids wasting time querying multiple regis

[PATCH v3 03/22] tests/docker: use project specific container registries

2021-05-13 Thread Daniel P . Berrangé
Since Docker Hub has started to enforce pull rate limits on clients, it is preferrable to use project specific container registries where they are available. Fedora and OpenSUSE projects provide registries. The images in these registries are also refreshed on a more regular basis than the ones in

[PATCH v3 01/22] hw/usb/ccid: remove references to NSS

2021-05-13 Thread Daniel P . Berrangé
The NSS package was previously pre-requisite for building CCID related features, however, this became obsolete when the libcacard library was spun off to a separate project: commit 7b02f5447c64d1854468f758398c9f6fe9e5721f Author: Marc-André Lureau Date: Sun Aug 30 11:48:40 2015 +020

Re: [PATCH 32/72] softfloat: Move round_canonical to softfloat-parts.c.inc

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > At the same time, convert to pointers, renaming to parts$N_uncanon, > and define a macro for parts_uncanon using QEMU_GENERIC. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

[Bug 1913969] Re: unable to migrate non shared storage when TLS is used

2021-05-13 Thread Dr. David Alan Gilbert
cc;ing in eblake Eric: Following that libvirt issue it looks like it's block related; something weird happening where only some of the disks are syncing? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs

Re: [ANNOUNCE] libblkio v0.1.0 preview release

2021-05-13 Thread Stefan Hajnoczi
On Thu, May 06, 2021 at 12:33:24PM +0200, Kevin Wolf wrote: > Am 06.05.2021 um 10:46 hat Stefan Hajnoczi geschrieben: > > On Wed, May 05, 2021 at 06:46:36PM +0200, Kevin Wolf wrote: > > > Am 05.05.2021 um 18:19 hat Stefan Hajnoczi geschrieben: > > > > On Tue, May 04, 2021 at 03:44:23PM +0200, Kevin

Re: [PATCH v2 0/6] hw/southbridge: QOM'ify vt82c686 as VT82C686B_SOUTHBRIDGE

2021-05-13 Thread Philippe Mathieu-Daudé
On 5/11/21 3:09 PM, BALATON Zoltan wrote: > On Tue, 11 May 2021, Philippe Mathieu-Daudé wrote: >> Hi Zoltan, >> >> On 5/11/21 1:28 PM, BALATON Zoltan wrote: >>> On Tue, 11 May 2021, Philippe Mathieu-Daudé wrote: The motivation behind this series is to remove the isa_get_irq(NULL) call to

Re: [PATCH 31/72] softfloat: Move sf_canonicalize to softfloat-parts.c.inc

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > At the same time, convert to pointers, rename to parts$N_canonicalize > and define a macro for parts_canonicalize using QEMU_GENERIC. You also changed the ordering of checks and the likely/unlikey conditions which would be worth mentioning why in the commit. Otherwi

Re: [vhost-user] Expectations around reconnection

2021-05-13 Thread Philippe Mathieu-Daudé
Cc'ing few developers On 5/11/21 3:33 PM, Boeuf, Sebastien wrote: > Hi All, > > In the context of vhost-user, I was wondering how a reconnection should > be handled from the VMM perspective? > > In particular, I'm looking at the OVS-DPDK use case using the client > mode (meaning QEMU acts as th

Re: [PATCH 08/10] iotests: use 'with open()' where applicable

2021-05-13 Thread Philippe Mathieu-Daudé
On 5/12/21 11:46 PM, John Snow wrote: > More pylint 2.8.x warning hushing: use open's context manager where it's > applicable to do so to avoid a warning. > > Signed-off-by: John Snow > --- > tests/qemu-iotests/iotests.py | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) Rev

Re: [PATCH 02/10] python/machine: use subprocess.DEVNULL instead of open(os.path.devnull)

2021-05-13 Thread Philippe Mathieu-Daudé
On 5/12/21 11:46 PM, John Snow wrote: > One less file resource to manage, and it helps quiet some pylint >= > 2.8.0 warnings about not using a with-context manager for the open call. > > Signed-off-by: John Snow > --- > python/qemu/machine.py | 6 ++ > 1 file changed, 2 insertions(+), 4 dele

Re: [PATCH 01/10] python/console_socket: avoid one-letter variable

2021-05-13 Thread Philippe Mathieu-Daudé
On 5/12/21 11:46 PM, John Snow wrote: > Fixes pylint warnings. > > Signed-off-by: John Snow > Reviewed-by: Cleber Rosa > --- > python/qemu/console_socket.py | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 27/72] softfloat: Convert float128_default_nan to parts

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [External] Re: [Virtio-fs] host-user reconnection and crash recovery

2021-05-13 Thread Jiachen Zhang
On Thu, May 13, 2021 at 4:26 PM Dr. David Alan Gilbert wrote: > * Jiachen Zhang (zhangjiachen.jay...@bytedance.com) wrote: > > Hi Stefan and Sebastien, > > > > I think I should give some background context from my perspective. > > > > For the virtiofsd crash reconnection (recovery) to QEMU, as sa

Re: [PATCH 26/72] softfloat: Convert float128_silence_nan to parts

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > This is the minimal change that also introduces float128_params, > float128_unpack_raw, and float128_pack_raw without running into > unused symbol Werrors. > > Signed-off-by: Richard Henderson > --- > fpu/softfloat.c| 96

[RFC PATCH 9/9] qapi: Allow some commands to be executed in machine 'initialized' phase

2021-05-13 Thread Mirela Grujic
The following commands are allowed to execute during the machine 'initialized' phase (enabled with 'allow-init-config' option): 1) query-machine-phase 2) next-machine-phase 3) advance-machine-phase 3) device_add Note: for device_add command in qdev.json adding the 'allow-init-config' option has no

[RFC PATCH 7/9] qdev-monitor: Restructure and fix the check for command availability

2021-05-13 Thread Mirela Grujic
The existing code had to be restructured to make room for adding checks that are specific to the machine phases. The fix is related to the way that commands with the 'allow-preconfig' option are treated. Commands labelled with the 'allow-preconfig' option were meant to be allowed during the 'prec

[RFC PATCH 5/9] qapi: Implement 'next-machine-phase' command

2021-05-13 Thread Mirela Grujic
This command will be used to control via QMP the advancing of machine through initialization phases. The feature is needed to enable the machine configuration via QMP. The command triggers QEMU to advance the machine to the next init phase, i.e. to execute initialization steps required to enter th

[RFC PATCH 8/9] qapi: Introduce 'allow-init-config' option

2021-05-13 Thread Mirela Grujic
This option will be used to select the commands which are allowed to execute during the MACHINE_INIT_PHASE_INITIALIZED machine phase. Signed-off-by: Mirela Grujic --- docs/sphinx/qapidoc.py | 2 +- include/qapi/qmp/dispatch.h | 1 + softmmu/qdev-monitor.c | 5 + scripts/qapi/com

[RFC PATCH 4/9] qapi: Implement 'query-machine-phase' command

2021-05-13 Thread Mirela Grujic
The command returns current machine initialization phase. >From now on, the MachineInitPhase enum is generated. Signed-off-by: Mirela Grujic --- qapi/machine.json | 54 ++ include/hw/qdev-core.h | 29 +--- hw/core/machine-qmp-cmds.

[RFC PATCH 2/9] replace machine phase_check with machine_is_initialized/ready calls

2021-05-13 Thread Mirela Grujic
Once we define MachineInitPhase in qapi, the generated enumeration constants will be prefixed with the MACHINE_INIT_PHASE_. We need to define the MachineInitPhase enum in qapi in order to add the QMP command that will query current machine init phase. Since in the existing definition of enum Machi

[RFC PATCH 6/9] qapi: Implement 'advance-machine-phase' command

2021-05-13 Thread Mirela Grujic
The command takes the target initialization phase as the argument and triggers QEMU to advance the machine to the target phase (i.e. execute all initialization steps required to enter the target phase). This command would be used as an alternative to 'next-machine-phase' if it's more convenient to

[RFC PATCH 3/9] rename MachineInitPhase enumeration constants

2021-05-13 Thread Mirela Grujic
This renaming is a second phase in getting the code ready for defining MachineInitPhase in qapi (enumeration constants are going to be generated and prefixed with a name derived from the enumeration type, i.e. MACHINE_INIT_PHASE_. Signed-off-by: Mirela Grujic --- include/hw/qdev-core.h | 10

[RFC PATCH 1/9] vl: Allow finer control in advancing machine through phases

2021-05-13 Thread Mirela Grujic
In addition to the existing preconfig approach, which allows configuring the machine via QMP before the machine is initialized, we need the ability to configure the machine right after it's initialized. This patch will enable doing that in a scalable fashion as follows. The basic idea is to group

[RFC PATCH 0/9] Initial support for machine creation via QMP

2021-05-13 Thread Mirela Grujic
The direction for this work has been set in the discussion thread: "About creating machines on the command line" in January/February 2021: https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg01839.html https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg01070.html To customize a machine

Re: [Virtio-fs] host-user reconnection and crash recovery

2021-05-13 Thread Dr. David Alan Gilbert
* Jiachen Zhang (zhangjiachen.jay...@bytedance.com) wrote: > Hi Stefan and Sebastien, > > I think I should give some background context from my perspective. > > For the virtiofsd crash reconnection (recovery) to QEMU, as said by > Stefan, we discussed the possible implementation on the bi-weekly

[Bug 1924603] Re: Incorrect feature negotiation for vhost-vdpa netdevice

2021-05-13 Thread Gautam Dawar
https://qemu-devel.nongnu.narkive.com/jUimpLt0/patch-vhost-net-initialize-acked-features-to-a-safe-value-during-ack This review of a patch that introduced "acked_features = backend_features" behaviour suggests that acked_features should be 0 by default, but it ended up pushing it as it is now (as

Re: [Phishing Risk] [External] Re: [Virtio-fs] vhost-user reconnection and crash recovery

2021-05-13 Thread Jiachen Zhang
Hi Stefan and Sebastien, I think I should give some background context from my perspective. For the virtiofsd crash reconnection (recovery) to QEMU, as said by Stefan, we discussed the possible implementation on the bi-weekly virtio-fs call. I had also sent an RFC patch to the virtio-fs mail-list

Re: [PATCH] hw/input/hid: Add support for keys of jp106 keyboard.

2021-05-13 Thread Laurent Vivier
Le 13/05/2021 à 08:11, Katsuhiro Ueno a écrit : > Ping. cc Gerd > 2021-04-27 11:02 Katsuhiro Ueno : >> >> Add support for the following keys: KATAKANAHIRAGANA, HENKAN, MUHENKAN, >> RO, and YEN. Before this commit, these keys did not work as expected >> when a jp106 keyboard was connected to the

Re: [RFC PATCH v2 2/6] hw/arm/virt: DT: Add cpu-map

2021-05-13 Thread wangyanan (Y)
On 2021/5/13 14:58, Andrew Jones wrote: On Tue, Apr 13, 2021 at 04:07:41PM +0800, Yanan Wang wrote: From: Andrew Jones Support device tree CPU topology descriptions. Signed-off-by: Andrew Jones Signed-off-by: Yanan Wang --- hw/arm/virt.c | 41

Re: [RFC v9 24/29] hw/arm/smmuv3: Fill the IOTLBEntry leaf field on NH_VA invalidation

2021-05-13 Thread Kunkun Jiang
Hi Eric, On 2021/4/11 20:09, Eric Auger wrote: Let's propagate the leaf attribute throughout the invalidation path. This hint is used to reduce the scope of the invalidations to the last level of translation. Not enforcing it induces large performance penalties in nested mode. Signed-off-by: Er

<    1   2   3   4