[PATCH v2] virtiofsd: use GDateTime for formatting timestamp for debug messages

2021-06-11 Thread Daniel P . Berrangé
The GDateTime APIs provided by GLib avoid portability pitfalls, such as some platforms where 'struct timeval.tv_sec' field is still 'long' instead of 'time_t'. When combined with automatic cleanup, GDateTime often results in simpler code too. Localtime is changed to UTC to avoid the need to grant

[PATCH v2] Test comment for git-publish

2021-06-11 Thread Mauro Matteo Cascella
--- hw/rdma/vmw/pvrdma_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c index 84ae8024fc..e229c19564 100644 --- a/hw/rdma/vmw/pvrdma_main.c +++ b/hw/rdma/vmw/pvrdma_main.c @@ -427,7 +427,7 @@ static void

Re: [PATCH 5/7] io: use GDateTime for formatting timestamp for websock headers

2021-06-11 Thread Daniel P . Berrangé
ping: anyone willing to review this On Wed, May 05, 2021 at 11:37:00AM +0100, Daniel P. Berrangé wrote: > The GDateTime APIs provided by GLib avoid portability pitfalls, such > as some platforms where 'struct timeval.tv_sec' field is still 'long' > instead of 'time_t'. When combined with

Re: [PATCH 3/7] net/rocker: use GDateTime for formatting timestamp in debug messages

2021-06-11 Thread Daniel P . Berrangé
ping: anyone willing to give a review of this one On Wed, May 05, 2021 at 11:36:58AM +0100, Daniel P. Berrangé wrote: > The GDateTime APIs provided by GLib avoid portability pitfalls, such > as some platforms where 'struct timeval.tv_sec' field is still 'long' > instead of 'time_t'. When combined

Re: [PATCH] tcg/arm: Fix tcg_out_op function signature

2021-06-11 Thread Richard Henderson
On 6/10/21 3:44 PM, Jose R. Ziviani wrote: Commit 5e8892db93 fixed several function signatures but tcg_out_op for arm is missing. This patch fixes it as well. Signed-off-by: Jose R. Ziviani --- tcg/arm/tcg-target.c.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Thanks, queued.

Re: [PATCH] Test comment for git-publish

2021-06-11 Thread Mauro Matteo Cascella
On Fri, Jun 11, 2021 at 6:20 PM Mauro Matteo Cascella wrote: > > --- > hw/rdma/vmw/pvrdma_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c > index 84ae8024fc..e229c19564 100644 > --- a/hw/rdma/vmw/pvrdma_main.c

[PATCH] Test comment for git-publish

2021-06-11 Thread Mauro Matteo Cascella
--- hw/rdma/vmw/pvrdma_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c index 84ae8024fc..e229c19564 100644 --- a/hw/rdma/vmw/pvrdma_main.c +++ b/hw/rdma/vmw/pvrdma_main.c @@ -427,7 +427,7 @@ static void

Re: [RFC PATCH 0/7] Support protection keys in an AMD EPYC-Milan VM

2021-06-11 Thread Paolo Bonzini
First of all, sorry for the delayed review. On 20/05/21 16:56, David Edmondson wrote: AMD EPYC-Milan CPUs introduced support for protection keys, previously available only with Intel CPUs. AMD chose to place the XSAVE state component for the protection keys at a different offset in the XSAVE

Re: [PATCH v2] async: the main AioContext is only "current" if under the BQL

2021-06-11 Thread Eric Blake
On Fri, Jun 11, 2021 at 01:14:27PM +0200, Paolo Bonzini wrote: > > > With this change, qemu_mutex_iothread_locked() must be changed from > > > > Did you miss "qemu_mutex_iothread_locked() stub function"? > > Yes, that comment refers to the stub. Let me resubmit with a testcase and > I'll fix

Re: [PATCH v4 00/32] block/nbd: rework client connection

2021-06-11 Thread Eric Blake
On Thu, Jun 10, 2021 at 01:07:30PM +0300, Vladimir Sementsov-Ogievskiy wrote: > v4: > > Now based on new Paolo's patch: > Based-on: <20210609122234.544153-1-pbonz...@redhat.com> > > Also, I've dropped patch 33 for now, it's too much for this series. > I'll resend it later on top of this. > >

Re: [Virtio-fs] [PATCH] docs: describe the security considerations with virtiofsd xattr mapping

2021-06-11 Thread Vivek Goyal
On Fri, Jun 11, 2021 at 01:04:27PM +0100, Daniel P. Berrangé wrote: > Different guest xattr prefixes have distinct access control rules applied > by the guest. When remapping a guest xattr care must be taken that the > remapping does not allow the a guest user to bypass guest kernel access >

Re: [PATCH v4 28/32] block/nbd: split nbd_co_do_establish_connection out of nbd_reconnect_attempt

2021-06-11 Thread Eric Blake
On Thu, Jun 10, 2021 at 01:07:58PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Split out the part that we want to reuse for nbd_open(). > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/nbd.c | 80 - > 1 file changed, 42

Re: [PATCH v4 21/32] nbd/client-connection: shutdown connection on release

2021-06-11 Thread Eric Blake
On Thu, Jun 10, 2021 at 01:07:51PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Now, when a thread can do negotiation and retry, it may run relatively > long. We need a mechanism to stop it, when the user is not interested > in a result any more. So, on nbd_client_connection_release() let's >

Re: [PATCH RFC 1/1] linux-user/s390x: save/restore condition code state during signal handling

2021-06-11 Thread Richard Henderson
On 6/10/21 11:58 AM, Jonathan Albrecht wrote: @@ -65,6 +65,10 @@ typedef struct { uint8_t callee_used_stack[__SIGNAL_FRAMESIZE]; target_sigcontext sc; target_sigregs sregs; +uint32_t scc_op; +uint64_t scc_src; +uint64_t scc_dst; +uint64_t scc_vr; int

Re: [PATCH v3 7/7] migration/dirtyrate: implement dirty-ring dirtyrate calculation

2021-06-11 Thread Peter Xu
On Fri, Jun 11, 2021 at 10:05:22PM +0800, Hyman Huang wrote: > > > +switch (last_method) { > > > +case CALC_NONE: > > > +case CALC_SAMPLE_PAGES: > > > +if (config.per_vcpu) { > > > +DirtyStat.method.vcpu.nvcpu = -1; > > > +DirtyStat.method.vcpu.rates =

Re: [PATCH v4 20/32] nbd/client-connection: implement connection retry

2021-06-11 Thread Eric Blake
On Thu, Jun 10, 2021 at 01:07:50PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Add an option for a thread to retry connection until succeeds. We'll for a thread to retry connecting until it succeeds. > use nbd/client-connection both for reconnect and for initial connection > in nbd_open(), so

Re: [PATCH v4 19/32] nbd/client-connection: add possibility of negotiation

2021-06-11 Thread Eric Blake
On Thu, Jun 10, 2021 at 01:07:49PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Add arguments and logic to support nbd negotiation in the same thread > after successful connection. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/nbd.h | 9 +++- > block/nbd.c

Re: tb_flush() calls causing long Windows XP boot times

2021-06-11 Thread Programmingkid
> On Jun 11, 2021, at 7:24 AM, Alex Bennée wrote: > > > Mark Cave-Ayland writes: > >> On 10/06/2021 14:14, Peter Maydell wrote: >> >>> On Thu, 10 Jun 2021 at 14:02, Programmingkid >>> wrote: Hi Richard, There is a function called breakpoint_invalidate() in cpu.c

Re: [PATCH v2] qemu-img: Make unallocated part of backing chain obvious in map

2021-06-11 Thread Eric Blake
On Fri, Jun 11, 2021 at 05:35:12PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > An obvious solution is to make 'qemu-img map --output=json' > > distinguish between clusters that have a local allocation from those > > that are found nowhere in the chain. We already have a one-off > > mismatch

Re: [PATCH 2/6] qapi/parser: Allow empty QAPIDoc Sections

2021-06-11 Thread Markus Armbruster
John Snow writes: > On 5/21/21 1:35 AM, Markus Armbruster wrote: >> Does not fire for qga/qapi-schema.json. Can you help? > > Odd. > > I did: > > if self._section: > ... > else: > raise QAPIWhicheverErrorItWas(...) > > and then did a full build and found it to fail on QGA stuff. You may

Re: [PATCH 1/1] vfio-ccw: Keep passthrough sense data intact

2021-06-11 Thread Cornelia Huck
On Fri, Jun 11 2021, Eric Farman wrote: > On Fri, 2021-06-11 at 12:21 +0200, Cornelia Huck wrote: >> On Fri, Jun 11 2021, Cornelia Huck wrote: >> >> > On Thu, Jun 10 2021, Eric Farman wrote: >> > > diff --git a/hw/s390x/css.c b/hw/s390x/css.c >> > > index bed46f5ec3..29234daa27 100644 >> > >

Re: [PATCH v2] qemu-img: Make unallocated part of backing chain obvious in map

2021-06-11 Thread Vladimir Sementsov-Ogievskiy
11.06.2021 17:01, Eric Blake wrote: The recently-added NBD context qemu:allocation-depth is able to distinguish between locally-present data (even with that data is sparse) [shown as depth 1 over NBD], and data that could not be found anywhere in the backing chain [shown as depth 0]. But

Re: [PATCH v7 2/2] target/i386: Correct implementation for FCS, FIP, FDS and FDP

2021-06-11 Thread Ziqiao Kong
Ping. On Fri, Jun 4, 2021 at 11:04 PM Ziqiao Kong wrote: > > Ping. > > Sorry again for the previous duplicate emails. > > On Sun, May 30, 2021 at 11:05 PM Ziqiao Kong wrote: > > > > Update FCS:FIP and FDS:FDP according to the Intel Manual Vol.1 8.1.8. Note > > that > >

Re: [PATCH v7 1/2] target/i386: Trivial code motion and code style fix

2021-06-11 Thread Ziqiao Kong
Ping. On Fri, Jun 4, 2021 at 11:04 PM Ziqiao Kong wrote: > > Ping. > > Sorry again for the previous duplicate emails. > > On Sun, May 30, 2021 at 11:03 PM Ziqiao Kong wrote: > > > > A new pair of braces has to be added to declare variables in the case block. > > The code style is also fixed

Re: [PATCH v4 18/32] nbd/client-connection: use QEMU_LOCK_GUARD

2021-06-11 Thread Eric Blake
On Thu, Jun 10, 2021 at 01:07:48PM +0300, Vladimir Sementsov-Ogievskiy wrote: > We don't update connect_thread_func() to use QEMU_LOCK_GUARD, as it > will get more complex critical sections logic in further commit, where > QEMU_LOCK_GUARD doesn't help. > > Signed-off-by: Vladimir

Re: [PATCH v4 16/32] block/nbd: introduce nbd_client_connection_release()

2021-06-11 Thread Eric Blake
On Thu, Jun 10, 2021 at 01:07:46PM +0300, Vladimir Sementsov-Ogievskiy wrote: > This is a last step of creating bs-independent nbd connection > interface. With next commit we can finally move it to separate file. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/nbd.c | 45

Re: [PATCH v4 11/32] block/nbd: drop thr->state

2021-06-11 Thread Eric Blake
On Thu, Jun 10, 2021 at 01:07:41PM +0300, Vladimir Sementsov-Ogievskiy wrote: > We don't need all these states. The code refactored to use two boolean > variables looks simpler. > > While moving the comment in nbd_co_establish_connection() rework it to > give better information. Also, we are

Re: [RFC PATCH 4/5] qmp: Added qemu-ebpf-rss-path command.

2021-06-11 Thread Eric Blake
On Wed, Jun 09, 2021 at 01:04:56PM +0300, Andrew Melnychenko wrote: > New qmp command to query ebpf helper. > It's crucial that qemu and helper are in sync and in touch. > Technically helper should pass eBPF fds that qemu may accept. > And different qemu's builds may have different eBPF programs

Re: [PATCH v4 05/32] qemu-sockets: introduce socket_address_parse_named_fd()

2021-06-11 Thread Vladimir Sementsov-Ogievskiy
11.06.2021 16:22, Eric Blake wrote: On Thu, Jun 10, 2021 at 01:07:35PM +0300, Vladimir Sementsov-Ogievskiy wrote: Add function that transforms named fd inside SocketAddress structure into number representation. This way it may be then used in a context where current monitor is not available.

Re: GSoC Intro - TUI interface for QMP

2021-06-11 Thread Vladimir Sementsov-Ogievskiy via
24.05.2021 20:34, John Snow wrote: On 5/24/21 9:32 AM, Stefan Hajnoczi wrote: On Sat, May 22, 2021 at 12:32:00AM +0530, Niteesh G. S. wrote: Welcome Niteesh :) I look forward to working with you this summer. By end of this summer, I would like to get a basic TUI with some desirable features

Re: [PATCH v4 10/32] block/nbd: simplify waking of nbd_co_establish_connection()

2021-06-11 Thread Eric Blake
On Thu, Jun 10, 2021 at 01:07:40PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Instead of managing connect_bh, bh_ctx, and wait_connect fields, we > can use a single link to the waiting coroutine with proper mutex > protection. > ... > Also, this commit reduces the dependence of >

Re: [PATCH v3 7/7] migration/dirtyrate: implement dirty-ring dirtyrate calculation

2021-06-11 Thread Hyman Huang
在 2021/6/8 2:36, Peter Xu 写道: On Mon, Jun 07, 2021 at 09:15:20AM +0800, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) use dirty ring feature to implement dirtyrate calculation. to enable it, set vcpu option as true in calc-dirty-rate. add per_vcpu as mandatory option in

Re: [PATCH 3/4] target/riscv: Implement AIA local interrupt CSRs

2021-06-11 Thread Anup Patel
On Fri, Jun 11, 2021 at 2:16 PM Alistair Francis wrote: > > On Fri, Jun 11, 2021 at 3:04 PM Anup Patel wrote: > > > > On Fri, Jun 11, 2021 at 4:49 AM Alistair Francis > > wrote: > > > > > > On Sat, May 15, 2021 at 12:34 AM Anup Patel wrote: > > > > > > > > We implement various AIA local

[PATCH v2] qemu-img: Make unallocated part of backing chain obvious in map

2021-06-11 Thread Eric Blake
The recently-added NBD context qemu:allocation-depth is able to distinguish between locally-present data (even with that data is sparse) [shown as depth 1 over NBD], and data that could not be found anywhere in the backing chain [shown as depth 0]. But qemu-img map --output=json predates that

Re: [PATCH v4 06/32] block/nbd: call socket_address_parse_named_fd() in advance

2021-06-11 Thread Eric Blake
On Thu, Jun 10, 2021 at 01:07:36PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Detecting monitor by current coroutine works bad when we are not in > coroutine context. And that's exactly so in nbd reconnect code, where > qio_channel_socket_connect_sync() is called from thread. > > Monitor is

Re: [PATCH v8 00/15] RAM_NORESERVE, MAP_NORESERVE and hostmem "reserve" property

2021-06-11 Thread David Hildenbrand
On 11.06.21 15:34, Paolo Bonzini wrote: On 10/05/21 13:43, David Hildenbrand wrote: Based-on: 20210406080126.24010-1-da...@redhat.com Queued both the dependent series and this one, thanks. Sorry for the delay. No worries Paolo, I know that we're all super busy -- thanks! -- Thanks,

Re: [PATCH v8 00/15] RAM_NORESERVE, MAP_NORESERVE and hostmem "reserve" property

2021-06-11 Thread Paolo Bonzini
On 10/05/21 13:43, David Hildenbrand wrote: Based-on: 20210406080126.24010-1-da...@redhat.com Queued both the dependent series and this one, thanks. Sorry for the delay. Paolo Some cleanups previously sent in other context (resizeable allocations), followed by RAM_NORESERVE, implementing

Re: [PATCH] qemu-{img,nbd}: Don't report zeroed cluster as a hole

2021-06-11 Thread Eric Blake
On Fri, Jun 11, 2021 at 01:21:45PM +0200, Kevin Wolf wrote: > > Did you consider just add a new field? > > > > So, "depth" keeps its meaning "which level provides data". > > > > And we add additional optional field like > > > > absolutely-completely-absent: bool > > > > Which is true if data

Re: [PATCH] qemu-{img,nbd}: Don't report zeroed cluster as a hole

2021-06-11 Thread Eric Blake
On Fri, Jun 11, 2021 at 10:09:09AM +0200, Kevin Wolf wrote: > > Yes, that might work as well. But we didn't previously document > > depth to be optional. Removing something from output risks breaking > > more downstream tools that expect it to be non-optional, compared to > > providing a new

Re: [PATCH v4 05/32] qemu-sockets: introduce socket_address_parse_named_fd()

2021-06-11 Thread Eric Blake
On Thu, Jun 10, 2021 at 01:07:35PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Add function that transforms named fd inside SocketAddress structure > into number representation. This way it may be then used in a context > where current monitor is not available. > > Signed-off-by: Vladimir

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-11 Thread Claudio Fontana
On 6/11/21 3:03 PM, Gerd Hoffmann wrote: > Hi, > >> Are there any pending patches to handle the remaining tcg dependencies >> in qemu? When trying to build tcg modular (more than only >> tcg-accel-ops*) I get lots of unresolved symbols to tcg bits which are >> referenced directly (in cpu.c,

Re: [PATCH v3 7/7] migration/dirtyrate: implement dirty-ring dirtyrate calculation

2021-06-11 Thread Hyman Huang
在 2021/6/10 2:17, Peter Xu 写道: On Mon, Jun 07, 2021 at 09:15:20AM +0800, huang...@chinatelecom.cn wrote: +static void calculate_dirtyrate_vcpu(struct DirtyRateConfig config) +{ +CPUState *cpu; +int64_t msec = 0; +int64_t start_time; +uint64_t dirtyrate = 0; +uint64_t

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-11 Thread Gerd Hoffmann
Hi, > Are there any pending patches to handle the remaining tcg dependencies > in qemu? When trying to build tcg modular (more than only > tcg-accel-ops*) I get lots of unresolved symbols to tcg bits which are > referenced directly (in cpu.c, gdbstub.c, monitor, ...). > > The CONFIG_TCG=n

Re: [PATCH] qemu-{img,nbd}: Don't report zeroed cluster as a hole

2021-06-11 Thread Vladimir Sementsov-Ogievskiy
11.06.2021 14:21, Kevin Wolf wrote: Am 11.06.2021 um 10:14 hat Vladimir Sementsov-Ogievskiy geschrieben: 11.06.2021 11:09, Kevin Wolf wrote: Am 10.06.2021 um 22:46 hat Eric Blake geschrieben: On Thu, Jun 10, 2021 at 11:09:05PM +0300, Nir Soffer wrote: But: $ qemu-img map --output=json -f

Re: [PATCH 1/1] vfio-ccw: Keep passthrough sense data intact

2021-06-11 Thread Eric Farman
On Fri, 2021-06-11 at 12:21 +0200, Cornelia Huck wrote: > On Fri, Jun 11 2021, Cornelia Huck wrote: > > > On Thu, Jun 10 2021, Eric Farman wrote: > > > diff --git a/hw/s390x/css.c b/hw/s390x/css.c > > > index bed46f5ec3..29234daa27 100644 > > > --- a/hw/s390x/css.c > > > +++ b/hw/s390x/css.c >

Re: [RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions

2021-06-11 Thread Stefan Berger
On 6/11/21 4:02 AM, Markus Armbruster wrote: Stefan, would you be willing to look into this? Have a look at the 3 topmost patches: https://github.com/stefanberger/qemu-tpm/commits/tpm-eliminate-if-not-config-tpm

Re: [PATCH v2 2/2] spapr: use DEVICE_UNPLUG_ERROR to report unplug errors

2021-06-11 Thread Markus Armbruster
Daniel Henrique Barboza writes: > Linux Kernel 5.12 is now unisolating CPU DRCs in the device_removal > error path, signalling that the hotunplug process wasn't successful. > This allow us to send a DEVICE_UNPLUG_ERROR in drc_unisolate_logical() > to signal this error to the management layer. >

Re: [PATCH v2 1/2] qapi/machine.json: add DEVICE_UNPLUG_ERROR QAPI event

2021-06-11 Thread Markus Armbruster
Daniel Henrique Barboza writes: > At this moment we only provide one event to report a hotunplug error, > MEM_UNPLUG_ERROR. As of Linux kernel 5.12 and QEMU 6.0.0, the pseries > machine is now able to report unplug errors for other device types, such > as CPUs. > > Instead of creating a

[PATCH] docs: describe the security considerations with virtiofsd xattr mapping

2021-06-11 Thread Daniel P . Berrangé
Different guest xattr prefixes have distinct access control rules applied by the guest. When remapping a guest xattr care must be taken that the remapping does not allow the a guest user to bypass guest kernel access control rules. For example if 'trusted.*' which requires CAP_SYS_ADMIN is

Re: [PULL 00/12] Net patches

2021-06-11 Thread Peter Maydell
On Fri, 11 Jun 2021 at 07:00, Jason Wang wrote: > > The following changes since commit 7fe7fae8b48e3f9c647fd685e5155ebc8e6fb84d: > > Merge remote-tracking branch > 'remotes/dgilbert-gitlab/tags/pull-migration-20210609a' into staging > (2021-06-09 16:40:21 +0100) > > are available in the git

[PATCH] esp: store lun coming from the MESSAGE OUT phase

2021-06-11 Thread Paolo Bonzini
The LUN is selected with an IDENTIFY message, and persists until the next message out phase. Instead of passing it to do_busid_cmd, store it in ESPState. Because do_cmd can simply skip the message out phase if cmdfifo_cdb_offset is zero, it can now be used for the S without ATN cases as well.

Re: [PATCH 4/5] esp: revert 75ef849696 "esp: correctly fill bus id with requested lun"

2021-06-11 Thread Mark Cave-Ayland
On 11/06/2021 12:38, Paolo Bonzini wrote: On 09/06/21 17:31, Mark Cave-Ayland wrote: Due to the absence of the IDENTIFY byte in the S case I'm guessing from the patch that the LUN is in encoded in buf[1] (the top bits being "Reserved" according to my copy of the specification). They used to

Re: [PATCH v2 2/3] hw/timer: Initial commit of Ibex Timer

2021-06-11 Thread Paolo Bonzini
On 11/06/21 01:01, Alistair Francis wrote: On Wed, Jun 9, 2021 at 5:57 PM Paolo Bonzini wrote: On 09/06/21 01:48, Alistair Francis wrote: Add support for the Ibex timer. This is used with the RISC-V mtime/mtimecmp similar to the SiFive CLINT. We currently don't support changing the prescale

[PATCH] block/nvme: Fix VFIO_MAP_DMA failed: No space left on device

2021-06-11 Thread Philippe Mathieu-Daudé
When the NVMe block driver was introduced (see commit bdd6a90a9e5, January 2018), Linux VFIO_IOMMU_MAP_DMA ioctl was only returning -ENOMEM in case of error. The driver was correctly handling the error path to recycle its volatile IOVA mappings. To fix CVE-2019-3882, Linux commit 492855939bdb

Re: [PATCH] softfloat: Fix tp init in float32_exp2

2021-06-11 Thread Alex Bennée
Richard Henderson writes: > Typo in the conversion to FloatParts64. > > Fixes: 572c4d862ff2 > Fixes: Coverity CID 1457457 > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 4/5] esp: revert 75ef849696 "esp: correctly fill bus id with requested lun"

2021-06-11 Thread Paolo Bonzini
On 09/06/21 17:31, Mark Cave-Ayland wrote: Due to the absence of the IDENTIFY byte in the S case I'm guessing from the patch that the LUN is in encoded in buf[1] (the top bits being "Reserved" according to my copy of the specification). They used to be the LUN many years ago.  static void

Re: tb_flush() calls causing long Windows XP boot times

2021-06-11 Thread Alex Bennée
Mark Cave-Ayland writes: > On 10/06/2021 14:14, Peter Maydell wrote: > >> On Thu, 10 Jun 2021 at 14:02, Programmingkid >> wrote: >>> >>> Hi Richard, >>> >>> There is a function called breakpoint_invalidate() in cpu.c that >>> calls a function called tb_flush(). I have determined that this

Re: [PATCH] qemu-{img,nbd}: Don't report zeroed cluster as a hole

2021-06-11 Thread Kevin Wolf
Am 11.06.2021 um 10:14 hat Vladimir Sementsov-Ogievskiy geschrieben: > 11.06.2021 11:09, Kevin Wolf wrote: > > Am 10.06.2021 um 22:46 hat Eric Blake geschrieben: > > > On Thu, Jun 10, 2021 at 11:09:05PM +0300, Nir Soffer wrote: > > > > > But: > > > > > > > > > > $ qemu-img map --output=json -f

Re: [PATCH] tcg: Fix documentation for tcg_constant_* vs tcg_temp_free_*

2021-06-11 Thread Alex Bennée
Richard Henderson writes: > At some point during the development of tcg_constant_*, I changed > my mind about whether such temps should be able to be passed to > tcg_temp_free_*. The final version committed allows this, but the > commentary was not updated to match. > > Fixes: c0522136adf >

Re: [PATCH] accel/tcg: Use MiB in tcg_init_machine

2021-06-11 Thread Alex Bennée
Richard Henderson writes: > Suggested-by: Alex Bennée > Signed-off-by: Richard Henderson > --- > > This sits in the middle of my "Clean up code_gen_buffer allocation" > patch set. Alex mentioned it during review, and I had already made > the change. > > This is the only patch in the set

Re: [PATCH] qemu-{img,nbd}: Don't report zeroed cluster as a hole

2021-06-11 Thread Vladimir Sementsov-Ogievskiy
11.06.2021 12:05, Nir Soffer wrote: ‫ב-11 ביוני 2021, בשעה 11:14, ‏‏Vladimir Sementsov-Ogievskiy ‏ כתב/ה:‬ 11.06.2021 11:09, Kevin Wolf wrote: Am 10.06.2021 um 22:46 hat Eric Blake geschrieben: On Thu, Jun 10, 2021 at 11:09:05PM +0300, Nir Soffer wrote: But: $ qemu-img map

Re: [PATCH v2] async: the main AioContext is only "current" if under the BQL

2021-06-11 Thread Paolo Bonzini
On 09/06/21 17:01, Vladimir Sementsov-Ogievskiy wrote: 09.06.2021 15:22, Paolo Bonzini wrote: If we want to wake up a coroutine from a worker thread, aio_co_wake() currently does not work.  In that scenario, aio_co_wake() calls aio_co_enter(), but there is no current AioContext and therefore

Re: [PATCH v2] async: the main AioContext is only "current" if under the BQL

2021-06-11 Thread Paolo Bonzini
On 09/06/21 15:02, Kevin Wolf wrote: Am 09.06.2021 um 14:22 hat Paolo Bonzini geschrieben: If we want to wake up a coroutine from a worker thread, aio_co_wake() currently does not work. In that scenario, aio_co_wake() calls aio_co_enter(), but there is no current AioContext and therefore

Re: [PATCH] util/oslib-win32: Fix fatal assertion in qemu_try_memalign

2021-06-11 Thread Stefan Weil
Am 11.06.21 um 13:06 schrieb Philippe Mathieu-Daudé: On 6/11/21 12:58 PM, Stefan Weil wrote: The function is called with alignment == 0 which caused an assertion. Use the code from oslib_posix.c to fix that regression (introduced by commit ed6f53f9ca9). Oops. Can we replace '(introduced by

Re: QEMU | USB Ethernet device (RNDIS) does not work on several tested operating systems (#198)

2021-06-11 Thread Philippe Mathieu-Daudé
Cc'ing Paul Zimmerman for the hcd-dwc2 model. On Thu, Jun 10, 2021 at 2:10 PM programmingkidx (@programmingkidx) wrote: > 虎游 commented: > > The same problem occurred in my Raspberry Pi 3b+ emulation. > > Host: Debian 10 x86_64. Guest rootfs: >

Re: [PATCH] util/oslib-win32: Fix fatal assertion in qemu_try_memalign

2021-06-11 Thread Philippe Mathieu-Daudé
On 6/11/21 12:58 PM, Stefan Weil wrote: > The function is called with alignment == 0 which caused an assertion. > Use the code from oslib_posix.c to fix that regression (introduced > by commit ed6f53f9ca9). > Oops. Can we replace '(introduced by commit ed6f53f9ca9)' by: Fixes: ed6f53f9ca9

Re: [PATCH v6 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

2021-06-11 Thread Alex Bennée
Cleber Rosa Junior writes: > On Tue, Jun 8, 2021 at 2:30 AM Philippe Mathieu-Daudé wrote: > > Hi Alex, Stefan, > > On 6/8/21 5:14 AM, Cleber Rosa wrote: > > The QEMU project has two machines (aarch64 and s390x) that can be used > > for jobs that do build and run tests. > > > Who has

[PATCH] util/oslib-win32: Fix fatal assertion in qemu_try_memalign

2021-06-11 Thread Stefan Weil
The function is called with alignment == 0 which caused an assertion. Use the code from oslib_posix.c to fix that regression (introduced by commit ed6f53f9ca9). Signed-off-by: Stefan Weil --- util/oslib-win32.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v6 2/4] Jobs based on custom runners: build environment docs and playbook

2021-06-11 Thread Alex Bennée
Cleber Rosa Junior writes: > On Wed, Jun 9, 2021 at 11:26 AM Alex Bennée wrote: > > Cleber Rosa Junior writes: > > > On Wed, Jun 9, 2021 at 9:36 AM Alex Bennée wrote: > > > > Cleber Rosa writes: > > > > > To run basic jobs on custom runners, the environment needs to be > > >

Re: [PATCH 1/1] vfio-ccw: Keep passthrough sense data intact

2021-06-11 Thread Cornelia Huck
On Fri, Jun 11 2021, Cornelia Huck wrote: > On Thu, Jun 10 2021, Eric Farman wrote: >> diff --git a/hw/s390x/css.c b/hw/s390x/css.c >> index bed46f5ec3..29234daa27 100644 >> --- a/hw/s390x/css.c >> +++ b/hw/s390x/css.c >> @@ -1661,7 +1661,8 @@ int css_do_tsch_get_irb(SubchDev *sch, IRB >>

Re: [PATCH v8 02/12] accel: Introduce 'query-accels' QMP command

2021-06-11 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Introduce the 'query-accels' QMP command which returns a list > of built-in accelerator names. > > - Accelerator is a QAPI enum of all existing accelerators, > > - AcceleratorInfo is a QAPI structure providing accelerator > specific information. Currently the

Re: [PATCH V7 1/6] qapi/net: Add IPFlowSpec and QMP command for COLO passthrough

2021-06-11 Thread Markus Armbruster
"Zhang, Chen" writes: >> -Original Message- >> From: Eric Blake >> Sent: Friday, June 4, 2021 10:35 PM >> To: Zhang, Chen >> Cc: Jason Wang ; qemu-dev > de...@nongnu.org>; Dr. David Alan Gilbert ; Markus >> Armbruster ; Daniel P. Berrangé >> ; Gerd Hoffmann ; Li Zhijian >> ; Zhang Chen

Re: [RFC PATCH 08/11] target/riscv: Update CSR xnxti in CLIC mode

2021-06-11 Thread LIU Zhiwei
On 6/11/21 5:07 PM, Frank Chang wrote: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年6月11日 週五 下午4:56寫道: On 6/11/21 4:42 PM, Frank Chang wrote: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年6月11日 週五 下午4:30寫道: On 6/11/21 4:15 PM, Frank Chang wrote: LIU

Re: iotest 233 failing

2021-06-11 Thread Daniel P . Berrangé
On Thu, Jun 10, 2021 at 10:33:40PM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 10, 2021 at 10:31:14PM +0100, Daniel P. Berrangé wrote: > > On Thu, Jun 10, 2021 at 03:34:46PM -0500, Eric Blake wrote: > > > I'm now getting failures on iotest 233: > > > > > > 233 fail [15:26:01]

Re: [RFC PATCH 08/11] target/riscv: Update CSR xnxti in CLIC mode

2021-06-11 Thread Frank Chang
LIU Zhiwei 於 2021年6月11日 週五 下午4:56寫道: > > On 6/11/21 4:42 PM, Frank Chang wrote: > > LIU Zhiwei 於 2021年6月11日 週五 下午4:30寫道: > >> >> On 6/11/21 4:15 PM, Frank Chang wrote: >> >> LIU Zhiwei 於 2021年4月9日 週五 下午3:52寫道: >> >>> The CSR can be used by software to service the next horizontal interrupt >>>

Re: [PATCH] qemu-{img,nbd}: Don't report zeroed cluster as a hole

2021-06-11 Thread Nir Soffer
> ‫ב-11 ביוני 2021, בשעה 11:14, ‏‏Vladimir Sementsov-Ogievskiy > ‏ כתב/ה:‬ > > 11.06.2021 11:09, Kevin Wolf wrote: >> Am 10.06.2021 um 22:46 hat Eric Blake geschrieben: On Thu, Jun 10, 2021 at 11:09:05PM +0300, Nir Soffer wrote: >> But: >> >> $ qemu-img map --output=json -f

Re: [RFC PATCH 08/11] target/riscv: Update CSR xnxti in CLIC mode

2021-06-11 Thread LIU Zhiwei
On 6/11/21 4:42 PM, Frank Chang wrote: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年6月11日 週五 下午4:30寫道: On 6/11/21 4:15 PM, Frank Chang wrote: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年4月9日 週五 下午3:52寫道: The CSR can be used by software to service the next

Re: [PATCH 3/4] target/riscv: Implement AIA local interrupt CSRs

2021-06-11 Thread Alistair Francis
On Fri, Jun 11, 2021 at 3:04 PM Anup Patel wrote: > > On Fri, Jun 11, 2021 at 4:49 AM Alistair Francis wrote: > > > > On Sat, May 15, 2021 at 12:34 AM Anup Patel wrote: > > > > > > We implement various AIA local interrupt CSRs for M-mode, HS-mode, > > > and VS-mode. > > > > > > Signed-off-by:

Re: [RFC PATCH 08/11] target/riscv: Update CSR xnxti in CLIC mode

2021-06-11 Thread Frank Chang
LIU Zhiwei 於 2021年6月11日 週五 下午4:30寫道: > > On 6/11/21 4:15 PM, Frank Chang wrote: > > LIU Zhiwei 於 2021年4月9日 週五 下午3:52寫道: > >> The CSR can be used by software to service the next horizontal interrupt >> when it has greater level than the saved interrupt context >> (held in xcause`.pil`) and

Re: [PATCH 0/4] AIA local interrupt CSR support

2021-06-11 Thread Alistair Francis
On Fri, Jun 11, 2021 at 4:48 PM Anup Patel wrote: > > Hi Alistair, > > On Fri, May 14, 2021 at 8:03 PM Anup Patel wrote: > > > > The advanced interrupt architecture (AIA) extends the per-HART local > > interrupt support. Along with this, it also adds IMSIC (MSI contrllor) > > and Advanced PLIC

Re: [PATCH v4 6/8] hw/intc: GICv3 redistributor ITS processing

2021-06-11 Thread Peter Maydell
On Fri, 11 Jun 2021 at 00:39, Shashi Mallela wrote: > > Have addressed all comments except the ones with responses(inline) below:- > > On Jun 8 2021, at 9:57 am, Peter Maydell wrote: > > > + cs->lpivalid = false; > > + cs->hpplpi.prio = 0xff; > > + gicv3_redist_update_lpi(cs); > > You can avoid

Re: [RFC PATCH 08/11] target/riscv: Update CSR xnxti in CLIC mode

2021-06-11 Thread LIU Zhiwei
On 6/11/21 4:15 PM, Frank Chang wrote: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年4月9日 週五 下午3:52寫道: The CSR can be used by software to service the next horizontal interrupt when it has greater level than the saved interrupt context (held in xcause`.pil`) and greater level

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-11 Thread Gerd Hoffmann
On Fri, Jun 11, 2021 at 09:35:42AM +0200, Paolo Bonzini wrote: > On 10/06/21 15:12, Claudio Fontana wrote: > > The difficulty is that accelerator code is going to be split across a > > large number of directories. We basically have to define the source sets at the toplevel meson.build file, then

Re: [PATCH] qemu-img: Use "depth":-1 to make backing probes obvious

2021-06-11 Thread Vladimir Sementsov-Ogievskiy
11.06.2021 11:08, Vladimir Sementsov-Ogievskiy wrote: 11.06.2021 00:39, Eric Blake wrote: The recently-added NBD context qemu:allocation-depth makes an obvious case for why it is important to distinguish between locally-present data (even with that data is sparse) [shown as depth 1 over NBD],

Re: [RFC PATCH 08/11] target/riscv: Update CSR xnxti in CLIC mode

2021-06-11 Thread Frank Chang
LIU Zhiwei 於 2021年4月9日 週五 下午3:52寫道: > The CSR can be used by software to service the next horizontal interrupt > when it has greater level than the saved interrupt context > (held in xcause`.pil`) and greater level than the interrupt threshold of > the corresponding privilege mode, > >

Re: [PATCH] qemu-{img,nbd}: Don't report zeroed cluster as a hole

2021-06-11 Thread Vladimir Sementsov-Ogievskiy
11.06.2021 11:09, Kevin Wolf wrote: Am 10.06.2021 um 22:46 hat Eric Blake geschrieben: On Thu, Jun 10, 2021 at 11:09:05PM +0300, Nir Soffer wrote: But: $ qemu-img map --output=json -f qcow2 json:'{"driver":"qcow2","backing":null, \ "file":{"driver":"file","filename":"top.qcow2"}}' [{

Re: [PATCH] qemu-{img,nbd}: Don't report zeroed cluster as a hole

2021-06-11 Thread Kevin Wolf
Am 10.06.2021 um 22:46 hat Eric Blake geschrieben: > On Thu, Jun 10, 2021 at 11:09:05PM +0300, Nir Soffer wrote: > > > But: > > > > > > $ qemu-img map --output=json -f qcow2 > > > json:'{"driver":"qcow2","backing":null, \ > > > "file":{"driver":"file","filename":"top.qcow2"}}' > > > [{ "start":

Re: [PATCH] qemu-img: Use "depth":-1 to make backing probes obvious

2021-06-11 Thread Vladimir Sementsov-Ogievskiy
11.06.2021 00:39, Eric Blake wrote: The recently-added NBD context qemu:allocation-depth makes an obvious case for why it is important to distinguish between locally-present data (even with that data is sparse) [shown as depth 1 over NBD], and data that could not be found anywhere in the backing

Re: [RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions

2021-06-11 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 6/10/21 1:06 PM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> On 6/10/21 11:33 AM, Markus Armbruster wrote: Eric Blake writes: > On Wed, Jun 09, 2021 at 08:49:54PM +0200, Philippe Mathieu-Daudé wrote: >> In case we

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-11 Thread Paolo Bonzini
On 10/06/21 15:12, Claudio Fontana wrote: The difficulty is that accelerator code is going to be split across a large number of directories. It should be possible to use a sourceset per target; just like there is target_arch, target_softmmu_arch, target_user_arch we can add

Re: [PATCH 1/1] hw: virt: consider hw_compat_6_0

2021-06-11 Thread Cornelia Huck
On Thu, Jun 10 2021, Heinrich Schuchardt wrote: > virt-6.0 must consider hw_compat_6_0. > > Signed-off-by: Heinrich Schuchardt > --- > hw/arm/virt.c | 2 ++ > 1 file changed, 2 insertions(+) Oops, forgot that hunk. Fixes: da7e13c00b59 ("hw: add compat machines for 6.1") Reviewed-by:

Re: [PATCH 1/1] vfio-ccw: Keep passthrough sense data intact

2021-06-11 Thread Cornelia Huck
On Thu, Jun 10 2021, Eric Farman wrote: > For virtual devices, there is space for sense data to be built > and later copied into the IRB's ECW space once a TSCH is handled. > > For passthrough devices, the IRB is passed up from hardware. > There might already be sense data in the ECW, in which

Re: [PATCH 0/1] vfio-ccw: Fix garbage sense data on I/O error

2021-06-11 Thread Cornelia Huck
On Thu, Jun 10 2021, Eric Farman wrote: > Hi Conny, > > Per our offline discussion, here's a fix for the error when a guest > issues "dasdfmt -M quick". It basically reverts commit 334e76850bbb > ("vfio/ccw: update sense data if a unit check is pending") > and modifies the check that builds

Re: [PATCH 1/3] qga-win: Increase VSS freeze timeout to 60 secs instead of 10

2021-06-11 Thread Konstantin Kostiuk
ping On Mon, Apr 5, 2021 at 4:14 PM Basil Salman wrote: > Currently Requester freeze times out after 10 seconds, while > the default timeout for Writer Freeze is 60 seconds. according to > VSS Documentation [1]. > [1]: >

Re: [PATCH 0/4] AIA local interrupt CSR support

2021-06-11 Thread Anup Patel
Hi Alistair, On Fri, May 14, 2021 at 8:03 PM Anup Patel wrote: > > The advanced interrupt architecture (AIA) extends the per-HART local > interrupt support. Along with this, it also adds IMSIC (MSI contrllor) > and Advanced PLIC (wired interrupt controller). > > The latest AIA draft

[Bug 391880] Re: migrate exec hangs for several minutes if the pipe is closed before all its data is written

2021-06-11 Thread Thomas Huth
*** This bug is a duplicate of bug 391879 *** https://bugs.launchpad.net/bugs/391879 ** No longer affects: qemu -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/391880 Title: migrate exec hangs

[PULL 11/12] Add the function of colo_compare_cleanup

2021-06-11 Thread Jason Wang
From: "Rao, Lei" This patch fixes the following: #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 #1 0x7f6ae4559859 in __GI_abort () at abort.c:79 #2 0x559aaa386720 in error_exit (err=16, msg=0x559aaa5973d0 <__func__.16227> "qemu_mutex_destroy") at

[PULL 12/12] Fixed calculation error of pkt->header_size in fill_pkt_tcp_info()

2021-06-11 Thread Jason Wang
From: "Rao, Lei" The data pointer has skipped vnet_hdr_len in the function of parse_packet_early().So, we can not subtract vnet_hdr_len again when calculating pkt->header_size in fill_pkt_tcp_info(). Otherwise, it will cause network packet comparsion errors and greatly increase the frequency of

[PULL 08/12] Optimize the function of filter_send

2021-06-11 Thread Jason Wang
From: "Rao, Lei" The iov_size has been calculated in filter_send(). we can directly return the size.In this way, this is no need to repeat calculations in filter_redirector_receive_iov(); Signed-off-by: Lei Rao Reviewed-by: Li Zhijian Reviewed-by: Zhang Chen Reviewed-by: Lukas Straub

[PULL 06/12] Remove some duplicate trace code.

2021-06-11 Thread Jason Wang
From: "Rao, Lei" There is the same trace code in the colo_compare_packet_payload. Signed-off-by: Lei Rao Reviewed-by: Li Zhijian Reviewed-by: Zhang Chen Reviewed-by: Lukas Straub Tested-by: Lukas Straub Signed-off-by: Zhang Chen Signed-off-by: Jason Wang --- net/colo-compare.c | 13

<    1   2   3   >