Re: [PATCH v4 0/4] avocado-qemu: New SMMUv3 and intel IOMMU tests

2021-06-29 Thread Eric Auger
Hi William, On 6/29/21 10:38 PM, Willian Rampazzo wrote: > On Tue, Jun 29, 2021 at 5:17 PM Eric Auger wrote: >> Hi Cleber, all, >> >> On 6/29/21 4:36 PM, Eric Auger wrote: >>> This series adds ARM SMMU and Intel IOMMU functional >>> tests using Fedora cloud-init images. >>> >>> ARM SMMU tests fea

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-29 Thread wangyanan (Y)
Hi Drew, Igor, I have a question below, hope for some explanation... :) I'm trying to rearrange the smp_parse() helper to make it more scalable. But I wonder why we are currently using maxcpus to calculate the missing sockets while using *cpus* to calculate the missing cores and threads? This m

Re: [PATCH 19/53] acpi: add helper routines to initialize ACPI tables

2021-06-29 Thread Igor Mammedov
On Tue, 29 Jun 2021 15:16:42 -0400 "Michael S. Tsirkin" wrote: > On Fri, Jun 25, 2021 at 05:17:44AM -0400, Igor Mammedov wrote: > >acpi_init_table(): > > initializes table header and keeps track of > > table data/offsets > >acpi_table_composed(): > > sets actual table le

[PATCH v2 1/2] hw/i386/pc: pc_system_ovmf_table_find: Assert that flash was parsed

2021-06-29 Thread Dov Murik
Add assertion in pc_system_ovmf_table_find that verifies that the flash was indeed previously parsed (looking for the OVMF table) by pc_system_parse_ovmf_flash. Now pc_system_ovmf_table_find distinguishes between "no one called pc_system_parse_ovmf_flash" (which will abort due to assertion failure

[PATCH v2 0/2] hw/i386/pc: Clarify pc_system_ovmf_table_find usage

2021-06-29 Thread Dov Murik
Add assertion to verify that the flash was parsed (looking for the OVMF table), and add documentation for pc_system_ovmf_table_find. Dov Murik (2): hw/i386/pc: pc_system_ovmf_table_find: Assert that flash was parsed hw/i386/pc: Document pc_system_ovmf_table_find hw/i386/pc_sysfw.c | 18 +

[PATCH v2 2/2] hw/i386/pc: Document pc_system_ovmf_table_find

2021-06-29 Thread Dov Murik
Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Dov Murik Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/pc_sysfw.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/i386/pc_sysfw.c b/hw/i386/pc_sysfw.c index 9eac36b830..d02f1b2361 100644 --- a/hw/i386/pc_sysfw.c +++ b/hw

Re: [RFC PATCH 03/11] hw/intc: Add CLIC device

2021-06-29 Thread Frank Chang
LIU Zhiwei 於 2021年6月29日 週二 上午10:45寫道: > Hi Frank, > > Thanks for a lot of good points. > On 2021/6/26 下午11:03, Frank Chang wrote: > > LIU Zhiwei 於 2021年4月9日 週五 下午3:57寫道: > >> +static uint8_t >> +riscv_clic_get_interrupt_level(RISCVCLICState *clic, uint8_t intctl) >> +{ >> +int nlbits = clic-

[Bug 1826401] Re: qemu-system-aarch64 has a high cpu usage on windows

2021-06-29 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1826401 Title: qemu-system

[Bug 1793635] Re: Using pflash with u-boot, when CONFIG_SYS_FLASH_USE_BUFFER_WRITE were defined, envirment args won't be able to save correctly

2021-06-29 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1793635 Title: Using pflas

[Bug 1827005] Re: hvf: ubuntu iso boot menu issue

2021-06-29 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1827005 Title: hvf: ubuntu

[Bug 1923693] Re: Lack of architecture in gdbstub makes debugging confusing

2021-06-29 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1923693 Title: Lack of arc

[PATCH v5 0/3] Fuzzer pattern-matching, timeouts, and instrumentation-filtering

2021-06-29 Thread Alexander Bulekov
v5: - Fix a name collision in 3/3, between "GString *pattern" and the struct pattern type, which lead to some bad heap problems during fuzzing v4: - Instead of changing the patterns in the AC97 and ES1370 configs, make the type/name pattern matching case-insensitive. -

[PATCH v5 3/3] fuzz: make object-name matching case-insensitive

2021-06-29 Thread Alexander Bulekov
We have some configs for devices such as the AC97 and ES1370 that were not matching memory-regions correctly, because the configs provided lowercase names. To resolve these problems and prevent them from occurring again in the future, convert both the pattern and names to lower-case, prior to check

[PATCH v5 2/3] fuzz: add an instrumentation filter

2021-06-29 Thread Alexander Bulekov
By default, -fsanitize=fuzzer instruments all code with coverage information. However, this means that libfuzzer will track coverage over hundreds of source files that are unrelated to virtual-devices. This means that libfuzzer will optimize inputs for coverage observed in timer code, memory APIs e

[PATCH v5 1/3] fuzz: adjust timeout to allow for longer inputs

2021-06-29 Thread Alexander Bulekov
Using a custom timeout is useful to continue fuzzing complex devices, even after we run into some slow code-path. However, simply adding a fixed timeout to each input effectively caps the maximum input length/number of operations at some artificial value. There are two major problems with this: 1.

Re: [PATCH] tests/vm: update NetBSD to 9.2

2021-06-29 Thread Brad Smith
ping. On 6/3/2021 3:19 AM, Gerd Hoffmann wrote: On Wed, Jun 02, 2021 at 01:21:49PM -0400, Brad Smith wrote: tests/vm: update NetBSD to 9.2 Signed-off-by: Brad Smith Tested-by: Gerd Hoffmann

Re: [PATCH] tests/vm: update openbsd to release 6.9

2021-06-29 Thread Brad Smith
ping. On 5/31/2021 12:55 AM, Gerd Hoffmann wrote: On Sun, May 30, 2021 at 10:01:28PM -0400, Brad Smith wrote: tests/vm: update openbsd to release 6.9 Signed-off-by: Brad Smith Tested-by: Gerd Hoffmann

Re: [PATCH 20/20] target/loongarch: Add linux-user emulation support

2021-06-29 Thread Song Gao
Hi, Peter, On 06/29/2021 09:42 PM, Peter Maydell wrote: > On Mon, 28 Jun 2021 at 13:05, Song Gao wrote: >> >> Add files to linux-user/loongarch64 >> Add file to default-configs >> Add loongarch to target/meson.build >> >> Signed-off-by: Song Gao >> --- >> MAINTAINERS

Re: [PATCH 20/20] target/loongarch: Add linux-user emulation support

2021-06-29 Thread maobibo
在 2021年06月29日 21:42, Peter Maydell 写道: > On Mon, 28 Jun 2021 at 13:05, Song Gao wrote: >> >> Add files to linux-user/loongarch64 >> Add file to default-configs >> Add loongarch to target/meson.build >> >> Signed-off-by: Song Gao >> --- >> MAINTAINERS|

Re: [question] Shall we flush ITS tables into guest RAM when shutdown the VM?

2021-06-29 Thread Kunkun Jiang
On 2021/6/30 4:14, Eric Auger wrote: Hi Kunkun, On 6/29/21 11:33 AM, Kunkun Jiang wrote: Hi all, Accroding to the patch cddafd8f353d2d251b1a5c6c948a577a85838582, our original intention is to flush the ITS tables into guest RAM at the point RUN_STATE_FINISH_MIGRATE, but sometimes the VM gets st

[PATCH v7 1/4] Jobs based on custom runners: documentation and configuration placeholder

2021-06-29 Thread Cleber Rosa
As described in the included documentation, the "custom runner" jobs extend the GitLab CI jobs already in place. One of their primary goals of catching and preventing regressions on a wider number of host systems than the ones provided by GitLab's shared runners. This sets the stage in which othe

[PATCH v7 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2021-06-29 Thread Cleber Rosa
To have the jobs dispatched to custom runners, gitlab-runner must be installed, active as a service and properly configured. The variables file and playbook introduced here should help with those steps. The playbook introduced here covers the Linux distributions and has been primarily tested on O

[PATCH v7 2/4] Jobs based on custom runners: build environment docs and playbook

2021-06-29 Thread Cleber Rosa
To run basic jobs on custom runners, the environment needs to be properly set up. The most common requirement is having the right packages installed. The playbook introduced here covers the QEMU's project s390x and aarch64 machines. At the time this is being proposed, those machines have already

[PATCH v7 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

2021-06-29 Thread Cleber Rosa
The QEMU project has two machines (aarch64 and s390x) that can be used for jobs that do build and run tests. This introduces those jobs, which are a mapping of custom scripts used for the same purpose. Signed-off-by: Cleber Rosa Reviewed-by: Willian Rampazzo --- .gitlab-ci.d/custom-runners.yml

[PATCH v7 0/4] GitLab Custom Runners and Jobs (was: QEMU Gating CI)

2021-06-29 Thread Cleber Rosa
TL;DR: this should allow the QEMU maintainer to push to the staging branch, and have custom jobs running on the project's aarch64 and s390x machines. Jobs in this version are allowed to fail, to allow for the inclusion of the novel machines/jobs without CI disruption. Simple usage looks like:

Re: [PATCH 01/20] target/loongarch: Add README

2021-06-29 Thread Song Gao
Hi, Peter, On 06/29/2021 07:52 PM, Peter Maydell wrote: > On Mon, 28 Jun 2021 at 13:04, Song Gao wrote: >> >> This patch give an introduction to the LoongArch target. >> >> Signed-off-by: Song Gao >> --- > >> +There are several code directories >> + >> +1 qemu/target/loongarch >> +T

Re: [PATCH 0/2] migration: Two fixes around yank and postcopy recovery

2021-06-29 Thread Leonardo Bras Soares Passos
On Tue, Jun 29, 2021 at 3:14 PM Peter Xu wrote: > > The 1st patch should fix yank with unregister instance; I think it should also > fix the issue that Leonardo used to fix in this patch: > > https://lore.kernel.org/qemu-devel/20210629050522.147057-1-leob...@redhat.com/ > > The 2nd patch fixes pos

[PATCH] target/i386: Remove split lock detect in Snowridge CPU model

2021-06-29 Thread Chenyi Qiang
At present, there's no mechanism intelligent enough to virtualize split lock detection correctly. Remove it in Snowridge CPU model to avoid the feature exposure. Signed-off-by: Chenyi Qiang --- target/i386/cpu.c | 8 1 file changed, 8 insertions(+) diff --git a/target/i386/cpu.c b/targ

Re: [PATCH 01/20] target/loongarch: Add README

2021-06-29 Thread Song Gao
Hi, Alex, On 06/29/2021 07:13 PM, Alex Bennée wrote: > > Song Gao writes: > >> This patch give an introduction to the LoongArch target. >> >> Signed-off-by: Song Gao >> --- >> MAINTAINERS | 5 + >> target/loongarch/README | 16 >> 2 files changed, 21 insertio

Re: [PATCH v6 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

2021-06-29 Thread Cleber Rosa
On Fri, Jun 11, 2021 at 7:04 AM Alex Bennée wrote: > > > Cleber Rosa Junior writes: > > > On Tue, Jun 8, 2021 at 2:30 AM Philippe Mathieu-Daudé > > wrote: > > > > Hi Alex, Stefan, > > > > On 6/8/21 5:14 AM, Cleber Rosa wrote: > > > The QEMU project has two machines (aarch64 and s390x) that c

Re: [PATCH 06/20] target/loongarch: Add main translation routines

2021-06-29 Thread Song Gao
Hi, Alex, On 06/29/2021 08:26 PM, Alex Bennée wrote: > > Song Gao writes: > >> Hi, Philippe, >> >> On 06/29/2021 02:46 AM, Philippe Mathieu-Daudé wrote: >>> On 6/28/21 2:04 PM, Song Gao wrote: This patch add main translation routines and basic functions for translation. Sign

Re: [PATCH v6 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

2021-06-29 Thread Cleber Rosa
On Thu, Jun 10, 2021 at 2:18 AM Thomas Huth wrote: > > On 08/06/2021 05.14, Cleber Rosa wrote: > > The QEMU project has two machines (aarch64 and s390x) that can be used > > for jobs that do build and run tests. This introduces those jobs, > > which are a mapping of custom scripts used for the sa

Re: [PATCH v6 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

2021-06-29 Thread Cleber Rosa
On Wed, Jun 9, 2021 at 11:09 AM Stefan Hajnoczi wrote: > > On Tue, Jun 08, 2021 at 04:07:57PM -0300, Wainer dos Santos Moschetta wrote: > > > And I understand that are a lot of them (from everyone, including > > > myself). The dilemma here is: should we activate the machines already > > > availab

Re: [PATCH v6 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

2021-06-29 Thread Cleber Rosa
On Wed, Jun 9, 2021 at 10:55 AM Stefan Hajnoczi wrote: > > On Tue, Jun 08, 2021 at 09:36:37AM -0400, Cleber Rosa Junior wrote: > > On Tue, Jun 8, 2021 at 2:30 AM Philippe Mathieu-Daudé > > wrote: > > Here are my thoughts. It's just my opinion based on experience running > the old QEMU Buildbot in

Re: [PATCH v6 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

2021-06-29 Thread Cleber Rosa
On Tue, Jun 8, 2021 at 2:27 PM Wainer dos Santos Moschetta wrote: > > Hi, > > On 6/8/21 12:14 AM, Cleber Rosa wrote: > > The QEMU project has two machines (aarch64 and s390x) that can be used > > for jobs that do build and run tests. This introduces those jobs, > > which are a mapping of custom s

Re: [PATCH v6 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2021-06-29 Thread Cleber Rosa
On Thu, Jun 10, 2021 at 2:24 AM Thomas Huth wrote: > > On 08/06/2021 05.14, Cleber Rosa wrote: > > To have the jobs dispatched to custom runners, gitlab-runner must > > be installed, active as a service and properly configured. The > > variables file and playbook introduced here should help with

Re: [PATCH v6 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2021-06-29 Thread Cleber Rosa
On Wed, Jun 9, 2021 at 1:46 PM Willian Rampazzo wrote: > > On Tue, Jun 8, 2021 at 12:14 AM Cleber Rosa wrote: > > > > To have the jobs dispatched to custom runners, gitlab-runner must > > be installed, active as a service and properly configured. The > > variables file and playbook introduced he

Re: [PATCH 0/2] migration: Two fixes around yank and postcopy recovery

2021-06-29 Thread Peter Xu
On Tue, Jun 29, 2021 at 07:38:32PM -0300, Leonardo Bras Soares Passos wrote: > > (Leo: please let me know if this series didn't fix the issue you used to > > fix) > > It does fix the issue, as far as I tested. Thanks, Leo! -- Peter Xu

Re: [PATCH v6 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2021-06-29 Thread Cleber Rosa
On Tue, Jun 8, 2021 at 3:04 PM Wainer dos Santos Moschetta wrote: > > Hi, > > On 6/8/21 12:14 AM, Cleber Rosa wrote: > > To have the jobs dispatched to custom runners, gitlab-runner must > > be installed, active as a service and properly configured. The > > variables file and playbook introduced

Re: [PATCH v6 2/4] Jobs based on custom runners: build environment docs and playbook

2021-06-29 Thread Cleber Rosa
On 6/10/21 4:13 AM, Erik Skultety wrote: ... On a freshly installed Ubuntu 20.04, the script failed for me with dependency messages on the apt side. After I updated the packages on the system, the playbook worked without problems. So, my suggestion is to add the "update = yes" here, or add a

Re: [PATCH v6 2/4] Jobs based on custom runners: build environment docs and playbook

2021-06-29 Thread Cleber Rosa
On 6/9/21 1:16 PM, Willian Rampazzo wrote: On Tue, Jun 8, 2021 at 12:14 AM Cleber Rosa wrote: To run basic jobs on custom runners, the environment needs to be properly set up. The most common requirement is having the right packages installed. The playbook introduced here covers the QEMU's

[PATCH v3 11/15] python: add 'make check-dev' invocation

2021-06-29 Thread John Snow
This is a *third* way to run the Python tests. Unlike the first two (check-pipenv, check-tox), this version does not require any specific interpreter version -- making it a lot easier to tell people to run it as a quick smoketest prior to submission to GitLab CI. Summary: Checked via GitLab CI:

[PATCH v3 15/15] python: Fix broken ReST docstrings

2021-06-29 Thread John Snow
This patch *doesn't* update all of the docstring standards across the QEMU package directory to make our docstring usage consistent. It *doesn't* fix the formatting to make it look pretty or reasonable in generated output. It *does* fix a few small instances where Sphinx would emit a build warning

[PATCH v3 13/15] python: Update help text on 'make clean', 'make distclean'

2021-06-29 Thread John Snow
Update for visual parity with all the remaining targets. Signed-off-by: John Snow Reviewed-by: Willian Rampazzo Reviewed-by: Wainer dos Santos Moschetta --- python/Makefile | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/python/Makefile b/python/Makefile index a

[PATCH v3 10/15] python: only check qemu/ subdir with flake8

2021-06-29 Thread John Snow
flake8 is a little eager to check everything it can. Limit it to checking inside the qemu namespace directory only. Update setup.cfg now that the exclude patterns are no longer necessary. Signed-off-by: John Snow --- python/setup.cfg | 2 -- python/tests/flake8.sh | 2 +- 2 files changed,

[PATCH v3 07/15] python: rename 'venv-check' target to 'check-pipenv'

2021-06-29 Thread John Snow
Well, Cleber was right, this is a better name. In preparation for adding a different kind of virtual environment check (One that simply uses whichever version of Python you happen to have), rename this test 'check-pipenv' so that it matches the CI job 'check-python-pipenv'. Remove the "If you don

[PATCH v3 14/15] python: remove auto-generated pyproject.toml file

2021-06-29 Thread John Snow
For reasons that at-present escape me, pipenv insists on creating a stub pyproject.toml file. This file is a nuisance, because its mere presence changes the behavior of various tools. For instance, this stub file will cause "pip install --user -e ." to fail in spectacular fashion with misleading e

[PATCH v3 09/15] python: Fix .PHONY Make specifiers

2021-06-29 Thread John Snow
I missed the 'check-tox' target. Add that, but split the large .PHONY specifier at the top into its component pieces and move them near the targets they describe so that they're much harder to forget to update. Signed-off-by: John Snow Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Willia

[PATCH v3 06/15] python: Add no-install usage instructions

2021-06-29 Thread John Snow
It's not encouraged, but it's legitimate to want to know how to do. Signed-off-by: John Snow Reviewed-by: Willian Rampazzo Reviewed-by: Wainer dos Santos Moschetta --- python/README.rst | 28 1 file changed, 28 insertions(+) diff --git a/python/README.rst b/python

[PATCH v3 12/15] python: Update help text on 'make check', 'make develop'

2021-06-29 Thread John Snow
Update for visual parity with the other targets. Signed-off-by: John Snow Reviewed-by: Willian Rampazzo Reviewed-by: Wainer dos Santos Moschetta --- python/Makefile | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/python/Makefile b/python/Makefile index 8f8e1999c0

[PATCH v3 05/15] python: README.rst touchups

2021-06-29 Thread John Snow
Clarifying a few points; removing the reference to 'setuptools' because it isn't referenced anywhere else in this document and doesn't really provide any useful information to a Python newcomer. Adjusting the language elsewhere to be less ambiguous and have fewer run-on sentences. Signed-off-by:

[PATCH v3 03/15] python: Remove global pylint suppressions

2021-06-29 Thread John Snow
These suppressions only apply to a small handful of places. Instead of disabling them globally, disable them just in the cases where we need. The design of the machine class grew quite organically with tons of constructor and class instance variables -- there's little chance of meaningfully refacto

[PATCH v3 08/15] python: update help text for check-tox

2021-06-29 Thread John Snow
Move it up near the check-pipenv help text, and update it to suggest parity. (At the time I first added it, I wasn't sure if I would be keeping it, but I've come to appreciate it as it has actually helped uncover bugs I would not have noticed without it. It should stay.) Signed-off-by: John Snow

[PATCH v3 01/15] python/qom: Do not use 'err' name at module scope

2021-06-29 Thread John Snow
Pylint updated to 2.9.0 upstream, adding new warnings for things that re-use the 'err' variable. Luckily, this only breaks the python-check-tox job, which is allowed to fail as a warning. Signed-off-by: John Snow --- I guess that's good enough evidence that check-pipenv and check-tox both have

[PATCH v3 00/15] Python: packaging cleanups

2021-06-29 Thread John Snow
This series is a collection of touchups and small fixes to the Python packaging series that was initiated with commit ea1213b7. It fixes a small handful of annoyances and adjusts some readme files, help text, and so on. I'd like to make sure this is included prior to the 6.1 RC testing period. (A

[PATCH v3 04/15] python: Re-lock pipenv at *oldest* supported versions

2021-06-29 Thread John Snow
tox is already testing the most recent versions. Let's use pipenv to test the oldest versions we claim to support. This matches the stylistic choice to have pipenv always test our oldest supported Python version, 3.6. The effect of this is that the python-check-pipenv CI job on gitlab will now tes

[PATCH v3 02/15] python: expose typing information via PEP 561

2021-06-29 Thread John Snow
https://www.python.org/dev/peps/pep-0561/#specification Create 'py.typed' files in each subpackage that indicate to mypy that this is a typed module, so that users of any of these packages can use mypy to check their code as well. Note: Theoretically it's possible to ditch MANIFEST.in in favor of

Re: [PATCH] target/i386: Fix cpuid level for AMD

2021-06-29 Thread Babu Moger
On 6/29/21 9:06 AM, Dr. David Alan Gilbert wrote: > * zhenwei pi (pizhen...@bytedance.com) wrote: >> A AMD server typically has cpuid level 0x10(test on Rome/Milan), it >> should not be changed to 0x1f in multi-dies case. >> >> Fixes: a94e1428991 (target/i386: Add CPUID.1F generation support >>

[RFC 2/2] modules: Fix warning in module_arch documentation

2021-06-29 Thread Jose R. Ziviani
Fixes a small issue in the module_arch documentation that caused the build system to complain: module.h:127: warning: Function parameter or member 'name' not described in 'module_arch' module.h:127: warning: Excess function parameter 'arch' description in 'module_arch'

[RFC 1/2] modules: Option to build native TCG with --enable-modules

2021-06-29 Thread Jose R. Ziviani
Adds an option (--enable-tcg-builtin) to build TCG natively when --enable-modules argument is passed to the build system. It gives the opportunity to have the accelerator built-in and still take advantage of the new modular system. Signed-off-by: Jose R. Ziviani --- configure | 12 ++

[RFC 0/2] Option to build native TCG with --enable-modules

2021-06-29 Thread Jose R. Ziviani
Hello! I'm sending this simple patchset based on a patch still on review[1] just to understand if it's something that makes sense to the community. If so, I think it could be included in Gerd's patchset. Thank you! [1] https://patchwork.kernel.org/project/qemu-devel/list/?series=506379 Jose R.

Re: [PATCH v2 07/12] python: update help text for check-tox

2021-06-29 Thread John Snow
On Tue, Jun 29, 2021 at 4:25 PM Wainer dos Santos Moschetta < waine...@redhat.com> wrote: > Hi John, > > On 6/29/21 1:42 PM, John Snow wrote: > > Move it up near the check-pipenv help text, and update it to suggest > parity. > > > > (At the time I first added it, I wasn't sure if I would be keepin

Re: [PATCH v4 0/4] avocado-qemu: New SMMUv3 and intel IOMMU tests

2021-06-29 Thread Willian Rampazzo
On Tue, Jun 29, 2021 at 5:17 PM Eric Auger wrote: > > Hi Cleber, all, > > On 6/29/21 4:36 PM, Eric Auger wrote: > > This series adds ARM SMMU and Intel IOMMU functional > > tests using Fedora cloud-init images. > > > > ARM SMMU tests feature guests with and without RIL > > (range invalidation supp

Re: [PATCH v2 07/12] python: update help text for check-tox

2021-06-29 Thread Wainer dos Santos Moschetta
Hi John, On 6/29/21 1:42 PM, John Snow wrote: Move it up near the check-pipenv help text, and update it to suggest parity. (At the time I first added it, I wasn't sure if I would be keeping it, but I've come to appreciate it as it has actually helped uncover bugs I would not have noticed withou

Re: [PATCH v4 0/4] avocado-qemu: New SMMUv3 and intel IOMMU tests

2021-06-29 Thread Eric Auger
Hi Cleber, all, On 6/29/21 4:36 PM, Eric Auger wrote: > This series adds ARM SMMU and Intel IOMMU functional > tests using Fedora cloud-init images. > > ARM SMMU tests feature guests with and without RIL > (range invalidation support) using respectively fedora 33 > and 31. For each, we test the p

Re: [question] Shall we flush ITS tables into guest RAM when shutdown the VM?

2021-06-29 Thread Eric Auger
Hi Kunkun, On 6/29/21 11:33 AM, Kunkun Jiang wrote: > Hi all, > > Accroding to the patch cddafd8f353d2d251b1a5c6c948a577a85838582, > our original intention is to flush the ITS tables into guest RAM at > the point > RUN_STATE_FINISH_MIGRATE, but sometimes the VM gets stopped before > migration laun

Re: [PATCH v4 1/4] Acceptance Tests: Add default kernel params and pxeboot url to the KNOWN_DISTROS collection

2021-06-29 Thread Willian Rampazzo
On Tue, Jun 29, 2021 at 11:36 AM Eric Auger wrote: > > When running LinuxTests we may need to run the guest with > custom params. It is practical to store the pxeboot URL > and the default kernel params so that the > tests just need to fetch those and augment the kernel params. > > Signed-off-by:

[PULL 61/63] tcg/arm: Unset TCG_TARGET_HAS_MEMORY_BSWAP

2021-06-29 Thread Richard Henderson
Now that the middle-end can replicate the same tricks as tcg/arm used for optimizing bswap for signed loads and for stores, do not pretend to have these memory ops in the backend. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.h | 2 +- tcg/arm/tcg-targ

[PULL 56/63] target/arm: Improve vector REV

2021-06-29 Thread Richard Henderson
We can eliminate the requirement for a zero-extended output, because the following store will ignore any garbage high bits. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 6 ++ 1 file changed, 2 insertions(+)

Re: [PATCH 0/2] migration: Two fixes around yank and postcopy recovery

2021-06-29 Thread Peter Xu
On Tue, Jun 29, 2021 at 02:13:54PM -0400, Peter Xu wrote: > Note that the multifd zstd test may fail if run migration-test with sudo on > master (which seems to be a known issue now), and it'll still fail after these > two patches applied, however all running tests keep usual. There's an unexpecte

[PULL 55/63] target/arm: Improve REV32

2021-06-29 Thread Richard Henderson
For the sf version, we are performing two 32-bit bswaps in either half of the register. This is equivalent to performing one 64-bit bswap followed by a rotate. For the non-sf version, we can remove TCG_BSWAP_IZ and the preceding zero-extension. Reviewed-by: Peter Maydell Reviewed-by: Philippe M

[PULL 59/63] target/sh4: Improve swap.b translation

2021-06-29 Thread Richard Henderson
Remove TCG_BSWAP_IZ and the preceding zero-extension. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/sh4/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 147219759b..4dcfff81f6 100644

[PULL 60/63] target/mips: Fix gen_mxu_s32ldd_s32lddr

2021-06-29 Thread Richard Henderson
There were two bugs here: (1) the required endianness was not present in the MemOp, and (2) we were not providing a zero-extended input to the bswap as semantics required. The best fix is to fold the bswap into the memory operation, producing the desired result directly. Acked-by: Philippe Mathie

[PULL 62/63] tcg/aarch64: Unset TCG_TARGET_HAS_MEMORY_BSWAP

2021-06-29 Thread Richard Henderson
The memory bswap support in the aarch64 backend merely dates from a time when it was required. There is nothing special about the backend support that could not have been provided by the middle-end even prior to the introduction of the bswap flags. Reviewed-by: Peter Maydell Signed-off-by: Richa

[PULL 52/63] tcg: Add flags argument to tcg_gen_bswap16_*, tcg_gen_bswap32_i64

2021-06-29 Thread Richard Henderson
Implement the new semantics in the fallback expansion. Change all callers to supply the flags that keep the semantics unchanged locally. Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/tcg/tcg-op.h| 8 +-- target/arm/tra

[PULL 53/63] tcg: Make use of bswap flags in tcg_gen_qemu_ld_*

2021-06-29 Thread Richard Henderson
We can perform any required sign-extension via TCG_BSWAP_OS. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op

[PULL 58/63] target/i386: Improve bswap translation

2021-06-29 Thread Richard Henderson
Use a break instead of an ifdefed else. There's no need to move the values through s->T0. Remove TCG_BSWAP_IZ and the preceding zero-extension. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 14 -- 1 file changed, 4 insertions(+), 10 de

[PULL 50/63] tcg/tci: Support bswap flags

2021-06-29 Thread Richard Henderson
The existing interpreter zero-extends, ignoring high bits. Simply add a separate sign-extension opcode if required. Ensure that the interpreter supports ext16s when bswap16 is enabled. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/tci.c| 3 ++- tc

[PULL 54/63] tcg: Make use of bswap flags in tcg_gen_qemu_st_*

2021-06-29 Thread Richard Henderson
By removing TCG_BSWAP_IZ we indicate that the input is not zero-extended, and thus can remove an explicit extend. By removing TCG_BSWAP_OZ, we allow the implementation to leave high bits set, which will be ignored by the store. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg

[PULL 48/63] tcg/mips: Support bswap flags in tcg_out_bswap16

2021-06-29 Thread Richard Henderson
Merge tcg_out_bswap16 and tcg_out_bswap16s. Use the flags in the internal uses for loads and stores. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/mips/tcg-target.c.inc | 63 +++ 1 file changed, 30 insertions(+), 33 deletions(-

[PULL 46/63] tcg/ppc: Use power10 byte-reverse instructions

2021-06-29 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.c.inc | 34 ++ 1 file changed, 34 insertions(+) diff --git a/tcg/ppc/tcg-target.c.inc b/tcg/ppc/tcg-target.c.inc index 33f0139519..e0f4665213 100644 --- a/tcg/ppc/tcg-target.c.inc

[PULL 37/63] tcg/aarch64: Merge tcg_out_rev{16,32,64}

2021-06-29 Thread Richard Henderson
Pass in the input and output size. We currently use 3 of the 5 possible combinations; the others may be used by new tcg opcodes. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c.inc | 42 ++-- 1 file changed, 16 insertions

[PULL 49/63] tcg/mips: Support bswap flags in tcg_out_bswap32

2021-06-29 Thread Richard Henderson
Merge tcg_out_bswap32 and tcg_out_bswap32s. Use the flags in the internal uses for loads and stores. For mips32r2 bswap32 with zero-extension, standardize on WSBH+ROTR+DEXT. This is the same number of insns as the previous DSBH+DSHD+DSRL but fits in better with the flags check. Reviewed-by: Phil

[PULL 47/63] tcg/s390: Support bswap flags

2021-06-29 Thread Richard Henderson
For INDEX_op_bswap16_i64, use 64-bit instructions so that we can easily provide the extension to 64-bits. Drop the special case, previously used, where the input is already zero-extended -- the minor code size savings is not worth the complication. Reviewed-by: Peter Maydell Signed-off-by: Richa

[PULL 25/63] target/cris: Use tcg_gen_lookup_and_goto_ptr

2021-06-29 Thread Richard Henderson
We can use this in gen_goto_tb and for DISAS_JUMP to indirectly chain to the next TB. Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target/cris/translate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/cris/tran

[PULL 45/63] tcg/ppc: Support bswap flags

2021-06-29 Thread Richard Henderson
For INDEX_op_bswap32_i32, pass 0 for flags: input not zero-extended, output does not need extension within the host 64-bit register. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.c.inc | 22 -- 1 file changed, 16 insertions(+), 6

[PULL 44/63] tcg/ppc: Split out tcg_out_bswap64

2021-06-29 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.c.inc | 64 +--- 1 file changed, 34 insertions(+), 30 deletions(-) diff --git a/tcg/ppc/tcg-target.c.inc b/tcg/ppc/tcg-target.c.inc index 28b8671cba..da6d10722e 100644 --- a/tc

[PULL 38/63] tcg/aarch64: Support bswap flags

2021-06-29 Thread Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c.inc | 12 1 file changed, 12 insertions(+) diff --git a/tcg/aarch64/tcg-target.c.inc b/tcg/aarch64/tcg-target.c.inc index 8619e54fca..72aa7e0e74 100644 ---

[PULL 42/63] tcg/ppc: Split out tcg_out_bswap16

2021-06-29 Thread Richard Henderson
With the use of a suitable temporary, we can use the same algorithm when src overlaps dst. The result is the same number of instructions either way. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.c.inc | 34 +++--- 1 file changed,

[PULL 28/63] target/cris: Do not exit tb for X_FLAG changes

2021-06-29 Thread Richard Henderson
We always know the exact value of X, that's all that matters. This avoids splitting the TB e.g. between "ax" and "addq". Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target/cris/translate.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PULL 18/63] target/cris: Convert to TranslatorOps

2021-06-29 Thread Richard Henderson
Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target/cris/translate.c | 317 ++-- 1 file changed, 174 insertions(+), 143 deletions(-) diff --git a/target/cris/translate.c b/target/cris/translate.c index 9e1f

[PULL 41/63] tcg/ppc: Split out tcg_out_sari{32,64}

2021-06-29 Thread Richard Henderson
We will shortly require sari in other context; split out both for cleanliness sake. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.c.inc | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/tcg/ppc/tcg-target.c.inc b/tcg/ppc/

[PULL 34/63] tcg: Use correct trap number for page faults on *BSD systems

2021-06-29 Thread Richard Henderson
From: Warner Losh The trap number for a page fault on BSD systems is T_PAGEFLT not 0xe -- 0xe is used by Linux and represents the intel hardware trap vector. The BSD kernels, however, translate this to T_PAGEFLT in their Xpage, Xtrap0e, Xtrap14, etc fault handlers. This is true for i386 and x86_6

[PULL 40/63] tcg/ppc: Split out tcg_out_ext{8,16,32}s

2021-06-29 Thread Richard Henderson
We will shortly require these in other context; make the expansion as clear as possible. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.c.inc | 31 +-- 1 file changed, 21 insertions(+), 10 delet

[PULL 33/63] tcg: Implement tcg_gen_vec_add{sub}32_tl

2021-06-29 Thread Richard Henderson
From: LIU Zhiwei Signed-off-by: LIU Zhiwei Message-Id: <20210624105023.3852-6-zhiwei_...@c-sky.com> Signed-off-by: Richard Henderson --- include/tcg/tcg-op-gvec.h | 4 1 file changed, 4 insertions(+) diff --git a/include/tcg/tcg-op-gvec.h b/include/tcg/tcg-op-gvec.h index e3b274502c..da5

Re: [PATCH 19/53] acpi: add helper routines to initialize ACPI tables

2021-06-29 Thread Michael S. Tsirkin
On Fri, Jun 25, 2021 at 05:17:44AM -0400, Igor Mammedov wrote: >acpi_init_table(): > initializes table header and keeps track of > table data/offsets >acpi_table_composed(): > sets actual table length and tells bios loader > where it's for later initialization on gue

[PULL 19/63] target/cris: Mark helper_raise_exception noreturn

2021-06-29 Thread Richard Henderson
Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target/cris/helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/cris/helper.h b/target/cris/helper.h index 20d21c4358..3abf608682 100644 --- a/target/cris/helper.h ++

[PULL 31/63] tcg: Add tcg_gen_vec_shl{shr}{sar}16i_i32

2021-06-29 Thread Richard Henderson
From: LIU Zhiwei Implement tcg_gen_vec_shl{shr}{sar}16i_tl by adding corresponging i32 OP. Signed-off-by: LIU Zhiwei Message-Id: <20210624105023.3852-4-zhiwei_...@c-sky.com> Signed-off-by: Richard Henderson --- include/tcg/tcg-op-gvec.h | 10 ++ tcg/tcg-op-gvec.c | 28

[PULL 17/63] target/cris: Fix use_goto_tb

2021-06-29 Thread Richard Henderson
Do not skip the page check for user-only -- mmap/mprotect can still change page mappings. Only check dc->base.pc_first, not dc->ppc -- the start page is the only one that's relevant. Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target/cris/t

[PULL 36/63] tcg/i386: Support bswap flags

2021-06-29 Thread Richard Henderson
Retain the current rorw bswap16 expansion for the zero-in/zero-out case. Otherwise, perform a wider bswap plus a right-shift or extend. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c.inc | 20 +++- 1 file changed, 19 insertions(+), 1 deleti

  1   2   3   4   >