Re: [External] Re: [RFC v1] virtio/vsock: add two more queues for datagram types

2021-06-30 Thread Stefano Garzarella
On Wed, Jun 30, 2021 at 03:44:17PM -0700, Jiang Wang . wrote: On Thu, Jun 24, 2021 at 7:31 AM Stefano Garzarella wrote: On Wed, Jun 23, 2021 at 11:50:33PM -0700, Jiang Wang . wrote: >Hi Stefano, > >I checked virtio_net_set_multiqueue(), which will help with following >changes in my patch: > >#

Re: [PATCH 18/18] vhost-vdpa: multiqueue support

2021-06-30 Thread Eugenio Perez Martin
On Mon, Jun 21, 2021 at 6:18 AM Jason Wang wrote: > > This patch implements the multiqueue support for vhost-vdpa. This is > done simply by reading the number of queue pairs from the config space > and initialize the datapath and control path net client. > > Signed-off-by: Jason Wang > --- > hw/

Re: [PATCH 20/20] target/loongarch: Add linux-user emulation support

2021-06-30 Thread Thomas Huth
On 01/07/2021 03.07, maobibo wrote: 在 2021年06月30日 17:36, Alex Bennée 写道: maobibo writes: 在 2021年06月29日 21:42, Peter Maydell 写道: On Mon, 28 Jun 2021 at 13:05, Song Gao wrote: Add files to linux-user/loongarch64 Add file to default-configs Add loongarch to target/meson.build Signed-off-

Re: [PULL 00/25] Vga 20210510 patches

2021-06-30 Thread Marc-André Lureau
Hi On Wed, Jun 30, 2021 at 10:16 PM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi > > On Wed, May 12, 2021 at 7:07 PM Peter Maydell > wrote: > >> On Mon, 10 May 2021 at 14:22, Gerd Hoffmann wrote: >> > >> > The following changes since commit >> d90f154867ec0ec22fd719164b88716e8fd4

[PATCH] vl: add virtio-vga-gl to the default_list

2021-06-30 Thread marcandre . lureau
From: Marc-André Lureau Do not instantiate an extra default VGA device if -device virtio-vga-gl is provided. Related to commit b36eb8860f8f4a9c6f131c3fd380116a3017e022 ("virtio-gpu: add virtio-vga-gl") Signed-off-by: Marc-André Lureau --- softmmu/vl.c | 1 + 1 file changed, 1 insertion(+) di

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-30 Thread wangyanan (Y)
On 2021/6/30 19:56, Andrew Jones wrote: On Wed, Jun 30, 2021 at 05:37:42PM +0800, wangyanan (Y) wrote: On 2021/6/30 16:30, Andrew Jones wrote: On Wed, Jun 30, 2021 at 02:36:31PM +0800, wangyanan (Y) wrote: Hi Drew, Igor, I have a question below, hope for some explanation... :) I'm trying to

Re: [PATCH v2 1/2] hw/i386/pc: pc_system_ovmf_table_find: Assert that flash was parsed

2021-06-30 Thread Dov Murik
On 30/06/2021 17:35, Philippe Mathieu-Daudé wrote: > On 6/30/21 3:38 PM, Tom Lendacky wrote: >> On 6/30/21 12:46 AM, Dov Murik wrote: >>> Add assertion in pc_system_ovmf_table_find that verifies that the flash >>> was indeed previously parsed (looking for the OVMF table) by >>> pc_system_parse_o

[PATCH v3 2/2] hw/i386/pc: Document pc_system_ovmf_table_find

2021-06-30 Thread Dov Murik
Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Dov Murik Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/pc_sysfw.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/i386/pc_sysfw.c b/hw/i386/pc_sysfw.c index e353f2a4e9..6ddce92a86 100644 --- a/hw/i386/pc_sysfw.c +++ b/hw

[PATCH v3 1/2] hw/i386/pc: pc_system_ovmf_table_find: Assert that flash was parsed

2021-06-30 Thread Dov Murik
Add assertion in pc_system_ovmf_table_find that verifies that the flash was indeed previously parsed (looking for the OVMF table) by pc_system_parse_ovmf_flash. Now pc_system_ovmf_table_find distinguishes between "no one called pc_system_parse_ovmf_flash" (which will abort due to assertion failure

[PATCH v3 0/2] hw/i386/pc: Clarify pc_system_ovmf_table_find usage

2021-06-30 Thread Dov Murik
Add assertion to verify that the flash was parsed (looking for the OVMF table), and add documentation for pc_system_ovmf_table_find. v3: - [style] remove static initalization to 'false' v2: - add assertion (insert patch 1/2) Dov Murik (2): hw/i386/pc: pc_system_ovmf_table_find: Assert that f

Re: [RFC v6 10/13] target/s390x: use kvm_enabled() to wrap call to kvm_s390_get_hpage_1m

2021-06-30 Thread Al Cho
Hi Cornelia, Sorry for missing the reply. I think it may not be worth it, as you said it seem to be the only call site for kvm_s390_get_hpage_1m(). So I think we could keep it. Thanks, AL From: Cornelia Huck Sent: Wednesday, June 30, 2021 11:21 PM To

Re: [PATCH] hw/pci/pcie_port: Rename "enable-native-hotplug" property

2021-06-30 Thread David Gibson
On Wed, Jun 23, 2021 at 04:47:47PM +0200, Julia Suvorova wrote: > PCIE_SLOT property renamed to "native-hotplug" to be more concise > and consistent with other properties. > > Signed-off-by: Julia Suvorova > Reviewed-by: Igor Mammedov > Reviewed-by: Marcel Apfelbaum Reviewed-by: David Gibson

Re: [PATCH v5 4/7] hw/pci/pcie: Do not set HPC flag if acpihp is used

2021-06-30 Thread David Gibson
On Thu, Jun 17, 2021 at 09:07:36PM +0200, Julia Suvorova wrote: > Instead of changing the hot-plug type in _OSC register, do not > set the 'Hot-Plug Capable' flag. This way guest will choose ACPI > hot-plug if it is preferred and leave the option to use SHPC with > pcie-pci-bridge. > > The ability

Re: [PATCH v5 1/7] hw/acpi/pcihp: Enhance acpi_pcihp_disable_root_bus() to support Q35

2021-06-30 Thread David Gibson
On Thu, Jun 17, 2021 at 09:07:33PM +0200, Julia Suvorova wrote: > PCI Express does not allow hot-plug on pcie.0. Check for Q35 in > acpi_pcihp_disable_root_bus() to be able to forbid hot-plug using the > 'acpi-root-pci-hotplug' flag. > > Signed-off-by: Julia Suvorova > Reviewed-by: Igor Mammedov

Re: [PATCH v5 2/7] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35

2021-06-30 Thread David Gibson
On Thu, Jun 17, 2021 at 09:07:34PM +0200, Julia Suvorova wrote: > Implement notifications and gpe to support q35 ACPI PCI hot-plug. > Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports. > > Signed-off-by: Julia Suvorova > Reviewed-by: Igor Mammedov > Reviewed-by: Marcel Apfelbaum I don't

Re: [PATCH v5 7/7] bios-tables-test: Update golden binaries

2021-06-30 Thread David Gibson
On Thu, Jun 17, 2021 at 09:07:39PM +0200, Julia Suvorova wrote: > Add ACPI hot-plug registers to DSDT Q35 tables. > Changes in the tables: > > +Scope (_SB.PCI0) > +{ > +OperationRegion (PCST, SystemIO, 0x0CC4, 0x08) > +Field (PCST, DWordAcc, NoLock, WriteAsZeros) > +

Re: [PATCH v5 3/7] hw/acpi/ich9: Enable ACPI PCI hot-plug

2021-06-30 Thread David Gibson
On Thu, Jun 17, 2021 at 09:07:35PM +0200, Julia Suvorova wrote: > Add acpi_pcihp to ich9_pm as part of > 'acpi-pci-hotplug-with-bridge-support' option. Set default to false. > > Signed-off-by: Julia Suvorova > Reviewed-by: Igor Mammedov > Reviewed-by: Marcel Apfelbaum > --- > hw/i386/acpi-buil

RE: [PATCH] migration: Move bitmap_mutex out of migration_bitmap_clear_dirty()

2021-06-30 Thread Wang, Wei W
On Thursday, July 1, 2021 4:08 AM, Peter Xu wrote: > Taking the mutex every time for each dirty bit to clear is too slow, > especially we'll > take/release even if the dirty bit is cleared. So far it's only used to sync > with > special cases with qemu_guest_free_page_hint() against migration th

[PATCH 14/20] python/aqmp: add QMP event support

2021-06-30 Thread John Snow
This class was designed as a "mix-in" primarily so that the feature could be given its own treatment in its own python file. It gets quite a bit too long otherwise. Signed-off-by: John Snow --- Yes, the docstring is long. I recommend looking at the generated Sphinx output for that part instead

[PATCH 15/20] python/aqmp: add QMP protocol support

2021-06-30 Thread John Snow
The star of our show! Add most of the QMP protocol, sans support for actually executing commands. No problem, that happens in the next two commits. Signed-off-by: John Snow --- python/qemu/aqmp/__init__.py | 2 + python/qemu/aqmp/qmp_protocol.py | 257 +++ 2 fi

[PATCH 18/20] python/aqmp: add _raw() execution interface

2021-06-30 Thread John Snow
This is added in anticipation of wanting it for a synchronous wrapper for the iotest interface. Normally, execute() and execute_msg() both raise QMP errors in the form of Python exceptions. Many iotests expect the entire reply as-is. To reduce churn there, add a private execution interface that wi

[PATCH 17/20] python/aqmp: add execute() interfaces

2021-06-30 Thread John Snow
Add execute() and execute_msg(). _execute() is split into _issue() and _reply() halves so that hypothetical subclasses of QMP that want to support different execution paradigms can do so. I anticipate a synchronous interface may have need of separating the send/reply phases. However, I do not wis

[PATCH 13/20] python/aqmp: add well-known QMP object models

2021-06-30 Thread John Snow
The QMP spec doesn't define very many objects that are iron-clad in their format, but there are a few. This module makes it trivial to validate them without relying on an external third-party library. Signed-off-by: John Snow --- python/qemu/aqmp/models.py | 133 +

[PATCH 16/20] python/aqmp: Add message routing to QMP protocol

2021-06-30 Thread John Snow
Add the ability to handle and route messages in qmp_protocol.py. The interface for actually sending anything still isn't added until next commit. Signed-off-by: John Snow --- python/qemu/aqmp/qmp_protocol.py | 98 +++- 1 file changed, 96 insertions(+), 2 deletions(-)

[PATCH 09/20] python/aqmp: add AsyncProtocol.accept() method

2021-06-30 Thread John Snow
It's a little messier than connect, because it wasn't designed to accept *precisely one* connection. Such is life. Signed-off-by: John Snow --- python/qemu/aqmp/protocol.py | 85 ++-- 1 file changed, 82 insertions(+), 3 deletions(-) diff --git a/python/qemu/aqmp/

[PATCH 12/20] python/aqmp: add QMP Message format

2021-06-30 Thread John Snow
The Message class is here primarily to serve as a solid type to use for mypy static typing for unambiguous annotation and documentation. We can also stuff JSON serialization and deserialization into this class itself so it can be re-used even outside this infrastructure. Signed-off-by: John Snow

[PATCH 20/20] python/aqmp: add scary message

2021-06-30 Thread John Snow
Add a warning whenever AQMP is used to steer people gently away from using it for the time-being. Signed-off-by: John Snow --- python/qemu/aqmp/__init__.py | 14 ++ 1 file changed, 14 insertions(+) diff --git a/python/qemu/aqmp/__init__.py b/python/qemu/aqmp/__init__.py index 5cd7df

[PATCH 10/20] python/aqmp: add _cb_inbound and _cb_inbound logging hooks

2021-06-30 Thread John Snow
Add hooks designed to log/filter incoming/outgoing messages. The primary intent for these is to be able to support iotests which may want to log messages with specific filters for reproducible output. Another use is for plugging into Urwid frameworks; all messages in/out can be automatically added

[PATCH 07/20] python/aqmp: add runstate state machine to AsyncProtocol

2021-06-30 Thread John Snow
This serves a few purposes: 1. Protect interfaces when it's not safe to call them (via @require) 2. Add an interface by which an async client can determine if the state has changed, for the purposes of connection management. Signed-off-by: John Snow --- python/qemu/aqmp/__init__.py | 5 +- p

[PATCH 19/20] python/aqmp: add asyncio_run compatibility wrapper

2021-06-30 Thread John Snow
Merely as a convenience for users stuck on Python 3.6. It isn't used by the library itself. Signed-off-by: John Snow --- python/qemu/aqmp/util.py | 20 1 file changed, 20 insertions(+) diff --git a/python/qemu/aqmp/util.py b/python/qemu/aqmp/util.py index 2311be5893..356323

[PATCH 11/20] python/aqmp: add AsyncProtocol._readline() method

2021-06-30 Thread John Snow
This is added as a courtesy: many protocols are line-based, including QMP. Putting it in AsyncProtocol lets us keep the QMP class implementation just a pinch more abstract. (And, if we decide to add a QTEST implementation later, it will need this, too. (Yes, I have a QTEST implementation.)) Signe

[PATCH 01/20] python/pylint: Add exception for TypeVar names ('T')

2021-06-30 Thread John Snow
'T' is a common TypeVar name, allow its use. See also https://github.com/PyCQA/pylint/issues/3401 -- In the future, we might be able to have a separate list of acceptable names for TypeVars exclusively. Signed-off-by: John Snow --- python/setup.cfg | 1 + 1 file changed, 1 insertion(+) diff --

[PATCH 03/20] python/aqmp: add asynchronous QMP (AQMP) subpackage

2021-06-30 Thread John Snow
For now, it's empty! Soon, it won't be. Signed-off-by: John Snow --- python/qemu/aqmp/__init__.py | 27 +++ python/qemu/aqmp/py.typed| 0 python/setup.cfg | 1 + 3 files changed, 28 insertions(+) create mode 100644 python/qemu/aqmp/__init__.py create m

[PATCH 06/20] python/aqmp: add generic async message-based protocol support

2021-06-30 Thread John Snow
This is the bare minimum that you need to establish a full-duplex async message-based protocol with Python's asyncio. The features to be added in forthcoming commits are: - Runstate tracking - Logging - Support for incoming connections via accept() - _cb_outbound, _cb_inbound message hooks - _rea

[PATCH 02/20] python/pylint: disable too-many-function-args

2021-06-30 Thread John Snow
too-many-function-args seems prone to failure when considering things like Method Resolution Order, which mypy gets correct. When dealing with multiple inheritance, pylint doesn't seem to understand which method will actually get called, while mypy does. Remove the less powerful, redundant check.

[PATCH 05/20] python/aqmp: add asyncio compatibility wrappers

2021-06-30 Thread John Snow
Python 3.6 does not have all of the goodies that Python 3.7 does, and I need to support both. Add some compatibility wrappers needed for this purpose. (Note: Python 3.6 is EOL December 2021.) Signed-off-by: John Snow --- python/qemu/aqmp/util.py | 77 1

[PATCH 08/20] python/aqmp: add logging to AsyncProtocol

2021-06-30 Thread John Snow
Give the connection and the reader/writer tasks nicknames, and add logging statements throughout. Signed-off-by: John Snow --- python/qemu/aqmp/protocol.py | 64 python/qemu/aqmp/util.py | 32 ++ 2 files changed, 90 insertions(+), 6 deleti

[PATCH 04/20] python/aqmp: add error classes

2021-06-30 Thread John Snow
Signed-off-by: John Snow --- python/qemu/aqmp/__init__.py | 7 +++ python/qemu/aqmp/error.py| 97 2 files changed, 104 insertions(+) create mode 100644 python/qemu/aqmp/error.py diff --git a/python/qemu/aqmp/__init__.py b/python/qemu/aqmp/__init__.py in

[PATCH 00/20] python: introduce Asynchronous QMP package

2021-06-30 Thread John Snow
GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-async-qmp-aqmp CI: https://gitlab.com/jsnow/qemu/-/pipelines/330003554 Docs: https://people.redhat.com/~jsnow/sphinx/html/qemu.aqmp.html Based-on: <20210701020921.1679468-1-js...@redhat.com> [PULL 00/15] Python patches Hi! This patc

Re: [PATCH v3 00/37] target/riscv: support packed extension v0.9.4

2021-06-30 Thread LIU Zhiwei
On 2021/7/1 上午9:30, Alistair Francis wrote: On Thu, Jun 24, 2021 at 9:14 PM LIU Zhiwei wrote: This patchset implements the packed extension for RISC-V on QEMU. You can also find this patch set on my repo(https://github.com/romanheros/qemu.git branch:packed-upstream-v3). Features: * support

Re: [PATCH 15/18] vhost-net: control virtqueue support

2021-06-30 Thread Jason Wang
在 2021/7/1 上午1:33, Eugenio Perez Martin 写道: On Mon, Jun 21, 2021 at 6:18 AM Jason Wang wrote: We assume there's no cvq in the past, this is not true when we need control virtqueue support for vhost-user backends. So this patch implements the control virtqueue support for vhost-net. As datapat

[PULL 13/15] python: Update help text on 'make clean', 'make distclean'

2021-06-30 Thread John Snow
Update for visual parity with all the remaining targets. Signed-off-by: John Snow Reviewed-by: Willian Rampazzo Reviewed-by: Wainer dos Santos Moschetta Message-id: 20210629214323.1329806-14-js...@redhat.com Signed-off-by: John Snow --- python/Makefile | 11 +++ 1 file changed, 7 inse

[PULL 09/15] python: Fix .PHONY Make specifiers

2021-06-30 Thread John Snow
I missed the 'check-tox' target. Add that, but split the large .PHONY specifier at the top into its component pieces and move them near the targets they describe so that they're much harder to forget to update. Signed-off-by: John Snow Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Willia

[PULL 11/15] python: add 'make check-dev' invocation

2021-06-30 Thread John Snow
This is a *third* way to run the Python tests. Unlike the first two (check-pipenv, check-tox), this version does not require any specific interpreter version -- making it a lot easier to tell people to run it as a quick smoketest prior to submission to GitLab CI. Summary: Checked via GitLab CI:

[PULL 12/15] python: Update help text on 'make check', 'make develop'

2021-06-30 Thread John Snow
Update for visual parity with the other targets. Signed-off-by: John Snow Reviewed-by: Willian Rampazzo Reviewed-by: Wainer dos Santos Moschetta Message-id: 20210629214323.1329806-13-js...@redhat.com Signed-off-by: John Snow --- python/Makefile | 10 +++--- 1 file changed, 7 insertions(+)

[PULL 06/15] python: Add no-install usage instructions

2021-06-30 Thread John Snow
It's not encouraged, but it's legitimate to want to know how to do. Signed-off-by: John Snow Reviewed-by: Willian Rampazzo Reviewed-by: Wainer dos Santos Moschetta Message-id: 20210629214323.1329806-7-js...@redhat.com Signed-off-by: John Snow --- python/README.rst | 28 +++

[PULL 14/15] python: remove auto-generated pyproject.toml file

2021-06-30 Thread John Snow
For reasons that at-present escape me, pipenv insists on creating a stub pyproject.toml file. This file is a nuisance, because its mere presence changes the behavior of various tools. For instance, this stub file will cause "pip install --user -e ." to fail in spectacular fashion with misleading e

[PULL 08/15] python: update help text for check-tox

2021-06-30 Thread John Snow
Move it up near the check-pipenv help text, and update it to suggest parity. (At the time I first added it, I wasn't sure if I would be keeping it, but I've come to appreciate it as it has actually helped uncover bugs I would not have noticed without it. It should stay.) Signed-off-by: John Snow

[PULL 04/15] python: Re-lock pipenv at *oldest* supported versions

2021-06-30 Thread John Snow
tox is already testing the most recent versions. Let's use pipenv to test the oldest versions we claim to support. This matches the stylistic choice to have pipenv always test our oldest supported Python version, 3.6. The effect of this is that the python-check-pipenv CI job on gitlab will now tes

[PULL 15/15] python: Fix broken ReST docstrings

2021-06-30 Thread John Snow
This patch *doesn't* update all of the docstring standards across the QEMU package directory to make our docstring usage consistent. It *doesn't* fix the formatting to make it look pretty or reasonable in generated output. It *does* fix a few small instances where Sphinx would emit a build warning

[PULL 10/15] python: only check qemu/ subdir with flake8

2021-06-30 Thread John Snow
flake8 is a little eager to check everything it can. Limit it to checking inside the qemu namespace directory only. Update setup.cfg now that the exclude patterns are no longer necessary. Signed-off-by: John Snow Reviewed-by: Willian Rampazzo Reviewed-by: Wainer dos Santos Moschetta Tested-by:

[PULL 02/15] python: expose typing information via PEP 561

2021-06-30 Thread John Snow
https://www.python.org/dev/peps/pep-0561/#specification Create 'py.typed' files in each subpackage that indicate to mypy that this is a typed module, so that users of any of these packages can use mypy to check their code as well. Note: Theoretically it's possible to ditch MANIFEST.in in favor of

[PULL 05/15] python: README.rst touchups

2021-06-30 Thread John Snow
Clarifying a few points; removing the reference to 'setuptools' because it isn't referenced anywhere else in this document and doesn't really provide any useful information to a Python newcomer. Adjusting the language elsewhere to be less ambiguous and have fewer run-on sentences. Signed-off-by:

[PULL 07/15] python: rename 'venv-check' target to 'check-pipenv'

2021-06-30 Thread John Snow
Well, Cleber was right, this is a better name. In preparation for adding a different kind of virtual environment check (One that simply uses whichever version of Python you happen to have), rename this test 'check-pipenv' so that it matches the CI job 'check-python-pipenv'. Remove the "If you don

[PULL 03/15] python: Remove global pylint suppressions

2021-06-30 Thread John Snow
These suppressions only apply to a small handful of places. Instead of disabling them globally, disable them just in the cases where we need. The design of the machine class grew quite organically with tons of constructor and class instance variables -- there's little chance of meaningfully refacto

[PULL 01/15] python/qom: Do not use 'err' name at module scope

2021-06-30 Thread John Snow
Pylint updated to 2.9.0 upstream, adding new warnings for things that re-use the 'err' variable. Luckily, this only breaks the python-check-tox job, which is allowed to fail as a warning. Signed-off-by: John Snow Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Willian Rampazzo Message-id:

[PULL 00/15] Python patches

2021-06-30 Thread John Snow
The following changes since commit d940d468e29bff5eb5669c0dd8f3de0c3de17bfb: Merge remote-tracking branch 'remotes/quic/tags/pull-hex-20210629' into staging (2021-06-30 19:09:45 +0100) are available in the Git repository at: https://gitlab.com/jsnow/qemu.git tags/python-pull-request for yo

Re: [PATCH v3 05/37] target/riscv: SIMD 16-bit Shift Instructions

2021-06-30 Thread Alistair Francis
On Thu, Jun 24, 2021 at 9:11 PM LIU Zhiwei wrote: > > Instructions include right arithmetic shift, right logic shift, > and left shift. > > The shift can be an immediate or a register scalar. The > right shift has rounding operation. And the left shift > has saturation operation. > > Signed-off-by

Re: [PATCH v3 03/37] target/riscv: 16-bit Addition & Subtraction Instructions

2021-06-30 Thread Alistair Francis
On Thu, Jun 24, 2021 at 9:08 PM LIU Zhiwei wrote: > > Include 5 groups: Wrap-around (dropping overflow), Signed Halving, > Unsigned Halving, Signed Saturation, and Unsigned Saturation. > > Signed-off-by: LIU Zhiwei Reviewed-by: Alistair Francis Alistair > --- > target/riscv/helper.h

Re: [PATCH v3 00/37] target/riscv: support packed extension v0.9.4

2021-06-30 Thread Alistair Francis
On Thu, Jun 24, 2021 at 9:14 PM LIU Zhiwei wrote: > > This patchset implements the packed extension for RISC-V on QEMU. > > You can also find this patch set on my > repo(https://github.com/romanheros/qemu.git branch:packed-upstream-v3). > > Features: > * support specification packed extension >

Re: [PATCH] target/riscv: pmp: Fix some typos

2021-06-30 Thread Alistair Francis
On Sun, Jun 27, 2021 at 9:57 PM Bin Meng wrote: > > %s/CSP/CSR > %s/thie/the > > Signed-off-by: Bin Meng Thanks! Applied to riscv-to-apply.next Alistair > --- > > target/riscv/pmp.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/target/riscv/pmp.c b/targe

ping Re: [PATCH] scsi: fix bug scsi resp sense is 0 when expand disk

2021-06-30 Thread wangjie (P)
ping. On 2021/6/29 15:12, Jie Wang wrote: > A large number of I/Os are delivered during disk capacity expansion. > Many I/Os are extracted from the Vring ring, and each one registers > reqops_unit_attention when new scsi req. > If the first registered req takes the ua, the ua is cleared > and othe

Re: [PATCH 20/20] target/loongarch: Add linux-user emulation support

2021-06-30 Thread maobibo
在 2021年06月30日 17:36, Alex Bennée 写道: > > maobibo writes: > >> 在 2021年06月29日 21:42, Peter Maydell 写道: >>> On Mon, 28 Jun 2021 at 13:05, Song Gao wrote: Add files to linux-user/loongarch64 Add file to default-configs Add loongarch to target/meson.build Signed-off-

[RFC 1/3] modules: Add CONFIG_TCG_MODULAR in config_host

2021-06-30 Thread Jose R. Ziviani
CONFIG_TCG_MODULAR is a complement to CONFIG_MODULES, in order to know if TCG will be a module, even if --enable-modules option was set. Signed-off-by: Jose R. Ziviani --- meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meson.build b/meson.build index 2d72b8cc06..c37a2358d4 10

[RFC 0/3] Improve module accelerator error message

2021-06-30 Thread Jose R. Ziviani
Hello! I'm sending this as RFC because it's based on a patch still on review[1], so I'd like to see if it makes sense. Tt will improve the error message when an accelerator module could not be loaded. Instead of the current assert error, a formated message will be displayed. [1] https://patchwor

[RFC 3/3] qom: Improve error message in module_object_class_by_name()

2021-06-30 Thread Jose R. Ziviani
module_object_class_by_name() calls module_load_qom_one if the object is provided by a dynamically linked library. Such library might not be available at this moment - for instance, it can be a package not yet installed. Thus, instead of assert error messages, this patch outputs more friendly messa

[RFC 2/3] modules: Implement module_is_loaded function

2021-06-30 Thread Jose R. Ziviani
The function module_load_one() fills a hash table will all modules that were successfuly loaded. However, that table is a static variable of module_load_one(). This patch changes it and creates a function that informs whether a given module was loaded or not. Signed-off-by: Jose R. Ziviani --- i

Re: [PATCH v4 0/4] avocado-qemu: New SMMUv3 and intel IOMMU tests

2021-06-30 Thread Wainer dos Santos Moschetta
Hi, On 6/29/21 5:17 PM, Eric Auger wrote: Hi Cleber, all, On 6/29/21 4:36 PM, Eric Auger wrote: This series adds ARM SMMU and Intel IOMMU functional tests using Fedora cloud-init images. ARM SMMU tests feature guests with and without RIL (range invalidation support) using respectively fedora

Re: [External] Re: [RFC v1] virtio/vsock: add two more queues for datagram types

2021-06-30 Thread Jiang Wang .
On Thu, Jun 24, 2021 at 7:31 AM Stefano Garzarella wrote: > > On Wed, Jun 23, 2021 at 11:50:33PM -0700, Jiang Wang . wrote: > >Hi Stefano, > > > >I checked virtio_net_set_multiqueue(), which will help with following > >changes in my patch: > > > >#ifdef CONFIG_VHOST_VSOCK_DGRAM > >vvc->dgram_recv_

Re: [PATCH v7 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

2021-06-30 Thread Wainer dos Santos Moschetta
On 6/29/21 10:26 PM, Cleber Rosa wrote: The QEMU project has two machines (aarch64 and s390x) that can be used for jobs that do build and run tests. This introduces those jobs, which are a mapping of custom scripts used for the same purpose. Signed-off-by: Cleber Rosa Reviewed-by: Willian Ra

Re: [PATCH v7 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2021-06-30 Thread Wainer dos Santos Moschetta
On 6/29/21 10:26 PM, Cleber Rosa wrote: To have the jobs dispatched to custom runners, gitlab-runner must be installed, active as a service and properly configured. The variables file and playbook introduced here should help with those steps. The playbook introduced here covers the Linux dist

Re: [PATCH v7 2/4] Jobs based on custom runners: build environment docs and playbook

2021-06-30 Thread Wainer dos Santos Moschetta
On 6/29/21 10:26 PM, Cleber Rosa wrote: To run basic jobs on custom runners, the environment needs to be properly set up. The most common requirement is having the right packages installed. The playbook introduced here covers the QEMU's project s390x and aarch64 machines. At the time this is

Re: [PATCH] python: Configure tox to skip missing interpreters

2021-06-30 Thread Willian Rampazzo
On Wed, Jun 30, 2021 at 3:46 PM Wainer dos Santos Moschetta wrote: > > Currently tox tests against the installed interpreters, however if any > supported interpreter is absent then it will return fail. It seems not > reasonable to expect developers to have all supported interpreters > installed on

Re: [PATCH 1/3] build: validate that system capstone works before using it

2021-06-30 Thread Willian Rampazzo
On Fri, Jun 25, 2021 at 2:22 PM Daniel P. Berrangé wrote: > > Some versions of capstone have shipped a broken pkg-config file which > puts the -I path without the trailing '/capstone' suffix. This breaks > the ability to "#include ". Upstream and most distros have > fixed this, but a few straggler

Re: [PATCH 3/3] cirrus: delete FreeBSD and macOS jobs

2021-06-30 Thread Willian Rampazzo
On Fri, Jun 25, 2021 at 2:22 PM Daniel P. Berrangé wrote: > > The builds for these two platforms can now be performed from GitLab CI > using cirrus-run. > > Signed-off-by: Daniel P. Berrangé > --- > .cirrus.yml | 55 - > 1 file changed, 55 dele

Re: [PATCH 2/3] gitlab: support for FreeBSD 12, 13 and macOS 11 via cirrus-run

2021-06-30 Thread Daniel P . Berrangé
On Wed, Jun 30, 2021 at 03:58:57PM -0300, Wainer dos Santos Moschetta wrote: > Hi, > > On 6/25/21 2:22 PM, Daniel P. Berrangé wrote: > > This adds support for running 4 jobs via Cirrus CI runners: > > > > * FreeBSD 12 > > * FreeBSD 13 > > * macOS 11 with default XCode > > * macOS 11 with

Re: [PULL v2 0/4] Hexagon (target/hexagon) bug fixes

2021-06-30 Thread Peter Maydell
On Tue, 29 Jun 2021 at 18:14, Taylor Simpson wrote: > > The following changes since commit 13d5f87cc3b94bfccc501142df4a7b12fee3a6e7: > > Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-axp-20210628' > into staging (2021-06-29 10:02:42 +0100) > > are available in the git repository at

[PATCH] migration: Move bitmap_mutex out of migration_bitmap_clear_dirty()

2021-06-30 Thread Peter Xu
Taking the mutex every time for each dirty bit to clear is too slow, especially we'll take/release even if the dirty bit is cleared. So far it's only used to sync with special cases with qemu_guest_free_page_hint() against migration thread, nothing really that serious yet. Let's move the lock to

Re: [PATCH v5 02/10] ACPI ERST: specification for ERST support

2021-06-30 Thread Eric DeVolder
Oops, at the end of the 4th paragraph, I meant to state that "Linux does not support the NVRAM mode." rather than "non-NVRAM mode", which contradicts everything I stated prior. Eric. From: Eric DeVolder Sent: Wednesday, June 30, 2021 2:07 PM To: qemu-devel@nongnu.

Re: [PATCH] target/i386: Fix cpuid level for AMD

2021-06-30 Thread Michael Roth
Quoting Dr. David Alan Gilbert (2021-06-29 09:06:02) > * zhenwei pi (pizhen...@bytedance.com) wrote: > > A AMD server typically has cpuid level 0x10(test on Rome/Milan), it > > should not be changed to 0x1f in multi-dies case. > > > > Fixes: a94e1428991 (target/i386: Add CPUID.1F generation suppor

[PATCH v5 08/10] ACPI ERST: create ACPI ERST table for pc/x86 machines.

2021-06-30 Thread Eric DeVolder
This change exposes ACPI ERST support for x86 guests. Signed-off-by: Eric DeVolder --- hw/i386/acpi-build.c | 9 + hw/i386/acpi-microvm.c | 9 + 2 files changed, 18 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index de98750..d2026cc 100644 --- a/hw/i3

[PATCH v5 07/10] ACPI ERST: trace support

2021-06-30 Thread Eric DeVolder
Provide the definitions needed to support tracing in ACPI ERST. Signed-off-by: Eric DeVolder --- hw/acpi/trace-events | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/acpi/trace-events b/hw/acpi/trace-events index dcc1438..a5c2755 100644 --- a/hw/acpi/trace-events +++ b/hw/

[PATCH v5 05/10] ACPI ERST: support for ACPI ERST feature

2021-06-30 Thread Eric DeVolder
This change implements the support for the ACPI ERST feature. This implements a PCI device for ACPI ERST. This implments the non-NVRAM "mode" of operation for ERST. This change also includes erst.c in the build of general ACPI support. Signed-off-by: Eric DeVolder --- hw/acpi/erst.c | 704

[PATCH v5 03/10] ACPI ERST: PCI device_id for ERST

2021-06-30 Thread Eric DeVolder
This change declares the PCI device_id for the new ACPI ERST device. Signed-off-by: Eric DeVolder --- include/hw/pci/pci.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 6be4e0c..eef3ef4 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci

[PATCH v5 02/10] ACPI ERST: specification for ERST support

2021-06-30 Thread Eric DeVolder
Information on the implementation of the ACPI ERST support. Signed-off-by: Eric DeVolder --- docs/specs/acpi_erst.txt | 152 +++ 1 file changed, 152 insertions(+) create mode 100644 docs/specs/acpi_erst.txt diff --git a/docs/specs/acpi_erst.txt b/doc

[PATCH v5 00/10] acpi: Error Record Serialization Table, ERST, support for QEMU

2021-06-30 Thread Eric DeVolder
= I believe I have corrected for all feedback on v4, but with responses to certain feedback below. In patch 1/6, Igor asks: "you are adding empty template files here but the later matching bios-tables-test is nowhere to be found Was testcase lost somewhere along the way

[PATCH v5 10/10] ACPI ERST: step 6 of bios-tables-test.c

2021-06-30 Thread Eric DeVolder
Following the guidelines in tests/qtest/bios-tables-test.c, this is step 6, the re-generated ACPI tables binary blobs. Signed-off-by: Eric DeVolder --- tests/data/acpi/microvm/ERST| Bin 0 -> 976 bytes tests/data/acpi/pc/ERST | Bin 0 -> 976 bytes tests/data/a

[PATCH v5 09/10] ACPI ERST: qtest for ERST

2021-06-30 Thread Eric DeVolder
This change provides a qtest that locates and then does a simple interrogation of the ERST feature within the guest. Signed-off-by: Eric DeVolder --- tests/qtest/erst-test.c | 129 tests/qtest/meson.build | 2 + 2 files changed, 131 insertions(+

[PATCH v5 06/10] ACPI ERST: build the ACPI ERST table

2021-06-30 Thread Eric DeVolder
This code is called from the machine code (if ACPI supported) to generate the ACPI ERST table. Signed-off-by: Eric DeVolder --- hw/acpi/erst.c | 214 + 1 file changed, 214 insertions(+) diff --git a/hw/acpi/erst.c b/hw/acpi/erst.c index 6e

[PATCH v5 04/10] ACPI ERST: header file for ERST

2021-06-30 Thread Eric DeVolder
This change introduces the defintions for ACPI ERST. Signed-off-by: Eric DeVolder --- include/hw/acpi/erst.h | 84 ++ 1 file changed, 84 insertions(+) create mode 100644 include/hw/acpi/erst.h diff --git a/include/hw/acpi/erst.h b/include/hw/acpi

[PATCH v5 01/10] ACPI ERST: bios-tables-test.c steps 1 and 2

2021-06-30 Thread Eric DeVolder
Following the guidelines in tests/qtest/bios-tables-test.c, this change adds empty placeholder files per step 1 for the new ERST table, and excludes resulting changed files in bios-tables-test-allowed-diff.h per step 2. Signed-off-by: Eric DeVolder --- tests/data/acpi/microvm/ERST

[PATCH v2 28/28] target/xtensa: Use translator_use_goto_tb

2021-06-30 Thread Richard Henderson
Reviewed-by: Max Filippov Signed-off-by: Richard Henderson --- target/xtensa/translate.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index 14028d307d..ac42f5efdc 100644 --- a/target/xtensa/translate.c +++ b/target

Re: [PATCH 3/3] cirrus: delete FreeBSD and macOS jobs

2021-06-30 Thread Wainer dos Santos Moschetta
On 6/25/21 2:22 PM, Daniel P. Berrangé wrote: The builds for these two platforms can now be performed from GitLab CI using cirrus-run. Signed-off-by: Daniel P. Berrangé --- .cirrus.yml | 55 - 1 file changed, 55 deletions(-) Reviewed-by

[PATCH v2 25/28] target/sparc: Use translator_use_goto_tb

2021-06-30 Thread Richard Henderson
Reviewed-by: Mark Cave-Ayland Signed-off-by: Richard Henderson --- target/sparc/translate.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 4bfa3179f8..fb0c242606 100644 --- a/target/sparc/translat

Re: [PATCH v7 0/7] virtiofsd: Add support to enable/disable posix acls

2021-06-30 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > Hi, > > This is V7 of the patches. > > Changes since V6. > > - Dropped kernel header update patch as somebody else did it. > - Fixed coding style issues. > > Currently posix ACL support does not work well with virtiofs and bunch > of tests fail when I

[PATCH v2 20/28] target/riscv: Use translator_use_goto_tb

2021-06-30 Thread Richard Henderson
Just use translator_use_goto_tb directly at the one call site, rather than maintaining a local wrapper. Reviewed-by: Alistair Francis Signed-off-by: Richard Henderson --- target/riscv/translate.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/target/ris

[PATCH v2 18/28] target/openrisc: Use translator_use_goto_tb

2021-06-30 Thread Richard Henderson
Reorder the cases in openrisc_tr_tb_stop to make this easier to read. Cc: Stafford Horne Signed-off-by: Richard Henderson --- target/openrisc/translate.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c

Re: [PATCH 2/3] gitlab: support for FreeBSD 12, 13 and macOS 11 via cirrus-run

2021-06-30 Thread Wainer dos Santos Moschetta
Hi, On 6/25/21 2:22 PM, Daniel P. Berrangé wrote: This adds support for running 4 jobs via Cirrus CI runners: * FreeBSD 12 * FreeBSD 13 * macOS 11 with default XCode * macOS 11 with latest XCode The gitlab job uses a container published by the libvirt-ci project (https://gitlab.com/lib

Re: [PATCH v3] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL

2021-06-30 Thread Richard Henderson
On 6/30/21 3:50 AM, Ulrich Weigand wrote: The FP-to-integer conversion instructions need to set CC 3 whenever a "special case" occurs; this is the case whenever the instruction also signals the IEEE invalid exception. (See e.g. figure 19-18 in the Principles of Operation.) However, qemu current

[PATCH] python: Configure tox to skip missing interpreters

2021-06-30 Thread Wainer dos Santos Moschetta
Currently tox tests against the installed interpreters, however if any supported interpreter is absent then it will return fail. It seems not reasonable to expect developers to have all supported interpreters installed on their systems. Luckily tox can be configured to skip missing interpreters. T

  1   2   3   >