Hi Peter,
Many thanks for your detailed explanation. Upon further reflection, it
seems that I have misinterpreted some of the explanations in
the manual. Sorry for the confusion, the original implementation is
correct.
Thanks,
Tianrui
On Fri, Jul 16, 2021 at 4:32 PM Peter Maydell
wrote:
> On
On Sun, 18 Jul 2021 at 00:21, Peter Maydell wrote:
>
> Split out the mmap prototypes into a new header user-mmap.h
> which we only include where required.
>
> Signed-off-by: Peter Maydell
> ---
> linux-user/qemu.h | 20
> linux-user/user-mmap.h | 34
On Sat, 17 Jul 2021 at 23:18, Richard Henderson
wrote:
>
> The actual number of bytes advanced need not be 100% exact,
> but we should not cross a page when the insn would not.
>
> If rvc is enabled, the minimum insn size is 2.
>
> Signed-off-by: Richard Henderson
> ---
>
On Sat, 17 Jul 2021 at 23:18, Richard Henderson
wrote:
>
> The actual number of bytes advanced need not be 100% exact,
> but we should not cross a page when the insn would not.
>
> If mips16 or mips32e are enabled, the minimum insn size is 2.
>
> Signed-off-by: Richard Henderson
> ---
>
On Sat, 17 Jul 2021 at 23:18, Richard Henderson
wrote:
>
> Since 0b00b0c1e05b, tb->size must not be zero.
> Advance pc so that the breakpoint covers the insn at the bp.
>
> Signed-off-by: Richard Henderson
> ---
> target/avr/translate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
On Sat, 17 Jul 2021 at 23:18, Richard Henderson
wrote:
>
> The space reserved for CF_COUNT_MASK was overly large.
> Reduce to free up cflags bits and eliminate an extra test.
>
> Reviewed-by: Alex Bennée
> Signed-off-by: Richard Henderson
Reviewed-by: Peter Maydell
thanks
-- PMM
On Sun, 18 Jul 2021 at 00:21, Peter Maydell wrote:
>
> Since commit 687ca797893ca1e853, the code that looks at the debug
> define DEBUG_REMAP is all in uaccess.c; move the #undef line to
> there from qemu.h (thus reducing significantly the amount of code
> that gets recompiled if you need to turn
Split the safe-syscall macro from qemu.h into a new safe-syscall.h.
Signed-off-by: Peter Maydell
---
linux-user/qemu.h | 135 -
linux-user/safe-syscall.h | 154 ++
linux-user/syscall.c | 1 +
3 files changed, 155
Since commit 687ca797893ca1e853, the code that looks at the debug
define DEBUG_REMAP is all in uaccess.c; move the #undef line to
there from qemu.h (thus reducing significantly the amount of code
that gets recompiled if you need to turn the debug on).
Signed-off-by: Peter Maydell
---
Split guest-binary loader prototypes out into a new header
loader.h which we include only where required.
Signed-off-by: Peter Maydell
---
linux-user/loader.h| 59 ++
linux-user/qemu.h | 34
linux-user/elfload.c | 1 +
Trim down the #includes in qemu.h where we can, either by
dropping unneeded headers or by moving them to user-internals.h.
This includes deleting a couple of #includes that appear at
weird points midway through the header file.
Signed-off-by: Peter Maydell
---
linux-user/qemu.h | 4
Currently the linux-user qemu.h pulls in gdbstub.h. There's no real reason
why it should do this; include it directly from the C files which require
it, and drop the include line in qemu.h.
(Note that several of the C files previously relying on this indirect
include were going out of their way
We're about to move a lot of the code in qemu.h out into different
header files; fix the coding style nits first so that checkpatch
is happy with the pure code-movement patches. This is mostly
block-comment style but also a few whitespace issues.
Signed-off-by: Peter Maydell
---
I didn't clean
Split out the mmap prototypes into a new header user-mmap.h
which we only include where required.
Signed-off-by: Peter Maydell
---
linux-user/qemu.h | 20
linux-user/user-mmap.h | 34 ++
linux-user/elfload.c | 1 +
qemu.h is included in various non-linux-user files (which
mostly want the TaskState struct and the functions for
doing usermode access to guest addresses like lock_user(),
unlock_user(), get_user*(), etc).
Split out the parts that are only used in linux-user itself
into a new user-internals.h.
Split the signal related prototypes into a new header file
sighandling.h, and include it in those places that require it.
Signed-off-by: Peter Maydell
---
linux-user/qemu.h| 36
linux-user/sighandling.h | 56
linux-user/qemu.h is an awkward header, for two reasons:
(1) its name suggests it's a rather common generic header,
but it's actually specific to the usermode emulators
(2) it is a mix of:
* lots of things internal to the implementation of linux-user
* functions that a few files
The functions implemented in strace.c are only used in a few files in
linux-user; split them out of qemu.h and into a new strace.h header
which we include in the places that need it.
Signed-off-by: Peter Maydell
---
linux-user/qemu.h| 18 --
linux-user/strace.h | 38
> -Original Message-
> From: Peter Maydell
> Sent: Saturday, July 17, 2021 4:30 AM
> To: qemu-devel@nongnu.org
> Cc: Taylor Simpson
> Subject: [PATCH] target/hexagon: Drop include of qemu.h
>
> The qemu.h file is a CONFIG_USER_ONLY header; it doesn't appear on the
> include path for
On Thu, 8 Jul 2021 at 16:49, Paolo Bonzini wrote:
>
> From: Philippe Mathieu-Daudé
>
> Add a target-specific Kconfig. We need the definitions in Kconfig so
> the minikconf tool can verify they exits. However CONFIG_FOO is only
> enabled for target foo via the meson.build rules.
>
> Two
Since 0b00b0c1e05b, tb->size must not be zero.
Advance pc so that the breakpoint covers the insn at the bp.
Signed-off-by: Richard Henderson
---
target/avr/translate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/avr/translate.c b/target/avr/translate.c
index
The actual number of bytes advanced need not be 100% exact,
but we should not cross a page when the insn would not.
If rvc is enabled, the minimum insn size is 2.
Signed-off-by: Richard Henderson
---
target/riscv/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The actual number of bytes advanced need not be 100% exact,
but we should not cross a page when the insn would not.
If mips16 or mips32e are enabled, the minimum insn size is 2.
Signed-off-by: Richard Henderson
---
target/mips/tcg/translate.c | 2 +-
1 file changed, 1 insertion(+), 1
Having this data in cflags means that hashing takes care
of selecting a TB with or without exceptions built in.
Which means that we no longer need to flush all TBs.
This does require that we single-step while we're within a page
that contains a breakpoint, so it's not yet ideal, but should be
an
Request that the one TB returns immediately, so that
we release the exclusive lock as soon as possible.
Reviewed-by: Peter Maydell
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
accel/tcg/cpu-exec.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git
Hi Zoltan can be the gcc, in past on ppc we face the same kind of issue.
i will ask some other guys in the debian ppc ML if can try to build qemu and
see if they have the same issue. in positive case we will report to the
mantainer.
Thanks
Luigi
Da: BALATON
Exchange the test in translator_use_goto_tb for CF_NO_GOTO_TB,
and the test in tb_gen_code for setting CF_COUNT_MASK to 1.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
accel/tcg/cpu-exec.c | 8 +++-
accel/tcg/translate-all.c | 2 +-
accel/tcg/translator.c| 2 +-
We will shortly have more than a simple member read here,
with stuff not necessarily exposed to exec/exec-all.h.
Reviewed-by: Peter Maydell
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
include/exec/exec-all.h | 5 +
accel/tcg/cpu-exec.c| 5 +
2 files changed, 6
We don't need the whole CPUBreakpoint structure in the check,
only the flags. Return the instruction length to consolidate
the adjustment of db->pc_next.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
include/exec/translator.h | 17 +--
accel/tcg/translator.c
The access internal to tb_cflags() is atomic.
Avoid re-reading it as such for the multiple uses.
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
accel/tcg/translator.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/accel/tcg/translator.c
The space reserved for CF_COUNT_MASK was overly large.
Reduce to free up cflags bits and eliminate an extra test.
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
include/exec/exec-all.h | 4 +++-
accel/tcg/translate-all.c | 5 ++---
2 files changed, 5 insertions(+), 4
The purpose of suppressing goto_ptr from -d nochain had been
to return to the main loop so that -d cpu would be recognized.
But we now include -d cpu logging in helper_lookup_tb_ptr so
there is no need to exclude goto_ptr.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
We will shortly require the guest pc for computing cflags,
so move the choice just after cpu_get_tb_cpu_state.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
accel/tcg/cpu-exec.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff
This is fixing #404 ("windows xp boot takes much longer...")
and several other similar reports.
Changes for v3:
* Map CF_COUNT_MASK == 0 -> TCG_MAX_INSNS.
* Split out *_breakpoint_check fixes for avr, mips, riscv.
Changes for v2:
* All prerequisites and 7 of the patches from v1 with are
Move the -d nochain check to bits on tb->cflags.
These will be used for more than -d nochain shortly.
Set bits during curr_cflags, test them in translator_use_goto_tb,
assert we're not doing anything odd in tcg_gen_goto_tb. The test
in tcg_gen_exit_tb is redundant with the assert for
On 7/17/21 3:13 PM, Peter Maydell wrote:
On Sat, 17 Jul 2021 at 21:50, Richard Henderson
wrote:
On 7/13/21 6:37 AM, Peter Maydell wrote:
+#define DO_VABAV(OP, ESIZE, TYPE) \
+uint32_t HELPER(glue(mve_, OP))(CPUARMState *env, void *vn, \
+
On Sat, 17 Jul 2021 at 21:50, Richard Henderson
wrote:
>
> On 7/13/21 6:37 AM, Peter Maydell wrote:
> > +#define DO_VABAV(OP, ESIZE, TYPE) \
> > +uint32_t HELPER(glue(mve_, OP))(CPUARMState *env, void *vn, \
> > +void *vm,
On 7/13/21 6:37 AM, Peter Maydell wrote:
+#define DO_VABAV(OP, ESIZE, TYPE) \
+uint32_t HELPER(glue(mve_, OP))(CPUARMState *env, void *vn, \
+void *vm, uint32_t ra) \
+{
On 7/13/21 6:37 AM, Peter Maydell wrote:
+/* Max and min of absolute values */
+static int64_t do_maxa(int64_t n, int64_t m)
+{
+if (n < 0) {
+n = -n;
+}
+if (m < 0) {
+m = -m;
+}
+return MAX(n, m);
+}
This doesn't look quite right. The n operand is
On 7/17/21 3:06 AM, Peter Maydell wrote:
On Fri, 16 Jul 2021 at 23:12, Richard Henderson
wrote:
On 7/13/21 6:37 AM, Peter Maydell wrote:
Implement the MVE VMLAS insn, which multiplies a vector by a vector
and adds a scalar.
Signed-off-by: Peter Maydell
---
target/arm/helper-mve.h| 8
On Fri, Jul 09, 2021 at 06:59:25PM -0600, Mathieu Poirier wrote:
> This sets adds a vhost-user based random number generator (RNG),
> similar to what has been done for i2c and virtiofsd, with the
> implementation following the patterns already set forth in those.
>
> Applies cleanly to
On Sat, 17 Jul 2021, luigi burdo wrote:
Hi
i small report
im try to build last relesase on a PowerMac G5 quad on debian sid PPC64 but ld
exit with an error:
Looks like it's gcc that crashes not ld. If you're sure it's not a
hardware problem this may be a gcc bug. Sometimes big compile jobs
On Sat, 17 Jul 2021 at 19:43, Richard Henderson
wrote:
>
> On 7/17/21 10:42 AM, Alex Bennée wrote:
> > Hmm we are testing a magic global here and looking at
> > cpu->singlestep_enabled lower down. We have a transient singlestep which
> > is turned on an off via cpu->singlestep_enabled and a
Richard Henderson writes:
> On 7/17/21 10:39 AM, Alex Bennée wrote:
>> Richard Henderson writes:
>>
>>> The purpose of suppressing goto_ptr from -d nochain had been
>>> to return to the main loop so that -d cpu would be recognized.
>> Hmm is it though? I've always treated it as ensuring we
On 7/17/21 10:52 AM, Peter Maydell wrote:
On Mon, 12 Jul 2021 at 16:48, Richard Henderson
wrote:
We don't need the whole CPUBreakpoint structure in the check,
only the flags. Return the instruction length to consolidate
the adjustment of db->pc_next.
Signed-off-by: Richard Henderson
Since the last thing that mem.h does is include mem-internal.h,
the symbols are not actually private.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
trace/mem-internal.h | 50
trace/mem.h | 50
Reduce the amount of code duplication by always passing
the TCGMemOpIdx argument to helper_atomic_*. This is not
currently used for user-only, but it's easy to ignore.
Signed-off-by: Richard Henderson
---
accel/tcg/tcg-runtime.h | 46 ---
accel/tcg/cputlb.c
Use trace_mem_get_info instead of trace_mem_build_info,
using the TCGMemOpIdx that we already have. Do this in
the atomic_trace_*_pre function as common subroutines.
Signed-off-by: Richard Henderson
---
accel/tcg/atomic_template.h | 48 +--
Always provide the atomic interface using TCGMemOpIdx oi
and uintptr_t retaddr. Rename from helper_* to cpu_* so
as to (mostly) match the exec/cpu_ldst.h functions, and
to emphasize that they are not callable from TCG directly.
Signed-off-by: Richard Henderson
---
include/tcg/tcg.h
All definitions are now empty.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
accel/tcg/atomic_template.h | 12
accel/tcg/cputlb.c | 1 -
accel/tcg/user-exec.c | 1 -
3 files changed, 14 deletions(-)
diff --git
Unify the parameters of atomic_mmu_lookup between cputlb.c and
user-exec.c. Call the function directly, and remove the macros.
Signed-off-by: Richard Henderson
---
accel/tcg/atomic_template.h | 41 +
accel/tcg/cputlb.c | 7 +--
Use it to avoid some clang-12 -Watomic-alignment errors,
forcing some structures to be aligned and as a pointer when
we have ensured that the address is aligned.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
accel/tcg/atomic_template.h | 4 ++--
We now require c11, so the fallbacks are now dead code
Signed-off-by: Richard Henderson
---
configure | 7 --
include/qemu/atomic.h | 204 +++---
2 files changed, 10 insertions(+), 201 deletions(-)
diff --git a/configure b/configure
index
All instances of EXTRA_ARGS are now identical.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
accel/tcg/atomic_template.h | 36
accel/tcg/cputlb.c | 1 -
accel/tcg/user-exec.c | 1 -
3 files changed, 20
Clang warnings about questionable atomic usage get localized
to the inline function in atomic.h. By using a macro, we get
the full traceback to the original use that caused the warning.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
include/qemu/atomic.h | 25
This is intended to fix building with clang-12 on i386.
In the process, I found bugs wrt handling of guest memory in target/
with respect to atomics, fixed by unifying the api between softmmu
and user-only and removing some ifdefs under target/.
Unification of the api allowed some further
On 7/17/21 10:58 AM, Peter Maydell wrote:
+static uint32_t cflags_for_breakpoints(CPUState *cpu, target_ulong pc,
+ uint32_t cflags)
+{
+uint32_t bflags = 0;
+
+if (unlikely(cpu->singlestep_enabled)) {
+bflags = CF_BP_SSTEP;
+} else {
On 7/17/21 10:43 AM, Peter Maydell wrote:
On Mon, 12 Jul 2021 at 16:46, Richard Henderson
wrote:
Request that the one TB returns immediately, so that
we release the exclusive lock as soon as possible.
Signed-off-by: Richard Henderson
---
accel/tcg/cpu-exec.c | 11 ---
1 file
On 7/17/21 10:42 AM, Alex Bennée wrote:
Richard Henderson writes:
Exchange the test in translator_use_goto_tb for CF_NO_GOTO_TB,
and the test in tb_gen_code for setting CF_COUNT_MASK to 1.
Signed-off-by: Richard Henderson
---
accel/tcg/cpu-exec.c | 8 +++-
On 7/17/21 10:39 AM, Alex Bennée wrote:
Richard Henderson writes:
The purpose of suppressing goto_ptr from -d nochain had been
to return to the main loop so that -d cpu would be recognized.
Hmm is it though? I've always treated it as ensuring we always come out
into the main loop (which is
On 7/17/21 10:30 AM, Peter Maydell wrote:
On Mon, 12 Jul 2021 at 16:42, Richard Henderson
wrote:
The space reserved for CF_COUNT_MASK was overly large.
Reduce to free up cflags bits and eliminate an extra test.
Signed-off-by: Richard Henderson
---
include/exec/exec-all.h | 4 +++-
Hi
i small report
im try to build last relesase on a PowerMac G5 quad on debian sid PPC64 but ld
exit with an error:
gigi@debian:~/src/tags/ppc-for-6.1-20210713/build$ ninja
[3864/9215] Compiling C object
libqemu-mipsel-softmmu.fa.p/target_mips_tcg_msa_helper.c.o
FAILED:
On Mon, 12 Jul 2021 at 16:49, Richard Henderson
wrote:
>
> Having this data in cflags means that hashing takes care
> of selecting a TB with or without exceptions built in.
> Which means that we no longer need to flush all TBs.
>
> This does require that we single-step while we're within a page
>
On Mon, 12 Jul 2021 at 16:48, Richard Henderson
wrote:
>
> We don't need the whole CPUBreakpoint structure in the check,
> only the flags. Return the instruction length to consolidate
> the adjustment of db->pc_next.
>
> Signed-off-by: Richard Henderson
> diff --git a/target/avr/translate.c
Richard Henderson writes:
> The access internal to tb_cflags() is atomic.
> Avoid re-reading it as such for the multiple uses.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
--
Alex Bennée
Richard Henderson writes:
> Request that the one TB returns immediately, so that
> we release the exclusive lock as soon as possible.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
--
Alex Bennée
Richard Henderson writes:
> Exchange the test in translator_use_goto_tb for CF_NO_GOTO_TB,
> and the test in tb_gen_code for setting CF_COUNT_MASK to 1.
>
> Signed-off-by: Richard Henderson
> ---
> accel/tcg/cpu-exec.c | 8 +++-
> accel/tcg/translate-all.c | 2 +-
>
On Mon, 12 Jul 2021 at 16:42, Richard Henderson
wrote:
>
> We will shortly require the guest pc for computing cflags,
> so move the choice just after cpu_get_tb_cpu_state.
>
> Signed-off-by: Richard Henderson
> ---
> accel/tcg/cpu-exec.c | 34 +-
> 1 file
On Mon, 12 Jul 2021 at 16:46, Richard Henderson
wrote:
>
> Request that the one TB returns immediately, so that
> we release the exclusive lock as soon as possible.
>
> Signed-off-by: Richard Henderson
> ---
> accel/tcg/cpu-exec.c | 11 ---
> 1 file changed, 8 insertions(+), 3
On Mon, 12 Jul 2021 at 16:42, Richard Henderson
wrote:
>
> Exchange the test in translator_use_goto_tb for CF_NO_GOTO_TB,
> and the test in tb_gen_code for setting CF_COUNT_MASK to 1.
>
> Signed-off-by: Richard Henderson
> ---
> accel/tcg/cpu-exec.c | 8 +++-
>
Richard Henderson writes:
> The purpose of suppressing goto_ptr from -d nochain had been
> to return to the main loop so that -d cpu would be recognized.
Hmm is it though? I've always treated it as ensuring we always come out
into the main loop (which is helpful for debugging).
> But we now
On Mon, 12 Jul 2021 at 16:44, Richard Henderson
wrote:
>
> The purpose of suppressing goto_ptr from -d nochain had been
> to return to the main loop so that -d cpu would be recognized.
> But we now include -d cpu logging in helper_lookup_tb_ptr so
> there is no need to exclude goto_ptr.
>
>
On Mon, 12 Jul 2021 at 16:44, Richard Henderson
wrote:
>
> Move the -d nochain check to bits on tb->cflags.
> These will be used for more than -d nochain shortly.
>
> Set bits during curr_cflags, test them in translator_use_goto_tb,
> assert we're not doing anything odd in tcg_gen_goto_tb. The
Richard Henderson writes:
> Move the -d nochain check to bits on tb->cflags.
> These will be used for more than -d nochain shortly.
>
> Set bits during curr_cflags, test them in translator_use_goto_tb,
> assert we're not doing anything odd in tcg_gen_goto_tb. The test
> in tcg_gen_exit_tb is
Richard Henderson writes:
> We will shortly have more than a simple member read here,
> with stuff not necessarily exposed to exec/exec-all.h.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
--
Alex Bennée
Richard Henderson writes:
> The space reserved for CF_COUNT_MASK was overly large.
> Reduce to free up cflags bits and eliminate an extra test.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
--
Alex Bennée
On Mon, 12 Jul 2021 at 16:44, Richard Henderson
wrote:
>
> We will shortly have more than a simple member read here,
> with stuff not necessarily exposed to exec/exec-all.h.
>
> Signed-off-by: Richard Henderson
> ---
Reviewed-by: Peter Maydell
(apologies if you saw a no-content email: gmail
On Mon, 12 Jul 2021 at 16:42, Richard Henderson
wrote:
>
> The space reserved for CF_COUNT_MASK was overly large.
> Reduce to free up cflags bits and eliminate an extra test.
>
> Signed-off-by: Richard Henderson
> ---
> include/exec/exec-all.h | 4 +++-
> accel/tcg/translate-all.c | 5 ++---
>
Ping. A Tested-by is nice, but Reviewed-by is better,
and time is running out, even for bug fixes.
r~
On 7/12/21 8:39 AM, Richard Henderson wrote:
This is fixing #404 ("windows xp boot takes much longer...")
and several other similar reports.
For v2, all prerequisites and 7 of the patches
On 7/17/21 3:30 AM, Peter Maydell wrote:
The qemu.h file is a CONFIG_USER_ONLY header; it doesn't appear on
the include path for softmmu builds. Currently we include it
unconditionally in target/hexagon/op_helper.c. We used to need it
for the put_user_*() and get_user_*() functions, but now
On 7/16/21 8:59 PM, LIU Zhiwei wrote:
If we want to strictly obey the spec, we should
1) Ignore MSB 32bits for source register, and sign-extend the destination
register.
2) Always use 32bit operation(TCG 32bit OP).
I want to still use TCG 64bit OP and just extend the source to 64bit by ext32s
Ticket has been re-opened here :
https://gitlab.com/qemu-project/qemu/-/issues/485
** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #485
https://gitlab.com/qemu-project/qemu/-/issues/485
--
You received this bug notification because you are a member of qemu-
devel-ml, which is
On Sat, Jul 17, 2021, 15:31 Alex Bennée wrote:
>
> Mahmoud Mandour writes:
>
> > Hello,
> >
> > This series removes passing arguments to plugins through "arg=" since
> > it's redundant and reduces readability especially when the argument
> > itself is composed of a name and a value.
>
> When
Mahmoud Mandour writes:
> Hello,
>
> This series removes passing arguments to plugins through "arg=" since
> it's redundant and reduces readability especially when the argument
> itself is composed of a name and a value.
When you re-roll a series it's useful to add a version tag. You can use
Peter Maydell writes:
> The qemu.h file is a CONFIG_USER_ONLY header; it doesn't appear on
> the include path for softmmu builds. Currently we include it
> unconditionally in target/hexagon/op_helper.c. We used to need it
> for the put_user_*() and get_user_*() functions, but now that we
The qemu.h file is a CONFIG_USER_ONLY header; it doesn't appear on
the include path for softmmu builds. Currently we include it
unconditionally in target/hexagon/op_helper.c. We used to need it
for the put_user_*() and get_user_*() functions, but now that we have
removed the uses of those from
Signed-off-by: Mahmoud Mandour
---
contrib/plugins/lockstep.c | 31 ++-
docs/devel/tcg-plugins.rst | 2 +-
2 files changed, 23 insertions(+), 10 deletions(-)
diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index 7fd35eb669..a41ffe83fa 100644
---
On 7/17/21 3:41 AM, Richard Henderson wrote:
> Since the last thing that mem.h does is include mem-internal.h,
> the symbols are not actually private.
>
> Signed-off-by: Richard Henderson
> ---
> trace/mem-internal.h | 50
> trace/mem.h | 50
Signed-off-by: Mahmoud Mandour
---
docs/system/deprecated.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
index e2e0090878..aaf0ee5777 100644
--- a/docs/system/deprecated.rst
+++ b/docs/system/deprecated.rst
@@ -126,6 +126,12
Signed-off-by: Mahmoud Mandour
---
contrib/plugins/hotblocks.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c
index 4b08340143..062200a7a4 100644
--- a/contrib/plugins/hotblocks.c
+++
Signed-off-by: Mahmoud Mandour
---
tests/plugin/bb.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/tests/plugin/bb.c b/tests/plugin/bb.c
index de09bdde4e..7d470a1011 100644
--- a/tests/plugin/bb.c
+++ b/tests/plugin/bb.c
@@ -104,10 +104,17 @@
On 7/17/21 3:41 AM, Richard Henderson wrote:
> All definitions are now empty.
>
> Signed-off-by: Richard Henderson
> ---
> accel/tcg/atomic_template.h | 12
> accel/tcg/cputlb.c | 1 -
> accel/tcg/user-exec.c | 1 -
> 3 files changed, 14 deletions(-)
Reviewed-by:
Signed-off-by: Mahmoud Mandour
---
docs/devel/tcg-plugins.rst | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst
index 4ab9dc4bb1..be1256d50c 100644
--- a/docs/devel/tcg-plugins.rst
+++
Correctly parsing plugin argument since they now must be provided as
full-form boolean parameters, e.g.:
-plugin ./contrib/plugins/libhowvec.so,verbose=on,inline=on
Also, introduced the argument "count" that accepts one opt to count
individually at a time.
Signed-off-by: Mahmoud Mandour
---
This commit makes the plugin adhere to the new plugins arg-passing
scheme by expecting full-form boolean args instead of short-form
booleans. This necessitates that we introduce a new argument, here
"track", to accept "r", "w", or "rw".
Also, it makes arguments not positional and we only care
Made argument "inline" not positional, this has two benefits. First is
that we adhere to how QEMU passes args generally, by taking the last
value of an argument and drop the others. And the second is that this
sets up a framework for potentially adding new args easily.
Signed-off-by: Mahmoud
Since plugin arguments now expect boolean arguments, a plugin argument
name "sortby" now expects a value of "read", "write", or "address".
"io" arg is now expected to be passed as a full-form boolean parameter,
i.e. "io=on|true|yes|off|false|no"
Signed-off-by: Mahmoud Mandour
---
This call will help boolean argument parsing since arguments are now
passed to plugins as a name and value.
Signed-off-by: Mahmoud Mandour
---
include/qemu/qemu-plugin.h | 13 +
plugins/api.c | 5 +
2 files changed, 18 insertions(+)
diff --git
Signed-off-by: Mahmoud Mandour
---
tests/plugin/syscall.c | 23 ---
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/tests/plugin/syscall.c b/tests/plugin/syscall.c
index 6dd71092e1..484b48de49 100644
--- a/tests/plugin/syscall.c
+++ b/tests/plugin/syscall.c
@@
Hello,
This series removes passing arguments to plugins through "arg=" since
it's redundant and reduces readability especially when the argument
itself is composed of a name and a value.
Also, passing arguments through "arg=" still works but is marked as
deprecated and will produce a deprecation
1 - 100 of 107 matches
Mail list logo
