The gen_pred_cancel() function, introduced in commit a646e99cb90
(Hexagon macros) doesn't use the 'one' TCG temporary; remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
target/hexagon/macros.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/target/hexagon/macros.h b/target/hexagon/macros
Replace uses of tcg_const_* with the allocate and free close together.
Inspired-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
target/hexagon/gen_tcg.h| 6 ++---
target/hexagon/macros.h | 3 +--
target/hexagon/genptr.c | 39 +++-
Replace temporary TCG registers by tcg_constant_*() when possible.
Philippe Mathieu-Daudé (2):
target/hexagon: Remove unused TCG temporary from predicated loads
target/hexagon: Use tcg_constant_*
target/hexagon/gen_tcg.h| 6 ++---
target/hexagon/macros.h | 5 +
target/h
MSA 2R/2RF instructions don't use any target vector register.
Remove the unused TCG temporaries.
Fixes: cbe50b9a8e7 ("target-mips: add MSA VEC/2R format instructions")
Fixes: 3bdeb68866e ("target-mips: add MSA 2RF format instructions")
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/tcg/ms
On 10/3/21 01:30, Philippe Mathieu-Daudé wrote:
> Replace uses of tcg_const_* with the allocate and free close together.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> target/nios2/translate.c | 14 --
> 1 file changed, 4 insertions(+), 10 deletions(-)
> @@ -448,9 +445,8 @@ stati
Replace uses of tcg_const_* with the allocate and free close together.
Signed-off-by: Philippe Mathieu-Daudé
---
target/nios2/translate.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/target/nios2/translate.c b/target/nios2/translate.c
index 8524a2f6dd8..8d4
Instead of using a temporary for $zero, keep a reference to the
constant pool.
Signed-off-by: Philippe Mathieu-Daudé
---
target/nios2/translate.c | 17 ++---
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/target/nios2/translate.c b/target/nios2/translate.c
index 08d7a
We already have a register holding the zero value in the constant
pool, use it instead of a temporary.
Signed-off-by: Philippe Mathieu-Daudé
---
target/nios2/translate.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/target/nios2/translate.c b/target/nios2/translate.c
ind
Replace temporary TCG registers by tcg_constant_*() when possible.
Philippe Mathieu-Daudé (3):
target/nios2: Replace load_zero() by zero constant in DisasContext
target/nios2: Use DisasContext::zero constant instead of temporary
target/nios2: Use tcg_constant_*
target/nios2/translate.c | 3
From: Andrew Jeffery
This model implements enough behaviour to do basic functionality tests
such as device initialisation and read out of dummy sample values. The
sample value generation strategy is similar to the STM ADC already in
the tree.
This patch was originally created by Andrew Jeffery,
From: Andrew Jeffery
Signed-off-by: Andrew Jeffery
Signed-off-by: Cédric Le Goater
Signed-off-by: Peter Delevoryas
---
hw/arm/aspeed_ast2600.c | 11 +++
hw/arm/aspeed_soc.c | 11 +++
include/hw/arm/aspeed_soc.h | 2 ++
3 files changed, 24 insertions(+)
diff --git
From: Peter Delevoryas
Following up from
https://lore.kernel.org/qemu-devel/20210930004235.1656003-1-p...@fb.com/
This is a resubmission of Andrew Jeffery's ADC model, but with the
registers converted from typed-member-fields to a regs[] array.
Otherwise, it should be pretty much equivalent.
R
When running on a Mac, QEMU is able to get the host OSK and use it as
the default value for the AppleSMC device. The OSK query operation
doesn't require administrator privileges and can be executed by any user
on the system. This patch is based on open-source code from Apple, just
like the implemen
On 10/2/21 9:37 AM, Philippe Mathieu-Daudé wrote:
-static inline void gen_mfc0_load64(TCGv arg, target_ulong off)
-{
-tcg_gen_ld_tl(arg, cpu_env, off);
-tcg_gen_ext32s_tl(arg, arg);
-}
-
static inline void gen_mtc0_store32(TCGv arg, target_ulong off)
{
TCGv_i32 t0 = tcg_temp_new
On Sat, 2 Oct 2021, BALATON Zoltan wrote:
Interestingly on pegasos2 which has UHCI instead of OHCI MorphOS does not
even correctly detect the emulated usb-audio device and trying to get info
makes it freeze so looks like the UHCI model may also have some problems of
its own.
So it's not the U
On 10/2/21 9:37 AM, Philippe Mathieu-Daudé wrote:
From: Leon Alrae
Remove misleading gen_mfc0_load64() which actually loads 32 or 64 bits
depending whether MIPS32 or MIPS64 and also replace the pair of
tcg_gen_ld_tl() + tcg_gen_ext32s_tl() with single tcg_gen_ld32s_tl().
Patch partly generated
On 10/2/21 5:56 AM, Markus Armbruster wrote:
The following changes since commit 5f992102383ed8ed97076548e1c897c7034ed8a4:
Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into
staging (2021-10-01 13:44:36 -0400)
are available in the Git repository at:
git://repo.or.cz/qe
在 2021/10/2 14:37, Philippe Mathieu-Daudé 写道:
From: Leon Alrae
Remove misleading gen_mfc0_load64() which actually loads 32 or 64 bits
depending whether MIPS32 or MIPS64 and also replace the pair of
tcg_gen_ld_tl() + tcg_gen_ext32s_tl() with single tcg_gen_ld32s_tl().
Patch partly generated
ELF kernel allows us debugging much easier with DWARF symbols.
Signed-off-by: Jiaxun Yang
Reviewed-by: Philippe Mathieu-Daudé
--
v2: Use g_autofree
v3: Remove unused kernel_low and uint64_t cast (BALATON)
---
hw/mips/boston.c | 35 +++
1 file changed, 31 insertio
Use memmap array to uinfy address of memory map.
That would allow us reuse address information for FDT generation.
Signed-off-by: Jiaxun Yang
Reviewed-by: Philippe Mathieu-Daudé
--
v2: Fix minor style issue, fix uart map size
---
hw/mips/boston.c | 95 ---
Jiaxun Yang (3):
hw/mips/boston: Massage memory map information
hw/mips/boston: Allow loading elf kernel and dtb
hw/mips/boston: Add FDT generator
hw/mips/boston.c | 348 +++
1 file changed, 320 insertions(+), 28 deletions(-)
--
2.30.2
Generate FDT on our own if no dtb argument supplied.
Avoid introducing unused device in FDT with user supplied dtb.
Signed-off-by: Jiaxun Yang
--
v2: Address f4bug cmments (Thanks!)
---
hw/mips/boston.c | 234 +--
1 file changed, 226 insertions(+), 8 d
On Sat, 2 Oct 2021, Howard Spoelstra wrote:
Both have issues communicating with endpoint 4 (the hid controls volume
up/down and mute).
Endpoint 1 should receive the isochronous audio stream, but never does.
After some experimentation with unplugging/plugging the headset and probing
the usb stack
On Thu, Sep 9, 2021 at 4:17 AM Philippe Mathieu-Daudé wrote:
>
> On 9/8/21 8:50 PM, Peter Xu wrote:
> > On Mon, Sep 06, 2021 at 03:01:54PM +0200, Philippe Mathieu-Daudé wrote:
> >> On 9/6/21 2:20 PM, Bin Meng wrote:
> >>> It's been a requirement that at least one function pointer for read
> >>> an
On Fri, 1 Oct 2021, BALATON Zoltan wrote:
Posted as RFC because it's unfinfished and untested as there seems to
be some regression with mac99 so it does not boot for me for some
reason I haven't debugged yet. Hope Howard can test it and see if it
changes any of the traces seen before.
I've now
On 10/1/21 19:11, Richard Henderson wrote:
> The fallback code in raise_sigsegv is sufficient for sparc.
>
> This makes all of the code in mmu_helper.c sysemu only, so remove
> the ifdefs and move the file to sparc_softmmu_ss. Remove the code
> from cpu_loop that handled TT_DFAULT and TT_TFAULT.
On 10/1/21 19:11, Richard Henderson wrote:
> We have replaced tlb_fill with record_sigsegv for user mod.
Typo "user mode"?
> Move the declaration to restrict it to system emulation.
>
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Richard Henderson
> ---
> include/hw/core/tcg-cpu-ops.
On 10/1/21 19:11, Richard Henderson wrote:
> The fallback code in raise_sigsegv is sufficient for xtensa.
> Remove the code from cpu_loop that raised SIGSEGV.
>
> Cc: Max Filippov
> Signed-off-by: Richard Henderson
> ---
> target/xtensa/cpu.h | 2 +-
> linux-user/xtensa/cpu_loop.c |
On 10/1/21 19:11, Richard Henderson wrote:
> The fallback code in raise_sigsegv is sufficient for riscv.
> Remove the code from cpu_loop that raised SIGSEGV.
>
> Cc: qemu-ri...@nongnu.org
> Signed-off-by: Richard Henderson
> ---
> linux-user/riscv/cpu_loop.c | 7 ---
> target/riscv/cpu.c
On 10/1/21 19:11, Richard Henderson wrote:
> The fallback code in raise_sigsegv is sufficient for openrisc.
> This makes all of the code in mmu.c sysemu only, so remove
> the ifdefs and move the file to openrisc_softmmu_ss.
> Remove the code from cpu_loop that handled EXCP_DPF.
>
> Cc: Stafford Ho
On 10/1/21 19:11, Richard Henderson wrote:
> Because the linux-user kuser page handling is currently implemented
> by detecting magic addresses in the unnamed 0xaa trap, we cannot
> simply remove nios2_cpu_tlb_fill and rely on the fallback code.
>
> Signed-off-by: Richard Henderson
> ---
> targe
On 10/1/21 19:11, Richard Henderson wrote:
> The fallback code in raise_sigsegv is sufficient for mips linux-user.
> This means we can remove tcg/user/tlb_helper.c entirely.
> Remove the code from cpu_loop that raised SIGSEGV.
>
> Signed-off-by: Richard Henderson
> ---
> target/mips/tcg/tcg-inte
On 10/1/21 19:11, Richard Henderson wrote:
> The fallback code in raise_sigsegv is sufficient for m68k-linux-user.
> Remove the code from cpu_loop that handled EXCP_ACCESS.
>
> Signed-off-by: Richard Henderson
> ---
> linux-user/m68k/cpu_loop.c | 10 --
> target/m68k/cpu.c | 2
On 10/1/21 19:11, Richard Henderson wrote:
> Use the new os interface for raising the exception,
> rather than calling arm_cpu_tlb_fill directly.
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/mte_helper.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Phili
On 10/1/21 19:11, Richard Henderson wrote:
> The fallback code in raise_sigsegv is sufficient for alpha-linux-user.
Renamed to TCGCPUOps.record_sigsegv in patch #19 of this series.
Otherwise:
Reviewed-by: Philippe Mathieu-Daudé
> Remove the code from cpu_loop that handled EXCP_MMFAULT.
>
> Sig
On 10/1/21 19:11, Richard Henderson wrote:
> Split host_signal_pc and host_signal_write out of user-exec.c.
> Drop the *BSD code, to be re-created under bsd-user/ later.
>
> Signed-off-by: Richard Henderson
> ---
> linux-user/host/arm/host-signal.h | 30 -
> accel/tcg/user-ex
On 10/1/21 19:11, Richard Henderson wrote:
> Split host_signal_pc and host_signal_write out of user-exec.c.
> Drop the *BSD code, to be re-created under bsd-user/ later.
> Drop the Solais code as completely unused.
Typo 'Solaris'.
>
> Signed-off-by: Richard Henderson
> ---
> linux-user/host/sp
On Sat, 2 Oct 2021, Howard Spoelstra wrote:
Hi all,
I've booted Fedora12 and MacOS 9.2/OSX10.4 ppc with these patches applied.
All boot OK.
(Fedora12 requires -mac99,via=pmu. Here there seems to be some interference
with the kbd, due to via=pmu presenting usb mouse and kdb to the guest. So
I cou
On 10/2/21 13:00, Mark Cave-Ayland wrote:
> Whilst the in-built Quadra 800 framebuffer exists within the Nubus address
> space for slot 9, it has its own dedicated interrupt on VIA2. Force the
> macfb device to occupy slot 9 in the q800 machine and wire its IRQ to the
> separate video interrupt sin
On 10/2/21 13:00, Mark Cave-Ayland wrote:
> Since the available resolutions and colour depths are determined by the
> attached
> display type, add a qdev property to allow the display type to be specified.
>
> The main resolutions of interest are high resolution 1152x870 with 8-bit
> colour
> an
On 10/2/21 13:00, Mark Cave-Ayland wrote:
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/display/macfb.c | 8 +++-
> hw/display/trace-events | 4
> 2 files changed, 11 insertions(+), 1 deletion(-)
> @@ -289,7 +290,10 @@ static uint64_t macfb_ctrl_read(void *opaque,
>
On 10/2/21 12:59, Mark Cave-Ayland wrote:
> Currently macfb_common_realize() defines the framebuffer RAM memory region as
> being non-migrateable but then immediately registers it for migration. Replace
> memory_region_init_ram_nomigrate() with memory_region_init_ram() which is
> clearer
> and doe
On 10/2/21 12:59, Mark Cave-Ayland wrote:
> During realize memory_region_init_ram_nomigrate() is used to initialise the
> RAM
> memory region used for the framebuffer but the owner object reference is
> incorrect since MacFbState is a typedef and not a QOM type.
>
> Change the memory region owner
On 10/2/21 12:59, Mark Cave-Ayland wrote:
> Make sure any errors that occur within the macfb realize chain are detected
> and handled correctly to prevent crashes and to ensure that error messages are
> reported back to the user.
>
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/display/macfb.c | 1
On 10/2/21 14:31, Mark Cave-Ayland wrote:
> Coverity points out that there is memory leak because name is never freed
> after
> use in nubus_device_realize().
>
> Fixes: Coverity CID 1464062
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/nubus/nubus-device.c | 1 +
> 1 file changed, 1 insertion(+
On 10/2/21 14:31, Mark Cave-Ayland wrote:
> Coverity thinks that the slot_offset multiplications in nubus_device_realize()
> might overflow because the resulting hwaddr is 64-bit whilst the
> multiplication
> is only done at 32-bits.
>
> Add an explicit ULL suffix to NUBUS_SUPER_SLOT_SIZE and NUB
From: Leon Alrae
Remove misleading gen_mfc0_load64() which actually loads 32 or 64 bits
depending whether MIPS32 or MIPS64 and also replace the pair of
tcg_gen_ld_tl() + tcg_gen_ext32s_tl() with single tcg_gen_ld32s_tl().
Patch partly generated using the following spatch script:
@@
expr
On Wed, Sep 29, 2021 at 06:37:54AM +0200, Klaus Jensen wrote:
On Aug 3 12:54, Padmakar Kalghatgi wrote:
From: padmakar
This patch contains the implementation of certain commands
of nvme-mi specification.The MI commands are useful to
manage/configure/monitor the device.Eventhough the MI comman
Kevin Wolf writes:
> Am 17.09.2021 um 10:26 hat Markus Armbruster geschrieben:
[...]
>> >> We actually require much less: for QMP chardev-add, we need
>> >> 'data.addr.data.FOO' and nothing else, and for CLI -chardev, we need
>> >> 'FOO' and nothing else (I think). The unneeded ones become acc
On 10/1/21 1:59 PM, Brian Cain wrote:
If there's any trust concerns we can verify the download in the dockerfile
using the hash file for the tarball and/or the gpg signature.
That's true, I should have thought of that.
r~
From: Dov Murik
Add the sev_add_kernel_loader_hashes function to calculate the hashes of
the kernel/initrd/cmdline and fill a designated OVMF encrypted hash
table area. For this to work, OVMF must support an encrypted area to
place the data which is advertised via a special GUID in the OVMF rese
Move qmp_query_sev() & hmp_info_sev()() from monitor.c to sev.c
and make sev_get_info() static. We don't need the stub anymore,
remove it. Add a stub for hmp_info_sev().
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/sev_i386.h| 3 ---
target/i386/monitor.c | 38 +
Move qmp_sev_inject_launch_secret() from monitor.c to sev.c
and make sev_inject_launch_secret() static. We don't need the
stub anymore, remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/monitor.c | 31 ---
target/i386/sev-sysemu-stub.c | 6 +++-
Add an entry to list SEV-related files.
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 50435b8d2f5..733a5201e76 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3038,6 +3038,13 @@ F: hw/core/clock-vms
Only declare sev_enabled() and sev_es_enabled() when CONFIG_SEV is
set, to allow the compiler to elide unused code. Remove unnecessary
stubs.
Signed-off-by: Philippe Mathieu-Daudé
---
include/sysemu/sev.h| 14 +-
target/i386/sev_i386.h | 3 ---
target/i386/cpu.c | 16
From: Dov Murik
If SEV is enabled and a kernel is passed via -kernel, pass the hashes of
kernel/initrd/cmdline in an encrypted guest page to OVMF for SEV
measured boot.
Co-developed-by: James Bottomley
Signed-off-by: James Bottomley
Signed-off-by: Dov Murik
Reviewed-by: Daniel P. Berrangé
Me
SEV is irrelevant on user emulation, so restrict it to sysemu.
Some stubs are still required because used in cpu.c by
x86_register_cpudef_types(), so move the sysemu specific stubs
to sev-sysemu-stub.c instead. This will allow us to simplify
monitor.c (which is not available in user emulation) in t
Move qmp_query_sev_launch_measure() from monitor.c to sev.c
and make sev_get_launch_measurement() static. We don't need the
stub anymore, remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/sev_i386.h| 1 -
target/i386/monitor.c | 17 -
target/i386/s
Move qmp_query_sev_capabilities() from monitor.c to sev.c
and make sev_get_capabilities() static. We don't need the
stub anymore, remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/sev_i386.h| 1 -
target/i386/monitor.c | 5 -
target/i386/sev-sysemu-stub.c | 4 +
Commit 00b81053244 ("target-i386: Remove assert_no_error usage")
forgot to add the "qapi/error.h" for &error_abort, add it now.
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Connor Kuehl
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/cpu.c | 1 +
1 file changed, 1 insertion(+)
diff
The unique sev_encrypt_flash() invocation (in pc_system_flash_map)
is protected by the "if (sev_enabled())" check, so is not
reacheable.
Replace the abort() call in sev_es_save_reset_vector() by
g_assert_not_reached() which meaning is clearer.
Reviewed-by: Connor Kuehl
Signed-off-by: Philippe Mat
Move qmp_query_sev_attestation_report() from monitor.c to sev.c
and make sev_get_attestation_report() static. We don't need the
stub anymore, remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/sev_i386.h| 2 --
target/i386/monitor.c | 6 --
target/i386/sev-sys
SEV is x86-specific, no need to add its stub to other
architectures. Move the stub file to target/i386/kvm/.
Signed-off-by: Philippe Mathieu-Daudé
---
{accel => target/i386}/kvm/sev-stub.c | 0
accel/kvm/meson.build | 1 -
target/i386/kvm/meson.build | 2 ++
3 files cha
On 10/2/21 6:09 AM, Peter Maydell wrote:
On Sat, 2 Oct 2021 at 01:41, Richard Henderson
wrote:
On 9/30/21 10:57 AM, Paolo Bonzini wrote:
The following changes since commit ba0fa56bc06e563de68d2a2bf3ddb0cfea1be4f9:
Merge remote-tracking branch
'remotes/vivier/tags/q800-for-6.2-pull-reque
From: "Dr. David Alan Gilbert"
Removes a whole bunch of g_free's and a goto.
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Connor Kuehl
Reviewed-by: Brijesh Singh
Message-Id: <20210603113017.34922-1-dgilb...@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/sev.c | 11 +
Declarations don't require these headers, remove them.
Reviewed-by: Connor Kuehl
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/sev_i386.h | 4
target/i386/sev-stub.c | 1 +
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/target/i386/sev_i386.h b/target/i386/sev_i386.h
There is already a section with various SEV commands / types,
so move the SEV guest attestation together.
Signed-off-by: Philippe Mathieu-Daudé
---
qapi/misc-target.json | 80 +--
1 file changed, 40 insertions(+), 40 deletions(-)
diff --git a/qapi/misc-ta
Signed-off-by: Philippe Mathieu-Daudé
---
include/monitor/hmp-target.h | 1 +
include/monitor/hmp.h | 1 -
target/i386/sev-sysemu-stub.c | 2 +-
target/i386/sev.c | 2 +-
4 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/monitor/hmp-target.h b/include/mon
Wrap long lines before 70 characters for legibility.
Suggested-by: Markus Armbruster
Reviewed-by: Markus Armbruster
Signed-off-by: Philippe Mathieu-Daudé
---
qapi/misc-target.json | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/qapi/misc-target.json b/qap
Unused dead code makes review harder, so remove it.
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Connor Kuehl
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/sev_i386.h | 1 -
target/i386/sev-stub.c | 5 -
target/i386/sev.c | 9 -
3 files changed, 15 deletions(-)
di
Introduce the i386_softmmu_kvm Meson source set to be able to
add features dependent on CONFIG_KVM.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/kvm/meson.build | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/target/i386/kvm/meson.build b/target/i386/kvm/meson.b
While prefixed with sysemu, 'sysemu/sev.h' contains the architecture
specific declarations. The system specific parts are declared in
'sev_i386.h'.
Signed-off-by: Philippe Mathieu-Daudé
---
include/sysemu/sev.h | 6 --
target/i386/sev_i386.h | 7 +++
hw/i386/pc_sysfw.c | 2 +-
3 fi
If the management layer tries to inject a secret, it gets an empty
response in case the binary built without SEV:
{ "execute": "sev-inject-launch-secret",
"arguments": { "packet-header": "mypkt", "secret": "mypass", "gpa":
4294959104 }
}
{
"return": {
}
}
Make it clearer
Hi,
While testing James & Dov patch:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg810571.html
I wasted some time trying to figure out how OVMF was supposed to
behave until realizing the binary I was using was built without SEV
support... Then wrote this series to help other developers to
Coverity thinks that the slot_offset multiplications in nubus_device_realize()
might overflow because the resulting hwaddr is 64-bit whilst the multiplication
is only done at 32-bits.
Add an explicit ULL suffix to NUBUS_SUPER_SLOT_SIZE and NUBUS_SUPER_SLOT_SIZE
to ensure that the multiplication is
Coverity points out that there is memory leak because name is never freed after
use in nubus_device_realize().
Fixes: Coverity CID 1464062
Signed-off-by: Mark Cave-Ayland
---
hw/nubus/nubus-device.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/nubus/nubus-device.c b/hw/nubus/nubus-devi
These patches fix a couple of issues found by Coverity in the recent nubus
patchset as reported by Peter.
Signed-off-by: Mark Cave-Ayland
Mark Cave-Ayland (2):
nubus.h: add ULL suffix to NUBUS_SUPER_SLOT_SIZE and
NUBUS_SUPER_SLOT_SIZE
nubus-device: ensure that name is freed after use in
On Sat, 2 Oct 2021, Mark Cave-Ayland wrote:
Currently macfb_common_realize() defines the framebuffer RAM memory region as
being non-migrateable but then immediately registers it for migration. Replace
memory_region_init_ram_nomigrate() with memory_region_init_ram() which is
clearer
and does exac
On Sat, 2 Oct 2021, Mark Cave-Ayland wrote:
During realize memory_region_init_ram_nomigrate() is used to initialise the RAM
memory region used for the framebuffer but the owner object reference is
incorrect since MacFbState is a typedef and not a QOM type.
Change the memory region owner to be th
On Sat, 2 Oct 2021, Mark Cave-Ayland wrote:
Make sure any errors that occur within the macfb realize chain are detected
and handled correctly to prevent crashes and to ensure that error messages are
reported back to the user.
Signed-off-by: Mark Cave-Ayland
---
hw/display/macfb.c | 11 +
Paolo Bonzini writes:
> On 01/10/21 19:15, Daniel P. Berrangé wrote:
>> On Fri, Oct 01, 2021 at 07:08:51PM +0200, Paolo Bonzini wrote:
>>> On 29/09/21 04:58, Yanan Wang wrote:
@@ -933,8 +935,7 @@ static void machine_set_smp(Object *obj, Visitor *v,
const char *name,
ret
According to Apple Technical Note HW26: "Macintosh Quadra Built-In Video" the
in-built framebuffer encodes each 24-bit pixel into 4 bytes. Adjust the 24-bit
RGB pixel encoding accordingly which agrees with the encoding expected by MacOS
when changing into 24-bit colour mode.
Signed-off-by: Mark Ca
The MacOS toolbox ROM uses the monitor sense to detect the display type and then
offer a fixed set of resolutions and colour depths accordingly. Implement the
monitor sense using information found in Apple Technical Note HW26: "Macintosh
Quadra Built-In Video" along with some local experiments.
Si
Whilst the in-built Quadra 800 framebuffer exists within the Nubus address
space for slot 9, it has its own dedicated interrupt on VIA2. Force the
macfb device to occupy slot 9 in the q800 machine and wire its IRQ to the
separate video interrupt since this is what is expected by the MacOS
interrupt
Since the available resolutions and colour depths are determined by the attached
display type, add a qdev property to allow the display type to be specified.
The main resolutions of interest are high resolution 1152x870 with 8-bit colour
and SVGA resolution up to 800x600 with 32-bit colour so upda
The MacOS driver expects a 60.15Hz vertical blank interrupt to be generated by
the framebuffer which in turn schedules the mouse driver via the Vertical
Retrace
Manager.
Signed-off-by: Mark Cave-Ayland
---
hw/display/macfb.c | 81 ++
include/hw/displa
The palette_current index counter has a maximum size of 256 * 3 to cover a full
color palette of 256 RGB entries. Linux assumes that the palette_current index
wraps back around to zero after writing 256 RGB entries so ensure that
palette_current is reset at this point to prevent data corruption wit
The MacOS driver expects the RGB values for the pixel to be in entries 0 and 1
of the colour palette.
Signed-off-by: Mark Cave-Ayland
---
hw/display/macfb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/display/macfb.c b/hw/display/macfb.c
index 6a69334565..0c9e181b9b
Currently macfb_common_realize() defines the framebuffer RAM memory region as
being non-migrateable but then immediately registers it for migration. Replace
memory_region_init_ram_nomigrate() with memory_region_init_ram() which is
clearer
and does exactly the same thing.
Signed-off-by: Mark Cave-
The monitor modes table is found by experimenting with the Monitors Control
Panel in MacOS and analysing the reads/writes. From this it can be found that
the mode is controlled by writes to the DAFB_MODE_CTRL1 and DAFB_MODE_CTRL2
registers.
Implement the first block of DAFB registers as a register
Signed-off-by: Mark Cave-Ayland
---
hw/display/macfb.c | 8 +++-
hw/display/trace-events | 4
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/hw/display/macfb.c b/hw/display/macfb.c
index e86f64..62c2727a5b 100644
--- a/hw/display/macfb.c
+++ b/hw/display/macfb.c
During realize memory_region_init_ram_nomigrate() is used to initialise the RAM
memory region used for the framebuffer but the owner object reference is
incorrect since MacFbState is a typedef and not a QOM type.
Change the memory region owner to be the corresponding DeviceState to fix the
issue a
This is the next set of patches to allow users to boot MacOS in QEMU's
q800 machine.
Patches 1 to 3 are fixes for existing bugs that I discovered whilst
developing the remainder of the patchset whilst patch 4 simplifies the
registration of the framebuffer RAM.
Patch 5 adds trace events to the fra
Make sure any errors that occur within the macfb realize chain are detected
and handled correctly to prevent crashes and to ensure that error messages are
reported back to the user.
Signed-off-by: Mark Cave-Ayland
---
hw/display/macfb.c | 11 +++
1 file changed, 11 insertions(+)
diff --
On Thu, 30 Sept 2021 at 06:44, David Gibson wrote:
>
> From: Cédric Le Goater
>
> The current way the mask is built can overflow with a 64-bit decrementer.
> Use sextract64() to extract the signed values and remove the logic to
> handle negative values which has become useless.
>
> Cc: Luis Ferna
On Wed, 29 Sept 2021 at 10:49, Laurent Vivier wrote:
>
> From: Mark Cave-Ayland
>
> According to "Designing Cards and Drivers for the Macintosh Family" each
> physical
> nubus slot can access 2 separate address ranges: a super slot memory region
> which
> is 256MB and a standard slot memory reg
On Wed, 29 Sept 2021 at 10:53, Laurent Vivier wrote:
>
> From: Mark Cave-Ayland
>
> The declaration ROM is located at the top-most address of the standard slot
> space.
>
> Signed-off-by: Mark Cave-Ayland
> Reviewed-by: Laurent Vivier
> Message-Id: <20210924073808.1041-12-mark.cave-ayl...@iland
On Fri, 17 Sept 2021 at 06:24, Tong Ho wrote:
>
> This series implements the Xilinx eFUSE and BBRAM devices for
> the Versal and ZynqMP product families.
>
> Furthermore, both new devices are connected to the xlnx-versal-virt
> board and the xlnx-zcu102 board.
>
> See changes in docs/system/arm/xl
On Sat, 2 Oct 2021 at 01:41, Richard Henderson
wrote:
>
> On 9/30/21 10:57 AM, Paolo Bonzini wrote:
> > The following changes since commit ba0fa56bc06e563de68d2a2bf3ddb0cfea1be4f9:
> >
> >Merge remote-tracking branch
> > 'remotes/vivier/tags/q800-for-6.2-pull-request' into staging (2021-09-29
From: John Snow
Pylint informs us we're not using these arguments. Oops, it's
right. Correct the error message and remove the remaining unused
parameter.
Fix test output now that the error message is improved.
Fixes: e151941d1b
Signed-off-by: John Snow
Message-Id: <20210930205716.1148693-4-js.
1 - 100 of 115 matches
Mail list logo
