Re: [PATCH v1 1/2] migration: block-dirty-bitmap: add missing qemu_mutex_lock_iothread

2021-11-02 Thread Juan Quintela
Emanuele Giuseppe Esposito wrote: > init_dirty_bitmap_migration assumes the iothread lock (BQL) > to be held, but instead it isn't. > > Instead of adding the lock to qemu_savevm_state_setup(), > follow the same pattern as the other ->save_setup callbacks > and lock+unlock inside dirty_bitmap_save_

Re: [PATCH 2/2] failover: don't allow to migrate a paused VM that needs PCI unplug

2021-11-02 Thread Juan Quintela
Laurent Vivier wrote: > As the guest OS is paused, we will never receive the unplug event > from the kernel and the migration cannot continue. > > Signed-off-by: Laurent Vivier Reviewed-by: Juan Quintela queued. I can't think of a better solution.

Re: [PATCH 1/2] migration: provide an error message to migration_cancel()

2021-11-02 Thread Juan Quintela
Laurent Vivier wrote: > This avoids to call migrate_get_current() in the caller function > whereas migration_cancel() already needs the pointer to the current > migration state. > > Signed-off-by: Laurent Vivier Reviewed-by: Juan Quintela queued. > error_setg(&err, "RAM block '%s' r

Re: [PATCH v2 7/7] hw/arm: Add ID for NPCM7XX SMBus

2021-11-02 Thread Philippe Mathieu-Daudé
+Markus/Eduardo On 11/1/21 18:33, Peter Maydell wrote: > On Thu, 21 Oct 2021 at 19:40, Hao Wu wrote: >> >> The ID can be used to indicate SMBus modules when adding >> dynamic devices to them. >> >> Signed-off-by: Hao Wu >> --- >> hw/arm/npcm7xx.c | 1 + >> 1 file changed, 1 insertion(+) >> >> d

Re: [PATCH v3 3/3] hw/i386: expose a "smbios-entry-point-type" PC machine property

2021-11-02 Thread Philippe Mathieu-Daudé
On 10/26/21 17:11, Eduardo Habkost wrote: > The i440fx and Q35 machine types are both hardcoded to use the > legacy SMBIOS 2.1 (32-bit) entry point. This is a sensible > conservative choice because SeaBIOS only supports SMBIOS 2.1 > > EDK2, however, can also support SMBIOS 3.0 (64-bit) entry point

Re: [PATCH v2] failover: specify an alternate MAC address

2021-11-02 Thread Michael S. Tsirkin
On Tue, Nov 02, 2021 at 09:14:51AM +0100, Laurent Vivier wrote: > On 01/11/2021 10:39, Michael S. Tsirkin wrote: > > On Wed, Oct 27, 2021 at 11:59:45AM +0200, Laurent Vivier wrote: > > > If the guest driver doesn't support the STANDBY feature, by default > > > we keep the virtio-net device and don'

Re: [RFC PATCH v5 11/26] vhost: Handle host notifiers in SVQ

2021-11-02 Thread Eugenio Perez Martin
On Tue, Nov 2, 2021 at 8:55 AM Jason Wang wrote: > > > 在 2021/10/30 上午2:35, Eugenio Pérez 写道: > > If device supports host notifiers, this makes one jump less (kernel) to > > deliver SVQ notifications to it. > > > > Signed-off-by: Eugenio Pérez > > --- > > hw/virtio/vhost-shadow-virtqueue.h | 2

[PATCH v5 3/6] tests/acceptance: Introduce QemuUserTest base class

2021-11-02 Thread Philippe Mathieu-Daudé
Similarly to the 'System' Test base class with methods for testing system emulation, the QemuUserTest class contains methods useful to test user-mode emulation. Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Willian Rampazzo Signed-off-by: Philippe Mathieu-Daudé --- v5: Use PEP3135, use

[PATCH v5 6/6] tests/acceptance: Rename avocado_qemu.Test -> QemuSystemTest

2021-11-02 Thread Philippe Mathieu-Daudé
To run user-mode emulation tests, we introduced the avocado_qemu.QemuUserTest which inherits from avocado_qemu.QemuBaseTest. System-mode emulation tests are based on the avocado_qemu.Test class, which also inherits avocado_qemu.QemuBaseTest. To avoid confusion, rename it as avocado_qemu.QemuSystemT

[PATCH v5 4/6] tests/acceptance: Share useful helpers from virtiofs_submounts test

2021-11-02 Thread Philippe Mathieu-Daudé
Move the useful has_cmd()/has_cmds() helpers from the virtiofs test to the avocado_qemu public class. Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Willian Rampazzo Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/avocado_qemu/__init__.py | 57 ++ tests/ac

[PATCH v5 0/6] tests/acceptance: Add bFLT loader linux-user test

2021-11-02 Thread Philippe Mathieu-Daudé
Since v4: - rebased - addressed Willian review comments Since v3: - rebased - addressed Wainer review comments from v2 - rename avocado_qemu.Test -> QemuSystemTest Since v2: - rebased tests/acceptance/avocado_qemu/__init__.py patches - extract has_cmd() from virtiofs_submounts.py - check cpio ava

[PATCH v5 5/6] tests/acceptance: Add bFLT loader linux-user test

2021-11-02 Thread Philippe Mathieu-Daudé
Add a very quick test that runs a busybox binary in bFLT format: $ AVOCADO_ALLOW_UNTRUSTED_CODE=1 \ avocado --show=app run -t linux_user tests/acceptance/load_bflt.py JOB ID : db94d5960ce564c50904d666a7e259148c27e88f JOB LOG: ~/avocado/job-results/job-2019-06-25T10.52-db94d59/job

[PATCH v5 2/6] tests/acceptance: Make pick_default_qemu_bin() more generic

2021-11-02 Thread Philippe Mathieu-Daudé
Make pick_default_qemu_bin() generic to find qemu-system or qemu-user binaries. Reviewed-by: Willian Rampazzo Signed-off-by: Philippe Mathieu-Daudé --- v5: Use PEP3135 --- tests/acceptance/avocado_qemu/__init__.py | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/te

[PATCH v5 1/6] tests/acceptance: Extract QemuBaseTest from Test

2021-11-02 Thread Philippe Mathieu-Daudé
The Avocado Test::fetch_asset() is handy to download artifacts before running tests. The current class is named Test but only tests system emulation. As we want to test user emulation, refactor the common code as QemuBaseTest. Reviewed-by: Willian Rampazzo Signed-off-by: Philippe Mathieu-Daudé -

Re: [PATCH v8 02/29] target/loongarch: Add core definition

2021-11-02 Thread Philippe Mathieu-Daudé
On 11/1/21 10:51, Song Gao wrote: > This patch adds target state header, target definitions > and initialization routines. > > Reviewed-by: Richard Henderson > Signed-off-by: Song Gao > Signed-off-by: Xiaojuan Yang > --- > target/loongarch/cpu-param.h | 19 +++ > target/loongarch/cpu.c

Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq

2021-11-02 Thread Eugenio Perez Martin
On Tue, Nov 2, 2021 at 8:25 AM Juan Quintela wrote: > > Eugenio Pérez wrote: > > The -1 assumes that all devices with no cvq have an spare vq allocated > > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may not be the > > case, and the device may have a pair number of queues. >

Re: [PATCH v1 00/12] virtio-mem: Expose device memory via multiple memslots

2021-11-02 Thread David Hildenbrand
On 01.11.21 23:15, Michael S. Tsirkin wrote: > On Wed, Oct 27, 2021 at 02:45:19PM +0200, David Hildenbrand wrote: >> This is the follow-up of [1], dropping auto-detection and vhost-user >> changes from the initial RFC. >> >> Based-on: 20211011175346.15499-1-da...@redhat.com >> >> A virtio-mem devic

Re: [PATCH v8 00/29] Add LoongArch linux-user emulation support

2021-11-02 Thread Philippe Mathieu-Daudé
Hi, On 11/1/21 10:51, Song Gao wrote: > > This series only support linux-user emulation. > More about LoongArch at: https://github.com/loongson/ > > The latest kernel: > * https://github.com/loongson/linux/tree/loongarch-next > create mode 100644 target/loongarch/insn_trans/trans_arith.c >

Re: [RFC PATCH v5 05/26] vhost: Add x-vhost-set-shadow-vq qmp

2021-11-02 Thread Eugenio Perez Martin
On Tue, Nov 2, 2021 at 8:36 AM Juan Quintela wrote: > > Eugenio Pérez wrote: > > Command to set shadow virtqueue mode. > > > > Signed-off-by: Eugenio Pérez > > Reviewed-by: Juan Quintela > > You need to keep care of: > > Markus Armbruster ] [PATCH v2 0/9] Configurable policy for handling

Re: [RFC PATCH v5 23/26] util: Add iova_tree_alloc

2021-11-02 Thread Eugenio Perez Martin
On Tue, Nov 2, 2021 at 7:35 AM Jason Wang wrote: > > > 在 2021/10/30 上午2:35, Eugenio Pérez 写道: > > This iova tree function allows it to look for a hole in allocated > > regions and return a totally new translation for a given translated > > address. > > > > It's usage is mainly to allow devices to

Re: [PATCH v2] failover: specify an alternate MAC address

2021-11-02 Thread Laurent Vivier
On 01/11/2021 10:39, Michael S. Tsirkin wrote: On Wed, Oct 27, 2021 at 11:59:45AM +0200, Laurent Vivier wrote: If the guest driver doesn't support the STANDBY feature, by default we keep the virtio-net device and don't hotplug the VFIO device, but in some cases, user can prefer to use the VFIO d

Re: [RFC PATCH v5 21/26] vhost: Add vhost_svq_valid_guest_features to shadow vq

2021-11-02 Thread Eugenio Perez Martin
On Tue, Nov 2, 2021 at 6:26 AM Jason Wang wrote: > > On Sat, Oct 30, 2021 at 2:44 AM Eugenio Pérez wrote: > > > > This allows it to test if the guest has aknowledge an invalid transport > > feature for SVQ. This will include packed vq layout or event_idx, > > where VirtIO device needs help from S

Issue with acpi hotplug on pcie root ports in case of q35 + ovmf + machine type 6.1

2021-11-02 Thread lma
Hi list, Have you experienced any acpi hotplugging issue while using q35 + ovmf + machine type 6.1? According to the error message in guest kernel, It seems qemu with ovmf doesn't prepare enough resource in PCI space for acpi hotplugging on multifunction bridges. Please refer to issue#705 f

Re: [PATCH] meson.build: Allow to disable OSS again

2021-11-02 Thread Philippe Mathieu-Daudé
On 11/2/21 08:45, Thomas Huth wrote: > On 29/10/2021 11.32, Philippe Mathieu-Daudé wrote: >> On 10/29/21 09:13, Thomas Huth wrote: >>> If sys/soundcard.h is available, it is currently not possible to >>> disable OSS with the --disable-oss or --without-default-features >>> configure switches. Improv

Re: [RFC PATCH v5 22/26] vhost: Shadow virtqueue buffers forwarding

2021-11-02 Thread Jason Wang
在 2021/10/30 上午2:35, Eugenio Pérez 写道: Initial version of shadow virtqueue that actually forward buffers. There are no iommu support at the moment, and that will be addressed in future patches of this series. Since all vhost-vdpa devices uses forced IOMMU, this means that SVQ is not usable at t

Re: [RFC PATCH v5 11/26] vhost: Handle host notifiers in SVQ

2021-11-02 Thread Jason Wang
在 2021/10/30 上午2:35, Eugenio Pérez 写道: If device supports host notifiers, this makes one jump less (kernel) to deliver SVQ notifications to it. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.h | 2 ++ hw/virtio/vhost-shadow-virtqueue.c | 23 ++- 2 f

Re: [PATCH] meson.build: Allow to disable OSS again

2021-11-02 Thread Thomas Huth
On 29/10/2021 11.32, Philippe Mathieu-Daudé wrote: On 10/29/21 09:13, Thomas Huth wrote: If sys/soundcard.h is available, it is currently not possible to disable OSS with the --disable-oss or --without-default-features configure switches. Improve the check in meson.build to fix this. Fixes: 874

Re: [PATCH v2] hw/arm/virt: Expose empty NUMA nodes through ACPI

2021-11-02 Thread Andrew Jones
On Tue, Nov 02, 2021 at 10:44:08AM +1100, Gavin Shan wrote: > > Yeah, I agree. I don't have strong sense to expose these empty nodes > for now. Please ignore the patch. > So were describing empty numa nodes on the command line ever a reasonable thing to do? What happens on x86 machine types when

Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq

2021-11-02 Thread Juan Quintela
Eugenio Pérez wrote: > The -1 assumes that all devices with no cvq have an spare vq allocated > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may not be the > case, and the device may have a pair number of queues. > > To fix this, just resort to the lower even number of queues. > > Fix

Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq

2021-11-02 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Tue, Nov 02, 2021 at 08:25:27AM +0100, Juan Quintela wrote: >> Eugenio Pérez wrote: >> > The -1 assumes that all devices with no cvq have an spare vq allocated >> > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may not be the >> > case, and the device

Re: [RFC PATCH v5 05/26] vhost: Add x-vhost-set-shadow-vq qmp

2021-11-02 Thread Juan Quintela
Eugenio Pérez wrote: > Command to set shadow virtqueue mode. > > Signed-off-by: Eugenio Pérez Reviewed-by: Juan Quintela You need to keep care of: Markus Armbruster ] [PATCH v2 0/9] Configurable policy for handling unstable interfaces When this hit the tree, you need to drop the x- an

Re: [RFC PATCH v5 12/26] vhost: Route guest->host notification through shadow virtqueue

2021-11-02 Thread Eugenio Perez Martin
On Tue, Nov 2, 2021 at 6:36 AM Jason Wang wrote: > > > 在 2021/10/30 上午2:35, Eugenio Pérez 写道: > > +/** > > + * Enable or disable shadow virtqueue in a vhost vdpa device. > > + * > > + * This function is idempotent, to call it many times with the same value > > for > > + * enable_svq will simply r

Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq

2021-11-02 Thread Michael S. Tsirkin
On Tue, Nov 02, 2021 at 08:25:27AM +0100, Juan Quintela wrote: > Eugenio Pérez wrote: > > The -1 assumes that all devices with no cvq have an spare vq allocated > > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may not be the > > case, and the device may have a pair number of queues. >

Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq

2021-11-02 Thread Juan Quintela
Eugenio Pérez wrote: > The -1 assumes that all devices with no cvq have an spare vq allocated > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may not be the > case, and the device may have a pair number of queues. even I know, I know, I am Spanis

Re: [PATCH 00/15] hw/nvme: SR-IOV with Virtualization Enhancements

2021-11-02 Thread Klaus Jensen
On Oct 27 18:49, Lukasz Maniak wrote: > On Tue, Oct 26, 2021 at 08:20:12PM +0200, Klaus Jensen wrote: > > On Oct 7 18:23, Lukasz Maniak wrote: > > > Hi, > > > > > > This series of patches is an attempt to add support for the following > > > sections of NVMe specification revision 1.4: > > > > >

Re: [PATCH] vhost: Fix last queue index of devices with no cvq

2021-11-02 Thread Jason Wang
On Tue, Nov 2, 2021 at 2:59 PM Eugenio Perez Martin wrote: > > On Tue, Nov 2, 2021 at 5:09 AM Jason Wang wrote: > > > > On Mon, Nov 1, 2021 at 4:59 PM Eugenio Perez Martin > > wrote: > > > > > > On Mon, Nov 1, 2021 at 4:34 AM Jason Wang wrote: > > > > > > > > On Fri, Oct 29, 2021 at 10:16 PM E

Re: [PATCH] vhost: Fix last queue index of devices with no cvq

2021-11-02 Thread Eugenio Perez Martin
On Tue, Nov 2, 2021 at 5:09 AM Jason Wang wrote: > > On Mon, Nov 1, 2021 at 4:59 PM Eugenio Perez Martin > wrote: > > > > On Mon, Nov 1, 2021 at 4:34 AM Jason Wang wrote: > > > > > > On Fri, Oct 29, 2021 at 10:16 PM Eugenio Pérez > > > wrote: > > > > > > > > The -1 assumes that all devices wi

<    1   2   3   4   5   6