Re: [PATCH v5 5/6] migration: Add migrate_use_tls() helper

2021-11-12 Thread Juan Quintela
Leonardo Bras wrote: > A lot of places check parameters.tls_creds in order to evaluate if TLS is > in use, and sometimes call migrate_get_current() just for that test. > > Add new helper function migrate_use_tls() in order to simplify testing > for TLS usage. > > Signed-off-by: Leonardo Bras

Re: [PATCH v4 05/25] block/block-backend.c: assertions for block-backend

2021-11-12 Thread Hanna Reitz
On 25.10.21 12:17, Emanuele Giuseppe Esposito wrote: All the global state (GS) API functions will check that qemu_in_main_thread() returns true. If not, it means that the safety of BQL cannot be guaranteed, and they need to be moved to I/O. Signed-off-by: Emanuele Giuseppe Esposito

Re: [PATCH v5 1/6] QIOChannel: Add io_writev_zerocopy & io_flush_zerocopy callbacks

2021-11-12 Thread Daniel P . Berrangé
On Fri, Nov 12, 2021 at 02:10:36AM -0300, Leonardo Bras wrote: > Adds io_writev_zerocopy and io_flush_zerocopy as optional callback to > QIOChannelClass, > allowing the implementation of zerocopy writes by subclasses. > > How to use them: > - Write data using qio_channel_writev_zerocopy(), > -

Re: [PATCH v5 3/6] QIOChannelSocket: Implement io_writev_zerocopy & io_flush_zerocopy for CONFIG_LINUX

2021-11-12 Thread Daniel P . Berrangé
On Fri, Nov 12, 2021 at 02:10:38AM -0300, Leonardo Bras wrote: > For CONFIG_LINUX, implement the new optional callbacks io_write_zerocopy and > io_flush_zerocopy on QIOChannelSocket, but enables it only when MSG_ZEROCOPY > feature is available in the host kernel, which is checked on >

Re: [PATCH for 6.2 v2 4/5] hw/i386/acpi-build: Deny control on PCIe Native Hot-plug in _OSC

2021-11-12 Thread Igor Mammedov
On Thu, 11 Nov 2021 11:19:30 +0530 (IST) Ani Sinha wrote: > On Wed, 10 Nov 2021, Igor Mammedov wrote: > > > From: Julia Suvorova > > > > There are two ways to enable ACPI PCI Hot-plug: > > > > * Disable the Hot-plug Capable bit on PCIe slots. > > > > This was the first approach which

Re: [PATCH for 6.2 v2 1/5] pcie: rename 'native-hotplug' to 'x-native-hotplug'

2021-11-12 Thread Igor Mammedov
On Thu, 11 Nov 2021 08:55:24 +0530 (IST) Ani Sinha wrote: > On Wed, 10 Nov 2021, Igor Mammedov wrote: > > > Mark property as experimental/internal adding 'x-' prefix. > > > > Property was introduced in 6.1 and it should have provided > > ability to turn on native PCIE hotplug on port even when

Re: [PATCH v2 0/1] Jobs based on custom runners: add CentOS Stream 8

2021-11-12 Thread Alex Bennée
Cleber Rosa writes: > This adds a new custom runner, showing an example of how other > entities can add their own custom jobs to the GitLab CI pipeline. > > > One example of a job introduced here, running on the host reserved for > this purpose can be seen at: > > -

Re: [PATCH v5 1/6] QIOChannel: Add io_writev_zerocopy & io_flush_zerocopy callbacks

2021-11-12 Thread Daniel P . Berrangé
On Fri, Nov 12, 2021 at 10:13:01AM +, Daniel P. Berrangé wrote: > On Fri, Nov 12, 2021 at 02:10:36AM -0300, Leonardo Bras wrote: > > Adds io_writev_zerocopy and io_flush_zerocopy as optional callback to > > QIOChannelClass, > > allowing the implementation of zerocopy writes by subclasses. > >

Re: [PATCH v4 04/25] include/sysemu/block-backend: split header into I/O and global state (GS) API

2021-11-12 Thread Hanna Reitz
On 25.10.21 12:17, Emanuele Giuseppe Esposito wrote: Similarly to the previous patches, split block-backend.h in block-backend-io.h and block-backend-global-state.h In addition, remove "block/block.h" include as it seems it is not necessary anymore, together with "qemu/iov.h"

Re: [PATCH for 6.2 v2 0/5] Fix Q35 ACPI PCI Hot-plug I/O issues

2021-11-12 Thread Igor Mammedov
On Fri, 12 Nov 2021 04:47:05 -0500 "Michael S. Tsirkin" wrote: > On Wed, Nov 10, 2021 at 04:11:35PM -0500, Igor Mammedov wrote: > > Changelog: > > v2: > > * simplify [1/5] and rename property to x-native-hotplug (CC stable) > > * [4/5] > >- rename function parameter to reflect

Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-11-12 Thread Gerd Hoffmann
Hi, > involved, but I think it's more a question of luck. This until these > specific patches, but they are only in v2 out of rfc status just today. Never posted a formal non-rfc version because I had no pending changes. Maybe I should have done that ... v2 has no functional changes, it only

Re: [PATCH v5 2/6] QIOChannelSocket: Add flags parameter for writing

2021-11-12 Thread Daniel P . Berrangé
On Fri, Nov 12, 2021 at 02:10:37AM -0300, Leonardo Bras wrote: > Change qio_channel_socket_writev() in order to accept flags, so its possible > to selectively make use of sendmsg() flags. > > qio_channel_socket_writev() contents were moved to a helper function > qio_channel_socket_writev_flags()

Re: [PATCH v5 1/6] QIOChannel: Add io_writev_zerocopy & io_flush_zerocopy callbacks

2021-11-12 Thread Daniel P . Berrangé
On Fri, Nov 12, 2021 at 02:10:36AM -0300, Leonardo Bras wrote: > Adds io_writev_zerocopy and io_flush_zerocopy as optional callback to > QIOChannelClass, > allowing the implementation of zerocopy writes by subclasses. > > How to use them: > - Write data using qio_channel_writev_zerocopy(), > -

Re: [PATCH v2 2/3] softmmu: fix watchpoint-interrupt races

2021-11-12 Thread David Hildenbrand
On 11.11.21 10:55, Pavel Dovgalyuk wrote: > Watchpoint may be processed in two phases. First one is detecting > the instruction with target memory access. And the second one is > executing only one instruction and setting the debug interrupt flag. > Hardware interrupts can break this sequence when

Re: [PATCH 1/2] virtio: use virtio accessor to access packed descriptor flags

2021-11-12 Thread Michael S. Tsirkin
On Fri, Nov 12, 2021 at 10:23:12AM +0800, Jason Wang wrote: > On Thu, Nov 11, 2021 at 4:27 PM Michael S. Tsirkin wrote: > > > > On Thu, Nov 11, 2021 at 02:38:53PM +0800, Jason Wang wrote: > > > We used to access packed descriptor flags via > > > address_space_{write|read}_cached(). When we hit

Re: [PATCH v10 16/26] target/loongarch: Add disassembler

2021-11-12 Thread gaosong
Hi Richard, On 2021/11/12 下午3:39, Richard Henderson wrote: On 11/12/21 7:53 AM, Song Gao wrote: +const char * const fccregnames[8] = { +  "$fcc0", "$fcc1", "$fcc2", "$fcc3", "$fcc4", "$fcc5", "$fcc6", "$fcc7", +}; static. OK. +static void output_fcsrdrj(DisasContext *ctx,

Re: [PATCH 05/10] vhost-backend: avoid overflow on memslots_limit

2021-11-12 Thread Daniel P . Berrangé
On Fri, Nov 12, 2021 at 10:46:46AM +0300, Roman Kagan wrote: > On Thu, Nov 11, 2021 at 06:59:43PM +0100, Philippe Mathieu-Daudé wrote: > > On 11/11/21 16:33, Roman Kagan wrote: > > > Fix the (hypothetical) potential problem when the value parsed out of > > > the vhost module parameter in sysfs

Re: [PATCH for 6.2 v2 0/5] Fix Q35 ACPI PCI Hot-plug I/O issues

2021-11-12 Thread Michael S. Tsirkin
On Wed, Nov 10, 2021 at 04:11:35PM -0500, Igor Mammedov wrote: > Changelog: > v2: > * simplify [1/5] and rename property to x-native-hotplug (CC stable) > * [4/5] >- rename function parameter to reflect actual action >- drop local 'hotplug' variable and opencode statement

Re: [PATCH v5 4/6] kvm: irqchip: extract kvm_irqchip_add_deferred_msi_route

2021-11-12 Thread Paolo Bonzini
On 11/3/21 09:16, Longpeng(Mike) wrote: Extract a common helper that add MSI route for specific vector but does not commit immediately. Signed-off-by: Longpeng(Mike) I think adding the new function is not necessary; I have no problem moving the call to kvm_irqchip_commit_routes to the

[PATCH v5 6/6] net/vmnet: update qemu-options.hx

2021-11-12 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- qemu-options.hx | 25 + 1 file changed, 25 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 7749f59300..350d43bbc0 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2677,6 +2677,25 @@ DEF("netdev", HAS_ARG,

[PATCH v5 5/6] net/vmnet: implement bridged mode (vmnet-bridged)

2021-11-12 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-bridged.m | 98 ++--- 1 file changed, 92 insertions(+), 6 deletions(-) diff --git a/net/vmnet-bridged.m b/net/vmnet-bridged.m index 4e42a90391..3c9da9dc8b 100644 --- a/net/vmnet-bridged.m +++

[PATCH v5 3/6] net/vmnet: implement shared mode (vmnet-shared)

2021-11-12 Thread Vladislav Yaroshchuk
Signed-off-by: Phillip Tennen Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-common.m | 305 + net/vmnet-shared.c | 75 ++- net/vmnet_int.h| 23 3 files changed, 399 insertions(+), 4 deletions(-) diff --git a/net/vmnet-common.m

[PATCH v5 4/6] net/vmnet: implement host mode (vmnet-host)

2021-11-12 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-host.c | 99 +--- 1 file changed, 93 insertions(+), 6 deletions(-) diff --git a/net/vmnet-host.c b/net/vmnet-host.c index 4a5ef99dc7..f7dbd3f9bf 100644 --- a/net/vmnet-host.c +++ b/net/vmnet-host.c @@

[PATCH v5 2/6] net/vmnet: add vmnet backends to qapi/net

2021-11-12 Thread Vladislav Yaroshchuk
Create separate netdevs for each vmnet operating mode: - vmnet-host - vmnet-shared - vmnet-bridged Signed-off-by: Vladislav Yaroshchuk --- net/clients.h | 11 net/meson.build | 7 +++ net/net.c | 10 net/vmnet-bridged.m | 25 + net/vmnet-common.m |

[PATCH v5 1/6] net/vmnet: add vmnet dependency and customizable option

2021-11-12 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- meson.build | 4 meson_options.txt | 2 ++ scripts/meson-buildoptions.sh | 3 +++ 3 files changed, 9 insertions(+) diff --git a/meson.build b/meson.build index 2ece4fe088..202e04af31 100644 --- a/meson.build +++

[PATCH v5 0/6] Add vmnet.framework based network backend

2021-11-12 Thread Vladislav Yaroshchuk
macOS provides networking API for VMs called 'vmnet.framework': https://developer.apple.com/documentation/vmnet We can provide its support as the new QEMU network backends which represent three different vmnet.framework interface usage modes: * `vmnet-shared`: allows the guest to

Re: [PATCH for 6.2 v2 5/5] bios-tables-test: Update golden binaries

2021-11-12 Thread Ani Sinha
On Thu, 11 Nov 2021, Ani Sinha wrote: > > > On Thu, 11 Nov 2021, Ani Sinha wrote: > > > > > > > On Thu, 11 Nov 2021, Michael S. Tsirkin wrote: > > > > > On Wed, Nov 10, 2021 at 04:11:40PM -0500, Igor Mammedov wrote: > > > > From: Julia Suvorova > > > > > > > > The changes are the result of >

Re: [PATCH 02/10] chardev/char-socket: tcp_chr_recv: don't clobber errno

2021-11-12 Thread Marc-André Lureau
On Thu, Nov 11, 2021 at 7:38 PM Roman Kagan wrote: > tcp_chr_recv communicates the specific error condition to the caller via > errno. However, after setting it, it may call into some system calls or > library functions which can clobber the errno. > > Avoid this by moving the errno assignment

Re: [PATCH 03/10] chardev/char-socket: tcp_chr_sync_read: don't clobber errno

2021-11-12 Thread Marc-André Lureau
On Thu, Nov 11, 2021 at 7:36 PM Roman Kagan wrote: > After the return from tcp_chr_recv, tcp_chr_sync_read calls into a > function which eventually makes a system call and may clobber errno. > > Make a copy of errno right after tcp_chr_recv and restore the errno on > return from

Re: [PATCH 1/2] hw/core/loader: return image sizes as ssize_t

2021-11-12 Thread Luc Michel
On 14:11 Thu 11 Nov , Jamie Iles wrote: > Various loader functions return an int which limits images to 2GB which > is fine for things like a BIOS/kernel image, but if we want to be able > to load memory images or large ramdisks then any file over 2GB would > silently fail to load. > > Cc:

Re: [PATCH 04/10] chardev/char-fe: don't allow EAGAIN from blocking read

2021-11-12 Thread Marc-André Lureau
Hi On Thu, Nov 11, 2021 at 7:44 PM Roman Kagan wrote: > As its name suggests, ChardevClass.chr_sync_read is supposed to do a > blocking read. The only implementation of it, tcp_chr_sync_read, does > set the underlying io channel to the blocking mode indeed. > > Therefore a failure return with

Re: [PATCH v4 2/6] net/vmnet: add vmnet backends to qapi/net

2021-11-12 Thread Vladislav Yaroshchuk
чт, 11 нояб. 2021 г., 11:49 PM Eric Blake : > On Thu, Nov 11, 2021 at 06:21:28PM +0300, Vladislav Yaroshchuk wrote: > > > > > +# > > > > +# Since: 6.2 > > > > > > Missed 6.2, please adjust. More of the same below. > > > > > > > > The next one is 6.3, isn't it? > > 7.0, actually, as it will be

Re: [PATCH 00/10] vhost: stick to -errno error return convention

2021-11-12 Thread Roman Kagan
On Thu, Nov 11, 2021 at 03:14:56PM -0500, Michael S. Tsirkin wrote: > On Thu, Nov 11, 2021 at 06:33:44PM +0300, Roman Kagan wrote: > > Error propagation between the generic vhost code and the specific backends > > is > > not quite consistent: some places follow "return -1 and set errno" > >

<    1   2