Re: [PATCH 0/3] Fix RVV calling incorrect RFV/RVD check functions bug

2021-12-29 Thread Frank Chang
On Wed, Dec 29, 2021 at 10:43 AM Frank Chang wrote: > 於 2021年12月29日 週三 上午10:13寫道: > >> From: Frank Chang >> >> For vector widening and narrowing floating-point instructions, we should >> use require_scale_rvf() instead of require_rvf() to check whether the >> correspond RVF/RVD is enabled if

Re: [PATCH v10 1/3] migration/dirtyrate: implement vCPU dirtyrate calculation periodically

2021-12-29 Thread Peter Xu
On Thu, Dec 30, 2021 at 01:01:09PM +0800, Hyman Huang wrote: > > > +/** > > > + * dirtylimit_calc_state_finalize > > > + * > > > + * finalize dirty page rate calculation state. > > > + */ > > > +void dirtylimit_calc_state_finalize(void); > > > +#endif > > > > Since dirtylimit and dirtyrate looks

Re: [PATCH v10 1/3] migration/dirtyrate: implement vCPU dirtyrate calculation periodically

2021-12-29 Thread Hyman Huang
在 2021/12/23 19:12, Peter Xu 写道: Hi, Yong, On Tue, Dec 14, 2021 at 07:07:32PM +0800, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Introduce the third method GLOBAL_DIRTY_LIMIT of dirty tracking for calculate dirtyrate periodly for dirty restraint. Implement thread for calculate

Re: [PATCH v11 29/31] linux-user: Implement CPU-specific signal handler for loongarch64 hosts

2021-12-29 Thread WANG Xuerui
Hi, On 12/30/21 11:11, gaosong wrote: HI, On 2021/12/21 下午1:41, WANG Xuerui wrote: +case 0b001110: /* indexed, atomic, bounds-checking memory operations */ +uint32_t sel = (insn >> 15) & 0b111; + +switch (sel) { +case 0b010: /* stx.b */ +

Re: [PATCH v11 29/31] linux-user: Implement CPU-specific signal handler for loongarch64 hosts

2021-12-29 Thread gaosong
HI, On 2021/12/21 下午1:41, WANG Xuerui wrote: +case 0b001110: /* indexed, atomic, bounds-checking memory operations */ +uint32_t sel = (insn >> 15) & 0b111; + +switch (sel) { +case 0b010: /* stx.b */ +case 0b0101000: /* stx.h */ +

Re: check-python-tox failures

2021-12-29 Thread Philippe Mathieu-Daudé
On 12/23/21 05:11, Richard Henderson wrote: > Hi John, > > This test has been failing for quite a while. While it is allowed to > fail, can we either fix this or disable it, to allow the ci to go proper > green? This job not only fails on the mainstream pipelines, but also on all forks recently

Re: [PULL 0/6] Block jobs patches

2021-12-29 Thread Richard Henderson
On 12/29/21 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: The following changes since commit 89f3bfa3265554d1d591ee4d7f1197b6e3397e84: Merge tag 'pull-pa-20211223' of https://gitlab.com/rth7680/qemu into staging (2021-12-23 17:53:36 -0800) are available in the Git repository at:

Re: [PATCH 0/2] dump: add 32-bit guest Windows support

2021-12-29 Thread Philippe Mathieu-Daudé
Hi Viktor, On 12/29/21 18:52, Viktor Prutyanov wrote: > Since 32-bit versions of Windows still exist, there is a need to take > live and crash dumps of such guests along with 64-bit guests. So, add > an ability for 'dump-guest-memory -w' to take dumps from 32-bit guest. > When running the command

[PATCH] gitlab-ci: Always upload artifacts by default

2021-12-29 Thread Philippe Mathieu-Daudé
GitLab defaults [1] to upload artifacts only when the job succeeds, which is not helpful to troubleshoot failing tests. Switch to always upload artifacts by default for QEMU jobs, by setting the 'artifacts:when' keyword in the global default section [2]. [1]

Re: [PATCH] target/hppa: Fix atomic_store_3 for STBY

2021-12-29 Thread Helge Deller
On 12/29/21 23:29, Richard Henderson wrote: > The parallel version of STBY did not take host endianness into > account, and also computed the incorrect address for STBY_E. > > Bswap twice to handle the merge and store. Compute mask inside > the function rather than as a parameter. Force align

[PATCH 3/3] hw/sysbus: Document GPIO related functions

2021-12-29 Thread Philippe Mathieu-Daudé
Similarly to cd07d7f9f51 ("qdev: Document GPIO related functions"), add documentation comments for the various sysbus functions related to creating and connecting GPIO lines. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sysbus.h | 67 +++-- 1 file

[PATCH 1/3] hw/qdev: Restrict qdev_get_gpio_out_connector() to qdev-internal.h

2021-12-29 Thread Philippe Mathieu-Daudé
qdev_get_gpio_out_connector() is called by sysbus_get_connected_irq() which is only used by platform-bus.c; restrict it to hw/core/ by adding a local "qdev-internal.h" header. Signed-off-by: Philippe Mathieu-Daudé --- hw/core/qdev-internal.h | 15 +++ include/hw/qdev-core.h | 18

[PATCH 2/3] hw/sysbus: Restrict sysbus_get_connected_irq() to sysbus-internal.h

2021-12-29 Thread Philippe Mathieu-Daudé
sysbus_get_connected_irq() and sysbus_is_irq_connected() are only used by platform-bus.c; restrict them to hw/core/ by adding a local "sysbus-internal.h" header. Signed-off-by: Philippe Mathieu-Daudé --- hw/core/sysbus-internal.h | 16 include/hw/sysbus.h | 2 --

[PATCH 0/3] hw/sysbus: Document GPIO related functions

2021-12-29 Thread Philippe Mathieu-Daudé
Reduce the scope of a pair of qdev/sysbus functions, then document the sysbus functions related to creating and connecting GPIO lines. Based-on: <20211218130437.1516929-1-f4...@amsat.org> Philippe Mathieu-Daudé (3): hw/qdev: Restrict qdev_get_gpio_out_connector() to qdev-internal.h

[PATCH] target/hppa: Fix atomic_store_3 for STBY

2021-12-29 Thread Richard Henderson
The parallel version of STBY did not take host endianness into account, and also computed the incorrect address for STBY_E. Bswap twice to handle the merge and store. Compute mask inside the function rather than as a parameter. Force align the address, rather than subtracting one. Generalize

New arm alignment issue with 6.2.0 - bisected to single revision

2021-12-29 Thread Mark Watson
Hi, I'm seeing a repeatable alignment exception running m68k system mode on armv7l (arm cortex a9) following this commit: "fa947a667fceab02f9f85fc99f54aebcc9ae6b51 is the first bad commit commit fa947a667fceab02f9f85fc99f54aebcc9ae6b51 Author: Richard Henderson Date: Thu Jul 29 10:45:10 2021

[PULL 0/6] Block jobs patches

2021-12-29 Thread Vladimir Sementsov-Ogievskiy
The following changes since commit 89f3bfa3265554d1d591ee4d7f1197b6e3397e84: Merge tag 'pull-pa-20211223' of https://gitlab.com/rth7680/qemu into staging (2021-12-23 17:53:36 -0800) are available in the Git repository at: https://src.openvz.org/scm/~vsementsov/qemu.git

[PULL 6/6] blockjob: drop BlockJob.blk field

2021-12-29 Thread Vladimir Sementsov-Ogievskiy
It's unused now (except for permission handling)[*]. The only reasonable user of it was block-stream job, recently updated to use own blk. And other block jobs prefer to use own source node related objects. So, the arguments of dropping the field are: - block jobs prefer not to use it - block

[PULL 5/6] test-bdrv-drain: don't use BlockJob.blk

2021-12-29 Thread Vladimir Sementsov-Ogievskiy
We are going to drop BlockJob.blk in further commit. For tests it's enough to simply pass bs pointer. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Nikita Lapshin --- tests/unit/test-bdrv-drain.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git

[PULL 4/6] block/stream: add own blk

2021-12-29 Thread Vladimir Sementsov-Ogievskiy
block-stream is the only block-job, that reasonably use BlockJob.blk. We are going to drop BlockJob.blk soon. So, let block-stream have own blk. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Nikita Lapshin --- block/stream.c | 24 ++-- 1 file changed, 18

[PULL 2/6] blockjob: implement and use block_job_get_aio_context

2021-12-29 Thread Vladimir Sementsov-Ogievskiy
We are going to drop BlockJob.blk. So let's retrieve block job context from underlying job instead of main node. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Nikita Lapshin --- include/block/blockjob.h | 7 +++ blockdev.c | 6 +++--- blockjob.c | 5

[PULL 3/6] test-blockjob-txn: don't abuse job->blk

2021-12-29 Thread Vladimir Sementsov-Ogievskiy
Here we use job->blk to drop our own reference in job cleanup. Let's do simpler: drop our reference immediately after job creation. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Nikita Lapshin --- tests/unit/test-blockjob-txn.c | 10 +- 1 file changed, 1 insertion(+), 9

[PULL 1/6] job.c: add missing notifier initialization

2021-12-29 Thread Vladimir Sementsov-Ogievskiy
From: Emanuele Giuseppe Esposito It seems that on_idle list is not properly initialized like the other notifiers. Fixes: 34dc97b9a0e ("blockjob: Wake up BDS when job becomes idle") Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi

[PATCH 2/2] dump/win_dump: add 32-bit guest Windows support

2021-12-29 Thread Viktor Prutyanov
Before this patch, 'dump-guest-memory -w' was accepting only 64-bit dump header provided by guest through vmcoreinfo and thus was unable to produce 32-bit guest Windows dump. So, add 32-bit guest Windows dumping support. Signed-off-by: Viktor Prutyanov --- dump/win_dump.c | 293

[PATCH 1/2] include/qemu: add 32-bit Windows dump structures

2021-12-29 Thread Viktor Prutyanov
These structures are required to produce 32-bit guest Windows Complete Memory Dump. Add 32-bit Windows dump header, CPU context and physical memory descriptor structures along with corresponding definitions. Signed-off-by: Viktor Prutyanov --- contrib/elf2dmp/main.c | 6 +-

[PATCH 0/2] dump: add 32-bit guest Windows support

2021-12-29 Thread Viktor Prutyanov
Since 32-bit versions of Windows still exist, there is a need to take live and crash dumps of such guests along with 64-bit guests. So, add an ability for 'dump-guest-memory -w' to take dumps from 32-bit guest. When running the command QEMU consumes 32-bit Complete Memory Dump header passed by

[PATCH v2 5/5] target/ppc: powerpc_excp: Stop passing excp_model around

2021-12-29 Thread Fabiano Rosas
We can just access it directly in powerpc_excp. Signed-off-by: Fabiano Rosas Reviewed-by: Cédric Le Goater Reviewed-by: Richard Henderson Reviewed-by: David Gibson --- target/ppc/excp_helper.c | 43 1 file changed, 21 insertions(+), 22 deletions(-)

[PATCH v2 4/5] target/ppc: powerpc_excp: Move system call vectored code together

2021-12-29 Thread Fabiano Rosas
Now that 'vector' is known before calling the interrupt-specific setup code, we can move all of the scv setup into one place. No functional change intended. Signed-off-by: Fabiano Rosas Reviewed-by: Cédric Le Goater Reviewed-by: Richard Henderson --- target/ppc/excp_helper.c | 13

[PATCH v2 3/5] target/ppc: powerpc_excp: Set vector earlier

2021-12-29 Thread Fabiano Rosas
None of the interrupt setup code touches 'vector', so we can move it earlier in the function. This will allow us to later move the System Call Vectored setup that is on the top level into the POWERPC_EXCP_SYSCALL_VECTORED code block. This patch also moves the verification for when 'excp' does not

[PATCH v2 2/5] target/ppc: powerpc_excp: Add excp_vectors bounds check

2021-12-29 Thread Fabiano Rosas
The next patch will start accessing the excp_vectors array earlier in the function, so add a bounds check as first thing here. This converts the empty return on POWERPC_EXCP_NONE to an error. This exception number never reaches this function and if it does it probably means something else went

[PATCH v2 0/5] target/ppc: powerpc_excp improvements (1/n)

2021-12-29 Thread Fabiano Rosas
This series comprises of the first 4 patches from the RFC v2 plus an extra patch addressing review comments. Patch 1,3,4,5 have been reviewed. Patch 2 addresses prior comments from patch 3 and has not been reviewed. RFC v1: https://lists.nongnu.org/archive/html/qemu-ppc/2021-06/msg00026.html

[PATCH v2 1/5] target/ppc: powerpc_excp: Set alternate SRRs directly

2021-12-29 Thread Fabiano Rosas
There are currently only two interrupts that use alternate SRRs, so let them write to them directly during the setup code. No functional change intended. Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson Reviewed-by: Cédric Le Goater Reviewed-by: David Gibson ---

Re: [PATCH v5 02/14] hw/core/machine: Introduce CPU cluster topology support

2021-12-29 Thread Philippe Mathieu-Daudé
On 12/29/21 14:04, wangyanan (Y) wrote: > > On 2021/12/29 18:44, Philippe Mathieu-Daudé wrote: >> On 12/29/21 04:48, wangyanan (Y) wrote: >>> Hi Philippe, >>> Thanks for your review. >>> >>> On 2021/12/29 3:17, Philippe Mathieu-Daudé wrote: Hi, On 12/28/21 10:22, Yanan Wang wrote:

Re: [RFC v2 00/12] target/ppc: powerpc_excp improvements

2021-12-29 Thread Fabiano Rosas
Cédric Le Goater writes: > Hello Fabiano, > > On 12/20/21 19:18, Fabiano Rosas wrote: >> This changed a lot since v1, basically what remains is the idea that >> we want to have some sort of array of interrupts and some sort of >> separation between processors. >> >> At the end of this series

Re: [PATCH v5 02/14] hw/core/machine: Introduce CPU cluster topology support

2021-12-29 Thread wangyanan (Y)
On 2021/12/29 18:44, Philippe Mathieu-Daudé wrote: On 12/29/21 04:48, wangyanan (Y) wrote: Hi Philippe, Thanks for your review. On 2021/12/29 3:17, Philippe Mathieu-Daudé wrote: Hi, On 12/28/21 10:22, Yanan Wang wrote: The new Cluster-Aware Scheduling support has landed in Linux 5.16,

Re: QEMU CI failure of cross-i386-* targets (meson picks wrong glib for native target)

2021-12-29 Thread Alessandro Di Federico via
On Fri, 24 Dec 2021 22:25:24 +0100 Paolo Bonzini wrote: > Is the configure script setting $cross_compile to yes? That will > decide whether meson getting a --cross-file or a --native-file > option, and consequently whether it treats the host and build > machines as equal or different. From what

Re: [PATCH v5 02/14] hw/core/machine: Introduce CPU cluster topology support

2021-12-29 Thread Philippe Mathieu-Daudé
On 12/29/21 04:48, wangyanan (Y) wrote: > Hi Philippe, > Thanks for your review. > > On 2021/12/29 3:17, Philippe Mathieu-Daudé wrote: >> Hi, >> >> On 12/28/21 10:22, Yanan Wang wrote: >>> The new Cluster-Aware Scheduling support has landed in Linux 5.16, >>> which has been proved to benefit the