at24c* device

2022-02-19 Thread Patrick Venture
Philippe; Looking at the at24c device, it doesn't support the c02 and other 1-byte addressable eeproms that are supported by the at24c driver in linux, and other compatible eeproms. If I recall correctly, the smbus-eeprom device correctly handles the 1-byte addressable variants, and so maybe it's

Re: configure: How to pass flags to the Objective-C compiler?

2022-02-19 Thread Joshua Seaton
Thanks, Philippe. I was in luck that you already had this prepared. My naive read of that patch is that it covers specification at the levels of the configure and meson front-ends, but that it still does not wire that up to the build (beyond the diagnostic `summary_info` addition). Is that accurate

Re: [PATCH 1/1] hw/ide: share bmdma read and write functions between piix.c and via.c

2022-02-19 Thread BALATON Zoltan
On Sat, 19 Feb 2022, Liav Albani wrote: On 2/19/22 17:57, BALATON Zoltan wrote: On Sat, 19 Feb 2022, BALATON Zoltan wrote: Maybe even the first if that's already contained in the default function could be avoided with some reorganisation like if (size == 1) {    remaining switch cases to set

Re: [PATCH 1/1] hw/ide: share bmdma read and write functions between piix.c and via.c

2022-02-19 Thread Liav Albani
On 2/19/22 17:57, BALATON Zoltan wrote: On Sat, 19 Feb 2022, BALATON Zoltan wrote: Maybe even the first if that's already contained in the default function could be avoided with some reorganisation like if (size == 1) {    remaining switch cases to set val } else {    val = bmdma_default_rea

Re: [PATCH 1/1] hw/ide: share bmdma read and write functions between piix.c and via.c

2022-02-19 Thread BALATON Zoltan
On Sat, 19 Feb 2022, BALATON Zoltan wrote: On Sat, 19 Feb 2022, Liav Albani wrote: On 2/19/22 13:19, BALATON Zoltan wrote: On Sat, 19 Feb 2022, Liav Albani wrote: Instead of letting each implementation to duplicate this code, we can share these functions between IDE PIIX3/4 and VIA implementat

Re: [PULL v2 0/5] 9p queue (previous 2022-02-10)

2022-02-19 Thread Peter Maydell
On Thu, 17 Feb 2022 at 16:38, Christian Schoenebeck wrote: > > The following changes since commit c13b8e9973635f34f3ce4356af27a311c993729c: > > Merge remote-tracking branch > 'remotes/alistair/tags/pull-riscv-to-apply-20220216' into staging (2022-02-16 > 09:57:11 +) > > are available in th

Re: [PATCH 1/1] hw/ide: share bmdma read and write functions between piix.c and via.c

2022-02-19 Thread BALATON Zoltan
On Sat, 19 Feb 2022, Liav Albani wrote: On 2/19/22 13:19, BALATON Zoltan wrote: On Sat, 19 Feb 2022, Liav Albani wrote: Instead of letting each implementation to duplicate this code, we can share these functions between IDE PIIX3/4 and VIA implementations. OK but there's a way to take this ev

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-19 Thread Stefan Hajnoczi
On Thu, 17 Feb 2022 at 18:24, Thomas Huth wrote: > > On 28/01/2022 16.47, Stefan Hajnoczi wrote: > > Dear QEMU, KVM, and rust-vmm communities, > > QEMU will apply for Google Summer of Code 2022 > > (https://summerofcode.withgoogle.com/) and has been accepted into > > Outreachy May-August 2022 (htt

Re: [PATCH 4/4] block: simplify handling of try to merge different sized bitmaps

2022-02-19 Thread Vladimir Sementsov-Ogievskiy via
19.02.2022 06:04, Nikta Lapshin wrote: On 2/15/22 20:53, Vladimir Sementsov-Ogievskiy wrote: We have too much logic to simply check that bitmaps are of the same size. Let's just define that hbitmap_merge() and bdrv_dirty_bitmap_merge_internal() require their argument bitmaps be of same size, th

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-19 Thread Stefan Hajnoczi
On Fri, 18 Feb 2022 at 16:03, Paolo Bonzini wrote: > > On 2/18/22 12:39, Michal Prívozník wrote: > > On 2/17/22 18:52, Paolo Bonzini wrote: > >> I would like to co-mentor one or more projects about adding more > >> statistics to Mark Kanda's newly-born introspectable statistics > >> subsystem in Q

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-19 Thread Stefan Hajnoczi
On Fri, 18 Feb 2022 at 11:40, Michal Prívozník wrote: > > On 2/17/22 18:52, Paolo Bonzini wrote: > > On 1/28/22 16:47, Stefan Hajnoczi wrote: > >> Dear QEMU, KVM, and rust-vmm communities, > >> QEMU will apply for Google Summer of Code 2022 > >> (https://summerofcode.withgoogle.com/) and has been

Re: [PATCH 4/4] block: simplify handling of try to merge different sized bitmaps

2022-02-19 Thread Nikta Lapshin
On 2/15/22 20:53, Vladimir Sementsov-Ogievskiy wrote: We have too much logic to simply check that bitmaps are of the same size. Let's just define that hbitmap_merge() and bdrv_dirty_bitmap_merge_internal() require their argument bitmaps be of same size, this simplifies things. Let's look throug

Re: [PATCH v3 5/6] hw/openrisc/openrisc_sim: Add automatic device tree generation

2022-02-19 Thread Peter Maydell
On Sat, 19 Feb 2022 at 06:42, Stafford Horne wrote: > > Using the device tree means that qemu can now directly tell > the kernel what hardware is configured rather than use having > to maintain and update a separate device tree file. > > This patch adds automatic device tree generation support for

Re: [PATCH v3 4/6] hw/openrisc/openrisc_sim: Increase max_cpus to 4

2022-02-19 Thread Peter Maydell
On Sat, 19 Feb 2022 at 06:42, Stafford Horne wrote: > > Now that we no longer have a limit of 2 CPUs due to fixing the > IRQ routing issues we can increase the max. Here we increase > the limit to 4, we could go higher, but currently OMPIC has a > limit of 4, so we align with that. > > Signed-off

Re: [PATCH 1/1] hw/ide: share bmdma read and write functions between piix.c and via.c

2022-02-19 Thread Liav Albani
On 2/19/22 13:19, BALATON Zoltan wrote: On Sat, 19 Feb 2022, Liav Albani wrote: Instead of letting each implementation to duplicate this code, we can share these functions between IDE PIIX3/4 and VIA implementations. OK but there's a way to take this even further as cmd646 also uses similar

Re: [PATCH v3 3/6] hw/openrisc/openrisc_sim: Use IRQ splitter when connecting UART

2022-02-19 Thread Peter Maydell
On Sat, 19 Feb 2022 at 06:42, Stafford Horne wrote: > > Currently the OpenRISC SMP configuration only supports 2 cores due to > the UART IRQ routing being limited to 2 cores. As was done in commit > 1eeffbeb11 ("hw/openrisc/openrisc_sim: Use IRQ splitter when connecting > IRQ to multiple CPUs") w

Re: [PULL v2 00/29] Misc mostly build system patches for 2022-02-15

2022-02-19 Thread Peter Maydell
On Thu, 17 Feb 2022 at 10:06, Paolo Bonzini wrote: > > The following changes since commit ad38520bdeb2b1e0b487db317f29119e94c1c88d: > > Merge remote-tracking branch > 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2022-02-15 > 19:30:33 +) > > are available in the Git repos

Re: [PATCH v2 2/2] hw/ide: add ich6 ide controller device emulation

2022-02-19 Thread BALATON Zoltan
On Sat, 19 Feb 2022, Liav Albani wrote: On 2/19/22 02:50, BALATON Zoltan wrote: +/* + * QEMU IDE Emulation: PCI ICH6/ICH7 IDE support. This is a small thing, but if these two are the same maybe keeping this comment but using the ich7 name everywhere else would make it less likely to get it c

Re: [PATCH 2/4] block: block_dirty_bitmap_merge(): fix error path

2022-02-19 Thread Nikta Lapshin
On 2/15/22 20:53, Vladimir Sementsov-Ogievskiy wrote: Reviewed-by: Nikita Lapshin At the end we ignore failure of bdrv_merge_dirty_bitmap() and report success. And still set errp. That's wrong. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/monitor/bitmap-qmp-cmds.c | 5 - 1 fil

initiating reboot/shutdown for a microvm machine?

2022-02-19 Thread Michael Tokarev
Hi! In the ol'good days, I used Ctrl-Alt-Delete sequence to initiate a guest shutdown. But with microvm, guest does not see this event anymore. What is the good way to tell a guest vm to shut down from the outside, besides running full-blown guest agent? Thanks, /mjt

Re: [PATCH 1/1] hw/ide: share bmdma read and write functions between piix.c and via.c

2022-02-19 Thread BALATON Zoltan
On Sat, 19 Feb 2022, Liav Albani wrote: Instead of letting each implementation to duplicate this code, we can share these functions between IDE PIIX3/4 and VIA implementations. OK but there's a way to take this even further as cmd646 also uses similar functions just with more cases so you coul

Re: [PATCH 3/4] block: improve block_dirty_bitmap_merge(): don't allocate extra bitmap

2022-02-19 Thread Nikta Lapshin
On 2/15/22 20:53, Vladimir Sementsov-Ogievskiy wrote: We don't need extra bitmap. All we need is to backup the original bitmap when we do first merge. So, drop extra temporary bitmap and work directly with target and backup. Note that block_dirty_bitmap_merge() semantics changed: on failure ta

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-19 Thread Stefan Hajnoczi
On Thu, 17 Feb 2022 at 17:49, Paolo Bonzini wrote: > On 2/14/22 15:01, Stefan Hajnoczi wrote: > > Thanks for this idea. As a stretch goal we could add implementing the > > packed virtqueue layout in Linux vhost, QEMU's libvhost-user, and/or > > QEMU's virtio qtest code. > > Why not have a separate

[PATCH 1/1] hw/ide: share bmdma read and write functions between piix.c and via.c

2022-02-19 Thread Liav Albani
Instead of letting each implementation to duplicate this code, we can share these functions between IDE PIIX3/4 and VIA implementations. Signed-off-by: Liav Albani --- hw/ide/pci.c | 47 hw/ide/piix.c| 50 ++

[PATCH 0/1] hw/ide: share bmdma read and write functions

2022-02-19 Thread Liav Albani
This is a preparation before I send v3 of ich6-ide controller emulation patch. I figured that it's more trivial to split the changes this way, by extracting the bmdma functions from via.c and piix.c and sharing them together. Then, I could easily put these into use when I send v3 of the ich6-ide pa