Re: [PATCH v4 7/9] aspeed/soc : Add AST1030 support

2022-03-31 Thread Cédric Le Goater
On 4/1/22 05:46, Jamin Lin wrote: From: Steven Lee The embedded core of AST1030 SoC is ARM Coretex M4. It is hard to be integrated in the common Aspeed Soc framework. We introduce a new ast1030 class with instance_init and realize handlers. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Si

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

2022-03-31 Thread Christian Borntraeger
Am 01.04.22 um 04:15 schrieb David Miller: Hi, There is some issue with instruction sub/alt encodings not matching, but I worked around it easily. I'm dropping the updated patch for the tests in here. I know I should resend the entire patch series as a higher version really, and will do so.

Re: [RFC PATCH 3/4] hw/i2c: add slave mode for aspeed_i2c

2022-03-31 Thread Klaus Jensen
On Mar 31 22:44, Philippe Mathieu-Daudé wrote: > On 31/3/22 18:57, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Add slave mode functionality for the Aspeed I2C controller. This is > > implemented by creating an Aspeed I2C Slave device that attaches to the > > bus. > > > > This i2c slave de

Re: [RFC PATCH 0/4] hw/i2c: i2c slave mode support

2022-03-31 Thread Klaus Jensen
On Mar 31 15:32, Corey Minyard wrote: > On Thu, Mar 31, 2022 at 06:57:33PM +0200, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Hi all, > > > > This RFC series adds I2C "slave mode" support for the Aspeed I2C > > controller as well as the necessary infrastructure in the i2c core to > > supp

Re: [PATCH] linux-user/sh4/termbits: Silence warning about TIOCSER_TEMT double definition

2022-03-31 Thread Thomas Huth
On 31/03/2022 19.31, Richard Henderson wrote: On 3/31/22 10:22, Laurent Vivier wrote: Le 30/03/2022 à 15:43, Thomas Huth a écrit : Seen while compiling on Alpine:   In file included from ../linux-user/strace.c:17:   In file included from ../linux-user/qemu.h:11:   In file included from ../linu

Re: [PATCH 2/3] i386: factor out x86_firmware_configure()

2022-03-31 Thread Xiaoyao Li
On 4/1/2022 1:08 PM, Gerd Hoffmann wrote: if (sev_enabled()) { ^^^ Can we remove the SEV check ... +pc_system_parse_ovmf_flash(ptr, size); + +if (sev_enabled()) { ... because we are still checking SEV here. Well, the two checks have slightly

Re: [PATCH 2/3] i386: factor out x86_firmware_configure()

2022-03-31 Thread Gerd Hoffmann
> > if (sev_enabled()) { > > ^^^ > Can we remove the SEV check ... > > +pc_system_parse_ovmf_flash(ptr, size); > > + > > +if (sev_enabled()) { > > ... because we are still checking SEV here. Well, the two checks have slightly different purposes. The f

Re: [PATCH v1 2/2] hw/arm/xlnx-zynqmp: Connect 4 TTC timers

2022-03-31 Thread Alistair Francis
On Fri, Apr 1, 2022 at 8:26 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Connect the 4 TTC timers on the ZynqMP. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- > include/hw/arm/xlnx-zynqmp.h | 4 > hw/arm/xlnx-zynqmp.c | 22 +

Re: [PATCH v1 1/2] timer: cadence_ttc: Break out header file to allow embedding

2022-03-31 Thread Alistair Francis
On Fri, Apr 1, 2022 at 8:24 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Break out header file to allow embedding of the the TTC. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- > include/hw/timer/cadence_ttc.h | 54

[PATCH] [PATCH RFC v2] Implements Backend Program conventions for vhost-user-scsi

2022-03-31 Thread Sakshi Kaushik
Signed-off-by: Sakshi Kaushik --- contrib/vhost-user-scsi/vhost-user-scsi.c | 35 +++ 1 file changed, 29 insertions(+), 6 deletions(-) diff --git a/contrib/vhost-user-scsi/vhost-user-scsi.c b/contrib/vhost-user-scsi/vhost-user-scsi.c index 4f6e3e2a24..9bdc088ce8 100644 --- a

Re: [PATCH 7/7] vhost-vdpa: backend feature should set only once

2022-03-31 Thread Si-Wei Liu
On 3/31/2022 7:39 PM, Jason Wang wrote: On Thu, Mar 31, 2022 at 5:20 PM Eugenio Perez Martin wrote: On Thu, Mar 31, 2022 at 10:54 AM Jason Wang wrote: 在 2022/3/31 下午4:02, Eugenio Perez Martin 写道: On Thu, Mar 31, 2022 at 1:03 AM Si-Wei Liu wrote: On 3/30/2022 12:01 PM, Eugenio Perez Ma

Re: [PATCH 2/2] NVDIMM: Init vNVDIMM's LSA index block if it hasn't been

2022-03-31 Thread Robert Hoo
On Thu, 2022-03-31 at 16:41 +0200, Igor Mammedov wrote: > On Thu, 31 Mar 2022 21:08:12 +0800 > Robert Hoo wrote: > > > > > > > Can user initialize/format LSA from guest using ndctl/some other > > > tool? > > > > > > > Yes, he can. But when guest Kernel already told him this is a dimm > > wi

[PATCH V2 4/4] net/colo.c: fix segmentation fault when packet is not parsed correctly

2022-03-31 Thread Zhang Chen
When COLO use only one vnet_hdr_support parameter between filter-redirector and filter-mirror(or colo-compare), COLO will crash with segmentation fault. Back track as follow: Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. 0x55cb200b in eth_get_l2_hdr_length (p=0x0)

[PATCH V2 3/4] net/colo.c: No need to track conn_list for filter-rewriter

2022-03-31 Thread Zhang Chen
Filter-rewriter no need to track connection in conn_list. This patch fix the glib g_queue_is_empty assertion when COLO guest keep a lot of network connection. Signed-off-by: Zhang Chen Reviewed-by: Li Zhijian --- net/colo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net

[PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

2022-03-31 Thread Zhang Chen
If the checkpoint occurs when the guest finishes restarting but has not started running, the runstate_set() may reject the transition from COLO to PRELAUNCH with the crash log: {"timestamp": {"seconds": 1593484591, "microseconds": 26605},\ "event": "RESET", "data": {"guest": true, "reason": "guest

[PATCH V2 2/4] net/colo: Fix a "double free" crash to clear the conn_list

2022-03-31 Thread Zhang Chen
We notice the QEMU may crash when the guest has too many incoming network connections with the following log: 15197@1593578622.668573:colo_proxy_main : colo proxy connection hashtable full, clear it free(): invalid pointer [1]15195 abort (core dumped) qemu-system-x86_64 This is because

[PATCH V2 0/4] COLO net and runstate bugfix/optimization

2022-03-31 Thread Zhang Chen
This series fix some COLO related issues in internal stress testing. - V2: - Add more comments in patch 2/4 commit log. Zhang Chen (4): softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH net/colo: Fix a "double free" crash to clear the conn_list net/colo.c: N

[PATCH v4 7/9] aspeed/soc : Add AST1030 support

2022-03-31 Thread Jamin Lin
From: Steven Lee The embedded core of AST1030 SoC is ARM Coretex M4. It is hard to be integrated in the common Aspeed Soc framework. We introduce a new ast1030 class with instance_init and realize handlers. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee --- hw/arm

[PATCH v4 9/9] test/avocado/machine_aspeed.py: Add ast1030 test case

2022-03-31 Thread Jamin Lin
Add test case to test "ast1030-evb" machine with zephyr os Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goater --- tests/avocado/machine_aspeed.py | 36 + 1 file changed, 36 insertions(+) create mode 100644

[PATCH v4 8/9] aspeed: Add an AST1030 eval board

2022-03-31 Thread Jamin Lin
The image should be supplied with ELF binary. $ qemu-system-arm -M ast1030-evb -kernel zephyr.elf -nographic Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee --- hw/arm/aspeed.c | 97 + include/hw/arm/aspeed.h | 6 +--

[PATCH v4 3/9] aspeed/wdt: Fix ast2500/ast2600 default reload value.

2022-03-31 Thread Jamin Lin
From: Steven Lee Per ast2500_2520_datasheet_v1.8 and ast2600v11.pdf, the default value of WDT00 and WDT04 is 0x014FB180 for ast2500/ast2600. Add default_status and default_reload_value attributes for storing counter status and reload value as they are different from ast2400. Signed-off-by: Troy

[PATCH v4 4/9] aspeed/wdt: Add AST1030 support

2022-03-31 Thread Jamin Lin
From: Steven Lee AST1030 wdt controller is similiar to AST2600's wdt, but it has extra registers. Introduce ast1030 object class and increse the number of regs(offset) of ast1030 model. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goater -

[PATCH v4 6/9] aspeed/scu: Add AST1030 support

2022-03-31 Thread Jamin Lin
From: Steven Lee Per ast1030_v07.pdf, AST1030 SOC doesn't have SCU300, the pclk divider selection is defined in SCU310[11:8]. Add a get_apb_freq function and a class init handler for ast1030. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goa

[PATCH v4 2/9] aspeed/smc: Add AST1030 support

2022-03-31 Thread Jamin Lin
From: Steven Lee AST1030 spi controller's address decoding unit is 1MB that is identical to ast2600, but fmc address decoding unit is 512kb. Introduce seg_to_reg and reg_to_seg handlers for ast1030 fmc controller. In addition, add ast1030 fmc, spi1, and spi2 class init handler. Signed-off-by: Tr

[PATCH v4 5/9] aspeed/timer: Add AST1030 support

2022-03-31 Thread Jamin Lin
From: Steven Lee ast1030 tmc(timer controller) is identical to ast2600 tmc. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goater --- hw/timer/aspeed_timer.c | 17 + include/hw/timer/aspeed_timer.h | 1 + 2 files ch

[PATCH v4 1/9] aspeed/adc: Add AST1030 support

2022-03-31 Thread Jamin Lin
From: Steven Lee Per ast1030_v7.pdf, AST1030 ADC engine is identical to AST2600's ADC. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goater --- hw/adc/aspeed_adc.c | 16 include/hw/adc/aspeed_adc.h | 1 + 2 files

[PATCH v4 0/9] Add support for AST1030 SoC

2022-03-31 Thread Jamin Lin
Changes from v4: - drop the ASPEED_SMC_FEATURE_WDT_CONTROL flag in hw/ssi/aspeed_smc.c Changes from v3: - remove AspeedMiniBmcMachineState state structure and AspeedMiniBmcMachineClass class - remove redundant new line in hw/arm/aspeed_ast10xx.c - drop the ASPEED_SMC_FEATURE_WDT_CONTROL flag in

Re: [PATCH v2 2/4] target/ppc: init 'lpcr' in kvmppc_enable_cap_large_decr()

2022-03-31 Thread David Gibson
On Thu, Mar 31, 2022 at 03:46:57PM -0300, Daniel Henrique Barboza wrote: > > > On 3/31/22 14:36, Richard Henderson wrote: > > On 3/31/22 11:17, Daniel Henrique Barboza wrote: > > > > Hmm... this is seeming a bit like whack-a-mole.  Could we instead use > > > > one of the valgrind hinting mechanis

Re: [PATCH v2 2/4] target/ppc: init 'lpcr' in kvmppc_enable_cap_large_decr()

2022-03-31 Thread David Gibson
On Thu, Mar 31, 2022 at 02:17:42PM -0300, Daniel Henrique Barboza wrote: > > > On 3/30/22 22:25, David Gibson wrote: > > On Wed, Mar 30, 2022 at 09:17:15PM -0300, Daniel Henrique Barboza wrote: > > > 'lpcr' is used as an input of kvm_get_one_reg(). Valgrind doesn't > > > understand that and it re

RE: [PATCH 2/4] net/colo: Fix a "double free" crash to clear the conn_list

2022-03-31 Thread Zhang, Chen
> -Original Message- > From: lizhij...@fujitsu.com > Sent: Friday, April 1, 2022 9:47 AM > To: Zhang, Chen ; Jason Wang > > Cc: qemu-dev ; Like Xu > Subject: Re: [PATCH 2/4] net/colo: Fix a "double free" crash to clear the > conn_list > > > > On 31/03/2022 10:25, Zhang, Chen wrote:

Re: [PATCH v3 0/9] Add support for AST1030 SoC

2022-03-31 Thread Jamin Lin
The 04/01/2022 03:04, Jamin Lin wrote: Please ignore this patch series, I lost to drop ASPEED_SMC_FEATURE_WDT_CONTROL flag. will resend v4 patch Thanks-Jamin > Changes from v3: > - remove AspeedMiniBmcMachineState state structure and > AspeedMiniBmcMachineClass class > - remove redundant new line

Re: [PATCH v4] vdpa: reset the backend device in the end of vhost_net_stop()

2022-03-31 Thread Michael Qiu
On 2022/4/1 10:53, Jason Wang wrote: On Fri, Apr 1, 2022 at 9:31 AM Michael Qiu wrote: Currently, when VM poweroff, it will trigger vdpa device(such as mlx bluefield2 VF) reset many times(with 1 datapath queue pair and one control queue, triggered 3 times), this leads to below issue: vhost

[PATCH v3 5/9] aspeed/timer: Add AST1030 support

2022-03-31 Thread Jamin Lin
From: Steven Lee ast1030 tmc(timer controller) is identical to ast2600 tmc. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goater --- hw/timer/aspeed_timer.c | 17 + include/hw/timer/aspeed_timer.h | 1 + 2 files ch

[PATCH v3 7/9] aspeed/soc : Add AST1030 support

2022-03-31 Thread Jamin Lin
From: Steven Lee The embedded core of AST1030 SoC is ARM Coretex M4. It is hard to be integrated in the common Aspeed Soc framework. We introduce a new ast1030 class with instance_init and realize handlers. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee --- hw/arm

[PATCH v3 1/9] aspeed/adc: Add AST1030 support

2022-03-31 Thread Jamin Lin
From: Steven Lee Per ast1030_v7.pdf, AST1030 ADC engine is identical to AST2600's ADC. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goater --- hw/adc/aspeed_adc.c | 16 include/hw/adc/aspeed_adc.h | 1 + 2 files

[PATCH v3 8/9] aspeed: Add an AST1030 eval board

2022-03-31 Thread Jamin Lin
The image should be supplied with ELF binary. $ qemu-system-arm -M ast1030-evb -kernel zephyr.elf -nographic Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee --- hw/arm/aspeed.c | 97 + include/hw/arm/aspeed.h | 6 +--

[PATCH v3 9/9] test/avocado/machine_aspeed.py: Add ast1030 test case

2022-03-31 Thread Jamin Lin
Add test case to test "ast1030-evb" machine with zephyr os Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goater --- tests/avocado/machine_aspeed.py | 36 + 1 file changed, 36 insertions(+) create mode 100644

[PATCH v3 6/9] aspeed/scu: Add AST1030 support

2022-03-31 Thread Jamin Lin
From: Steven Lee Per ast1030_v07.pdf, AST1030 SOC doesn't have SCU300, the pclk divider selection is defined in SCU310[11:8]. Add a get_apb_freq function and a class init handler for ast1030. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goa

[PATCH v3 4/9] aspeed/wdt: Add AST1030 support

2022-03-31 Thread Jamin Lin
From: Steven Lee AST1030 wdt controller is similiar to AST2600's wdt, but it has extra registers. Introduce ast1030 object class and increse the number of regs(offset) of ast1030 model. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goater -

[PATCH v3 2/9] aspeed/smc: Add AST1030 support

2022-03-31 Thread Jamin Lin
From: Steven Lee AST1030 spi controller's address decoding unit is 1MB that is identical to ast2600, but fmc address decoding unit is 512kb. Introduce seg_to_reg and reg_to_seg handlers for ast1030 fmc controller. In addition, add ast1030 fmc, spi1, and spi2 class init handler. Signed-off-by: Tr

[PATCH v3 3/9] aspeed/wdt: Fix ast2500/ast2600 default reload value.

2022-03-31 Thread Jamin Lin
From: Steven Lee Per ast2500_2520_datasheet_v1.8 and ast2600v11.pdf, the default value of WDT00 and WDT04 is 0x014FB180 for ast2500/ast2600. Add default_status and default_reload_value attributes for storing counter status and reload value as they are different from ast2400. Signed-off-by: Troy

[PATCH v3 0/9] Add support for AST1030 SoC

2022-03-31 Thread Jamin Lin
Changes from v3: - remove AspeedMiniBmcMachineState state structure and AspeedMiniBmcMachineClass class - remove redundant new line in hw/arm/aspeed_ast10xx.c - drop the ASPEED_SMC_FEATURE_WDT_CONTROL flag in hw/ssi/aspeed_smc.c Changes from v2: - replace aspeed_ast1030.c with aspeed_ast10xx.c f

Re: [PATCH v3] vdpa: reset the backend device in the end of vhost_net_stop()

2022-03-31 Thread Jason Wang
On Thu, Mar 31, 2022 at 5:12 PM Maxime Coquelin wrote: > > Hi, > > On 3/31/22 10:55, Jason Wang wrote: > > On Thu, Mar 31, 2022 at 1:20 PM <08005...@163.com> wrote: > > > > Hi: > > > > For some reason, I see the patch as an attachment. > > We are starting to see this more and more since yesterday

Re: [PATCH v4] vdpa: reset the backend device in the end of vhost_net_stop()

2022-03-31 Thread Jason Wang
On Fri, Apr 1, 2022 at 9:31 AM Michael Qiu wrote: > > Currently, when VM poweroff, it will trigger vdpa > device(such as mlx bluefield2 VF) reset many times(with 1 datapath > queue pair and one control queue, triggered 3 times), this > leads to below issue: > > vhost VQ 2 ring restore failed: -22:

Re: [PATCH 7/7] vhost-vdpa: backend feature should set only once

2022-03-31 Thread Jason Wang
On Thu, Mar 31, 2022 at 5:20 PM Eugenio Perez Martin wrote: > > On Thu, Mar 31, 2022 at 10:54 AM Jason Wang wrote: > > > > > > 在 2022/3/31 下午4:02, Eugenio Perez Martin 写道: > > > On Thu, Mar 31, 2022 at 1:03 AM Si-Wei Liu wrote: > > >> > > >> > > >> On 3/30/2022 12:01 PM, Eugenio Perez Martin wro

Re: [PATCH] virtio-net: use g_memdup2() instead of unsafe g_memdup()

2022-03-31 Thread Jason Wang
On Fri, Apr 1, 2022 at 2:29 AM Eugenio Pérez wrote: > > Fixing that literal checkpatch.pl because it will complain when we modify the > file > > Signed-off-by: Eugenio Pérez Acked-by: Jason Wang > --- > hw/net/virtio-net.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --

Re: [PATCH] util: Return void on iova_tree_remove

2022-03-31 Thread Jason Wang
On Fri, Apr 1, 2022 at 2:17 AM Eugenio Pérez wrote: > > It always returns IOVA_OK so nobody uses it. > > Signed-off-by: Eugenio Pérez Acked-by: Jason Wang > --- > include/qemu/iova-tree.h | 4 +--- > util/iova-tree.c | 4 +--- > 2 files changed, 2 insertions(+), 6 deletions(-) > > dif

Re: [PATCH] vhost: Fix bad return of descriptors to SVQ

2022-03-31 Thread Jason Wang
On Fri, Apr 1, 2022 at 2:14 AM Eugenio Pérez wrote: > > Only the first one of them were properly enqueued back. > > Fixes: 100890f7ca ("vhost: Shadow virtqueue buffers forwarding") > Signed-off-by: Eugenio Pérez > --- > hw/virtio/vhost-shadow-virtqueue.c | 17 +++-- > 1 file changed,

[PATCH] intel-iommu: correct the value used for error_setg_errno()

2022-03-31 Thread Jason Wang
error_setg_errno() expects a normal errno value, not a negated one, so we should use ENOTSUP instead of -ENOSUP. Fixes: Coverity CID 1487174 Fixes: ("intel_iommu: support snoop control") Signed-off-by: Jason Wang --- hw/i386/intel_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

2022-03-31 Thread David Miller
On Thu, Mar 31, 2022 at 10:15 PM David Miller wrote: > > Hi, > > There is some issue with instruction sub/alt encodings not matching, > but I worked around it easily. > > I'm dropping the updated patch for the tests in here. > I know I should resend the entire patch series as a higher version > re

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

2022-03-31 Thread David Miller
Hi, There is some issue with instruction sub/alt encodings not matching, but I worked around it easily. I'm dropping the updated patch for the tests in here. I know I should resend the entire patch series as a higher version really, and will do so. I'm hoping someone can tell me if it's ok to use

Re: [PULL v4 15/47] intel_iommu: support snoop control

2022-03-31 Thread Jason Wang
On Thu, Mar 31, 2022 at 5:51 PM Peter Maydell wrote: > > On Mon, 7 Mar 2022 at 22:45, Michael S. Tsirkin wrote: > > > > From: Jason Wang > > > > SC is required for some kernel features like vhost-vDPA. So this patch > > implements basic SC feature. The idea is pretty simple, for software > > emu

Re: who's maintaining amd_iommu.c these days?

2022-03-31 Thread Jason Wang
On Fri, Apr 1, 2022 at 2:30 AM Peter Xu wrote: > > On Thu, Mar 31, 2022 at 05:01:52PM +0100, Peter Maydell wrote: > > Coverity points out some problems with hw/i386/amd_iommu.c's event > > logging code -- specifically, CID 1487115 1487116 1487190 1487200 > > 1487232 1487258 are all the same basic

Re: [PULL 19/35] ppc/pnv: Add models for POWER9 PHB4 PCIe Host bridge

2022-03-31 Thread Benjamin Herrenschmidt
On Thu, 2022-03-31 at 18:51 +0100, Peter Maydell wrote: > > Hi; Coverity has just spotted an error in this old change > (CID 1487176): Oh my this is old ... I don't work for IBM anymore but I found the relevant doc here: https://wiki.raptorcs.com/w/images/a/a5/POWER9_PCIe_controller_v11_27JUL201

[PATCH v2] target/riscv: Call probe_write() before atomic operations

2022-03-31 Thread Alistair Francis
From: Alistair Francis If an atomic operation fails on RISC-V we want to generate a store/amo fault and not a load fault. Currently if we have no permissions to access the memory location the atomic operation will sometimes fail with a load fault (depending on the path taken in tcg/tcg-op.c) as

Re: [PATCH 2/4] net/colo: Fix a "double free" crash to clear the conn_list

2022-03-31 Thread lizhij...@fujitsu.com
On 31/03/2022 10:25, Zhang, Chen wrote: > >> -Original Message- >> From: lizhij...@fujitsu.com >> Sent: Thursday, March 31, 2022 9:15 AM >> To: Zhang, Chen ; Jason Wang >> >> Cc: qemu-dev ; Like Xu >> Subject: Re: [PATCH 2/4] net/colo: Fix a "double free" crash to clear the >> conn_lis

Re: [PATCH RESEND v3] vdpa: reset the backend device in the end of vhost_net_stop()

2022-03-31 Thread Michael Qiu
On 2022/4/1 9:12, Si-Wei Liu worte: On 3/31/2022 2:25 AM, qiud...@archeros.com wrote: From: Michael Qiu Currently, when VM poweroff, it will trigger vdpa device(such as mlx bluefield2 VF) reset many times(with 1 datapath queue pair and one control queue, triggered 3 times), this leads to

[PATCH v4] vdpa: reset the backend device in the end of vhost_net_stop()

2022-03-31 Thread Michael Qiu
Currently, when VM poweroff, it will trigger vdpa device(such as mlx bluefield2 VF) reset many times(with 1 datapath queue pair and one control queue, triggered 3 times), this leads to below issue: vhost VQ 2 ring restore failed: -22: Invalid argument (22) This because in vhost_net_stop(), it wil

Re: [PATCH v2 2/9] aspeed/smc: Add AST1030 support

2022-03-31 Thread Jamin Lin
The 03/31/2022 15:59, Cédric Le Goater wrote: > Hello Jamin, > > On 3/31/22 10:15, Jamin Lin wrote: > > From: Steven Lee > > > > AST1030 spi controller's address decoding unit is 1MB that is identical > > to ast2600, but fmc address decoding unit is 512kb. > > Introduce seg_to_reg and reg_to_seg

Re: [PATCH v2 7/9] aspeed/soc : Add AST1030 support

2022-03-31 Thread Jamin Lin
The 03/31/2022 11:08, Cédric Le Goater wrote: > On 3/31/22 10:15, Jamin Lin wrote: > > From: Steven Lee > > > > The embedded core of AST1030 SoC is ARM Coretex M4. > > It is hard to be integrated in the common Aspeed Soc framework. > > We introduce a new ast1030 class with instance_init and reali

Re: [PATCH v2 8/9] aspeed: Add an AST1030 eval board

2022-03-31 Thread Jamin Lin
The 03/31/2022 11:04, Cédric Le Goater wrote: Hi Cedric, > Hello Jamin, > > On 3/31/22 10:15, Jamin Lin wrote: > > The image should be supplied with ELF binary. > > $ qemu-system-arm -M ast1030-evb -kernel zephyr.elf -nographic > > > > Signed-off-by: Troy Lee > > Signed-off-by: Jamin Lin > > Si

Re: [PATCH RESEND v3] vdpa: reset the backend device in the end of vhost_net_stop()

2022-03-31 Thread Si-Wei Liu
On 3/31/2022 2:25 AM, qiud...@archeros.com wrote: From: Michael Qiu Currently, when VM poweroff, it will trigger vdpa device(such as mlx bluefield2 VF) reset many times(with 1 datapath queue pair and one control queue, triggered 3 times), this leads to below issue: vhost VQ 2 ring restore f

Re: [PATCH] hw/riscv: Enable TPM backends

2022-03-31 Thread Bin Meng
On Fri, Apr 1, 2022 at 8:19 AM Alistair Francis wrote: > > From: Alistair Francis > > Imply the TPM sysbus devices. This allows users to add TPM devices to > the RISC-V virt board. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/942 > Signed-off-by: Alistair Francis > --- > hw/riscv

[PATCH] hw/riscv: Enable TPM backends

2022-03-31 Thread Alistair Francis
From: Alistair Francis Imply the TPM sysbus devices. This allows users to add TPM devices to the RISC-V virt board. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/942 Signed-off-by: Alistair Francis --- hw/riscv/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/riscv/Kcon

[PULL 2/2] target/riscv: rvv: Add missing early exit condition for whole register load/store

2022-03-31 Thread Alistair Francis
From: "Yueh-Ting (eop) Chen" According to v-spec (section 7.9): The instructions operate with an effective vector length, evl=NFIELDS*VLEN/EEW, regardless of current settings in vtype and vl. The usual property that no elements are written if vstart ≥ vl does not apply to these instructions. Inst

[PULL 1/2] target/riscv: Avoid leaking "no translation" TLB entries

2022-03-31 Thread Alistair Francis
From: Palmer Dabbelt The ISA doesn't allow bare mappings to be cached, as the caches are translations and bare mppings are not translated. We cache these translations in QEMU in order to utilize the TLB code, but that leaks out to the guest. Suggested-by: phan...@zju.edu.cn # no name in the Fro

[PULL 0/2] riscv-to-apply queue

2022-03-31 Thread Alistair Francis
From: Alistair Francis The following changes since commit d5341e09135b871199073572f53bc11ae9b44897: Merge tag 'pull-tcg-20220331' of https://gitlab.com/rth7680/qemu into staging (2022-03-31 18:36:08 +0100) are available in the Git repository at: g...@github.com:alistair23/qem

Re: use of uninitialized variable involving visit_type_uint32() and friends

2022-03-31 Thread Daniel Henrique Barboza
On 3/31/22 14:35, Peter Maydell wrote: Coverity warns about use of uninitialized data in what seems to be a common pattern of use of visit_type_uint32() and similar functions. Here's an example from target/arm/cpu64.c: static void cpu_max_set_sve_max_vq(Object *obj, Visitor *v, const char *na

[PATCH v1 2/2] hw/arm/xlnx-zynqmp: Connect 4 TTC timers

2022-03-31 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Connect the 4 TTC timers on the ZynqMP. Signed-off-by: Edgar E. Iglesias --- include/hw/arm/xlnx-zynqmp.h | 4 hw/arm/xlnx-zynqmp.c | 22 ++ 2 files changed, 26 insertions(+) diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm

[PATCH v1 1/2] timer: cadence_ttc: Break out header file to allow embedding

2022-03-31 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Break out header file to allow embedding of the the TTC. Signed-off-by: Edgar E. Iglesias --- include/hw/timer/cadence_ttc.h | 54 ++ hw/timer/cadence_ttc.c | 32 ++-- 2 files changed, 56 insertions(+), 30 deleti

[PULL 1/4] linux-user/sh4/termbits: Silence warning about TIOCSER_TEMT double definition

2022-03-31 Thread Laurent Vivier
From: Thomas Huth Seen while compiling on Alpine: In file included from ../linux-user/strace.c:17: In file included from ../linux-user/qemu.h:11: In file included from ../linux-user/syscall_defs.h:1247: ../linux-user/sh4/termbits.h:276:10: warning: 'TIOCSER_TEMT' macro redefined [-Wmacro-r

[PULL 2/4] target/sh4: Remove old README.sh4 file

2022-03-31 Thread Laurent Vivier
From: Thomas Huth This file didn't have any non-trivial update since it was initially added in 2006, and looking at the content, it seems incredibly outdated, saying e.g. "The sh4 target is not ready at all yet for integration in qemu" or "A sh4 user-mode has also somewhat started but will be wor

[PATCH v1 0/2] hw/arm: zynqmp: Add the 4 TTC timers

2022-03-31 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This adds the 4 TTC timers in the Xilinx ZynqMP. This is for after the 7.0.0 release. Cheers, Edgar Edgar E. Iglesias (2): timer: cadence_ttc: Break out header file to allow embedding hw/arm/xlnx-zynqmp: Connect 4 TTC timers include/hw/arm/xlnx-zynqmp.h | 4 ++

[PULL 3/4] vhost-vdpa: fix typo in a comment

2022-03-31 Thread Laurent Vivier
From: Stefano Garzarella Replace vpda with vdpa. Signed-off-by: Stefano Garzarella Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220328152022.73245-1-sgarz...@redhat.com> Signed-off-by: Laurent Vivier --- hw/virtio/vhost-vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PULL 0/4] Trivial branch for 7.0 patches

2022-03-31 Thread Laurent Vivier
The following changes since commit cace6c6f3aca7b88afc42995f90bbefb37a0ed57: Merge tag 'pull-qapi-2022-03-31' of git://repo.or.cz/qemu/armbru into staging (2022-03-31 11:56:52 +0100) are available in the Git repository at: https://gitlab.com/laurent_vivier/qemu.git tags/trivial-branch-for-

[PULL 4/4] tests/lcitool: Do not use a hard-coded /usr/bin/python3 as python interpreter

2022-03-31 Thread Laurent Vivier
From: Thomas Huth When running "make lcitool-refresh", this currently uses the hard-coded /usr/bin/python3 from the script's shebang line for running Python. That's bad, since neither /usr/bin/python3 is guaranteed to exist, nor does it honor the python interpreter that the user might have chosen

Re: [PATCH v8 04/46] hw/cxl/device: Introduce a CXL device (8.2.8)

2022-03-31 Thread Adam Manzanares
On Wed, Mar 30, 2022 at 06:48:48PM +0100, Jonathan Cameron wrote: > On Tue, 29 Mar 2022 18:13:59 + > Adam Manzanares wrote: > > > On Fri, Mar 18, 2022 at 03:05:53PM +, Jonathan Cameron wrote: > > > From: Ben Widawsky > > > > > > A CXL device is a type of CXL component. Conceptually, a C

Re: [PATCH] target/riscv: Avoid leaking "no translation" TLB entries

2022-03-31 Thread Alistair Francis
On Thu, Mar 31, 2022 at 3:11 AM Palmer Dabbelt wrote: > > The ISA doesn't allow bare mappings to be cached, as the caches are > translations and bare mppings are not translated. We cache these > translations in QEMU in order to utilize the TLB code, but that leaks > out to the guest. > > Suggeste

Re: [EXT] Re: [PATCH] hw/riscv: virt: Warn the user if -bios is provided when using KVM

2022-03-31 Thread Ralf Ramsauer
On 31/03/2022 02:11, Alistair Francis wrote: On Thu, Mar 24, 2022 at 7:08 PM Daniel P. Berrangé wrote: On Wed, Mar 23, 2022 at 06:13:46PM +0100, Ralf Ramsauer wrote: The -bios option is silently ignored if used in combination with -enable-kvm. The reason is that the machine starts in S-Mod

Re: [PATCH v8 04/46] hw/cxl/device: Introduce a CXL device (8.2.8)

2022-03-31 Thread Adam Manzanares
On Wed, Mar 30, 2022 at 01:15:58PM +0100, Jonathan Cameron wrote: > On Tue, 29 Mar 2022 12:53:51 -0700 > Davidlohr Bueso wrote: > > > On Tue, 29 Mar 2022, Adam Manzanares wrote: > > >> +typedef struct cxl_device_state { > > >> +MemoryRegion device_registers; > > >> + > > >> +/* mmio for d

Re: [PATCH 7/7] vhost-vdpa: backend feature should set only once

2022-03-31 Thread Si-Wei Liu
On 3/31/2022 1:02 AM, Eugenio Perez Martin wrote: On Thu, Mar 31, 2022 at 1:03 AM Si-Wei Liu wrote: On 3/30/2022 12:01 PM, Eugenio Perez Martin wrote: On Wed, Mar 30, 2022 at 8:33 AM Si-Wei Liu wrote: The vhost_vdpa_one_time_request() branch in vhost_vdpa_set_backend_cap() incorrectly s

Re: [PATCH] qga: replace usleep() with g_usleep()

2022-03-31 Thread Philippe Mathieu-Daudé
On 31/3/22 22:53, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau The latter simply requires glib.h, while the former is not in the Windows API (but provided by mingw header & CRT) Also simplify the expression for 1/10s. Signed-off-by: Marc-André Lureau --- qga/main.c | 2 +- 1

Re: [PATCH 2/3] i386: factor out x86_firmware_configure()

2022-03-31 Thread Philippe Mathieu-Daudé
On 31/3/22 10:35, Gerd Hoffmann wrote: move sev firmware setup to separate function so it can be used from other code paths. No functional change. Signed-off-by: Gerd Hoffmann Tested-by: Xiaoyao Li --- include/hw/i386/x86.h | 3 +++ hw/i386/pc_sysfw.c| 36 ++---

[PATCH] qga: replace usleep() with g_usleep()

2022-03-31 Thread marcandre . lureau
From: Marc-André Lureau The latter simply requires glib.h, while the former is not in the Windows API (but provided by mingw header & CRT) Also simplify the expression for 1/10s. Signed-off-by: Marc-André Lureau --- qga/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 3/3] i386: firmware parsing and sev setup for -bios loaded firmware

2022-03-31 Thread Philippe Mathieu-Daudé
On 31/3/22 10:35, Gerd Hoffmann wrote: Don't register firmware as rom, not needed (see comment). Add x86_firmware_configure() call for proper sev initialization. Signed-off-by: Gerd Hoffmann Tested-by: Xiaoyao Li --- hw/i386/x86.c | 25 +++-- 1 file changed, 19 insertion

Re: [PATCH 1/3] i386: move bios load error message

2022-03-31 Thread Philippe Mathieu-Daudé
On 31/3/22 10:35, Gerd Hoffmann wrote: Switch to usual goto-end-of-function error handling style. No functional change. Signed-off-by: Gerd Hoffmann Tested-by: Xiaoyao Li --- hw/i386/x86.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [RFC PATCH 3/4] hw/i2c: add slave mode for aspeed_i2c

2022-03-31 Thread Philippe Mathieu-Daudé
On 31/3/22 18:57, Klaus Jensen wrote: From: Klaus Jensen Add slave mode functionality for the Aspeed I2C controller. This is implemented by creating an Aspeed I2C Slave device that attaches to the bus. This i2c slave device only implements the asynchronous version of i2c_send() and the event c

Re: [PATCH] build-sys: remove MSI's QEMU_GA_MSI_MINGW_DLL_PATH

2022-03-31 Thread Philippe Mathieu-Daudé
On 31/3/22 22:11, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Since the introduction of the variable in commit 9dacf32d2cb ("qemu-ga: Building Windows MSI installation with configure/Makefile"), nothing makes use of the Mingw_dlls variable in the .wxs file. Signed-off-by: Marc-A

Re: [PATCH RESEND v3] vdpa: reset the backend device in the end of vhost_net_stop()

2022-03-31 Thread Michael S. Tsirkin
On Thu, Mar 31, 2022 at 06:19:37PM +0800, Michael Qiu wrote: > Hi, Jason > > Does it work this time? Nope. Just use git-send-email. -- MST

Re: [RFC PATCH 0/4] hw/i2c: i2c slave mode support

2022-03-31 Thread Corey Minyard
On Thu, Mar 31, 2022 at 06:57:33PM +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Hi all, > > This RFC series adds I2C "slave mode" support for the Aspeed I2C > controller as well as the necessary infrastructure in the i2c core to > support this. I've been wondering when this would happen

Re: [PATCH 0/3] i386: firmware parsing and sev setup for -bios loaded firmware

2022-03-31 Thread Michael S. Tsirkin
On Thu, Mar 31, 2022 at 10:35:46AM +0200, Gerd Hoffmann wrote: > Looks good. Acked-by: Michael S. Tsirkin Who's merging this? Yourself? > Gerd Hoffmann (3): > i386: move bios load error message > i386: factor out x86_firmware_configure() > i386: firmware parsing and sev setup for -bios

[PATCH] build-sys: remove MSI's QEMU_GA_MSI_MINGW_DLL_PATH

2022-03-31 Thread marcandre . lureau
From: Marc-André Lureau Since the introduction of the variable in commit 9dacf32d2cb ("qemu-ga: Building Windows MSI installation with configure/Makefile"), nothing makes use of the Mingw_dlls variable in the .wxs file. Signed-off-by: Marc-André Lureau --- configure | 3 --- qga/meson.bu

Re: [PATCH v2] 9p: move P9_XATTR_SIZE_MAX from 9p.h to 9p.c

2022-03-31 Thread Will Cohen
On Thu, Mar 31, 2022 at 4:00 PM Peter Maydell wrote: > On Thu, 31 Mar 2022 at 19:27, Will Cohen wrote: > > > > The patch set adding 9p functionality to darwin introduced an issue > > where limits.h, which defines XATTR_SIZE_MAX, is included in 9p.c, > > though the referenced constant is needed i

Re: [PATCH v2] 9p: move P9_XATTR_SIZE_MAX from 9p.h to 9p.c

2022-03-31 Thread Peter Maydell
On Thu, 31 Mar 2022 at 19:27, Will Cohen wrote: > > The patch set adding 9p functionality to darwin introduced an issue > where limits.h, which defines XATTR_SIZE_MAX, is included in 9p.c, > though the referenced constant is needed in 9p.h. This commit fixes that > issue by moving the definition o

Re: [PULL 0/1] Last minute tcg/aarch64 fix for 7.0

2022-03-31 Thread Peter Maydell
ilable in the Git repository at: > > https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20220331 > > for you to fetch changes up to 7ceee3a19b31818e6f7c8e429e25b219aefa8dd6: > > tcg/aarch64: Use 'ull' su

[PATCH 1/3] block/copy-before-write: create block_copy bitmap in filter node

2022-03-31 Thread Vladimir Sementsov-Ogievskiy
Currently block_copy creates copy_bitmap in source node. But that is in bad relation with .independent_close=true of copy-before-write filter: source node may be detached and removed before .bdrv_close() handler called, which should call block_copy_state_free(), which in turn should remove copy_bit

[PATCH 2/3] qapi: blockdev-backup: add discard-source parameter

2022-03-31 Thread Vladimir Sementsov-Ogievskiy
Add a parameter that enables discard-after-copy. That is mostly useful in "push backup with fleecing" scheme, when source is snapshot-access format driver node, based on copy-before-write filter snapshot-access API: [guest] [snapshot-access] ~~ blockdev-backup ~~> [backup target] |

[PATCH 3/3] iotests: add backup-discard-source

2022-03-31 Thread Vladimir Sementsov-Ogievskiy
Add test for a new backup option: discard-source. Signed-off-by: Vladimir Sementsov-Ogievskiy --- .../qemu-iotests/tests/backup-discard-source | 154 ++ .../tests/backup-discard-source.out | 5 + 2 files changed, 159 insertions(+) create mode 100755 tests/qemu-iotes

[PATCH 0/3] backup: discard-source parameter

2022-03-31 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is a new option for backup, that brings two things into push-backup-with-fleecing scheme: - discard copied region in temporary image to save disk space - avoid extra copy-before-write operation in the region that is already copied This is based on "[PATCH v5 00/45] Transactiona

Re: Re: [PATCH] target/riscv: Exit current TB after an sfence.vma

2022-03-31 Thread Palmer Dabbelt
On Wed, 30 Mar 2022 22:13:39 PDT (-0700), alistai...@gmail.com wrote: On Thu, Mar 31, 2022 at 2:36 PM Palmer Dabbelt wrote: On Wed, 30 Mar 2022 20:23:21 PDT (-0700), alistai...@gmail.com wrote: > On Thu, Mar 31, 2022 at 3:11 AM Idan Horowitz wrote: >> >> On Wed, 30 Mar 2022 at 19:11, Palmer D

  1   2   3   4   >