On Fri, May 27, 2022 at 11:34 PM Kevin Wolf wrote:
>
> Am 23.05.2022 um 10:46 hat Xie Yongji geschrieben:
> > This implements a VDUSE block backends based on
> > the libvduse library. We can use it to export the BDSs
> > for both VM and container (host) usage.
> >
> > The new command-line syntax i
hvf was missed when cpregs.h was split out.
Signed-off-by: Akihiko Odaki
---
target/arm/hvf/hvf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c
index 86710509d20..e595da31b9e 100644
--- a/target/arm/hvf/hvf.c
+++ b/target/arm/hvf/hvf.c
@@ -25,6 +
On 28/05/2022 20:20, Bernhard Beschow wrote:
TYPE_PIIX3_PCI_DEVICE resides there as already, so add the remaining
ones, too.
Signed-off-by: Bernhard Beschow
Reviewed-by: Mark Cave-Ayland
Reviewed-by: Philippe Mathieu-Daudé
---
hw/isa/piix3.c| 3 ---
include/hw/isa/isa.h
Am 22. Mai 2022 22:32:06 UTC schrieb BALATON Zoltan :
>On Sun, 22 May 2022, Bernhard Beschow wrote:
>> TYPE_PIIX3_PCI_DEVICE resides there as already, so add the remaining
>> ones, too.
>>
>> Signed-off-by: Bernhard Beschow
>> Reviewed-by: Mark Cave-Ayland
>> ---
>> hw/isa/piix3.c
On 28/05/2022 20:20, Bernhard Beschow wrote:
Just like the real hardware, create the PIIX4 ACPI controller as part of
the PIIX4 southbridge. This also mirrors how the IDE and USB functions
are already created.
Signed-off-by: Bernhard Beschow
---
hw/isa/piix4.c| 25 +++
On 28/05/2022 20:20, Bernhard Beschow wrote:
v3:
* Rebase onto 'hw/acpi/piix4: remove legacy piix4_pm_init() function' (Mark) [1]
* Use embedded structs for touched PCI devices (Mark)
* Fix piix4's rtc embedded struct to be initialized by
object_initialize_child() (Peter) [2]
Testing done:
On 29/05/2022 10:23, Bernhard Beschow wrote:
Am 22. Mai 2022 22:32:06 UTC schrieb BALATON Zoltan :
On Sun, 22 May 2022, Bernhard Beschow wrote:
TYPE_PIIX3_PCI_DEVICE resides there as already, so add the remaining
ones, too.
Signed-off-by: Bernhard Beschow
Reviewed-by: Mark Cave-Ayland
---
h
On 29/05/2022 10:46, Mark Cave-Ayland wrote:
On 28/05/2022 20:20, Bernhard Beschow wrote:
v3:
* Rebase onto 'hw/acpi/piix4: remove legacy piix4_pm_init() function' (Mark) [1]
* Use embedded structs for touched PCI devices (Mark)
* Fix piix4's rtc embedded struct to be initialized by
object_
On 27/5/22 19:11, Richard Henderson wrote:
Fixes a number of assembler warnings of the form:
test-i386.c: Assembler messages:
test-i386.c:869: Warning: no instruction mnemonic suffix given
and no register operands; using default for `fist'
Signed-off-by: Richard Henderson
---
tests/tcg/i3
On 29/5/22 10:25, Akihiko Odaki wrote:
Signed-off-by: Akihiko Odaki
---
ui/cocoa.m | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/ui/cocoa.m b/ui/cocoa.m
index 09a62817f2a..84c84e98fc5 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -35,6 +35,7 @@
#include "ui/kbd-stat
On Sun, 29 May 2022 at 09:27, Akihiko Odaki wrote:
>
> hvf was missed when cpregs.h was split out.
>
> Signed-off-by: Akihiko Odaki
Thanks; there's already a patch on the list for this:
https://patchew.org/QEMU/20220525161926.34233-1-phi...@fungible.com/
-- PMM
On 26/5/22 21:00, Peter Maydell wrote:
In two places in gdbstub.c we look at gdbserver_state.init to decide
whether we're going to do a semihosting syscall via the gdb remote
protocol:
* when setting up, if the user didn't explicitly select either
native semihosting or gdb semihosting, we a
On Sun, May 29, 2022 at 12:06 PM Mark Cave-Ayland <
mark.cave-ayl...@ilande.co.uk> wrote:
> On 29/05/2022 10:46, Mark Cave-Ayland wrote:
>
> > On 28/05/2022 20:20, Bernhard Beschow wrote:
> >
> >> v3:
> >> * Rebase onto 'hw/acpi/piix4: remove legacy piix4_pm_init() function'
> (Mark) [1]
> >> * Us
Hi
Please, send any topic that you are interested in covering.
At the end of Monday I will send an email with the agenda or the
cancellation of the call, so hurry up.
After discussions on the QEMU Summit, we are going to have always open a
KVM call where you can add topics.
Call details:
B
On 28/5/22 11:19, Mark Cave-Ayland wrote:
Whilst reviewing Bernhard's PIIX Southbridge QOMifcation patches at
https://lists.gnu.org/archive/html/qemu-devel/2022-05/msg04329.html, I
noticed that we should first eliminate the legacy device init function
piix4_pm_init().
This series moves the outst
On Sun, May 29, 2022 at 11:25 AM Mark Cave-Ayland <
mark.cave-ayl...@ilande.co.uk> wrote:
> On 28/05/2022 20:20, Bernhard Beschow wrote:
>
> > Just like the real hardware, create the PIIX4 ACPI controller as part of
> > the PIIX4 southbridge. This also mirrors how the IDE and USB functions
> > are
On Sun, May 29, 2022 at 11:05 AM Mark Cave-Ayland <
mark.cave-ayl...@ilande.co.uk> wrote:
> On 28/05/2022 20:20, Bernhard Beschow wrote:
>
> > TYPE_PIIX3_PCI_DEVICE resides there as already, so add the remaining
> > ones, too.
> >
> > Signed-off-by: Bernhard Beschow
> > Reviewed-by: Mark Cave-Ayl
Am 28. Mai 2022 09:19:27 UTC schrieb Mark Cave-Ayland
:
>This exposes the PIIX4_PM device to the caller to allow any qdev gpios to be
>mapped outside of piix4_pm_init().
>
>Signed-off-by: Mark Cave-Ayland
>---
> hw/acpi/piix4.c | 11 ---
> hw/i386/pc_piix.c | 10 +
Am 29. Mai 2022 18:05:41 UTC schrieb "Philippe Mathieu-Daudé" :
>On 28/5/22 11:19, Mark Cave-Ayland wrote:
>> Whilst reviewing Bernhard's PIIX Southbridge QOMifcation patches at
>> https://lists.gnu.org/archive/html/qemu-devel/2022-05/msg04329.html, I
>> noticed that we should first eliminate the l
On Fri, May 27, 2022 at 05:54:12PM +0200, Kevin Wolf wrote:
> Am 26.05.2022 um 13:36 hat Yongji Xie geschrieben:
> > On Wed, May 25, 2022 at 8:19 PM Stefan Hajnoczi wrote:
> > >
> > > Document vduse-blk exports in qemu-storage-daemon --help and the
> > > qemu-storage-daemon(1) man page.
> > >
> >
Since commit 3b004a16540aa41f2aa6a1ceb0bf306716766914 'hw/rtc/
mc146818rtc: QOM'ify IRQ number' mc146818rtc's IRQ number is
configurable. Fix microvm-dt to respect its value.
Signed-off-by: Bernhard Beschow
Reviewed-by: Mark Cave-Ayland
Reviewed-by: Philippe Mathieu-Daudé
---
hw/i386/microvm-d
v3:
* "iobase" is now u16 (Philippe)
v2:
* Explicitly fail with &error_abort rather than NULL (Mark)
* Explicitly fail with &error_abort rather than NULL in existing code (me)
* Unexport rather than remove RTC_ISA_BASE (Mark)
* Use object_property_get_*u*int() also for "iobase" (me)
v1:
This litt
New code will be added where this is best practice. So update existing code
as well.
Signed-off-by: Bernhard Beschow
Reviewed-by: Philippe Mathieu-Daudé
---
hw/i386/microvm-dt.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/i386/microvm-dt.c b/hw/i386/microvm-dt.c
Exposing the io_base offset as a QOM property not only allows it to be
configurable but also to be displayed in HMP:
Before:
(qemu) info qtree
...
dev: mc146818rtc, id ""
gpio-out "" 1
base_year = 0 (0x0)
irq = 8 (0x8)
lost_tick_pol
Am 28. Mai 2022 09:19:26 UTC schrieb Mark Cave-Ayland
:
>This allows the QOM types in hw/acpi/piix4.c to be used elsewhere by simply
>including
>hw/acpi/piix4.h.
>
>Signed-off-by: Mark Cave-Ayland
>---
> hw/acpi/piix4.c | 43 +---
> hw/i386/acpi-build.c | 1
Am 28. Mai 2022 09:19:29 UTC schrieb Mark Cave-Ayland
:
>Use the new piix4_pm_init() instance init function to initialise 2 separate
>qdev
>gpios for the SCI and SMI IRQs.
>
>Signed-off-by: Mark Cave-Ayland
>---
> hw/acpi/piix4.c | 9 +
> 1 file changed, 9 insertions(+)
>
>diff --git a/hw
From: Marc-André Lureau
The following changes since commit 2417cbd5916d043e0c56408221fbe9935d0bc8da:
Merge tag 'ak-pull-request' of https://gitlab.com/berrange/qemu into staging
(2022-05-26 07:00:04 -0700)
are available in the Git repository at:
g...@gitlab.com:marcandre.lureau/qemu.git t
From: Marc-André Lureau
SHGetFolderPath() is a deprecated API:
https://docs.microsoft.com/en-us/windows/win32/api/shlobj_core/nf-shlobj_core-shgetfolderpatha
It is a wrapper for SHGetKnownFolderPath() and CSIDL_COMMON_PATH is
mapped to FOLDERID_ProgramData:
https://docs.microsoft.com/en-us/windo
From: Marc-André Lureau
The function takes care of setting CLOEXEC.
Signed-off-by: Marc-André Lureau
Reviewed-by: Markus Armbruster
Message-Id: <20220525144140.591926-7-marcandre.lur...@redhat.com>
---
qga/commands-posix.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --g
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Thomas Huth
Message-Id: <20220525144140.591926-4-marcandre.lur...@redhat.com>
---
tests/qtest/libqmp.h | 2 ++
tests/qtest/libqmp.c | 34 +-
2 files changed, 31 insertions(+), 5 deletions(-)
From: Marc-André Lureau
QGA calls qemu_open_old() in various places. Calling qemu_open() instead
isn't a great alternative, as it has special "/dev/fdset" handling and
depends on QEMU internal monitor data structures.
Instead, provide a simple helper for QGA needs, with Error* support. The
follo
From: Marc-André Lureau
The function is required by get_relocated_path() (already in cutils),
and used by qemu-ga and may be generally useful.
Signed-off-by: Marc-André Lureau
Reviewed-by: Markus Armbruster
Message-Id: <20220525144140.591926-2-marcandre.lur...@redhat.com>
---
include/qemu/cut
From: Marc-André Lureau
There is a bit too much nesting in the function, this can be simplified
a bit to improve readability.
This also helps with the following error handling changes.
Signed-off-by: Marc-André Lureau
Reviewed-by: Markus Armbruster
Message-Id: <20220525144140.591926-5-marcand
From: Marc-André Lureau
No need to setup an environment or to check if the variable is undefined
manually.
Signed-off-by: Marc-André Lureau
Reviewed-by: Konstantin Kostiuk
Message-Id: <20220525144140.591926-12-marcandre.lur...@redhat.com>
---
qga/installer/qemu-ga.wxs | 30 +--
From: Marc-André Lureau
Change build_fs_mount_list() to return bool, in accordance
with the guidance under = Rules = in include/qapi/error.h
Signed-off-by: Marc-André Lureau
Suggested-by: Markus Armbruster
Message-Id: <20220525144140.591926-10-marcandre.lur...@redhat.com>
---
qga/commands-pos
From: Marc-André Lureau
Allow for a single point of error reporting, and further refactoring.
Signed-off-by: Marc-André Lureau
Reviewed-by: Markus Armbruster
Message-Id: <20220525144140.591926-8-marcandre.lur...@redhat.com>
---
qga/channel-posix.c | 42 +---
From: Marc-André Lureau
This a more accurate way to lookup the test data, and will allow to move
the test in a subproject.
Signed-off-by: Marc-André Lureau
Reviewed-by: Konstantin Kostiuk
Message-Id: <20220525144140.591926-11-marcandre.lur...@redhat.com>
---
tests/unit/test-qga.c | 11 +--
From: Marc-André Lureau
Sadly, wixl doesn't have 'elif'.
Signed-off-by: Marc-André Lureau
Reviewed-by: Konstantin Kostiuk
Message-Id: <20220525144140.591926-14-marcandre.lur...@redhat.com>
---
qga/installer/qemu-ga.wxs | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-
From: Marc-André Lureau
qemu_open_old() uses qemu_open_internal() which handles special
"/dev/fdset/" path for monitor fd sets, set CLOEXEC, and uses Error
reporting (and some O_DIRECT special error casing).
The monitor fdset handling is unnecessary for qga, use
qga_open_cloexec() instead.
Sign
From: Marc-André Lureau
Use more conventional variables to set the location of pre-built
DLL/bin.
Signed-off-by: Marc-André Lureau
Reviewed-by: Konstantin Kostiuk
Message-Id: <20220525144140.591926-15-marcandre.lur...@redhat.com>
---
configure | 9 ++---
meson.build
From: Marc-André Lureau
No clear reason to make guesses here.
Signed-off-by: Marc-André Lureau
Reviewed-by: Konstantin Kostiuk
Message-Id: <20220525144140.591926-13-marcandre.lur...@redhat.com>
---
qga/installer/qemu-ga.wxs | 9 -
1 file changed, 9 deletions(-)
diff --git a/qga/insta
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Konstantin Kostiuk
Message-Id: <20220525144140.591926-16-marcandre.lur...@redhat.com>
---
tests/unit/test-qga.c | 121 +++---
1 file changed, 43 insertions(+), 78 deletions(-)
diff --git
On 5/29/22 15:51, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
The following changes since commit 2417cbd5916d043e0c56408221fbe9935d0bc8da:
Merge tag 'ak-pull-request' of https://gitlab.com/berrange/qemu into staging
(2022-05-26 07:00:04 -0700)
are available in the Git repos
Hello all,
I'm starting to develop with the surrounding qemu libraries trying to add
the internals of a system target. I am working with the type system right
now, which I do know how to interact with. I think there is like some way
to script or interact with the qemu periphery via a cli. I found
(v1 Subject was "acpi/nvdimm: support NVDIMM _LS{I,R,W} methods")
Originally NVDIMM Label methods was defined in Intel PMEM _DSM Interface
Spec [1], of function index 4, 5 and 6.
Recent ACPI spec [2] has deprecated those _DSM methods with ACPI NVDIMM
Label Methods _LS{I,R,W}. The essence of these
The Intel Optane PMem DSM Interface, Version 2.0 [1], is the up-to-date
spec for NVDIMM _DSM definition, which supports revision_id == 2.
Nevertheless, Rev.2 of NVDIMM _DSM has no functional change on those Label
Data _DSM Functions, which are the only ones implemented for vNVDIMM.
So, simple chan
In If condition, using bitwise and/or, rather than logical and/or.
The result change in AML code:
If (((Local6 == Zero) | (Arg0 != Local0)))
==>
If (((Local6 == Zero) || (Arg0 != Local0)))
If (((ObjectType (Arg3) == 0x04) & (SizeOf (Arg3) == One)))
==>
If (((ObjectType (Arg3) == 0x04) && (SizeOf
Recent ACPI spec [1] has defined NVDIMM Label Methods _LS{I,R,W}, which
depricates corresponding _DSM Functions defined by PMEM _DSM Interface spec
[2].
In this implementation, we do 2 things
1. Generalize the QEMU<->ACPI BIOS NVDIMM interface, wrap it with ACPI
method dispatch, _DSM is one of the
Signed-off-by: Robert Hoo
Reviewed-by: Jingqi Liu
---
tests/qtest/bios-tables-test-allowed-diff.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..eb8bae1407 100644
--- a/tests/qtest
Diff in disassembled ASL files
@@ -1,100 +1,103 @@
/*
* Intel ACPI Component Architecture
* AML/ASL+ Disassembler version 20190509 (64-bit version)
* Copyright (c) 2000 - 2019 Intel Corporation
*
* Disassembling to symbolic ASL+ operators
*
- * Disassembly of tests/data/acpi/q35/SSDT.d
Signed-off-by: Robert Hoo
Reviewed-by: Jingqi Liu
---
hw/acpi/nvdimm.c| 38 ++
hw/acpi/trace-events| 14 ++
include/hw/mem/nvdimm.h | 8
3 files changed, 32 insertions(+), 28 deletions(-)
diff --git a/hw/acpi/nvdimm.c b/hw/ac
Hi guys,
Ping...Any other comments?
在 2022/5/14 12:11, Longpeng(Mike) 写道:
From: Longpeng
Hi guys,
With the generic vDPA device, QEMU won't need to touch the device
types any more, such like vfio.
We can use the generic vDPA device as follow:
-device vhost-vdpa-device-pci,vhostdev=/dev/vh
On Sat, May 28, 2022 at 2:49 PM Mark Cave-Ayland
wrote:
>
> This logic can be included as part of piix4_pm_realize() and does not need to
> be handled externally.
>
> Signed-off-by: Mark Cave-Ayland
Reviewed-by: Ani Sinha
> ---
> hw/acpi/piix4.c | 7 ---
> 1 file changed, 4 insertions(+),
On Sat, May 28, 2022 at 2:49 PM Mark Cave-Ayland
wrote:
>
> This is in preparation for conversion to a qdev property.
>
> Signed-off-by: Mark Cave-Ayland
other than the comment below,
Reviewed-by: Ani Sinha
> ---
> hw/acpi/piix4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> di
Hi everyone,
I'm Sam Li, working on the Outreachy project which is to add zoned
device support to QEMU's virtio-blk emulation.
For the first goal, adding QEMU block layer APIs resembling Linux ZBD
ioctls, I think the naive approach would be to introduce a new stable
struct zbd_zone descriptor for
On Sat, May 28, 2022 at 2:49 PM Mark Cave-Ayland
wrote:
>
> This allows the smm_enabled value to be set using a standard qdev property
> instead
> of being referenced directly in piix4_pm_init().
>
> Signed-off-by: Mark Cave-Ayland
Reviewed-by: Ani Sinha
> ---
> hw/acpi/piix4.c | 3 ++-
> 1
On 2022/05/30 14:09, Sam Li wrote:
> Hi everyone,
Hi Sam,
> I'm Sam Li, working on the Outreachy project which is to add zoned
> device support to QEMU's virtio-blk emulation.
>
> For the first goal, adding QEMU block layer APIs resembling Linux ZBD
> ioctls, I think the naive approach would be
On 5/30/22 13:02, HORIGUCHI NAOYA(堀口 直也) wrote:
On Fri, May 20, 2022 at 03:06:47PM +0800, zhenwei pi wrote:
Origianlly, unpoison_memory() is only used by hwpoison-inject, and
unpoisons a page which is poisoned by hwpoison-inject too. The kernel PTE
entry has no change during software poison/u
On Fri, May 27, 2022 at 10:27 PM Julia Suvorova wrote:
>
> Introduce the 64-bit entry point. Since we no longer have a total
> number of structures, stop checking for the new ones at the EOF
> structure (type 127).
>
> Signed-off-by: Julia Suvorova
> ---
> tests/qtest/bios-tables-test.c | 101 ++
On 25/05/2022 19.34, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Could you please provide a patch description? (What's the benefit of this
patch? Why is testlog.txt not sufficient?)
Thanks,
Thomas
Signed-off-by: Marc-André Lureau
---
.gitlab-ci.d/buildtest-template.y
On 20.05.22 09:06, zhenwei pi wrote:
> Origianlly, unpoison_memory() is only used by hwpoison-inject, and
> unpoisons a page which is poisoned by hwpoison-inject too. The kernel PTE
> entry has no change during software poison/unpoison.
>
> On a virtualization platform, it's possible to fix hardwa
61 matches
Mail list logo