Re: [PATCH v2 3/3] target/mips: implement Octeon-specific arithmetic instructions

2022-06-13 Thread Pavel Dovgalyuk
On 09.06.2022 18:53, Richard Henderson wrote: On 6/9/22 01:23, Pavel Dovgalyuk wrote: +static bool trans_BADDU(DisasContext *ctx, arg_BADDU *a) +{ +    TCGv t0, t1; + +    if (a->rt == 0) { +    /* nop */ +    return true; +    } I believe that we're standardizing on using

Re: [PATCH] qemu-iotests: Discard stderr when probing devices

2022-06-13 Thread Thomas Huth
On 05/06/2022 16.57, Cole Robinson wrote: ./configure --enable-modules --enable-smartcard \ --target-list=x86_64-softmmu,s390x-softmmu make cd build QEMU_PROG=`pwd`/s390x-softmmu/qemu-system-s390x \ ../tests/check-block.sh qcow2 ... ---

Re: [PATCH v2 1/2] hw: m25p80: add WP# pin and SRWD bit for write protection

2022-06-13 Thread Dan Zhang
Just find out how to use mutt to reply all in the thread. repeat the previous comments. Add STATE_HIZ to handle decode_new_command aborting gracefully. On Thu, Jun 09, 2022 at 08:06:00PM +, Peter Delevoryas wrote: > > > > On Jun 9, 2022, at 12:22 PM, Francisco Iglesias > > wrote: > > >

Re: Re: [PULL 00/18] Block layer patches

2022-06-13 Thread Yongji Xie
On Tue, Jun 14, 2022 at 1:04 AM Kevin Wolf wrote: > > Am 09.06.2022 um 22:18 hat Richard Henderson geschrieben: > > On 6/9/22 10:21, Kevin Wolf wrote: > > > The following changes since commit > > > 028f2361d0c2d28d6f918fe618f389228ac22b60: > > > > > >Merge tag 'pull-target-arm-20220609' of

[PATCH v3 2/2] QIOChannelSocket: Fix zero-copy send so socket flush works

2022-06-13 Thread Leonardo Bras
Somewhere between v6 and v7 the of the zero-copy-send patchset a crucial part of the flushing mechanism got missing: incrementing zero_copy_queued. Without that, the flushing interface becomes a no-op, and there is no guarantee the buffer is really sent. This can go as bad as causing a

Re: [PATCH v2 1/2] hw: m25p80: add WP# pin and SRWD bit for write protection

2022-06-13 Thread Dan Zhang
On Thu, Jun 09, 2022 at 08:06:00PM +, Peter Delevoryas wrote: > > > > On Jun 9, 2022, at 12:22 PM, Francisco Iglesias > > wrote: > > > > Hi Iris, > > > > Looks good some, a couple of comments below. > > > > On [2022 Jun 08] Wed 20:13:19, Iris Chen wrote: > >> From: Iris Chen > >> > >>

[PATCH v3 1/2] QIOChannelSocket: Introduce assert and reduce ifdefs to improve readability

2022-06-13 Thread Leonardo Bras
During implementation of MSG_ZEROCOPY feature, a lot of #ifdefs were introduced, particularly at qio_channel_socket_writev(). Rewrite some of those changes so it's easier to read. Also, introduce an assert to help detect incorrect zero-copy usage is when it's disabled on build. Signed-off-by:

[PATCH v2 6/6] vduse-blk: Add name option

2022-06-13 Thread Xie Yongji
Currently we use 'id' option as the name of VDUSE device. It's a bit confusing since we use one value for two different purposes: the ID to identfy the export within QEMU (must be distinct from any other exports in the same QEMU process, but can overlap with names used by other processes), and the

[PATCH v2 1/6] libvduse: Fix some compile errors with clang

2022-06-13 Thread Xie Yongji
This fixes some compile errors with clang: ../subprojects/libvduse/libvduse.c:578:20: error: unused function 'vring_used_flags_set_bit' [-Werror,-Wunused-function] static inline void vring_used_flags_set_bit(VduseVirtq *vq, int mask) ^ ../subprojects/libvduse/libvduse.c:587:20:

[PATCH v2 4/6] vduse-blk: Don't delete the export until all inflight I/Os completed

2022-06-13 Thread Xie Yongji
Don't delete the export until all inflight I/Os completed. Otherwise, it might lead to a use-after-free. Fixes: cc241b5505b2 ("vduse-blk: Implement vduse-blk export") Signed-off-by: Xie Yongji --- block/export/vduse-blk.c | 22 ++ 1 file changed, 22 insertions(+) diff --git

[PATCH v2 5/6] vduse-blk: Add serial option

2022-06-13 Thread Xie Yongji
Add a 'serial' option to allow user to specify this value explicitly. And the default value is changed to an empty string as what we did in "hw/block/virtio-blk.c". Signed-off-by: Xie Yongji --- block/export/vduse-blk.c | 20 ++-- block/export/vhost-user-blk-server.c

[PATCH v2 0/6] Some fixes and improvements for vduse-blk

2022-06-13 Thread Xie Yongji
This series includes few fixes and improvements for the vduse-blk export. Patch 1 fixes some compile errors with clang in 32-bit machine. Patch 2 fixes resources leak when vduse fd is zero. Patch 3, 4 fixes two bugs which could be triggered by force deleting a vduse-blk export with high I/O

[PATCH v2 3/6] vduse-blk: Don't unlink the reconnect file if device exists

2022-06-13 Thread Xie Yongji
We should not unlink the reconnect file if vduse_dev_destroy() fails with -EBUSY which means the VDUSE device has not been removed from the vDPA bus. Otherwise, we might fail on the reconnection later. Fixes: 730abef0e873 ("libvduse: Add support for reconnecting") Signed-off-by: Xie Yongji ---

[PATCH v2 2/6] libvduse: Fix resources leak in vduse_dev_destroy()

2022-06-13 Thread Xie Yongji
This fixes resource leak when the fd is zero in vduse_dev_destroy(). Fixes: 8dbd281c1675 ("libvduse: Add VDUSE (vDPA Device in Userspace) library") Signed-off-by: Xie Yongji --- subprojects/libvduse/libvduse.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2 08/11] bsd-user: Implement rmdir and undocumented __getcwd

2022-06-13 Thread Richard Henderson
On 6/13/22 21:20, Warner Losh wrote: Implemenet rmdir and __getcwd. __getcwd is the undocumented back end to getcwd(3). Signed-off-by: Stacey Son Signed-off-by: Jung-uk Kim Signed-off-by: Warner Losh Reviewed-by: Richard Henderson r~

Re: [PATCH 2/5] tests/qemu-iotests: skip 108 when FUSE is not loaded

2022-06-13 Thread Thomas Huth
On 14/06/2022 03.50, John Snow wrote: In certain container environments we may not have FUSE at all, so skip the test in this circumstance too. Signed-off-by: John Snow --- tests/qemu-iotests/108 | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/qemu-iotests/108

Re: [PATCH 4/5] tests/vm: switch CentOS 8 to CentOS 8 Stream

2022-06-13 Thread Thomas Huth
On 14/06/2022 03.50, John Snow wrote: The old CentOS image didn't work anymore because it was already EOL at the beginning of 2022. Signed-off-by: John Snow --- tests/vm/centos | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v4 2/2] target/xtensa: Use semihosting/syscalls.h

2022-06-13 Thread Richard Henderson
On 6/13/22 18:06, Max Filippov wrote: +++ b/hw/xtensa/sim.c @@ -87,9 +87,6 @@ XtensaCPU *xtensa_sim_common_init(MachineState *machine) xtensa_create_memory_regions(, "xtensa.sysram", get_system_memory()); } -if (serial_hd(0)) { -

Re: [PATCH 3/5] tests/vm: use 'cp' instead of 'ln' for temporary vm images

2022-06-13 Thread Thomas Huth
On 14/06/2022 03.50, John Snow wrote: If the initial setup fails, you've permanently altered the state of the downloaded image in an unknowable way. Use 'cp' like our other test setup scripts do. Signed-off-by: John Snow --- tests/vm/centos | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v1 3/7] gitlab-ci: Fix the build-cfi-aarch64 and build-cfi-ppc64-s390x jobs

2022-06-13 Thread Thomas Huth
On 13/06/2022 23.46, Richard Henderson wrote: On 6/13/22 10:12, Alex Bennée wrote: From: Thomas Huth The job definitions recently got a second "variables:" section by accident and thus are failing now if one tries to run them. Merge the two sections into one again to fix the issue. And while

[PATCH v2 09/11] bsd-user: Implement dup and dup2

2022-06-13 Thread Warner Losh
Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/bsd-file.h | 12 bsd-user/freebsd/os-syscall.c | 8 2 files changed, 20 insertions(+) diff --git a/bsd-user/bsd-file.h b/bsd-user/bsd-file.h index

[PATCH v2 11/11] bsd-user: Implement acct and sync

2022-06-13 Thread Warner Losh
Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/bsd-file.h | 23 +++ bsd-user/freebsd/os-syscall.c | 8 2 files changed, 31 insertions(+) diff --git a/bsd-user/bsd-file.h b/bsd-user/bsd-file.h index

[PATCH v2 06/11] bsd-user: Implement link, linkat, unlink and unlinkat

2022-06-13 Thread Warner Losh
Signed-off-by: Stacey Son Signed-off-by: Jung-uk Kim Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/bsd-file.h | 54 +++ bsd-user/freebsd/os-syscall.c | 16 +++ 2 files changed, 70 insertions(+) diff --git

[PATCH v2 07/11] bsd-user: Implement mkdir and mkdirat

2022-06-13 Thread Warner Losh
Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/bsd-file.h | 27 +++ bsd-user/freebsd/os-syscall.c | 8 2 files changed, 35 insertions(+) diff --git a/bsd-user/bsd-file.h b/bsd-user/bsd-file.h index

[PATCH v2 10/11] bsd-user: Implement trunctate and ftruncate

2022-06-13 Thread Warner Losh
Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/bsd-file.h | 29 + bsd-user/freebsd/os-syscall.c | 8 2 files changed, 37 insertions(+) diff --git a/bsd-user/bsd-file.h b/bsd-user/bsd-file.h index

[PATCH v2 05/11] bsd-user: Implement rename and renameat

2022-06-13 Thread Warner Losh
Plus the helper LOCK_PATH2 and UNLOCK_PATH2 macros. Signed-off-by: Stacey Son Signed-off-by: Jung-uk Kim Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/bsd-file.h | 45 +++ bsd-user/freebsd/os-syscall.c | 8 +++ 2 files

[PATCH v2 00/11] bsd-user: Next round of syscalls

2022-06-13 Thread Warner Losh
Implement the next round of system calls. These are open, openat, close, fdatasync, fsync, close_from, revoke, access, eacccess, facccessat, chdir, fchdir, rename, renameat, mkdir, mkdirat, rmdir, _getcwd, dup, dup2, truncate, ftruncate, acct and sync. In addition, the helper functions needed for

[PATCH v2 08/11] bsd-user: Implement rmdir and undocumented __getcwd

2022-06-13 Thread Warner Losh
Implemenet rmdir and __getcwd. __getcwd is the undocumented back end to getcwd(3). Signed-off-by: Stacey Son Signed-off-by: Jung-uk Kim Signed-off-by: Warner Losh --- bsd-user/bsd-file.h | 29 + bsd-user/freebsd/os-syscall.c | 8 2 files

[PATCH v2 04/11] bsd-user: Implement chdir and fchdir

2022-06-13 Thread Warner Losh
Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/bsd-file.h | 19 +++ bsd-user/freebsd/os-syscall.c | 8 2 files changed, 27 insertions(+) diff --git a/bsd-user/bsd-file.h b/bsd-user/bsd-file.h index

[PATCH v2 01/11] bsd-user: Implement open, openat and close

2022-06-13 Thread Warner Losh
Add the open, openat and close system calls. We need to lock paths, so implmenent that as well. Signed-off-by: Stacey Son Signed-off-by: Jung-uk Kim Signed-off-by: Kyle Evans Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/bsd-file.h | 49

[PATCH v2 02/11] bsd-user: Implement fdatasync, fsync and close_from

2022-06-13 Thread Warner Losh
Implement fdatasync(2), fsync(2) and close_from(2). Signed-off-by: Stacey Son Signed-off-by: Jung-uk Kim Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/bsd-file.h | 19 +++ bsd-user/freebsd/os-syscall.c | 12 2 files changed, 31

[PATCH v2 03/11] bsd-user: Implement revoke, access, eaccess and faccessat

2022-06-13 Thread Warner Losh
Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/bsd-file.h | 53 +++ bsd-user/freebsd/os-syscall.c | 16 +++ 2 files changed, 69 insertions(+) diff --git a/bsd-user/bsd-file.h

Re: [External] [PATCH v13 3/8] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-06-13 Thread Leonardo Bras Soares Passos
On Mon, Jun 13, 2022 at 7:53 PM Peter Xu wrote: > > On Mon, Jun 13, 2022 at 05:58:44PM -0300, Leonardo Bras Soares Passos wrote: > > Hello Peter, > > > > On Wed, Jun 8, 2022 at 5:23 PM Peter Xu wrote: > > [...] > > > > In a previous iteration of the patchset, it was made clear that it's > > > >

Re: [Bug] Take more 150s to boot qemu on ARM64

2022-06-13 Thread chenxiang (M)
在 2022/6/13 21:22, Paul E. McKenney 写道: On Mon, Jun 13, 2022 at 08:26:34PM +0800, chenxiang (M) wrote: Hi all, I encounter a issue with kernel 5.19-rc1 on a ARM64 board: it takes about 150s between beginning to run qemu command and beginng to boot Linux kernel ("EFI stub: Booting Linux

[PATCH 4/5] tests/vm: switch CentOS 8 to CentOS 8 Stream

2022-06-13 Thread John Snow
The old CentOS image didn't work anymore because it was already EOL at the beginning of 2022. Signed-off-by: John Snow --- tests/vm/centos | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/vm/centos b/tests/vm/centos index be4f6ff2f14..f5bbdecf62d 100755 ---

[PATCH 3/5] tests/vm: use 'cp' instead of 'ln' for temporary vm images

2022-06-13 Thread John Snow
If the initial setup fails, you've permanently altered the state of the downloaded image in an unknowable way. Use 'cp' like our other test setup scripts do. Signed-off-by: John Snow --- tests/vm/centos | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vm/centos

[PATCH 0/5] Update CentOS VM tests

2022-06-13 Thread John Snow
This patch series attempts to revive the CentOS VM test targets, because both appear to be presently non-functional. I didn't quite get it working 100%, but I'm sending anyway to ask for help in solving straggler problems. My experience testing these is that CentOS 8 (x86_64) fails on test-qga:

[PATCH 1/5] tests/qemu-iotests: hotfix for 307, 223 output

2022-06-13 Thread John Snow
Fixes: 58a6fdcc Signed-off-by: John Snow --- tests/qemu-iotests/223.out | 4 ++-- tests/qemu-iotests/307.out | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/223.out b/tests/qemu-iotests/223.out index 06479415312..26fb347c5da 100644 ---

[PATCH 2/5] tests/qemu-iotests: skip 108 when FUSE is not loaded

2022-06-13 Thread John Snow
In certain container environments we may not have FUSE at all, so skip the test in this circumstance too. Signed-off-by: John Snow --- tests/qemu-iotests/108 | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/qemu-iotests/108 b/tests/qemu-iotests/108 index 9e923d6a59f..e401c5e9933

Re: [Phishing Risk] [External] Re: [PATCH 4/7] crypto: Add ECDSA key parser

2022-06-13 Thread 何磊
Hi Philippe, lots of thanks for your review! > On Jun 13, 2022, at 10:19 PM, Philippe Mathieu-Daudé wrote: > > On 13/6/22 10:45, Lei He wrote: >> Add ECDSA key parser and ECDSA signautre parser. >> Signed-off-by: lei he >> --- >> crypto/ecdsakey-builtin.c.inc | 248 >>

RE: [PATCH] virtio/vhost-user: Fix wrong vhost notifier GPtrArray size

2022-06-13 Thread Yajun Wu
Hi Michael, User space vhost clients are broken for few weeks now without this fix. With Alex's review, can you please merge it if there are no further comments? Thanks. -Original Message- From: Alex Bennée Sent: Thursday, May 26, 2022 3:09 PM To: Yajun Wu Cc: qemu-devel@nongnu.org;

Re: [PATCH v4 2/2] target/xtensa: Use semihosting/syscalls.h

2022-06-13 Thread Max Filippov
On Tue, Jun 7, 2022 at 10:36 PM Richard Henderson wrote: > > This separates guest file descriptors from host file descriptors, > and utilizes shared infrastructure for integration with gdbstub. > Remove the xtensa custom console handing and rely on the > generic -semihosting-config handling of

[PULL 7/7] .gitlab: use less aggressive nproc on our aarch64/32 runners

2022-06-13 Thread Alex Bennée
Running on all 80 cores of our aarch64 runner does occasionally trigger a race condition which fails the build. However the CI system is not the time and place to play with much heisenbugs so turn down the nproc to "only" use 40 cores in the build. Signed-off-by: Alex Bennée Reviewed-by: Richard

[PULL 5/7] tests/tcg: disable xtensa-linux-user again

2022-06-13 Thread Alex Bennée
From: Paolo Bonzini The move from tests/tcg/configure.sh started enabling the container image for xtensa-linux-user, which fails because the compiler does not have the full set of headers. The cause is the "xtensa*-softmmu)" case in tests/tcg/configure.sh which became just "xtensa*)" in the new

[PULL 1/7] test/tcg/arm: Use -mfloat-abi=soft for test-armv6m-undef

2022-06-13 Thread Alex Bennée
From: Richard Henderson GCC11 from crossbuild-essential-armhf from ubuntu 22.04 errors: cc1: error: ‘-mfloat-abi=hard’: selected architecture lacks an FPU Signed-off-by: Richard Henderson Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PULL 3/7] gitlab-ci: Fix the build-cfi-aarch64 and build-cfi-ppc64-s390x jobs

2022-06-13 Thread Alex Bennée
From: Thomas Huth The job definitions recently got a second "variables:" section by accident and thus are failing now if one tries to run them. Merge the two sections into one again to fix the issue. And while we're at it, bump the timeout here (70 minutes are currently not enough for the

[PULL 6/7] gitlab: compare CIRRUS_nn vars against 'null' not ""

2022-06-13 Thread Alex Bennée
From: Daniel P. Berrangé The GitLab variable comparisons don't have shell like semantics where an unset variable compares equal to empty string. We need to explicitly test against 'null' to detect an unset variable. Signed-off-by: Daniel P. Berrangé Tested-by: Richard Henderson Reviewed-by:

[PULL 4/7] tests/docker: fix the IMAGE for build invocation

2022-06-13 Thread Alex Bennée
We inadvertently broke the ability to run local builds when the code was re-factored. The result was the run stanza failing to find the docker image with it's qemu/ prefix. Signed-off-by: Alex Bennée Fixes: d39eaa2266 ("tests/docker: simplify docker-TEST@IMAGE targets") Reviewed-by: Richard

[PULL 2/7] tests/tcg/i386: Use explicit suffix on fist insns

2022-06-13 Thread Alex Bennée
From: Richard Henderson Fixes a number of assembler warnings of the form: test-i386.c: Assembler messages: test-i386.c:869: Warning: no instruction mnemonic suffix given and no register operands; using default for `fist' Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé

[PULL 0/7] testing/next (docker, gitlab,tcg)

2022-06-13 Thread Alex Bennée
The following changes since commit dcb40541ebca7ec98a14d461593b3cd7282b4fac: Merge tag 'mips-20220611' of https://github.com/philmd/qemu into staging (2022-06-11 21:13:27 -0700) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testing-next-140622-1 for

Re: [PATCH 08/11] bsd-user: Implement rmdir and undocumented -_getcwd

2022-06-13 Thread Warner Losh
On Mon, Jun 13, 2022 at 1:52 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 6/12/22 13:48, Warner Losh wrote: > > Implemenet rmdir and __getcwd. Declare __getcwd as extern because > > there's no installed FreeBSD header that has it. It's used internally by > > libc, which

Re: [PATCH 03/11] bsd-user: Implement revoke, access, eaccess and faccessat

2022-06-13 Thread Philippe Mathieu-Daudé via
On 12/6/22 22:48, Warner Losh wrote: Signed-off-by: Stacey Son Signed-off-by: Warner Losh --- bsd-user/bsd-file.h | 53 +++ bsd-user/freebsd/os-syscall.c | 16 +++ 2 files changed, 69 insertions(+) diff --git a/bsd-user/bsd-file.h

Re: [PATCH v1 7/7] .gitlab: use less aggressive nproc on our aarch64/32 runners

2022-06-13 Thread Philippe Mathieu-Daudé via
On 13/6/22 19:12, Alex Bennée wrote: Running on all 80 cores of our aarch64 runner does occasionally trigger a race condition which fails the build. However the CI system is not the time and place to play with much heisenbugs so turn down the nproc to "only" use 40 cores in the build.

Re: [External] [PATCH v13 3/8] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-06-13 Thread Peter Xu
On Mon, Jun 13, 2022 at 05:58:44PM -0300, Leonardo Bras Soares Passos wrote: > Hello Peter, > > On Wed, Jun 8, 2022 at 5:23 PM Peter Xu wrote: > [...] > > > In a previous iteration of the patchset, it was made clear that it's > > > desirable to detect when the kernel falls back to copying

Re: [PATCH v1 5/7] tests/tcg: disable xtensa-linux-user again

2022-06-13 Thread Philippe Mathieu-Daudé via
On 13/6/22 19:12, Alex Bennée wrote: From: Paolo Bonzini The move from tests/tcg/configure.sh started enabling the container image for xtensa-linux-user, which fails because the compiler does not have the full set of headers. The cause is the "xtensa*-softmmu)" case in tests/tcg/configure.sh

Re: [PATCH 09/11] bsd-user: Implement dup and dup2

2022-06-13 Thread Warner Losh
On Mon, Jun 13, 2022 at 1:53 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 6/12/22 13:48, Warner Losh wrote: > > Signed-off-by: Stacey Son > > Signed-off-by: Warner Losh > > --- > > bsd-user/bsd-file.h | 14 ++ > > bsd-user/freebsd/os-syscall.c | 8

Re: [PATCH v1 7/7] .gitlab: use less aggressive nproc on our aarch64/32 runners

2022-06-13 Thread Richard Henderson
On 6/13/22 10:12, Alex Bennée wrote: Running on all 80 cores of our aarch64 runner does occasionally trigger a race condition which fails the build. However the CI system is not the time and place to play with much heisenbugs so turn down the nproc to "only" use 40 cores in the build.

Re: [PATCH v1 5/7] tests/tcg: disable xtensa-linux-user again

2022-06-13 Thread Richard Henderson
On 6/13/22 10:12, Alex Bennée wrote: From: Paolo Bonzini The move from tests/tcg/configure.sh started enabling the container image for xtensa-linux-user, which fails because the compiler does not have the full set of headers. The cause is the "xtensa*-softmmu)" case in tests/tcg/configure.sh

Re: [PATCH v1 4/7] tests/docker: fix the IMAGE for build invocation

2022-06-13 Thread Richard Henderson
On 6/13/22 10:12, Alex Bennée wrote: We inadvertently broke the ability to run local builds when the code was re-factored. The result was the run stanza failing to find the docker image with it's qemu/ prefix. Signed-off-by: Alex Bennée Fixes: d39eaa2266 ("tests/docker: simplify

Re: [PATCH v1 3/7] gitlab-ci: Fix the build-cfi-aarch64 and build-cfi-ppc64-s390x jobs

2022-06-13 Thread Richard Henderson
On 6/13/22 10:12, Alex Bennée wrote: From: Thomas Huth The job definitions recently got a second "variables:" section by accident and thus are failing now if one tries to run them. Merge the two sections into one again to fix the issue. And while we're at it, bump the timeout here (70 minutes

Re: [PATCH v2 1/2] QIOChannelSocket: Reduce ifdefs to improve readability

2022-06-13 Thread Leonardo Bras Soares Passos
On Fri, Jun 10, 2022 at 5:25 AM Daniel P. Berrangé wrote: > [...] > Ok, so if it is checked earlier then we merely need an assert. > > if (flags & QIO_CHANNEL_WRITE_FLAG_ZERO_COPY) { > #ifdef QEMU_MSG_ZEROCOPY > sflags = MSG_ZEROCOPY; > zero_copy_enabled = true; > #else

Re: [PATCH 1/2] hw/nvme: Implement shadow doorbell buffer support

2022-06-13 Thread Keith Busch
On Sun, Jun 12, 2022 at 07:40:55PM +0800, Jinhao Fan wrote: > > > On Jun 10, 2022, at 1:27 AM, Klaus Jensen wrote: > > > > I'm ok with following the concensus here, but we all agree that this is > > a blatant spec violation that ended up manifesting itself down the > > stack, right? > > > >

Re: [External] [PATCH v13 3/8] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-06-13 Thread Leonardo Bras Soares Passos
Hello Peter, On Wed, Jun 8, 2022 at 5:23 PM Peter Xu wrote: [...] > > In a previous iteration of the patchset, it was made clear that it's > > desirable to detect when the kernel falls back to copying mechanism, > > so the user of 'QIOChannelSocket' can switch to copying and avoid the > >

[PATCH v12 05/14] vfio-user: define vfio-user-server object

2022-06-13 Thread Jagannathan Raman
Define vfio-user object which is remote process server for QEMU. Setup object initialization functions and properties necessary to instantiate the object Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi ---

[PATCH v12 07/14] vfio-user: find and init PCI device

2022-06-13 Thread Jagannathan Raman
Find the PCI device with specified id. Initialize the device context with the QEMU PCI device Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi --- hw/remote/vfio-user-obj.c | 67 +++

[PATCH v12 14/14] vfio-user: handle reset of remote device

2022-06-13 Thread Jagannathan Raman
Adds handler to reset a remote device Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi --- hw/remote/vfio-user-obj.c | 20 1 file changed, 20 insertions(+) diff --git a/hw/remote/vfio-user-obj.c

[PATCH v12 09/14] vfio-user: handle PCI config space accesses

2022-06-13 Thread Jagannathan Raman
Define and register handlers for PCI config space accesses Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi --- hw/remote/vfio-user-obj.c | 51 +++ hw/remote/trace-events| 2 ++

[PATCH v12 12/14] vfio-user: handle PCI BAR accesses

2022-06-13 Thread Jagannathan Raman
Determine the BARs used by the PCI device and register handlers to manage the access to the same. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi --- include/exec/memory.h | 3 + hw/remote/vfio-user-obj.c

[PATCH v12 11/14] vfio-user: handle DMA mappings

2022-06-13 Thread Jagannathan Raman
Define and register callbacks to manage the RAM regions used for device DMA Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi --- hw/remote/machine.c | 5 hw/remote/vfio-user-obj.c | 55

[PATCH v12 10/14] vfio-user: IOMMU support for remote device

2022-06-13 Thread Jagannathan Raman
Assign separate address space for each device in the remote processes. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi --- include/hw/remote/iommu.h | 40 hw/remote/iommu.c | 131

[PATCH v12 13/14] vfio-user: handle device interrupts

2022-06-13 Thread Jagannathan Raman
Forward remote device's interrupts to the guest Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- include/hw/pci/msi.h | 1 + include/hw/pci/msix.h | 1 + include/hw/pci/pci.h | 13 +++

[PATCH v12 08/14] vfio-user: run vfio-user context

2022-06-13 Thread Jagannathan Raman
Setup a handler to run vfio-user context. The context is driven by messages to the file descriptor associated with it - get the fd for the context and hook up the handler with it Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan

[PATCH v12 04/14] vfio-user: build library

2022-06-13 Thread Jagannathan Raman
add the libvfio-user library as a submodule. build it as a meson subproject. libvfio-user is distributed with BSD 3-Clause license and json-c with MIT (Expat) license Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi

[PATCH v12 06/14] vfio-user: instantiate vfio-user context

2022-06-13 Thread Jagannathan Raman
create a context with the vfio-user library to run a PCI device Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi --- hw/remote/vfio-user-obj.c | 82 +++ 1 file changed, 82

[PATCH v12 03/14] remote/machine: add vfio-user property

2022-06-13 Thread Jagannathan Raman
Add vfio-user to x-remote machine. It is a boolean, which indicates if the machine supports vfio-user protocol. The machine configures the bus differently vfio-user and multiprocess protocols, so this property informs it on how to configure the bus. This property should be short lived. Once

[PATCH v12 02/14] remote/machine: add HotplugHandler for remote machine

2022-06-13 Thread Jagannathan Raman
Allow hotplugging of PCI(e) devices to remote machine Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi --- hw/remote/machine.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/remote/machine.c

[PATCH v12 01/14] qdev: unplug blocker for devices

2022-06-13 Thread Jagannathan Raman
Add blocker to prevent hot-unplug of devices TYPE_VFIO_USER_SERVER, which is introduced shortly, attaches itself to a PCIDevice on which it depends. If the attached PCIDevice gets removed while the server in use, it could cause it crash. To prevent this, TYPE_VFIO_USER_SERVER adds an unplug

[PATCH v12 00/14] vfio-user server in QEMU

2022-06-13 Thread Jagannathan Raman
This is v12 of the server side changes to enable vfio-user in QEMU. Thanks so much for reviewing this series and sharing your feedback. We made the following changes in this series: [PATCH v12 13/14] vfio-user: handle device interrupts - Renamed msi_set_irq_state() and msix_set_irq_state() as

Re: [PATCH 09/11] bsd-user: Implement dup and dup2

2022-06-13 Thread Richard Henderson
On 6/12/22 13:48, Warner Losh wrote: Signed-off-by: Stacey Son Signed-off-by: Warner Losh --- bsd-user/bsd-file.h | 14 ++ bsd-user/freebsd/os-syscall.c | 8 2 files changed, 22 insertions(+) diff --git a/bsd-user/bsd-file.h b/bsd-user/bsd-file.h index

Re: [PATCH 06/11] bsd-user: Implement link, linkat, unlink and unlinkat

2022-06-13 Thread Richard Henderson
On 6/12/22 13:48, Warner Losh wrote: Signed-off-by: Stacey Son Signed-off-by: Jung-uk Kim Signed-off-by: Warner Losh --- bsd-user/bsd-file.h | 54 +++ bsd-user/freebsd/os-syscall.c | 16 +++ 2 files changed, 70 insertions(+) Reviewed-by:

Re: [PATCH 11/11] bsd-user: Implement acct and sync

2022-06-13 Thread Richard Henderson
On 6/12/22 13:48, Warner Losh wrote: +static abi_long do_bsd_sync(void) +{ + Extra line, otherwise, Reviewed-by: Richard Henderson r~

Re: [PATCH 05/11] bsd-user: Implement rename and renameat

2022-06-13 Thread Richard Henderson
On 6/12/22 13:48, Warner Losh wrote: Plus the helper LOCK_PATH2 and UNLOCK_PATH2 macros. Signed-off-by: Stacey Son Signed-off-by: Jung-uk Kim Signed-off-by: Warner Losh --- bsd-user/bsd-file.h | 45 +++ bsd-user/freebsd/os-syscall.c | 8 +++ 2

Re: [PATCH 10/11] bsd-user: Implement trunctate and ftruncate

2022-06-13 Thread Richard Henderson
On 6/12/22 13:48, Warner Losh wrote: +static abi_long do_bsd_ftruncate(void *cpu_env, abi_long arg1, +abi_long arg2, abi_long arg3, abi_long arg4) +{ + Extra line. Otherwise, Reviewed-by: Richard Henderson r~

Re: [PATCH 08/11] bsd-user: Implement rmdir and undocumented -_getcwd

2022-06-13 Thread Richard Henderson
On 6/12/22 13:48, Warner Losh wrote: Implemenet rmdir and __getcwd. Declare __getcwd as extern because there's no installed FreeBSD header that has it. It's used internally by libc, which doesn't provide an external declaration, but does export the symbol. Typo in subject: s/-/_/. @@ -55,6

Re: [PATCH 03/11] bsd-user: Implement revoke, access, eaccess and faccessat

2022-06-13 Thread Richard Henderson
On 6/12/22 13:48, Warner Losh wrote: Signed-off-by: Stacey Son Signed-off-by: Warner Losh --- bsd-user/bsd-file.h | 53 +++ bsd-user/freebsd/os-syscall.c | 16 +++ 2 files changed, 69 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH 07/11] bsd-user: Implement mkdir and mkdirat

2022-06-13 Thread Richard Henderson
On 6/12/22 13:48, Warner Losh wrote: Signed-off-by: Stacey Son Signed-off-by: Warner Losh --- bsd-user/bsd-file.h | 27 +++ bsd-user/freebsd/os-syscall.c | 8 2 files changed, 35 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH 04/11] bsd-user: Implement chdir and fchdir

2022-06-13 Thread Richard Henderson
On 6/12/22 13:48, Warner Losh wrote: Signed-off-by: Stacey Son Signed-off-by: Warner Losh --- bsd-user/bsd-file.h | 20 bsd-user/freebsd/os-syscall.c | 8 2 files changed, 28 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH 02/11] bsd-user: Implement fdatasync, fsync and close_from

2022-06-13 Thread Richard Henderson
On 6/12/22 13:48, Warner Losh wrote: Implement fdatasync(2), fsync(2) and close_from(2). Signed-off-by: Stacey Son Signed-off-by: Jung-uk Kim Signed-off-by: Warner Losh --- bsd-user/bsd-file.h | 22 ++ bsd-user/freebsd/os-syscall.c | 12 2 files

Re: [PATCH 01/11] bsd-user: Implement open, openat and close

2022-06-13 Thread Richard Henderson
On 6/12/22 13:48, Warner Losh wrote: +static inline abi_long do_bsd_close(abi_long arg1) +{ + Watch the extra linefeed. Otherwise, Reviewed-by: Richard Henderson r~

Re: CentOS 8 cloud images not working under VM tests

2022-06-13 Thread John Snow
On Mon, Jun 13, 2022 at 12:36 PM John Snow wrote: > > On Mon, Jun 13, 2022 at 2:05 AM Thomas Huth wrote: > > > > On 11/06/2022 01.28, John Snow wrote: > > > This test doesn't appear to work for me: > > > > > > def build_image(self, img): > > > cimg = > > >

[PATCH v1 5/7] tests/tcg: disable xtensa-linux-user again

2022-06-13 Thread Alex Bennée
From: Paolo Bonzini The move from tests/tcg/configure.sh started enabling the container image for xtensa-linux-user, which fails because the compiler does not have the full set of headers. The cause is the "xtensa*-softmmu)" case in tests/tcg/configure.sh which became just "xtensa*)" in the new

[PATCH v1 7/7] .gitlab: use less aggressive nproc on our aarch64/32 runners

2022-06-13 Thread Alex Bennée
Running on all 80 cores of our aarch64 runner does occasionally trigger a race condition which fails the build. However the CI system is not the time and place to play with much heisenbugs so turn down the nproc to "only" use 40 cores in the build. Signed-off-by: Alex Bennée ---

[PATCH v1 6/7] gitlab: compare CIRRUS_nn vars against 'null' not ""

2022-06-13 Thread Alex Bennée
From: Daniel P. Berrangé The GitLab variable comparisons don't have shell like semantics where an unset variable compares equal to empty string. We need to explicitly test against 'null' to detect an unset variable. Signed-off-by: Daniel P. Berrangé Tested-by: Richard Henderson Reviewed-by:

[PATCH v1 4/7] tests/docker: fix the IMAGE for build invocation

2022-06-13 Thread Alex Bennée
We inadvertently broke the ability to run local builds when the code was re-factored. The result was the run stanza failing to find the docker image with it's qemu/ prefix. Signed-off-by: Alex Bennée Fixes: d39eaa2266 ("tests/docker: simplify docker-TEST@IMAGE targets") ---

[PATCH v1 3/7] gitlab-ci: Fix the build-cfi-aarch64 and build-cfi-ppc64-s390x jobs

2022-06-13 Thread Alex Bennée
From: Thomas Huth The job definitions recently got a second "variables:" section by accident and thus are failing now if one tries to run them. Merge the two sections into one again to fix the issue. And while we're at it, bump the timeout here (70 minutes are currently not enough for the

[PATCH v1 0/7] testing/next pre-PR (docker, gitlab, tcg)

2022-06-13 Thread Alex Bennée
Hi, Another day, another testing/next series. Mostly this contains a few hot fixes for docker breakages and other stuff that I picked off the list. There is a late breaking patch to try and make the aarch64 CI is little less twitchy. We are still seeing hanging tests on the s390x box but so far

[PATCH v1 2/7] tests/tcg/i386: Use explicit suffix on fist insns

2022-06-13 Thread Alex Bennée
From: Richard Henderson Fixes a number of assembler warnings of the form: test-i386.c: Assembler messages: test-i386.c:869: Warning: no instruction mnemonic suffix given and no register operands; using default for `fist' Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé

[PATCH v1 1/7] test/tcg/arm: Use -mfloat-abi=soft for test-armv6m-undef

2022-06-13 Thread Alex Bennée
From: Richard Henderson GCC11 from crossbuild-essential-armhf from ubuntu 22.04 errors: cc1: error: ‘-mfloat-abi=hard’: selected architecture lacks an FPU Signed-off-by: Richard Henderson Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-Id:

Re: [PULL 00/18] Block layer patches

2022-06-13 Thread Kevin Wolf
Am 09.06.2022 um 22:18 hat Richard Henderson geschrieben: > On 6/9/22 10:21, Kevin Wolf wrote: > > The following changes since commit 028f2361d0c2d28d6f918fe618f389228ac22b60: > > > >Merge tag 'pull-target-arm-20220609' of > > https://git.linaro.org/people/pmaydell/qemu-arm into staging

Re: [RFC PATCH] tcg/ppc: implement rem[u]_i{32,64} with mod[su][wd]

2022-06-13 Thread Richard Henderson
On 6/13/22 07:43, Matheus Kowalczuk Ferst wrote: Power ISA v3.0 introduced mod[su][wd] insns that can be used to implement rem[u]_i{32,64}. Signed-off-by: Matheus Ferst --- tcg/ppc/tcg-target.c.inc | 22 ++ tcg/ppc/tcg-target.h | 4 ++-- 2 files changed, 24

  1   2   3   >