Re: [PATCH] target/riscv: Update tval for hardware watchpoint

On 6/14/22 21:08, Bin Meng wrote: From: Bin Meng When watchpoint is hit, the breakpoint exception should update tval to point to the faulting virtual address. Signed-off-by: Bin Meng --- target/riscv/cpu.h| 1 + target/riscv/cpu_helper.c | 6 ++ target/riscv/debug.c | 2

Re: [PATCH] tests/vm: allow running tests in an unconfigured source tree

On Tue, Jun 14, 2022 at 12:51 PM Paolo Bonzini wrote: > > tests/vm/Makefile.include used to assume that it could run in an unconfigured > source tree, and Cirrus CI relies on that. It was however broken by commit > f4c66f1705 ("tests: use tests/venv to run basevm.py-based scripts", > 2022-06-06)

Re: [PATCH 2/5] tests/qemu-iotests: skip 108 when FUSE is not loaded

On Wed, Jun 15, 2022 at 09:41:32AM -0400, John Snow wrote: > On Tue, Jun 14, 2022 at 10:30 AM John Snow wrote: > > > > On Tue, Jun 14, 2022 at 4:59 AM Daniel P. Berrangé > > wrote: > > > > > > On Tue, Jun 14, 2022 at 06:46:35AM +0200, Thomas Huth wrote: > > > > On 14/06/2022 03.50, John Snow wro

Re: [PATCH v4 3/7] tests/9pfs: compare QIDs in fs_walk_none() test

On Tue, 15 Mar 2022 11:08:35 +0100 Christian Schoenebeck wrote: > Extend previously added fs_walk_none() test by comparing the QID > of the root fid with the QID of the cloned fid. They should be > equal. > > Signed-off-by: Christian Schoenebeck > --- LGTM. Reviewed-by: Greg Kurz > tests/q

[PATCH V8 15/39] qapi: QAPI_LIST_LENGTH

Signed-off-by: Steve Sistare --- include/qapi/util.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/qapi/util.h b/include/qapi/util.h index 7d88b09..75dddca 100644 --- a/include/qapi/util.h +++ b/include/qapi/util.h @@ -65,4 +65,17 @@ struct strList *strList_from_strin

Re: New "IndustryStandard" fw_cfg?

On 6/15/2022 8:46 AM, Xu, Min M wrote: I would like to add more engineers (Confidential Computing Reviewers in EDK2 community and Intel's QEMU engineers) in this mail thread. -Original Message- From: Dionna Amalie Glaze Sent: Wednesday, June 15, 2022 2:09 AM To: qemu-devel@nongnu.org

Re: [PATCH] MAINTAINERS: Add softmmu/runstate.c to "Main loop"

On 6/15/22 05:23, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4cf6174f9f..4c921c07db 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2745,6 +2745,7 @@ F: softmmu/cpu-throttle.c F

[PATCH V8 07/39] cpr: reboot HMP interfaces

cpr-save Call qmp_cpr_save(). Arguments: filename : save vmstate to filename mode: must be "reboot" cpr-load Call qmp_cpr_load(). Arguments: filename : load vmstate from filename mode: must be "reboot" Signed-off-by: Mark Kanda Signed-off-by: Steve Sistare --- hmp-c

[PATCH V8 16/39] qapi: strv_from_strList

Signed-off-by: Steve Sistare --- include/qapi/util.h | 6 ++ qapi/qapi-util.c| 14 ++ 2 files changed, 20 insertions(+) diff --git a/include/qapi/util.h b/include/qapi/util.h index 75dddca..51ff64e 100644 --- a/include/qapi/util.h +++ b/include/qapi/util.h @@ -33,6 +33,12 @@

Re: [PATCH v16 2/9] linux-user: Add LoongArch signal support

On 6/15/22 02:57, gaosong wrote: On 2022/6/15 上午12:15, Richard Henderson wrote: +static void *get_ctx(struct target_sctx_info *info) +{ +    return (void *)((char *)info + sizeof(struct target_sctx_info)); +} Return type should be struct target_sctx_info *. I wonder that if we return targe

[PATCH V8 05/39] vl: start on wakeup request

If qemu starts and loads a VM in the suspended state, then a later wakeup request will set the state to running, which is not sufficient to initialize the vm, as vm_start was never called during this invocation of qemu. See qemu_system_wakeup_request(). Define the start_on_wakeup_requested() hook

[PATCH V8 38/39] python/machine: add QEMUMachine accessors

Provide full_args() to return all command-line arguments used to start a vm, some of which are not otherwise visible to QEMUMachine clients. This is needed by the cpr test, which must start a vm, then pass all qemu command-line arguments to the cpr-exec monitor call. Provide reopen_qmp_connection

[PATCH V8 35/39] chardev: cpr for pty

Save and restore pty descriptors across cpr-save and cpr-load. Signed-off-by: Steve Sistare --- chardev/char-pty.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/chardev/char-pty.c b/chardev/char-pty.c index 53f25c6..ff5b00a 100644 --- a/chardev/char-pty.c +

[PATCH V8 37/39] cpr: only-cpr-capable option

Add the only-cpr-capable option, which causes qemu to exit with an error if any devices that are not capable of cpr are added. This guarantees that cpr-save will not fail due to a blocker. Signed-off-by: Steve Sistare --- include/migration/cpr.h | 2 +- migration/cpr.c | 13 +++

[PATCH V8 01/39] migration: fix populate_vfio_info

Include CONFIG_DEVICES so that populate_vfio_info is instantiated for CONFIG_VFIO. Signed-off-by: Steve Sistare --- migration/target.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/target.c b/migration/target.c index 907ebf0..a0991bc 100644 --- a/migration/target.c +++ b/migratio

[PATCH V8 39/39] tests/avocado: add cpr regression test

Signed-off-by: Steve Sistare --- MAINTAINERS | 1 + tests/avocado/cpr.py | 152 +++ 2 files changed, 153 insertions(+) create mode 100644 tests/avocado/cpr.py diff --git a/MAINTAINERS b/MAINTAINERS index 864aec6..4e6e7ab 100644 --- a/MA

[PATCH V8 28/39] vfio-pci: cpr part 2 (msi)

Finish cpr for vfio-pci MSI/MSI-X devices by preserving eventfd's and vector state. Signed-off-by: Steve Sistare --- hw/vfio/pci.c | 122 +- 1 file changed, 121 insertions(+), 1 deletion(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index

[PATCH V8 34/39] chardev: cpr for simple devices

Set QEMU_CHAR_FEATURE_CPR for devices that trivially support cpr. char-stdio is slightly less trivial. Allow the gdb server by closing it on exec. Signed-off-by: Steve Sistare --- chardev/char-mux.c| 1 + chardev/char-null.c | 1 + chardev/char-serial.c | 1 + chardev/char-stdio.c | 1

[PATCH V8 26/39] vfio-pci: refactor for cpr

Refactor vector use into a helper vfio_vector_init. Add vfio_notifier_init and vfio_notifier_cleanup for named notifiers, and pass additional arguments to vfio_remove_kvm_msi_virq. All for use by cpr in a subsequent patch. No functional change. Signed-off-by: Steve Sistare --- hw/vfio/pci.c |

[PATCH V8 30/39] vfio-pci: recover from unmap-all-vaddr failure

If vfio_cpr_save fails to unmap all vaddr's, then recover by walking all flat sections to restore the vaddr for each. Do so by invoking the vfio listener callback, and passing a new "replay" flag that tells it to replay a mapping without re-allocating new userland data structures. Signed-off-by:

[PATCH V8 36/39] chardev: cpr for sockets

Save accepted socket fds before cpr-save, and look for them after cpr-load. Block cpr-exec if a socket enables the TLS or websocket option. Allow a monitor socket by closing it on exec. Signed-off-by: Mark Kanda Signed-off-by: Steve Sistare --- chardev/char-socket.c | 45 ++

[PATCH V8 24/39] pci: export export msix_is_pending

Export msix_is_pending for use by cpr. No functional change. Signed-off-by: Steve Sistare --- hw/pci/msix.c | 2 +- include/hw/pci/msix.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/pci/msix.c b/hw/pci/msix.c index ae9331c..e492ce0 100644 --- a/hw/pci/msix.c

[PATCH V8 33/39] chardev: cpr framework

Add QEMU_CHAR_FEATURE_CPR for devices that support cpr by preserving an open descriptor across exec. Add the chardev reopen-on-cpr option for devices that should be closed on cpr and reopened after exec. Enable cpr for a chardev if it has QEMU_CHAR_FEATURE_CPR and reopen-on-cpr is false. Allow c

[PATCH V8 27/39] vfio-pci: cpr part 1 (fd and dma)

Enable vfio-pci devices to be saved and restored across an exec restart of qemu. At vfio creation time, save the value of vfio container, group, and device descriptors in cpr state. In the container pre_save handler, suspend the use of virtual addresses in DMA mappings with VFIO_DMA_UNMAP_FLAG_VA

[PATCH V8 21/39] cpr: restart HMP interfaces

cpr-save mode may be "restart" cpr-exec Call qmp_cpr_exec(). Arguments: command : command line to execute, with space-separated arguments Signed-off-by: Steve Sistare --- hmp-commands.hx | 29 ++--- include/monitor/hmp.h | 1 + monitor/hmp-cmds.c|

[PATCH V8 23/39] hostmem-memfd: cpr for memory-backend-memfd

Preserve memory-backend-memfd memory objects during cpr. Signed-off-by: Steve Sistare --- backends/hostmem-memfd.c | 21 - hmp-commands.hx | 2 +- qapi/cpr.json| 2 +- 3 files changed, 14 insertions(+), 11 deletions(-) diff --git a/backends/hostmem-mem

[PATCH V8 20/39] cpr: restart mode

Provide the cpr-save restart mode, which preserves the guest VM across a restart of the qemu process. After cpr-save, the caller passes qemu command-line arguments to cpr-exec, which directly exec's the new qemu binary. The arguments must include -S so new qemu starts in a paused state. The calle

[PATCH V8 32/39] loader: suppress rom_reset during cpr

Reported-by: Zheng Chuan Signed-off-by: Steve Sistare --- hw/core/loader.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index 0548830..7b39c07 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -51,6 +51,7 @@ #include "hw/hw.h"

[PATCH V8 29/39] vfio-pci: cpr part 3 (intx)

Preserve vfio INTX state across cpr restart. Preserve VFIOINTx fields as follows: pin : Recover this from the vfio config in kernel space interrupt : Preserve its eventfd descriptor across exec. unmask : Ditto route.irq : This could perhaps be recovered in vfio_pci_post_load by calling

[PATCH V8 14/39] qapi: strList_from_string

Generalize strList_from_comma_list() to take any delimiter character, rename as strList_from_string(), and move it to qapi/util.c. No functional change. Signed-off-by: Steve Sistare --- include/qapi/util.h | 9 + monitor/hmp-cmds.c | 29 ++--- qapi/qapi-util.c

[PATCH V8 22/39] cpr: ram block blockers

Unlike reboot mode, restart mode cannot save volatile ram blocks in the vmstate file and recreate them later, because the physical memory for the blocks is pinned and registered for vfio. Add a restart-mode blocker for volatile ram blocks. Signed-off-by: Steve Sistare --- include/exec/memory.h

[PATCH V8 09/39] cpr: register blockers

Register the known cpr blockers. Signed-off-by: Steve Sistare --- accel/xen/xen-all.c| 3 +++ backends/hostmem-epc.c | 6 ++ migration/migration.c | 6 ++ replay/replay.c| 4 4 files changed, 19 insertions(+) diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c index

[PATCH V8 18/39] vl: helper to request re-exec

Add a qemu_system_exec_request() hook that causes the main loop to exit and re-exec qemu using the specified arguments. Signed-off-by: Steve Sistare --- include/sysemu/runstate.h | 1 + softmmu/runstate.c| 26 ++ 2 files changed, 27 insertions(+) diff --git a/in

[PATCH V8 31/39] vhost: reset vhost devices for cpr

A vhost device is implicitly preserved across re-exec because its fd is not closed, and the value of the fd is specified on the command line for the new qemu to find. However, new qemu issues an VHOST_RESET_OWNER ioctl, which fails because the device already has an owner. To fix, reset the owner

[PATCH V8 13/39] oslib: qemu_clear_cloexec

Define qemu_clear_cloexec, analogous to qemu_set_cloexec. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Steve Sistare --- include/qemu/osdep.h | 1 + util/oslib-posix.c | 9 + util/oslib-win32.c | 4 3 files changed, 14 insertions(+) diff --git a/include/qemu/osdep.h b/in

[PATCH V8 06/39] cpr: reboot mode

Provide the cpr-save and cpr-load functions for live update. These save and restore VM state, with minimal guest pause time, so that qemu may be updated to a new version in between. cpr-save stops the VM and saves vmstate to an ordinary file. It supports any type of guest image and block device,

[PATCH V8 11/39] cpr: save ram blocks

Add a vmstate handler to save volatile ram blocks in the state file. This is used to preserve secondary guest ram blocks (those that cannot be specified on the command line) such as video ram and roms for cpr reboot, as there is no option to allocate them in shared memory. For efficiency, the use

[PATCH V8 17/39] qapi: strList unit tests

Signed-off-by: Steve Sistare --- MAINTAINERS | 1 + tests/unit/meson.build| 1 + tests/unit/test-strlist.c | 81 +++ 3 files changed, 83 insertions(+) create mode 100644 tests/unit/test-strlist.c diff --git a/MAINTAINERS b/MAINTAIN

[PATCH V8 19/39] cpr: preserve extra state

cpr must save state that is needed after qemu is restarted, when devices are realized. Thus the extra state cannot be saved in the cpr-load vmstate file, as objects must already exist before that file can be loaded. Instead, define auxilliary state structures and vmstate descriptions, not associa

[PATCH V8 03/39] migration: simplify savevm

Use qemu_file_open to simplify a few functions in savevm.c. No functional change. Signed-off-by: Steve Sistare Reviewed-by: Dr. David Alan Gilbert --- migration/savevm.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/migration/savevm.c b/migration/save

[PATCH V8 25/39] cpr: notifiers

Add an interface to register notifiers for cpr transitions. It is used to support vfio cpr in a subsequent patch. Signed-off-by: Steve Sistare --- include/migration/cpr.h | 13 + migration/cpr.c | 25 + stubs/cpr.c | 10 ++ 3 files

[PATCH V8 10/39] cpr: cpr-enable option

Add the '-cpr-enable ' command-line option as a pre-requisite for using cpr-save and cpr-load for the mode. Multiple -cpr-enable options may be specified, one per mode. Requiring -cpr-enable allows qemu to initialize objects differently, if necessary, so that cpr-save is not blocked. Signed-off-

[PATCH V8 12/39] memory: flat section iterator

Add an iterator over the sections of a flattened address space. Signed-off-by: Steve Sistare Reviewed-by: Marc-André Lureau --- include/exec/memory.h | 31 +++ softmmu/memory.c | 20 2 files changed, 51 insertions(+) diff --git a/include/ex

Re: [PATCH 1/2] hw/nvme: Implement shadow doorbell buffer support

> On Jun 15, 2022, at 5:38 PM, Klaus Jensen wrote: > > I prefer we use the NVMe terminology to minimize misunderstandings, so > "host" means the driver and "device" means the qemu side of things > Thanks for helping me disambiguate this! Now that we have resolved all issues in v1, I’ve subm

[PATCH V8 08/39] cpr: blockers

Add an interface to register a blocker for cpr-save for one or more modes. Devices and options that do not support a cpr mode can register a blocker, and cpr-save will fail with a descriptive error message. Conversely, if such a device is deleted and un-registers its blocker, cpr will be allowed a

[PATCH V8 02/39] migration: qemu file wrappers

Add qemu_file_open and qemu_fd_open to create QEMUFile objects for unix files and file descriptors. Signed-off-by: Steve Sistare --- migration/qemu-file-channel.c | 36 migration/qemu-file-channel.h | 6 ++ 2 files changed, 42 insertions(+) diff --git a

[PATCH V8 00/39] Live Update

Provide the cpr-save, cpr-exec, and cpr-load commands for live update. These save and restore VM state, with minimal guest pause time, so that qemu may be updated to a new version in between. cpr-save stops the VM and saves vmstate to an ordinary file. It supports any type of guest image and bloc

[PATCH v2 2/2] hw/nvme: Add trace events for shadow doorbell buffer

When shadow doorbell buffer is enabled, doorbell registers are lazily updated. The actual queue head and tail pointers are stored in Shadow Doorbell buffers. Add trace events for updates on the Shadow Doorbell buffers and EventIdx buffers. Also add trace event for the Doorbell Buffer Config comman

[PATCH v2 1/2] hw/nvme: Implement shadow doorbell buffer support

Implement Doorbel Buffer Config command (Section 5.7 in NVMe Spec 1.3) and Shadow Doorbel buffer & EventIdx buffer handling logic (Section 7.13 in NVMe Spec 1.3). For queues created before the Doorbell Buffer Config command, the nvme_dbbuf_config function tries to associate each existing SQ and CQ

[PATCH v2 0/2] hw/nvme: Add shadow doorbell buffer support

This patch adds shadow doorbell buffer support in NVMe 1.3 to QEMU NVMe. The Doorbell Buffer Config admin command is implemented for the guest to enable shadow doobell buffer. When this feature is enabled, each SQ/CQ is associated with two buffers, i.e., Shadow Doorbell buffer and EventIdx buffer.

Re: [PATCH v16 3/9] linux-user: Add LoongArch elf support

On 6/15/22 02:44, gaosong wrote: Hi Richard. On 2022/6/15 上午12:21, Richard Henderson wrote: On 6/14/22 02:05, Song Gao wrote: +#define ELF_HWCAP get_elf_hwcap() + +static uint32_t get_elf_hwcap(void) +{ +    return 0; +} This should not be zero.  See cpu_probe_common in the kernel.  At minim

Re: [External] [PATCH v13 3/8] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

On 2022/6/14 下午10:14, Dr. David Alan Gilbert wrote: I don't think we can tell which one of them triggered the error; so the only thing I can suggest is that we document the need for optmem_max setting; I wonder how we get a better answer than 'a few 100KB'? I guess it's something like the number

Re: [PULL 00/10] Block jobs & NBD patches

On 6/15/22 02:47, Vladimir Sementsov-Ogievskiy wrote: Also, could/should I run all these test pipelines on gitlab by hand before sending a PULL request? Or can I rerun them on my qemu fork for debugging? The first thing I'd try is make vm-build- and make docker-test-full@. Either or both will

Re: [PATCH v6 0/8] KVM: mm: fd-based approach for supporting KVM guest private memory

On Wed, Jun 15, 2022, Chao Peng wrote: > On Tue, Jun 14, 2022 at 01:59:41PM -0700, Andy Lutomirski wrote: > > On Tue, Jun 14, 2022 at 12:09 PM Sean Christopherson > > wrote: > > > > > > On Tue, Jun 14, 2022, Andy Lutomirski wrote: > > > > This patch series is fairly close to implementing a rather

Re: regarding QEMU ACPI table generation and passing acpi tables/methods to guest OS

On Wed, 15 Jun 2022 18:23:28 +0530 ritul guru wrote: > Came across below link about QEMU to pass acpi tables to guest OS. > https://wiki.qemu.org/Features/ACPITableGeneration that link a bit outdated (project was completed but than later QEMU moved on to built-in library for composing ACPI table

Re: [PATCH 2/5] tests/qemu-iotests: skip 108 when FUSE is not loaded

On Tue, Jun 14, 2022 at 10:30 AM John Snow wrote: > > On Tue, Jun 14, 2022 at 4:59 AM Daniel P. Berrangé > wrote: > > > > On Tue, Jun 14, 2022 at 06:46:35AM +0200, Thomas Huth wrote: > > > On 14/06/2022 03.50, John Snow wrote: > > > > In certain container environments we may not have FUSE at all

Re: [PATCH 8/9] target/riscv: debug: Return 0 if previous value written to tselect >= number of triggers

On Fri, Jun 10, 2022 at 1:24 PM wrote: > > From: Frank Chang > > If the value written to tselect is greater than or equal to the number > of supported triggers, then the following reads of tselect would return > value 0. Where is this behavior documented? > > Signed-off-by: Frank Chang > --- >

regarding QEMU ACPI table generation and passing acpi tables/methods to guest OS

Came across below link about QEMU to pass acpi tables to guest OS. https://wiki.qemu.org/Features/ACPITableGeneration Can I get more docs with respect to acpi tables/devices passing to guest OS from hypervisor or dom0? Looking for an example how an asl file which gets added in the SSDT table can

Re: [PATCH 9/9] target/riscv: debug: Add initial support of type 6 trigger

On Fri, Jun 10, 2022 at 1:25 PM wrote: > > From: Frank Chang > > Type 6 trigger is similar to a type 2 trigger, but provides additional > functionality and should be used instead of type 2 in newer > implementations. > > Signed-off-by: Frank Chang > --- > target/riscv/debug.c | 174

Re: [PATCH 1/2] chardev: don't set O_NONBLOCK on SCM_RIGHTS file descriptors.

On Tue, Jun 14, 2022 at 02:18:42PM +0300, Andrey Ryabinin wrote: > This reverts commit 9b938c7262e4 ("chardev: clear O_NONBLOCK on SCM_RIGHTS > file descriptors"). > File descriptor passed to QEMU via 'getfd' QMP command always > changed to blocking mode. Instead of that, change blocking mode by Q

[PATCH v5 4/4] net: Use bundle mechanism

Signed-off-by: Akihiko Odaki --- include/net/net.h | 2 +- meson.build | 4 +++- net/tap.c | 6 +- qemu-options.hx | 4 ++-- 4 files changed, 11 insertions(+), 5 deletions(-) diff --git a/include/net/net.h b/include/net/net.h index 523136c7acb..4a5ed27a4b7 100644 --- a/includ

Re: [PATCH v4 1/4] cutils: Introduce bundle mechanism

On 2022/06/15 17:19, Paolo Bonzini wrote: On 6/14/22 23:07, Akihiko Odaki wrote: diff --git a/util/cutils.c b/util/cutils.c index a58bcfd80e7..fe3bbb1c4eb 100644 --- a/util/cutils.c +++ b/util/cutils.c @@ -1086,3 +1086,36 @@ char *get_relocated_path(const char *dir)   }   return g_string

[PATCH v5 3/4] ui/icons: Use bundle mechanism

Signed-off-by: Akihiko Odaki --- meson.build | 2 +- ui/cocoa.m | 29 - ui/gtk.c | 6 +- ui/icons/meson.build | 32 ui/sdl2.c| 18 +++--- 5 files changed, 57 insertions(+), 30

Re: [PATCH 0/2] Make local migration with TAP network device possible

On Tue, Jun 14, 2022 at 02:18:41PM +0300, Andrey Ryabinin wrote: > Hi > > These couple patches aims to make possible local migration (within one host) > on the same TAP device used by source and destination QEMU > > The scenario looks like this > 1. Create TAP devices and pass file descriptors

[PATCH v5 0/4] cutils: Introduce bundle mechanism

Developers often run QEMU without installing. The bundle mechanism allows to look up files which should be present in installation even in such a situation. It is a general mechanism and can find any files located relative to the installation tree. The build tree must have a new directory, qemu-bu

[PATCH v5 1/4] cutils: Introduce bundle mechanism

Developers often run QEMU without installing. The bundle mechanism allows to look up files which should be present in installation even in such a situation. It is a general mechanism and can find any files located relative to the installation tree. The build tree must have a new directory, qemu-bu

[PATCH v5 2/4] datadir: Use bundle mechanism

softmmu/datadir.c had its own implementation to find files in the build tree, but now bundle mechanism provides the unified implementation which works for datadir and the other files. Signed-off-by: Akihiko Odaki --- .travis.yml | 2 +- meson.build | 2 +- pc-bi

Re: [PATCH 7/9] target/riscv: debug: Check VU/VS modes for type 2 trigger

On Fri, Jun 10, 2022 at 1:25 PM wrote: > > From: Frank Chang > > Type 2 trigger cannot be fired in VU/VS modes. > > Signed-off-by: Frank Chang > --- > target/riscv/debug.c | 10 ++ > 1 file changed, 10 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH 6/9] target/riscv: debug: Create common trigger actions function

On Fri, Jun 10, 2022 at 1:21 PM wrote: > > From: Frank Chang > > Trigger actions are shared among all triggers. Extract to a common > function. > > Signed-off-by: Frank Chang > --- > target/riscv/debug.c | 55 ++-- > target/riscv/debug.h | 13 +++

Re: [PATCH 5/9] target/riscv: debug: Introduce tinfo CSR

On Fri, Jun 10, 2022 at 1:21 PM wrote: > > From: Frank Chang > > tinfo.info: > One bit for each possible type enumerated in tdata1. > If the bit is set, then that type is supported by the currently > selected trigger. > > Signed-off-by: Frank Chang > --- > target/riscv/cpu_bits.h | 1 + >

[PATCH] MAINTAINERS: Add softmmu/runstate.c to "Main loop"

Signed-off-by: Markus Armbruster --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4cf6174f9f..4c921c07db 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2745,6 +2745,7 @@ F: softmmu/cpu-throttle.c F: softmmu/cpu-timers.c F: softmmu/icount.c F:

Re: [PATCH 4/9] target/riscv: debug: Restrict the range of tselect value can be written

On Fri, Jun 10, 2022 at 1:14 PM wrote: > > From: Frank Chang > > The value of tselect CSR can be written should be limited within the > range of supported triggers number. > > Signed-off-by: Frank Chang > --- > target/riscv/debug.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-

Re: [PATCH 3/9] target/riscv: debug: Introduce tdata1, tdata2, and tdata3 CSRs

On Fri, Jun 10, 2022 at 1:15 PM wrote: > > From: Frank Chang > > Replace type2_trigger_t with the real tdata1, tdata2, and tdata3 CSRs, > which allows us to support more types of triggers in the future. > > Signed-off-by: Frank Chang > --- > target/riscv/cpu.h | 6 ++- > target/riscv/debu

Re: [PATCH 2/9] target/riscv: debug: Introduce build_tdata1() to build tdata1 register content

On Fri, Jun 10, 2022 at 1:14 PM wrote: > > From: Frank Chang > > Introduce build_tdata1() to build tdata1 register content, which can be > shared among all types of triggers. > > Signed-off-by: Frank Chang > --- > target/riscv/debug.c | 15 ++- > 1 file changed, 10 insertions(+), 5

Re: [PATCH v3 4/4] net: convert to use qemu_find_file to locate bridge helper

On Wed, Jun 15, 2022 at 01:42:58PM +0200, Paolo Bonzini wrote: > On 6/15/22 12:52, Daniel P. Berrangé wrote: > > +case QEMU_FILE_TYPE_HELPER: > > +rel_install_dir = ""; > > +rel_build_dir = ""; > > +default_install_dir = default_helper_dir; > > +break; > > + > >

Re: [PULL 20/33] configure: handle host compiler in probe_target_compiler

On 01/06/2022 15:05, Alex Bennée wrote: > From: Paolo Bonzini > > In preparation for handling more binaries than just cc, handle > the case of "probe_target_compiler $cpu" directly in the function, > setting the target_* variables based on the ones that are used to > build QEMU. The clang check

Re: [RFC PATCH v2 2/8] qapi: net: introduce a way to bypass qemu_opts_parse_noisily()

Laurent Vivier writes: > On 13/05/2022 13:21, Markus Armbruster wrote: >> Laurent Vivier writes: >> >>> As qemu_opts_parse_noisily() flattens the QAPI structures ("type" field >>> of Netdev structure can collides with "type" field of SocketAddress), >> >> To remember how this works, I have to

Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

On 15.06.22 13:17, Xiao Guangrong wrote: > On Wed, Jun 15, 2022 at 4:24 PM David Hildenbrand wrote: > Is that a temporary or a permanent thing? Do we know? >>> >>> No idea. But his last signed-off was three years ago. >> >> I sent a patch to Xiao, asking if he's still active in QEMU. If I do

Re: [RFC PATCH v2 3/8] qapi: net: add stream and dgram netdevs

Laurent Vivier writes: > On 13/05/2022 13:44, Markus Armbruster wrote: >> Laurent Vivier writes: >> >>> Copied from socket netdev file and modified to use SocketAddress >>> to be able to introduce new features like unix socket. >>> >>> "udp" and "mcast" are squashed into dgram netdev, multicast

Re: [PATCH 1/2] hw/nvme: Implement shadow doorbell buffer support

On Wed, Jun 15, 2022 at 07:22:22PM +0800, Jinhao Fan wrote: > >>> Isn't this racy against the driver? Compare > >>> https://github.com/spdk/spdk/blob/master/lib/nvmf/vfio_user.c#L1317 > >> > >> QEMU has full memory barriers on dma read/write, so I believe this is > >> safe? > > > > But don't you

Re: [PATCH v3 4/4] net: convert to use qemu_find_file to locate bridge helper

On 6/15/22 12:52, Daniel P. Berrangé wrote: +case QEMU_FILE_TYPE_HELPER: +rel_install_dir = ""; +rel_build_dir = ""; +default_install_dir = default_helper_dir; +break; + You're replacing ad hoc rules in Akihiko's meson.build with an ad hoc enum + the corr

Re: [PATCH v4 0/4] cutils: Introduce bundle mechanism

On Wed, Jun 15, 2022 at 01:02:08PM +0200, Paolo Bonzini wrote: > On 6/15/22 10:30, Daniel P. Berrangé wrote: > > I don't think this is an attractive approach to the problem, > > because it results in us adding a bunch of meson rules to > > simulate 'make install' within the build dir. This is undes

Re: [PATCH 1/2] hw/nvme: Implement shadow doorbell buffer support

> On Jun 15, 2022, at 6:11 PM, John Levon wrote: > > On Wed, Jun 15, 2022 at 11:33:02AM +0200, Klaus Jensen wrote: > >>> BTW I'm surprised that this patch has just this: >>> >>> +static void nvme_update_sq_eventidx(const NvmeSQueue *sq) >>> +{ >>> +pci_dma_write(&sq->ctrl->parent_obj, sq

Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

On Wed, Jun 15, 2022 at 4:24 PM David Hildenbrand wrote: > >> Is that a temporary or a permanent thing? Do we know? > > > > No idea. But his last signed-off was three years ago. > > I sent a patch to Xiao, asking if he's still active in QEMU. If I don't > get a reply this week, I'll move forward

Re: [PATCH v4 0/4] cutils: Introduce bundle mechanism

On 6/15/22 10:30, Daniel P. Berrangé wrote: I don't think this is an attractive approach to the problem, because it results in us adding a bunch of meson rules to simulate 'make install' within the build dir. This is undesirable clutter IMHO, and can be solved more simply by just modifying the qe

[PATCH v3 2/4] ui: move 'pc-bios/keymaps' to 'ui/keymaps'

The 'keymaps' directory contents is nothing to do with the firmware blobs. The 'pc-bios/keymaps' directory appears to have been used previously as a convenience for getting the files installed into a subdir of the firmware install dir, as well as to make it easier to launch QEMU directly from the b

[PATCH v3 4/4] net: convert to use qemu_find_file to locate bridge helper

The TAP device code currently uses get_relocate_path to find the bridge helper, however, this fails when run from the build dir. Adding support to qemu_find_file for helper binaries, allows it to work from both the (relocated) install tree and build dir. Signed-off-by: Daniel P. Berrangé --- inc

Re: [PATCH v4 0/4] cutils: Introduce bundle mechanism

On Wed, Jun 15, 2022 at 10:39:29AM +0200, Paolo Bonzini wrote: > On 6/14/22 23:07, Akihiko Odaki wrote: > > Developers often run QEMU without installing. The bundle mechanism > > allows to look up files which should be present in installation even in > > such a situation. > > > > It is a general m

[PATCH v3 3/4] ui: find icons using qemu_find_file

The SDL/GTK/Cocoa UIs currently fail to load icons when run from the build directory as get_resource returns a bogus path. To address this we first re-arrange the ui/icons sub-directory so that its layout reflects the contents that will be installed. Then we introduce QEMU_FILE_TYPE_ICON to qemu_

[PATCH v3 1/4] softmmu: rewrite handling of qemu_find_file

The qemu_find_file method has a couple of flaws in its current implementation: * The configure time 'qemu-firmware' search path is mistakenly also used to find keymaps * The configure time 'qemu-firmware' search path is mistakenly relocated even when running from build dir resulting in

[PATCH v3 0/4] softmmu: make qemu_find_file more flexible wrt build dir layout

The qemu_find_file method impl is rather crude with a variety of problems (detailed in commit message of first patch). This series addresses those problems, making qemu_find_file much more flexible and able to be trivially extended to find any type of file, both in a (optionally relocated) install

Re: [PATCH 1/2] hw/nvme: Implement shadow doorbell buffer support

On Wed, Jun 15, 2022 at 11:33:02AM +0200, Klaus Jensen wrote: > > BTW I'm surprised that this patch has just this: > > > > +static void nvme_update_sq_eventidx(const NvmeSQueue *sq) > > +{ > > +pci_dma_write(&sq->ctrl->parent_obj, sq->ei_addr, &sq->tail, > > + sizeof(sq->tail

Re: [RFC PATCH v8 00/21] Net Control VQ support with asid in vDPA SVQ

On Wed, Jun 15, 2022 at 5:04 AM Jason Wang wrote: > > On Tue, Jun 14, 2022 at 5:32 PM Eugenio Perez Martin > wrote: > > > > On Tue, Jun 14, 2022 at 10:20 AM Jason Wang wrote: > > > > > > On Tue, Jun 14, 2022 at 4:14 PM Eugenio Perez Martin > > > wrote: > > > > > > > > On Tue, Jun 14, 2022 at 10

Re: [PATCH v16 2/9] linux-user: Add LoongArch signal support

On 2022/6/15 上午12:15, Richard Henderson wrote: +static void *get_ctx(struct target_sctx_info *info) +{ +    return (void *)((char *)info + sizeof(struct target_sctx_info)); +} Return type should be struct target_sctx_info *. I wonder that if we return target_fpu_context * and rename get_ctx

Re: [PATCH v16 7/9] target/loongarch: Adjust functions and structure to support user-mode

On 2022/6/15 上午12:43, Richard Henderson wrote: On 6/14/22 02:05, Song Gao wrote: @@ -172,17 +173,20 @@ static void loongarch_cpu_do_interrupt(CPUState *cs)   update_badinstr = 0;   break;   case EXCCODE_ADEM: +    case EXCCODE_BCE:   case EXCCODE_SYS:   case EXCCOD

Re: [PULL 00/10] Block jobs & NBD patches

On 6/14/22 21:05, Richard Henderson wrote: On 6/14/22 03:29, Vladimir Sementsov-Ogievskiy wrote: The following changes since commit debd0753663bc89c86f5462a53268f2e3f680f60:    Merge tag 'pull-testing-next-140622-1' of https://github.com/stsquad/qemu into staging (2022-06-13 21:10:57 -0700) a

Re: [PATCH v16 3/9] linux-user: Add LoongArch elf support

Hi Richard. On 2022/6/15 上午12:21, Richard Henderson wrote: On 6/14/22 02:05, Song Gao wrote: +#define ELF_HWCAP get_elf_hwcap() + +static uint32_t get_elf_hwcap(void) +{ +    return 0; +} This should not be zero.  See cpu_probe_common in the kernel.  At minimum HWCAP_LOONGARCH_CRC32 and HWCA

Re: [PATCH] target/ppc: cpu_init: Clean up stop state on cpu reset

On 6/15/22 09:17, Frederic Barrat wrote: On 15/06/2022 07:23, Cédric Le Goater wrote: On 6/14/22 10:29, Frederic Barrat wrote: The 'resume_as_sreset' attribute of a cpu can be set when a thread is entering a stop state on ppc books. It causes the thread to be re-routed to vector 0x100 when wo

Re: [PATCH 1/2] hw/nvme: Implement shadow doorbell buffer support

On Jun 15 11:58, Jinhao Fan wrote: > > > On Jun 14, 2022, at 11:41 PM, Keith Busch wrote: > > > > It's a pretty nasty hack, and definitely not in compliance with the spec: > > the > > db_addr is supposed to be read-only from the device side, though I do think > > it's safe for this environment.

Re: [PATCH 1/2] hw/nvme: Implement shadow doorbell buffer support

On Jun 15 10:07, John Levon wrote: > On Wed, Jun 15, 2022 at 10:48:26AM +0200, Klaus Jensen wrote: > > > > By the way, I noticed that the patch never updates the cq's ei_addr > > > value. Is > > > that on purpose? > > > > Yeah, I also mentioned this previously[1] and I still think we need to > >

<    1   2   3   >