Re: [PATCH 0/9] Add Qualcomm BMC machines

2022-06-22 Thread Cédric Le Goater
On 6/23/22 07:25, Joel Stanley wrote: On Wed, 22 Jun 2022 at 17:29, Jae Hyun Yoo wrote: Hello, I'm sending a series to add Qualcomm BMC machines that are equipped with Aspeed AST2600 SoC. Also, this series adds MAX31785 fan controller device emulation. Please help to review. Thanks for the

Re: [PATCH 4/9] hw/arm/aspeed: add Qualcomm Firework machine and FRU device

2022-06-22 Thread Cédric Le Goater
On 6/22/22 19:28, Jae Hyun Yoo wrote: From: Graeme Gregory Add base for Qualcomm Firework machine and add its FRU device which is defined by DC-SCM to be fixed address 0x50. Signed-off-by: Graeme Gregory --- hw/arm/aspeed.c | 53 + 1 file cha

Re: [RFC PATCH] qemu-options: bring the kernel and image options together

2022-06-22 Thread Cédric Le Goater
On 6/22/22 16:50, Alex Bennée wrote: How to control the booting of QEMU is often a source of confusion for users. Bring the options that control this together in the manual pages and add some verbiage to describe when each option is appropriate. Signed-off-by: Alex Bennée Cc: Cédric Le Goater

Re: [PATCH] fuzz: only use generic-fuzz targets on oss-fuzz

2022-06-22 Thread Thomas Huth
On 22/06/2022 18.38, Darren Kenny wrote: On Wednesday, 2022-06-22 at 12:28:40 -04, Alexander Bulekov wrote: On 220622 1703, Darren Kenny wrote: Hi Alex, This looks good to me, so: Reviewed-by: Darren Kenny But, if it is at all possible to use Bash glob in a '[[ ... ]]' test such as: if

Re: [PATCH] hw/riscv: boot: Reduce FDT address alignment constraints

2022-06-22 Thread Atish Kumar Patra
On Wed, Jun 22, 2022 at 9:15 PM Alistair Francis wrote: > > On Wed, Jun 8, 2022 at 4:41 PM Bin Meng wrote: > > > > +Atish > > > > On Wed, Jun 8, 2022 at 2:20 PM Alistair Francis > > wrote: > > > > > > From: Alistair Francis > > > > > > We previously stored the device tree at a 16MB alignment fr

Re: [PATCH 6/9] hw/sensor: add Maxim MAX31785 device

2022-06-22 Thread Cédric Le Goater
On 6/23/22 07:17, Joel Stanley wrote: On Wed, 22 Jun 2022 at 17:29, Jae Hyun Yoo wrote: From: Maheswara Kurapati MAX31785 is a PMBus compliant 6-Channel fan controller. It supports 6 fan channels, 11 temperature sensors, and 6-Channel ADC to measure the remote voltages. Datasheet can be foun

Re: [PATCH 9/9] hw/arm/aspeed: firework: add I2C MUXes for VR channels

2022-06-22 Thread Joel Stanley
On Wed, 22 Jun 2022 at 17:29, Jae Hyun Yoo wrote: > > Add 2-level cascaded I2C MUXes for SOC VR channels into the Firework > machine. > > Signed-off-by: Jae Hyun Yoo > --- > hw/arm/aspeed.c | 30 +++--- > 1 file changed, 19 insertions(+), 11 deletions(-) > > diff --git a/

Re: [PATCH 3/9] hw/arm/aspeed: qcom-dc-scm-v1: add block backed FRU device

2022-06-22 Thread Joel Stanley
On Wed, 22 Jun 2022 at 17:29, Jae Hyun Yoo wrote: > > From: Graeme Gregory > > The FRU device uses the index 0 device on bus IF_NONE. > > -drive file=$FRU,format=raw,if=none > > file must match FRU size of 128k > > Signed-off-by: Graeme Gregory > --- > hw/arm/aspeed.c | 22 +

Re: [PATCH 0/9] Add Qualcomm BMC machines

2022-06-22 Thread Joel Stanley
On Wed, 22 Jun 2022 at 17:29, Jae Hyun Yoo wrote: > > Hello, > > I'm sending a series to add Qualcomm BMC machines that are equipped with > Aspeed AST2600 SoC. Also, this series adds MAX31785 fan controller device > emulation. Please help to review. Thanks for the MAX31785 model, that's handy to

Re: [PATCH 6/9] hw/sensor: add Maxim MAX31785 device

2022-06-22 Thread Joel Stanley
On Wed, 22 Jun 2022 at 17:29, Jae Hyun Yoo wrote: > > From: Maheswara Kurapati > > MAX31785 is a PMBus compliant 6-Channel fan controller. It supports 6 fan > channels, 11 temperature sensors, and 6-Channel ADC to measure the remote > voltages. Datasheet can be found here: > https://datasheets.ma

Re: [PATCH] hw/riscv: boot: Reduce FDT address alignment constraints

2022-06-22 Thread Alistair Francis
On Wed, Jun 8, 2022 at 4:41 PM Bin Meng wrote: > > +Atish > > On Wed, Jun 8, 2022 at 2:20 PM Alistair Francis > wrote: > > > > From: Alistair Francis > > > > We previously stored the device tree at a 16MB alignment from the end of > > memory (or 3GB). This means we need at least 16MB of memory t

[PATCH v3] virtio-iommu: Fix the partial copy of probe request

2022-06-22 Thread Zhenzhong Duan
The structure of probe request doesn't include the tail, this leads to a few field missed to be copied. Currently this isn't an issue as those missed field belong to reserved field, just in case reserved field will be used in the future. Changed 4th parameter of virtio_iommu_iov_to_req() to receiv

RE: [PATCH v2] virtio-iommu: Fix the partial copy of probe request

2022-06-22 Thread Duan, Zhenzhong
>-Original Message- >From: Jean-Philippe Brucker >Sent: Wednesday, June 22, 2022 9:58 PM >To: Eric Auger >Cc: Duan, Zhenzhong ; qemu- >de...@nongnu.org; m...@redhat.com >Subject: Re: [PATCH v2] virtio-iommu: Fix the partial copy of probe request > >On Wed, Jun 22, 2022 at 02:22:18PM +0

RE: AIX 7.2 guest, Windows 10 host, networking, qemu 6.0.50.

2022-06-22 Thread Paul Dembry
Hi Daniel, It works! Using your -netdev and -device and https://www.jazakallah.info/post/how-to-setup-network-for-ibm-aix-vm-access-in-qemu with the addition of "ip route add 192.168.122.99 gw 192.168.122.1" Linux host: ens160: flags=4163 mtu 1500 inet 192.0.2.186 netmask 255.255.255

Re: [PATCH v5 0/5] i386/pc: Fix creation of >= 1010G guests on AMD systems with IOMMU

2022-06-22 Thread Joao Martins
On 6/22/22 23:37, Alex Williamson wrote: > On Fri, 20 May 2022 11:45:27 +0100 > Joao Martins wrote: >> v4[5] -> v5: >> * Fixed the 32-bit build(s) (patch 1, Michael Tsirkin) >> * Fix wrong reference (patch 4) to TCG_PHYS_BITS in code comment and >> commit message; >> >> --- >> >> This series lets

Re: [PATCH v5 0/5] i386/pc: Fix creation of >= 1010G guests on AMD systems with IOMMU

2022-06-22 Thread Alex Williamson
On Fri, 20 May 2022 11:45:27 +0100 Joao Martins wrote: > v4[5] -> v5: > * Fixed the 32-bit build(s) (patch 1, Michael Tsirkin) > * Fix wrong reference (patch 4) to TCG_PHYS_BITS in code comment and > commit message; > > --- > > This series lets Qemu spawn i386 guests with >= 1010G with VFIO, >

Re: [PATCH 6/9] hw/sensor: add Maxim MAX31785 device

2022-06-22 Thread Jae Hyun Yoo
Hello Titus, On 6/22/2022 1:49 PM, Titus Rwantare wrote: On Wed, 22 Jun 2022 at 10:29, Jae Hyun Yoo wrote: From: Maheswara Kurapati MAX31785 is a PMBus compliant 6-Channel fan controller. It supports 6 fan channels, 11 temperature sensors, and 6-Channel ADC to measure the remote voltages. D

Re: [PATCH 5/9] hw/i2c: pmbus: Page #255 is valid page for read requests.

2022-06-22 Thread Jae Hyun Yoo
Hello Titus, On 6/22/2022 1:49 PM, Titus Rwantare wrote: On Wed, 22 Jun 2022 at 10:29, Jae Hyun Yoo wrote: From: Maheswara Kurapati Current implementation of the pmbus core driver treats the read request for page 255 as invalid request and sets the invalid command bit (bit 7) in the STATUS_

Re: [PATCH] softmmu/physmem: Fix input parameters for flatview_access_allowed()

2022-06-22 Thread Peter Xu
On Wed, Jun 22, 2022 at 09:28:39AM +0800, Zhenzhong Duan wrote: > The comment of flatview_access_allowed() suggests to pass address > within that memory region, this isn't ture in some call sites. > > This makes qemu log in flatview_access_allowed() confusing and > potential risk if the input para

Re: [PATCH] memory: Fix wrong end address dump

2022-06-22 Thread Peter Xu
On Wed, Jun 22, 2022 at 05:59:12PM +0800, Zhenzhong Duan wrote: > The end address of memory region section isn't correctly calculated > which leads to overflowed mtree dump: > > Dispatch > Physical sections > .. > #70 @2000..00011fff io [ROOT] > #71

[PATCH v8 14/15] tests: Add postcopy tls recovery migration test

2022-06-22 Thread Peter Xu
It's easy to build this upon the postcopy tls test. Rename the old postcopy recovery test to postcopy/recovery/plain. Signed-off-by: Peter Xu --- tests/qtest/migration-test.c | 38 +++- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git a/tests/qtest/mi

[PATCH v8 15/15] tests: Add postcopy preempt tests

2022-06-22 Thread Peter Xu
Four tests are added for preempt mode: - Postcopy plain - Postcopy recovery - Postcopy tls - Postcopy tls+recovery Signed-off-by: Peter Xu --- tests/qtest/migration-test.c | 58 1 file changed, 58 insertions(+) diff --git a/tests/qtest/migration-tes

[PATCH v8 13/15] tests: Add postcopy tls migration test

2022-06-22 Thread Peter Xu
We just added TLS tests for precopy but not postcopy. Add the corresponding test for vanilla postcopy. Rename the vanilla postcopy to "postcopy/plain" because all postcopy tests will only use unix sockets as channel. Signed-off-by: Peter Xu --- tests/qtest/migration-test.c | 61 +++

Re: [PATCH 6/9] hw/sensor: add Maxim MAX31785 device

2022-06-22 Thread Titus Rwantare
On Wed, 22 Jun 2022 at 10:29, Jae Hyun Yoo wrote: > > From: Maheswara Kurapati > > MAX31785 is a PMBus compliant 6-Channel fan controller. It supports 6 fan > channels, 11 temperature sensors, and 6-Channel ADC to measure the remote > voltages. Datasheet can be found here: > https://datasheets.ma

[PATCH v8 10/15] migration: Enable TLS for preempt channel

2022-06-22 Thread Peter Xu
This patch is based on the async preempt channel creation. It continues wiring up the new channel with TLS handshake to destionation when enabled. Note that only the src QEMU needs such operation; the dest QEMU does not need any change for TLS support due to the fact that all channels are establi

Re: [PATCH 5/9] hw/i2c: pmbus: Page #255 is valid page for read requests.

2022-06-22 Thread Titus Rwantare
On Wed, 22 Jun 2022 at 10:29, Jae Hyun Yoo wrote: > > From: Maheswara Kurapati > > Current implementation of the pmbus core driver treats the read request > for page 255 as invalid request and sets the invalid command bit (bit 7) in > the > STATUS_CML register. As per the PMBus specification it

[PATCH v8 11/15] migration: Respect postcopy request order in preemption mode

2022-06-22 Thread Peter Xu
With preemption mode on, when we see a postcopy request that was requesting for exactly the page that we have preempted before (so we've partially sent the page already via PRECOPY channel and it got preempted by another postcopy request), currently we drop the request so that after all the other p

[PATCH v8 06/15] migration: Create the postcopy preempt channel asynchronously

2022-06-22 Thread Peter Xu
This patch allows the postcopy preempt channel to be created asynchronously. The benefit is that when the connection is slow, we won't take the BQL (and potentially block all things like QMP) for a long time without releasing. A function postcopy_preempt_wait_channel() is introduced, allowing the

[PATCH v8 12/15] tests: Move MigrateCommon upper

2022-06-22 Thread Peter Xu
So that it can be used in postcopy tests too soon. Signed-off-by: Peter Xu --- tests/qtest/migration-test.c | 144 +-- 1 file changed, 72 insertions(+), 72 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index f59d31b2ef..977

[PATCH v8 08/15] migration: Add helpers to detect TLS capability

2022-06-22 Thread Peter Xu
Add migrate_channel_requires_tls() to detect whether the specific channel requires TLS, leveraging the recently introduced migrate_use_tls(). No functional change intended. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/channel.c | 9 ++--- migration/migration.

[PATCH v8 09/15] migration: Export tls-[creds|hostname|authz] params to cmdline too

2022-06-22 Thread Peter Xu
It's useful for specifying tls credentials all in the cmdline (along with the -object tls-creds-*), especially for debugging purpose. The trick here is we must remember to not free these fields again in the finalize() function of migration object, otherwise it'll cause double-free. The thing is w

[PATCH v8 04/15] migration: Postcopy preemption enablement

2022-06-22 Thread Peter Xu
This patch enables postcopy-preempt feature. It contains two major changes to the migration logic: (1) Postcopy requests are now sent via a different socket from precopy background migration stream, so as to be isolated from very high page request delays. (2) For huge page enabled hosts:

[PATCH v8 07/15] migration: Add property x-postcopy-preempt-break-huge

2022-06-22 Thread Peter Xu
Add a property field that can conditionally disable the "break sending huge page" behavior in postcopy preemption. By default it's enabled. It should only be used for debugging purposes, and we should never remove the "x-" prefix. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Manish Mishra

[PATCH v8 05/15] migration: Postcopy recover with preempt enabled

2022-06-22 Thread Peter Xu
To allow postcopy recovery, the ram fast load (preempt-only) dest QEMU thread needs similar handling on fault tolerance. When ram_load_postcopy() fails, instead of stopping the thread it halts with a semaphore, preparing to be kicked again when recovery is detected. A mutex is introduced to make

[PATCH v8 02/15] migration: Add postcopy-preempt capability

2022-06-22 Thread Peter Xu
Firstly, postcopy already preempts precopy due to the fact that we do unqueue_page() first before looking into dirty bits. However that's not enough, e.g., when there're host huge page enabled, when sending a precopy huge page, a postcopy request needs to wait until the whole huge page that is sen

[PATCH v8 03/15] migration: Postcopy preemption preparation on channel creation

2022-06-22 Thread Peter Xu
Create a new socket for postcopy to be prepared to send postcopy requested pages via this specific channel, so as to not get blocked by precopy pages. A new thread is also created on dest qemu to receive data from this new channel based on the ram_load_postcopy() routine. The ram_load_postcopy(PO

[PATCH v8 01/15] fixup! migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-22 Thread Peter Xu
This fixes a bug with the cleanup patch. Should be squashed into the patch in subject. Cc: Daniel P. Berrange Signed-off-by: Peter Xu --- migration/qemu-file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 3a380a6072..1e

[PATCH v8 00/15] migration: Postcopy Preemption

2022-06-22 Thread Peter Xu
This is v8 of postcopy preempt series. It can also be found here: https://github.com/xzpeter/qemu/tree/postcopy-preempt RFC: https://lore.kernel.org/qemu-devel/20220119080929.39485-1-pet...@redhat.com V1: https://lore.kernel.org/qemu-devel/20220216062809.57179-1-pet...@redhat.com V2: https:/

Re: [PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-22 Thread Peter Xu
On Wed, Jun 22, 2022 at 03:34:52PM -0400, Peter Xu wrote: > On Wed, Jun 22, 2022 at 07:39:06PM +0100, Dr. David Alan Gilbert (git) wrote: > > diff --git a/migration/qemu-file.c b/migration/qemu-file.c > > index 74f919de67..e206b05550 100644 > > --- a/migration/qemu-file.c > > +++ b/migration/qemu-f

Re: [PATCH v4 33/53] semihosting: Split out semihost_sys_isatty

2022-06-22 Thread Luc Michel
On 13:45 Tue 07 Jun , Richard Henderson wrote: > Split out the non-ARM specific portions of SYS_ISTTY to a > reusable function. This handles all GuestFD. > > Add a common_semi_istty_cb helper to translate the Posix > error return, 0+ENOTTY, to the Arm semihosting not-a-file > success result.

Re: [PATCH v4 32/53] semihosting: Split out semihost_sys_lseek

2022-06-22 Thread Luc Michel
On 13:45 Tue 07 Jun , Richard Henderson wrote: > Split out the non-ARM specific portions of SYS_SEEK to a > reusable function. This handles all GuestFD. Isolate the > curious ARM-specific return value processing to a new > callback, common_semi_seek_cb. > > Expand the internal type of the of

[PATCH] target/ppc: Change FPSCR_* to follow POWER ISA numbering convention

2022-06-22 Thread Víctor Colombo
FPSCR_* bit values in QEMU are in the 'inverted' order from what Power ISA defines (e.g. FPSCR.FI is bit 46 but is defined as 17 in cpu.h). Now that PPC_BIT_NR macro was introduced to fix this situation for the MSR bits, we can use it for the FPSCR bits too. Also, adjust the comments to make then

Re: [PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-22 Thread Peter Xu
On Wed, Jun 22, 2022 at 07:39:06PM +0100, Dr. David Alan Gilbert (git) wrote: > diff --git a/migration/qemu-file.c b/migration/qemu-file.c > index 74f919de67..e206b05550 100644 > --- a/migration/qemu-file.c > +++ b/migration/qemu-file.c > @@ -377,8 +377,22 @@ static ssize_t qemu_fill_buffer(QEMUFil

Re: [PATCH v4 31/53] semihosting: Bound length for semihost_sys_{read, write}

2022-06-22 Thread Luc Michel
On 13:45 Tue 07 Jun , Richard Henderson wrote: > Fixes a minor bug in which a 64-bit guest on a 32-bit host could > truncate the length. This would only ever cause a problem if > there were no bits set in the low 32, so that it truncates to 0. > > Signed-off-by: Richard Henderson Reviewed-b

Re: [PATCH v4 30/53] semihosting: Split out semihost_sys_write

2022-06-22 Thread Luc Michel
On 13:45 Tue 07 Jun , Richard Henderson wrote: > Split out the non-ARM specific portions of SYS_WRITE to a > reusable function. This handles all GuestFD. This removes > the last use of common_semi_syscall_len. > > Note that gdb_do_syscall %x reads target_ulong, not int. > > Signed-off-by: R

Re: [PATCH v4 29/53] semihosting: Split out semihost_sys_read

2022-06-22 Thread Luc Michel
On 13:45 Tue 07 Jun , Richard Henderson wrote: > Split out the non-ARM specific portions of SYS_READ to a > reusable function. This handles all GuestFD. Isolate the > curious ARM-specific return value processing to a new > callback, common_semi_rw_cb. > > Note that gdb_do_syscall %x reads ta

[PULL 27/33] cpus: Introduce cpu_list_generation_id

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Hyman Huang(黄勇) Introduce cpu_list_generation_id to track cpu list generation so that cpu hotplug/unplug can be detected during measurement of dirty page rate. cpu_list_generation_id could be used to detect changes of cpu list, which is prepared for dirty page rate measurement. Signed-off

[PULL 33/33] tests: Add dirty page rate limit test

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Hyman Huang(黄勇) Add dirty page rate limit test if kernel support dirty ring. The following qmp commands are covered by this test case: "calc-dirty-rate", "query-dirty-rate", "set-vcpu-dirty-limit", "cancel-vcpu-dirty-limit" and "query-vcpu-dirty-limit". Signed-off-by: Hyman Huang(黄勇) Ack

[PULL 32/33] softmmu/dirtylimit: Implement dirty page rate limit

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Hyman Huang(黄勇) Implement dirtyrate calculation periodically basing on dirty-ring and throttle virtual CPU until it reachs the quota dirty page rate given by user. Introduce qmp commands "set-vcpu-dirty-limit", "cancel-vcpu-dirty-limit", "query-vcpu-dirty-limit" to enable, disable, query d

Re: [PATCH v2 2/7] semihosting: add the semihosting_exit_request function

2022-06-22 Thread Peter Maydell
On Tue, 21 Jun 2022 at 13:59, Luc Michel wrote: > > Add the semihosting_exit_request function to be used by targets when > handling an `exit' semihosted syscall. This function calls gdb_exit to > close existing GDB connections, and qemu_system_shutdown_request with > the new `guest-semi-exit' exit

[PULL 21/33] migration: remove the QEMUFileOps 'close' callback

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé This directly implements the close logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- migration/qemu-file-channel.c | 1

Re: [PATCH v4 28/53] semihosting: Split out semihost_sys_close

2022-06-22 Thread Luc Michel
On 13:45 Tue 07 Jun , Richard Henderson wrote: > Split out the non-ARM specific portions of SYS_CLOSE to a > reusable function. This handles all GuestFD. > > Note that gdb_do_syscall %x reads target_ulong, not int. > > Signed-off-by: Richard Henderson Reviewed-by: Luc Michel > --- > inc

[PULL 31/33] softmmu/dirtylimit: Implement virtual CPU throttle

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Hyman Huang(黄勇) Setup a negative feedback system when vCPU thread handling KVM_EXIT_DIRTY_RING_FULL exit by introducing throttle_us_per_full field in struct CPUState. Sleep throttle_us_per_full microseconds to throttle vCPU if dirtylimit is in service. Signed-off-by: Hyman Huang(黄勇) Revie

[PULL 23/33] migration: remove the QEMUFileOps 'writev_buffer' callback

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé This directly implements the writev_buffer logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- migration/qemu-file-chann

[PULL 20/33] migration: remove the QEMUFileOps 'set_blocking' callback

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé This directly implements the set_blocking logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- migration/qemu-file-channe

[PULL 29/33] softmmu/dirtylimit: Implement vCPU dirtyrate calculation periodically

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Hyman Huang(黄勇) Introduce the third method GLOBAL_DIRTY_LIMIT of dirty tracking for calculate dirtyrate periodly for dirty page rate limit. Add dirtylimit.c to implement dirtyrate calculation periodly, which will be used for dirty page rate limit. Add dirtylimit.h to export util functions

[PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé This directly implements the get_buffer logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- migration/qemu-file-channel.

[PULL 24/33] migration: remove the QEMUFileOps 'get_return_path' callback

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé This directly implements the get_return_path logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- migration/qemu-file-cha

[PULL 30/33] accel/kvm/kvm-all: Introduce kvm_dirty_ring_size function

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Hyman Huang(黄勇) Introduce kvm_dirty_ring_size util function to help calculate dirty ring ful time. Signed-off-by: Hyman Huang(黄勇) Acked-by: Peter Xu Message-Id: Signed-off-by: Dr. David Alan Gilbert dgilbert: Fixed up excess #endif --- accel/kvm/kvm-all.c| 5 + accel/stubs/

[PULL 18/33] migration: remove unused QEMUFileGetFD typedef / qemu_get_fd method

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- migration/qemu-file.h | 5 - 1 file changed, 5 deletions(-) diff --git a/migration/qemu-file.

[PULL 25/33] migration: remove the QEMUFileOps abstraction

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé Now that all QEMUFile callbacks are removed, the entire concept can be deleted. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- migration/channel

[PULL 17/33] migration: introduce new constructors for QEMUFile

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé Prepare for the elimination of QEMUFileOps by introducing a pair of new constructors. This lets us distinguish between an input and output file object explicitly rather than via the existance of specific callbacks. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dani

[PULL 15/33] migration: stop passing 'opaque' parameter to QEMUFile hooks

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé The only user of the hooks is RDMA which provides a QIOChannel backed impl of QEMUFile. It can thus use the qemu_file_get_ioc() method. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signe

[PULL 19/33] migration: remove the QEMUFileOps 'shut_down' callback

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé This directly implements the shutdown logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- migration/qemu-file-channel.c

[PULL 09/33] migration: rename 'pos' field in QEMUFile to 'bytes_processed'

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé The field name 'pos' gives the misleading impression that the QEMUFile objects are seekable. This is not the case, as in general we just have an opaque stream. The users of this method are only interested in the total bytes processed. This switches to a new name that refl

[PULL 11/33] migration: rename qemu_update_position to qemu_file_credit_transfer

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé The qemu_update_position method name gives the misleading impression that it is changing the current file offset. Most of the files are just streams, however, so there's no concept of a file offset in the general case. What this method is actually used for is to report o

[PULL 28/33] migration/dirtyrate: Refactor dirty page rate calculation

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Hyman Huang(黄勇) abstract out dirty log change logic into function global_dirty_log_change. abstract out dirty page rate calculation logic via dirty-ring into function vcpu_calculate_dirtyrate. abstract out mathematical dirty page rate calculation into do_calculate_dirtyrate, decouple it f

[PULL 14/33] migration: convert savevm to use QIOChannelBlock for VMState

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé With this change, all QEMUFile usage is backed by QIOChannel at last. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert dgilbert: Wrap long lines ---

[PULL 16/33] migration: hardcode assumption that QEMUFile is backed with QIOChannel

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé The only callers of qemu_fopen_ops pass 'true' for the 'has_ioc' parameter, so hardcode this assumption in QEMUFile, by passing in the QIOChannel object as a non-opaque parameter. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Q

[PULL 07/33] migration: remove unreachble RDMA code in save_hook impl

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé The QEMUFile 'save_hook' callback has a 'size_t size' parameter. The RDMA impl of this has logic that takes different actions depending on whether the value is zero or non-zero. It has commented out logic that would have taken further actions if the value was negative.

[PULL 26/33] accel/kvm/kvm-all: Refactor per-vcpu dirty ring reaping

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Hyman Huang(黄勇) Add a non-required argument 'CPUState' to kvm_dirty_ring_reap so that it can cover single vcpu dirty-ring-reaping scenario. Signed-off-by: Hyman Huang(黄勇) Reviewed-by: Peter Xu Message-Id: Signed-off-by: Dr. David Alan Gilbert --- accel/kvm/kvm-all.c | 23

[PULL 06/33] migration: switch to use QIOChannelNull for dummy channel

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé This removes one further custom impl of QEMUFile, in favour of a QIOChannel based impl. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 7 +

[PULL 08/33] migration: rename rate limiting fields in QEMUFile

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé This renames the following QEMUFile fields * bytes_xfer -> rate_limit_used * xfer_limit -> rate_limit_max The intent is to make it clear that 'bytes_xfer' is specifically related to rate limiting of data and applies to data queued, which need not have been transferred

[PULL 05/33] io: add a QIOChannelNull equivalent to /dev/null

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé This is for code which needs a portable equivalent to a QIOChannelFile connected to /dev/null. Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- include/io/channel-null.h | 55

[PULL 12/33] migration: rename qemu_file_update_transfer to qemu_file_acct_rate_limit

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé The qemu_file_update_transfer name doesn't give a clear guide on what its purpose is, and how it differs from the qemu_file_credit_transfer method. The latter is specifically for accumulating for total migration traffic, while the former is specifically for accounting in

[PULL 00/33] migration queue

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit 2b049d2c8dc01de750410f8f1a4eac498c04c723: Merge tag 'pull-aspeed-20220622' of https://github.com/legoater/qemu into staging (2022-06-22 07:27:06 -0700) are available in the Git repository at: http

[PULL 04/33] migration: Change zero_copy_send from migration parameter to migration capability

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Leonardo Bras When originally implemented, zero_copy_send was designed as a Migration paramenter. But taking into account how is that supposed to work, and how the difference between a capability and a parameter, it only makes sense that zero-copy-send would work better as a capability. T

[PULL 10/33] migration: rename qemu_ftell to qemu_file_total_transferred

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé The name 'ftell' gives the misleading impression that the QEMUFile objects are seekable. This is not the case, as in general we just have an opaque stream. The users of this method are only interested in the total bytes processed. This switches to a new name that reflects

[PULL 13/33] migration: introduce a QIOChannel impl for BlockDriverState VMState

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé Introduce a QIOChannelBlock class that exposes the BlockDriverState VMState region for I/O. This is kept in the migration/ directory rather than io/, to avoid a mutual dependancy between block/ <-> io/ directories. Also the VMState should only be used by the migration co

[PULL 03/33] QIOChannelSocket: Fix zero-copy send so socket flush works

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Leonardo Bras Somewhere between v6 and v7 the of the zero-copy-send patchset a crucial part of the flushing mechanism got missing: incrementing zero_copy_queued. Without that, the flushing interface becomes a no-op, and there is no guarantee the buffer is really sent. This can go as bad a

[PULL 01/33] migration: Remove RDMA_UNREGISTRATION_EXAMPLE

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Juan Quintela Nobody has ever showed up to unregister individual pages, and another set of patches written by Daniel P. Berrangé just remove qemu_rdma_signal_unregister() function needed here. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-22 Thread Vladimir Sementsov-Ogievskiy
On 6/22/22 17:26, Emanuele Giuseppe Esposito wrote: Am 21/06/2022 um 19:26 schrieb Vladimir Sementsov-Ogievskiy: On 6/16/22 16:18, Emanuele Giuseppe Esposito wrote: With the*nop*  job_lock/unlock placed, rename the static functions that are always under job_mutex, adding "_locked" suffix. Li

[PULL 02/33] QIOChannelSocket: Introduce assert and reduce ifdefs to improve readability

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Leonardo Bras During implementation of MSG_ZEROCOPY feature, a lot of #ifdefs were introduced, particularly at qio_channel_socket_writev(). Rewrite some of those changes so it's easier to read. Also, introduce an assert to help detect incorrect zero-copy usage is when it's disabled on bui

Re: [PATCH v7 05/18] job.h: add _locked duplicates for job API functions called with and without job_mutex

2022-06-22 Thread Vladimir Sementsov-Ogievskiy
On 6/22/22 17:26, Emanuele Giuseppe Esposito wrote: Am 21/06/2022 um 17:03 schrieb Vladimir Sementsov-Ogievskiy: On 6/16/22 16:18, Emanuele Giuseppe Esposito wrote: In preparation to the job_lock/unlock usage, create _locked duplicates of some functions, since they will be sometimes called wi

[PATCH 3/9] hw/arm/aspeed: qcom-dc-scm-v1: add block backed FRU device

2022-06-22 Thread Jae Hyun Yoo
From: Graeme Gregory The FRU device uses the index 0 device on bus IF_NONE. -drive file=$FRU,format=raw,if=none file must match FRU size of 128k Signed-off-by: Graeme Gregory --- hw/arm/aspeed.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/hw/ar

[PATCH 6/9] hw/sensor: add Maxim MAX31785 device

2022-06-22 Thread Jae Hyun Yoo
From: Maheswara Kurapati MAX31785 is a PMBus compliant 6-Channel fan controller. It supports 6 fan channels, 11 temperature sensors, and 6-Channel ADC to measure the remote voltages. Datasheet can be found here: https://datasheets.maximintegrated.com/en/ds/MAX31785.pdf This initial version of th

[PATCH 8/9] hw/arm/aspeed: firework: Add Thermal Diodes

2022-06-22 Thread Jae Hyun Yoo
From: Maheswara Kurapati Add Thermal Diodes for Firework machine. Signed-off-by: Maheswara Kurapati --- hw/arm/aspeed.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 08e5fc178a94..526f3b651a9f 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/a

Re: [PATCH 2/2] build: try both native and cross compilers for linux-user tests

2022-06-22 Thread Matheus Kowalczuk Ferst
On 22/06/2022 10:47, Paolo Bonzini wrote: > Configure is trying to fall back on cross compilers for targets that > can have bi-arch or bi-endian toolchains, but there are many corner > cases where just checking the name can go wrong. For example, the RHEL > ppc64le compiler is bi-arch and bi-endia

[PATCH 0/9] Add Qualcomm BMC machines

2022-06-22 Thread Jae Hyun Yoo
Hello, I'm sending a series to add Qualcomm BMC machines that are equipped with Aspeed AST2600 SoC. Also, this series adds MAX31785 fan controller device emulation. Please help to review. Thanks, Jae Graeme Gregory (2): hw/arm/aspeed: qcom-dc-scm-v1: add block backed FRU device hw/arm/aspee

[PATCH 9/9] hw/arm/aspeed: firework: add I2C MUXes for VR channels

2022-06-22 Thread Jae Hyun Yoo
Add 2-level cascaded I2C MUXes for SOC VR channels into the Firework machine. Signed-off-by: Jae Hyun Yoo --- hw/arm/aspeed.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 526f3b651a9f..866a60cf7b4e 10

[PATCH 7/9] hw/arm/aspeed: firework: Add MAX31785 Fan controllers

2022-06-22 Thread Jae Hyun Yoo
From: Maheswara Kurapati Firework has two MAX31785 Fan controllers at 0x52, and 0x54. Include them in the model so that the Linux driver populates the sysfs interface. Signed-off-by: Maheswara Kurapati --- hw/arm/aspeed.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/arm/aspeed.c

[PATCH 1/9] hw/arm/aspeed: add support for the Qualcomm EVB proto board

2022-06-22 Thread Jae Hyun Yoo
Add qcom-evb-proto board support. Signed-off-by: Jae Hyun Yoo --- hw/arm/aspeed.c | 24 1 file changed, 24 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 98dc185acd9a..4f54721e5f1f 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@ -1420,6 +1420,2

[PATCH 2/9] hw/arm/aspeed: add support for the Qualcomm DC-SCM v1 board

2022-06-22 Thread Jae Hyun Yoo
Add qcom-dc-scm-v1 board support. Signed-off-by: Jae Hyun Yoo --- hw/arm/aspeed.c | 41 + 1 file changed, 41 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 4f54721e5f1f..785cc543d046 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @

[PATCH 5/9] hw/i2c: pmbus: Page #255 is valid page for read requests.

2022-06-22 Thread Jae Hyun Yoo
From: Maheswara Kurapati Current implementation of the pmbus core driver treats the read request for page 255 as invalid request and sets the invalid command bit (bit 7) in the STATUS_CML register. As per the PMBus specification it is a valid request. Refer to the PMBus specification, revision 1

[PATCH 4/9] hw/arm/aspeed: add Qualcomm Firework machine and FRU device

2022-06-22 Thread Jae Hyun Yoo
From: Graeme Gregory Add base for Qualcomm Firework machine and add its FRU device which is defined by DC-SCM to be fixed address 0x50. Signed-off-by: Graeme Gregory --- hw/arm/aspeed.c | 53 + 1 file changed, 53 insertions(+) diff --git a/hw/ar

[RFC PATCH] target/ppc: Implement hashst(p) and hashchk(p) instructions

2022-06-22 Thread Víctor Colombo
Implementation for instructions hashst, hashchk, and its privileged versions. It was decided to implement the hash algorithm from ground up in this patch exactly as described in Power ISA. Signed-off-by: Víctor Colombo --- RFC because I need some feedback on if the approach of implementing the

Re: [PATCH] fuzz: only use generic-fuzz targets on oss-fuzz

2022-06-22 Thread Darren Kenny
On Wednesday, 2022-06-22 at 12:28:40 -04, Alexander Bulekov wrote: > On 220622 1703, Darren Kenny wrote: >> Hi Alex, >> >> This looks good to me, so: >> >> Reviewed-by: Darren Kenny >> >> But, if it is at all possible to use Bash glob in a '[[ ... ]]' test >> such as: >> >> if [[ $target ==

Re: [PATCH] fuzz: only use generic-fuzz targets on oss-fuzz

2022-06-22 Thread Alexander Bulekov
On 220622 1703, Darren Kenny wrote: > Hi Alex, > > This looks good to me, so: > > Reviewed-by: Darren Kenny > > But, if it is at all possible to use Bash glob in a '[[ ... ]]' test > such as: > > if [[ $target == generic-fuzz-* ]]; then > > that might read better - but it seems the default

Re: [PATCH v2 2/7] semihosting: add the semihosting_exit_request function

2022-06-22 Thread Eric Blake
On Tue, Jun 21, 2022 at 02:59:11PM +0200, Luc Michel wrote: > Add the semihosting_exit_request function to be used by targets when > handling an `exit' semihosted syscall. This function calls gdb_exit to > close existing GDB connections, and qemu_system_shutdown_request with > the new `guest-semi-e

Re: [RFC PATCH v3 04/11] qapi: net: add stream and dgram netdevs

2022-06-22 Thread Laurent Vivier
On 22/06/2022 13:47, Markus Armbruster wrote: Laurent Vivier writes: On 21/06/2022 10:49, Markus Armbruster wrote: Laurent Vivier writes: On 20/06/2022 17:21, Markus Armbruster wrote: Laurent Vivier writes: Copied from socket netdev file and modified to use SocketAddress to be able to

  1   2   3   >