>-Original Message-
>From: Li, Xiaoyao
>Sent: Friday, July 8, 2022 2:03 PM
>To: Duan, Zhenzhong ; qemu-
>de...@nongnu.org
>Cc: pbonz...@redhat.com; ehabk...@redhat.com; Ma, XiangfeiX
>
>Subject: Re: [PATCH] target/i386: Restore TSX features with taa-no
>
>On 7/8/2022 1:42 PM, Zhenzhong D
On 7/8/2022 1:42 PM, Zhenzhong Duan wrote:
In L1 kernel side, taa-no is cleared because RTM is disabled
which will lead to below warning when starting L2 qemu:
"warning: host doesn't support requested feature: MSR(10AH).taa-no [bit 8]"
If host isn't susceptible to TSX Async Abort (TAA) vulnerab
While in other call site "x-force-features" takes effect to keep
the CPU feature even though not supported for any reason.
This isn't consistent while expanding features, Fixed to keep user
explicitly enabled features if "x-force-features" is specified.
Fixes: 99e24dbdaa682 ("target/i386: introdu
In L1 kernel side, taa-no is cleared because RTM is disabled
which will lead to below warning when starting L2 qemu:
"warning: host doesn't support requested feature: MSR(10AH).taa-no [bit 8]"
If host isn't susceptible to TSX Async Abort (TAA) vulnerabilities,
exposing TSX to L2 may help performa
Avoid bounce buffers when QEMUIOVector elements are within previously
registered bdrv_register_buf() buffers.
The idea is that emulated storage controllers will register guest RAM
using bdrv_register_buf() and set the BDRV_REQ_REGISTERED_BUF on I/O
requests. Therefore no blkio_map_mem_region() cal
Register guest RAM using BlockRAMRegistrar and set the
BDRV_REQ_REGISTERED_BUF flag so block drivers can optimize memory
accesses in I/O requests.
This is for vdpa-blk, vhost-user-blk, and other I/O interfaces that rely
on DMA mapping/unmapping.
Signed-off-by: Stefan Hajnoczi
---
include/hw/vir
The blkio block driver will need to look up the file descriptor for a
given pointer. This is possible in softmmu builds where the memory API
is available for querying guest RAM.
Add stubs so tools like qemu-img that link the block layer still build
successfully. In this case there is no guest RAM
The only implementor of bdrv_register_buf() is block/nvme.c, where the
size is not needed when unregistering a buffer. This is because
util/vfio-helpers.c can look up mappings by address.
Future block drivers that implement bdrv_register_buf() may not be able
to do their job given only the buffer
Emulated devices and other BlockBackend users wishing to take advantage
of blk_register_buf() all have the same repetitive job: register
RAMBlocks with the BlockBackend using RAMBlockNotifier.
Add a BlockRAMRegistrar API to do this. A later commit will use this
from hw/block/virtio-blk.c.
Signed-
When a RAMBlockNotifier is added, ->ram_block_added() is called with all
existing RAMBlocks. There is no equivalent ->ram_block_removed() call
when a RAMBlockNotifier is removed.
The util/vfio-helpers.c code (the sole user of RAMBlockNotifier) is fine
with this asymmetry because it does not rely o
Block drivers may optimize I/O requests accessing buffers previously
registered with bdrv_register_buf(). Checking whether all elements of a
request's QEMUIOVector are within previously registered buffers is
expensive, so we need a hint from the user to avoid costly checks.
Add a BDRV_REQ_REGISTER
libblkio (https://gitlab.com/libblkio/libblkio/) is a library for
high-performance disk I/O. It currently supports io_uring and
virtio-blk-vhost-vdpa with additional drivers under development.
One of the reasons for developing libblkio is that other applications
besides QEMU can use it. This will
v3:
- Add virtio-blk-vhost-vdpa for vdpa-blk devices including VDUSE
- Add discard and write zeroes support
- Rebase and adopt latest libblkio APIs
v2:
- Add BDRV_REQ_REGISTERED_BUF to bs.supported_write_flags [Stefano]
- Use new blkioq_get_num_completions() API
- Implement .bdrv_refresh_limits()
On 7/8/2022 4:08 AM, Sean Christopherson wrote:
On Fri, Jul 01, 2022, Xiaoyao Li wrote:
On 7/1/2022 6:21 AM, Michael Roth wrote:
On Thu, Jun 30, 2022 at 12:14:13PM -0700, Vishal Annapurve wrote:
With transparent_hugepages=always setting I see issues with the
current implementation.
...
Loo
/qemu into
staging (2022-07-07 06:21:05 +0530)
are available in the Git repository at:
https://git.linaro.org/people/pmaydell/qemu-arm.git
tags/pull-target-arm-20220707
for you to fetch changes up to c2360eaa0262a816faf8032b7762d0c73df2cc62:
target/arm: Fix qemu-system-arm handling of
On 7/7/22 13:24, Thomas Huth wrote:
Hi Richard!
The following changes since commit 39e19f5f67d925c60278a6156fd1776d04495a93:
Merge tag 'pull-xen-20220705' of
https://xenbits.xen.org/git-http/people/aperard/qemu-dm into staging
(2022-07-05 22:13:51 +0530)
are available in the Git reposit
Yes, the qemu version is too old.
My previous qemu version is 4.2, and I upgraded it into 6.0, and it worked now.
Thanks a lot.
- Shirley
-Original Message-
From: Dr. David Alan Gilbert
Sent: Tuesday, July 5, 2022 5:37 PM
To: Zhao, Shirley
Cc: Thomas Huth ; qemu-devel@nongnu.org;
在 2022/7/8 上午12:53, Mayuresh Chitale 写道:
On Sat, 2022-07-02 at 18:19 +0800, angell1518 wrote:
At 2022-06-04 00:04:22, "Mayuresh Chitale"
wrote:
Smstateen extension specifies a mechanism to close
the potential covert channels that could cause security issues.
This patch adds the CSRs defined
在 2022/7/8 上午1:20, Mayuresh Chitale 写道:
On Sat, 2022-07-02 at 18:33 +0800, angell1518 wrote:
At 2022-06-04 00:04:23, "Mayuresh Chitale"
wrote:
Accesses to henvcfg, henvcfgh and senvcfg are allowed
only if corresponding bit in mstateen0/hstateen0 is
enabled. Otherwise an illegal instruction tra
On Thu, Jul 07, 2022 at 06:14:17PM -0300, Leonardo Brás wrote:
> Having 'if(queued == sent)' will cause us to falsely return '1' in two buggy
> cases, while 'if queued == 0) will either skip early or go into 'infinite'
> loop.
I'm not sure I strictly follow here..
Imagine the case we do flush()
This spares us a g_free() call. Let's also not use 'val' and return the
value of kvmppc_read_int_dt() directly.
Signed-off-by: Daniel Henrique Barboza
---
target/ppc/kvm.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
index cf4610
When running under KVM accel it is expected to have 'clock-frequency' in
the DT. Not having this attribute is too risky for both the machine
emulation and userspace.
We have a way of telling whether this error scenario might happen or not
via kvmppc_read_int_cpu_dt() now being able to report error
From: jianchunfu
Use an Error pointer to report the error back to the caller.
While we're at it, return '0' instead of '-1' on error since the
function is supposed to return an uint64_t.
Signed-off-by: jianchunfu
[danielhb: return 0, use error_set_errno() instead of fprintf]
Signed-off-by: Dan
First and foremost, the function can't return '-1' when an error occurs
because the return type is set to uint64_t. Let's fix that.
After that, the function can't simply return 0 whether an error happened
and call it a day. We must provide a way of letting callers know if the
zero return is legiti
Hi,
In this v3 I changed the error report after fopen() to use
error_setg_errno(), as suggested by Cedric.
I also cut patch 1/1 because it's simpler to do all the function changes
in a single patch instead of having a separated patch just to change the
return value of both.
Changes from v2:
- fo
On Thu, 2022-07-07 at 16:06 -0400, Peter Xu wrote:
> On Thu, Jul 07, 2022 at 04:59:22PM -0300, Leonardo Bras Soares Passos wrote:
> > Hello Peter,
> >
> > On Thu, Jul 7, 2022 at 2:56 PM Peter Xu wrote:
> > >
> > > On Mon, Jul 04, 2022 at 05:23:15PM -0300, Leonardo Bras wrote:
> > > > Some errors
On Thu, 2022-07-07 at 15:56 -0400, Peter Xu wrote:
> On Thu, Jul 07, 2022 at 04:50:47PM -0300, Leonardo Bras Soares Passos wrote:
> > > I also think we should squash
> > > patch 2/3 as patch 3 only started to provide meaningful values.
> >
> > IIRC Previously in zero-copy-send implementation, I wa
On Thu, 2022-07-07 at 15:52 -0400, Peter Xu wrote:
> On Thu, Jul 07, 2022 at 04:44:21PM -0300, Leonardo Bras Soares Passos wrote:
> > Hello Peter,
> >
> > On Thu, Jul 7, 2022 at 2:47 PM Peter Xu wrote:
> > >
> > > Hi, Leo,
> > >
> > > On Mon, Jul 04, 2022 at 05:23:13PM -0300, Leonardo Bras wrot
Hi,
Thanks to everyone who contributed information to this report. As far as
issue #1 from David, I cannot reproduce the intermittent MS-DOS or
Windows NT 4 I/O failures with the latest git revision (a74c66b1). I am
similarly unable to reproduce Mdasoh's issue.
For the NT 4 testing script, I had
Call the CHECK_NOSHUF macro multiple times: once in the
fGEN_TCG_PRED_LOAD() and again in fLOAD().
Before this commit, a packet with a store and a predicated
load with mem_noshuf that gets encoded like this:
{ P0 = cmp.eq(R17,#0x0)
memw(R18+#0x0) = R2
if (!P0.new) R3 = memw(R17+#0
The semantics of a mem_noshuf packet are that the store effectively
happens before the load. However, in cases where the load raises an
exception, we cannot simply execute the store first.
This change adds a probe to check that the load will not raise an
exception before executing the store.
If
Recall that the semantics of a Hexagon mem_noshuf packet are that the
store effectively happens before the load. There are two bug fixes
in this series.
Taylor Simpson (2):
Hexagon (target/hexagon) fix store w/mem_noshuf & predicated load
Hexagon (target/hexagon) fix bug in mem_noshuf load e
For small disk images (<4 GiB), QEMU and SeaBIOS default to the
LARGE/ECHS disk translation method, but it is not uncommon for other
BIOS software to use LBA in these cases as well. Some operating
system boot loaders (e.g., NT 4) do not handle LARGE translations
outside of fixed configurations. S
On Thu, 7 Jul 2022 at 20:54, Gregg Allison
wrote:
> We are considering the Gaisler GR712RC (2 core LEON3) and GR740 (4 core
> LEON4) SoCs for a new deep space mission.
>
> Does QEMU support these two multicore configurations at present? Is there
> an effort planned to provide multicore LEONx emul
On Mon, 4 Jul 2022 at 05:50, Markus Armbruster wrote:
> My initial (knee-jerk) reaction to breaking array properties: Faster,
> Pussycat! Kill! Kill!
In an ideal world, what would you replace them with?
thanks
-- PMM
On Fri, Jul 01, 2022, Xiaoyao Li wrote:
> On 7/1/2022 6:21 AM, Michael Roth wrote:
> > On Thu, Jun 30, 2022 at 12:14:13PM -0700, Vishal Annapurve wrote:
> > > With transparent_hugepages=always setting I see issues with the
> > > current implementation.
...
> > > Looks like with transparent huge p
On Thu, Jul 07, 2022 at 04:59:22PM -0300, Leonardo Bras Soares Passos wrote:
> Hello Peter,
>
> On Thu, Jul 7, 2022 at 2:56 PM Peter Xu wrote:
> >
> > On Mon, Jul 04, 2022 at 05:23:15PM -0300, Leonardo Bras wrote:
> > > Some errors, like the lack of Scatter-Gather support by the network
> > > int
Hello Peter,
On Thu, Jul 7, 2022 at 2:56 PM Peter Xu wrote:
>
> On Mon, Jul 04, 2022 at 05:23:15PM -0300, Leonardo Bras wrote:
> > Some errors, like the lack of Scatter-Gather support by the network
> > interface(NETIF_F_SG) may cause sendmsg(...,MSG_ZEROCOPY) to fail on using
> > zero-copy, whic
On Thu, Jul 07, 2022 at 04:50:47PM -0300, Leonardo Bras Soares Passos wrote:
> > I also think we should squash
> > patch 2/3 as patch 3 only started to provide meaningful values.
>
> IIRC Previously in zero-copy-send implementation, I was asked to keep the
> property/capability in a separated patc
On Thu, Jul 07, 2022 at 04:44:21PM -0300, Leonardo Bras Soares Passos wrote:
> Hello Peter,
>
> On Thu, Jul 7, 2022 at 2:47 PM Peter Xu wrote:
> >
> > Hi, Leo,
> >
> > On Mon, Jul 04, 2022 at 05:23:13PM -0300, Leonardo Bras wrote:
> > > If flush is called when no buffer was sent with MSG_ZEROCOPY
We are considering the Gaisler GR712RC (2 core LEON3) and GR740 (4 core LEON4)
SoCs for a new deep space mission.
Does QEMU support these two multicore configurations at present? Is there an
effort planned to provide multicore LEONx emulation?
Gregg Allison
[signature_1890048335]
Senior Profess
Hello Peter,
On Thu, Jul 7, 2022 at 2:54 PM Peter Xu wrote:
>
> On Mon, Jul 04, 2022 at 05:23:14PM -0300, Leonardo Bras wrote:
> > Signed-off-by: Leonardo Bras
> > ---
> > qapi/migration.json | 7 ++-
> > migration/migration.c | 2 ++
> > monitor/hmp-cmds.c| 4
> > 3 files change
This program:
int main(void) { asm("bv %r0(%r0)"); return 0; }
produces on real hardware the expected segfault:
--- SIGSEGV {si_signo=SIGSEGV, si_code=SEGV_MAPERR, si_addr=0x3} ---
+++ killed by SIGSEGV +++
Segmentation fault
But when run on linux-user you get instead internal qemu errors:
Hello Peter,
On Thu, Jul 7, 2022 at 2:47 PM Peter Xu wrote:
>
> Hi, Leo,
>
> On Mon, Jul 04, 2022 at 05:23:13PM -0300, Leonardo Bras wrote:
> > If flush is called when no buffer was sent with MSG_ZEROCOPY, it currently
> > returns 1. This return code should be used only when Linux fails to use
>
We just added TLS tests for precopy but not postcopy. Add the
corresponding test for vanilla postcopy.
Rename the vanilla postcopy to "postcopy/plain" because all postcopy tests
will only use unix sockets as channel.
Signed-off-by: Peter Xu
---
tests/qtest/migration-test.c | 61 +++
So that it can be used in postcopy tests too soon.
Reviewed-by: Daniel P. Berrange
Signed-off-by: Peter Xu
---
tests/qtest/migration-test.c | 144 +--
1 file changed, 72 insertions(+), 72 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migra
Add a property field that can conditionally disable the "break sending huge
page" behavior in postcopy preemption. By default it's enabled.
It should only be used for debugging purposes, and we should never remove
the "x-" prefix.
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Manish Mishra
On Thu, Jul 07, 2022 at 10:53:57AM -0700, Peter Delevoryas wrote:
> On Thu, Jul 07, 2022 at 10:56:02AM +0200, Cédric Le Goater wrote:
> > On 7/7/22 09:17, Peter Delevoryas wrote:
> > > It seems that aspeed_gpio_update is allowing the value for input pins to
> > > be
> > > modified through register
Add migrate_channel_requires_tls() to detect whether the specific channel
requires TLS, leveraging the recently introduced migrate_use_tls(). No
functional change intended.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
migration/channel.c | 9 ++---
migration/migration.
It's easy to build this upon the postcopy tls test. Rename the old
postcopy recovery test to postcopy/recovery/plain.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
tests/qtest/migration-test.c | 37
1 file changed, 29 insertions(+), 8 dele
This patch allows the postcopy preempt channel to be created
asynchronously. The benefit is that when the connection is slow, we won't
take the BQL (and potentially block all things like QMP) for a long time
without releasing.
A function postcopy_preempt_wait_channel() is introduced, allowing the
It's useful for specifying tls credentials all in the cmdline (along with
the -object tls-creds-*), especially for debugging purpose.
The trick here is we must remember to not free these fields again in the
finalize() function of migration object, otherwise it'll cause double-free.
The thing is w
To allow postcopy recovery, the ram fast load (preempt-only) dest QEMU thread
needs similar handling on fault tolerance. When ram_load_postcopy() fails,
instead of stopping the thread it halts with a semaphore, preparing to be
kicked again when recovery is detected.
A mutex is introduced to make
Four tests are added for preempt mode:
- Postcopy plain
- Postcopy recovery
- Postcopy tls
- Postcopy tls+recovery
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
tests/qtest/migration-test.c | 56
1 file changed, 56 insertions(+)
d
This patch is based on the async preempt channel creation. It continues
wiring up the new channel with TLS handshake to destionation when enabled.
Note that only the src QEMU needs such operation; the dest QEMU does not
need any change for TLS support due to the fact that all channels are
establi
Firstly, postcopy already preempts precopy due to the fact that we do
unqueue_page() first before looking into dirty bits.
However that's not enough, e.g., when there're host huge page enabled, when
sending a precopy huge page, a postcopy request needs to wait until the whole
huge page that is sen
With preemption mode on, when we see a postcopy request that was requesting
for exactly the page that we have preempted before (so we've partially sent
the page already via PRECOPY channel and it got preempted by another
postcopy request), currently we drop the request so that after all the
other p
This patch enables postcopy-preempt feature.
It contains two major changes to the migration logic:
(1) Postcopy requests are now sent via a different socket from precopy
background migration stream, so as to be isolated from very high page
request delays.
(2) For huge page enabled hosts:
Create a new socket for postcopy to be prepared to send postcopy requested
pages via this specific channel, so as to not get blocked by precopy pages.
A new thread is also created on dest qemu to receive data from this new channel
based on the ram_load_postcopy() routine.
The ram_load_postcopy(PO
Based on:
[PATCH] tests: migration-test: Allow test to run without uffd
https://lore.kernel.org/qemu-devel/20220707184600.24164-1-pet...@redhat.com/
This is v8 of postcopy preempt series. It can also be found here:
https://github.com/xzpeter/qemu/tree/postcopy-preempt
RFC: https://lore.ker
On Wed, Jul 06, 2022 at 05:52:48PM -0700, Peter Delevoryas wrote:
> On Wed, Jul 06, 2022 at 09:46:48AM -0700, Peter Delevoryas wrote:
> > On Wed, Jul 06, 2022 at 09:02:14AM +0100, Daniel P. Berrangé wrote:
> > > On Tue, Jul 05, 2022 at 02:46:59PM -0700, Peter Delevoryas wrote:
> > > > I noticed tha
We used to stop running all tests if uffd is not detected. However
logically that's only needed for postcopy not the rest of tests.
Keep running the rest when still possible.
Signed-off-by: Peter Xu
---
tests/qtest/migration-test.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions
Hi
On Thu, Jul 7, 2022 at 4:13 PM Markus Armbruster wrote:
> marcandre.lur...@redhat.com writes:
>
> > From: Marc-André Lureau
> >
> > Remove monitor dependency from error printing code, by allowing programs
> > to set a callback for when to use "detailed" reporting or not.
> >
> > Signed-off-b
Hi
On Thu, Jul 7, 2022 at 4:18 PM Markus Armbruster wrote:
> marcandre.lur...@redhat.com writes:
>
> > From: Marc-André Lureau
> >
> > error_vprintf() is implemented in monitor.c, which overrides the
> > default implementation from stubs/, while avoiding a direct dependency
> > to the monitor f
On Mon, Jul 04, 2022 at 05:23:15PM -0300, Leonardo Bras wrote:
> Some errors, like the lack of Scatter-Gather support by the network
> interface(NETIF_F_SG) may cause sendmsg(...,MSG_ZEROCOPY) to fail on using
> zero-copy, which causes it to fall back to the default copying mechanism.
>
> After ea
On Mon, Jul 04, 2022 at 05:23:14PM -0300, Leonardo Bras wrote:
> Signed-off-by: Leonardo Bras
> ---
> qapi/migration.json | 7 ++-
> migration/migration.c | 2 ++
> monitor/hmp-cmds.c| 4
> 3 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/migration.json b/qap
On Thu, Jul 07, 2022 at 10:56:02AM +0200, Cédric Le Goater wrote:
> On 7/7/22 09:17, Peter Delevoryas wrote:
> > It seems that aspeed_gpio_update is allowing the value for input pins to be
> > modified through register writes and QOM property modification.
> >
> > The QOM property modification is
On Thu, Jul 07, 2022 at 08:20:01AM +, Joel Stanley wrote:
> On Thu, 7 Jul 2022 at 07:17, Peter Delevoryas wrote:
> >
> > It seems that aspeed_gpio_update is allowing the value for input pins to be
> > modified through register writes and QOM property modification.
> >
> > The QOM property modi
Hi, Leo,
On Mon, Jul 04, 2022 at 05:23:13PM -0300, Leonardo Bras wrote:
> If flush is called when no buffer was sent with MSG_ZEROCOPY, it currently
> returns 1. This return code should be used only when Linux fails to use
> MSG_ZEROCOPY on a lot of sendmsg().
>
> Fix this by returning early from
Hi
On Thu, Jul 7, 2022 at 4:25 PM Markus Armbruster wrote:
> marcandre.lur...@redhat.com writes:
>
> > From: Marc-André Lureau
> >
> > Not needed outside monitor.c. Remove the needless stub.
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > include/monitor/monitor.h | 1 -
> > monitor/moni
On Sat, 2022-07-02 at 18:33 +0800, angell1518 wrote:
> At 2022-06-04 00:04:23, "Mayuresh Chitale" > wrote:
> >Accesses to henvcfg, henvcfgh and senvcfg are allowed
> >only if corresponding bit in mstateen0/hstateen0 is
> >enabled. Otherwise an illegal instruction trap is
> >generated.
> >
> >Signe
On Sat, 2022-07-02 at 18:19 +0800, angell1518 wrote:
> At 2022-06-04 00:04:22, "Mayuresh Chitale" > wrote:
> >Smstateen extension specifies a mechanism to close
> >the potential covert channels that could cause security issues.
> >
> >This patch adds the CSRs defined in the specification and
> >th
On Mon, Jul 04, 2022 at 04:46:53PM +0100, Peter Maydell wrote:
> On Mon, 4 Jul 2022 at 16:23, Daniel P. Berrangé wrote:
> >
> > Historically QEMU has used the 'scripts/checkpatch.pl' script to
> > validate various style rules but there are a number of issues:
>
> > meson.build | 3
Signed-off-by: Daniel P. Berrangé
---
block/linux-aio.c | 2 +-
block/qcow2-bitmap.c | 8
contrib/plugins/cache.c| 2 +-
disas/libvixl/vixl/invalset.h | 2 +-
docs/devel/qom.rst | 4 ++--
docs/interop/liv
On Thu, Jul 7, 2022, 17:28 Alex Bennée wrote:
>
> Stefan Hajnoczi writes:
>
> > On Thu, 7 Jul 2022 at 14:42, Alex Bennée wrote:
> >>
> >>
> >> Stefan Hajnoczi writes:
> >>
> >> > [[PGP Signed Part:Undecided]]
> >> > On Tue, May 24, 2022 at 04:40:41PM +0100, Alex Bennée wrote:
> >> >> Hi,
> >>
A few files relied on qemu/osdep.h being included via a common
header. Others didn't need it because they were actually an
included file, so ought to have been named '.c.inc'. Finally
some didn't have it as the first header included.
Signed-off-by: Daniel P. Berrangé
---
backends/hostmem-epc.c
The qemu/osdep.h file must be included as the very first header in
all C source files, to ensure its definitions take effect over all
other header files, including system headers.
Signed-off-by: Daniel P. Berrangé
---
tests/style.yml | 24 +++-
1 file changed, 23 insertions(+
Since qemu/osdep.h is guaranteed present in all C source files,
there is hno reason for it to be present in header files. Some
C source files are not directly directly, but rather included
from other source files. These should also not have qemu/osdep.h
present, as the primary source will have alre
This style check looks for cases where the words
the then in an on if is it but for or at and do to
are repeated in a sentence. It uses a multi-line match to catch the
especially common mistake in docs where the last word on a line is
repeated as the first word of the next line.
There are inev
Since the qemu/osdep.h file must be included as the very first header
in all C source files, there is no reason to include it in .h or .c.in
files.
Signed-off-by: Daniel P. Berrangé
---
tests/style.yml | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/style.yml b/tests/style.yml
ind
Historically QEMU has used the 'scripts/checkpatch.pl' script to
validate various style rules but there are a number of issues:
- Contributors / maintainers are reluctant to add new
tests to it, nor fix existint rules, because the Perl
code is much too hard to understand for most people.
The 'true' and 'false' constants should only ever be used with the
'bool' type, never 'int'.
Signed-off-by: Daniel P. Berrangé
---
tests/style.yml | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/style.yml b/tests/style.yml
index b4e7c6111f..704227d8e9 100644
--- a/tests/style.yml
Signed-off-by: Daniel P. Berrangé
---
block/vhdx-log.c | 2 +-
hw/xtensa/sim.c| 4 ++--
nbd/client.c | 8 +---
target/i386/cpu-dump.c | 3 ++-
ui/spice-display.c | 4 ++--
5 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/block/vhdx-log.c b/block/vhdx
Update of:
v2: https://lists.gnu.org/archive/html/qemu-devel/2022-07/msg00595.html
The first patch gives a detailed description, but the overall goal
here is to provide a code style checking facility to augment (and
ideally replace) checkstyle.pl. The key conceptual differences are:
- Always a
Signed-off-by: Cornelia Huck
---
tests/qtest/arm-cpu-features.c | 77 ++
1 file changed, 77 insertions(+)
diff --git a/tests/qtest/arm-cpu-features.c b/tests/qtest/arm-cpu-features.c
index 5a145273860c..466be857d391 100644
--- a/tests/qtest/arm-cpu-features.c
+++
This series makes it possible to enable MTE for kvm guests, if the kernel
supports it. Again, tested on the simulator via patiently waiting for the
arm64/mte kselftests to finish successfully.
For tcg, turning on mte on the machine level (to get tag memory) stays a
requirement. If the new mte cpu
Introduce a new cpu feature flag to control MTE support. To preserve
backwards compatibility for tcg, MTE will continue to be enabled as
long as tag memory has been provided.
If MTE has been enabled, we need to disable migration, as we do not
yet have a way to migrate the tags as well. Therefore,
On Thu, 2022-06-16 at 17:18 +1000, Alistair Francis wrote:
> On Sat, Jun 4, 2022 at 2:15 AM Mayuresh Chitale
> wrote:
> > If smstateen is implemented then accesses to AIA
> > registers CSRS, IMSIC CSRs and other IMSIC registers
> > is controlled by setting of corresponding bits in
> > mstateen/hst
On Thu, 2022-06-16 at 17:17 +1000, Alistair Francis wrote:
> On Sat, Jun 4, 2022 at 2:08 AM Mayuresh Chitale
> wrote:
> > If smstateen is implemented and sstateen0.fcsr is clear
> > then the floating point operations must return illegal
> > instruction exception.
> >
> > Signed-off-by: Mayuresh C
On 7/1/22 17:10, Joao Martins wrote:
> +/*
> + * The HyperTransport range close to the 1T boundary is unique to AMD
> + * hosts with IOMMUs enabled. Restrict the ram-above-4g relocation
> + * to above 1T to AMD vCPUs only.
> + */
> +if (IS_AMD_CPU(&cpu->env)) {
> +pc
On Thu, Jul 07, 2022 at 11:48:35AM -0400, John Snow wrote:
> On Thu, Jul 7, 2022 at 4:33 AM Daniel P. Berrangé wrote:
> >
> > On Thu, Jul 07, 2022 at 12:03:07AM -0400, John Snow wrote:
> > > The fedora container has since been split apart, so there's no suitable
> > > nearby target that would supp
Markus Armbruster writes:
> QDict is implemented as a simple hash table of fixed size. Observe:
>
> * Slow for large n. Not sure this matters.
>
> * A QDict with n entries takes 4120 + n * 32 bytes on my box. Wastes
> space for small n, which is a common case.
>
> * Order of traversal depe
On Thu, Jul 7, 2022 at 4:33 AM Daniel P. Berrangé wrote:
>
> On Thu, Jul 07, 2022 at 12:03:07AM -0400, John Snow wrote:
> > The fedora container has since been split apart, so there's no suitable
> > nearby target that would support "test-mingw" as it requires both x32
> > and x64 support -- so ei
On Thu, 2022-06-16 at 15:48 +1000, Alistair Francis wrote:
> On Sat, Jun 4, 2022 at 2:13 AM Mayuresh Chitale
> wrote:
> > Smstateen extension specifies a mechanism to close
> > the potential covert channels that could cause security issues.
> >
> > This patch adds the CSRs defined in the specific
On Thu, Jul 7, 2022 at 7:05 AM Richard Henderson
wrote:
>
> On 7/7/22 09:33, John Snow wrote:
> > 18.04 has fallen out of our support window, so move ubuntu.aarch64
> > forward to ubuntu 20.04, which is now our oldest supported Ubuntu
> > release.
>
> Ah. Squash with patch 5?
Can do. I left it s
On Tue, Jul 05, 2022 at 11:54:21AM +0200, Markus Armbruster wrote:
> QDict is implemented as a simple hash table of fixed size. Observe:
>
> * Slow for large n. Not sure this matters.
I presume you're referring qdict_find() here, which would
ideally be O(1).
Our bucket size is 512, so for hash
Stefan Hajnoczi writes:
> On Thu, 7 Jul 2022 at 14:42, Alex Bennée wrote:
>>
>>
>> Stefan Hajnoczi writes:
>>
>> > [[PGP Signed Part:Undecided]]
>> > On Tue, May 24, 2022 at 04:40:41PM +0100, Alex Bennée wrote:
>> >> Hi,
>> >>
>> >> This series ostensibly adds virtio-user-gpio stubs to the bu
On 7/7/22 14:15, Igor Mammedov wrote:
> On Fri, 1 Jul 2022 17:10:12 +0100
> Joao Martins wrote:
>
>> Move obtaining hole64_start from device_memory MR base/size into an helper
>> alongside correspondent getters in pc_memory_init() when the hotplug
>> range is unitialized.
>>
>> This is the fi
On Thu, Jul 7, 2022 at 4:40 AM Marc-André Lureau
wrote:
>
> Hi
>
> On Thu, Jul 7, 2022 at 8:10 AM John Snow wrote:
>>
>> In some container environments, there may be references to block devices
>> witnessable from a container through /proc/self/mountinfo that reference
>> devices we simply don't
On 7/7/22 14:05, Igor Mammedov wrote:
> On Fri, 1 Jul 2022 17:10:11 +0100
> Joao Martins wrote:
>
>> This in preparation to allow pc_pci_hole64_start() to be called early
>> in pc_memory_init(), handle CXL memory region end when its underlying
>> memory region isn't yet initialized.
>>
>> Cc:
1 - 100 of 197 matches
Mail list logo
