Re: Internal MAC addresses list (mac_table) usage

2022-07-14 Thread Ovchinnikov, Vitalii
Hi Jason, Thanks for pointing out that corner case with "52:54:00:12:34:XX". In the NIC model I'm developing qemu_macaddr_default_if_unset is called every time MAC is updated in the NIC registers. This way a just assigned "52:54:00:12:34:XX" MAC is at least marked as used in the mac_table. How

Re: [PATCH v2 05/11] dump/dump: Add section string table support

2022-07-14 Thread Marc-André Lureau
Hi On Thu, Jul 14, 2022 at 3:54 PM Janosch Frank wrote: > On 7/13/22 17:58, Marc-André Lureau wrote: > > Hi > > > > On Wed, Jul 13, 2022 at 5:07 PM Janosch Frank > wrote: > >> > >> Time to add a bit more descriptiveness to the dumps. > > > > Please add some more description & motivation to the

Re: [PATCH v2 05/11] dump/dump: Add section string table support

2022-07-14 Thread Janosch Frank
On 7/13/22 17:58, Marc-André Lureau wrote: Hi On Wed, Jul 13, 2022 at 5:07 PM Janosch Frank wrote: Time to add a bit more descriptiveness to the dumps. Please add some more description & motivation to the patch (supposedly necessary for next patches), and explain that it currently doesn't c

Re: [PATCH v6 09/10] i386/pc: relocate 4g start to 1T where applicable

2022-07-14 Thread Igor Mammedov
On Thu, 14 Jul 2022 11:47:19 +0100 Joao Martins wrote: > On 7/14/22 10:54, Joao Martins wrote: > > On 7/14/22 10:28, Igor Mammedov wrote: > >> On Tue, 12 Jul 2022 12:35:49 +0100 > >> Joao Martins wrote: > >>> On 7/12/22 11:01, Joao Martins wrote: > On 7/12/22 10:06, Igor Mammedov wrot

Re: [PATCH v2 03/11] dump: Split write of section headers and data and add a prepare step

2022-07-14 Thread Janosch Frank
On 7/13/22 17:31, Marc-André Lureau wrote: Hi On Wed, Jul 13, 2022 at 5:07 PM Janosch Frank wrote: By splitting the writing of the section headers and (future) section data we prepare for the addition of a string table section and architecture sections. Signed-off-by: Janosch Frank --- [.

Re: [PULL 00/54] virtio,pc,pci: fixes,cleanups,features

2022-07-14 Thread Igor Mammedov
On Thu, 14 Jul 2022 10:16:34 +0100 Peter Maydell wrote: > On Fri, 10 Jun 2022 at 08:57, Michael S. Tsirkin wrote: > > > > virtio,pc,pci: fixes,cleanups,features > > > > more CXL patches > > VIOT > > Igor's huge AML rework > > fixes

Re: [PATCH v8 02/12] s390x/cpu_topology: CPU topology objects and structures

2022-07-14 Thread Pierre Morel
On 7/14/22 12:38, Janis Schoetterl-Glausch wrote: On 7/13/22 16:59, Pierre Morel wrote: On 7/12/22 17:40, Janis Schoetterl-Glausch wrote: On 6/20/22 16:03, Pierre Morel wrote: [...] +} + +/* + * s390_topology_new_cpu: + * @core_id: the core ID is machine wide + * + * We have a single

Re: [PATCH v6 09/10] i386/pc: relocate 4g start to 1T where applicable

2022-07-14 Thread Joao Martins
On 7/14/22 10:54, Joao Martins wrote: > On 7/14/22 10:28, Igor Mammedov wrote: >> On Tue, 12 Jul 2022 12:35:49 +0100 >> Joao Martins wrote: >>> On 7/12/22 11:01, Joao Martins wrote: On 7/12/22 10:06, Igor Mammedov wrote: > On Mon, 11 Jul 2022 21:03:28 +0100 > Joao Martins wrote:

Re: [PATCH v2] Align Raspberry Pi DMA interrupts with Linux DTS

2022-07-14 Thread Makarov, Andrey
Hi Phil, Agreed, for v3 I selected naming with "orgated" instead of "shared" because there is already IRQ line #15 that is called shared which seems like a completely different thing and it's "not used" according to DTS (arch/arm/boot/dts/bcm2835-common.dtsi): interru

Re: [PATCH v8 02/12] s390x/cpu_topology: CPU topology objects and structures

2022-07-14 Thread Janis Schoetterl-Glausch
On 7/13/22 16:59, Pierre Morel wrote: > > > On 7/12/22 17:40, Janis Schoetterl-Glausch wrote: >> On 6/20/22 16:03, Pierre Morel wrote: >>> We use new objects to have a dynamic administration of the CPU topology. >>> The highest level object in this implementation is the s390 book and >>> in this

Re: [PATCH v10 12/12] target/riscv: Update the privilege field for sscofpmf CSRs

2022-07-14 Thread Heiko Stübner
Am Dienstag, 21. Juni 2022, 01:16:02 CEST schrieb Atish Patra: > The sscofpmf extension was ratified as a part of priv spec v1.12. > Mark the csr_ops accordingly. > > Reviewed-by: Alistair Francis > Signed-off-by: Atish Patra Reviewed-by: Heiko Stuebner Tested-by: Heiko Stuebner > --- > tar

Re: [PATCH v10 11/12] hw/riscv: virt: Add PMU DT node to the device tree

2022-07-14 Thread Heiko Stübner
Hi Atish, Am Dienstag, 21. Juni 2022, 01:16:01 CEST schrieb Atish Patra: > Qemu virt machine can support few cache events and cycle/instret counters. > It also supports counter overflow for these events. > > Add a DT node so that OpenSBI/Linux kernel is aware of the virt machine > capabilities. T

Re: [PATCH v7 03/13] multifd: Create page_count fields into both MultiFD{Recv,Send}Params

2022-07-14 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We were recalculating it left and right. We plan to change that > values on next patches. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/multifd.h | 4 > migration/multifd.c | 7 --- > 2 files cha

Re: [RFC v3 8/8] virtio-blk: use BDRV_REQ_REGISTERED_BUF optimization hint

2022-07-14 Thread Hanna Reitz
On 08.07.22 06:17, Stefan Hajnoczi wrote: Register guest RAM using BlockRAMRegistrar and set the BDRV_REQ_REGISTERED_BUF flag so block drivers can optimize memory accesses in I/O requests. This is for vdpa-blk, vhost-user-blk, and other I/O interfaces that rely on DMA mapping/unmapping. Signed-

Re: [RFC v3 7/8] blkio: implement BDRV_REQ_REGISTERED_BUF optimization

2022-07-14 Thread Hanna Reitz
On 08.07.22 06:17, Stefan Hajnoczi wrote: Avoid bounce buffers when QEMUIOVector elements are within previously registered bdrv_register_buf() buffers. The idea is that emulated storage controllers will register guest RAM using bdrv_register_buf() and set the BDRV_REQ_REGISTERED_BUF on I/O reque

Re: [PATCH v7 02/13] multifd: Create page_size fields into both MultiFD{Recv,Send}Params

2022-07-14 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We were calling qemu_target_page_size() left and right. Yeh, I still suspect the right answer is to make qemu_target_page_size() trivially fast, but for now; Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Juan Quintela > --- > migration/mu

Re: [PATCH v10 09/12] target/riscv: Simplify counter predicate function

2022-07-14 Thread Heiko Stübner
Am Dienstag, 21. Juni 2022, 01:15:59 CEST schrieb Atish Patra: > All the hpmcounters and the fixed counters (CY, IR, TM) can be represented > as a unified counter. Thus, the predicate function doesn't need handle each > case separately. > > Simplify the predicate function so that we just handle th

[PATCH] hw/virtio/virtio-iommu: Enforce power-of-two notify for both MAP and UNMAP

2022-07-14 Thread Jean-Philippe Brucker
Currently we only enforce power-of-two mappings (required by the QEMU notifier) for UNMAP requests. A MAP request not aligned on a power-of-two may be successfully handled by VFIO, and then the corresponding UNMAP notify will fail because it will attempt to split that mapping. Ensure MAP and UNMAP

RE: [PATCH v2] target/i386: Restore TSX features with taa-no

2022-07-14 Thread Duan, Zhenzhong
>-Original Message- >From: Paolo Bonzini On Behalf Of Paolo Bonzini >Sent: Thursday, July 14, 2022 3:59 PM >To: Duan, Zhenzhong ; qemu- >de...@nongnu.org >Cc: ehabk...@redhat.com; Ma, XiangfeiX ; Li, >Xiaoyao ; Christopherson,, Sean >Subject: Re: [PATCH v2] target/i386: Restore TSX feat

Re: [PATCH v10 10/12] target/riscv: Add few cache related PMU events

2022-07-14 Thread Heiko Stübner
Am Dienstag, 21. Juni 2022, 01:16:00 CEST schrieb Atish Patra: > From: Atish Patra > > Qemu can monitor the following cache related PMU events through > tlb_fill functions. > > 1. DTLB load/store miss > 3. ITLB prefetch miss > > Increment the PMU counter in tlb_fill function. > > Reviewed-by:

Re: [PATCH v6 09/10] i386/pc: relocate 4g start to 1T where applicable

2022-07-14 Thread Joao Martins
On 7/14/22 10:28, Igor Mammedov wrote: > On Tue, 12 Jul 2022 12:35:49 +0100 > Joao Martins wrote: > >> On 7/12/22 11:01, Joao Martins wrote: >>> On 7/12/22 10:06, Igor Mammedov wrote: On Mon, 11 Jul 2022 21:03:28 +0100 Joao Martins wrote: > On 7/11/22 16:31, Joao Martins wrote:

Re: [PATCH v10 08/12] target/riscv: Add sscofpmf extension support

2022-07-14 Thread Heiko Stübner
Am Dienstag, 21. Juni 2022, 01:15:58 CEST schrieb Atish Patra: > The Sscofpmf ('Ss' for Privileged arch and Supervisor-level extensions, > and 'cofpmf' for Count OverFlow and Privilege Mode Filtering) > extension allows the perf to handle overflow interrupts and filtering > support. This patch prov

Re: [RFC v3 6/8] stubs: add memory_region_from_host() and memory_region_get_fd()

2022-07-14 Thread Hanna Reitz
On 08.07.22 06:17, Stefan Hajnoczi wrote: The blkio block driver will need to look up the file descriptor for a given pointer. This is possible in softmmu builds where the memory API is available for querying guest RAM. Add stubs so tools like qemu-img that link the block layer still build succe

Re: [RFC v3 5/8] block: add BlockRAMRegistrar

2022-07-14 Thread Hanna Reitz
On 08.07.22 06:17, Stefan Hajnoczi wrote: Emulated devices and other BlockBackend users wishing to take advantage of blk_register_buf() all have the same repetitive job: register RAMBlocks with the BlockBackend using RAMBlockNotifier. Add a BlockRAMRegistrar API to do this. A later commit will u

Re: [PATCH v7 01/13] multifd: Document the locking of MultiFD{Send/Recv}Params

2022-07-14 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Reorder the structures so we can know if the fields are: > - Read only > - Their own locking (i.e. sems) > - Protected by 'mutex' > - Only for the multifd channel > > Signed-off-by: Juan Quintela > --- > migration/multifd.h | 90

Re: [PATCH v2 01/11] dump: Cleanup memblock usage

2022-07-14 Thread Janosch Frank
On 7/13/22 17:35, Marc-André Lureau wrote: Hi On Wed, Jul 13, 2022 at 7:30 PM Janosch Frank wrote: On 7/13/22 17:09, Marc-André Lureau wrote: Hi On Wed, Jul 13, 2022 at 5:07 PM Janosch Frank wrote: The iteration over the memblocks is hard to understand so it's about time to clean it up.

[PATCH v3] Align Raspberry Pi DMA interrupts with Linux DTS

2022-07-14 Thread Andrey Makarov
In v3: - changed naming of orgate & removed hard-coded constants Signed-off-by: Andrey Makarov --- hw/arm/bcm2835_peripherals.c | 25 ++- include/hw/arm/bcm2835_peripherals.h | 2 + tests/qtest/bcm2835-dma-test.c | 106 +++ tests/qtest/meson.build

Re: [PATCH v6 09/10] i386/pc: relocate 4g start to 1T where applicable

2022-07-14 Thread Igor Mammedov
On Tue, 12 Jul 2022 12:35:49 +0100 Joao Martins wrote: > On 7/12/22 11:01, Joao Martins wrote: > > On 7/12/22 10:06, Igor Mammedov wrote: > >> On Mon, 11 Jul 2022 21:03:28 +0100 > >> Joao Martins wrote: > >>> On 7/11/22 16:31, Joao Martins wrote: > On 7/11/22 15:52, Joao Martins wrote

Re: [PATCH v6 09/10] i386/pc: relocate 4g start to 1T where applicable

2022-07-14 Thread Igor Mammedov
On Tue, 12 Jul 2022 11:01:18 +0100 Joao Martins wrote: > On 7/12/22 10:06, Igor Mammedov wrote: > > On Mon, 11 Jul 2022 21:03:28 +0100 > > Joao Martins wrote: > > > >> On 7/11/22 16:31, Joao Martins wrote: > >>> On 7/11/22 15:52, Joao Martins wrote: > On 7/11/22 13:56, Igor Mammedo

[PULL 18/20] q800: add default vendor and product information for scsi-hd devices

2022-07-14 Thread Paolo Bonzini
From: Mark Cave-Ayland The Apple HD SC Setup program uses a SCSI INQUIRY command to check that any SCSI hard disks detected match a whitelist of vendors and products before allowing the "Initialise" button to prepare an empty disk. Add known-good default vendor and product information using the

[PULL 15/20] q800: implement compat_props to enable quirk_mode_page_truncated for scsi-cd devices

2022-07-14 Thread Paolo Bonzini
From: Mark Cave-Ayland By default quirk_mode_page_truncated should be enabled for all scsi-cd devices connected to the q800 machine to allow A/UX to enumerate SCSI CDROM devices without hanging. Signed-off-by: Mark Cave-Ayland Message-Id: <20220622105314.802852-11-mark.cave-ayl...@ilande.co.uk>

[PULL 20/20] pc-bios/s390-ccw: add -Wno-array-bounds

2022-07-14 Thread Paolo Bonzini
The option generates a lot of warnings for integers casted to pointers, for example: /home/pbonzini/work/upstream/qemu/pc-bios/s390-ccw/dasd-ipl.c:174:19: warning: array subscript 0 is outside array bounds of ‘CcwSeekData[0]’ [-Warray-bounds] 174 | seekData->cyl = 0x00; |

[PULL 14/20] scsi-disk: add SCSI_DISK_QUIRK_MODE_PAGE_TRUNCATED quirk for Macintosh

2022-07-14 Thread Paolo Bonzini
From: Mark Cave-Ayland When A/UX configures the CDROM device it sends a truncated MODE SELECT request for page 1 (MODE_PAGE_R_W_ERROR) which is only 6 bytes in length rather than 10. This seems to be due to bug in Apple's code which calculates the CDB message length incorrectly. The work at [1]

[PULL 17/20] scsi-disk: allow MODE SELECT block descriptor to set the block size

2022-07-14 Thread Paolo Bonzini
From: Mark Cave-Ayland The MODE SELECT command can contain an optional block descriptor that can be used to set the device block size. If the block descriptor is present then update the block size on the SCSI device accordingly. This allows CDROMs to be used with A/UX which requires a CDROM dri

Re: [PULL 00/54] virtio,pc,pci: fixes,cleanups,features

2022-07-14 Thread Peter Maydell
On Fri, 10 Jun 2022 at 08:57, Michael S. Tsirkin wrote: > > virtio,pc,pci: fixes,cleanups,features > > more CXL patches > VIOT > Igor's huge AML rework > fixes, cleanups all over the place Hi. On my macos machine (an x86 one), 'make

[PULL 06/20] scsi-disk: add new quirks bitmap to SCSIDiskState

2022-07-14 Thread Paolo Bonzini
From: Mark Cave-Ayland Since the MacOS SCSI implementation is quite old (and Apple added some firmware customisations to their drives for m68k Macs) there is need to add a mechanism to correctly handle Apple-specific quirks. Add a new quirks bitmap to SCSIDiskState that can be used to enable the

[PULL 12/20] q800: implement compat_props to enable quirk_mode_page_vendor_specific_apple for scsi devices

2022-07-14 Thread Paolo Bonzini
From: Mark Cave-Ayland By default quirk_mode_page_vendor_specific_apple should be enabled for both scsi-hd and scsi-cd devices to allow MacOS to format SCSI disk devices, and A/UX to enumerate SCSI CDROM devices succesfully without getting stuck in a loop. Signed-off-by: Mark Cave-Ayland Messa

[PULL 19/20] q800: add default vendor and product information for scsi-cd devices

2022-07-14 Thread Paolo Bonzini
From: Mark Cave-Ayland The MacOS CDROM driver uses a SCSI INQUIRY command to check that any SCSI CDROMs detected match a whitelist of vendors and products before adding them to the list of available devices. Add known-good default vendor and product information using the existing compat_prop mec

[PULL 16/20] scsi-disk: allow the MODE_PAGE_R_W_ERROR AWRE bit to be changeable for CDROM drives

2022-07-14 Thread Paolo Bonzini
From: Mark Cave-Ayland A/UX sends a MODE_PAGE_R_W_ERROR command with the AWRE bit set to 0 when enumerating CDROM drives. Since the bit is currently hardcoded to 1 then indicate that the AWRE bit can be changed (even though we don't care about the value) so that the MODE_PAGE_R_W_ERROR page can

[PULL 13/20] scsi-disk: add FORMAT UNIT command

2022-07-14 Thread Paolo Bonzini
From: Mark Cave-Ayland When initialising a drive ready to install MacOS, Apple HD SC Setup first attempts to format the drive. Add a simple FORMAT UNIT command which simply returns success to allow the format to succeed. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Mes

[PULL 09/20] scsi-disk: add SCSI_DISK_QUIRK_MODE_SENSE_ROM_USE_DBD quirk for Macintosh

2022-07-14 Thread Paolo Bonzini
From: Mark Cave-Ayland During SCSI bus enumeration A/UX sends a MODE SENSE command to the CDROM with the DBD bit unset and expects the response to include a block descriptor. As per the latest SCSI documentation, QEMU currently force-disables the block descriptor for CDROM devices but the A/UX dr

[PULL 04/20] module: Use bundle mechanism

2022-07-14 Thread Paolo Bonzini
From: Akihiko Odaki Before this change, the directory of the executable was being added to resolve modules in the build tree. However, get_relocated_path() can now resolve them with the new bundle mechanism. Signed-off-by: Akihiko Odaki Message-Id: <20220624145039.49929-5-akihiko.od...@gmail.co

[PULL 10/20] q800: implement compat_props to enable quirk_mode_sense_rom_use_dbd for scsi-cd devices

2022-07-14 Thread Paolo Bonzini
From: Mark Cave-Ayland By default quirk_mode_sense_rom_use_dbd should be enabled for all scsi-cd devices connected to the q800 machine to correctly report the CDROM block descriptor back to A/UX. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20220622105314.802852-6

[PULL 07/20] scsi-disk: add MODE_PAGE_APPLE_VENDOR quirk for Macintosh

2022-07-14 Thread Paolo Bonzini
From: Mark Cave-Ayland One of the mechanisms MacOS uses to identify CDROM drives compatible with MacOS is to send a custom MODE SELECT command for page 0x30 to the drive. The response to this is a hard-coded manufacturer string which must match in order for the CDROM to be usable within MacOS. A

[PULL 11/20] scsi-disk: add SCSI_DISK_QUIRK_MODE_PAGE_VENDOR_SPECIFIC_APPLE quirk for Macintosh

2022-07-14 Thread Paolo Bonzini
From: Mark Cave-Ayland Both MacOS and A/UX make use of vendor-specific MODE SELECT commands with PF=0 to identify SCSI devices: - MacOS sends a MODE SELECT command with PF=0 for the MODE_PAGE_VENDOR_SPECIFIC (0x0) mode page containing 2 bytes before initialising a disk - A/UX (installed on di

[PULL 00/20] SCSI, build system patches for 2022-07-13

2022-07-14 Thread Paolo Bonzini
The following changes since commit 8e3d85d36b77f11ad7bded3a2d48c1f0cc334f82: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2022-07-12 14:12:15 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetch c

[PULL 08/20] q800: implement compat_props to enable quirk_mode_page_apple_vendor for scsi-cd devices

2022-07-14 Thread Paolo Bonzini
From: Mark Cave-Ayland By default quirk_mode_page_apple_vendor should be enabled for all scsi-cd devices connected to the q800 machine to enable MacOS to detect and use them. Signed-off-by: Mark Cave-Ayland Message-Id: <20220622105314.802852-4-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Paol

[PULL 02/20] cutils: Introduce bundle mechanism

2022-07-14 Thread Paolo Bonzini
From: Akihiko Odaki Developers often run QEMU without installing. The bundle mechanism allows to look up files which should be present in installation even in such a situation. It is a general mechanism and can find any files in the installation tree. The build tree will have a new directory, qe

[PULL 03/20] datadir: Use bundle mechanism

2022-07-14 Thread Paolo Bonzini
From: Akihiko Odaki softmmu/datadir.c had its own implementation to find files in the build tree, but now bundle mechanism provides the unified implementation which works for datadir and the other files. Signed-off-by: Akihiko Odaki Message-Id: <20220624145039.49929-4-akihiko.od...@gmail.com> S

[PULL 05/20] meson: Prefix each element of firmware path

2022-07-14 Thread Paolo Bonzini
From: Akihiko Odaki Signed-off-by: Akihiko Odaki Message-Id: <20220624154042.51512-1-akihiko.od...@gmail.com> [Rewrite shell function without using Bash extensions. - Paolo] Signed-off-by: Paolo Bonzini --- configure | 15 +++ meson.build | 11

[PULL 01/20] scsi/lsi53c895a: really fix use-after-free in lsi_do_msgout (CVE-2022-0216)

2022-07-14 Thread Paolo Bonzini
From: Mauro Matteo Cascella Set current_req to NULL, not current_req->req, to prevent reusing a free'd buffer in case of repeated SCSI cancel requests. Also apply the fix to CLEAR QUEUE and BUS DEVICE RESET messages as well, since they also cancel the request. Thanks to Alexander Bulekov for pr

Re: [RFC v3 4/8] block: add BDRV_REQ_REGISTERED_BUF request flag

2022-07-14 Thread Hanna Reitz
On 08.07.22 06:17, Stefan Hajnoczi wrote: Block drivers may optimize I/O requests accessing buffers previously registered with bdrv_register_buf(). Checking whether all elements of a request's QEMUIOVector are within previously registered buffers is expensive, so we need a hint from the user to a

Re: [PULL 00/12] MIPS patches for 2022-07-12

2022-07-14 Thread Peter Maydell
On Tue, 12 Jul 2022 at 21:56, Philippe Mathieu-Daudé via wrote: > > The following changes since commit 8e3d85d36b77f11ad7bded3a2d48c1f0cc334f82: > > Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging > (2022-07-12 14:12:15 +0100) > > are available in the Git repository at:

Re: [PATCH v2] target/i386: Restore TSX features with taa-no

2022-07-14 Thread Paolo Bonzini
On 7/14/22 07:36, Zhenzhong Duan wrote: On ICX-2S2 host, when run L2 guest with both L1/L2 using Icelake-Server-v3 or above, we got below warning: "warning: host doesn't support requested feature: MSR(10AH).taa-no [bit 8]" This is because L1 KVM doesn't expose taa-no to L2 if RTM is disabled, t

Re: [RFC PATCH v9 20/23] vdpa: Buffer CVQ support on shadow virtqueue

2022-07-14 Thread Jason Wang
On Thu, Jul 14, 2022 at 2:54 PM Eugenio Perez Martin wrote: > > > > > +static void vhost_vdpa_net_handle_ctrl_used(VhostShadowVirtqueue *svq, > > > > +void *vq_elem_opaque, > > > > +uint32_t dev_written) > > >

<    1   2   3