Re: [PATCH v4 04/17] dump: Rework get_start_block

2022-07-28 Thread Steffen Eiden
On 7/26/22 11:22, Janosch Frank wrote: get_start_block() returns the start address of the first memory block or -1. With the GuestPhysBlock iterator conversion we don't need to set the start address and can therefore remove that code. The only functionality left is the validation of the start

Re: [PATCH v4 01/17] dump: Rename write_elf_loads to write_elf_phdr_loads

2022-07-28 Thread Steffen Eiden
On 7/26/22 11:22, Janosch Frank wrote: Let's make it a bit clearer that we write the program headers of the PT_LOAD type. Signed-off-by: Janosch Frank Reviewed-by: Marc-André Lureau Reviewed-by: Steffen Eiden --- dump/dump.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH v2] ci: Upgrade msys2 release to 20220603

2022-07-28 Thread Bin Meng
On Fri, Jul 29, 2022 at 4:04 AM Yonggang Luo wrote: > > Signed-off-by: Yonggang Luo > --- > .cirrus.yml | 2 +- > .gitlab-ci.d/windows.yml | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH 08/16] vhost: add op to enable or disable a single vring

2022-07-28 Thread Kangjie Xu
在 2022/7/28 10:41, Jason Wang 写道: On Wed, Jul 27, 2022 at 3:05 PM Kangjie Xu wrote: 在 2022/7/27 12:55, Jason Wang 写道: On Tue, Jul 26, 2022 at 2:39 PM Kangjie Xu wrote: 在 2022/7/26 11:49, Jason Wang 写道: 在 2022/7/18 19:17, Kangjie Xu 写道: The interface to set enable status for a single vri

Re: [PATCH 5/6] hw/loongarch: Add acpi ged support

2022-07-28 Thread gaosong
On 2022/7/28 下午10:03, Igor Mammedov wrote: On Tue, 12 Jul 2022 16:32:05 +0800 Xiaojuan Yang wrote: Loongarch virt machine uses general hardware reduces acpi method, rather than LS7A acpi device. Now only power management function is used in acpi ged device, memory hotplug will be added later

Re: [PULL 0/3] ppc queue

2022-07-28 Thread Richard Henderson
https://gitlab.com/danielhb/qemu.git pull-ppc-20220728 for you to fetch changes up to 0c9717ff35d2fe46fa9cb91566fe2afbed9f4f2a: target/ppc: Implement new wait variants (2022-07-28 13:30:41 -0300) ppc patch queue for 2022-07-

Re: [RFC 0/3] Add Generic SPI GPIO model

2022-07-28 Thread Peter Delevoryas
On Thu, Jul 28, 2022 at 04:23:19PM -0700, Iris Chen wrote: > Hey everyone, > > I have been working on a project to add support for SPI-based TPMs in QEMU. > Currently, most of our vboot platforms using a SPI-based TPM use the Linux > SPI-GPIO driver to "bit-bang" the SPI protocol. This is because

RE: [PATCH] configure: pass correct cflags to container-based cross compilers

2022-07-28 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Thursday, July 28, 2022 5:11 PM > To: Paolo Bonzini ; qemu-devel@nongnu.org > Cc: Taylor Simpson > Subject: Re: [PATCH] configure: pass correct cflags to container-based cross > compilers > > On 7/28/22 15:22, Paolo Bonzini wrote:

[python-qemu-qmp MR #13] Sphinx: improve version detection for SDists

2022-07-28 Thread GitLab Bot
Author: John Snow - https://gitlab.com/jsnow Merge Request: https://gitlab.com/qemu-project/python-qemu-qmp/-/merge_requests/13 ... from: jsnow/python-qemu-qmp:doc-version-fix ... into: qemu-project/python-qemu-qmp:main When building docs from SDist files, we won't have git metadata available. Us

[RFC 2/3] hw: spi_gpio: add spi gpio model

2022-07-28 Thread Iris Chen
Signed-off-by: Iris Chen --- hw/ssi/spi_gpio.c | 166 ++ include/hw/ssi/spi_gpio.h | 38 + 2 files changed, 204 insertions(+) create mode 100644 hw/ssi/spi_gpio.c create mode 100644 include/hw/ssi/spi_gpio.h diff --git a/hw/ssi/spi_gpio.c b/

[RFC 1/3] hw: m25p80: add prereading ability in transfer8

2022-07-28 Thread Iris Chen
With SPI-GPIO we don't have the input bits until all 8 bits of the output have been shifted out, so we have to prime the MISO with bogus values (0xFF). Signed-off-by: Iris Chen --- hw/block/m25p80.c| 29 - hw/ssi/ssi.c | 4 include/hw/ssi/ssi.h | 5

[RFC 0/3] Add Generic SPI GPIO model

2022-07-28 Thread Iris Chen
Hey everyone, I have been working on a project to add support for SPI-based TPMs in QEMU. Currently, most of our vboot platforms using a SPI-based TPM use the Linux SPI-GPIO driver to "bit-bang" the SPI protocol. This is because the Aspeed SPI controller (modeled in QEMU under hw/ssi/aspeed_smc.

Re: [PATCH] configure: pass correct cflags to container-based cross compilers

2022-07-28 Thread Richard Henderson
On 7/28/22 15:22, Paolo Bonzini wrote: probe_target_compiler returns nonempty $target_cc for installed toolchains and $container_cross_cc for container-based toolchains. In both cases however the flags (coming from $cross_cc_cflags_${target_arch}) must be in $target_cflags. Therefore, do not cl

[PATCH] configure: pass correct cflags to container-based cross compilers

2022-07-28 Thread Paolo Bonzini
probe_target_compiler returns nonempty $target_cc for installed toolchains and $container_cross_cc for container-based toolchains. In both cases however the flags (coming from $cross_cc_cflags_${target_arch}) must be in $target_cflags. Therefore, do not clear them prior to returning from probe_ta

Re: [PATCH] Hexagon (tests/tcg/hexagon) add compiler options to EXTRA_CFLAGS

2022-07-28 Thread Paolo Bonzini
On 7/26/22 21:17, Taylor Simpson wrote: The cross_cc_cflags_hexagon in configure are not getting passed to the Hexagon cross compiler. Set EXTRA_CFLAGS in tests/tcg/hexagon/Makefile.target. Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson --- The bug applies to all targets, I am

Re: Question to mem-path support at QEMU for Xen

2022-07-28 Thread Stefano Stabellini
On Thu, 28 Jul 2022, Igor Mammedov wrote: > On Thu, 28 Jul 2022 15:17:49 +0800 > Huang Rui wrote: > > > Hi Igor, > > > > Appreciate you for the reply! > > > > On Wed, Jul 27, 2022 at 04:19:30PM +0800, Igor Mammedov wrote: > > > On Tue, 26 Jul 2022 15:27:07 +0800 > > > Huang Rui wrote: > > >

Re: [PATCH for-7.1?] kvm: don't use perror() without useful errno

2022-07-28 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH] configure: Fix ppc container_cross_cc substitution

2022-07-28 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH] ppc: Remove redundant macro MSR_BOOK3S_MASK.

2022-07-28 Thread Daniel Henrique Barboza
On 7/28/22 17:11, Yonggang Luo wrote: Signed-off-by: Yonggang Luo --- target/ppc/excp_helper.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c index cb752b184a..7550aafed6 100644 --- a/target/ppc/excp_helper.c +++ b/target/ppc/excp_hel

Re: [PULL 0/3] ppc queue

2022-07-28 Thread Daniel Henrique Barboza
On 7/28/22 17:18, Richard Henderson wrote: On 7/28/22 09:55, Daniel Henrique Barboza wrote:    https://gitlab.com/danielhb/qemu.git  pull-ppc-20220728 fatal: couldn't find remote ref pull-ppc-20220728 Did you forget to push the tag to gitlab? I guess I mistyped the credentials

Re: [PATCH] Hexagon (tests/tcg/hexagon) add compiler options to EXTRA_CFLAGS

2022-07-28 Thread Richard Henderson
On 7/26/22 12:17, Taylor Simpson wrote: The cross_cc_cflags_hexagon in configure are not getting passed to the Hexagon cross compiler. Set EXTRA_CFLAGS in tests/tcg/hexagon/Makefile.target. Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson --- tests/tcg/hexagon/Makefile.target |

Re: [PULL 0/3] ppc queue

2022-07-28 Thread Richard Henderson
On 7/28/22 09:55, Daniel Henrique Barboza wrote: https://gitlab.com/danielhb/qemu.git pull-ppc-20220728 fatal: couldn't find remote ref pull-ppc-20220728 Did you forget to push the tag to gitlab? r~

[PATCH] ppc: Remove redundant macro MSR_BOOK3S_MASK.

2022-07-28 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- target/ppc/excp_helper.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c index cb752b184a..7550aafed6 100644 --- a/target/ppc/excp_helper.c +++ b/target/ppc/excp_helper.c @@ -2015,7 +2015,6 @@ void helper_rfi(C

Re: [PATCH 1/1] block: add missed block_acct_setup with new block device init procedure

2022-07-28 Thread Denis V. Lunev
On 28.07.2022 16:42, Vladimir Sementsov-Ogievskiy wrote: On 7/11/22 14:07, Denis V. Lunev wrote: Commit 5f76a7aac156ca75680dad5df4a385fd0b58f6b1 is looking harmless from the first glance, but it has changed things a lot. 'libvirt' uses it to detect that it should follow new initialization way an

Re: [PATCH for-7.1] hw/mips/malta: turn off x86 specific features of PIIX4_PM

2022-07-28 Thread Ani Sinha
On Thu, 28 Jul 2022, Peter Maydell wrote: > On Thu, 28 Jul 2022 at 12:50, Igor Mammedov wrote: > > > > QEMU crashes trying to save VMSTATE when only MIPS target are compiled in > > $ qemu-system-mips -monitor stdio > > (qemu) migrate "exec:gzip -c > STATEFILE.gz" > > Segmentation fault (

Re: [PATCH for-7.1] hw/mips/malta: turn off x86 specific features of PIIX4_PM

2022-07-28 Thread Ani Sinha
On Thu, 28 Jul 2022, Peter Maydell wrote: > On Thu, 28 Jul 2022 at 15:44, Dr. David Alan Gilbert > wrote: > > Isn't the problem partially due to a 'stub' vmsd which isn't terminated? > > Yes, but setting these properties causes that vmsd > (vmstate_acpi_pcihp_pci_status) to not be used: > >

[PATCH] configure: Fix ppc container_cross_cc substitution

2022-07-28 Thread Richard Henderson
When moving this code out of probe_target_compiler(), we failed to adjust the variable in which the target is located, resulting in e.g. powerpc64-linux-user-linux-gnu-gcc-10 Fixes: cd362defbbd ("tests/tcg: merge configure.sh back into main configure script") Signed-off-by: Richard Henderson ---

Re: [PULL 0/2] riscv-to-apply queue

2022-07-28 Thread Richard Henderson
tags/pull-riscv-to-apply-20220728 for you to fetch changes up to 54f218363052be210e77d2ada8c0c1e51b3ad6cd: hw/intc: sifive_plic: Fix multi-socket plic configuraiton (2022-07-28 09:08:44 +1000) Sixth RISC-V PR for QEMU 7.1 This

[PATCH] hw/riscv: remove 'fdt' param from riscv_setup_rom_reset_vec()

2022-07-28 Thread Daniel Henrique Barboza
The 'fdt' param is not being used in riscv_setup_rom_reset_vec(). Simplify the API by removing it. While we're at it, remove the redundant 'return' statement at the end of function. Cc: Palmer Dabbelt Cc: Alistair Francis Cc: Bin Meng Cc: Vijai Kumar K Signed-off-by: Daniel Henrique Barboza -

Re: [RFC 0/2] Fix Coverity and other errors in ppc440_uc DMA

2022-07-28 Thread BALATON Zoltan
On Tue, 26 Jul 2022, Peter Maydell wrote: This patchset is mainly trying to fix a problem that Coverity spotted in the dcr_write_dma() function in hw/ppc/ppc440_uc.c, where the code is not correctly using the cpu_physical_memory_map() function. While I was fixing that I noticed a second problem i

Re: [PATCH] linux-user: Do not treat madvise()'s advice as a bitmask

2022-07-28 Thread Laurent Vivier
Le 25/07/2022 à 15:41, Ilya Leoshkevich a écrit : Advice is enum, not flags. Doing (advice & MADV_DONTNEED) also matches e.g. MADV_MERGEABLE. Signed-off-by: Ilya Leoshkevich --- linux-user/mmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/mmap.c b/linux-us

Re: [PATCH for-7.1] linux-user/flatload.c: Fix setting of image_info::end_code

2022-07-28 Thread Laurent Vivier
Le 28/07/2022 à 17:14, Peter Maydell a écrit : The flatload loader sets the end_code field in the image_info struct incorrectly, due to a typo. This is a very long-standing bug (dating all the way back to when the bFLT loader was added in 2006), but has gone unnoticed because (a) most people don

Re: [PATCH for-7.1?] kvm: don't use perror() without useful errno

2022-07-28 Thread Richard Henderson
On 7/28/22 07:24, Cornelia Huck wrote: perror() is designed to append the decoded errno value to a string. This, however, only makes sense if we called something that actually sets errno prior to that. For the callers that check for split irqchip support that is not the case, and we end up with

Re: [PATCH for-7.1] linux-user/flatload.c: Fix setting of image_info::end_code

2022-07-28 Thread Richard Henderson
On 7/28/22 08:14, Peter Maydell wrote: The flatload loader sets the end_code field in the image_info struct incorrectly, due to a typo. This is a very long-standing bug (dating all the way back to when the bFLT loader was added in 2006), but has gone unnoticed because (a) most people don't use b

Re: [PATCH v5 5/8] blockdev: Add a new IF type IF_OTHER

2022-07-28 Thread Kevin Wolf
Am 28.07.2022 um 16:50 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 28.07.2022 um 11:46 hat Peter Maydell geschrieben: > >> On Wed, 27 Jul 2022 at 20:03, Kevin Wolf wrote: > >> > > >> > Am 18.07.2022 um 11:49 hat Markus Armbruster geschrieben: > >> > > An OTP device isn't rea

[ANNOUNCE] QEMU 7.1.0-rc0 is now available

2022-07-28 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 7.1 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-7.1.0-rc0.tar.xz http://downlo

[PULL 2/3] hw/ppc/ppc440_uc: Initialize length passed to cpu_physical_memory_map()

2022-07-28 Thread Daniel Henrique Barboza
From: Peter Maydell In dcr_write_dma(), there is code that uses cpu_physical_memory_map() to implement a DMA transfer. That function takes a 'plen' argument, which points to a hwaddr which is used for both input and output: the caller must set it to the size of the range it wants to map, and on

[PULL 3/3] target/ppc: Implement new wait variants

2022-07-28 Thread Daniel Henrique Barboza
From: Nicholas Piggin ISA v2.06 adds new variations of wait, specified by the WC field. These are not all compatible with the prior wait implementation, because they add additional conditions that cause the processor to resume, which can cause software to hang or run very slowly. At this moment,

[PULL 1/3] hw/ppc: check if spapr_drc_index() returns NULL in spapr_nvdimm.c

2022-07-28 Thread Daniel Henrique Barboza
spapr_nvdimm_flush_completion_cb() and flush_worker_cb() are using the DRC object returned by spapr_drc_index() without checking it for NULL. In this case we would be dereferencing a NULL pointer when doing SPAPR_NVDIMM(drc->dev) and PC_DIMM(drc->dev). This can happen if, during a scm_flush(), the

[PULL 0/3] ppc queue

2022-07-28 Thread Daniel Henrique Barboza
The following changes since commit 3e4abe2c92964aadd35344a635b0f32cb487fd5c: Merge tag 'pull-block-2022-07-27' of https://gitlab.com/vsementsov/qemu into staging (2022-07-27 20:10:15 -0700) are available in the Git repository at: https://gitlab.com/danielhb/qemu.git pull-ppc-202

Re: [RFC patch 0/1] block: vhost-blk backend

2022-07-28 Thread Stefano Garzarella
On Thu, Jul 28, 2022 at 7:28 AM Andrey Zhadchenko wrote: > On 7/27/22 16:06, Stefano Garzarella wrote: > > On Tue, Jul 26, 2022 at 04:15:48PM +0200, Denis V. Lunev wrote: > >> On 26.07.2022 15:51, Michael S. Tsirkin wrote: > >>> On Mon, Jul 25, 2022 at 11:55:26PM +0300, Andrey Zhadchenko wrote: >

Re: [RFC] hw/nvme: Use irqfd to send interrupts

2022-07-28 Thread Jinhao Fan
at 11:18 PM, Stefan Hajnoczi wrote: > I think that is incorrect. QEMU has guest notifier emulation for the > non-KVM (and non-MSI-X PCI) cases. When there is no irqfd support > available, QEMU sets up a regular eventfd and calls > virtio_queue_guest_notifier_read() when it becomes readable. Than

Re: [RFC] hw/nvme: Use irqfd to send interrupts

2022-07-28 Thread Stefan Hajnoczi
On Thu, Jul 28, 2022, 11:34 Jinhao Fan wrote: > at 11:18 PM, Stefan Hajnoczi wrote: > > > I think that is incorrect. QEMU has guest notifier emulation for the > > non-KVM (and non-MSI-X PCI) cases. When there is no irqfd support > > available, QEMU sets up a regular eventfd and calls > > virtio_

Re: [PATCH for-7.1 0/3] hw/nvme: misc ioeventfd fixes

2022-07-28 Thread Keith Busch
On Thu, Jul 28, 2022 at 10:25:19AM +0200, Klaus Jensen wrote: > From: Klaus Jensen > > A set of fixes/changes to the ioeventfd support. Series looks good. Reviewed-by: Keith Busch

Re: [PATCH for-7.1 0/3] hw/nvme: misc ioeventfd fixes

2022-07-28 Thread Jinhao Fan
at 4:25 PM, Klaus Jensen wrote: > From: Klaus Jensen > > A set of fixes/changes to the ioeventfd support. > > Klaus Jensen (3): > hw/nvme: skip queue processing if notifier is cleared > hw/nvme: unregister the event notifier handler on the main loop > hw/nvme: do not enable ioeventfd by def

Re: [PATCH v2 5/7] multifd: establishing connection between any non-default src and dest pair

2022-07-28 Thread Het Gala
On 26/07/22 4:14 pm, Daniel P. Berrangé wrote: In $SUBJECT s/multifd:/io:/ as this is not migration related. On Thu, Jul 21, 2022 at 07:56:18PM +, Het Gala wrote: i) Binding of the socket to source ip address and port on the non-default interface has been implemented for multi-FD

Re: [PATCH for-7.1] hw/mips/malta: turn off x86 specific features of PIIX4_PM

2022-07-28 Thread Peter Maydell
On Thu, 28 Jul 2022 at 15:44, Dr. David Alan Gilbert wrote: > > * Igor Mammedov (imamm...@redhat.com) wrote: > > QEMU crashes trying to save VMSTATE when only MIPS target are compiled in > > $ qemu-system-mips -monitor stdio > > (qemu) migrate "exec:gzip -c > STATEFILE.gz" > > Segmentation f

Re: [PATCH v3 0/2] migration-test: Allow test to run without uffd

2022-07-28 Thread Peter Xu
On Thu, Jul 28, 2022 at 04:44:49PM +0200, Thomas Huth wrote: > On 28/07/2022 15.35, Peter Xu wrote: > > v2: > > - Fix warning in patch 1 [Thomas] > > - Collected R-b for Daniel > > > > Compare to v1, this added a new patch as reported by Thomas to (hopefully) > > allow auto-converge test to pass o

Re: [PATCH for-7.1] hw/mips/malta: turn off x86 specific features of PIIX4_PM

2022-07-28 Thread Peter Maydell
On Thu, 28 Jul 2022 at 16:09, Dr. David Alan Gilbert wrote: > > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Thu, 28 Jul 2022 15:44:20 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > > QEMU crashes trying to save VMSTATE when only MIPS

[PATCH for-7.1] linux-user/flatload.c: Fix setting of image_info::end_code

2022-07-28 Thread Peter Maydell
The flatload loader sets the end_code field in the image_info struct incorrectly, due to a typo. This is a very long-standing bug (dating all the way back to when the bFLT loader was added in 2006), but has gone unnoticed because (a) most people don't use bFLT binaries (b) we don't actually do any

Re: [PATCH for-7.1] hw/mips/malta: turn off x86 specific features of PIIX4_PM

2022-07-28 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Thu, 28 Jul 2022 15:44:20 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > QEMU crashes trying to save VMSTATE when only MIPS target are compiled in > > > $ qemu-system-mips -monitor stdio > > >

Re: [PATCH v2 2/7] multifd: modifying 'migrate' qmp command to add multifd socket on particular src and dest pair

2022-07-28 Thread Het Gala
On 26/07/22 4:43 pm, Daniel P. Berrangé wrote: On Thu, Jul 21, 2022 at 07:56:15PM +, Het Gala wrote: i) Modified the format of the qemu monitor command : 'migrate' by adding a list, each element in the list consisting of multifd connection parameters: source uri, destination uri an

Re: [PATCH v2 3/7] multifd: adding multi-interface support for multifd on destination side

2022-07-28 Thread Het Gala
On 26/07/22 4:50 pm, Daniel P. Berrangé wrote: On Thu, Jul 21, 2022 at 07:56:16PM +, Het Gala wrote: i) Modified the format of qemu monitor command: 'migrate-incoming' by adding a list, each element in the list to open socket listeners with a given number of multifd channels. ii)

Re: [PATCH v5 5/8] blockdev: Add a new IF type IF_OTHER

2022-07-28 Thread Peter Maydell
On Thu, 28 Jul 2022 at 15:50, Markus Armbruster wrote: > Kevin Wolf writes: > > > > But if you have more than one device, it becomes hard to predict which > > device gets which backend - it depends on the initialisation order in > > the code then, > > Really? Board code should use IF_OTHER devic

Re: [PATCH for-7.1] hw/mips/malta: turn off x86 specific features of PIIX4_PM

2022-07-28 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > QEMU crashes trying to save VMSTATE when only MIPS target are compiled in > $ qemu-system-mips -monitor stdio > (qemu) migrate "exec:gzip -c > STATEFILE.gz" > Segmentation fault (core dumped) > > It happens due to PIIX4_PM trying to parse hotplu

Re: [PATCH for-7.1] hw/mips/malta: turn off x86 specific features of PIIX4_PM

2022-07-28 Thread Igor Mammedov
On Thu, 28 Jul 2022 15:44:20 +0100 "Dr. David Alan Gilbert" wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > QEMU crashes trying to save VMSTATE when only MIPS target are compiled in > > $ qemu-system-mips -monitor stdio > > (qemu) migrate "exec:gzip -c > STATEFILE.gz" > > Segmenta

Re: [QEMU PATCH v2 4/6] nvdimm: Implement ACPI NVDIMM Label Methods

2022-07-28 Thread Igor Mammedov
On Wed, 27 Jul 2022 13:22:34 +0800 Robert Hoo wrote: > On Thu, 2022-07-21 at 10:58 +0200, Igor Mammedov wrote: > [...] > Thanks Igor for review. > > > > The patch it is too intrusive and my hunch is that it breaks > > > > ABI and needs a bunch of compat knobs to work properly and > > > > that I'd

Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used

2022-07-28 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Jul 28, 2022 at 02:40:22PM +0100, Peter Maydell wrote: >> On Thu, 28 Jul 2022 at 14:30, Markus Armbruster wrote: >> > Peter Maydell writes: >> > I applaud the renaissance of roman-style inscriptions, but it's not just >> > words without spaces, it's also cap

Re: [PATCH v5 5/8] blockdev: Add a new IF type IF_OTHER

2022-07-28 Thread Markus Armbruster
Kevin Wolf writes: > Am 28.07.2022 um 11:46 hat Peter Maydell geschrieben: >> On Wed, 27 Jul 2022 at 20:03, Kevin Wolf wrote: >> > >> > Am 18.07.2022 um 11:49 hat Markus Armbruster geschrieben: >> > > An OTP device isn't really a parallel flash, and neither are eFuses. >> > > More fast-and-lose

Re: [PATCH v3 0/2] migration-test: Allow test to run without uffd

2022-07-28 Thread Thomas Huth
On 28/07/2022 15.35, Peter Xu wrote: v2: - Fix warning in patch 1 [Thomas] - Collected R-b for Daniel Compare to v1, this added a new patch as reported by Thomas to (hopefully) allow auto-converge test to pass on some MacOS testbeds. Please review, thanks. Peter Xu (2): migration-test: Use

Re: [PATCH 1/1] block: add missed block_acct_setup with new block device init procedure

2022-07-28 Thread Vladimir Sementsov-Ogievskiy
On 7/11/22 14:07, Denis V. Lunev wrote: Commit 5f76a7aac156ca75680dad5df4a385fd0b58f6b1 is looking harmless from the first glance, but it has changed things a lot. 'libvirt' uses it to detect that it should follow new initialization way and this changes things considerably. With this procedure fo

[PATCH for-7.1?] kvm: don't use perror() without useful errno

2022-07-28 Thread Cornelia Huck
perror() is designed to append the decoded errno value to a string. This, however, only makes sense if we called something that actually sets errno prior to that. For the callers that check for split irqchip support that is not the case, and we end up with confusing error messages that end in "suc

Re: [PATCH 3/3] dump: support cancel dump process

2022-07-28 Thread Kevin Wolf
Am 28.07.2022 um 14:37 hat Marc-André Lureau geschrieben: > Hi > > On Wed, Jul 27, 2022 at 6:02 PM Hogan Wang via > wrote: > > > Break saving pages or dump iterate when dump job in cancel state, > > make sure dump process exits as soon as possible. > > > > Signed-off-by: Hogan Wang > > > > Ove

Re: Question to mem-path support at QEMU for Xen

2022-07-28 Thread Igor Mammedov
On Thu, 28 Jul 2022 15:17:49 +0800 Huang Rui wrote: > Hi Igor, > > Appreciate you for the reply! > > On Wed, Jul 27, 2022 at 04:19:30PM +0800, Igor Mammedov wrote: > > On Tue, 26 Jul 2022 15:27:07 +0800 > > Huang Rui wrote: > > > > > Hi Anthony and other Qemu/Xen guys, > > > > > > We are t

Re: [PATCH 5/6] hw/loongarch: Add acpi ged support

2022-07-28 Thread Igor Mammedov
On Tue, 12 Jul 2022 16:32:05 +0800 Xiaojuan Yang wrote: > Loongarch virt machine uses general hardware reduces acpi method, rather > than LS7A acpi device. Now only power management function is used in > acpi ged device, memory hotplug will be added later. Also acpi tables > such as RSDP/RSDT/FAD

Re: [PATCH v5 5/8] blockdev: Add a new IF type IF_OTHER

2022-07-28 Thread Cédric Le Goater
On 7/28/22 15:29, Kevin Wolf wrote: Am 28.07.2022 um 11:46 hat Peter Maydell geschrieben: On Wed, 27 Jul 2022 at 20:03, Kevin Wolf wrote: Am 18.07.2022 um 11:49 hat Markus Armbruster geschrieben: An OTP device isn't really a parallel flash, and neither are eFuses. More fast-and-lose use of I

[PATCH v2 1/4] hw/virtio: incorporate backend features in features

2022-07-28 Thread Alex Bennée
There are some extra bits used over a vhost-user connection which are hidden from the device itself. We need to set them here to ensure we enable things like the protocol extensions. Currently net/vhost-user.c has it's own inscrutable way of persisting this data but it really should live in the co

[PATCH v2 2/4] hw/virtio: gracefully handle unset vhost_dev vdev

2022-07-28 Thread Alex Bennée
I've noticed asserts firing because we query the status of vdev after a vhost connection is closed down. Rather than faulting on the NULL indirect just quietly reply false. Signed-off-by: Alex Bennée Message-Id: <20220726192150.2435175-8-alex.ben...@linaro.org> --- hw/virtio/vhost.c | 10 +++

[PATCH v2 4/4] hw/virtio: fix vhost_user_read tracepoint

2022-07-28 Thread Alex Bennée
As reads happen in the callback we were never seeing them. We only really care about the header so move the tracepoint to when the header is complete. Fixes: 6ca6d8ee9d (hw/virtio: add vhost_user_[read|write] trace points) Signed-off-by: Alex Bennée Acked-by: Jason Wang Message-Id: <202207261921

[PATCH for 7.1 v2 0/4] virtio fixes (split from virtio-gpio series)

2022-07-28 Thread Alex Bennée
Hi, This is just a split out series based on: Subject: [PATCH v3 for 7.2 00/21] virtio-gpio and various virtio cleanups Date: Tue, 26 Jul 2022 20:21:29 +0100 Message-Id: <20220726192150.2435175-1-alex.ben...@linaro.org> with the patches identified by mst: Right. Still I think some ar

Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used

2022-07-28 Thread Daniel P . Berrangé
On Thu, Jul 28, 2022 at 02:40:22PM +0100, Peter Maydell wrote: > On Thu, 28 Jul 2022 at 14:30, Markus Armbruster wrote: > > Peter Maydell writes: > > I applaud the renaissance of roman-style inscriptions, but it's not just > > words without spaces, it's also capital letters only: > > > > ANY6

Re: virtio: why no full reset on virtio_set_status 0 ?

2022-07-28 Thread Michael S. Tsirkin
On Thu, Jul 28, 2022 at 11:09:15AM +0200, Claudio Fontana wrote: > On 7/28/22 09:43, Claudio Fontana wrote: > > On 7/28/22 03:27, Jason Wang wrote: > >> On Wed, Jul 27, 2022 at 11:32 PM Michael S. Tsirkin > >> wrote: > >>> > >>> On Wed, Jul 27, 2022 at 12:51:31PM +0200, Claudio Fontana wrote: > >

Re: [PATCH v5 5/8] blockdev: Add a new IF type IF_OTHER

2022-07-28 Thread Peter Maydell
On Thu, 28 Jul 2022 at 14:30, Kevin Wolf wrote: > > Am 28.07.2022 um 11:46 hat Peter Maydell geschrieben: > > On Wed, 27 Jul 2022 at 20:03, Kevin Wolf wrote: > > > If the existing types aren't good enough (I don't have an opinion on > > > whether IF_PFLASH is a good match), let's add a new one. B

[PATCH v2 3/4] hw/virtio: handle un-configured shutdown in virtio-pci

2022-07-28 Thread Alex Bennée
The assert() protecting against leakage is a little aggressive and causes needless crashes if a device is shutdown without having been configured. In this case no descriptors are lost because none have been assigned. Signed-off-by: Alex Bennée Message-Id: <20220726192150.2435175-9-alex.ben...@lin

[PATCH for-7.1] tests: acpi: silence applesmc warning about invalid key

2022-07-28 Thread Igor Mammedov
OSK value is irrelevant for ACPI test case. Supply fake OSK explicitly to prevent QEMU complaining about invalid key when it fallbacks to default_osk. Suggested-by: Daniel P. Berrangé Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test.c | 4 +++- 1 file changed, 3 insertions(+), 1 de

Re: [PATCH for-7.2] hw: Add compat machines for 7.2

2022-07-28 Thread Michael S. Tsirkin
On Wed, Jul 27, 2022 at 02:17:55PM +0200, Cornelia Huck wrote: > Add 7.2 machine types for arm/i440fx/m68k/q35/s390x/spapr. > > Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin whoever needs this first, feel free to merge. > --- > hw/arm/virt.c | 9 - > hw/c

Re: [PATCH v4 11/17] dump/dump: Add section string table support

2022-07-28 Thread Marc-André Lureau
Hi On Tue, Jul 26, 2022 at 6:26 PM Janosch Frank wrote: > On 7/26/22 15:12, Marc-André Lureau wrote: > > On Tue, Jul 26, 2022 at 4:55 PM Janosch Frank > wrote: > > > >> On 7/26/22 13:25, Marc-André Lureau wrote: > >>> Hi > >>> > >>> On Tue, Jul 26, 2022 at 1:23 PM Janosch Frank > >> wrote: > >

[PATCH v3 1/2] migration-test: Use migrate_ensure_converge() for auto-converge

2022-07-28 Thread Peter Xu
Thomas reported that auto-converge test will timeout on MacOS CI gatings. Use the migrate_ensure_converge() helper too in the auto-converge as when Daniel reworked the other test cases. Since both max_bandwidth / downtime_limit will not be used for converge calculations, make it simple by removing

[PATCH] vga: fix incorrect line height in 640x200x2 mode

2022-07-28 Thread Paolo Bonzini
When in CGA modes, QEMU wants to ignore the maximum scan field (bits 0..4) of the maximum scan length register in the CRTC. It is not clear why this is needed---for example, Bochs ignores bit 7 instead. The issue is that the CGA modes are not detected correctly, and in particular mode 6 results i

Re: [PATCH for-7.1] tests: acpi: silence applesmc warning about invalid key

2022-07-28 Thread Daniel P . Berrangé
On Thu, Jul 28, 2022 at 09:37:13AM -0400, Igor Mammedov wrote: > OSK value is irrelevant for ACPI test case. > Supply fake OSK explicitly to prevent QEMU complaining about > invalid key when it fallbacks to default_osk. > > Suggested-by: Daniel P. Berrangé > Signed-off-by: Igor Mammedov > --- >

[PATCH v3 0/2] migration-test: Allow test to run without uffd

2022-07-28 Thread Peter Xu
v2: - Fix warning in patch 1 [Thomas] - Collected R-b for Daniel Compare to v1, this added a new patch as reported by Thomas to (hopefully) allow auto-converge test to pass on some MacOS testbeds. Please review, thanks. Peter Xu (2): migration-test: Use migrate_ensure_converge() for auto-conve

Re: [PATCH 4/5] util/qemu-sockets: Enable unix socket support on Windows

2022-07-28 Thread Bin Meng
On Thu, Jul 28, 2022 at 9:11 PM Marc-André Lureau wrote: > > Hi > > On Wed, Jul 27, 2022 at 2:05 PM Bin Meng wrote: >> >> On Wed, Jul 27, 2022 at 4:53 PM Konstantin Kostiuk >> wrote: >> > >> > >> > >> > >> > >> > On Wed, Jul 27, 2022 at 10:47 AM Bin Meng wrote: >> >> >> >> From: Bin Meng >> >

Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used

2022-07-28 Thread Igor Mammedov
On Thu, 28 Jul 2022 15:29:58 +0200 Markus Armbruster wrote: > Peter Maydell writes: > > > On Thu, 28 Jul 2022 at 11:23, Daniel P. Berrangé > > wrote: > >> > >> On Thu, Jul 28, 2022 at 11:05:13AM +0100, Peter Maydell wrote: > >> > On Thu, 28 Jul 2022 at 10:48, Daniel P. Berrangé > >> > w

Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used

2022-07-28 Thread Peter Maydell
On Thu, 28 Jul 2022 at 14:30, Markus Armbruster wrote: > Peter Maydell writes: > I applaud the renaissance of roman-style inscriptions, but it's not just > words without spaces, it's also capital letters only: > > ANY64CHARACTERFAKEOSKISENOUGHTOPREVENTINVALIDKEYWARNINGSONSTDERR > > Seriously,

qtest/libqos: How to find the free PCI slots in a qtest instance?

2022-07-28 Thread Frenkel, Sheindy
Hi, I'm trying to find out how I can get the free PCI slots in a qtest code. I want to assign a PCI device to a qtest-mode VM. If I assign this device to an unavailable address in the qemu process, I get this assertion: PCI: slot x function y not available for z. I'm just wondering if I can avoid

[PATCH v3 2/2] migration-test: Allow test to run without uffd

2022-07-28 Thread Peter Xu
We used to stop running all tests if uffd is not detected. However logically that's only needed for postcopy not the rest of tests. Keep running the rest when still possible. Reviewed-by: Daniel P. Berrange Signed-off-by: Peter Xu --- tests/qtest/migration-test.c | 48 +++-

Re: [PATCH v2 1/2] migration-test: Use migrate_ensure_converge() for auto-converge

2022-07-28 Thread Peter Xu
On Thu, Jul 28, 2022 at 03:04:27PM +0200, Thomas Huth wrote: > On 22/07/2022 16.56, Peter Xu wrote: > > Thomas reported that auto-converge test will timeout on MacOS CI gatings. > > Use the migrate_ensure_converge() helper too in the auto-converge as when > > Daniel reworked the other test cases. >

Re: [PATCH v5 5/8] blockdev: Add a new IF type IF_OTHER

2022-07-28 Thread Kevin Wolf
Am 28.07.2022 um 11:46 hat Peter Maydell geschrieben: > On Wed, 27 Jul 2022 at 20:03, Kevin Wolf wrote: > > > > Am 18.07.2022 um 11:49 hat Markus Armbruster geschrieben: > > > An OTP device isn't really a parallel flash, and neither are eFuses. > > > More fast-and-lose use of IF_PFLASH may exist i

Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used

2022-07-28 Thread Markus Armbruster
Peter Maydell writes: > On Thu, 28 Jul 2022 at 11:23, Daniel P. Berrangé wrote: >> >> On Thu, Jul 28, 2022 at 11:05:13AM +0100, Peter Maydell wrote: >> > On Thu, 28 Jul 2022 at 10:48, Daniel P. Berrangé >> > wrote: >> > > >> > > On Thu, Jul 28, 2022 at 05:35:58AM -0400, Igor Mammedov wrote: >>

Re: [PATCH v3] target/ppc: Implement new wait variants

2022-07-28 Thread Daniel Henrique Barboza
On 7/28/22 02:29, Joel Stanley wrote: On Wed, 27 Jul 2022 at 13:49, Daniel Henrique Barboza wrote: On 7/20/22 10:33, Nicholas Piggin wrote: ISA v2.06 adds new variations of wait, specified by the WC field. These are not all compatible with the prior wait implementation, because they add

Re: [PATCH] aspeed: Enable backend file for eeprom

2022-07-28 Thread Cédric Le Goater
On 7/28/22 09:20, John Wang wrote: Cédric Le Goater 于2022年7月28日周四 14:28写道: Hello John, On 7/28/22 08:12, John Wang wrote: tested on a fp5280g2: $QEMU_BIN -machine fp5280g2-bmc \ -nographic \ -drive file="${IMAGE_PATH}",format=raw,if=mtd \ -drive file="eeprom.bin",

Re: [PATCH for-7.2] hw: Add compat machines for 7.2

2022-07-28 Thread Daniel Henrique Barboza
On 7/27/22 09:17, Cornelia Huck wrote: Add 7.2 machine types for arm/i440fx/m68k/q35/s390x/spapr. Signed-off-by: Cornelia Huck --- Looking good for pseries. Reviewed-by: Daniel Henrique Barboza hw/arm/virt.c | 9 - hw/core/machine.c | 3 +++ hw/i38

Re: [PATCH for-7.1] hw/mips/malta: turn off x86 specific features of PIIX4_PM

2022-07-28 Thread Igor Mammedov
On Thu, 28 Jul 2022 13:29:07 +0100 Peter Maydell wrote: > On Thu, 28 Jul 2022 at 12:50, Igor Mammedov wrote: > > > > QEMU crashes trying to save VMSTATE when only MIPS target are compiled in > > $ qemu-system-mips -monitor stdio > > (qemu) migrate "exec:gzip -c > STATEFILE.gz" > > Segmenta

Re: [PATCH v3 00/12] powernv: introduce pnv-phb base/proxy devices

2022-07-28 Thread Daniel Henrique Barboza
On 7/27/22 14:28, Frederic Barrat wrote: On 24/06/2022 10:49, Daniel Henrique Barboza wrote: Hi, This is the version 3 of the pnv-phb proxy device which has the following main differences from v2: - it's rebased on top of "[PATCH v3 0/8] pnv-phb related cleanups" - it doesn't have any pat

Re: [PATCH 4/5] util/qemu-sockets: Enable unix socket support on Windows

2022-07-28 Thread Marc-André Lureau
Hi On Wed, Jul 27, 2022 at 2:05 PM Bin Meng wrote: > On Wed, Jul 27, 2022 at 4:53 PM Konstantin Kostiuk > wrote: > > > > > > > > > > > > On Wed, Jul 27, 2022 at 10:47 AM Bin Meng wrote: > >> > >> From: Bin Meng > >> > >> Support for the unix socket has existed both in BSD and Linux for the >

Re: [PATCH v3 05/12] ppc/pnv: turn PnvPHB4 into a PnvPHB backend

2022-07-28 Thread Daniel Henrique Barboza
On 7/27/22 14:41, Frederic Barrat wrote: On 24/06/2022 10:49, Daniel Henrique Barboza wrote: diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 1df91971b8..b7273f386e 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -672,7 +672,14 @@ static void pnv_chip_power8_pic_print_info(PnvChip *chip, Mo

Re: [PATCH v2 1/2] migration-test: Use migrate_ensure_converge() for auto-converge

2022-07-28 Thread Thomas Huth
On 22/07/2022 16.56, Peter Xu wrote: Thomas reported that auto-converge test will timeout on MacOS CI gatings. Use the migrate_ensure_converge() helper too in the auto-converge as when Daniel reworked the other test cases. Since both max_bandwidth / downtime_limit will not be used for converge c

Re: [PATCH v2 5/6] chardev/char-socket: Update AF_UNIX for Windows

2022-07-28 Thread Marc-André Lureau
Hi On Wed, Jul 27, 2022 at 5:28 PM Bin Meng wrote: > > From: Bin Meng > > Now that AF_UNIX has come to Windows, update the existing logic in > qemu_chr_compute_filename() and qmp_chardev_open_socket() for Windows. > > Signed-off-by: Bin Meng lgtm, Reviewed-by: Marc-André Lureau > --- > > Ch

Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used

2022-07-28 Thread Daniel P . Berrangé
On Thu, Jul 28, 2022 at 02:00:37PM +0200, Igor Mammedov wrote: > On Thu, 28 Jul 2022 11:23:00 +0100 > Daniel P. Berrangé wrote: > > > On Thu, Jul 28, 2022 at 11:05:13AM +0100, Peter Maydell wrote: > > > On Thu, 28 Jul 2022 at 10:48, Daniel P. Berrangé > > > wrote: > > > > > > > > On Thu, Jul

Re: [PATCH v2 3/6] qga/commands-win32: Use os_get_win_version()

2022-07-28 Thread Marc-André Lureau
Hi On Wed, Jul 27, 2022 at 5:30 PM Bin Meng wrote: > From: Bin Meng > > Drop its own ga_get_win_version() implementation, and use the one > provided in oslib-win32 instead. > > Signed-off-by: Bin Meng > Will be squashed with the previous patch, since the move should be done together. > ---

  1   2   >