Re: [PATCH v7 01/14] mm: Add F_SEAL_AUTO_ALLOCATE seal to memfd

2022-08-23 Thread David Hildenbrand
On 18.08.22 01:41, Kirill A. Shutemov wrote: > On Fri, Aug 05, 2022 at 07:55:38PM +0200, Paolo Bonzini wrote: >> On 7/21/22 11:44, David Hildenbrand wrote: >>> >>> Also, I*think* you can place pages via userfaultfd into shmem. Not >>> sure if that would count "auto alloc", but it would certainly

Re: [PATCH v2 03/24] virtio: introduce virtio_queue_reset()

2022-08-23 Thread Jason Wang
在 2022/8/16 09:06, Kangjie Xu 写道: From: Xuan Zhuo Introduce a new interface function virtio_queue_reset() to implement reset for vq. Add a new callback to VirtioDeviceClass for queue reset operation for each child device. Signed-off-by: Xuan Zhuo Acked-by: Jason Wang ---

Re: [PATCH v2 02/24] virtio: introduce __virtio_queue_reset()

2022-08-23 Thread Jason Wang
在 2022/8/16 09:06, Kangjie Xu 写道: From: Xuan Zhuo Separate the logic of vq reset. This logic will be called directly later. Signed-off-by: Xuan Zhuo Acked-by: Jason Wang --- hw/virtio/virtio.c | 37 + 1 file changed, 21 insertions(+), 16

Re: [PATCH v5 1/9] parallels: Out of image offset in BAT leads to image inflation

2022-08-23 Thread Alexander Ivanov
On 23.08.2022 08:58, Vladimir Sementsov-Ogievskiy wrote: On 8/22/22 12:05, Alexander Ivanov wrote: data_end field in BDRVParallelsState is set to the biggest offset present in BAT. If this offset is outside of the image, any further write will create the cluster at this offset and/or the

Re: [PATCH] vhost: reduce the set_mem_table call frenquency

2022-08-23 Thread Li Feng
Sorry, looks like I use the old qemu code, master has fix this issue. Just ignore this patch. > 2022年8月23日 下午1:38,Li Feng 写道: > > If the vhost memory layout doesn't change, don't need to call the vhost > backend. > The set_mem_table is time consuming when sending to vhost-user backend. > > On

Re: [PATCH v5 1/9] parallels: Out of image offset in BAT leads to image inflation

2022-08-23 Thread Vladimir Sementsov-Ogievskiy
On 8/22/22 12:05, Alexander Ivanov wrote: data_end field in BDRVParallelsState is set to the biggest offset present in BAT. If this offset is outside of the image, any further write will create the cluster at this offset and/or the image will be truncated to this offset on close. This is

Re: [PATCH 7/7] vdpa: Use ring hwaddr at vhost_vdpa_svq_unmap_ring

2022-08-23 Thread Jason Wang
在 2022/8/20 00:53, Eugenio Pérez 写道: Reduce code duplication. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang (In the future, we need to look for other cases where a function may use only a partial of DMAMap.) Thanks --- hw/virtio/vhost-vdpa.c | 17 - 1 file

Re: [PATCH v9 11/12] vdpa: Add virtio-net mac address via CVQ at start

2022-08-23 Thread Jason Wang
在 2022/8/20 01:00, Eugenio Pérez 写道: This is needed so the destination vdpa device see the same state a the guest set in the source. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang --- v9: * Use guest acked features instead of device's. * Constify vhost_vdpa and VirtIONet variables.

Re: [PATCH 4/7] vdpa: Remove SVQ vring from iova_tree at shutdown

2022-08-23 Thread Jason Wang
在 2022/8/20 00:53, Eugenio Pérez 写道: Although the device will be reset before usage, the right thing to do is to clean it. Reported-by: Lei Yang Fixes: 34e3c94eda ("vdpa: Add custom IOTLB translations to SVQ") Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-vdpa.c | 7 ++- 1 file

Re: [PATCH 6/7] vhost: Always store new kick fd on vhost_svq_set_svq_kick_fd

2022-08-23 Thread Jason Wang
在 2022/8/20 00:53, Eugenio Pérez 写道: We can unbind twice a file descriptor if we call twice vhost_svq_set_svq_kick_fd because of this. Since it comes from vhost and not from SVQ, that file descriptor could be a different thing that guest's vhost notifier. Likewise, it can happens the same if

Re: [PATCH 5/7] vdpa: Make SVQ vring unmapping return void

2022-08-23 Thread Jason Wang
在 2022/8/20 00:53, Eugenio Pérez 写道: Nothing actually reads the return value, but an error in cleaning some entries could cause device stop to abort, making a restart impossible. Better ignore explicitely the return value. Reported-by: Lei Yang Fixes: 34e3c94eda ("vdpa: Add custom IOTLB

Re: [PATCH 3/7] util: make a copy of iova_tree_remove_parameter

2022-08-23 Thread Jason Wang
在 2022/8/20 00:53, Eugenio Pérez 写道: It's convenient to call iova_tree_remove from a map returned from iova_tree_find or iova_tree_find_iova. The looks like a hint of the defect of current API. With the current code this is not possible, since we will free it, and then we will try to

[PATCH v4 4/4] hw/ssi: ibex_spi: update reg addr

2022-08-23 Thread Wilfred Mallawa
From: Wilfred Mallawa Updates the `EVENT_ENABLE` register to offset `0x34` as per OpenTitan spec [1]. [1] https://docs.opentitan.org/hw/ip/spi_host/doc/#Reg_event_enable Signed-off-by: Wilfred Mallawa Reviewed-by: Alistair Francis --- hw/ssi/ibex_spi_host.c | 2 +- 1 file changed, 1

[PATCH v4 3/4] hw/ssi: ibex_spi: fixup/add rw1c functionality

2022-08-23 Thread Wilfred Mallawa
From: Wilfred Mallawa This patch adds the `rw1c` functionality to the respective registers. The status fields are cleared when the respective field is set. Signed-off-by: Wilfred Mallawa Reviewed-by: Alistair Francis --- hw/ssi/ibex_spi_host.c | 34 --

[PATCH v4 1/4] hw/ssi: ibex_spi: fixup typos in ibex_spi_host

2022-08-23 Thread Wilfred Mallawa
From: Wilfred Mallawa This patch fixes up minor typos in ibex_spi_host Signed-off-by: Wilfred Mallawa Reviewed-by: Alistair Francis Reviewed-by: Andrew Jones --- hw/ssi/ibex_spi_host.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ssi/ibex_spi_host.c

[PATCH v4 2/4] hw/ssi: ibex_spi: fixup coverity issue

2022-08-23 Thread Wilfred Mallawa
From: Wilfred Mallawa This patch addresses the coverity issues specified in [1], as suggested, `FIELD_DP32()`/`FIELD_EX32()` macros have been implemented to clean up the code. [1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg887713.html Fixes: Coverity CID 1488107 Signed-off-by:

[PATCH v4 0/4] hw/ssi: ibex_spi: cleanup and fixup bugs

2022-08-23 Thread Wilfred Mallawa
From: Wilfred Mallawa Patch V4 fixes up: - Fixup missing register field clearing on tx/rx_fifo_reset() in [2/4] Testing: - Tested with Opentitan unit tests for TockOS...[OK] Wilfred Mallawa (4): hw/ssi: ibex_spi: fixup typos in ibex_spi_host hw/ssi: ibex_spi: fixup coverity issue

<    1   2   3