Re: [PATCH 4/8] tests: Only run intel-hda-tests if machine type is compiled in

2022-09-04 Thread Ani Sinha
On Fri, 2 Sep 2022, Juan Quintela wrote: Reviewed-by: Ani Sinha > Signed-off-by: Juan Quintela > --- > tests/qtest/intel-hda-test.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/tests/qtest/intel-hda-test.c b/tests/qtest/intel-hda-test.c > index a58

Re: [PATCH 2/8] bios-tables-test: Sort all x86_64 tests by machine type

2022-09-04 Thread Ani Sinha
On Fri, 2 Sep 2022, Juan Quintela wrote: > No code change here, just move test around. > > Signed-off-by: Juan Quintela Reviewed-by: Ani Sinha > --- > tests/qtest/bios-tables-test.c | 60 +++--- > 1 file changed, 33 insertions(+), 27 deletions(-) > > diff --git

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-09-04 Thread Bin Meng
On Mon, Sep 5, 2022 at 2:04 PM Marc-André Lureau wrote: > > Hi > > On Sun, Sep 4, 2022 at 10:24 AM Bin Meng wrote: >> >> On Thu, Sep 1, 2022 at 8:58 PM Marc-André Lureau >> wrote: >> > >> > Hi >> > >> > On Wed, Aug 24, 2022 at 2:49 PM Bin Meng wrote: >> >> >> >> From: Bin Meng >> >> >> >> Rand

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-09-04 Thread Marc-André Lureau
Hi On Sun, Sep 4, 2022 at 10:24 AM Bin Meng wrote: > On Thu, Sep 1, 2022 at 8:58 PM Marc-André Lureau > wrote: > > > > Hi > > > > On Wed, Aug 24, 2022 at 2:49 PM Bin Meng wrote: > >> > >> From: Bin Meng > >> > >> Random failure was observed when running qtests on Windows due to > >> "Broken p

RE: [PATCH v2 0/2] vhost-user: Support vhost_dev_start

2022-09-04 Thread Yajun Wu
Michael, 7.1 released, please merge. -Original Message- From: Michael S. Tsirkin Sent: Tuesday, July 26, 2022 10:56 PM To: Yajun Wu Cc: qemu-devel@nongnu.org; Parav Pandit Subject: Re: [PATCH v2 0/2] vhost-user: Support vhost_dev_start External email: Use caution opening links or att

Re: [PATCH v3 01/15] virtio: sync relevant definitions with linux

2022-09-04 Thread Jason Wang
在 2022/8/25 16:08, Kangjie Xu 写道: From: Xuan Zhuo This is updated using scripts/update-linux-headers.sh. Added VIRTIO_F_RING_RESET, VIRTIO_PCI_COMMON_Q_RESET. It came from here: https://github.com/oasis-tcs/virtio-spec/issues/124 https://github.com/oasis-tcs/virtio-spec/issues/139 Add VIRTI

[PATCH] hw/riscv: virt: Enable booting S-mode firmware from pflash

2022-09-04 Thread Sunil V L
To boot S-mode firmware payload like EDK2 from persistent flash storage, qemu needs to pass the flash address as the next_addr in fw_dynamic_info to the opensbi. Update the kernel_entry with the flash address when no kernel is specified via QEMU command line so that opensbi can jump to the flash

Re: [PATCH v2] scsi-disk: support setting CD-ROM block size via device options

2022-09-04 Thread John Millikin
I notice this patch wasn't included in the [PULL] series last week, and it isn't present in the `master` branch. Is there anything else I should be doing to get it merged in? Sorry if this isn't a good question, I'm not used to QEMU's email-based change management workflow. On Sat, Aug 20, 2022 a

Re: [PATCH v3] target/i386: Set maximum APIC ID to KVM prior to vCPU creation

2022-09-04 Thread Zeng Guang
Kindly PING! On 8/25/2022 10:52 AM, Zeng Guang wrote: Specify maximum possible APIC ID assigned for current VM session to KVM prior to the creation of vCPUs. By this setting, KVM can set up VM-scoped data structure indexed by the APIC ID, e.g. Posted-Interrupt Descriptor pointer table to support

Re: [PATCH v5 3/3] i386: Add notify VM exit support

2022-09-04 Thread Chenyi Qiang
Hi Paolo, Any comment on patch 2-3? Thanks Chenyi On 8/17/2022 10:08 AM, Chenyi Qiang wrote: There are cases that malicious virtual machine can cause CPU stuck (due to event windows don't open up), e.g., infinite loop in microcode when nested #AC (CVE-2015-5307). No event window means no event

Re: [PATCH v1 00/40] TDX QEMU support

2022-09-04 Thread Xiaoyao Li
Hi Gerd On 8/2/2022 3:47 PM, Xiaoyao Li wrote: .. == Change history == Changes from RFC v4: [RFC v4] https://lore.kernel.org/qemu-devel/20220512031803.3315890-1-xiaoyao...@intel.com/ - Add 3 more patches(9, 10, 11) to improve the tdx_get_supported_cpuid(); Patch 8-11 are the only left ones t

[PATCH v2] softmmu/physmem: Fix address of FlatView access in address_space_(read|write)_cached_slow()

2022-09-04 Thread Alberto Faria
flatview_(read|write)_continue() must be called with an address in the FlatView's address space, but `addr` is relative to the MemoryRegionCache. Convert `addr` from the MemoryRegionCache's address space to the FlatView's before passing it to flatview_(read|write)_continue(). This problem was unc

[PATCH v6 14/14] qmp/hmp, device_tree.c: introduce dumpdtb

2022-09-04 Thread Daniel Henrique Barboza
To save the FDT blob we have the '-machine dumpdtb=' property. With this property set, the machine saves the FDT in and exit. The created file can then be converted to plain text dts format using 'dtc'. There's nothing particularly sophisticated into saving the FDT that can't be done with the mac

[PATCH v6 07/14] hw/ppc: set machine->fdt in xilinx_load_device_tree()

2022-09-04 Thread Daniel Henrique Barboza
This will enable support for 'dumpdtb' QMP/HMP command for the virtex_ml507 machine. Cc: Edgar E. Iglesias Signed-off-by: Daniel Henrique Barboza --- hw/ppc/virtex_ml507.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c in

[PATCH v6 13/14] hw/xtensa: set machine->fdt in xtfpga_init()

2022-09-04 Thread Daniel Henrique Barboza
This will enable support for the 'dumpdtb' QMP/HMP command for all xtensa machines that uses a FDT. Signed-off-by: Daniel Henrique Barboza --- hw/xtensa/meson.build | 2 +- hw/xtensa/xtfpga.c| 6 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/xtensa/meson.build b/hw

Re: [PATCH] softmmu/physmem: Fix address of FlatView access in address_space_(read|write)_cached_slow()

2022-09-04 Thread Alberto Campinho Faria
On Mon, Sep 5, 2022 at 12:32 AM Alberto Campinho Faria wrote: > Hi Peter, > > On Sat, Aug 27, 2022 at 7:59 PM Peter Xu wrote: > > Any bug encountered? It'll be great to add more information into the > > commit message if there is. We could also mention the issue was observed > > by code review

[PATCH v6 12/14] hw/riscv: set machine->fdt in spike_board_init()

2022-09-04 Thread Daniel Henrique Barboza
This will enable support for the 'dumpdtb' QMP/HMP command for the spike machine. Cc: Palmer Dabbelt Cc: Alistair Francis Cc: Bin Meng Reviewed-by: Alistair Francis Signed-off-by: Daniel Henrique Barboza --- hw/riscv/spike.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/riscv/

[PATCH v6 06/14] hw/ppc: set machine->fdt in sam460ex_load_device_tree()

2022-09-04 Thread Daniel Henrique Barboza
This will enable support for 'dumpdtb' QMP/HMP command for the sam460ex machine. Setting machine->fdt requires a MachineState pointer to be used inside sam460ex_load_device_tree(). Let's change the function to receive this pointer from the caller. 'ramsize' and 'kernel_cmdline' can be retrieved di

[PATCH v6 08/14] hw/ppc: set machine->fdt in pegasos2_machine_reset()

2022-09-04 Thread Daniel Henrique Barboza
We'll introduce a QMP/HMP command that requires machine->fdt to be set properly. Cc: BALATON Zoltan Cc: qemu-...@nongnu.org Signed-off-by: Daniel Henrique Barboza --- hw/ppc/pegasos2.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c index 61f4263953

[PATCH v6 05/14] hw/ppc: set machine->fdt in bamboo_load_device_tree()

2022-09-04 Thread Daniel Henrique Barboza
This will enable support for 'dumpdtb' QMP/HMP command for the bamboo machine. Cc: Cédric Le Goater Signed-off-by: Daniel Henrique Barboza --- hw/ppc/ppc440_bamboo.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/hw/ppc/ppc440_bamboo.c b/hw/ppc/ppc440_bamboo.c i

[PATCH v6 03/14] hw/nios2: set machine->fdt in nios2_load_dtb()

2022-09-04 Thread Daniel Henrique Barboza
This will enable support for 'dumpdtb' QMP/HMP command for all nios2 machines that uses nios2_load_dtb(). Cc: Chris Wulff Cc: Marek Vasut Signed-off-by: Daniel Henrique Barboza --- hw/nios2/boot.c | 8 +++- hw/nios2/meson.build | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-)

[PATCH v6 10/14] hw/ppc: set machine->fdt in spapr machine

2022-09-04 Thread Daniel Henrique Barboza
The pSeries machine never bothered with the common machine->fdt attribute. We do all the FDT related work using spapr->fdt_blob. We're going to introduce a QMP/HMP command to dump the FDT, which will rely on setting machine->fdt properly to work across all machine archs/types. Let's set machine->

[PATCH v6 04/14] hw/ppc: set machine->fdt in ppce500_load_device_tree()

2022-09-04 Thread Daniel Henrique Barboza
This will enable support for 'dumpdtb' QMP/HMP command for the e500 machine. Cc: Cédric Le Goater Signed-off-by: Daniel Henrique Barboza --- hw/ppc/e500.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 32495d0123..ea5f947824

[PATCH v6 11/14] hw/riscv: set machine->fdt in sifive_u_machine_init()

2022-09-04 Thread Daniel Henrique Barboza
This will enable support for 'dumpdtb' QMP/HMP command for the sifive_u machine. Cc: Alistair Francis Cc: Bin Meng Cc: Palmer Dabbelt Reviewed-by: Alistair Francis Signed-off-by: Daniel Henrique Barboza --- hw/riscv/sifive_u.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/riscv/s

[PATCH v6 09/14] hw/ppc: set machine->fdt in pnv_reset()

2022-09-04 Thread Daniel Henrique Barboza
This will enable support for the 'dumpdtb' QMP/HMP command for all powernv machines. Cc: Cédric Le Goater Cc: Frederic Barrat Signed-off-by: Daniel Henrique Barboza --- hw/ppc/pnv.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 354

[PATCH v6 02/14] hw/microblaze: set machine->fdt in microblaze_load_dtb()

2022-09-04 Thread Daniel Henrique Barboza
This will enable support for 'dumpdtb' QMP/HMP command for all microblaze machines that uses microblaze_load_dtb(). Cc: Edgar E. Iglesias Signed-off-by: Daniel Henrique Barboza --- hw/microblaze/boot.c | 8 +++- hw/microblaze/meson.build | 2 +- 2 files changed, 8 insertions(+), 2 dele

[PATCH v6 01/14] hw/arm: do not free machine->fdt in arm_load_dtb()

2022-09-04 Thread Daniel Henrique Barboza
At this moment, arm_load_dtb() can free machine->fdt when binfo->dtb_filename is NULL. If there's no 'dtb_filename', 'fdt' will be retrieved by binfo->get_dtb(). If get_dtb() returns machine->fdt, as is the case of machvirt_dtb() from hw/arm/virt.c, fdt now has a pointer to machine->fdt. And, in th

[PATCH v6 00/14] QMP/HMP: introduce 'dumpdtb'

2022-09-04 Thread Daniel Henrique Barboza
Hi, This new version contains changes suggested by Zoltan in the v5 review. Changes from v5: - shortened the 'machine->fdt' comment in all relevant patches - patch 6: - changed sam460ex_load_device_tree() to receive a MachineState pointer - v5 link: https://lists.gnu.org/archive/html/qemu-d

Re: [PATCH] softmmu/physmem: Fix address of FlatView access in address_space_(read|write)_cached_slow()

2022-09-04 Thread Alberto Campinho Faria
Hi Peter, On Sat, Aug 27, 2022 at 7:59 PM Peter Xu wrote: > Any bug encountered? It'll be great to add more information into the > commit message if there is. We could also mention the issue was observed > by code review or so. I came across this when performing unaligned 8-byte writes on x86_

Re: [PATCH v2 1/8] virtio: introduce VirtIOConfigSizeParams & virtio_get_config_size

2022-09-04 Thread Raphael Norwitz
> I can squash the first four if that would be better. I think so. Just may be easier for other reviewers :)

Re: [PATCH 0/2] expose host-phys-bits to guest

2022-09-04 Thread Michael S. Tsirkin
On Fri, Sep 02, 2022 at 10:44:20AM +0200, Gerd Hoffmann wrote: > Hi, > > > I feel there are three major sources of controversy here > > > > 0. the cover letter and subject don't do such a good job > >explaining that what we are doing is just telling guest > >CPUID is not broken. we are

Re: [PATCH] 9pfs: use GHashMap for fid table

2022-09-04 Thread Christian Schoenebeck
On Samstag, 3. September 2022 17:03:27 CEST Linus Heckemann wrote: > The previous implementation would iterate over the fid table for > lookup operations, resulting in an operation with O(n) complexity on > the number of open files and poor cache locality -- for nearly every > open, stat, read, wri

Re: [PATCH] x86: only modify setup_data if the boot protocol indicates safety

2022-09-04 Thread Jason A. Donenfeld
FYI, this patch depends on this one in the kernel: https://lore.kernel.org/linux-efi/20220904165321.1140894-1-ja...@zx2c4.com/

[PATCH] x86: only modify setup_data if the boot protocol indicates safety

2022-09-04 Thread Jason A. Donenfeld
This reverts 3824e25db1 ("x86: disable rng seeding via setup_data"), and then makes the use of setup_data safe. It does so by checking the boot protocol version. If it's sufficient, then it means EFI boots won't crash. While we're at it, gate this on SEV too. Cc: Gerd Hoffmann Cc: Laurent Vivier

Re: [PATCH 21/51] tests/qtest: migration-test: Skip running test_migrate_fd_proto on win32

2022-09-04 Thread Philippe Mathieu-Daudé via
On 24/8/22 11:39, Bin Meng wrote: From: Bin Meng The test case 'test_migrate_fd_proto' calls socketpair() which does not exist on win32. Exclude it. The helper function wait_command_fd() is not needed anymore, hence exclude it too. I'd rather use a feature test, then check for the HAVE_POSIX_

Re: [PATCH 01/51] tests/qtest: Use g_setenv()

2022-09-04 Thread Philippe Mathieu-Daudé via
On 24/8/22 11:39, Bin Meng wrote: From: Bin Meng Windows does not provide a setenv() API, but glib does. Replace setenv() call with the glib version. Signed-off-by: Bin Meng --- tests/qtest/fuzz/generic_fuzz.c | 8 tests/qtest/libqtest.c | 2 +- 2 files changed, 5 inser

Re: [PATCH 22/51] tests/qtest: qmp-test: Skip running test_qmp_oob for win32

2022-09-04 Thread Philippe Mathieu-Daudé via
On 29/8/22 17:06, Markus Armbruster wrote: Bin Meng writes: Hi Markus, On Mon, Aug 29, 2022 at 9:14 PM Markus Armbruster wrote: Bin Meng writes: From: Bin Meng The test_qmp_oob test case calls mkfifo() which does not exist on win32. Exclude it. Signed-off-by: Bin Meng --- tests/q

Re: [PATCH 4/8] tests: Only run intel-hda-tests if machine type is compiled in

2022-09-04 Thread Philippe Mathieu-Daudé via
On 2/9/22 19:34, Juan Quintela wrote: Signed-off-by: Juan Quintela --- tests/qtest/intel-hda-test.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/tests/qtest/intel-hda-test.c b/tests/qtest/intel-hda-test.c index a58c98e4d1..d4a8db6fd6 100644 --- a/tests/qte

[PATCH] hcd-xhci: drop operation with secondary stream arrays enabled

2022-09-04 Thread Qiang Liu
The abort() in xhci_find_stream() can be triggered via enabling the secondary stream arrays by setting linear stream array (LSA) bit (in endpoint context) to 0. We may show warnings and drop this operation. Fixes: 024426acc0a2 ("usb-xhci: usb3 streams") Reported-by: Qiang Liu Resolves: https://gi

Re: [PATCH 3/8] bios-tables-test: Only run test for machine types compiled in

2022-09-04 Thread Philippe Mathieu-Daudé via
On 2/9/22 19:34, Juan Quintela wrote: Signed-off-by: Juan Quintela --- tests/qtest/bios-tables-test.c | 145 ++--- 1 file changed, 78 insertions(+), 67 deletions(-) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index 757db2bc40..bc21

Re: [PATCH 1/8] bios-tables-test: Make oem-fields tests be consistent

2022-09-04 Thread Philippe Mathieu-Daudé via
On 2/9/22 19:34, Juan Quintela wrote: Every other test function is named: test_acpi__() Just make this test the same. Once there, rename "acpi/oem-fields" to "acpi/piix4/oem-fields" so it is consistent with everything else. Signed-off-by: Juan Quintela --- tests/qtest/bios-tables-t

Re: [PATCH 2/2] vvfat: allow spaces in file names

2022-09-04 Thread Philippe Mathieu-Daudé via
On 3/9/22 18:23, Hervé Poussineau wrote: In R/W mode, files with spaces were never created on host side. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1176 Fixes: c79e243ed67683d6d06692bd7040f7394da178b0 Signed-off-by: Hervé Poussineau --- block/vvfat.c | 2 +- 1 file changed, 1 in

Re: [PATCH] KVM: use store-release to mark dirty pages as harvested

2022-09-04 Thread Philippe Mathieu-Daudé via
On 2/9/22 02:19, Paolo Bonzini wrote: The following scenario can happen if QEMU sets more RESET flags while the KVM_RESET_DIRTY_RINGS ioctl is ongoing on another host CPU: CPU0 CPU1 CPU2 -- -

Re: [PATCH 2/8] qtest: Set "-net none" in qtest_init()

2022-09-04 Thread Philippe Mathieu-Daudé via
On 2/9/22 18:51, Juan Quintela wrote: This way, we don't have networking by default. If test needs it, configure it. Signed-off-by: Juan Quintela --- tests/qtest/bios-tables-test.c | 2 +- tests/qtest/libqtest.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) Reviewed-by:

Re: [PATCH 6/8] tests: Fix error strings

2022-09-04 Thread Philippe Mathieu-Daudé via
On 2/9/22 18:51, Juan Quintela wrote: They were copy-pasted from e1000e and never changed. Signed-off-by: Juan Quintela --- tests/qtest/e1000-test.c | 2 +- tests/qtest/es1370-test.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] 9pfs: use GHashMap for fid table

2022-09-04 Thread Philippe Mathieu-Daudé via
Hi Linus, On 3/9/22 17:03, Linus Heckemann wrote: The previous implementation would iterate over the fid table for lookup operations, resulting in an operation with O(n) complexity on the number of open files and poor cache locality -- for nearly every open, stat, read, write, etc operation. Th

Re: [PATCH 10/20] ppc440_sdram: Implement enable bit in the DDR2 SDRAM controller

2022-09-04 Thread BALATON Zoltan
On Sun, 4 Sep 2022, Philippe Mathieu-Daudé via wrote: On 19/8/22 18:55, BALATON Zoltan wrote: To allow removing the do_init hack we need to improve the DDR2 SDRAM controller model to handle the enable/disable bit that it ignored so far. Signed-off-by: BALATON Zoltan --- hw/ppc/ppc440_uc.c |

Re: [PATCH 17/20] ppc4xx_sdram: Use hwaddr for memory bank size

2022-09-04 Thread Philippe Mathieu-Daudé via
On 19/8/22 18:55, BALATON Zoltan wrote: This resolves the target_ulong dependency that's clearly wrong and was also noted in a fixme comment. Signed-off-by: BALATON Zoltan --- hw/ppc/ppc4xx_sdram.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) Reviewed-by: Philippe

Re: [PATCH 10/20] ppc440_sdram: Implement enable bit in the DDR2 SDRAM controller

2022-09-04 Thread Philippe Mathieu-Daudé via
On 19/8/22 18:55, BALATON Zoltan wrote: To allow removing the do_init hack we need to improve the DDR2 SDRAM controller model to handle the enable/disable bit that it ignored so far. Signed-off-by: BALATON Zoltan --- hw/ppc/ppc440_uc.c | 34 -- 1 file changed,

Re: [PATCH 02/20] ppc4xx: Introduce Ppc4xxSdramBank struct

2022-09-04 Thread Philippe Mathieu-Daudé via
On 19/8/22 18:55, BALATON Zoltan wrote: Instead of storing sdram bank parameters in unrelated arrays put them in a struct so it's clear they belong to the same bank and simplify the state struct using this bank type. Signed-off-by: BALATON Zoltan --- hw/ppc/ppc440_uc.c | 49 +

[PULL 09/11] target/openrisc: Interrupt handling fixes

2022-09-04 Thread Stafford Horne
When running SMP systems we sometimes were seeing lockups where IPI interrupts were being raised by never handled. This looks to be caused by 2 issues in the openrisc interrupt handling logic. 1. After clearing an interrupt the openrisc_cpu_set_irq handler will always clear PICSR. This is n

[PULL 11/11] docs/system: openrisc: Add OpenRISC documentation

2022-09-04 Thread Stafford Horne
Reviewed-by: Richard Henderson Signed-off-by: Stafford Horne --- docs/system/openrisc/cpu-features.rst | 15 ++ docs/system/openrisc/emulation.rst| 17 +++ docs/system/openrisc/or1k-sim.rst | 43 docs/system/openrisc/virt.rst | 50 +++ doc

[PULL 07/11] target/openrisc: Add interrupted CPU to log

2022-09-04 Thread Stafford Horne
When we are tracing it's helpful to know which CPU's are getting interrupted, add that detail to the log line. Reviewed-by: Richard Henderson Signed-off-by: Stafford Horne --- target/openrisc/interrupt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/openrisc/inte

[PULL 05/11] hw/openrisc: Add PCI bus support to virt

2022-09-04 Thread Stafford Horne
This is mostly borrowed from xtensa and riscv as examples. The create_pcie_irq_map swizzle function is almost and exact copy but here we use a single cell interrupt, possibly we can make this generic. Signed-off-by: Stafford Horne --- hw/openrisc/Kconfig | 3 + hw/openrisc/virt.c | 160 +

[PULL 08/11] target/openrisc: Enable MTTCG

2022-09-04 Thread Stafford Horne
This patch enables multithread TCG for OpenRISC. Since the or1k shared syncrhonized timer can be updated from each vCPU via helpers we use a mutex to synchronize updates. Reviewed-by: Richard Henderson Signed-off-by: Stafford Horne --- configs/targets/or1k-softmmu.mak | 1 + target/openrisc/cp

[PULL 04/11] hw/openrisc: Add the OpenRISC virtual machine

2022-09-04 Thread Stafford Horne
This patch adds the OpenRISC virtual machine 'virt' for OpenRISC. This platform allows for a convenient CI platform for toolchain, software ports and the OpenRISC linux kernel port. Much of this has been sourced from the m68k and riscv virt platforms. The platform provides: - OpenRISC SMP with

[PULL 06/11] hw/openrisc: Initialize timer time at startup

2022-09-04 Thread Stafford Horne
The last_clk time was initialized at zero, this means when we calculate the first delta we will calculate 0 vs current time which could cause unnecessary hops. This patch moves timer initialization to the cpu reset. There are two resets registered here: 1. Per cpu timer mask (ttmr) reset. 2. G

[PULL 01/11] hw/openrisc: Split re-usable boot time apis out to boot.c

2022-09-04 Thread Stafford Horne
These will be shared with the virt platform. Reviewed-by: Richard Henderson Signed-off-by: Stafford Horne --- hw/openrisc/boot.c | 116 + hw/openrisc/meson.build| 1 + hw/openrisc/openrisc_sim.c | 106 ++--- include/h

[PULL 10/11] hw/openrisc: virt: pass random seed to fdt

2022-09-04 Thread Stafford Horne
From: "Jason A. Donenfeld" If the FDT contains /chosen/rng-seed, then the Linux RNG will use it to initialize early. Set this using the usual guest random number generation function. This is confirmed to successfully initialize the RNG on Linux 5.19-rc2. Signed-off-by: Jason A. Donenfeld Review

[PULL 03/11] goldfish_rtc: Add big-endian property

2022-09-04 Thread Stafford Horne
Add a new property "big-endian" to allow configuring the RTC as either little or big endian, the default is little endian. Currently overriding the default to big endian is only used by the m68k virt platform. New platforms should prefer to use little endian and not set this. Cc: Laurent Vivier

[PULL 02/11] target/openrisc: Fix memory reading in debugger

2022-09-04 Thread Stafford Horne
In commit f0655423ca ("target/openrisc: Reorg tlb lookup") data and instruction TLB reads were combined. This, broke debugger reads where we first tried to map using the data tlb then fall back to the instruction tlb. This patch replicates this logic by first requesting a PAGE_READ protection map

[PULL 00/11] OpenRISC updates for 7.2.0

2022-09-04 Thread Stafford Horne
The following changes since commit 61fd710b8da8aedcea9b4f197283dc38638e4b60: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2022-09-02 13:24:28 -0400) are available in the Git repository at: g...@github.com:stffrdhrn/qemu.git tags/pull-or1k-20220904

Re: [PATCH v2] pci: Assert that capabilities never overlap

2022-09-04 Thread Akihiko Odaki
On Fri, Sep 2, 2022 at 7:23 PM Markus Armbruster wrote: > > Akihiko Odaki writes: > > > pci_add_capability appears most PCI devices. Its error handling required > > lots of code, and led to inconsistent behaviors such as: > > - passing error_abort > > - passing error_fatal > > - asserting the ret