[PULL v2 59/82] tests: acpi: update expected blobs

2022-11-02 Thread Michael S. Tsirkin
From: Igor Mammedov Expected change in q35 tests: @@ -2797,14 +2797,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC ", 0x0001) } } -Scope (_SB.PCI0) -{ -Device (SMB0) -{ -

[PULL v2 82/82] intel-iommu: PASID support

2022-11-02 Thread Michael S. Tsirkin
From: Jason Wang This patch introduce ECAP_PASID via "x-pasid-mode". Based on the existing support for scalable mode, we need to implement the following missing parts: 1) tag VTDAddressSpace with PASID and support IOMMU/DMA translation with PASID 2) tag IOTLB with PASID 3) PASID cache and

[PULL v2 37/82] virtio: introduce virtio_queue_enable()

2022-11-02 Thread Michael S. Tsirkin
From: Kangjie Xu Introduce the interface queue_enable() in VirtioDeviceClass and the fucntion virtio_queue_enable() in virtio, it can be called when VIRTIO_PCI_COMMON_Q_ENABLE is written and related virtqueue can be started. It only supports the devices of virtio 1 or later. The not-supported

[PULL v2 40/82] virtio-pci: support queue enable

2022-11-02 Thread Michael S. Tsirkin
From: Kangjie Xu PCI devices support device specific vq enable. Based on this function, the driver can re-enable the virtqueue after the virtqueue is reset. Signed-off-by: Kangjie Xu Signed-off-by: Xuan Zhuo Acked-by: Jason Wang Message-Id:

[PULL v2 34/82] virtio: re-order vm_running and use_started checks

2022-11-02 Thread Michael S. Tsirkin
From: Alex Bennée During migration the virtio device state can be restored before we restart the VM. As no devices can be running while the VM is paused it makes sense to bail out early in that case. This returns the order introduced in: 9f6bcfd99f (hw/virtio: move vm_running check to

[PULL v2 32/82] vhost-user: Support vhost_dev_start

2022-11-02 Thread Michael S. Tsirkin
From: Yajun Wu The motivation of adding vhost-user vhost_dev_start support is to improve backend configuration speed and reduce live migration VM downtime. Today VQ configuration is issued one by one. For virtio net with multi-queue support, backend needs to update RSS (Receive side scaling) on

[PULL v2 70/82] hmat acpi: Don't require initiator value in -numa

2022-11-02 Thread Michael S. Tsirkin
From: Brice Goglin The "Memory Proximity Domain Attributes" structure of the ACPI HMAT has a "Processor Proximity Domain Valid" flag that is currently always set because Qemu -numa requires an initiator=X value when hmat=on. Unsetting this flag allows to create more complex memory topologies by

[PULL v2 53/82] tests: acpi: whitelist DSDT before generating PCI-ISA bridge AML automatically

2022-11-02 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Message-Id: <20221017102146.2254096-3-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.h | 34 + 1 file changed, 34 insertions(+) diff

[PULL v2 39/82] virtio-pci: support queue reset

2022-11-02 Thread Michael S. Tsirkin
From: Xuan Zhuo PCI devices support vq reset. Based on this function, the driver can adjust the size of the ring, and quickly recycle the buffer in the ring. The migration of the virtio devices will not happen during a reset operation. This is becuase the global iothread lock is held.

[PULL v2 50/82] virtio-rng-pci: Allow setting nvectors, so we can use MSI-X

2022-11-02 Thread Michael S. Tsirkin
From: David Daney Most other virtio-pci devices allow MSI-X, let's have it for rng too. Signed-off-by: David Daney Reviewed-by: Marcin Nowakowski Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20221014160947.66105-1-phi...@fungible.com> Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael

[PULL v2 24/82] acpi: arm/virt: madt: bump to revision 4 accordingly to ACPI 6.0 Errata A

2022-11-02 Thread Michael S. Tsirkin
From: Miguel Luis MADT has been updated with the GIC Structures from ACPI 6.0 Errata A and so MADT revision and GICC Structure must be updated also. Fixes: 37f33084ed2e ("acpi: arm/virt: madt: use build_append_int_noprefix() API to compose MADT table") Signed-off-by: Miguel Luis Reviewed-by:

[PULL v2 16/82] MAINTAINERS: add myself as the maintainer for acpi biosbits avocado tests

2022-11-02 Thread Michael S. Tsirkin
From: Ani Sinha I wrote the biosbits avocado tests for testing QEMU's ACPI/SMBIOS implementation and all the related changes including fixes in biosbits software itself. Making myself as the maintainer for QEMU's biosbits related files and test scripts. Cc: Daniel P. Berrangé Cc: Paolo Bonzini

[PULL v2 05/82] acpi/nvdimm: Implement ACPI NVDIMM Label Methods

2022-11-02 Thread Michael S. Tsirkin
From: Robert Hoo Recent ACPI spec [1] has defined NVDIMM Label Methods _LS{I,R,W}, which deprecates corresponding _DSM Functions defined by PMEM _DSM Interface spec [2]. Since the semantics of the new Label Methods are almost same as old _DSM methods, the implementations here simply wrapper old

[PULL v2 09/82] crypto: Support export akcipher to pkcs8

2022-11-02 Thread Michael S. Tsirkin
From: Lei He crypto: support export RSA private keys with PKCS#8 standard. So that users can upload this private key to linux kernel. Signed-off-by: lei he Message-Id: <20221008085030.70212-4-helei.si...@bytedance.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[PULL v2 13/82] acpi/tests/avocado/bits: add biosbits config file for running bios tests

2022-11-02 Thread Michael S. Tsirkin
From: Ani Sinha This change adds initial biosbits config file that instructs biosbits to run bios test suits in batch mode. Additionally acpi and smbios structures are also dumped. Cc: Daniel P. Berrangé Cc: Paolo Bonzini Cc: Maydell Peter Cc: John Snow Cc: Thomas Huth Cc: Alex Bennée Cc:

[PULL v2 21/82] tests/acpi: update tables for new core count test

2022-11-02 Thread Michael S. Tsirkin
From: Julia Suvorova Changes in the tables (for 275 cores): FACP: + Use APIC Cluster Model (V4) : 1 APIC: +[02Ch 0044 1]Subtable Type : 00 [Processor Local APIC] +[02Dh 0045 1] Length : 08 +[02Eh 0046 1] Processor ID :

[PULL v2 29/82] hw/mem/cxl-type3: Add CXL CDAT Data Object Exchange

2022-11-02 Thread Michael S. Tsirkin
From: Huai-Cheng Kuo The CDAT can be specified in two ways. One is to add ",cdat=" in "-device cxl-type3"'s command option. The file is required to provide the whole CDAT table in binary mode. The other is to use the default that provides some 'reasonable' numbers based on type of memory and

[PULL v2 22/82] tests/acpi: virt: allow acpi MADT and FADT changes

2022-11-02 Thread Michael S. Tsirkin
From: Miguel Luis Step 3 from bios-tables-test.c documented procedure. Signed-off-by: Miguel Luis Message-Id: <20221011181730.10885-2-miguel.l...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked-by: Ani Sinha ---

[PULL v2 10/82] cryptodev: Add a lkcf-backend for cryptodev

2022-11-02 Thread Michael S. Tsirkin
From: Lei He cryptodev: Added a new type of backend named lkcf-backend for cryptodev. This backend upload asymmetric keys to linux kernel, and let kernel do the accelerations if possible. The lkcf stands for Linux Kernel Cryptography Framework. Signed-off-by: lei he Message-Id:

[PULL v2 08/82] crypto: Support DER encodings

2022-11-02 Thread Michael S. Tsirkin
From: Lei He Add encoding interfaces for DER encoding: 1. support decoding of 'bit string', 'octet string', 'object id' and 'context specific tag' for DER encoder. 2. implemented a simple DER encoder. 3. add more testsuits for DER encoder. Signed-off-by: lei he Message-Id:

[PULL v2 04/82] acpi/nvdimm: define macro for NVDIMM Device _DSM

2022-11-02 Thread Michael S. Tsirkin
From: Robert Hoo Since it will be heavily used in next patch, define macro NVDIMM_DEVICE_DSM_UUID for "4309AC30-0D11-11E4-9191-0800200C9A66", which is NVDIMM device specific method uuid defined in NVDIMM _DSM interface spec, Section 3. [1] No functional changes in this patch. [1]

[PULL v2 06/82] test/acpi/bios-tables-test: SSDT: update golden master binaries

2022-11-02 Thread Michael S. Tsirkin
From: Robert Hoo And empty bios-tables-test-allowed-diff.h. Diff of ASL form, from qtest testlog.txt: @@ -1,30 +1,30 @@ /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20180629 (64-bit version) * Copyright (c) 2000 - 2018 Intel Corporation * * Disassembling to

[PULL v2 15/82] acpi/tests/avocado/bits/doc: add a doc file to describe the acpi bits test

2022-11-02 Thread Michael S. Tsirkin
From: Ani Sinha A doc file is added under docs/devel that describes the purpose of the various test files and gives guidance to developers on where and how to make changes. Cc: Daniel P. Berrange" Cc: Paolo Bonzini Cc: Maydell Peter Cc: John Snow Cc: Thomas Huth Cc: Alex Bennée Cc: Igor

[PULL v2 01/82] hw/i386/e820: remove legacy reserved entries for e820

2022-11-02 Thread Michael S. Tsirkin
From: Ani Sinha e820 reserved entries were used before the dynamic entries with fw config files were intoduced. Please see the following change: 7d67110f2d9a6("pc: add etc/e820 fw_cfg file") Identical support was introduced into seabios as well with the following commit: ce39bd4031820 ("Add

[PULL v2 02/82] tests/acpi: allow SSDT changes

2022-11-02 Thread Michael S. Tsirkin
From: Robert Hoo Signed-off-by: Robert Hoo Reviewed-by: Jingqi Liu Message-Id: <20220922122155.1326543-2-robert...@linux.intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ 1 file changed, 2 insertions(+) diff

[PULL v2 03/82] acpi/ssdt: Fix aml_or() and aml_and() in if clause

2022-11-02 Thread Michael S. Tsirkin
From: Robert Hoo In If condition, using bitwise and/or, rather than logical and/or. The result change in AML code: If (((Local6 == Zero) | (Arg0 != Local0))) ==> If (((Local6 == Zero) || (Arg0 != Local0))) If (((ObjectType (Arg3) == 0x04) & (SizeOf (Arg3) == One))) ==> If (((ObjectType (Arg3)

Re: Using QEMU for VRChat

2022-11-02 Thread Denis V. Lunev
On 8/10/22 13:06, danko babro wrote: Dear QEMU dev team, Recently a game called VRChat got a security update, implementing Easy Anti Cheat into their game (pretty much spyware that logs everything happening on the users PC) which made me want to install their game on a virtual machine. The

Re: [PATCH RFC 1/4] net: Introduce qmp cmd "query-netdev"

2022-11-02 Thread Hyman
在 2022/11/2 15:10, Thomas Huth 写道: On 02/11/2022 06.42, Jason Wang wrote: On Tue, Nov 1, 2022 at 12:19 AM wrote: From: Hyman Huang(黄勇) For netdev device that can offload virtio-net dataplane to slave, such as vhost-net, vhost-user and vhost-vdpa, exporting it's capability information

Re: [PATCH RFC 1/4] net: Introduce qmp cmd "query-netdev"

2022-11-02 Thread Hyman
在 2022/11/2 14:41, Michael S. Tsirkin 写道: On Wed, Nov 02, 2022 at 01:42:39PM +0800, Jason Wang wrote: On Tue, Nov 1, 2022 at 12:19 AM wrote: From: Hyman Huang(黄勇) For netdev device that can offload virtio-net dataplane to slave, such as vhost-net, vhost-user and vhost-vdpa, exporting

Re: [PATCH RFC 1/4] net: Introduce qmp cmd "query-netdev"

2022-11-02 Thread Hyman
在 2022/11/2 13:42, Jason Wang 写道: On Tue, Nov 1, 2022 at 12:19 AM wrote: From: Hyman Huang(黄勇) For netdev device that can offload virtio-net dataplane to slave, such as vhost-net, vhost-user and vhost-vdpa, exporting it's capability information and acked features would be more friendly

Re: [PATCH v9 1/8] mm: Introduce memfd_restricted system call to create restricted user memory

2022-11-02 Thread Chao Peng
On Tue, Nov 01, 2022 at 02:30:58PM -0500, Michael Roth wrote: > On Tue, Nov 01, 2022 at 10:19:44AM -0500, Michael Roth wrote: > > On Tue, Nov 01, 2022 at 07:37:29PM +0800, Chao Peng wrote: > > > On Mon, Oct 31, 2022 at 12:47:38PM -0500, Michael Roth wrote: > > > > On Tue, Oct 25, 2022 at

Re: Using QEMU for VRChat

2022-11-02 Thread Paolo Bonzini
On 8/10/22 13:06, danko babro wrote: https://docs.vrchat.com/docs/using-vrchat-in-a-virtual-machine I simply cant understand what that code (on the given website) does. Does it open up a backdoor for the anti cheat to access my

Re: [PATCH v10 0/2] vhost-vdpa: add support for vIOMMU

2022-11-02 Thread Michael S. Tsirkin
On Wed, Nov 02, 2022 at 06:39:11AM -0600, Alex Williamson wrote: > On Wed, 2 Nov 2022 06:54:28 -0400 > "Michael S. Tsirkin" wrote: > > > On Mon, Oct 31, 2022 at 08:57:00PM +0800, Cindy Lu wrote: > > > changes in V3 > > > 1. Move function vfio_get_xlat_addr to memory.c > > > 2. Use the existing

Re: [PULL 21/86] bios-tables-test: add test for number of cores > 255

2022-11-02 Thread Ani Sinha
On Tue, Nov 1, 2022 at 7:25 PM Ani Sinha wrote: > > > > On Tue, Nov 1, 2022 at 19:22 Jonathan Cameron > wrote: >> >> On Mon, 31 Oct 2022 08:51:44 -0400 >> "Michael S. Tsirkin" wrote: >> >> > From: Julia Suvorova >> > >> > The new test is run with a large number of cpus and checks if the >> >

Re: [PATCH v10 1/2] vfio: move implement of vfio_get_xlat_addr() to memory.c

2022-11-02 Thread Michael S. Tsirkin
On Mon, Oct 31, 2022 at 08:57:01PM +0800, Cindy Lu wrote: > - Move the implement vfio_get_xlat_addr to softmmu/memory.c, and > change the name to memory_get_xlat_addr(). So we can use this > function on other devices, such as vDPA device. > - Add a new function vfio_get_xlat_addr in

Re: [PATCH v10 2/2] vhost-vdpa: add support for vIOMMU

2022-11-02 Thread Michael S. Tsirkin
On Mon, Oct 31, 2022 at 08:57:02PM +0800, Cindy Lu wrote: > Add support for vIOMMU. add the new function to deal with iommu MR. > - during iommu_region_add register a specific IOMMU notifier, > and store all notifiers in a list. > - during iommu_region_del, compare and delete the IOMMU notifier

Re: [PATCH] target/i386: Fix test for paging enabled

2022-11-02 Thread Paolo Bonzini
On 11/2/22 10:12, Richard Henderson wrote: If CR0.PG is unset, pg_mode will be zero, but that is not the only condition for which pg_mode will be zero. Restore the correct test for paging enabled. Fixes: 98281984a37 ("target/i386: Add MMU_PHYS_IDX and MMU_NESTED_IDX") Resolves:

Re: [PULL 0/5] Misc patches for QEMU 7.2 soft freeze

2022-11-02 Thread Paolo Bonzini
On 11/2/22 13:13, Bin Meng wrote: Could you pleaes queue this series? https://lore.kernel.org/qemu-devel/20221019102015.2441622-1-bmeng...@gmail.com/#t If you are not the right person to queue this, please recommend someone else. Thank you. I was expecting Marc-André to handle it but sure, I

Re: [PATCH v10 0/2] vhost-vdpa: add support for vIOMMU

2022-11-02 Thread Alex Williamson
On Wed, 2 Nov 2022 06:54:28 -0400 "Michael S. Tsirkin" wrote: > On Mon, Oct 31, 2022 at 08:57:00PM +0800, Cindy Lu wrote: > > changes in V3 > > 1. Move function vfio_get_xlat_addr to memory.c > > 2. Use the existing memory listener, while the MR is > > iommu MR then call the function

RE: [PATCH 09/16] hw/9pfs: Disable unsupported flags and features for Windows

2022-11-02 Thread Shi, Guohuai
> -Original Message- > From: Christian Schoenebeck > Sent: Wednesday, November 2, 2022 19:34 > To: qemu-devel@nongnu.org > Cc: Greg Kurz ; Meng, Bin ; Shi, > Guohuai > Subject: Re: [PATCH 09/16] hw/9pfs: Disable unsupported flags and features > for Windows > > CAUTION: This email

Re: [PULL 0/5] Misc patches for QEMU 7.2 soft freeze

2022-11-02 Thread Bin Meng
Hi Paolo, On Wed, Nov 2, 2022 at 7:44 PM Paolo Bonzini wrote: > > The following changes since commit 75d30fde55485b965a1168a21d016dd07b50ed32: > > Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into > staging (2022-10-30 15:07:25 -0400) > > are available in the Git

Re: [PATCH 07/16] hw/9pfs: Implement Windows specific utilities functions for 9pfs

2022-11-02 Thread Christian Schoenebeck
On Wednesday, November 2, 2022 12:51:23 PM CET Christian Schoenebeck wrote: > On Wednesday, November 2, 2022 12:28:08 PM CET Shi, Guohuai wrote: > > > [...] > > > > > > > > Yes, symlink can be supported by "mapped" mode. > > > > I mean that MinGW does not provide symlink mode flags "S_IFLNK" and

Re: [PATCH] block/blkio: Tolerate device size changes

2022-11-02 Thread Kevin Wolf
Am 29.10.2022 um 14:20 hat Alberto Faria geschrieben: > Some libblkio drivers may be able to work with regular files (e.g., > io_uring) or otherwise resizable devices. Conservatively set > BlockDriver::has_variable_length to true to ensure bdrv_nb_sectors() > always gives up-to-date results. > >

Re: [PATCH 07/16] hw/9pfs: Implement Windows specific utilities functions for 9pfs

2022-11-02 Thread Christian Schoenebeck
On Wednesday, November 2, 2022 12:28:08 PM CET Shi, Guohuai wrote: > [...] > > > > > > Yes, symlink can be supported by "mapped" mode. > > > I mean that MinGW does not provide symlink mode flags "S_IFLNK" and some > > other related functions and defines. > > > You can check with "9p.c": S_ISLNK,

Re: [PATCH 3/3] vdpa: Expose VIRTIO_NET_F_STATUS unconditionally

2022-11-02 Thread Eugenio Perez Martin
On Tue, Nov 1, 2022 at 9:10 AM Jason Wang wrote: > > On Fri, Oct 28, 2022 at 5:30 PM Eugenio Perez Martin > wrote: > > > > On Fri, Oct 28, 2022 at 3:59 AM Jason Wang wrote: > > > > > > On Thu, Oct 27, 2022 at 6:18 PM Eugenio Perez Martin > > > wrote: > > > > > > > > On Thu, Oct 27, 2022 at

[PULL 5/5] target/i386: Fix test for paging enabled

2022-11-02 Thread Paolo Bonzini
From: Richard Henderson If CR0.PG is unset, pg_mode will be zero, but it will also be zero for non-PAE/non-PSE page tables with CR0.WP=0. Restore the correct test for paging enabled. Fixes: 98281984a37 ("target/i386: Add MMU_PHYS_IDX and MMU_NESTED_IDX") Resolves:

[PULL 3/5] target/i386: Set maximum APIC ID to KVM prior to vCPU creation

2022-11-02 Thread Paolo Bonzini
From: Zeng Guang Specify maximum possible APIC ID assigned for current VM session to KVM prior to the creation of vCPUs. By this setting, KVM can set up VM-scoped data structure indexed by the APIC ID, e.g. Posted-Interrupt Descriptor pointer table to support Intel IPI virtualization, with the

[PULL 4/5] util/log: Close per-thread log file on thread termination

2022-11-02 Thread Paolo Bonzini
From: Greg Kurz When `-D ${logfile} -d tid` is passed, qemu_log_trylock() creates a dedicated log file for the current thread and opens it. The corresponding file descriptor is cached in a __thread variable. Nothing is done to close the corresponding file descriptor when the thread terminates

[PULL 1/5] target/i386: Fix calculation of LOCK NEG eflags

2022-11-02 Thread Paolo Bonzini
From: Qi Hu After: lock negl -0x14(%rbp) pushf pop%rax %rax will contain the wrong value because the "lock neg" calculates the wrong eflags. Simple test: #include int main() { __volatile__ unsigned test = 0x2363a;

[PULL 2/5] os-posix: asynchronous teardown for shutdown on Linux

2022-11-02 Thread Paolo Bonzini
From: Claudio Imbrenda This patch adds support for asynchronously tearing down a VM on Linux. When qemu terminates, either naturally or because of a fatal signal, the VM is torn down. If the VM is huge, it can take a considerable amount of time for it to be cleaned up. In case of a protected

[PULL 0/5] Misc patches for QEMU 7.2 soft freeze

2022-11-02 Thread Paolo Bonzini
The following changes since commit 75d30fde55485b965a1168a21d016dd07b50ed32: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2022-10-30 15:07:25 -0400) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to

Re: [PATCH 09/16] hw/9pfs: Disable unsupported flags and features for Windows

2022-11-02 Thread Christian Schoenebeck
On Wednesday, November 2, 2022 4:44:14 AM CET Shi, Guohuai wrote: > > > -Original Message- > > From: Christian Schoenebeck > > Sent: Wednesday, November 2, 2022 02:59 > > To: qemu-devel@nongnu.org > > Cc: Greg Kurz ; Meng, Bin ; Shi, > > Guohuai > > Subject: Re: [PATCH 09/16] hw/9pfs:

RE: [PATCH 07/16] hw/9pfs: Implement Windows specific utilities functions for 9pfs

2022-11-02 Thread Shi, Guohuai
> -Original Message- > From: Christian Schoenebeck > Sent: Wednesday, November 2, 2022 19:06 > To: qemu-devel@nongnu.org > Cc: Greg Kurz ; Meng, Bin ; Shi, > Guohuai > Subject: Re: [PATCH 07/16] hw/9pfs: Implement Windows specific utilities > functions for 9pfs > > CAUTION: This

Re: [PATCH 07/16] hw/9pfs: Implement Windows specific utilities functions for 9pfs

2022-11-02 Thread Christian Schoenebeck
On Wednesday, November 2, 2022 4:07:35 AM CET Shi, Guohuai wrote: > > > -Original Message- > > From: Christian Schoenebeck > > Sent: Wednesday, November 2, 2022 02:22 > > To: qemu-devel@nongnu.org > > Cc: Greg Kurz ; Meng, Bin ; Shi, > > Guohuai > > Subject: Re: [PATCH 07/16] hw/9pfs:

Re: [PATCH v10 0/2] vhost-vdpa: add support for vIOMMU

2022-11-02 Thread Michael S. Tsirkin
On Mon, Oct 31, 2022 at 08:57:00PM +0800, Cindy Lu wrote: > changes in V3 > 1. Move function vfio_get_xlat_addr to memory.c > 2. Use the existing memory listener, while the MR is > iommu MR then call the function iommu_region_add/ > iommu_region_del > > changes in V4 > 1.make the comments in

Re: [PATCH 9/9] target/s390x: Use Int128 for passing float128

2022-11-02 Thread Ilya Leoshkevich
On Wed, Nov 02, 2022 at 08:47:24PM +1100, Richard Henderson wrote: > On 11/2/22 20:38, Ilya Leoshkevich wrote: > > On Fri, Oct 21, 2022 at 05:30:06PM +1000, Richard Henderson wrote: > > > Signed-off-by: Richard Henderson > > > --- > > > target/s390x/helper.h | 32 ++--- > > >

Re: [PATCH] s390x/tcg: Fix LDER instruction format

2022-11-02 Thread David Hildenbrand
On 02.11.22 10:43, Ilya Leoshkevich wrote: It's RRE, not RXE. Found by running valgrind's none/tests/s390x/bfp-2. Fixes: 86b59624c4aa ("s390x/tcg: Implement LOAD LENGTHENED short HFP to long HFP") Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/insn-data.def | 2 +- 1 file changed, 1

Re: [PATCH 9/9] target/s390x: Use Int128 for passing float128

2022-11-02 Thread Richard Henderson
On 11/2/22 20:38, Ilya Leoshkevich wrote: On Fri, Oct 21, 2022 at 05:30:06PM +1000, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/s390x/helper.h | 32 ++--- target/s390x/tcg/fpu_helper.c | 88 ++

[PATCH] s390x/tcg: Fix LDER instruction format

2022-11-02 Thread Ilya Leoshkevich
It's RRE, not RXE. Found by running valgrind's none/tests/s390x/bfp-2. Fixes: 86b59624c4aa ("s390x/tcg: Implement LOAD LENGTHENED short HFP to long HFP") Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/insn-data.def | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 9/9] target/s390x: Use Int128 for passing float128

2022-11-02 Thread Ilya Leoshkevich
On Fri, Oct 21, 2022 at 05:30:06PM +1000, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/s390x/helper.h | 32 ++--- > target/s390x/tcg/fpu_helper.c | 88 ++ > target/s390x/tcg/translate.c | 76

Re: [PATCH] block/blkio: Make driver nvme-io_uring take a "path" instead of a "filename"

2022-11-02 Thread Stefano Garzarella
On Sat, Oct 29, 2022 at 12:38:54AM +0100, Alberto Faria wrote: The nvme-io_uring driver expects a character special file such as /dev/ng0n1. Follow the convention of having a "filename" option when a regular file is expected, and a "path" option otherwise. This makes io_uring the only

[PATCH] target/i386: Fix test for paging enabled

2022-11-02 Thread Richard Henderson
If CR0.PG is unset, pg_mode will be zero, but that is not the only condition for which pg_mode will be zero. Restore the correct test for paging enabled. Fixes: 98281984a37 ("target/i386: Add MMU_PHYS_IDX and MMU_NESTED_IDX") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1269

Re: [PATCH] target/arm: Two fixes for secure ptw

2022-11-02 Thread Philippe Mathieu-Daudé
On 2/11/22 06:47, Richard Henderson wrote: Reversed the sense of non-secure in get_phys_addr_lpae, and failed to initialize attrs.secure for ARMMMUIdx_Phys_S. Fixes: 48da29e4 ("target/arm: Add ptw_idx to S1Translate") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1293 Thanks!

[PATCH 0/2] cryptodev: fix memory leak

2022-11-02 Thread Lei He
- Avoid using g_autoptr to free memory that not allocated in the same function. - Fix memory-leak when 'virtio_crypto_handle_request' returns no-zero value. - When error occurred, always pass negative status to function 'vritio_crypto_req_complete'. Lei He (2): cryptodev: avoid unreasonable use

[PATCH 2/2] cryptodev: fix memory-leak occurs on error path

2022-11-02 Thread Lei He
- Fix memory-leak when 'virtio_crypto_handle_request' returns non-zero value. - When error occurred, always pass negative status to function 'virtio_crypto_req_complete'. Signed-off-by: Lei He --- hw/virtio/virtio-crypto.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff

[PATCH 1/2] cryptodev: avoid unreasonable use of g_autoptr

2022-11-02 Thread Lei He
Avoid using g_autoptr to free memory that not allocated in the same function, just use g_free instead. Signed-off-by: Lei He --- hw/virtio/virtio-crypto.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/virtio/virtio-crypto.c b/hw/virtio/virtio-crypto.c

Re: [PATCH v7 7/7] hw/arm/virt: Add properties to disable high memory regions

2022-11-02 Thread Cornelia Huck
On Sun, Oct 30 2022, Gavin Shan wrote: > The 3 high memory regions are usually enabled by default, but they may > be not used. For example, VIRT_HIGH_GIC_REDIST2 isn't needed by GICv2. > This leads to waste in the PA space. > > Add properties ("highmem-redists", "highmem-ecam", "highmem-mmio")

[PATCH v2 1/6] i386: Introduce FeatureWordInfo for AMX CPUID leaf 0x1D and 0x1E

2022-11-02 Thread Wang, Lei
CPUID leaf 0x1D and 0x1E enumerate tile and TMUL information for AMX. Introduce FeatureWord FEAT_1D_1_EAX, FEAT_1D_1_EBX, FEAT_1D_1_ECX and FEAT_1E_0_EBX. Thus these features of AMX can be expanded when "-cpu host/max" and can be configured in named CPU model. Signed-off-by: Wang, Lei ---

[PATCH v2 5/6] i386: Initialize AMX CPUID leaves with corresponding env->features[] leaves

2022-11-02 Thread Wang, Lei
The AMX-related CPUID value, i.e., CPUID(0x1D,1):EAX, CPUID(0x1D,1):EBX, CPUID(0x1D,1):ECX and CPUID(0x1E,0):EBX are hard-coded to Sapphire Rapids without considering future platforms. Replace these hard-coded values with env->features[], so QEMU can pass the right value to KVM. Signed-off-by:

[PATCH v2 0/6] Support for new CPU model SapphireRapids

2022-11-02 Thread Wang, Lei
This series aims to add a new CPU model SapphireRapids, and tries to address the problem stated in https://lore.kernel.org/all/20220812055751.14553-1-lei4.w...@intel.com/T/#mcf67dbd1ad37c65d7988c36a2b267be9afd2fb30, so that named CPU model can define its own AMX values, and QEMU won't pass the

[PATCH v2 2/6] i386: Remove unused parameter "uint32_t bit" in feature_word_description()

2022-11-02 Thread Wang, Lei
Parameter "uint32_t bit" is not used in function feature_word_description(), so remove it. Signed-off-by: Wang, Lei --- target/i386/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index e98780773c..0083a2a7f7 100644 ---

[PATCH v2 4/6] i386: Mask and report unavailable multi-bit feature values

2022-11-02 Thread Wang, Lei
Some feature words, e.g., feature words in AMX-related CPUID leaf 0x1D and 0x1E are not bit-wise but multiple bits represents one value. Handle this situation when the values specified are not the same as which are reported by KVM. The handling includes: - The responsibility of masking bits and

[PATCH v2 3/6] i386: Introduce new struct "MultiBitFeatureInfo" for multi-bit features

2022-11-02 Thread Wang, Lei
Some features use multiple CPUID bits to form a value to be used, e.g., CPUID(0x1E,0):EBX[23:08] is regarded as the tmul_maxn value for AMX. Introduce a new struct "MultiBitFeatureInfo" to hold the information for those features and create a corresponding member in struct FeatureWordInfo, so that

[PATCH v2 1/6] i386: Introduce FeatureWordInfo for AMX CPUID leaf 0x1D and 0x1E

2022-11-02 Thread Wang, Lei
CPUID leaf 0x1D and 0x1E enumerate tile and TMUL information for AMX. Introduce FeatureWord FEAT_1D_1_EAX, FEAT_1D_1_EBX, FEAT_1D_1_ECX and FEAT_1E_0_EBX. Thus these features of AMX can be expanded when "-cpu host/max" and can be configured in named CPU model. Signed-off-by: Wang, Lei ---

[PATCH v2 0/6] Support for new CPU model SapphireRapids

2022-11-02 Thread Wang, Lei
This series aims to add a new CPU model SapphireRapids, and tries to address the problem stated in https://lore.kernel.org/all/20220812055751.14553-1-lei4.w...@intel.com/T/#mcf67dbd1ad37c65d7988c36a2b267be9afd2fb30, so that named CPU model can define its own AMX values, and QEMU won't pass the

[PATCH v2 6/6] i386: Add new CPU model SapphireRapids

2022-11-02 Thread Wang, Lei
The new CPU model mostly inherits features from Icelake-Server, while adding new features: - AMX (Advance Matrix eXtensions) - Bus Lock Debug Exception and new instructions: - AVX VNNI (Vector Neural Network Instruction): - VPDPBUS: Multiply and Add Unsigned and Signed Bytes -

[PULL 0/2] hw/nvme fixes

2022-11-02 Thread Klaus Jensen
From: Klaus Jensen Hi, The following changes since commit a11f65ec1b8adcb012b89c92819cbda4dc25aaf1: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2022-11-01 13:49:33 -0400) are available in the Git repository at: git://git.infradead.org/qemu-nvme.git

[PULL 2/2] hw/nvme: Abort copy command when format is one while pif

2022-11-02 Thread Klaus Jensen
From: Francis Pravin Antony Michael Raj As per the NVMe Command Set specification Section 3.2.2, if i) The namespace is formatted to use 16b Guard Protection Information (i.e., pif = 0) and ii) The Descriptor Format is not cleared to 0h Then the copy command should be aborted with

[PULL 1/2] hw/nvme: reenable cqe batching

2022-11-02 Thread Klaus Jensen
From: Klaus Jensen Commit 2e53b0b45024 ("hw/nvme: Use ioeventfd to handle doorbell updates") had the unintended effect of disabling batching of CQEs. This patch changes the sq/cq timers to bottom halfs and instead of calling nvme_post_cqes() immediately (causing an interrupt per cqe), we defer

Re: [PATCH v4 6/6] tests: acpi: aarch64: Add *.topology tables

2022-11-02 Thread wangyanan (Y)
On 2022/11/1 15:10, Yicong Yang wrote: From: Yicong Yang Add *.topology tables for the aarch64's topology test and empty bios-tables-test-allowed-diff.h The disassembled differences between actual and expected PPTT (the table which we actually care about): +/* + * Intel ACPI Component

Re: Re: [PATCH v2 1/4] virtio-crypto: Support asynchronous mode

2022-11-02 Thread Lei He
On 2022/11/2 03:51, Michael S. Tsirkin wrote: On Tue, Nov 01, 2022 at 06:37:26AM -0400, Michael S. Tsirkin wrote: On Sat, Oct 08, 2022 at 04:50:27PM +0800, Lei He wrote: virtio-crypto: Modify the current interface of virtio-crypto device to support asynchronous mode. Signed-off-by: lei he

Re: [PATCH v4 0/6] Only generate cluster node in PPTT when specified

2022-11-02 Thread Michael S. Tsirkin
On Tue, Nov 01, 2022 at 03:10:42PM +0800, Yicong Yang wrote: > From: Yicong Yang > > This series mainly change the policy for building a cluster topology node > in PPTT. Previously we'll always build a cluster node in PPTT without > asking the user, after this set the cluster node will be built

Re: [PATCH] hw/nvme: Abort copy command when format is one while pif is zero

2022-11-02 Thread Klaus Jensen
On Aug 25 22:53, Francis Pravin Antony Michael Raj wrote: > As per the NVMe command set specification section-3.2.2, > If: > i) The namespace is formatted to use 16b Guard Protection Information > (i.e., pif = 0) and > ii) The Descriptor Format is not cleared to 0h > Then the copy command

Re: [PATCH v3 0/4] Add a new backend for cryptodev

2022-11-02 Thread Michael S. Tsirkin
On Wed, Nov 02, 2022 at 04:02:09PM +0800, Lei He wrote: > v2 --> v3: > - Avoid using g_autoptr to free memory that not allocated in current > function. > - Fix memory-leak when 'virtio_crypto_handle_request' returns non-zero > value. > - When error occurred, always pass negative status to

[PATCH v3 4/4] cryptodev: Add a lkcf-backend for cryptodev

2022-11-02 Thread Lei He
cryptodev: Added a new type of backend named lkcf-backend for cryptodev. This backend upload asymmetric keys to linux kernel, and let kernel do the accelerations if possible. The lkcf stands for Linux Kernel Cryptography Framework. Signed-off-by: lei he Reviewed-by: Michael S. Tsirkin ---

[PATCH v3 0/4] Add a new backend for cryptodev

2022-11-02 Thread Lei He
v2 --> v3: - Avoid using g_autoptr to free memory that not allocated in current function. - Fix memory-leak when 'virtio_crypto_handle_request' returns non-zero value. - When error occurred, always pass negative status to function 'virtio_crypto_req_complete'. v1 --> v2: - Fix compile errors

[PATCH v3 3/4] crypto: Support export akcipher to pkcs8

2022-11-02 Thread Lei He
crypto: support export RSA private keys with PKCS#8 standard. So that users can upload this private key to linux kernel. Signed-off-by: lei he Reviewed-by: Michael S. Tsirkin Reviewed-by: Daniel P. Berrangé --- crypto/akcipher.c | 18 ++ crypto/rsakey.c | 42

[PATCH v3 2/4] crypto: Support DER encodings

2022-11-02 Thread Lei He
Add encoding interfaces for DER encoding: 1. support decoding of 'bit string', 'octet string', 'object id' and 'context specific tag' for DER encoder. 2. implemented a simple DER encoder. 3. add more testsuits for DER encoder. Signed-off-by: lei he Reviewed-by: Daniel P. Berrangé Reviewed-by:

[PATCH v3 1/4] virtio-crypto: Support asynchronous mode

2022-11-02 Thread Lei He
virtio-crypto: Modify the current interface of virtio-crypto device to support asynchronous mode. Signed-off-by: lei he Reviewed-by: Michael S. Tsirkin --- backends/cryptodev-builtin.c| 69 ++--- backends/cryptodev-vhost-user.c | 51 -- backends/cryptodev.c| 44

Re: [PATCH] hw/nvme: set DNR on compare failure

2022-11-02 Thread Klaus Jensen
On Aug 25 07:32, Klaus Jensen wrote: > From: Klaus Jensen > > Even if the host is somehow using compare to do compare-and-write, the > host should be notified immediately about the compare failure and not > have to wait for the driver to potentially retry the command. > > Reported-by: Jim

Re: [PATCH v4 5/6] tests: acpi: aarch64: Add topology test for aarch64

2022-11-02 Thread wangyanan (Y)
On 2022/11/1 15:10, Yicong Yang wrote: From: Yicong Yang Add test for aarch64's ACPI topology building for all the supported levels. Acked-by: Michael S. Tsirkin Signed-off-by: Yicong Yang --- tests/qtest/bios-tables-test.c | 19 +++ 1 file changed, 19 insertions(+)

Re: [PATCH v4 4/6] tests: acpi: Add and whitelist *.topology blobs

2022-11-02 Thread wangyanan (Y)
On 2022/11/1 15:10, Yicong Yang wrote: From: Yicong Yang Add and whitelist *.topology blobs, prepares for the aarch64's ACPI topology building test. Signed-off-by: Yicong Yang Reviewed-by: Yanan Wang Thanks, Yanan --- tests/data/acpi/virt/APIC.topology | 0

Re: [PATCH v4 3/6] tests: virt: Update expected ACPI tables for virt test

2022-11-02 Thread wangyanan (Y)
On 2022/11/1 15:10, Yicong Yang wrote: From: Yicong Yang Update the ACPI tables according to the acpi aml_build change, also empty bios-tables-test-allowed-diff.h. The disassembled differences between actual and expected PPTT: /* * Intel ACPI Component Architecture * AML/ASL+

Re: [PATCH v4 2/6] hw/acpi/aml-build: Only generate cluster node in PPTT when specified

2022-11-02 Thread wangyanan (Y)
On 2022/11/1 15:10, Yicong Yang wrote: From: Yicong Yang Currently we'll always generate a cluster node no matter user has specified '-smp clusters=X' or not. Cluster is an optional level and will participant the building of Linux scheduling domains and only appears on a few platforms. It's

Re: [PATCH RFC 2/4] hmp: Add "info netdev" cmd

2022-11-02 Thread Thomas Huth
On 31/10/2022 17.19, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Introduce "info netdev" command so developers can play with it easier. Signed-off-by: Hyman Huang(黄勇) --- hmp-commands-info.hx | 14 ++ include/monitor/hmp.h | 1 + net/net.c | 31

Re: [PATCH RFC 1/4] net: Introduce qmp cmd "query-netdev"

2022-11-02 Thread Thomas Huth
On 02/11/2022 06.42, Jason Wang wrote: On Tue, Nov 1, 2022 at 12:19 AM wrote: From: Hyman Huang(黄勇) For netdev device that can offload virtio-net dataplane to slave, such as vhost-net, vhost-user and vhost-vdpa, exporting it's capability information and acked features would be more friendly

Re: [PATCH 5/5] MAINTAINERS: Inherit from nanoMIPS

2022-11-02 Thread Thomas Huth
On 01/11/2022 12.44, Philippe Mathieu-Daudé wrote: 6 months ago Stefan Pejic stepped in as nanoMIPS maintainer (see commit a 8e0e23445a "target/mips: Undeprecate nanoMIPS ISA support in QEMU"), however today his email is bouncing: ** Message blocked ** Your message to

Re: [PATCH v4 1/6] tests: virt: Allow changes to PPTT test table

2022-11-02 Thread wangyanan (Y)
On 2022/11/1 15:10, Yicong Yang wrote: From: Yicong Yang Allow changes to test/data/acpi/virt/PPTT, prepare to change the building policy of the cluster topology. Signed-off-by: Yicong Yang Reviewed-by: Yanan Wang Thanks, Yanan --- tests/qtest/bios-tables-test-allowed-diff.h | 1 +

Re: [PATCH] tests/unit/test-io-channel-command: Silence GCC error "maybe-uninitialized"

2022-11-02 Thread Bin Meng
On Wed, Nov 2, 2022 at 5:41 AM Bernhard Beschow wrote: > > GCC issues a false positive warning, resulting in build failure with -Werror: > > In file included from /usr/lib/glib-2.0/include/glibconfig.h:9, >from /usr/include/glib-2.0/glib/gtypes.h:34, >

Re: [PATCH v4 4/4] hw/usb: fix tab indentation

2022-11-02 Thread Thomas Huth
On 31/10/2022 20.10, Amarjargal Gundjalam wrote: On 26/10/22 00:22, Thomas Huth wrote: On 25/10/2022 16.28, Amarjargal Gundjalam wrote: The TABs should be replaced with spaces, to make sure that we have a consistent coding style with an indentation of 4 spaces everywhere. Resolves:

<    1   2   3   >