Re: [PATCH] vhost: Not return fail while the device does not support send_iotlb_msg

2022-12-02 Thread Cindy Lu
On Thu, 1 Dec 2022 at 16:49, Jason Wang wrote: > > On Wed, Nov 30, 2022 at 4:11 PM Cindy Lu wrote: > > > > Some device does not support vhost_send_device_iotlb_msg() > > such as vDPA device, which is as expected. So we should not > > return fail here. > > Please explain in which case you may hit

[PATCH 0/3] python: testing fixes

2022-12-02 Thread John Snow
A few tiny touchups needed for cutting edge 'flake8' tooling, a minor type touchup in iotests, and extending the python tests to cover the recently released Python 3.11. John Snow (3): Python: fix flake8 config iotests/check: Fix typing for sys.exit() value python: add 3.11 to supported

[PATCH 1/3] Python: fix flake8 config

2022-12-02 Thread John Snow
Newer flake8 versions are a bit pickier about the config file, and my in-line comment confuses the parser. Fix it. Signed-off-by: John Snow --- python/setup.cfg | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/python/setup.cfg b/python/setup.cfg index

[PATCH 2/3] iotests/check: Fix typing for sys.exit() value

2022-12-02 Thread John Snow
Signed-off-by: John Snow --- tests/qemu-iotests/check | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check index 75de1b4691e..9bdda1394e7 100755 --- a/tests/qemu-iotests/check +++ b/tests/qemu-iotests/check @@ -159,7 +159,7 @@ if

[PATCH 3/3] python: add 3.11 to supported list

2022-12-02 Thread John Snow
Signed-off-by: John Snow --- python/setup.cfg | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/python/setup.cfg b/python/setup.cfg index c0d7bab168e..56418157065 100644 --- a/python/setup.cfg +++ b/python/setup.cfg @@ -19,6 +19,7 @@ classifiers = Programming Language ::

Re: [PATCH] qemu/machine: add asyncio process-management demo

2022-12-02 Thread John Snow
On Fri, Dec 2, 2022 at 3:57 PM John Snow wrote: > > This is just an RFC to show a technique for how to watch terminal input > using asyncio. This is just a *demo* and elides many things for > simplicity; namely I don't create a QMP monitor nor a guest console > socket. > > What I really wanted

Re: [PATCH v2 for-8.0] target/s390x/tcg: Fix and improve the SACF instruction

2022-12-02 Thread Ilya Leoshkevich
On Thu, 2022-12-01 at 19:44 +0100, Thomas Huth wrote: > The SET ADDRESS SPACE CONTROL FAST instruction is not privileged, it > can be > used from problem space, too. Just the switching to the home address > space > is privileged and should still generate a privilege exception. This > bug is > e.g.

Re: [QEMU][PATCH v2 10/11] hw/arm: introduce xenpv machine

2022-12-02 Thread Stefano Stabellini
On Fri, 2 Dec 2022, Vikram Garhwal wrote: > On 12/2/22 6:52 AM, Alex Bennée wrote: > > Vikram Garhwal writes: > > > > > Add a new machine xenpv which creates a IOREQ server to register/connect > > > with > > > Xen Hypervisor. > > > > > > Optional: When CONFIG_TPM is enabled, it also creates a

Re: [QEMU][PATCH v2 10/11] hw/arm: introduce xenpv machine

2022-12-02 Thread Vikram Garhwal
Hi Alex, On 12/2/22 6:52 AM, Alex Bennée wrote: Vikram Garhwal writes: Add a new machine xenpv which creates a IOREQ server to register/connect with Xen Hypervisor. Optional: When CONFIG_TPM is enabled, it also creates a tpm-tis-device, adds a TPM emulator and connects to swtpm running on

Re: [QEMU][PATCH v2 05/11] include/hw/xen/xen_common: return error from xen_create_ioreq_server

2022-12-02 Thread Stefano Stabellini
On Fri, 1 Dec 2022, Philippe Mathieu-Daudé wrote: > On 2/12/22 08:19, Philippe Mathieu-Daudé wrote: > > Hi Stefano and Vikram, > > > > On 2/12/22 03:59, Vikram Garhwal wrote: > > > From: Stefano Stabellini > > > > > > This is done to prepare for enabling xenpv support for ARM architecture. > >

[PATCH] qemu/machine: add asyncio process-management demo

2022-12-02 Thread John Snow
This is just an RFC to show a technique for how to watch terminal input using asyncio. This is just a *demo* and elides many things for simplicity; namely I don't create a QMP monitor nor a guest console socket. What I really wanted feedback on was an API for consuming information from an async

Re: [PATCH] .gitlab/issue_templates: Move suggestions into comments

2022-12-02 Thread John Snow
On Thu, Dec 1, 2022 at 8:38 AM Thomas Huth wrote: > > Many users forget to remove the suggestions from the bug template > when creating a new issue. So when searching for strings like "s390x" > or "Windows", you get a lot of unrelated issues in the results. > Thus let's move the suggestions into

[PATCH 0/5] Update AMD EPYC CPU Models

2022-12-02 Thread Babu Moger
This series adds following changes. a. Allow versioned CPUs to specify new cache_info pointers. b. Add EPYC-v4, EPYC-Rome-v3 and EPYC-Milan-v2 fixing the cache_info.complex_indexing. c. Introduce EPYC-Milan-v2 by adding few missing feature bits. --- Babu Moger (3): target/i386: Add a

[PATCH 3/5] target/i386: Add a couple of feature bits in 8000_0008_EBX

2022-12-02 Thread Babu Moger
Add the following feature bits. amd-psfd : Predictive Store Forwarding Disable: PSF is a hardware-based micro-architectural optimization designed to improve the performance of code execution by predicting address dependencies between loads and stores.

[PATCH 4/5] target/i386: Add feature bits for CPUID_Fn80000021_EAX

2022-12-02 Thread Babu Moger
Add the following feature bits. no-nested-data-bp : Processor ignores nested data breakpoints. lfence-always-serializing : LFENCE instruction is always serializing. null-select-clears-base : Null Selector Clears Base. When this bit is set, a null segment load

[PATCH 2/5] target/i386: Add new EPYC CPU versions with updated cache_info

2022-12-02 Thread Babu Moger
From: Michael Roth Introduce new EPYC cpu versions: EPYC-v4 and EPYC-Rome-v3. The only difference vs. older models is an updated cache_info with the 'complex_indexing' bit unset, since this bit is not currently defined for AMD and may cause problems should it be used for something else in the

[PATCH 1/5] target/i386: allow versioned CPUs to specify new cache_info

2022-12-02 Thread Babu Moger
From: Michael Roth New EPYC CPUs versions require small changes to their cache_info's. Because current QEMU x86 CPU definition does not support cache versions, we would have to declare a new CPU type for each such case. To avoid this duplication, the patch allows new cache_info pointers to be

[PATCH 5/5] target/i386: Add missing feature bits in EPYC-Milan model

2022-12-02 Thread Babu Moger
And the following feature bits for EPYC-Milan model and bump the version. vaes: Vector VAES(ENC|DEC), VAES(ENC|DEC)LAST instruction support vpclmulqdq : Vector VPCLMULQDQ instruction support stibp-always-on : Single Thread Indirect Branch Prediction Mode has enhanced

Re: [RFC PATCH for 8.0] configure: repeat ourselves for the benefit of CI

2022-12-02 Thread Philippe Mathieu-Daudé
On 2/12/22 18:47, Alex Bennée wrote: Our CI system echos the lines it executes but not the expansions. For the sake of a line of extra verbosity during the configure phase lets echo the invocation of script to stdout as well as the log. Signed-off-by: Alex Bennée --- configure | 7 ---

Re: [QEMU][PATCH v2 07/11] hw/xen/xen-hvm-common: Use g_new and error_setg_errno

2022-12-02 Thread Vikram Garhwal
Hi Markus & Philippe, Thanks for reviewing this one. Please see the question below. On 12/2/22 12:53 AM, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 2/12/22 03:59, Vikram Garhwal wrote: Replace g_malloc with g_new and perror with error_setg_errno. Signed-off-by: Vikram

[RFC PATCH for 8.0] configure: repeat ourselves for the benefit of CI

2022-12-02 Thread Alex Bennée
Our CI system echos the lines it executes but not the expansions. For the sake of a line of extra verbosity during the configure phase lets echo the invocation of script to stdout as well as the log. Signed-off-by: Alex Bennée --- configure | 7 --- 1 file changed, 4 insertions(+), 3

[PATCH] ui/vnc.c: Allow websocket connections over AF_UNIX sockets

2022-12-02 Thread Pierre-Yves Ritschard
Hi, The provided patch allows the VNC websocket server of a qemu process to be provided over AF_UNIX as it is already possible for standard TCP VNC servers. Now that many clients support websocket connections, some exclusively, it can be useful to expose the VNC server. One such case is when a

Re: [RFC PATCH] test-bdrv-drain: keep graph manipulations out of coroutines

2022-12-02 Thread Paolo Bonzini
On 12/2/22 14:42, Emanuele Giuseppe Esposito wrote: Am 02/12/2022 um 14:27 schrieb Paolo Bonzini: Changes to the BlockDriverState graph will have to take the corresponding lock for writing, and therefore cannot be done inside a coroutine. Move them outside the test body. Signed-off-by:

Re: [PATCH v2 for-8.0] hw/misc: Move some arm-related files from specific_ss into softmmu_ss

2022-12-02 Thread Philippe Mathieu-Daudé
On 2/12/22 16:40, Thomas Huth wrote: The header arget/arm/kvm-consts.h checks CONFIG_KVM which is marked as typo "target" poisoned in common code, so the files that include this header have to be added to specific_ss and recompiled for each, qemu-system-arm and qemu-system-aarch64. However,

[PATCH v2 for-8.0] hw/misc: Move some arm-related files from specific_ss into softmmu_ss

2022-12-02 Thread Thomas Huth
The header arget/arm/kvm-consts.h checks CONFIG_KVM which is marked as poisoned in common code, so the files that include this header have to be added to specific_ss and recompiled for each, qemu-system-arm and qemu-system-aarch64. However, since the kvm headers are only optionally used in

Re: [PATCH v15 1/6] qmp: add QMP command x-query-virtio

2022-12-02 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 2/12/22 13:23, Jonah Palmer wrote: >> On 11/30/22 11:16, Philippe Mathieu-Daudé wrote: >>> Hi, >>> >>> On 11/8/22 14:24, Jonah Palmer wrote: From: Laurent Vivier This new command lists all the instances of VirtIODevices with their

Re: [PATCH v2 10/14] ui: Factor out qmp_add_client() parts and move to ui/ui-qmp-cmds.c

2022-12-02 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 2/12/22 11:05, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> include/monitor/qmp-helpers.h | 26 >> monitor/qmp-cmds.c| 74 --- >> ui/ui-qmp-cmds.c | 41

Re: [QEMU][PATCH v2 10/11] hw/arm: introduce xenpv machine

2022-12-02 Thread Alex Bennée
Vikram Garhwal writes: > Add a new machine xenpv which creates a IOREQ server to register/connect with > Xen Hypervisor. > > Optional: When CONFIG_TPM is enabled, it also creates a tpm-tis-device, adds a > TPM emulator and connects to swtpm running on host machine via chardev socket > and

Re: [QEMU][PATCH v2 10/11] hw/arm: introduce xenpv machine

2022-12-02 Thread Alex Bennée
Vikram Garhwal writes: > Add a new machine xenpv which creates a IOREQ server to register/connect with > Xen Hypervisor. > > Optional: When CONFIG_TPM is enabled, it also creates a tpm-tis-device, adds a > TPM emulator and connects to swtpm running on host machine via chardev socket > and

Re: [PATCH v3 2/3] KVM: keep track of running ioctls

2022-12-02 Thread Emanuele Giuseppe Esposito
Am 02/12/2022 um 14:32 schrieb Robert Hoo: > On Fri, 2022-12-02 at 13:03 +0100, Emanuele Giuseppe Esposito wrote: > ... @@ -3032,7 +3035,9 @@ int kvm_vcpu_ioctl(CPUState *cpu, int type, ...) va_end(ap); trace_kvm_vcpu_ioctl(cpu->cpu_index, type, arg); +

Re: [PATCH for-8.0] hw/misc: Move some arm-related files from specific_ss into softmmu_ss

2022-12-02 Thread Thomas Huth
On 02/12/2022 13.25, Thomas Huth wrote: On 01/12/2022 12.55, Peter Maydell wrote: On Wed, 30 Nov 2022 at 11:16, Thomas Huth wrote: By removing #include "kvm-consts.h" from arm-powerctl.h (seems not to be required there) and adjusting the header includes in some files, we can move them from

Re: [PATCH v12 6/7] s390x/cpu_topology: activating CPU topology

2022-12-02 Thread Thomas Huth
On 02/12/2022 15.08, Pierre Morel wrote: On 12/2/22 10:05, Thomas Huth wrote: On 01/12/2022 12.52, Pierre Morel wrote: On 12/1/22 11:15, Thomas Huth wrote: On 29/11/2022 18.42, Pierre Morel wrote: The KVM capability, KVM_CAP_S390_CPU_TOPOLOGY is used to activate the

Re: [PATCH v15 1/6] qmp: add QMP command x-query-virtio

2022-12-02 Thread Philippe Mathieu-Daudé
On 2/12/22 13:23, Jonah Palmer wrote: On 11/30/22 11:16, Philippe Mathieu-Daudé wrote: Hi, On 11/8/22 14:24, Jonah Palmer wrote: From: Laurent Vivier This new command lists all the instances of VirtIODevices with their canonical QOM path and name. [Jonah: @virtio_list duplicates

Re: [PATCH v12 6/7] s390x/cpu_topology: activating CPU topology

2022-12-02 Thread Pierre Morel
On 12/2/22 10:05, Thomas Huth wrote: On 01/12/2022 12.52, Pierre Morel wrote: On 12/1/22 11:15, Thomas Huth wrote: On 29/11/2022 18.42, Pierre Morel wrote: The KVM capability, KVM_CAP_S390_CPU_TOPOLOGY is used to activate the S390_FEAT_CONFIGURATION_TOPOLOGY feature and the topology

Re: regression: insmod module failed in VM with nvdimm on

2022-12-02 Thread Ard Biesheuvel
On Fri, 2 Dec 2022 at 03:48, chenxiang (M) wrote: > > Hi Ard, > > > 在 2022/12/1 19:07, Ard Biesheuvel 写道: > > On Thu, 1 Dec 2022 at 09:07, Ard Biesheuvel wrote: > >> On Thu, 1 Dec 2022 at 08:15, chenxiang (M) > >> wrote: > >>> Hi Ard, > >>> > >>> > >>> 在 2022/11/30 16:18, Ard Biesheuvel 写道: >

Re: [PATCH v9 1/8] mm: Introduce memfd_restricted system call to create restricted user memory

2022-12-02 Thread Kirill A . Shutemov
On Fri, Dec 02, 2022 at 02:49:09PM +0800, Chao Peng wrote: > On Thu, Dec 01, 2022 at 06:16:46PM -0800, Vishal Annapurve wrote: > > On Tue, Oct 25, 2022 at 8:18 AM Chao Peng > > wrote: > > > > ... > > > +} > > > + > > > +SYSCALL_DEFINE1(memfd_restricted, unsigned int, flags) > > > +{ > > > >

Re: [RFC PATCH] test-bdrv-drain: keep graph manipulations out of coroutines

2022-12-02 Thread Emanuele Giuseppe Esposito
Am 02/12/2022 um 14:27 schrieb Paolo Bonzini: > Changes to the BlockDriverState graph will have to take the > corresponding lock for writing, and therefore cannot be done > inside a coroutine. Move them outside the test body. > > Signed-off-by: Paolo Bonzini > --- >

Re: [PATCH v3 2/3] KVM: keep track of running ioctls

2022-12-02 Thread Robert Hoo
On Fri, 2022-12-02 at 13:03 +0100, Emanuele Giuseppe Esposito wrote: ... > > > @@ -3032,7 +3035,9 @@ int kvm_vcpu_ioctl(CPUState *cpu, int type, > > > ...) > > > va_end(ap); > > > > > > trace_kvm_vcpu_ioctl(cpu->cpu_index, type, arg); > > > +accel_cpu_ioctl_begin(cpu); > > > >

Re: [PATCH] tests/qtest/vhost-user-blk-test: don't abort all qtests on missing envar

2022-12-02 Thread Thomas Huth
On 01/12/2022 12.03, Thomas Huth wrote: On 25/11/2022 16.58, Christian Schoenebeck wrote: This test requires environment variable QTEST_QEMU_STORAGE_DAEMON_BINARY to be defined for running. If not, it would immediately abort all qtests and prevent other, unrelated tests from running. To fix

[RFC PATCH] test-bdrv-drain: keep graph manipulations out of coroutines

2022-12-02 Thread Paolo Bonzini
Changes to the BlockDriverState graph will have to take the corresponding lock for writing, and therefore cannot be done inside a coroutine. Move them outside the test body. Signed-off-by: Paolo Bonzini --- tests/unit/test-bdrv-drain.c | 63 ++-- 1 file changed,

[RFC PATCH for 8.0] backends/vhost-user: relax the ioeventfd check

2022-12-02 Thread Alex Bennée
While you certainly need ioeventfds to work for KVM guests it shouldn't be limited to that. We can run vhost-user backends for TCG guests and either use ioeventfds or in band signalling. Maybe we should apply the same fix as b0aa77d36d (vhost-user: fix ioeventfd_enabled)? With this change I can

Re: [PATCH v2 for-8.0] target/s390x/tcg: Fix and improve the SACF instruction

2022-12-02 Thread David Hildenbrand
On 01.12.22 19:44, Thomas Huth wrote: The SET ADDRESS SPACE CONTROL FAST instruction is not privileged, it can be used from problem space, too. Just the switching to the home address space is privileged and should still generate a privilege exception. This bug is e.g. causing programs like Java

Re: [PATCH v2] softmmu/physmem: Fix address of FlatView access in address_space_(read|write)_cached_slow()

2022-12-02 Thread Alberto Faria
On Mon, Sep 5, 2022 at 8:45 AM Paolo Bonzini wrote: > Thanks, I will queue it. > > Paolo > > Il lun 5 set 2022, 02:00 Alberto Faria ha scritto: >> >> flatview_(read|write)_continue() must be called with an address in the >> FlatView's address space, but `addr` is relative to the >>

Re: [PATCH for-8.0] hw/misc: Move some arm-related files from specific_ss into softmmu_ss

2022-12-02 Thread Thomas Huth
On 01/12/2022 12.55, Peter Maydell wrote: On Wed, 30 Nov 2022 at 11:16, Thomas Huth wrote: By removing #include "kvm-consts.h" from arm-powerctl.h (seems not to be required there) and adjusting the header includes in some files, we can move them from specific_ss into softmmu_ss, so that they

Re: [PATCH v15 1/6] qmp: add QMP command x-query-virtio

2022-12-02 Thread Jonah Palmer
On 11/30/22 11:16, Philippe Mathieu-Daudé wrote: Hi, On 11/8/22 14:24, Jonah Palmer wrote: From: Laurent Vivier This new command lists all the instances of VirtIODevices with their canonical QOM path and name. [Jonah: @virtio_list duplicates information that already exists in   the QOM

Re: [PATCH v3 2/3] KVM: keep track of running ioctls

2022-12-02 Thread Emanuele Giuseppe Esposito
Am 02/12/2022 um 07:54 schrieb Robert Hoo: > On Fri, 2022-11-11 at 10:47 -0500, Emanuele Giuseppe Esposito wrote: >> Using the new accel-blocker API, mark where ioctls are being called >> in KVM. Next, we will implement the critical section that will take >> care of performing memslots

Re: [PATCH v2 10/14] ui: Factor out qmp_add_client() parts and move to ui/ui-qmp-cmds.c

2022-12-02 Thread Philippe Mathieu-Daudé
On 2/12/22 11:05, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- include/monitor/qmp-helpers.h | 26 monitor/qmp-cmds.c| 74 --- ui/ui-qmp-cmds.c | 41 +++ 3 files changed, 100

Re: [QEMU][PATCH v2 05/11] include/hw/xen/xen_common: return error from xen_create_ioreq_server

2022-12-02 Thread Philippe Mathieu-Daudé
On 2/12/22 08:19, Philippe Mathieu-Daudé wrote: Hi Stefano and Vikram, On 2/12/22 03:59, Vikram Garhwal wrote: From: Stefano Stabellini This is done to prepare for enabling xenpv support for ARM architecture. On ARM it is possible to have a functioning xenpv machine with only the PV backends

[PULL for 7.2-rc4 0/1] loongarch for 7.2-rc4 patch

2022-12-02 Thread Song Gao
The following changes since commit c4ffd91aba1c3d878e99a3e7ba8aad4826728ece: Update VERSION for v7.2.0-rc3 (2022-11-29 18:15:26 -0500) are available in the Git repository at: https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20221202 for you to fetch changes up

[PULL for 7.2-rc4 1/1] hw/loongarch/virt: Add cfi01 pflash device

2022-12-02 Thread Song Gao
From: Xiaojuan Yang Add cfi01 pflash device for LoongArch virt machine Signed-off-by: Xiaojuan Yang Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20221130100647.398565-1-yangxiaoj...@loongson.cn> Signed-off-by: Song Gao --- hw/loongarch/Kconfig| 1 + hw/loongarch/acpi-build.c

Re: [PATCH v2 09/14] ui: Move QMP commands from monitor to new ui/ui-qmp-cmds.c

2022-12-02 Thread Philippe Mathieu-Daudé
On 2/12/22 11:05, Markus Armbruster wrote: This moves these commands from MAINTAINERS section "Human Monitor (HMP)" to "Graphics". Command add-client applies to socket character devices in addition to display devices. Move it anyway. Aside: the way @protocol character device IDs and display

Re: [PATCH v2 06/14] ui/spice: QXLInterface method set_mm_time() is now dead, drop

2022-12-02 Thread Philippe Mathieu-Daudé
On 2/12/22 11:05, Markus Armbruster wrote: SPICE_NEEDS_SET_MM_TIME is now always off. Bury the dead code. Signed-off-by: Markus Armbruster --- include/ui/qemu-spice.h | 2 -- hw/display/qxl.c| 19 --- ui/spice-display.c | 10 --

Re: [PATCH v2 05/14] ui/spice: Require spice-server >= 0.14.0

2022-12-02 Thread Philippe Mathieu-Daudé
On 2/12/22 11:05, Markus Armbruster wrote: Version 0.14.0 is now old enough to have made it into the major distributions: Debian 11: 0.14.3 RHEL-8: 0.14.3 FreeBSD (ports): 0.15.0 Fedora 35: 0.15.0 Ubuntu 20.04: 0.14.2 OpenSUSE Leap 15.3: 0.14.3 Requiring it

Re: [PATCH v2 03/14] ui/spice: Require spice-protocol >= 0.14.0

2022-12-02 Thread Philippe Mathieu-Daudé
On 2/12/22 11:05, Markus Armbruster wrote: Version 0.14.0 is now old enough to have made it into the major distributions: Debian 11: 0.14.3 RHEL-8: 0.14.2 FreeBSD (ports): 0.14.4 Fedora 35: 0.14.0 Ubuntu 20.04: 0.14.0 OpenSUSE Leap 15.3: 0.14.3 Requiring it lets us drop

Re: [PATCH v2 07/14] ui/spice: Give hmp_info_spice()'s channel_names[] static linkage

2022-12-02 Thread Philippe Mathieu-Daudé
On 2/12/22 11:05, Markus Armbruster wrote: Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- monitor/hmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, Reviewed-by: Philippe Mathieu-Daudé

[PATCH v2 06/14] ui/spice: QXLInterface method set_mm_time() is now dead, drop

2022-12-02 Thread Markus Armbruster
SPICE_NEEDS_SET_MM_TIME is now always off. Bury the dead code. Signed-off-by: Markus Armbruster --- include/ui/qemu-spice.h | 2 -- hw/display/qxl.c| 19 --- ui/spice-display.c | 10 -- hw/display/trace-events | 1 - 4 files changed, 32 deletions(-) diff

[PATCH v2 09/14] ui: Move QMP commands from monitor to new ui/ui-qmp-cmds.c

2022-12-02 Thread Markus Armbruster
This moves these commands from MAINTAINERS section "Human Monitor (HMP)" to "Graphics". Command add-client applies to socket character devices in addition to display devices. Move it anyway. Aside: the way @protocol character device IDs and display types is bad design. Signed-off-by: Markus

[PATCH v2 11/14] ui: Move HMP commands from monitor to new ui/ui-hmp-cmds.c

2022-12-02 Thread Markus Armbruster
This moves these commands from MAINTAINERS section "Human Monitor (HMP)" to "Graphics". Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé --- monitor/hmp-cmds.c | 343 -- ui/ui-hmp-cmds.c | 361

[PATCH v2 10/14] ui: Factor out qmp_add_client() parts and move to ui/ui-qmp-cmds.c

2022-12-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- include/monitor/qmp-helpers.h | 26 monitor/qmp-cmds.c| 74 --- ui/ui-qmp-cmds.c | 41 +++ 3 files changed, 100 insertions(+), 41 deletions(-) create mode 100644

[PATCH v2 13/14] ui: Factor out hmp_change_vnc(), and move to ui/ui-hmp-cmds.c

2022-12-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé --- include/monitor/hmp.h | 5 + monitor/hmp-cmds.c| 28 +--- ui/ui-hmp-cmds.c | 35 ++- 3 files changed, 40 insertions(+), 28 deletions(-) diff --git

[PATCH v2 12/14] ui: Improve "change vnc" error reporting

2022-12-02 Thread Markus Armbruster
Switch from monitor_printf() to error_setg() and hmp_handle_error(). This makes "this is an error" more obvious both in the source and in the monitor, where hmp_handle_error() prefixes the message with "Error: ". Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé ---

[PATCH v2 07/14] ui/spice: Give hmp_info_spice()'s channel_names[] static linkage

2022-12-02 Thread Markus Armbruster
Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- monitor/hmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 7360ed71a6..8eb9c19b3a 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@

[PATCH v2 01/14] ui: Check numeric part of expire_password argument @time properly

2022-12-02 Thread Markus Armbruster
When argument @time isn't 'now' or 'never', we parse it as an integer, optionally prefixed with '+'. If parsing fails, we silently assume zero. Report an error and fail instead. While there, use qemu_strtou64() instead of strtoull() so checkpatch.pl won't complain. Aside: encoding numbers in

[PATCH v2 04/14] Revert "hmp: info spice: take out webdav"

2022-12-02 Thread Markus Armbruster
This reverts commit 7c6044a94e52db8aef9a71d616c7a0914adb71ab. We had to take it out because SPICE_CHANNEL_WEBDAV requires spice-protocol 0.12.7, but we had only 0.12.3. We have 0.14.0 now, so put it back in. Signed-off-by: Markus Armbruster --- monitor/hmp-cmds.c | 5 - 1 file changed, 5

[PATCH v2 14/14] ui: Reduce nesting in hmp_change_vnc() slightly

2022-12-02 Thread Markus Armbruster
Transform if (good) { do stuff } else { handle error } to if (!good) { handle error return; } do stuff Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé --- ui/ui-hmp-cmds.c | 17

[PATCH v2 05/14] ui/spice: Require spice-server >= 0.14.0

2022-12-02 Thread Markus Armbruster
Version 0.14.0 is now old enough to have made it into the major distributions: Debian 11: 0.14.3 RHEL-8: 0.14.3 FreeBSD (ports): 0.15.0 Fedora 35: 0.15.0 Ubuntu 20.04: 0.14.2 OpenSUSE Leap 15.3: 0.14.3 Requiring it lets us drop a number of version checks. The next

[PATCH v2 08/14] ui: Clean up a few things checkpatch.pl would flag later on

2022-12-02 Thread Markus Armbruster
Fix a few style violations so that checkpatch.pl won't complain when I move this code. Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé --- monitor/hmp-cmds.c | 7 --- monitor/qmp-cmds.c | 21 +++-- 2 files changed, 15 insertions(+), 13 deletions(-) diff

[PATCH v2 02/14] ui: Fix silent truncation of numeric keys in HMP sendkey

2022-12-02 Thread Markus Armbruster
Keys are int. HMP sendkey assigns them from the value strtoul(), silently truncating values greater than INT_MAX. Fix to reject them. While there, use qemu_strtoul() instead of strtoul() so checkpatch.pl won't complain. Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé ---

[PATCH v2 03/14] ui/spice: Require spice-protocol >= 0.14.0

2022-12-02 Thread Markus Armbruster
Version 0.14.0 is now old enough to have made it into the major distributions: Debian 11: 0.14.3 RHEL-8: 0.14.2 FreeBSD (ports): 0.14.4 Fedora 35: 0.14.0 Ubuntu 20.04: 0.14.0 OpenSUSE Leap 15.3: 0.14.3 Requiring it lets us drop two version checks in ui/vdagent.c. It also

[PATCH v2 00/14] ui: Move and clean up monitor command code

2022-12-02 Thread Markus Armbruster
This is mainly about splitting off monitor-related code. There's also a minimum Spice version bump, and a few UI improvements to HMP commands sendkey, change vnc, and info spice. v2: * PATCH 03,05-06: New [Daniel] * PATCH 04: Enable instead of drop channel type "webdav" [Daniel] * PATCH 07: New

Re: [PATCH v1 10/12] hw/arm: introduce xenpv machine

2022-12-02 Thread Julien Grall
On 02/12/2022 03:24, Garhwal, Vikram wrote: Hi Julien, Hi Vikram, I am having trouble to differentiate your answers from my remark. For instance... From: Julien Grall Date: Sunday, October 16, 2022 at 10:48 AM To: Garhwal, Vikram , qemu-devel@nongnu.org Cc: Stabellini, Stefano ,

tests/qtest: Is vnc-display-test supposed to work on Darwin?

2022-12-02 Thread Philippe Mathieu-Daudé
Hi, The vnc-display-test is failing on Darwin: tests/qtest/vnc-display-test:45038): ERROR **: 10:42:35.488: vnc-error: Unsupported auth type 17973672 Is it supposed to pass, or should we skip it similarly to Windows? Thanks, Phil.

Re: [PATCH v3 02/34] meson: Move CONFIG_TCG_INTERPRETER to config_host

2022-12-02 Thread Paolo Bonzini
On 12/2/22 06:39, Richard Henderson wrote: Like CONFIG_TCG, the enabled method of execution is a host property not a guest property. This exposes the define to compile-once files. Acked-by: Paolo Bonzini Paolo Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson ---

Re: [PATCH] blockdev: add 'media=cdrom' argument to support usb cdrom emulated as cdrom

2022-12-02 Thread Paolo Bonzini
On 12/2/22 03:26, Zhipeng Lu wrote: NAME  MAJ:MIN RM  SIZE RO TYPE MOUNTPOINT sda 8:0    0  100M  1 disk vda   252:0    0   10G  0 disk ├─vda1    252:1    0    1G  0 part /boot └─vda2    252:2    0    9G  0 part   ├─rhel-root 253:0    0    8G  0 lvm  /  

Re: [PATCH v12 6/7] s390x/cpu_topology: activating CPU topology

2022-12-02 Thread Thomas Huth
On 01/12/2022 12.52, Pierre Morel wrote: On 12/1/22 11:15, Thomas Huth wrote: On 29/11/2022 18.42, Pierre Morel wrote: The KVM capability, KVM_CAP_S390_CPU_TOPOLOGY is used to activate the S390_FEAT_CONFIGURATION_TOPOLOGY feature and the topology facility for the guest in the case the

Re: [QEMU][PATCH v2 07/11] hw/xen/xen-hvm-common: Use g_new and error_setg_errno

2022-12-02 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 2/12/22 03:59, Vikram Garhwal wrote: >> Replace g_malloc with g_new and perror with error_setg_errno. >> >> Signed-off-by: Vikram Garhwal >> --- >> hw/xen/xen-hvm-common.c | 15 --- >> 1 file changed, 8 insertions(+), 7 deletions(-) > > >> @@